1 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3 * keyboard.c (read_key_sequence_remapped): New var.
4 (read_key_sequence): Compute remapping in the right buffer.
5 (command_loop_1): Use read_key_sequence's remapping directly.
7 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
9 * dired.c (file_name_completion): Don't expand file name.
10 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
11 before checking file name handler.
13 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
14 they've been requested explicitly (bug#9591).
16 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
18 * keymap.c (Fsingle_key_description): Use make_specified_string
19 instead of build_string to build string from push_key_description.
22 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
24 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
25 This fixes a Y2038 bug on 64-bit hosts.
26 * buffer.c (reset_buffer):
27 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
28 (Fclear_buffer_auto_save_failure):
29 Use 0, not -1, to represent an unset failure time, since time_t
32 Remove dependency on glibc malloc internals.
33 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
34 Move back here from lisp.h, but with their new implementations.
35 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
36 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
37 * charset.c (charset_table_init): New static var.
38 (syms_of_charset): Use it instead of xmalloc. This removes a
39 dependency on glibc malloc internals. See Eli Zaretskii's comment in
40 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
41 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
43 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
44 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
46 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
48 * nsterm.m (windowDidResize): Call x_set_window_size only when
49 ns_in_resize is true. Otherwise set pixelwidth/height and
50 call change_frame_size (Bug#9628).
52 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
54 Port --enable-checking=all to Fedora 14 x86-64.
55 * charset.c (syms_of_charset): Also account for glibc malloc's
56 internal overhead when calculating the initial malloc maximum.
58 Port --enable-checking=all to Fedora 14 x86.
59 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
61 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
62 (overrun_check_realloc, overrun_check_free):
63 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
64 That way, xmalloc returns a properly-aligned pointer even if
65 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
66 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
67 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
68 into account when calculating the initial malloc maximum.
69 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
70 Move here from alloc.c, so that charset.c can use it too.
71 Properly align; the old code wasn't right for common 32-bit hosts
72 when configured with --enable-checking=all.
73 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
74 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
76 2011-09-29 Eli Zaretskii <eliz@gnu.org>
78 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
81 2011-09-28 Eli Zaretskii <eliz@gnu.org>
83 * xdisp.c (compute_display_string_end): If there's no display
84 string at CHARPOS, return -1.
86 * bidi.c (bidi_fetch_char): When compute_display_string_end
87 returns a negative value, treat the character as a normal
88 character not covered by a display string. (Bug#9624)
90 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
92 * lread.c (Fread_from_string): Fix typo in docstring.
94 2011-09-27 Eli Zaretskii <eliz@gnu.org>
96 * xdisp.c (handle_invisible_prop): If invisible text ends on a
97 newline, reseat the iterator instead of bidi-iterating there one
98 character at a time. (Bug#9610)
99 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
100 TO_CHARPOS if the bidi iterator is at base embedding level.
102 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
104 * lread.c (readevalloop): Use correct code for NBSP.
105 (read1): Likewise. (Bug#9608)
107 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
109 * dbusbind.c (Fdbus_register_signal): When service is not
110 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
112 2011-09-25 Glenn Morris <rgm@gnu.org>
114 * buffer.c (truncate-lines): Doc fix.
116 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
118 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
119 (Fset_window_next_buffers): Doc fix.
121 2011-09-24 Glenn Morris <rgm@gnu.org>
123 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
125 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
127 Fix minor problems found by static checking.
128 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
129 * indent.c (Fvertical_motion): Fix == vs = typo.
131 2011-09-24 Eli Zaretskii <eliz@gnu.org>
133 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
134 value is now t. Doc fix.
136 * indent.c (Fvertical_motion): Compute and apply the overshoot
137 logic when moving up, not only when moving down. Fix the
138 confusing name and values of the it_overshoot_expected variable;
139 logic changes accordingly. (Bug#9254) (Bug#9549)
141 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
142 CHARPOS is covered by a display string which includes newlines.
143 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
144 is covered by a display string with embedded newlines.
146 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
148 * dbusbind.c (Fdbus_register_signal): Add match rule to
149 Vdbus_registered_objects_table. (Bug#9581)
150 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
153 2011-09-24 Jim Meyering <meyering@redhat.com>
155 do not ignore write error for any output size
156 The previous change was incomplete.
157 While it makes emacs --batch detect the vast majority of stdout
158 write failures, errors were still ignored whenever the output size is
159 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
160 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
161 && echo FAIL: ignored write error
162 FAIL: ignored write error
163 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
164 && echo FAIL: ignored write error
165 FAIL: ignored write error
166 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
168 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
170 * emacs.c (Fkill_emacs): In noninteractive mode exit
171 non-successfully if a write error occurred on stdout. (Bug#9574)
173 2011-09-21 Eli Zaretskii <eliz@gnu.org>
175 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
178 * dispextern.h (struct it): Update the comment documenting what
181 2011-09-20 Eli Zaretskii <eliz@gnu.org>
183 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
184 a display string, extend search for cursor position to end of row.
185 (find_row_edges): If the row ends in a newline from a display
186 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
187 Handle the case of a display string with multiple newlines.
188 (Fcurrent_bidi_paragraph_direction): Fix search for previous
189 non-empty line. Fixes confusing cursor motion with arrow keys at
190 the beginning of a line that starts with whitespace.
192 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
194 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
197 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
199 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
202 2011-09-18 Eli Zaretskii <eliz@gnu.org>
204 * xdisp.c (display_line): Record maximum and minimum buffer
205 positions even if no glyphs were produced (e.g., by a zero-width
206 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
207 buffer positions that will be removed from the glyph row because
209 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
210 column is beyond frame width: don't subtract 1 "pixel" when
211 computing width of the stretch.
212 (reseat_at_next_visible_line_start): Undo the change made on
213 2011-09-17 that saved paragraph information and restored it after
214 the call to `reseat'. (Bug#9545)
216 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
218 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
219 and turn window cursor on if cleared (Bug#9415).
221 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
223 * search.c (boyer_moore): Take unibyte characters from pattern
224 literally. (Bug#9458)
226 2011-09-18 Eli Zaretskii <eliz@gnu.org>
228 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
230 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
232 Fix minor problem found by static checking.
233 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
234 initialized, to pacify gcc -Wuninitialized.
236 * fileio.c: Report proper errno when syscall falls.
237 (Finsert_file_contents): Save and restore errno,
238 so that report_file_error outputs the correct diagnostic.
239 (Fwrite_region) [CLASH_DETECTION]: Likewise.
241 2011-09-18 Eli Zaretskii <eliz@gnu.org>
243 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
245 2011-09-17 Eli Zaretskii <eliz@gnu.org>
247 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
248 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
250 2011-09-17 Eli Zaretskii <eliz@gnu.org>
252 * xdisp.c (reseat_at_next_visible_line_start): Keep information
253 about the current paragraph and restore it after the call to
256 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
257 (bidi_find_paragraph_start): Search back for paragraph beginning
258 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
259 (bidi_move_to_visually_next): Only trigger paragraph-related
260 computations when the last character is a newline or at EOB, not
261 just any NEUTRAL_B. (Bug#9470)
263 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
264 truncated lines if point is covered by a display string. (Bug#9524)
266 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
268 * xselect.c: Relax test for outgoing X longs (Bug#9498).
269 (cons_to_x_long): New function.
270 (lisp_data_to_selection_data): Use it. Correct the test for
271 short-versus-long data; it was negated. Break out of vector
272 loop, for efficiency, when a long datum is discovered.
274 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
276 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
278 2011-09-16 Eli Zaretskii <eliz@gnu.org>
280 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
281 GCC PR/17406) by declaring this function with external scope.
283 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
285 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
286 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
288 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
290 * editfns.c (Fformat): Correctly handle text properties on "%%".
292 2011-09-15 Eli Zaretskii <eliz@gnu.org>
294 * xterm.c (x_draw_composite_glyph_string_foreground):
295 * w32term.c (x_draw_composite_glyph_string_foreground):
296 * term.c (encode_terminal_code):
297 * composite.c (composition_update_it, get_composition_id):
298 * xdisp.c (get_next_display_element)
299 (fill_composite_glyph_string): Add comments about special meaning
300 of TAB characters in a composition.
302 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
304 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
305 This occurs when processing a multibyte format.
306 Problem reported by Wolfgang Jenker.
308 2011-09-15 Johan Bockgård <bojohan@gnu.org>
310 * xdisp.c (try_cursor_movement): Only check for exact match if
311 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
313 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
315 Remove unused external symbols.
316 * dispextern.h (calc_pixel_width_or_height): Remove decl.
317 * xdisp.c (calc_pixel_width_or_height): Now static.
318 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
319 * indent.c (check_display_width):
320 * w32term.c: Fix comment to match code.
321 * xterm.c, xterm.h (x_catching_errors): Remove.
323 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
325 * xselect.c: Use signed conversions more consistently (Bug#9498).
326 (selection_data_to_lisp_data): Assume incoming selection data are
327 signed integers, not unsigned. This is to be consistent with
328 outgoing selection data, which was modified to use signed integers
329 in as part of the fix to Bug#9196 in response to Jan D.'s comment
330 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
331 expects long, not unsigned long.
333 2011-09-14 Eli Zaretskii <eliz@gnu.org>
335 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
336 computation of loop end. Reported by Johan Bockgård
339 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
341 * frame.c (Fother_visible_frames_p): Function deleted.
343 2011-09-12 Eli Zaretskii <eliz@gnu.org>
345 * indent.c (compute_motion): Process display vector front to back
346 rather than the other way around. (Bug#2496)
348 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
350 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
352 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
354 * minibuf.c (Fread_from_minibuffer): Doc fix.
356 2011-09-11 Eli Zaretskii <eliz@gnu.org>
358 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
359 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
361 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
363 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
364 value for non-existent files.
366 2011-09-11 Eli Zaretskii <eliz@gnu.org>
368 * fileio.c (Finsert_file_contents): If the file cannot be opened,
369 set its "size" to -1. This will set the modtime_size field of
370 the corresponding buffer to -1, which is what
371 verify-visited-file-modtime expects for files that do not exist.
374 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
376 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
378 * lisp.h: ... from here. push_key_description is no longer
379 defined in keyboard.c, so its declaration should not be in
380 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
381 logically belongs with push_key_description.
383 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
385 * buffer.h: Include <sys/types.h> instead of <time.h>.
386 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
387 Problem reported by Herbert J. Skuhra.
389 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
391 * xml.c (parse_region): Make the parsing work for
392 non-comment-starting XML files again (bug#9144).
394 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
396 * image.c (gif_load): Fix calculation of bottom and right corner.
399 2011-09-10 Eli Zaretskii <eliz@gnu.org>
401 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
402 redisplay in small windows.
404 2011-09-09 Eli Zaretskii <eliz@gnu.org>
406 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
408 2011-09-08 Martin Rudalics <rudalics@gmx.at>
410 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
411 Operate on live windows only.
413 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
415 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
417 2011-09-07 Eli Zaretskii <eliz@gnu.org>
419 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
420 only under bidi iteration.
422 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
424 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
426 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
428 isnan: Fix porting problem to Solaris 10 with bundled gcc.
429 Without this fix, the command to link temacs failed due to an
430 undefined symbol __builtin_isnan. This is because
431 /usr/include/iso/math_c99.h #defines isnan(x) to
432 __builtin_isnan(x), but the bundled gcc, which identifies itself
433 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
435 * floatfns.c (isnan): #undef, and then #define to a clone of
437 (Fisnan): Always define, since it's always available now.
438 (syms_of_floatfns): Always define isnan at the Lisp level.
440 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
442 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
444 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
446 * fileio.c: Fix bugs with large file offsets (Bug#9428).
447 The previous code assumed that file offsets (off_t values) fit in
448 EMACS_INT variables, which is not true on typical 32-bit hosts.
449 The code messed up by falsely reporting buffer overflow in cases
450 such as (insert-file-contents "big" nil 1 2) into an empty buffer
451 when "big" contains more than 2**29 bytes, even though this
452 inserts just one byte and does not overflow the buffer.
453 (Finsert_file_contents): Store file offsets as off_t
454 values, not as EMACS_INT values. Check for overflow when
455 converting between EMACS_INT and off_t. When checking for
456 buffer overflow or for overlap, take the offsets into account.
457 Don't use EMACS_INT for small values where int suffices.
458 When checking for overlap, fix a typo: ZV was used where
459 ZV_BYTE was intended.
460 (Fwrite_region): Don't assume off_t fits into 'long'.
461 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
463 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
465 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
467 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
469 sprintf-related integer and memory overflow issues (Bug#9412).
471 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
472 (esprintf, exprintf, evxprintf): New functions.
473 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
474 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
475 (modify_event_symbol): Do not assume that the length of
476 name_alist_or_stem is safe to alloca and fits in int.
477 (Fexecute_extended_command): Likewise for function name and binding.
478 (Frecursion_depth): Wrap around reliably on integer overflow.
479 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
480 since some callers pass EMACS_INT values.
481 (Fsingle_key_description): Don't crash if symbol name contains more
482 than MAX_ALLOCA bytes.
483 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
484 (get_minibuffer): Arg is now EMACS_INT, not int.
485 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
486 (esprintf, exprintf, evxprintf): New decls.
487 * window.h (command_loop_level, minibuf_level): Reflect API changes.
489 * dbusbind.c (signature_cat): New function.
490 (xd_signature, Fdbus_register_signal):
491 Do not overrun buffer; instead, report string overflow.
493 * dispnew.c (add_window_display_history): Don't overrun buffer.
494 Truncate instead; this is OK since it's just a log.
496 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
497 even if the time zone offset is outlandishly large.
498 Don't mishandle offset == INT_MIN.
500 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
501 when creating daemon; the previous buffer-overflow check was incorrect.
503 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
504 which has the guts of the old verror function.
506 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
507 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
509 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
510 (font_unparse_xlfd): Don't blindly alloca long strings.
511 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
512 fits in int, when using sprintf. Use single snprintf to count
513 length of string rather than counting it via multiple sprintfs;
514 that's simpler and more reliable.
515 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
516 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
517 sprintf, in case result does not fit in int.
519 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
520 (fontset_from_font): Print it.
522 * frame.c (tty_frame_count): Now printmax_t, not int.
523 (make_terminal_frame, set_term_frame_name): Print it.
524 (x_report_frame_params): In X, window IDs are unsigned long,
525 not signed long, so print them as unsigned.
526 (validate_x_resource_name): Check for implausibly long names,
527 and don't assume name length fits in 'int'.
528 (x_get_resource_string): Don't blindly alloca invocation name;
529 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
532 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
533 (xg_check_special_colors, xg_set_geometry):
534 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
536 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
537 Use esprintf, not sprintf, in case result does not fit in int.
539 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
540 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
541 it as a large positive number.
542 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
543 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
545 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
546 in case result does not fit in int.
548 * print.c (float_to_string): Detect width overflow more reliably.
549 (print_object): Make sprintf buffer a bit bigger, to avoid potential
550 buffer overrun. Don't assume list length fits in 'int'. Treat
551 print length of 0 as 0, not as infinity; to be consistent with other
552 uses of print length in this function. Don't overflow print length
553 index. Don't assume hash table size fits in 'long', or that
554 vectorlike size fits in 'unsigned long'.
556 * process.c (make_process): Use printmax_t, not int, to format
557 process-name gensyms.
559 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
561 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
562 to avoid potential buffer overrun.
564 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
565 if X resource line is longer than 512 bytes.
567 * xfns.c (x_window): Make sprintf buffer a bit bigger
568 to avoid potential buffer overrun.
570 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
572 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
574 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
576 Integer overflow fixes for scrolling, etc.
577 Without these, Emacs silently mishandles large integers sometimes.
578 For example, "C-u 4294967297 M-x recenter" was treated as if
579 it were "C-u 1 M-x recenter" on a typical 64-bit host.
581 * xdisp.c (try_window_id): Check Emacs fixnum range before
584 * window.c (window_scroll_line_based, Frecenter):
585 Check that an Emacs fixnum is in range before assigning it to 'int'.
586 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
587 values converted from Emacs fixnums.
588 (Frecenter): Don't wrap around a line count if it is out of 'int'
589 range; instead, treat it as an extreme value.
590 (Fset_window_configuration, compare_window_configurations):
591 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
593 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
594 that can exceed INT_MAX. Check that EMACS_INT value is in range
595 before assigning it to the (possibly-narrower) index.
596 (match_limit): Don't assume that a fixnum can fit in 'int'.
598 * print.c (print_object): Use ptrdiff_t, not int, for index that can
601 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
602 (Fvertical_motion): Don't wrap around LINES values that don't fit
603 in 'int'. Instead, treat them as extreme values. This is good
604 enough for windows, which can't have more than INT_MAX lines anyway.
606 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
608 * Require libxml/parser.h to avoid compilation warning.
610 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
612 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
613 since this reportedly can destroy thread storage.
615 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
617 * syntax.c (find_defun_start): Update all cache variables if
618 exiting early (Bug#9401).
620 2011-08-30 Eli Zaretskii <eliz@gnu.org>
622 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
624 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
625 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
626 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
628 * term.c (tty_append_glyph): New function.
629 (produce_stretch_glyph): Static function and its prototype deleted.
631 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
634 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
636 * image.c (parse_image_spec): Check for nonnegative, not for positive,
637 when checking :margin (Bug#9390).
638 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
639 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
640 so that the name doesn't mislead. All uses changed.
642 2011-08-28 Johan Bockgård <bojohan@gnu.org>
644 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
647 2011-08-27 Eli Zaretskii <eliz@gnu.org>
649 * xdisp.c (move_it_to): Don't bail out early when reaching
650 position beyond to_charpos, if we are scanning backwards.
651 (move_it_vertically_backward): When DY == 0, make sure we get to
652 the first character in the line after the newline.
654 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
656 * ccl.c: Improve and simplify overflow checking (Bug#9196).
657 (ccl_driver): Do not generate an out-of-range pointer.
658 (Fccl_execute_on_string): Remove unnecessary check for
659 integer overflow, noted by Stefan Monnier in
660 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
661 Remove a FIXME that didn't need fixing.
662 Simplify the newly-introduced buffer reallocation code.
664 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
666 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
668 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
670 Integer and memory overflow issues (Bug#9196).
672 * doc.c (get_doc_string): Rework so that
673 get_doc_string_buffer_size is the actual buffer size, rather than
674 being 1 less than the actual buffer size; this makes xpalloc more
677 * image.c (x_allocate_bitmap_record, cache_image):
678 * xselect.c (Fx_register_dnd_atom):
679 Simplify previous changes by using xpalloc.
681 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
682 since either will do and ptrdiff_t is convenient with xpalloc.
684 * charset.c (charset_table_size)
685 (struct charset_sort_data.priority): Now ptrdiff_t.
686 (charset_compare): Don't overflow if priorities differ greatly.
687 (Fsort_charsets): Don't assume list length fits in int.
688 Check for size-calculation overflow when allocating sort data.
689 (syms_of_charset): Allocate an initial charset table that is
690 just under 64 KiB, to avoid problems with glibc malloc and mmap.
692 * cmds.c (internal_self_insert): Check for size-calculation overflow.
694 * composite.h (struct composition.glyph_len): Now int, not unsigned.
695 The actual value is always <= INT_MAX, and leaving it unsigned made
696 overflow checking harder.
698 * dispextern.h (struct glyph_matrix.rows_allocated)
699 (struct face_cache.size): Now ptrdiff_t, for convenience in use
700 with xpalloc. The values are still always <= INT_MAX.
702 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
704 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
705 (SAFE_NALLOCA): New macro.
707 * region-cache.c (struct boundary.pos, find_cache_boundary)
708 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
709 (set_cache_region, invalidate_region_cache)
710 (revalidate_region_cache, know_region_cache, region_cache_forward)
711 (region_cache_backward, pp_cache):
712 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
713 so that ptrdiff_t * can be passed to xpalloc.
714 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
715 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
716 (pp_cache): Don't assume cache_len fits in int.
717 * region-cache.h: Adjust extern decls to match.
719 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
720 EMACS_INT, since either will do, for xpalloc.
722 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
723 (xnmalloc, xnrealloc, xpalloc): New functions.
725 * bidi.c (bidi_shelve_header_size): New constant.
726 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
727 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
729 * bidi.c (bidi_cache_shrink):
730 * buffer.c (overlays_at, overlays_in, record_overlay_string)
732 Don't update size of array until after memory allocation succeeds,
733 because xmalloc/xrealloc may not return.
734 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
735 now that we have proper integer overflow checking.
736 (record_overlay_string, overlay_strings): Catch overflows when
737 calculating size of overlay_str_buf.
739 * callproc.c (Fcall_process): Check for size overflow when
740 calculating size of args2.
741 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
742 Normally we prefer signed values, but sticking with ptrdiff_t would
743 require adding more-complicated checks.
745 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
746 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
747 Redo buffer-overflow calculations to avoid integer overflow.
748 Add a FIXME comment where memory seems to be over-allocated.
750 * character.c (Fstring): Check for size-calculation overflow.
752 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
753 unnecessary integer overflow. Check for size overflow.
754 (encode_coding_object): Don't update size until xmalloc succeeds.
756 * composite.c (get_composition_id): Check for overflow in glyph
759 Integer and memory overflow fixes for display code.
760 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
761 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
762 (scrolling_window): Check for overflow in size calculations.
763 (line_draw_cost, realloc_glyph_pool, add_row_entry):
764 Don't assume glyph table len fits in int.
765 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
766 (row_table_size): Now ptrdiff_t, not int.
767 (scrolling_window): Avoid overflow in size calculations.
768 Don't update size until allocation succeeds.
769 * fns.c (concat): Check for overflow in size calculations.
770 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
771 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
772 (NEXT_ALMOST_PRIME_LIMIT): New constant.
774 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
775 (get_doc_string): Check for size calculation overflow.
776 Don't update size until allocation succeeds.
777 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
778 EMACS_INT, where ptrdiff_t will do.
779 (Fsubstitute_command_keys): Check for string overflow.
781 * editfns.c (set_time_zone_rule): Don't assume environment length
783 (message_length): Now ptrdiff_t, not int.
784 (Fmessage_box): Don't update size until allocation succeeds.
785 Don't assume message length fits in int.
786 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
788 * emacs.c (main): Do not reallocate argv, since there is a null at
789 the end that can be overwritten, and this way there's no need to
790 worry about size-calculation overflow.
791 (sort_args): Check for size-calculation overflow.
793 * eval.c (init_eval_once, grow_specpdl): Don't update size until
795 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
797 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
798 (x_set_scroll_bar_width, x_figure_window_size):
799 Check for integer overflow.
800 (x_set_alpha): Do not assume XINT fits in int.
802 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
803 This is for the members text_lines, text_cols, total_lines, total_cols,
804 where the system imposes an 'int' limit.
806 * fringe.c (Fdefine_fringe_bitmap):
807 Don't update size until alloc works.
809 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
810 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
812 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
813 Check for size-calculation overflow.
814 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
815 do, as we prefer signed integers.
816 (id_to_widget.max_size, id_to_widget.used)
817 (xg_store_widget_in_map, xg_remove_widget_from_map)
818 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
819 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
820 Use and return ptrdiff_t, not int.
821 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
822 * gtkutil.h: Change prototypes to match the above.
824 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
825 are duplicate now that they've been promoted to lisp.h.
826 (x_allocate_bitmap_record, x_alloc_image_color)
827 (make_image_cache, cache_image, xpm_load):
828 Don't update size until alloc is done.
829 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
831 Check for size calculation overflow.
832 (ct_colors_allocated_max): New constant.
833 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
836 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
837 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
838 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
839 Use ptrdiff_t, not int, to count maps.
840 (read_char_minibuf_menu_prompt): Check for overflow in size
841 calculations. Don't update size until allocation succeeds. Redo
842 calculations to avoid overflow.
843 * keyboard.h: Change prototypes to match the above.
845 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
847 (current_minor_maps): Check for size calculation overflow.
848 * keymap.h: Change prototypes to match the above.
850 * lread.c (read1, init_obarray): Don't update size until alloc done.
852 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
853 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
855 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
856 Now ptrdiff_t, not int.
857 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
858 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
860 * process.c (Fnetwork_interface_list): Check for overflow
863 * region-cache.c (move_cache_gap): Check for size calculation overflow.
865 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
866 overflow. Don't bother calling xmalloc when xrealloc will do.
868 * search.c (Freplace_match): Check for size calculation overflow.
869 (Fset_match_data): Don't assume list lengths fit in 'int'.
871 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
872 for command line length. Do not attempt to address one before the
873 beginning of an array, as that's not portable.
875 * term.c (max_frame_lines): Remove; unused.
876 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
878 (encode_terminal_code, calculate_costs): Check for size
879 calculation overflow.
880 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
881 table lengths and related sizes. Don't update size until alloc
882 done. Redo calculations to avoid overflow.
883 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
885 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
886 subtracting pointers.
887 (gobble_line): Check for overflow more carefully. Don't update size
890 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
891 Don't update size until alloc done.
892 Redo size calculations to avoid overflow.
893 Check for size calculation overflow.
894 (main) [DEBUG]: Fix typo in invoking tparam1.
896 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
897 Use ptrdiff_t, not int, for sizes.
898 (store_mode_line_noprop_char): Don't update size until alloc done.
900 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
901 Use ptrdiff_t, not int, for sizes.
902 (Finternal_make_lisp_face, cache_face):
903 Check for size calculation overflow.
904 (cache_face): Treat size calculation overflows as if they were
905 memory exhaustion (the usual treatment), rather than aborting.
907 * xfns.c (x_encode_text, x_set_name_internal)
908 (Fx_change_window_property): Use ptrdiff_t, not int, to count
909 sizes, since they can exceed INT_MAX in size. Check for size
910 calculation overflow.
912 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
913 (xg_select): Check for size calculation overflow.
914 Don't update size until alloc done.
916 * xrdb.c (get_environ_db): Don't assume path length fits in int,
917 as sprintf is limited to int lengths.
919 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
920 (X_LONG_MIN): New macros.
921 Use them to make the following changes clearer.
922 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
923 This change doesn't affect the value now, but it may help remind
924 future maintainers not to raise the value too much later.
925 (SELECTION_QUANTUM): Remove, replacing with ...
926 (selection_quantum): ... new function, which avoids overflow.
928 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
929 assumption that selection length fits in 'int'.
930 (x_reply_selection_request, x_handle_selection_request)
931 (x_get_window_property, receive_incremental_selection)
932 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
933 (lisp_data_to_selection_data, clean_local_selection_data):
934 Use ptrdiff_t, not int, to record length of selection.
935 (x_reply_selection_request, x_get_window_property)
936 (receive_incremental_selection, x_property_data_to_lisp):
937 Redo calculations to avoid overflow.
938 (x_reply_selection_request): When sending hint, ceiling it at
939 X_LONG_MAX rather than relying on wraparound overflow to send
941 (x_get_window_property, receive_incremental_selection)
942 (lisp_data_to_selection_data, x_property_data_to_lisp):
943 Check for size-calculation overflow.
944 (x_get_window_property, receive_incremental_selection)
945 (lisp_data_to_selection_data, Fx_register_dnd_atom):
946 Don't store size until memory allocation succeeds.
947 (x_get_window_property): Plug memory leak on memory exhaustion.
948 Don't double-block input; malloc is safe here. Don't assume 2**34
949 - 4 fits in unsigned long. Add an xassert to check
950 XGetWindowProperty overflow. Be more careful about overflow
951 calculations, and distinguish size from memory overflow better.
952 (receive_incremental_selection): When tracing, don't assume
953 unsigned int is less than INT_MAX.
954 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
955 harmful) conversions of unsigned short to int.
956 (lisp_data_to_selection_data): Don't assume that integers
957 in the range -65535 through -1 fit in an X unsigned short.
958 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
959 result parameters unless successful. Rely on cons_to_unsigned
960 to report problems with elements; the old code wasn't right anyway.
961 (x_check_property_data): Check for int overflow; we cannot use
962 a wider type due to X limits.
963 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
965 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
967 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
968 (x_term_init): Check for size calculation overflow.
969 (x_color_cells): Don't store size until memory allocation succeeds.
970 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
971 Don't assume alloca size is less than MAX_ALLOCA.
972 (x_term_init): Don't assume length fits in int (sprintf is limited
975 Use ptrdiff_t for composition IDs.
976 * character.c (lisp_string_width):
977 * composite.c (composition_table_size, n_compositions)
978 (get_composition_id, composition_gstring_from_id):
979 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
980 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
981 * window.c (Frecenter):
982 Use ptrdiff_t, not int, for composition IDs.
983 * composite.c (get_composition_id): Check for integer overflow.
984 * composite.h: Adjust prototypes to match the above changes.
986 Use ptrdiff_t for hash table indexes.
987 * category.c (hash_get_category_set):
988 * ccl.c (ccl_driver):
989 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
990 * coding.c (coding_system_charset_list, detect_coding_system):
991 * coding.h (struct coding_system.id):
992 * composite.c (get_composition_id, gstring_lookup_cache):
993 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
994 * image.c (xpm_get_color_table_h):
995 * lisp.h (hash_lookup, hash_put):
996 * minibuf.c (Ftest_completion):
997 Use ptrdiff_t for hash table indexes, not int (which is too
998 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
999 32-bit --with-wide-int hosts).
1001 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1002 Add a FIXME comment about memory leaks.
1003 (syms_of_charset): Don't assume xmalloc returns.
1005 Don't assume that stated character widths fit in int.
1006 * character.c (Fchar_width, c_string_width, lisp_string_width):
1007 * character.h (CHAR_WIDTH):
1008 * indent.c (MULTIBYTE_BYTES_WIDTH):
1009 Use sanitize_char_width to avoid undefined and/or bad behavior
1010 with outlandish widths.
1011 * character.h (sanitize_tab_width): Renamed from sanitize_width,
1012 now that we have two such functions. All uses changed.
1013 (sanitize_char_width): New inline function.
1015 Don't assume that tab-width fits in int.
1016 * character.h (sanitize_width): New inline function.
1017 (SANE_TAB_WIDTH): New macro.
1018 (ASCII_CHAR_WIDTH): Use it.
1019 * indent.c (sane_tab_width): Remove. All uses replaced by
1020 SANE_TAB_WIDTH (current_buffer).
1021 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1023 * fileio.c: Integer overflow issues with file modes.
1024 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1026 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1027 Remove unreachable code.
1028 (read_hex, load_charset_map_from_file): Check for integer overflow.
1030 * xterm.c: don't go over XClientMessageEvent limit
1031 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1032 (x_send_scroll_bar_event): Likewise. Check that the size does not
1033 exceed limits imposed by XClientMessageEvent, as well as the usual
1034 ptrdiff_t and size_t limits.
1036 * keyboard.c: Overflow, signedness and related fixes.
1037 (make_lispy_movement): Use same integer type in forward decl
1038 that is used in the definition.
1039 (read_key_sequence, keyremap_step):
1040 Change bufsize argument back to int, undoing my 2011-03-30 change.
1041 We prefer signed types, and int is wide enough here.
1042 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1043 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1044 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1045 length, not size_t. Use ptrdiff_t for index, not int.
1046 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1047 possibility of integer overflow.
1049 Overflow, signedness and related fixes for images.
1051 * dispextern.h (struct it.stack[0].u.image.image_id)
1052 (struct_it.image_id, struct image.id, struct image_cache.size)
1053 (struct image_cache.used, struct image_cache.ref_count):
1054 * gtkutil.c (update_frame_tool_bar):
1055 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1056 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1057 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1058 * nsmenu.m (update_frame_tool_bar):
1059 * xdisp.c (calc_pixel_width_or_height):
1060 * xfns.c (image_cache_refcount):
1061 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1062 on typical 64-bit hosts.
1064 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1065 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1066 Omit unnecessary casts to int.
1067 (parse_image_spec): Check that integers fall into 'int' range
1068 when the callers expect that.
1069 (image_ascent): Redo ascent calculation to avoid int overflow.
1070 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1071 (lookup_image): Remove unnecessary tests.
1072 (xbm_image_p): Locals are now of int, not EMACS_INT,
1073 since parse_image_check makes sure they fit into int.
1074 (png_load, gif_load, svg_load_image):
1075 Prefer int to unsigned where either will do.
1076 (tiff_handler): New function, combining the cores of the
1077 old tiff_error_handler and tiff_warning_handler. This
1078 function is rewritten to use vsnprintf and thereby avoid
1079 stack buffer overflows. It uses only the features of vsnprintf
1080 that are common to both POSIX and native Microsoft.
1081 (tiff_error_handler, tiff_warning_handler): Use it.
1082 (tiff_load, gif_load, imagemagick_load_image):
1083 Don't assume :index value fits in 'int'.
1084 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1085 (imagemagick_load_image): Check that crop parameters fit into
1086 the integer types that MagickCropImage accepts. Don't assume
1087 Vimagemagick_render_type has a nonnegative value. Don't assume
1088 size_t fits in 'long'.
1089 (gs_load): Use printmax_t to print the widest integers possible.
1090 Check for integer overflow when computing image height and width.
1092 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1094 * xdisp.c (redisplay_window): Don't force window start if point
1095 will be invisible in the resulting window. (Bug#9324)
1097 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1099 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1100 the display spec is of the form `(space ...)'.
1101 (handle_display_spec): Return the value returned by
1102 handle_single_display_spec, not just 1 or zero.
1103 (handle_single_display_spec): If the display spec is of the form
1104 `(space ...)', and specifies display in the text area, return 2
1106 (try_cursor_movement): Check for the need to scroll more
1107 accurately, and prefer exact match for point under bidi. Don't
1108 advance `row' beyond the last row of the window.
1110 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1111 into disp_prop; all users changed.
1113 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1114 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1115 for the text covered by the display property.
1117 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1119 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1120 Change return value to nil.
1121 (Frecord_buffer): Delete unused function.
1123 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1125 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1126 buffers, return left-to-right.
1127 (set_cursor_from_row): Consider candidate row a win if its glyph
1128 represents a newline and point is on that newline. Fixes cursor
1129 positioning on the newline at EOL of R2L text within L2R
1130 paragraph, and vice versa.
1131 (try_cursor_movement): Check continued rows, in addition to
1132 continuation rows. Fixes unwarranted scroll when point enters a
1133 continued line of R2L text within an L2R paragraph, or vice versa.
1134 (cursor_row_p): Consider the case of point being equal to
1135 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1136 from the end of a short line to the beginning of a continued line
1137 of R2L text within L2R paragraph.
1138 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1139 composed characters.
1141 * bidi.c (bidi_check_type): Use xassert.
1142 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1145 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1147 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1150 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1152 * nsfont.m (ns_otf_to_script): Fix typo.
1154 2011-08-22 Kenichi Handa <handa@m17n.org>
1156 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1157 extra slot even if the purpose is char-code-property-table.
1159 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1161 * xdisp.c (redisplay_window): When computing centering_position,
1162 account for the height of the header line. (Bug#8874)
1164 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1165 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1166 candidate is selected by the mouse, and that candidate has a
1167 composed character under the mouse.
1169 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1170 coordinates reported by pos-visible-in-window-p for a composed
1171 character in column zero.
1173 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1175 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1177 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1179 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1180 consider it a hit if to_charpos is anywhere in the range of the
1181 composed buffer positions.
1183 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1185 * image.c (gif_load): Don't assume that each subimage has the same
1186 dimensions as the base image. Handle disposal method that is
1187 "undefined" by the gif spec (Bug#9335).
1189 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1191 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1192 (Fcondition_case): Document `debug' symbol in error handler.
1194 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1196 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1197 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1198 from an Org mode buffer to a Speedbar frame.
1200 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1201 a composition, take its buffer position from IT->cmp_it.charpos.
1202 Fixes cursor positioning at the beginning of a line that begins
1203 with a composed character.
1205 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1207 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1208 character bidirectional type, use STRONG_L instead. Fixes crashes
1209 in a buffer produced by `describe-categories'.
1211 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1212 members before the level stack, so they would be saved and
1213 restored when copying iterator state. Fixes incorrect reordering
1214 around TABs covered by display properties.
1216 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1218 * process.c (Fnetwork_interface_list): Correctly determine buffer
1221 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1223 * eval.c (internal_condition_case, internal_condition_case_1)
1224 (internal_condition_case_2, internal_condition_case_n):
1225 Remove unnecessary aborts (Bug#9081).
1227 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1229 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1230 has no `load' handler, try opening the file locally. (Bug#9311)
1232 2011-08-16 Ken Brown <kbrown@cornell.edu>
1234 * gmalloc.c: Expand comment.
1236 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1238 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1239 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1241 2011-08-16 Ken Brown <kbrown@cornell.edu>
1243 Fix memory allocation problems in Cygwin build (Bug#9273).
1245 * unexcw.c ( __malloc_initialized): Declare external variable.
1246 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1248 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1250 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1252 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1254 [CYGWIN] (special_realloc): New function.
1255 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1256 requests to realloc storage in the static heap.
1258 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1260 * bidi.c (bidi_initialize): Remove unused local.
1262 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1264 * biditype.h: File removed.
1266 * bidimirror.h: File removed.
1268 * deps.mk (bidi.o): Remove biditype.h and
1271 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1274 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1276 * chartab.c: Improve commentary for the uniprop_table API.
1278 * bidi.c (bidi_paragraph_init): Support zero value of
1279 bidi_ignore_explicit_marks_for_paragraph_level.
1280 (bidi_initialize): Use uniprop_table instead of including
1281 biditype.h and bidimirror.h.
1283 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1284 coordinates of the iterator when restoring from ppos_it.
1287 2011-08-14 Kenichi Handa <handa@m17n.org>
1289 * process.c (create_process): Call setup_process_coding_systems
1290 after the pid of the process is set to -1 (Bug#8162).
1292 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1294 * xdisp.c (move_it_in_display_line_to): Don't invoke
1295 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1296 ppos_it. Fixes vertical cursor motion when line beginning is
1297 covered by an image. (Bug#9296)
1299 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1301 * nsterm.h (ns_run_ascript): Declare.
1302 (NSAPP_DATA2_RUNASSCRIPT): Define.
1304 * nsfns.m (as_script, as_result, as_status): New static variables.
1305 (ns_run_ascript): New function.
1306 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1307 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1308 the event loop. Get status from as_status (Bug#7276).
1310 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1311 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1312 the event loop (Bug#7276).
1314 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1316 * gnutls.c (QCgnutls_bootprop_priority)
1317 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1318 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1319 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1320 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1321 (QCgnutls_bootprop_verify_hostname_error)
1322 (QCgnutls_bootprop_callbacks_verify): Rename from
1323 Qgnutls_bootprop_..., all uses changed.
1325 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1328 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1330 * xfaces.c (Qframe_set_background_mode): Now static.
1331 * dispextern.h (Qframe_set_background_mode): Remove decl.
1333 * process.c (Fnetwork_interface_info): Declare local only if needed.
1335 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1337 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1338 (Fnetwork_interface_list): Allocate in increments of bytes instead
1339 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1340 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1342 (struct ifflag_def): notrailers is smart on OSX.
1343 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1344 Get hardware address with getifaddrs if available.
1346 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1348 * xdisp.c (iterate_out_of_display_property): xassert that
1349 IT->position is set to within IT->object's boundaries. Break from
1350 the loop as soon as EOB is reached; avoids infloops in redisplay
1351 when IT->position is set up wrongly due to some bug.
1352 Set IT->current to match the bidi iterator unconditionally.
1353 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1354 entry. Force push_it to save on the stack the current
1355 buffer/string position, to be restored by pop_it. Fix flags in
1356 the iterator structure wrt the object coming from a display
1357 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1358 properties. (Bug#9284)
1360 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1362 * fontset.c (fontset_get_font_group): Add proper type checks.
1365 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1367 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1368 and LC_VERSION_MIN_MACOSX.
1369 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1370 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1372 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1374 * xdisp.c (forward_to_next_line_start): Allow to use the
1375 no-display-properties-and-no-overlays under bidi display.
1376 Set disp_pos in the bidi iterator to avoid searches for display
1377 properties and overlays.
1379 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1381 * editfns.c (Fset_time_zone_rule): Document relationship with the
1384 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1385 the font entity extracted from the cache (Bug#8109).
1387 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1389 * composite.c (autocmp_chars): Don't reset point. That is done by
1390 restore_point_unwind (Bug#5984).
1392 2011-08-07 Juri Linkov <juri@jurta.org>
1394 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1395 to show the arg `TIME' instead of `TIMEVAL'.
1397 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1399 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1400 display property strides EOL and includes a newline, as in
1401 longlines-mode. (Bug#9254)
1402 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1403 word-wrap under bidirectional display. (Bug#9224)
1405 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1406 is non-zero, even if the data buffer is NULL. Fixes a crash in
1407 vertical-motion with longlines-mode. (Bug#9254)
1409 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1411 * bidi.c <bidi_cache_total_alloc>: Now static.
1412 (bidi_initialize): Initialize bidi_cache_total_alloc.
1414 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1417 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1418 amount allocated this far in `bidi_cache_total_alloc'.
1419 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1420 non-zero, only free the data buffer without restoring the cache
1421 contents. All callers changed.
1423 * dispextern.h (bidi_unshelve_cache): Update prototype.
1425 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1426 (move_it_in_display_line, move_it_to)
1427 (move_it_vertically_backward, move_it_by_lines): Replace the call
1428 to xfree to an equivalent call to bidi_unshelve_cache.
1429 (move_it_in_display_line_to): Fix logic of returning
1430 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1432 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1434 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1435 came from a string character with a `cursor' property. (Bug#9229)
1437 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1439 * Makefile.in (LIB_PTHREAD): New variable.
1440 (LIBES): Add LIB_PTHREAD (Bug#9216).
1442 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1443 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1445 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1447 * regex.c (re_iswctype): Remove some redundant boolean
1450 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1452 * xterm.c (x_find_topmost_parent): New function.
1453 (x_set_frame_alpha): Find topmost parent window with
1454 x_find_topmost_parent and set the property there also (bug#9181).
1455 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1457 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1459 * callproc.c (Fcall_process): Avoid vfork clobbering
1460 the local vars buffer, coding_systems, current_dir.
1462 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1464 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1466 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1468 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1469 so that it is not optimized away.
1471 * xdisp.c (compute_display_string_pos): Remove unused local.
1473 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1475 Fix slow cursor motion and scrolling in large buffers with
1476 selective display, like Org Mode buffers. (Bug#9218)
1478 * dispextern.h (struct bidi_it): New member disp_prop_p.
1480 * xdisp.c: Remove one-slot cache of display string positions.
1481 (compute_display_string_pos): Accept an additional argument
1482 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1483 for a display string or property. If found, set DISP_PROP_P
1486 * bidi.c (bidi_fetch_char): Accept an additional argument
1487 DISP_PROP_P, and pass it to compute_display_string_pos.
1488 Only handle text covered by a display string if DISP_PROP_P is returned
1489 non-zero. All callers of bidi_fetch_char changed.
1491 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1493 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1495 2010-12-03 Don March <don@ohspite.net>
1497 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1498 last character M-[char] is translated to ESC [char] (bug#7541).
1500 2011-08-02 Kenichi Handa <handa@m17n.org>
1502 * lisp.h (uniprop_table): Extern it.
1504 * chartab.c (uniprop_table): Make it non-static.
1506 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1508 * xdisp.c (forward_to_next_line_start): Accept additional argument
1509 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1511 (reseat_at_next_visible_line_start): Use the bidi iterator state
1512 returned by forward_to_next_line_start to restore the state of
1513 it->bidi_it after backing up to previous newline. (Bug#9212)
1515 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1517 * regex.c (re_comp): Protoize.
1518 (re_exec): Fix return type.
1519 (regexec): Fix type of `ret'. (Bug#9203)
1521 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1523 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1524 This is needed if max-image-size is a floating-point number.
1526 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1528 * print.c (print_object): Print empty symbol as ##.
1530 * lread.c (read1): Read ## as empty symbol.
1532 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1534 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1535 setting frame foreground color (Bug#9175).
1536 (x_set_background_color): Likewise.
1538 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1539 contents (Bug#9176).
1540 (EmacsTooltip -init): Remove bezels and add shadows to
1543 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1544 or scroll bar (Bug#8470).
1546 * nsfont.m (nsfont_open): Remove assignment to voffset and
1547 unnecessary vars hshink, expand, hd, full_height, min_height.
1548 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1550 * nsterm.h (nsfont_info): Remove voffset field.
1552 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1554 Implement strike-through and overline on NextStep (Bug#8863).
1556 * nsfont.m (nsfont_open): Use underline position provided by font,
1557 instead of hard-coded value of 2.
1558 (nsfont_draw): Call ns_draw_text_decoration instead.
1560 * nsterm.h: Add declaration for ns_draw_text_decoration.
1562 * nsterm.m (ns_draw_text_decoration): New function for drawing
1563 underline, overline, and strike-through.
1564 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1565 ns_draw_text_decoration. Change treatment of cursor drawing to
1566 accommodate underlining, etc.
1568 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1570 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1573 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1575 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1576 Without this fix, if a signal arrives just after memory fills up,
1577 'malloc' might be invoked reentrantly.
1579 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1580 In other words, assume that every image size is allowed, on non-X
1581 hosts. This assumption is probably wrong, but it lets Emacs compile.
1583 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1585 * regex.c (re_iswctype): Convert return values to boolean.
1587 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1589 * xdisp.c (compute_display_string_pos): Don't use cached display
1590 string position if the buffer had its restriction changed.
1593 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1595 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1597 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1599 Integer signedness and overflow and related fixes. (Bug#9079)
1601 * bidi.c: Integer size and overflow fixes.
1602 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1603 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1604 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1605 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1606 (bidi_find_other_level_edge):
1607 Use ptrdiff_t instead of EMACS_INT where either will do.
1608 This works better on 32-bit hosts configured --with-wide-int.
1609 (bidi_cache_ensure_space): Check for size-calculation overflow.
1610 Use % rather than repeated addition, for better worst-case speed.
1611 Don't set bidi_cache_size until after xrealloc returns, because it
1613 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1614 (bidi_cache_ensure_space): Also check that the bidi cache size
1615 does not exceed that of the largest Lisp string or buffer. See Eli
1616 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1618 * alloc.c (__malloc_size_t): Remove.
1619 All uses replaced by size_t. See Andreas Schwab's note
1620 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1622 * image.c: Improve checking for integer overflow.
1623 (check_image_size): Assume that f is nonnull, since
1624 it is always nonnull in practice. This is one less thing to
1625 worry about when checking for integer overflow later.
1626 (x_check_image_size): New function, which checks for integer
1627 overflow issues inside X.
1628 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1629 This removes the need for a memory_full check.
1630 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1631 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1632 (xbm_read_bitmap_data): Change locals back to 'int', since
1633 their values must fit in 'int'.
1634 (xpm_load_image, png_load, tiff_load):
1635 Invoke x_create_x_image_and_pixmap earlier,
1636 to avoid much needless work if the image is too large.
1637 (tiff_load): Treat overly large images as if
1638 x_create_x_image_and_pixmap failed, not as malloc failures.
1639 (gs_load): Use x_check_image_size.
1641 * gtkutil.c: Omit integer casts.
1642 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1643 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1645 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1647 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1648 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1649 would wrongly return t on a 64-bit host.
1651 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1652 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1653 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1654 and therefore cause GCC to emit a bogus diagnostic in some cases.
1656 * image.c: Integer signedness and overflow and related fixes.
1657 This is not an exhaustive set of fixes, but it's time to
1658 record what I've got.
1659 (lookup_pixel_color, check_image_size): Remove redundant decls.
1660 (check_image_size): Don't assume that arbitrary EMACS_INT values
1661 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1662 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1663 (tiff_load, imagemagick_load_image):
1664 Check for overflow in size calculations.
1665 (x_create_x_image_and_pixmap): Remove unnecessary test for
1666 xmalloc returning NULL; that can't happen.
1667 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1668 (xpm_color_bucket): Use better integer hashing function.
1669 (xpm_cache_color): Don't possibly over-allocate memory.
1670 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1671 (gif_memory_source):
1672 Use ptrdiff_t, not int or size_t, to record sizes.
1673 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1674 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1675 either works, as we prefer signed integers.
1676 (tiff_read_from_memory, tiff_write_from_memory):
1677 Return tsize_t, not size_t, since that's what the TIFF API wants.
1678 (tiff_read_from_memory): Don't fail simply because the read would
1679 go past EOF; instead, return a short read.
1680 (tiff_load): Omit no-longer-needed casts.
1681 (Fimagemagick_types): Don't assume size fits into 'int'.
1683 Improve hashing quality when configured --with-wide-int.
1684 * fns.c (hash_string): New function, taken from sxhash_string.
1685 Do not discard information about ASCII character case; this
1686 discarding is no longer needed.
1687 (sxhash-string): Use it. Change sig to match it. Caller changed.
1688 * lisp.h: Declare it.
1689 * lread.c (hash_string): Remove, since we now use fns.c's version.
1690 The fns.c version returns a wider integer if --with-wide-int is
1691 specified, so this should help the quality of the hashing a bit.
1693 * emacs.c: Integer overflow minor fix.
1694 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1695 Define only if GNU_LINUX.
1696 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1698 * dispnew.c: Integer signedness and overflow fixes.
1699 Remove unnecessary forward decls, that were a maintenance hassle.
1700 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1702 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1703 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1704 (prepare_desired_row, line_draw_cost):
1705 Use int, not unsigned, where either works.
1706 (save_current_matrix, restore_current_matrix):
1707 Use ptrdiff_t, not size_t, where either works.
1708 (init_display): Check for overflow more accurately, and without
1709 relying on undefined behavior.
1711 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1712 Remove, replacing with the new symbols in lisp.h. All uses changed.
1713 * fileio.c (make_temp_name):
1714 * filelock.c (lock_file_1, lock_file):
1715 * xdisp.c (message_dolog):
1716 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1717 Use pMd etc. instead.
1718 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1719 replacing the pWIDE etc. symbols removed from editfns.c.
1721 * keyboard.h (num_input_events): Now uintmax_t.
1722 This is (very slightly) less likely to mess up due to wraparound.
1725 * buffer.c: Integer signedness fixes.
1726 (alloc_buffer_text, enlarge_buffer_text):
1727 Use ptrdiff_t rather than size_t when either will do, as we prefer
1730 * alloc.c: Integer signedness and overflow fixes.
1731 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1732 (__malloc_size_t): Default to size_t, not to int.
1733 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1734 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1735 Prefer ptrdiff_t to size_t when either would do, as we prefer
1737 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1738 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1739 Now const. Initialize with values that are in range even if char
1741 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1742 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1743 These functions do the right thing with sizes > 2**32.
1744 (check_depth): Now ptrdiff_t, not int.
1745 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1746 Adjust to new way of storing sizes. Check for size overflow bugs
1748 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1749 slightly wrong anyway, as it missed one instance of
1750 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1751 (refill_memory_reserve): Omit needless cast to size_t.
1752 (mark_object_loop_halt): Mark as externally visible.
1754 * xselect.c: Integer signedness and overflow fixes.
1755 (Fx_register_dnd_atom, x_handle_dnd_message):
1756 Use ptrdiff_t, not size_t, since we prefer signed.
1757 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1758 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1759 x_dnd_atoms_size and x_dnd_atoms_length.
1761 * doprnt.c: Prefer signed to unsigned when either works.
1763 * doprnt.c (doprnt):
1765 * xdisp.c (vmessage):
1766 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1767 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1768 prefer signed arithmetic to avoid comparison confusion.
1769 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1770 but is a bit tricky.
1772 Assume freestanding C89 headers, string.h, stdlib.h.
1773 * data.c, doprnt.c, floatfns.c, print.c:
1774 Include float.h unconditionally.
1775 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1776 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1777 * regex.c: Likewise for stddef.h, string.h.
1778 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1779 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1780 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1781 (STDC_HEADERS): Remove obsolete defines.
1782 * sysdep.c: Include limits.h unconditionally.
1784 Assume support for memcmp, memcpy, memmove, memset.
1785 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1786 * regex.c (memcmp, memcpy):
1787 Remove; we assume C89 now.
1789 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1790 (__malloc_safe_bcopy): Remove; no longer needed.
1792 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1793 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1794 well either way, and we prefer signed to unsigned.
1796 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1798 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1799 closes the connection while we're reading (bug#9182).
1801 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1803 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1804 are specified (Bug#9168).
1806 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1808 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1809 Found by GCC static checking and --with-wide-int on a 32-bit host.
1811 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1813 * xdisp.c (compute_display_string_pos): Fix logic of caching
1814 previous display string position. Initialize cached_prev_pos to
1815 -1. Fixes slow-down at the beginning of a buffer.
1817 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1819 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1820 for attrs[LFACE_FONTSET_INDEX].
1822 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1824 * xml.c (parse_region): Remove unused local
1825 that was recently introduced.
1827 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1829 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1830 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1832 * xdisp.c (move_it_in_display_line_to): Record the best matching
1833 position for TO_CHARPOS while scanning the line, and restore it on
1834 exit if none of the characters scanned was an exact match.
1835 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1836 when exact match is impossible due to invisible text, and the
1837 lines are truncated.
1839 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1841 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1844 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1846 Fix a significant slow-down of cursor motion with C-n, C-p,
1847 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1848 auto-repeat under bidi redisplay in fontified buffers.
1849 * xdisp.c (compute_stop_pos_backwards): New function.
1850 (next_element_from_buffer): Call compute_stop_pos_backwards to
1851 find a suitable prev_stop when we find ourselves before
1853 (reseat): Don't look for prev_stop, as that could mean a very long
1855 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1856 <cached_disp_overlay_modiff>: Cache for last found display string
1858 (compute_display_string_pos): Return the cached position if asked
1859 about the same buffer in the same area of character positions, and
1860 the buffer wasn't changed since the time the display string
1861 position was cached.
1863 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1865 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1866 is an integer, which is important for empty lines. (Bug#9149)
1868 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1870 * frame.c (Fmodify_frame_parameters): In tty case, update the
1871 default face if necessary (Bug#4238).
1873 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1875 * editfns.c (Fstring_to_char): No need to explain what a character
1876 is in the docstring (Bug#6576).
1878 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1880 * xml.c (parse_region): Make sure we always return a tree.
1882 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1884 * xml.c (parse_region): If a document contains only comments,
1887 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1889 * xml.c (make_dom): Return comments, too.
1891 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1894 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1895 and the surrounding thread.
1896 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1897 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1898 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1900 * s/openbsd.h (BROKEN_SIGIO): Define.
1901 * unexelf.c (unexec) [__OpenBSD__]:
1902 Don't update the .mdebug section of the Alpha COFF symbol table.
1904 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1906 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1909 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1911 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1912 This fixes some race conditions on the permissions of any newly
1915 * alloc.c (valid_pointer_p): Use pipe, not open.
1916 This fixes some permissions issues when debugging.
1918 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1919 If fchown fails to set both uid and gid, try to set just gid,
1920 as that is sometimes allowed. Adjust the file's mode to eliminate
1921 setuid or setgid bits that are inappropriate if fchown fails.
1923 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1925 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1926 to compare Lisp_Objects.
1927 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1928 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1929 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1931 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1933 * lread.c (read_integer): Unread even EOF character.
1934 (read1): Likewise. Properly record start position of symbol.
1936 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1937 symbol character follows.
1939 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1941 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1942 This works around a problem with the previous change to Fcopy_file.
1943 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1944 and without this change, GCC might complain about discarding
1945 fchown's return value.
1947 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1949 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1951 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1953 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1955 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1957 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1958 it's used from the C level.
1960 * process.c: Use the same condition for POLL_FOR_INPUT in both
1961 keyboard.c and process.c (bug#1858).
1963 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1965 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1966 (Fgnutls_boot): Use it.
1968 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1970 * doc.c (Fsubstitute_command_keys): Revert last change.
1972 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1974 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1975 quotes the next character, and doesn't affect other longer
1976 sequences (bug#8935).
1978 * lread.c (syms_of_lread): Clarify that is isn't only
1979 `eval-buffer' and `eval-defun' that's affected by
1980 `lexical-binding' (bug#8460).
1982 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1984 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1985 bidi redisplay when a line includes both an image and is
1988 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1990 Fix minor problems found by static checking.
1991 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1992 (elsz): Now a signed constant, not a size_t var. We prefer signed
1993 types to unsigned, to avoid integer comparison confusion. Without
1994 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1995 "cannot optimize loop, the loop counter may overflow", a symptom
1997 * indent.c (Fvertical_motion): Mark locals as initialized.
1998 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2000 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2002 * search.c (Fre_search_backward): Mention `case-fold-search' in
2003 all the re_search_* functions (bug#8138).
2005 * keyboard.c (Fopen_dribble_file): Document when the file is
2008 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2010 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2013 Support bidi reordering of display and overlay strings.
2014 * xdisp.c (compute_display_string_pos)
2015 (compute_display_string_end): Accept additional argument STRING.
2016 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2017 (reseat_to_string): Initialize bidi_it->string.s and
2018 bidi_it->string.schars.
2019 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2020 NULL (avoids a crash in bidi_paragraph_init).
2021 Initialize itb.string.lstring.
2022 (init_iterator): Call bidi_init_it only of a valid
2023 buffer position was specified. Initialize paragraph_embedding to
2025 (reseat_to_string): Initialize the bidi iterator.
2026 (display_string): If we need to ignore text properties of
2027 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2028 original value of -1 will not work with bidi.)
2029 (compute_display_string_pos): First arg is now struct
2030 `text_pos *'; all callers changed. Support display properties on
2032 (compute_display_string_end): Support display properties on Lisp
2034 (init_iterator, reseat_1, reseat_to_string): Initialize the
2035 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2036 when iterating on a string not from display properties).
2037 (compute_display_string_pos, compute_display_string_end):
2038 Fix calculation of the object to scan. Fixes an error when using
2040 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2041 base_level_stop; instead, set base_level_stop to BEGV.
2042 Fixes crashes in vertical-motion.
2043 (next_element_from_buffer): Improve commentary for when
2044 the iterator is before prev_stop.
2045 (init_iterator): Initialize bidi_p from the default value of
2046 bidi-display-reordering, not from buffer-local value. Use the
2047 buffer-local value only if initializing for buffer iteration.
2048 (handle_invisible_prop): Support invisible properties on strings
2049 that are being bidi-reordered.
2050 (set_iterator_to_next): Support bidi reordering of C strings and
2052 (next_element_from_string): Support bidi reordering of Lisp
2054 (handle_stop_backwards): Support Lisp strings as well.
2055 (display_string): Support display of R2L glyph rows.
2056 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2057 (init_iterator): Don't initialize it->bidi_p for strings
2059 (reseat_to_string): Initialize it->bidi_p for strings here.
2060 (next_element_from_string, next_element_from_c_string)
2061 (next_element_from_buffer): Add xassert's for correspondence
2062 between IT's object being iterated and it->bidi_it.string
2064 (face_before_or_after_it_pos): Support bidi iteration.
2065 (next_element_from_c_string): Handle the case of the first string
2066 character that is not the first one in the visual order.
2067 (get_visually_first_element): New function, refactored from common
2068 parts of next_element_from_buffer, next_element_from_string, and
2069 next_element_from_c_string.
2070 (tool_bar_lines_needed, redisplay_tool_bar)
2071 (display_menu_bar): Force left-to-right direction. Add a FIXME
2072 comment for making that be controlled by a user option.
2073 (push_it, pop_it): Save and restore the state of the
2074 bidi iterator. Save and restore the bidi_p flag.
2075 (pop_it): Iterate out of display property for string iteration as
2077 (iterate_out_of_display_property): Support iteration over strings.
2078 (handle_single_display_spec): Set up it->bidi_it for iteration
2079 over a display string, and call bidi_init_it.
2080 (handle_single_display_spec, next_overlay_string)
2081 (get_overlay_strings_1, push_display_prop): Set up the bidi
2082 iterator for displaying display or overlay strings.
2083 (forward_to_next_line_start): Don't use the shortcut if
2085 (back_to_previous_visible_line_start): If handle_display_prop
2086 pushed the iterator stack, restore the internal state of the bidi
2087 iterator by calling bidi_pop_it same number of times.
2088 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2089 and we are bidi-iterating, don't decrement the iterator position;
2090 instead, set the first_elt flag in the bidi iterator, to produce
2092 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2093 (push_display_prop): xassert that we are iterating a buffer.
2094 (push_it, pop_it): Save and restore paragraph_embedding member.
2095 (handle_single_display_spec, next_overlay_string)
2096 (get_overlay_strings_1, reseat_1, reseat_to_string)
2097 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2098 correctly. Don't assume unibyte strings are not bidi-reordered.
2099 (compute_display_string_pos)
2100 (compute_display_string_end): Fix handling the case of C string.
2101 (push_it, pop_it): Save and restore from_disp_prop_p.
2102 (handle_single_display_spec, push_display_prop): Set the
2103 from_disp_prop_p flag.
2104 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2105 (pop_it): Call iterate_out_of_display_property only if we are
2106 popping after iteration over a string that came from a display
2107 property. Fix a typo in popping stretch info. Add an assertion
2108 for verifying that the iterator position is in sync with the bidi
2110 (handle_single_display_spec, get_overlay_strings_1)
2111 (push_display_prop): Fix initialization of paragraph direction for
2112 string when that of the parent object is not yet determined.
2113 (reseat_1): Call bidi_init_it to resync the bidi
2114 iterator with IT's position. (Bug#7616)
2115 (find_row_edges): If ROW->start.pos gives position
2116 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2117 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2118 Reset the from_disp_prop_p flag.
2119 (SAVE_IT, RESTORE_IT): New macros.
2120 (pos_visible_p, face_before_or_after_it_pos)
2121 (back_to_previous_visible_line_start)
2122 (move_it_in_display_line_to, move_it_in_display_line)
2123 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2124 (try_scrolling, redisplay_window, display_line): Use them when
2125 saving a temporary copy of the iterator and restoring it back.
2126 (back_to_previous_visible_line_start, reseat_1)
2127 (init_iterator): Empty the bidi cache "stack".
2128 (move_it_in_display_line_to): If iterator ended up at
2129 EOL, but we never saw any buffer positions smaller than
2130 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2131 motion in bidi-reordered lines.
2132 (move_it_in_display_line_to): Record prev_method and prev_pos
2133 immediately before the call to set_iterator_to_next. Fixes cursor
2134 motion in bidi-reordered lines with stretch glyphs and strings
2135 displayed in margins. (Bug#8133) (Bug#8867)
2136 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2138 (pos_visible_p): Support positions in bidi-reordered lines.
2139 Save and restore bidi cache.
2141 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2142 (bidi_paragraph_info): Delete unused struct.
2143 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2144 (bidi_cache_start): New variable.
2145 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2147 (bidi_cache_fetch_state, bidi_cache_search)
2148 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2149 (bidi_cache_find, bidi_peek_at_next_level)
2150 (bidi_level_of_next_char, bidi_find_other_level_edge)
2151 (bidi_move_to_visually_next): Compare cache index with
2152 bidi_cache_start rather than with zero.
2153 (bidi_fetch_char): Accept new argument STRING; all callers
2154 changed. Support iteration over a string. Support strings with
2155 display properties. Support unibyte strings. Fix the type of
2156 `len' according to what STRING_CHAR_AND_LENGTH expects.
2157 (bidi_paragraph_init, bidi_resolve_explicit_1)
2158 (bidi_resolve_explicit, bidi_resolve_weak)
2159 (bidi_level_of_next_char, bidi_move_to_visually_next):
2160 Support iteration over a string.
2161 (bidi_set_sor_type, bidi_resolve_explicit_1)
2162 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2163 can now be zero (for strings); special values 0 and -1 were
2164 changed to -1 and -2, respectively.
2165 (bidi_char_at_pos): New function.
2166 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2167 Call it instead of FETCH_MULTIBYTE_CHAR.
2168 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2169 initialized to valid values.
2170 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2172 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2173 the test for valid cached positions. Fix the logic for looking up
2174 the sentinel state in the cache. GCPRO the Lisp string we are
2176 (bidi_push_it, bidi_pop_it): New functions.
2177 (bidi_initialize): Initialize the bidi cache start stack pointer.
2178 (bidi_cache_ensure_space): New function, refactored from part of
2179 bidi_cache_iterator_state. Don't assume the required size is just
2180 one BIDI_CACHE_CHUNK away.
2181 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2182 (bidi_count_bytes, bidi_char_at_pos): New functions.
2183 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2184 always valid if bidi_cache_idx is valid.
2185 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2186 is valid if it's going to be used.
2187 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2188 (bidi_cache_fetch_state, bidi_cache_search)
2189 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2190 (bidi_cache_iterator_state, bidi_cache_find)
2191 (bidi_find_other_level_edge, bidi_cache_start_stack):
2192 All variables related to cache indices are now EMACS_INT.
2194 * dispextern.h (struct bidi_string_data): New structure.
2195 (struct bidi_it): New member `string'. Make flag members be 1-bit
2196 fields, and put them last in the struct.
2197 (compute_display_string_pos, compute_display_string_end):
2199 (bidi_push_it, bidi_pop_it): Add prototypes.
2200 (struct iterator_stack_entry): New members bidi_p,
2201 paragraph_embedding, and from_disp_prop_p.
2202 (struct it): Member bidi_p is now a bit field 1 bit wide.
2203 (bidi_shelve_cache, bidi_unshelve_cache):
2206 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2207 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2208 and vector-like objects.
2210 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2211 cache around display iteration.
2213 * window.c (Fwindow_end, window_scroll_pixel_based)
2214 (displayed_window_lines, Frecenter): Save and restore the bidi
2215 cache around display iteration.
2217 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2219 * editfns.c (Fdelete_region): Clarify the use of the named
2220 parameters (bug#6788).
2222 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2224 * indent.c (Fvertical_motion): Set and restore w->pointm when
2225 saving and restoring the window's buffer (Bug#9006).
2227 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2229 * editfns.c (Fstring_to_char): Clarify just what is returned
2230 (bug#6576). Text by Eli Zaretskii.
2232 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2234 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2236 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2238 * buffer.c (mmap_find): Fix a typo.
2240 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2242 Fix execution of x selection hooks.
2243 * xselect.c (Qx_lost_selection_functions)
2244 (Qx_sent_selection_functions): New vars.
2245 (syms_of_xselect): DEFSYM them.
2246 (x_handle_selection_request): Pass Qx_sent_selection_functions
2247 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2248 (x_handle_selection_clear,x_clear_frame_selections):
2249 Pass Qx_lost_selection_functions rather than
2250 Vx_lost_selection_functions to Frun_hook_with_args.
2252 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2254 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2255 The old code sometimes used this field without initializing it.
2257 * alloc.c (gc_sweep): Don't read past end of array.
2258 In theory, the old code could also have corrupted Emacs internals,
2259 though it'd be very unlikely.
2261 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2263 * character.c (Fcharacterp): Don't advertise optional ignored
2264 argument. (Bug#4026)
2266 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2268 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2271 * window.c (Fset_window_start): Doc fix (bug#4199).
2272 (Fset_window_hscroll): Ditto.
2274 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2276 Fix minor new problems caught by GCC 4.6.1.
2277 * term.c (init_tty): Remove unused local.
2278 * xsettings.c (store_monospaced_changed): Define this function only
2279 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2282 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2284 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2286 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2288 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2289 are the mini-buffer and the echo area (bug#3320).
2291 * term.c (init_tty): Remove support for supdup, c10 and perq
2292 terminals, which are no longer supported (bug#1482).
2294 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2296 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2298 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2300 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2301 for non-popups (Bug#3642).
2303 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2305 * alloc.c (reset_malloc_hooks): Protoize.
2306 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2307 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2308 * cm.c (losecursor): Likewise.
2309 * data.c (fmod): Likewise.
2310 * dispnew.c (swap_glyphs_in_rows): Likewise.
2311 * emacs.c (memory_warning_signal): Likewise.
2312 * floatfns.c (float_error): Likewise.
2313 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2314 (otf_open, font_otf_capability, generate_otf_features)
2315 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2317 * image.c (pbm_read_file): Likewise.
2318 * indent.c (string_display_width): Likewise.
2319 * intervals.c (check_for_interval, search_for_interval)
2320 (inc_interval_count, count_intervals, root_interval)
2321 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2322 * lread.c (defalias): Likewise.
2323 * ralloc.c (r_alloc_check): Likewise.
2324 * regex.c (set_image_of_range_1, set_image_of_range)
2325 (regex_grow_registers): Likewise.
2326 * sysdep.c (strerror): Likewise.
2327 * termcap.c (valid_filename_p, tprint, main): Likewise.
2328 * tparam.c (main): Likewise.
2329 * unexhp9k800.c (run_time_remap, save_data_space)
2330 (update_file_ptrs, read_header, write_header, calculate_checksum)
2331 (copy_file, copy_rest, display_header): Likewise.
2332 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2334 * xdisp.c (check_it): Likewise.
2335 * xfaces.c (register_color, unregister_color, unregister_colors):
2337 * xfns.c (print_fontset_result): Likewise.
2338 * xrdb.c (member, fatal, main): Likewise.
2340 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2342 Fix minor problems found by static checking (Bug#9031).
2343 * chartab.c (char_table_set_range, map_sub_char_table):
2344 Remove unused locals.
2345 (uniprop_table): Now static.
2346 * composite.c (_work_char): Remove unused static var.
2348 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2350 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2352 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2354 * gtkutil.c (qttip_cb): Remove code without function.
2356 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2358 * w32.c (pthread_sigmask): New stub.
2360 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2362 Use pthread_sigmask, not sigprocmask (Bug#9010).
2363 sigprocmask is portable only for single-threaded applications, and
2364 Emacs can be multi-threaded when it uses GTK.
2365 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2367 * callproc.c (Fcall_process):
2368 * process.c (create_process):
2369 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2370 Use pthread_sigmask, not sigprocmask.
2372 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2374 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2375 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2378 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2380 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2381 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2382 (xg_hide_tooltip): Fix comment.
2384 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2385 in registerServicesMenuSendTypes.
2386 (validRequestorForSendType): Don't check ns_return_types.
2388 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2391 2011-07-08 Jason Rumney <jasonr@gnu.org>
2393 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2394 frame struct members of non-existent frames (Bug#6284).
2396 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2398 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2399 variable firstTime not needed on OSX >= 10.6.
2400 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2401 >= 10.5. Use setKnobProportion, setDoubleValue.
2403 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2404 (MAC_OS_X_VERSION_10_5): Define if not defined.
2405 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2406 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2407 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2409 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2410 cString and lossyCString on OSX >= 10.4
2412 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2413 sizeToFit on OSX >= 10.2.
2415 * nsimage.m (allocInitFromFile): Don't use deprecated method
2416 bestRepresentationForDevice on OSX >= 10.6.
2418 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2421 * emacs.c: Declare unexec_init_emacs_zone.
2423 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2425 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2427 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2428 on svcsMenu (Bug#8842).
2430 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2432 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2434 * nsterm.m (QUTF8_STRING): Declare.
2435 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2436 (validRequestorForSendType): Return type is (id).
2437 Change indexOfObjectIdenticalTo to indexOfObject.
2438 Check if we have local selection before returning self (Bug#8842).
2439 (writeSelectionToPasteboard): Put local selection into paste board
2440 if we have a local selection (Bug#8842).
2441 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2443 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2444 (ns_get_local_selection): Declare.
2446 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2448 * keymap.c (describe_map_tree): Don't insert a double newline at
2449 the end of the buffer (bug#1169) and return whether we inserted
2452 * callint.c (Fcall_interactively): Change "reading args" to
2453 "providing args" to try to clarify what it does (bug#1010).
2455 2011-07-07 Kenichi Handa <handa@m17n.org>
2457 * composite.c (composition_compute_stop_pos): Ignore a static
2458 composition starting before CHARPOS (Bug#8915).
2460 * xdisp.c (handle_composition_prop): Likewise.
2462 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2464 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2467 2011-07-07 Kenichi Handa <handa@m17n.org>
2469 * character.h (unicode_category_t): New enum type.
2471 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2472 (Qchar_code_property_table): New variable.
2473 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2474 (UNIPROP_COMPRESSED_FORM_P): New macros.
2475 (char_table_ascii): Uncompress the compressed values.
2476 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2477 Uncompress the compressed values.
2478 (sub_char_table_ref_and_range): Likewise.
2479 (char_table_ref_and_range): Uncompress the compressed values.
2480 (sub_char_table_set): New arg is_uniprop. Callers changed.
2481 Uncompress the compressed values.
2482 (sub_char_table_set_range): Args changed. Callers changed.
2483 (char_table_set_range): Adjuted for the above change.
2484 (map_sub_char_table): Delete args default_val and parent. Add arg
2485 top. Give decoded values to a Lisp function.
2486 (map_char_table): Adjust for the above change. Give decoded
2487 values to a Lisp function. Gcpro more variables.
2488 (uniprop_table_uncompress)
2489 (uniprop_decode_value_run_length): New functions.
2490 (uniprop_decoder, uniprop_decoder_count): New variables.
2491 (uniprop_get_decoder, uniprop_encode_value_character)
2492 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2494 (uniprop_encoder, uniprop_encoder_count): New variables.
2495 (uniprop_get_encoder, uniprop_table)
2496 (Funicode_property_table_internal, Fget_unicode_property_internal)
2497 (Fput_unicode_property_internal): New functions.
2498 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2499 Sunicode_property_table_internal, Sget_unicode_property_internal,
2500 and Sput_unicode_property_internal. Defvar_lisp
2501 char-code-property-alist.
2503 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2504 Vunicode_category_table.
2506 * font.c (font_range): Adjust for the change of
2507 Vunicode_category_table.
2509 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2511 * m/iris4d.h: Remove file, move contents ...
2512 * s/irix6-5.h: ... here.
2514 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2516 Remove unportable assumption about struct layout (Bug#8884).
2517 * alloc.c (mark_buffer):
2518 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2519 (clone_per_buffer_values): Don't assume that
2520 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2521 This isn't true in general, and it's particularly not true
2522 if Emacs is configured with --with-wide-int.
2523 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2524 New macros, used in the buffer.c change.
2526 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2528 * xsettings.c: Use both GConf and GSettings if both are available.
2529 (store_config_changed_event): Add comment.
2530 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2531 (store_tool_bar_style_changed): New functions.
2532 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2533 (struct xsettings): Move font inside HAVE_XFT.
2534 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2535 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2536 Move inside HAVE_XFT.
2537 (something_changed_gsettingsCB): Rename from something_changedCB.
2538 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2540 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2541 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2542 (something_changed_gconfCB): Rename from something_changedCB.
2543 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2544 (parse_settings): Move check for font inside HAVE_XFT.
2545 (read_settings, apply_xft_settings): Add comment.
2546 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2547 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2548 call store_font_name_changed.
2549 (xft_settings_event): Add comment.
2550 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2551 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2552 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2553 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2554 (xsettings_initialize): Call init_gsettings last.
2555 (xsettings_get_system_font, xsettings_get_system_normal_font):
2558 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2560 Random fixes. E.g., (random) never returned negative values.
2561 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2562 subseconds part to the entropy, as that's a bit more random.
2563 Prefer signed to unsigned, since the signedness doesn't matter and
2564 in general we prefer signed. When given a limit, use a
2565 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2566 latter isn't right if USE_2_TAGS_FOR_INTS.
2567 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2568 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2570 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2572 * textprop.c (text_property_stickiness):
2573 Obey Vtext_property_default_nonsticky.
2574 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2575 * w32fns.c (syms_of_w32fns):
2576 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2578 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2580 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2581 This is more efficient than Ffile_directory_p and avoids a minor race.
2583 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2585 * buffer.c (Foverlay_put): Say what the return value is
2588 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2589 is a directory before asking whether to use the file name
2591 (barf_or_query_if_file_exists): Make the "File is a directory"
2592 error be more correct.
2594 * fns.c (Frequire): Remove the mention of the .gz files, since
2595 that's installation-specific, but keep the mention of
2596 `get-load-suffixes'.
2598 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2600 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2601 Report string overflow if the output is too long.
2603 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2605 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2606 (syms_of_gnutls): Remove duplicate DEFSYM for
2607 Qgnutls_bootprop_verify_hostname_error, an error for
2608 Qgnutls_bootprop_verify_error (which is no longer used).
2610 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2611 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2612 Also (re)move comments that are misplaced or no longer relevant.
2614 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2616 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2618 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2620 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2621 and background color parameters if they have been changed.
2623 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2625 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2627 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2629 * xsettings.c (SYSTEM_FONT): Define only when used.
2630 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2632 * keymap.c (access_keymap_1): Now static.
2634 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2636 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2637 leave any prefix arg for the up event (Bug#1586).
2639 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2641 * lread.c (syms_of_lread): Mention single symbols defined by
2642 `defvar' or `defconst' (bug#7154).
2644 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2645 (Frequire): Mention get-load-suffixes.
2647 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2649 * window.h (window): Remove clone_number slot.
2650 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2652 (make_parent_window, make_window, saved_window)
2653 (Fset_window_configuration, save_window_save): Don't deal with
2655 * buffer.c (Qclone_number): Remove declaration.
2656 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2658 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2660 Add multiple inheritance to keymaps.
2661 * keymap.c (Fmake_composed_keymap): New function.
2662 (Fset_keymap_parent): Simplify.
2663 (fix_submap_inheritance): Remove.
2664 (access_keymap_1): New function extracted from access_keymap to handle
2665 embedded parents and handle lists of maps.
2666 (access_keymap): Use it.
2667 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2668 (Fcopy_keymap): Handle embedded parents.
2669 (Fcommand_remapping, define_as_prefix): Simplify.
2670 (Fkey_binding): Simplify.
2671 (syms_of_keymap): Move minibuffer-local-completion-map,
2672 minibuffer-local-filename-completion-map,
2673 minibuffer-local-must-match-map, and
2674 minibuffer-local-filename-must-match-map to Elisp.
2675 (syms_of_keymap): Defsubr make-composed-keymap.
2676 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2677 (parse_menu_item): Trivial simplification.
2679 2011-07-01 Glenn Morris <rgm@gnu.org>
2681 * Makefile.in (SETTINGS_LIBS): Fix typo.
2683 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2685 * coding.c (Fencode_coding_string): Record the last coding system
2686 used, as the function doc string says (bug#8738).
2688 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2690 * xsettings.c (store_monospaced_changed): Take new font as arg and
2691 check for change against current_mono_font.
2692 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2693 (emacs_settings_constructor, emacs_settings_get_property)
2694 (emacs_settings_set_property, emacs_settings_class_init)
2695 (emacs_settings_init, gsettings_obj): Remove.
2696 (something_changedCB): New function for HAVE_GSETTINGS.
2697 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2698 with value as argument.
2699 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2700 g_settings_new (Bug#8967). Do not create gsettings_obj.
2701 Remove calls to g_settings_bind. Connect something_changedCB to
2704 * xgselect.c: Add defined (HAVE_GSETTINGS).
2705 (xgselect_initialize): Ditto.
2707 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2708 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2711 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2713 * eval.c (struct backtrace): Simplify and port the data structure.
2714 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2715 signed bit field, as this assumption is not portable and it makes
2716 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2717 "char debug_on_exit : 1" as this is not portable either; instead,
2718 use the portable "unsigned int debug_on_exit : 1". Remove unused
2719 member evalargs. Remove obsolete comments about cc bombing out.
2721 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2723 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2724 Let HAVE_GSETTINGS override HAVE_GCONF.
2725 (store_monospaced_changed): New function.
2726 (EMACS_SETTINGS): A new type derived from GObject to handle
2727 GSettings notifications.
2728 (emacs_settings_constructor, emacs_settings_get_property)
2729 (emacs_settings_set_property, emacs_settings_class_init):
2731 (gsettings_client, gsettings_obj): New variables.
2732 (GSETTINGS_SCHEMA): New define.
2733 (something_changedCB): Call store_monospaced_changed.
2734 (init_gsettings): New function.
2735 (xsettings_initialize): Call init_gsettings.
2736 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2739 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2742 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2744 * window.c (resize_root_window, grow_mini_window)
2745 (shrink_mini_window): Rename Qresize_root_window to
2746 Qwindow_resize_root_window and Qresize_root_window_vertically to
2747 Qwindow_resize_root_window_vertically.
2749 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2751 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2753 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2755 * makefile.w32-in: Redesign dependencies so they reflect more
2756 clearly which files are directly included by each source file,
2757 and not through other includes.
2759 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2761 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2762 (sort_overlays, overlay_strings): When an overlay's clone number
2763 matches the window's clone number process the overlay even if
2764 the overlay's window property doesn't match the current window.
2766 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2767 (Fwindow_hchild): Rename to Fwindow_left_child.
2768 (Fwindow_next): Rename to Fwindow_next_sibling.
2769 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2770 (resize_window_check): Rename to window_resize_check.
2771 (resize_window_apply): Rename to window_resize_apply.
2772 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2773 (Fdelete_other_windows_internal, resize_frame_windows)
2774 (Fsplit_window_internal, Fdelete_window_internal)
2775 (grow_mini_window, shrink_mini_window)
2776 (Fresize_mini_window_internal): Fix callers accordingly.
2778 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2780 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2781 (emacs_fixed_set_min_size): Remove.
2782 (emacs_fixed_new): Take frame as argument.
2784 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2785 (_EmacsFixedPrivate): Remove minwidth/height.
2786 Add struct frame *f.
2787 (emacs_fixed_init): Initialize priv->f.
2788 (get_parent_class, emacs_fixed_set_min_size): Remove.
2789 (emacs_fixed_new): Set priv->f to argument.
2790 (emacs_fixed_get_preferred_width)
2791 (emacs_fixed_get_preferred_height): Use min_width/height from
2792 frames size_hint to set minimum and natural (Bug#8919).
2793 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2794 and use min_width/height from frames size_hint to set
2795 min_width/height (Bug#8919).
2797 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2798 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2801 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2803 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2804 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2807 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2809 * process.c (wait_reading_process_output): Bypass select if
2810 waiting for a cell while ignoring keyboard input, and input is
2811 pending. Suggested by Jan Djärv (Bug#8869).
2813 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2815 Use gnulib's dup2 module instead of rolling our own.
2816 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2818 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2820 * dispnew.c (scrolling_window): Before scrolling, turn off a
2821 mouse-highlight in the window being scrolled.
2823 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2825 Move DEFSYM to lisp.h and use everywhere.
2827 * character.h (DEFSYM): Move declaration...
2828 * lisp.h (DEFSYM): ...here.
2834 * w32select.c: Don't include character.h.
2836 * alloc.c (syms_of_alloc):
2837 * buffer.c (syms_of_buffer):
2838 * bytecode.c (syms_of_bytecode):
2839 * callint.c (syms_of_callint):
2840 * casefiddle.c (syms_of_casefiddle):
2841 * casetab.c (init_casetab_once):
2842 * category.c (init_category_once, syms_of_category):
2843 * ccl.c (syms_of_ccl):
2844 * cmds.c (syms_of_cmds):
2845 * composite.c (syms_of_composite):
2846 * dbusbind.c (syms_of_dbusbind):
2847 * dired.c (syms_of_dired):
2848 * dispnew.c (syms_of_display):
2849 * doc.c (syms_of_doc):
2850 * editfns.c (syms_of_editfns):
2851 * emacs.c (syms_of_emacs):
2852 * eval.c (syms_of_eval):
2853 * fileio.c (syms_of_fileio):
2854 * fns.c (syms_of_fns):
2855 * frame.c (syms_of_frame):
2856 * fringe.c (syms_of_fringe):
2857 * insdel.c (syms_of_insdel):
2858 * keymap.c (syms_of_keymap):
2859 * lread.c (init_obarray, syms_of_lread):
2860 * macros.c (syms_of_macros):
2861 * msdos.c (syms_of_msdos):
2862 * print.c (syms_of_print):
2863 * process.c (syms_of_process):
2864 * search.c (syms_of_search):
2865 * sound.c (syms_of_sound):
2866 * syntax.c (init_syntax_once, syms_of_syntax):
2867 * terminal.c (syms_of_terminal):
2868 * textprop.c (syms_of_textprop):
2869 * undo.c (syms_of_undo):
2870 * w32.c (globals_of_w32):
2871 * window.c (syms_of_window):
2872 * xdisp.c (syms_of_xdisp):
2873 * xfaces.c (syms_of_xfaces):
2874 * xfns.c (syms_of_xfns):
2875 * xmenu.c (syms_of_xmenu):
2876 * xsettings.c (syms_of_xsettings):
2877 * xterm.c (syms_of_xterm): Use DEFSYM.
2879 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2881 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2883 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2885 Integer and buffer overflow fixes (Bug#8873).
2887 * print.c (printchar, strout): Check for string overflow.
2888 (PRINTPREPARE, printchar, strout):
2889 Don't set size unless allocation succeeds.
2891 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2892 for sizes. Check for string overflow more accurately.
2893 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2895 * macros.c: Integer and buffer overflow fixes.
2896 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2897 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2898 Use ptrdiff_t, not int, for sizes.
2899 Don't increment bufsize until after realloc succeeds.
2900 Check for size-calculation overflow.
2901 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2903 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2905 * lread.c: Integer overflow fixes.
2906 (read_integer): Radix is now EMACS_INT, not int,
2907 to improve quality of diagnostics for out-of-range radices.
2908 Calculate buffer size correctly for out-of-range radices.
2909 (read1): Check for integer overflow in radices, and in
2910 read-circle numbers.
2911 (read_escape): Avoid int overflow.
2912 (Fload, openp, read_buffer_size, read1)
2913 (substitute_object_recurse, read_vector, read_list, map_obarray):
2914 Use ptrdiff_t, not int, for sizes.
2915 (read1): Use EMACS_INT, not int, for sizes.
2916 Check for size overflow.
2918 * image.c (cache_image): Check for size arithmetic overflow.
2920 * lread.c: Integer overflow issues.
2921 (saved_doc_string_size, saved_doc_string_length)
2922 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2923 Now ptrdiff_t, not int.
2924 (read1): Don't assume doc string length fits in int. Check for
2925 out-of-range doc string lengths.
2926 (read_list): Don't assume file position fits in int.
2927 (read_escape): Check for hex character overflow.
2929 2011-06-22 Leo Liu <sdl.web@gmail.com>
2931 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2932 Move to minibuffer.el.
2934 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2936 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2937 The following patches are for when GLYPH_DEBUG && !XASSERT.
2938 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2939 * dispnew.c (flush_stdout):
2940 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2941 Mark as externally visible.
2942 * dispnew.c (check_window_matrix_pointers): Now static.
2943 * dispnew.c (window_to_frame_vpos):
2944 * xfns.c (unwind_create_frame):
2945 * xterm.c (x_check_font): Remove unused local.
2946 * scroll.c (CHECK_BOUNDS):
2947 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2948 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2949 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2950 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2951 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2953 (debug_method_add): Use va_list and vsprintf rather than relying
2954 on undefined behavior with wrong number of arguments.
2955 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2956 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2957 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2958 since we're not interested in debugging glyphs with old libraries.
2959 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2960 GCC 4.6.0's static checking.
2962 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2964 Integer overflow and signedness fixes (Bug#8873).
2965 A few related buffer overrun fixes, too.
2967 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2969 * dispextern.h (struct face.stipple):
2970 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2971 (x_bitmap_mask, x_allocate_bitmap_record)
2972 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2973 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2974 (x_create_bitmap_from_xpm_data):
2975 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2976 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2978 * xfaces.c (load_pixmap):
2979 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2980 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2981 (.bitmaps_last, struct x_output.icon_bitmap):
2982 Use ptrdiff_t, not int, for bitmap indexes.
2983 (x_allocate_bitmap_record): Check for size overflow.
2984 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2986 Use ptrdiff_t, not int, for overlay counts.
2987 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2988 * editfns.c (overlays_around, get_pos_property):
2989 * textprop.c (get_char_property_and_overlay):
2990 * xdisp.c (next_overlay_change, note_mouse_highlight):
2991 * xfaces.c (face_at_buffer_position):
2992 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2993 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2994 (Fnext_overlay_change, Fprevious_overlay_change)
2995 (mouse_face_overlay_overlaps, Foverlays_in):
2996 Use ptrdiff_t, not int, for sizes.
2997 (overlays_at, overlays_in): Check for size-calculation overflow.
2999 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3001 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3002 (x_session_initialize): Do not assume string length fits in int.
3004 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3005 This is unlikely, but can occur if DPI is outlandish.
3007 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3008 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3010 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3011 * xrdb.c (magic_file_p, search_magic_path):
3012 Omit last arg SUFFIX; it was always 0. All callers changed.
3013 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3015 * xfont.c (xfont_match): Avoid need for strlen.
3017 * xfns.c: Don't assume strlen fits in int.
3018 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3020 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3021 not unsigned long, as we prefer signed integers. All callers changed.
3022 Detect integer overflow in repeat count.
3023 (message_dolog): Don't assume print length fits in 39 bytes.
3024 (display_mode_element): Don't assume strlen fits in int.
3026 * termcap.c: Don't assume sizes fit in int and never overflow.
3027 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3028 (gobble_line): Check for size-calculation overflow.
3030 * minibuf.c (Fread_buffer):
3031 * lread.c (intern, intern_c_string):
3032 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3033 Don't assume string length fits in int.
3035 * keyboard.c (parse_tool_bar_item):
3036 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3038 * font.c: Don't assume string length fits in int.
3039 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3040 Use ptrdiff_t, not int.
3041 (font_intern_prop): Don't assume string length fits in int.
3042 Don't assume integer property fits in fixnum.
3043 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3045 * filelock.c: Fix some buffer overrun and integer overflow issues.
3046 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3047 Reformulate so as not to need the command string.
3048 Invoke gzip -cd rather than gunzip, as it's more portable.
3049 (lock_info_type, lock_file_1, lock_file):
3050 Don't assume pid_t and time_t fit in unsigned long.
3051 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3052 (current_lock_owner): Prefer signed type for sizes.
3053 Use memcpy, not strncpy, where memcpy is what is really wanted.
3054 Don't assume (via atoi) that time_t and pid_t fit in int.
3055 Check for time_t and/or pid_t out of range, e.g., via a network share.
3056 Don't alloca where an auto var works fine.
3058 * fileio.c: Fix some integer overflow issues.
3059 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3060 Don't assume string length fits in int.
3061 (directory_file_name): Don't assume string length fits in long.
3062 (make_temp_name): Don't assume pid fits in int, or that its print
3063 length is less than 20.
3065 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3067 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3069 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3071 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3072 We prefer signed integers, even for size calculations.
3074 * emacs.c: Don't assume string length fits in 'int'.
3075 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3076 (main): Don't invoke strlen when not needed.
3078 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3079 (XD_DEBUG_MESSAGE): Don't waste a byte.
3081 * callproc.c (getenv_internal_1, getenv_internal)
3083 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3085 * lread.c (invalid_syntax): Omit length argument.
3086 All uses changed. This doesn't fix a bug, but it simplifies the
3087 code away from its former Hollerith-constant appearance, and it's
3088 one less 'int' to worry about when looking at integer-overflow issues.
3089 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3091 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3092 This didn't break anything, but it didn't help either.
3093 It's confusing to put a bogus integer in a place where the actual
3094 value does not matter.
3095 (LIST_END_P): Remove unused macro and its bogus comment.
3096 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3098 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3099 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3101 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3102 We prefer signed types, and the value cannot exceed the EMACS_INT
3103 range anyway (because otherwise the length would not be representable).
3104 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3105 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3106 This avoids a GCC warning when WIDE_EMACS_INT.
3108 * indent.c (sane_tab_width): New function.
3109 (current_column, scan_for_column, Findent_to, position_indentation)
3110 (compute_motion): Use it. This is just for clarity.
3111 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3113 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3115 * lisp.h (lint_assume): New macro.
3116 * composite.c (composition_gstring_put_cache):
3117 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3119 * editfns.c, insdel.c:
3120 Omit unnecessary forward decls, to simplify future changes.
3122 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3124 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3126 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3127 Use much-faster test for byte-length change.
3128 Don't assume string byte-length fits in 'int'.
3129 Check that character arg fits in 'int'.
3130 (mapcar1): Declare byte as byte, for clarity.
3132 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3134 * fns.c (concat): Catch string overflow earlier.
3135 Do not rely on integer wraparound.
3137 * dispextern.h (struct it.overlay_strings_charpos)
3138 (struct it.selective): Now EMACS_INT, not int.
3139 * xdisp.c (forward_to_next_line_start)
3140 (back_to_previous_visible_line_start)
3141 (reseat_at_next_visible_line_start, next_element_from_buffer):
3142 Don't arbitrarily truncate the value of 'selective' to int.
3144 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3146 * composite.c: Don't truncate sizes to 'int'.
3147 (composition_gstring_p, composition_reseat_it)
3148 (composition_adjust_point): Use EMACS_INT, not int.
3149 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3150 not EMACS_UINT, for indexes.
3152 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3154 * buffer.c: Include <verify.h>.
3155 (struct sortvec.priority, struct sortstr.priority):
3156 Now EMACS_INT, not int.
3157 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3158 (struct sortstr.size, record_overlay_string)
3159 (struct sortstrlist.size, struct sortlist.used):
3160 Don't truncate size to int.
3161 (record_overlay_string): Check for size-calculation overflow.
3162 (init_buffer_once): Check at compile-time, not run-time.
3164 2011-06-22 Jim Meyering <meyering@redhat.com>
3166 Don't leak an XBM-image-sized buffer
3167 * image.c (xbm_load): Free the image buffer after using it.
3169 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3172 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3173 that Sun C diagnosed.
3174 * fns.c (secure_hash): Fix pointer signedness issue.
3175 * intervals.c (static_offset_intervals): New function.
3176 (offset_intervals): Use it.
3178 2011-06-21 Leo Liu <sdl.web@gmail.com>
3181 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3184 * fns.c (secure_hash): Rename from crypto_hash_function and change
3185 the first arg to accept symbols.
3186 (Fsecure_hash): New primitive.
3187 (syms_of_fns): New symbols.
3189 2011-06-20 Deniz Dogan <deniz@dogan.se>
3191 * process.c (Fset_process_buffer): Clarify return value in
3194 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3196 * dispnew.c (add_window_display_history): Use BVAR.
3198 * xdisp.c (debug_method_add): Use BVAR.
3199 (check_window_end, dump_glyph_matrix, dump_glyph)
3200 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3202 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3205 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3206 check till after the cache is created in init_frame_faces.
3208 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3210 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3212 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3214 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3215 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3216 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3218 Improve buffer-overflow checking (Bug#8873).
3219 * fileio.c (Finsert_file_contents):
3220 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3221 Remove the old (too-loose) buffer overflow checks.
3222 They weren't needed, since make_gap checks for buffer overflow.
3223 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3224 The old code merely checked for Emacs fixnum overflow, and relied
3225 on undefined (wraparound) behavior. The new code avoids undefined
3226 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3228 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3229 Tune. Don't use wider integers than needed. Don't use alloca.
3230 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3232 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3234 * insdel.c, lisp.h (buffer_overflow): New function.
3235 (insert_from_buffer_1, replace_range, replace_range_2):
3236 * insdel.c (make_gap_larger):
3237 * editfns.c (Finsert_char):
3238 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3240 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3242 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3244 Integer overflow and signedness fixes (Bug#8873).
3246 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3247 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3249 * fileio.c: Don't assume EMACS_INT fits in off_t.
3250 (emacs_lseek): New static function.
3251 (Finsert_file_contents, Fwrite_region): Use it.
3252 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3254 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3256 * fns.c: Don't overflow int when computing a list length.
3257 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3258 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3259 truncation on 64-bit hosts. Check for QUIT every
3260 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3261 faster and is responsive enough.
3262 (Flength): Report an error instead of overflowing an integer.
3263 (Fsafe_length): Return a float if the value is not representable
3264 as a fixnum. This shouldn't happen except in contrived situations.
3265 (Fnthcdr, Fsort): Don't assume list length fits in int.
3266 (Fcopy_sequence): Don't assume vector length fits in int.
3268 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3269 (header_size, word_size): New constants.
3270 (allocate_vectorlike): Don't check size overflow here.
3271 (allocate_vector): Check it here instead, since this is the only
3272 caller of allocate_vectorlike that could cause overflow.
3273 Check that the new vector's length is representable as a fixnum.
3275 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3276 The previous code was bogus. For example, next_almost_prime (32)
3277 returned 39, which is undesirable as it is a multiple of 3; and
3278 next_almost_prime (24) returned 25, which is a multiple of 5 so
3279 why was the code bothering to check for multiples of 7?
3281 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3283 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3285 Variadic C functions now count arguments with ptrdiff_t.
3286 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3287 Back then I didn't know that the Emacs coding style prefers signed int.
3288 Also, in the meantime I found a few more instances where arguments
3289 were being counted with int, which may truncate counts on 64-bit
3290 machines, or EMACS_INT, which may be unnecessarily wide.
3291 * lisp.h (struct Lisp_Subr.function.aMANY)
3292 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3293 Arg counts are now ptrdiff_t, not size_t.
3294 All variadic functions and their callers changed accordingly.
3295 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3296 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3297 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3298 * callint.c (Fcall_interactively): Check arg count for overflow,
3299 to avoid potential buffer overrun. Use signed char, not 'int',
3300 for 'varies' array, so that we needn't bother to check its size
3301 calculation for overflow.
3302 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3303 * eval.c (apply_lambda):
3304 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3305 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3306 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3308 * callint.c (Fcall_interactively): Don't use index var as event count.
3310 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3311 * mem-limits.h (SIZE): Remove; no longer used.
3313 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3315 Remove unnecessary casts.
3316 * xterm.c (x_term_init):
3317 * xfns.c (x_set_border_pixel):
3318 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3319 These aren't needed now that we assume ANSI C.
3321 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3322 It's more likely to cause problems (due to unsigned overflow)
3325 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3327 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3329 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3331 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3333 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3335 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3337 GLYPH_CODE_FACE returns EMACS_INT, not int.
3338 * dispextern.h (merge_faces):
3339 * xfaces.c (merge_faces):
3340 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3341 Don't assume EMACS_INT fits in int.
3343 * character.h (CHAR_VALID_P): Remove unused parameter.
3344 * fontset.c, lisp.h, xdisp.c: All uses changed.
3346 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3348 * fns.c (concat): Minor tuning based on overflow analysis.
3349 This doesn't fix any bugs. Use int to hold character, instead
3350 of constantly refetching from Emacs object. Use XFASTINT, not
3351 XINT, for value known to be a character. Don't bother comparing
3352 a single byte to 0400, as it's always less.
3354 * floatfns.c (Fexpt):
3355 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3357 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3360 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3362 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3363 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3364 incorrectly succeed when S was a string, because 4294967386 was
3365 truncated before it was used.
3367 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3368 Otherwise, an out-of-range integer could cause undefined behavior
3371 * composite.c: Use int, not EMACS_INT, for characters.
3372 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3373 EMACS_INT, for values that are known to be in character range.
3374 This doesn't fix any bugs but is the usual style inside Emacs and
3375 may generate better code on 32-bit machines.
3377 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3378 This is for reasons similar to the recent CHAR_STRING fix.
3379 * charset.c (Fencode_char): Check that character arg is actually
3380 a character. Pass an int to ENCODE_CHAR.
3381 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3382 wider than 'int', as a compile-time check to prevent future regressions
3385 * character.c (char_string): Remove unnecessary casts.
3387 Make sure a 64-bit char is never passed to CHAR_STRING.
3388 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3389 by silently ignoring the top 32 bits, allowing some values
3390 that were far too large to be valid characters.
3391 * character.h: Include <verify.h>.
3392 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3393 arguments are no wider than unsigned, as a compile-time check
3394 to prevent future regressions in this area.
3396 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3397 (Fsubst_char_in_region):
3399 * xdisp.c (decode_mode_spec_coding):
3400 Adjust to CHAR_STRING's new requirement.
3401 * editfns.c (Finsert_char, Fsubst_char_in_region):
3402 * fns.c (concat): Check that character args are actually
3403 characters. Without this test, these functions did the wrong
3404 thing with wildly out-of-range values on 64-bit hosts.
3406 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3407 These casts should not be needed on 32-bit hosts, either.
3408 * keyboard.c (read_char):
3409 * lread.c (Fload): Remove casts to unsigned.
3411 * lisp.h (UNSIGNED_CMP): New macro.
3412 This fixes comparison bugs on 64-bit hosts.
3413 (ASCII_CHAR_P): Use it.
3414 * casefiddle.c (casify_object):
3415 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3416 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3417 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3418 * dispextern.h (FACE_FROM_ID):
3419 * keyboard.c (read_char): Use UNSIGNED_CMP.
3421 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3422 not to EMACS_INT, to avoid GCC warning.
3424 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3426 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3427 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3428 isn't needed on 32-bit machines.
3430 * buffer.c (Fgenerate_new_buffer_name):
3431 Use EMACS_INT for count, not int.
3432 (advance_to_char_boundary): Return EMACS_INT, not int.
3434 * data.c (Qcompiled_function): Now static.
3436 * window.c (window_body_lines): Now static.
3438 * image.c (gif_load): Rename local to avoid shadowing.
3440 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3441 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3442 * alloc.c (make_save_value): Integer argument is now of type
3444 (mark_object): Use ptrdiff_t, not int.
3445 * lisp.h (pD): New macro.
3446 * print.c (print_object): Use it.
3448 * alloc.c: Use EMACS_INT, not int, to count objects.
3449 (total_conses, total_markers, total_symbols, total_vector_size)
3450 (total_free_conses, total_free_markers, total_free_symbols)
3451 (total_free_floats, total_floats, total_free_intervals)
3452 (total_intervals, total_strings, total_free_strings):
3453 Now EMACS_INT, not int. All uses changed.
3454 (Fgarbage_collect): Compute overall total using a double, so that
3455 integer overflow is less likely to be a problem. Check for overflow
3456 when converting back to an integer.
3457 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3458 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3459 These were 'int' variables that could overflow on 64-bit hosts;
3460 they were never used, so remove them instead of repairing them.
3461 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3462 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3463 Previously, this ceilinged at INT_MAX, but that doesn't work on
3465 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3467 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3468 (allocate_vectorlike): Check for ptrdiff_t overflow.
3469 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3470 when a (possibly-narrower) signed value would do just as well.
3471 We prefer using signed arithmetic, to avoid comparison confusion.
3473 * alloc.c: Catch some string size overflows that we were missing.
3474 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3475 for convenience in STRING_BYTES_MAX.
3476 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3477 The definition here is exact; the one in lisp.h was approximate.
3478 (allocate_string_data): Check for string overflow. This catches
3479 some instances we weren't catching before. Also, it catches
3480 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3481 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3482 and ptrdiff_t and EMACS_INT are both 64 bits.
3484 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3485 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3486 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3488 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3490 * alloc.c (Fmake_string): Check for out-of-range init.
3492 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3494 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3496 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3498 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3499 xg_get_default_scrollbar_width.
3501 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3502 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3503 (style_changed_cb): Call update_theme_scrollbar_width and call
3504 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3505 all frames (Bug#8505).
3506 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3507 Call gtk_window_set_resizable if HAVE_GTK3.
3508 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3509 and height if HAVE_GTK3 (Bug#8505).
3510 (scroll_bar_width_for_theme): New variable.
3511 (update_theme_scrollbar_width): New function.
3512 (xg_get_default_scrollbar_width): Move code to
3513 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3514 (xg_initialize): Call update_theme_scrollbar_width.
3516 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3518 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3520 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3522 * frame.c (make_frame): Call other_buffer_safely instead of
3525 * window.c (temp_output_buffer_show): Call display_buffer with
3526 second argument Vtemp_buffer_show_specifiers and reset latter
3527 immediately after the call.
3528 (Vtemp_buffer_show_specifiers): New variable.
3529 (auto_window_vscroll_p, next_screen_context_lines)
3530 (Vscroll_preserve_screen_position): Remove leading asterisks from
3533 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3535 Fix minor problems found by GCC 4.6.0 static checking.
3536 * buffer.c (Qclone_number): Remove for now, as it's unused.
3537 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3538 (record_buffer): Remove unused local.
3539 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3540 (set_frame_buffer_list): Remove; unused.
3541 * frame.h (other_visible_frames): Remove decl.
3542 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3543 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3544 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3546 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3547 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3548 Define only if HAVE_GPM.
3549 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3550 (update_hints_inhibit): Remove; never set. All uses removed.
3551 * widgetprv.h (emacsFrameClassRec): Remove decl.
3552 * window.c (delete_deletable_window): Now returns void, since it
3553 wasn't returning anything.
3554 (compare_window_configurations): Remove unused locals.
3555 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3556 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3557 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3558 the same widths as pointers. This follows up on the 2011-05-06 patch.
3559 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3560 * xterm.h: Likewise.
3561 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3563 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3565 * makefile.w32-in: Update dependencies.
3566 (LISP_H): Add lib/intprops.h.
3568 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3570 * image.c (gif_load): Add animation frame delay to the metadata.
3571 (syms_of_image): Use DEFSYM. New symbol `delay'.
3573 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3575 * window.c (delete_deletable_window): Re-add.
3576 (Fset_window_configuration): Rewrite to handle dead buffers and
3577 consequently deletable windows.
3578 (window_tree, Fwindow_tree): Remove. Supply functionality in
3580 (compare_window_configurations): Simplify code.
3582 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3584 * image.c (imagemagick_load_image): Fix type mismatch.
3585 (Fimagemagick_types): Likewise.
3587 * window.h (replace_buffer_in_windows): Declare.
3589 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3591 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3592 Qclone_number. Remove external declaration of Qdelete_window.
3593 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3595 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3596 Run Qbuffer_list_update_hook if allowed.
3597 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3598 buffer list implementation.
3599 (other_buffer_safely): New function.
3600 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3601 calls to replace_buffer_in_windows and
3602 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3604 (record_buffer): Inhibit quitting and rewrite using quittable
3605 functions. Run Qbuffer_list_update_hook if allowed.
3606 (Frecord_buffer, Funrecord_buffer): New functions.
3607 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3608 Move switch-to-buffer to window.el.
3609 (bury-buffer): Move to window.el.
3610 (Vbuffer_list_update_hook): New variable.
3612 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3615 * window.h (resize_frame_windows): Move up in code.
3616 (Fwindow_frame): Remove EXFUN.
3617 (replace_buffer_in_all_windows): Remove prototype.
3618 (replace_buffer_in_windows_safely): Add prototype.
3620 * window.c: Declare Qdelete_window static again. Move down
3621 declaration of select_count.
3622 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3623 (Fother_window): Move to window.el.
3624 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3625 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3626 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3628 (replace_buffer_in_windows): Implement by calling
3629 Qreplace_buffer_in_windows.
3630 (replace_buffer_in_all_windows): Remove with some functionality
3631 moved into replace_buffer_in_windows_safely.
3632 (replace_buffer_in_windows_safely): New function.
3633 (select_window_norecord, select_frame_norecord): Move in front
3634 of run_window_configuration_change_hook. Remove now obsolete
3636 (Fset_window_buffer): Rewrite doc-string.
3637 Call Qrecord_window_buffer.
3638 (keys_of_window): Move binding for other-window to window.el.
3640 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3642 * dispextern.h (struct image): Replace data member, whose int_val
3643 and ptr_val fields were not used by anything, with a single
3646 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3647 (gif_clear_image, gif_load, imagemagick_load_image)
3648 (gs_clear_image, gs_load): Callers changed.
3650 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3652 * buffer.h: Include <time.h>, for time_t.
3653 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3655 Fix minor problems found by static checking.
3657 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3659 Make identifiers static if they are not used in other modules.
3660 * data.c (Qcompiled_function, Qframe, Qvector):
3661 * image.c (QimageMagick, Qsvg):
3662 * minibuf.c (Qmetadata):
3663 * window.c (resize_window_check, resize_root_window): Now static.
3664 * window.h (resize_window_check, resize_root_window): Remove decls.
3666 * window.c (window_deletion_count, delete_deletable_window):
3668 (window_body_lines): Now static.
3669 (Fdelete_other_windows_internal): Mark vars as initialized.
3670 Make sure 'resize_failed' is initialized.
3671 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3672 (resize_window_apply): Remove unused local.
3673 * window.h (delete_deletable_window): Remove decl.
3675 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3676 (imagemagick_load_image): Fix pointer signedness problem by changing
3677 last arg from unsigned char * to char *. All uses changed.
3678 Also, fix a local for similar reasons.
3679 Remove unused locals. Remove locals to avoid shadowing.
3680 (fn_rsvg_handle_free): Remove; unused.
3681 (svg_load, svg_load_image): Fix pointer signedness problem.
3682 (imagemagick_load_image): Don't use garbage pointer image_wand.
3684 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3686 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3688 * image.c (gif_load): Fix omitted cast error introduced by
3691 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3693 * window.h (resize_proportionally, orig_total_lines)
3694 (orig_top_line): Remove from window structure.
3695 (set_window_height, set_window_width, change_window_heights)
3696 (Fdelete_window): Remove prototypes.
3697 (resize_frame_windows): Remove duplicate declaration.
3699 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3701 * window.h (resize_frame_windows, resize_window_check)
3702 (delete_deletable_window, resize_root_window)
3703 (resize_frame_windows): Declare prototypes.
3705 * window.c (resize_window_apply): Make definition be "static" to
3706 match the prototype.
3708 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3710 * window.c: Remove declarations of Qwindow_size_fixed,
3711 window_min_size_1, window_min_size_2, window_min_size,
3712 size_window, window_fixed_size_p, enlarge_window, delete_window.
3713 Remove static from declaration of Qdelete_window, it's
3714 temporarily needed by Fbury_buffer.
3715 (replace_window): Don't assign orig_top_line and
3717 (Fdelete_window, delete_window): Remove. Window deletion is
3718 handled by window.el.
3719 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3720 Replace Fdelete_window calls with calls to Qdelete_window.
3721 (Fdelete_other_windows): Remove. Deleting other windows is
3722 handled by window.el.
3723 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3724 handled in window.el.
3725 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3726 Window minimum sizes are handled in window.el.
3727 (shrink_windows, size_window, set_window_height)
3728 (set_window_width, change_window_heights, window_height)
3729 (window_width, CURBEG, CURSIZE, enlarge_window)
3730 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3731 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3732 handled in window.el.
3733 (make_dummy_parent): Rename to make_parent_window and give it a
3734 second argument horflag.
3735 (make_window): Don't set resize_proportionally any more.
3736 (Fsplit_window): Remove. Windows are split in window.el.
3737 (save_restore_action, save_restore_orig_size)
3738 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3739 Resize mini windows in window.el.
3740 (grow_mini_window, shrink_mini_window): Implement by calling
3741 Qresize_root_window_vertically, resize_window_check and
3742 resize_window_apply.
3743 (saved_window, Fset_window_configuration, save_window_save):
3744 Do not handle orig_top_line, orig_total_lines, and
3745 resize_proportionally.
3746 (window_min_height, window_min_width): Move to window.el.
3747 (keys_of_window): Move bindings for delete-other-windows,
3748 split-window, delete-window and enlarge-window to window.el.
3750 * buffer.c: Temporarily extern Qdelete_window.
3751 (Fbury_buffer): Temporarily call Qdelete_window instead of
3752 Fdelete_window (Fbury_buffer will move to window.el soon).
3754 * frame.c (set_menu_bar_lines_1): Remove code handling
3755 orig_top_line and orig_total_lines.
3757 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3758 set_window_height but set heights directly.
3759 (change_frame_size_1): Use resize_frame_windows.
3761 * xdisp.c (init_xdisp): Don't use set_window_height but set
3764 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3765 Use resize_frame_windows instead of change_window_heights and run
3766 run_window_configuration_change_hook.
3768 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3769 instead of change_window_heights and run
3770 run_window_configuration_change_hook.
3772 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3774 * window.c (replace_window): Rename second argument REPLACEMENT to
3775 NEW. New third argument SETFLAG. Rewrite.
3776 (delete_window, make_dummy_parent): Call replace_window with
3778 (window_list_1): Move down in code.
3779 (run_window_configuration_change_hook): Move set_buffer part
3780 before select_frame_norecord part in order to unwind correctly.
3781 Rename count1 to count.
3782 (recombine_windows, delete_deletable_window, resize_root_window)
3783 (Fdelete_other_windows_internal)
3784 (Frun_window_configuration_change_hook, make_parent_window)
3785 (resize_window_check, resize_window_apply, Fresize_window_apply)
3786 (resize_frame_windows, Fsplit_window_internal)
3787 (Fdelete_window_internal, Fresize_mini_window_internal):
3789 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3791 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3793 * window.h (window): Add some new members to window structure -
3794 normal_lines, normal_cols, new_total, new_normal, clone_number,
3795 splits, nest, prev_buffers, next_buffers.
3796 (WINDOW_TOTAL_SIZE): Move here from window.c.
3797 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3799 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3801 (make_dummy_parent): Set new members of windows structure.
3802 (make_window): Move down in code. Handle new members of window
3804 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3805 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3806 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3807 (Fset_window_prev_buffers, Fwindow_next_buffers)
3808 (Fset_window_next_buffers, Fset_window_clone_number):
3810 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3811 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3813 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3814 Argument WINDOW can be now internal window too.
3815 (Fwindow_use_time): Move up in code.
3816 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3818 (Fset_window_configuration, saved_window)
3819 (Fcurrent_window_configuration, save_window_save): Handle new
3820 members of window structure.
3821 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3822 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3823 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3824 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3825 Qget_mru_window, Qresize_root_window,
3826 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3827 Qauto_buffer_name; staticpro them.
3829 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3831 * window.c (Fwindow_total_size, Fwindow_left_column)
3832 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3833 (Fwindow_list_1): New functions.
3834 (window_box_text_cols): Replace with window_body_cols.
3835 (Fwindow_width, Fscroll_left, Fscroll_right):
3836 Use window_body_cols instead of window_box_text_cols.
3837 (delete_window, Fset_window_configuration):
3838 Call delete_all_subwindows with window as argument.
3839 (delete_all_subwindows): Take a window as argument and not a
3841 (window_loop): Remove handling of GET_LRU_WINDOW and
3843 (Fget_lru_window, Fget_largest_window): Move to window.el.
3845 * window.h: Extern window_body_cols instead of
3846 window_box_text_cols. delete_all_subwindows now takes a
3847 Lisp_Object as argument.
3849 * indent.c (compute_motion, Fcompute_motion):
3850 Use window_body_cols instead of window_box_text_cols.
3852 * frame.c (delete_frame): Call delete_all_subwindows with root
3855 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3857 * fns.c (Fputhash): Document return value.
3859 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3861 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3863 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3865 Cons<->int and similar integer overflow fixes (Bug#8794).
3867 Check for overflow when converting integer to cons and back.
3868 * charset.c (Fdefine_charset_internal, Fdecode_char):
3869 Use cons_to_unsigned to catch overflow.
3870 (Fencode_char): Use INTEGER_TO_CONS.
3871 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3872 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3873 * data.c (long_to_cons, cons_to_long): Remove.
3874 (cons_to_unsigned, cons_to_signed): New functions.
3875 These signal an error for invalid or out-of-range values.
3876 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3877 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3878 * font.c (Ffont_variation_glyphs):
3879 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3880 * lisp.h: Include <intprops.h>.
3881 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3882 (cons_to_signed, cons_to_unsigned): New decls.
3883 (long_to_cons, cons_to_long): Remove decls.
3884 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3885 (Fprimitive_undo): Use CONS_TO_INTEGER.
3886 * xfns.c (Fx_window_property): Likewise.
3887 * xselect.c: Include <limits.h>.
3888 (x_own_selection, selection_data_to_lisp_data):
3889 Use INTEGER_TO_CONS.
3890 (x_handle_selection_request, x_handle_selection_clear)
3891 (x_get_foreign_selection, Fx_disown_selection_internal)
3892 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3893 (lisp_data_to_selection_data): Use cons_to_unsigned.
3894 (x_fill_property_data): Use cons_to_signed.
3895 Report values out of range.
3897 Check for buffer and string overflow more precisely.
3898 * buffer.h (BUF_BYTES_MAX): New macro.
3899 * lisp.h (STRING_BYTES_MAX): New macro.
3900 * alloc.c (Fmake_string):
3901 * character.c (string_escape_byte8):
3902 * coding.c (coding_alloc_by_realloc):
3903 * doprnt.c (doprnt):
3904 * editfns.c (Fformat):
3906 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3907 since they may not be the same number.
3908 * editfns.c (Finsert_char):
3909 * fileio.c (Finsert_file_contents):
3910 Likewise for BUF_BYTES_MAX.
3912 * image.c: Use ptrdiff_t, not int, for sizes.
3913 (slurp_file): Switch from int to ptrdiff_t.
3915 (slurp_file): Check that file size fits in both size_t (for
3916 malloc) and ptrdiff_t (for sanity and safety).
3918 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3919 if b->modtime has its maximal value.
3921 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3923 Don't assume time_t can fit into int.
3924 * buffer.h (struct buffer.modtime): Now time_t, not int.
3925 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3926 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3928 Minor fixes for signed vs unsigned integers.
3929 * character.h (MAYBE_UNIFY_CHAR):
3930 * charset.c (maybe_unify_char):
3931 * keyboard.c (read_char, reorder_modifiers):
3932 XINT -> XFASTINT, since the integer must be nonnegative.
3933 * ftfont.c (ftfont_spec_pattern):
3934 * keymap.c (access_keymap, silly_event_symbol_error):
3935 XUINT -> XFASTINT, since the integer must be nonnegative.
3936 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3937 since it makes no difference and we prefer signed.
3938 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3939 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3942 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3944 * window.h (Fwindow_frame): Declare.
3946 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3948 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3949 (SPARE_MEMORY): Always define.
3950 (LARGE_REQUEST): Remove.
3951 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3953 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3955 * lisp.h: Move EXFUNS for Fframe_root_window,
3956 Fframe_first_window and Fset_frame_selected_window to window.h.
3958 * window.h: Move EXFUNS for Fframe_root_window,
3959 Fframe_first_window and Fset_frame_selected_window here from
3962 * frame.c (Fwindow_frame, Fframe_first_window)
3963 (Fframe_root_window, Fframe_selected_window)
3964 (Fset_frame_selected_window): Move to window.c.
3965 (Factive_minibuffer_window): Move to minibuf.c.
3966 (Fother_visible_frames_p): New function.
3968 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3970 * window.c (decode_window, decode_any_window): Move up in code.
3971 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3972 (inhibit_frame_unsplittable): Remove unused variable.
3973 (Fwindow_buffer): Move up and rewrite doc-string.
3974 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3975 (Fwindow_prev): New functions.
3976 (Fwindow_frame): Move here from frame.c. Accept any window as
3978 (Fframe_root_window, Fframe_first_window)
3979 (Fframe_selected_window): Move here from frame.c. Accept frame
3980 or arbitrary window as argument. Update doc-strings.
3981 (Fminibuffer_window): Move up in code.
3982 (Fwindow_minibuffer_p): Move up in code and simplify.
3983 (Fset_frame_selected_window): Move here from frame.c.
3985 (Fselected_window, select_window, Fselect_window): Move up in
3986 code. Minor doc-string fixes.
3988 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3990 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3991 Do not assume that spare memory exists; that assumption is valid
3992 only if SYSTEM_MALLOC.
3993 (LARGE_REQUEST): New macro, so that the issue of large requests
3994 is separated from the issue of spare memory.
3996 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3998 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4001 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4003 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4006 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4008 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4010 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4012 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4013 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4015 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4017 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4019 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4021 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4022 (x_clipboard_manager_save): Add return value.
4023 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4025 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4026 Obey Vx_select_enable_clipboard_manager. Catch errors in
4027 x_clipboard_manager_save (Bug#8779).
4028 (Vx_select_enable_clipboard_manager): New variable.
4029 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4031 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4033 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4035 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4037 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4038 in the current matrix if keep_current_p is non-zero.
4040 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4042 * bidi.c (bidi_level_of_next_char): Fix last change.
4044 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4046 Support bidi reordering of text covered by display properties.
4048 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4049 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4050 (bidi_cache_search, bidi_cache_iterator_state)
4051 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4052 (bidi_level_of_next_char, bidi_move_to_visually_next):
4053 Support character positions inside a run of characters covered by a
4055 (bidi_paragraph_init, bidi_resolve_explicit_1)
4056 (bidi_level_of_next_char): Call bidi_fetch_char and
4057 bidi_fetch_char_advance instead of FETCH_CHAR and
4059 (bidi_init_it): Initialize new members.
4060 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4062 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4063 instead of using explicit *_CHAR codes.
4064 (bidi_resolve_explicit, bidi_resolve_weak):
4065 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4066 bidirectional text is supported only in multibyte buffers.
4067 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4068 it to initialize the frame_window_p member of struct bidi_it.
4069 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4070 (bidi_resolve_explicit, bidi_resolve_weak)
4071 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4072 bidi_it->nchars is non-positive.
4073 (bidi_level_of_next_char): Don't try to lookup the cache for the
4074 next/previous character if nothing is cached there yet, or if we
4075 were just reseat()'ed to a new position.
4077 * xdisp.c (set_cursor_from_row): Set start and stop points
4078 according to the row's direction when priming the loop that looks
4079 for the glyph on which to display cursor.
4080 (single_display_spec_intangible_p): Function deleted.
4081 (display_prop_intangible_p): Reimplement to call
4082 handle_display_spec instead of single_display_spec_intangible_p.
4083 Accept 3 additional arguments needed by handle_display_spec.
4084 This fixes incorrect cursor motion across display property with complex
4085 values: lists, `(when COND...)' forms, etc.
4086 (single_display_spec_string_p): Support property values that are
4087 lists with the argument STRING its top-level element.
4088 (display_prop_string_p): Fix the condition for processing a
4089 property that is a list to be consistent with handle_display_spec.
4090 (handle_display_spec): New function, refactored from the
4091 last portion of handle_display_prop.
4092 (compute_display_string_pos): Accept additional argument
4093 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4094 value of a `display' property is a "replacing spec".
4095 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4096 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4097 the display property, but just return a value indicating whether
4098 the display property will replace the characters it covers.
4099 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4100 frame_window_p members of struct bidi_it.
4101 (compute_display_string_pos, compute_display_string_end):
4103 (push_it): Accept second argument POSITION, where pop_it should
4104 jump to continue iteration.
4105 (reseat_1): Initialize bidi_it.disp_pos.
4107 * keyboard.c (adjust_point_for_property): Adjust the call to
4108 display_prop_intangible_p to its new signature.
4110 * dispextern.h (struct bidi_it): New member frame_window_p.
4111 (bidi_init_it): Update prototypes.
4112 (display_prop_intangible_p): Update prototype.
4113 (compute_display_string_pos, compute_display_string_end):
4115 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4118 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4120 Malloc failure behavior now depends on size of allocation.
4121 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4122 * lisp.h: Change signatures accordingly.
4123 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4124 All callers changed. (Bug#8762)
4126 * gnutls.c: Use Emacs's memory allocators.
4127 Without this change, the gnutls library would invoke malloc etc.
4128 directly, which causes problems on non-SYNC_INPUT hosts, and which
4129 runs afoul of improving memory_full behavior. (Bug#8761)
4130 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4131 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4132 xfree instead of the default malloc, realloc, free.
4133 (Fgnutls_boot): No need to check for memory allocation failure,
4134 since xmalloc does that for us.
4136 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4137 * category.c (hash_get_category_set):
4138 * ccl.c (ccl_driver):
4139 * charset.c (Fdefine_charset_internal):
4140 * charset.h (struct charset.hash_index):
4141 * composite.c (get_composition_id, gstring_lookup_cache)
4142 (composition_gstring_put_cache):
4143 * composite.h (struct composition.hash_index):
4144 * dispextern.h (struct image.hash):
4145 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4146 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4147 (hashfn_equal, hashfn_user_defined, make_hash_table)
4148 (maybe_resize_hash_table, hash_lookup, hash_put)
4149 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4150 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4151 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4152 * image.c (make_image, search_image_cache, lookup_image)
4153 (xpm_put_color_table_h):
4154 * lisp.h (struct Lisp_Hash_Table):
4155 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4156 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4157 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4158 * alloc.c (allocate_vectorlike):
4159 Check for overflow in vector size calculations.
4160 * ccl.c (ccl_driver):
4161 Check for overflow when converting EMACS_INT to int.
4162 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4163 need to be updated by these changes.
4164 * fns.c (make_hash_table, maybe_resize_hash_table):
4165 Check for integer overflow with large hash tables.
4166 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4167 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4168 (SXHASH_REDUCE): New macro.
4169 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4170 Use it instead of discarding useful hash info with large hash values.
4171 (sxhash_float): New function.
4172 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4173 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4174 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4175 Rewrite to use FIXNUM_BITS, as this simplifies things.
4176 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4177 Adjust signatures to match updated version of code.
4178 (consing_since_gc): Now EMACS_INT, since a single hash table can
4179 use more than INT_MAX bytes.
4181 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4183 Make it possible to build with GCC-4.6+ -O2 -flto.
4185 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4187 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4189 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4190 Call minibuffer-inactive-mode.
4192 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4194 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4195 Update dependencies.
4197 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4199 * data.c (init_data): Remove code for UTS, this system is not
4202 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4204 Don't force ./temacs to start in terminal mode.
4206 * frame.c (make_initial_frame): Initialize faces in all cases, not
4207 only when CANNOT_DUMP is defined.
4208 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4210 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4212 * dispnew.c (add_window_display_history): Use const for the string
4213 pointer. Remove declaration, not needed.
4215 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4217 Use 'inline', not 'INLINE'.
4218 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4219 * alloc.c, fontset.c (INLINE): Remove.
4220 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4221 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4222 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4223 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4224 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4226 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4228 Make it possible to run ./temacs.
4230 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4231 syms_of_callproc does the same thing. Remove test for
4232 "initialized", do it in the caller.
4233 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4235 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4237 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4238 (read_minibuf): Use get_minibuffer.
4239 (syms_of_minibuf): Use DEFSYM.
4240 (Qmetadata): New var.
4241 * data.c (Qbuffer): Don't make it static.
4242 (syms_of_data): Use DEFSYM.
4244 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4246 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4247 (CCL_CODE_MIN): New macro.
4249 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4251 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4253 * eval.c (Qdebug): Now static.
4254 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4255 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4256 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4258 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4260 * image.c: Various fixes to ImageMagick code comments.
4261 (Fimagemagick_types): Doc fix.
4263 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4265 Minor fixes prompted by GCC 4.6.0 warnings.
4267 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4269 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4270 (x_clipboard_manager_save_all): Move extern decl to ...
4271 * xterm.h: ... here, so that it can be checked for consistency.
4273 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4275 * xselect.c (x_clipboard_manager_save_frame)
4276 (x_clipboard_manager_save_all): New functions.
4277 (Fx_clipboard_manager_save): Lisp function deleted.
4279 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4280 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4282 * xterm.h: Update prototype.
4284 2011-05-28 William Xu <william.xwl@gmail.com>
4286 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4289 2011-05-28 Jim Meyering <meyering@redhat.com>
4291 Avoid a sign-extension bug in crypto_hash_function.
4292 * fns.c (to_uchar): Define.
4293 (crypto_hash_function): Use it to convert some newly-signed
4294 variables to unsigned, to avoid sign-extension bugs. For example,
4295 without this change, (md5 "truc") would evaluate to
4296 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4297 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4298 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4300 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4302 Integer overflow fixes.
4304 * dbusbind.c: Serial number integer overflow fixes.
4305 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4306 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4307 to hold a serial number that is too large for a fixnum.
4308 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4309 Check for serial numbers out of range. Decode any serial number
4310 that was so large that it became a float. (Bug#8722)
4312 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4313 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4314 Use XFASTINT rather than XUINT when numbers are nonnegative.
4315 (xd_append_arg, Fdbus_method_return_internal):
4316 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4317 arguments, check that Lisp number is nonnegative, rather than
4318 silently wrapping negative numbers around. (Bug#8722)
4319 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4322 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4324 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4326 ccl: add integer overflow checks
4327 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4328 (IN_INT_RANGE): New macros.
4329 (ccl_driver): Use them to check for integer overflow when
4330 decoding a CCL program. Many of the new checks are whether XINT (x)
4331 fits in int; it doesn't always, on 64-bit hosts. The new version
4332 doesn't catch all possible integer overflows, but it's an
4333 improvement. (Bug#8719)
4335 * alloc.c (make_event_array): Use XINT, not XUINT.
4336 There's no need for unsigned here.
4338 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4339 This follows up to the 2011-05-06 change that substituted uintptr_t
4340 for EMACS_INT. This case wasn't caught back then.
4342 Rework Fformat to avoid integer overflow issues.
4343 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4344 now (part of C89). Include <verify.h>.
4345 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4346 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4347 (Fformat): Avoid the prepass trying to compute sizes; it was only
4348 approximate and thus did not catch overflow reliably. Instead, walk
4349 through the format just once, formatting and computing sizes as we go,
4350 checking for integer overflow at every step, and allocating a larger
4351 buffer as needed. Keep track separately whether the format is
4352 multibyte. Keep only the most-recently calculated precision, rather
4353 than them all. Record whether each argument has been converted to
4354 string. Use EMACS_INT, not int, for byte and char and arg counts.
4355 Support field widths and precisions larger than INT_MAX. Avoid
4356 sprintf's undefined behavior with conversion specifications such as %#d
4357 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4358 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4359 formatting out-of-range floating point numbers with int
4362 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4364 * data.c: Avoid integer truncation in expressions involving floats.
4365 * data.c: Include <intprops.h>.
4366 (arith_driver): When there's an integer overflow in an expression
4367 involving floating point, convert the integers to floating point
4368 so that the resulting value does not suffer from catastrophic
4369 integer truncation. For example, on a 64-bit host (* 4
4370 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4371 Do not rely on undefined behavior after integer overflow.
4373 merge count_size_as_multibyte, parse_str_to_multibyte
4374 * character.c, character.h (count_size_as_multibyte):
4375 Rename from parse_str_to_multibyte; all uses changed.
4376 Check for integer overflow.
4377 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4378 since it's now a duplicate of the other. This is more of
4379 a character than a buffer op, so better that it's in character.c.
4380 * fns.c, print.c: Adjust to above changes.
4382 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4384 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4386 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4388 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4389 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4390 (x_clipboard_manager_save): Now static.
4391 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4393 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4394 (crypto_hash_function): Now static.
4395 Fix pointer signedness problems. Avoid unnecessary initializations.
4397 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4399 * termhooks.h (Vselection_alist): Make it terminal-local.
4401 * terminal.c (create_terminal): Initialize it.
4403 * xselect.c: Support for clipboard managers.
4404 (Vselection_alist): Move to termhooks.h as terminal-local var.
4405 (LOCAL_SELECTION): New macro.
4406 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4407 (symbol_to_x_atom): Remove gratuitous arg.
4408 (x_handle_selection_request, lisp_data_to_selection_data)
4409 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4410 (x_own_selection, x_get_local_selection, x_convert_selection):
4411 New arg, specifying work frame. Use terminal-local Vselection_alist.
4412 (some_frame_on_display): Delete unused function.
4413 (Fx_own_selection_internal, Fx_get_selection_internal)
4414 (Fx_disown_selection_internal, Fx_selection_owner_p)
4415 (Fx_selection_exists_p): New optional frame arg.
4416 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4417 (x_handle_selection_clear): Don't treat other terminals with the
4418 same keyboard specially. Use the terminal-local Vselection_alist.
4419 (x_clear_frame_selections): Use Frun_hook_with_args.
4421 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4423 * xterm.h: Add support for those atoms.
4425 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4427 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4428 (converted_selections, conversion_fail_tag): New global variables.
4429 (x_selection_request_lisp_error): Free the above.
4430 (x_get_local_selection): Remove unnecessary code.
4431 (x_reply_selection_request): Args changed; handle arbitrary array
4432 of converted selections stored in converted_selections.
4433 Separate the XChangeProperty and SelectionNotify steps.
4434 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4435 (x_convert_selection): New function.
4436 (x_handle_selection_event): Simplify.
4437 (x_get_foreign_selection): Don't ignore incoming requests while
4438 waiting for an answer; this will fail when we implement
4439 SAVE_TARGETS, and seems unnecessary anyway.
4440 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4441 (Vx_sent_selection_functions): Doc fix.
4443 2011-05-26 Leo Liu <sdl.web@gmail.com>
4445 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4447 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4449 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4451 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4452 for fringe update if it has periodic bitmap.
4453 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4454 and fringe_bitmap_periodic_p.
4456 * fringe.c (get_fringe_bitmap_data): New function.
4457 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4458 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4459 row. Mark glyph row for fringe update if periodicity changed.
4461 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4462 for fringe update unless it has periodic bitmap.
4464 2011-05-25 Kenichi Handa <handa@m17n.org>
4466 * xdisp.c (get_next_display_element): Set correct it->face_id for
4467 a static composition.
4469 2011-05-24 Leo Liu <sdl.web@gmail.com>
4472 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4474 * fns.c (crypto_hash_function, Fsha1): New function.
4475 (Fmd5): Use crypto_hash_function.
4476 (syms_of_fns): Add Ssha1.
4478 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4480 * gnutls.c: Remove unused macros.
4481 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4482 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4483 Remove macros that are defined and never used.
4484 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4486 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4488 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4489 (Fx_get_selection_internal): Minor cleanup.
4490 (Fx_own_selection_internal): Rename arguments for consistency with
4493 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4495 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4497 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4499 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4501 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4503 * dispnew.c (scrolling_window): Don't exclude the case that the
4504 last enabled row in the desired matrix touches the bottom boundary.
4506 2011-05-21 Glenn Morris <rgm@gnu.org>
4508 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4509 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4510 and add some more files.
4512 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4514 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4515 report_file_error introduced by the change from 2011-05-07.
4517 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4519 * systime.h (Time): Define only if emacs is defined.
4520 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4521 where the include path doesn't have X11/X.h by default. See
4522 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4524 2011-05-20 Kenichi Handa <handa@m17n.org>
4526 * composite.c (find_automatic_composition): Fix previous change.
4528 2011-05-20 Glenn Morris <rgm@gnu.org>
4530 * lisp.mk: New file, split from Makefile.in.
4531 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4532 (shortlisp): Remove.
4533 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4535 2011-05-19 Glenn Morris <rgm@gnu.org>
4537 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4538 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4539 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4540 (lisp): Set the order to that of loadup.el.
4541 (shortlisp): Make it a copy of $lisp.
4542 (SOME_MACHINE_LISP): Remove.
4543 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4544 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4546 2011-05-18 Kenichi Handa <handa@m17n.org>
4548 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4549 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4550 (find_automatic_composition): Mostly rewrite for efficiency.
4552 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4554 * makefile.w32-in: Update dependencies.
4556 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4558 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4559 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4561 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4563 Fix some integer overflow issues, such as string length overflow.
4565 * insdel.c (count_size_as_multibyte): Check for string overflow.
4567 * character.c (lisp_string_width): Check for string overflow.
4568 Use EMACS_INT, not int, for string indexes and lengths; in
4569 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4570 the resulting string length overflows an EMACS_INT; instead,
4571 report a string overflow if no precision given. When checking for
4572 precision exhaustion, use a check that cannot possibly have
4573 integer overflow. (Bug#8675)
4574 * character.h (lisp_string_width): Adjust to new signature.
4576 * alloc.c (string_overflow): New function.
4577 (Fmake_string): Use it. This doesn't change behavior, but saves
4578 a few bytes and will simplify future changes.
4579 * character.c (string_escape_byte8): Likewise.
4580 * lisp.h (string_overflow): New decl.
4582 Fixups, following up to the user-interface timestamp change.
4583 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4584 for UI timestamps, instead of unsigned long.
4585 * msdos.c (mouse_get_pos): Likewise.
4586 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4587 * w32gui.h (Time): Define by including "systime.h" rather than by
4588 declaring it ourselves. (Bug#8664)
4590 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4591 * image.c (clear_image_cache): Likewise.
4593 * term.c (term_mouse_position): Don't assume time_t wraparound.
4595 Be more systematic about user-interface timestamps.
4596 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4597 and sometimes 'EMACS_UINT', to represent these timestamps.
4598 This change causes it to use 'Time' uniformly, as that's what X uses.
4599 This makes the code easier to follow, and makes it easier to catch
4600 integer overflow bugs such as Bug#8664.
4601 * frame.c (Fmouse_position, Fmouse_pixel_position):
4602 Use Time, not unsigned long, for user-interface timestamps.
4603 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4604 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4605 * keyboard.h (last_event_timestamp): Likewise.
4606 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4607 * menu.h (xmenu_show): Likewise.
4608 * term.c (term_mouse_position): Likewise.
4609 * termhooks.h (struct input_event.timestamp): Likewise.
4610 (struct terminal.mouse_position_hook): Likewise.
4611 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4612 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4613 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4614 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4616 * menu.h, termhooks.h: Include "systime.h", for Time.
4618 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4619 Don't assume that the difference between two unsigned long values
4620 can fit into an integer. At this point, we know button_down_time
4621 <= event->timestamp, so the difference must be nonnegative, so
4622 there's no need to cast the result if double-click-time is
4623 nonnegative, as it should be; check that it's nonnegative, just in
4624 case. This bug is triggered when events are more than 2**31 ms
4625 apart (about 25 days). (Bug#8664)
4627 * xselect.c (last_event_timestamp): Remove duplicate decl.
4628 (x_own_selection): Remove needless cast to unsigned long.
4630 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4631 that always fit in int. Use a sentinel instead of a counter, to
4632 avoid a temp and to allay GCC's concerns about possible int overflow.
4633 * frame.h (struct frame): Use int for menu_bar_items_used
4634 instead of EMACS_INT, since it always fits in int.
4636 * menu.c (grow_menu_items): Check for int overflow.
4638 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4640 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4641 Before, the code was not consistent. These values cannot exceed
4642 2**31 - 1 so there's no need to make them unsigned.
4643 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4644 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4645 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4647 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4649 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4650 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4651 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4652 presumably because the widths might not match.
4654 * window.c (size_window): Avoid needless test at loop start.
4656 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4658 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4660 2011-05-12 Drew Adams <drew.adams@oracle.com>
4662 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4664 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4666 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4667 `width' to `bar_area_x' and `bar_area_width', respectively.
4668 (x_scroll_run): Take account of fringe background extension.
4670 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4671 Rename local vars `left' and `width' to `bar_area_x' and
4672 `bar_area_width', respectively.
4673 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4674 background extension.
4676 2011-05-10 Jim Meyering <meyering@redhat.com>
4678 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4680 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4682 * image.c (Finit_image_library): Return t for built-in image types,
4683 like pbm and xbm. (Bug#8640)
4685 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4687 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4689 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4691 * w32console.c (Fset_screen_color): Doc fix.
4692 (Fget_screen_color): New function.
4693 (syms_of_ntterm): Defsubr it.
4695 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4696 unlink the temporary file if Fcall_process didn't create it in the
4698 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4699 child process will be redirected to a file specified with `:file'.
4700 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4701 cue to call_process_cleanup not to close that handle.
4703 2011-05-07 Ben Key <bkey76@gmail.com>
4705 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4706 one of two shell specific rules, either bootstrap-temacs-CMD or
4707 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4708 to the previous implementation of the bootstrap-temacs rule.
4709 The bootstrap-temacs-CMD rule is similar to the previous
4710 implementation of the bootstrap-temacs rule except that it
4711 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4714 These changes, along with some changes to nt/configure.bat,
4715 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4716 earlier fix to add support for --cflags and --ldflags options
4717 that include quotes so that it works whether make uses cmd or
4720 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4722 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4723 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4725 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4726 a string. Handle both cases.
4727 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4728 (Fdbus_register_method): Use Qinvalid_function.
4730 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4732 * makefile.w32-in: Update dependencies.
4733 (LISP_H): Add inttypes.h and stdin.h.
4734 (PROCESS_H): Add unistd.h.
4736 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4738 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4739 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4741 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4743 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4745 * term.c (vfatal): Remove stray call to va_end.
4746 It's not needed and the C Standard doesn't allow it here anyway.
4748 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4749 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4751 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4754 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4756 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4758 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4760 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4762 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4764 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4765 * charset.c (Fdefine_charset_internal): Don't initialize
4766 charset.code_space[15]. The value was garbage, on hosts with
4767 32-bit int (Bug#8600).
4769 * lread.c (read_integer): Be more consistent with string-to-number.
4770 Use string_to_number to do the actual conversion; this avoids
4771 rounding errors and fixes some other screwups. Without this fix,
4772 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4773 (digit_to_number): Move earlier, for benefit of read_integer.
4774 Return -1 if the digit is out of range for the base, -2 if it is
4775 not a digit in any supported base. (Bug#8602)
4777 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4779 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4780 to match comment at start of function. This also removes a
4781 GCC warning about overflow in a 32+64-bit port.
4783 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4785 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4786 Reported by Stefan Monnier in
4787 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4788 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4789 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4791 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4792 (EMACS_UINTPTR): Likewise, with uintptr_t.
4794 * lisp.h: Prefer 64-bit EMACS_INT if available.
4795 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4796 on 32-bit hosts that have 64-bit int, so that they can access
4798 However, temporarily disable this change unless the temporary
4799 symbol WIDE_EMACS_INT is defined.
4801 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4803 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4804 This removes an assumption that EMACS_INT and long are the same
4805 width as pointers. The assumption is true for Emacs porting targets
4806 now, but we want to make other targets possible.
4807 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4808 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4809 In the rest of the code, change types of integers that hold casted
4810 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4811 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4812 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4813 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4814 No need to cast type when ORing.
4815 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4816 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4817 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4818 assume EMACS_INT is the same width as char *.
4819 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4820 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4821 Remove no-longer-needed casts.
4822 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4823 (xg_tool_bar_help_callback, xg_make_tool_item):
4824 Use EMACS_INTPTR to hold an integer
4825 that will be cast to void *; this can avoid a GCC warning
4826 if EMACS_INT is not the same width as void *.
4827 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4828 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4829 (current_message_1, set_message_1):
4830 Use a local to convert to proper width without a cast.
4831 * xmenu.c (dialog_selection_callback): Likewise.
4833 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4834 Also, don't assume VALBITS / RAND_BITS is less than 5,
4835 and don't rely on undefined behavior when shifting a 1 left into
4837 * lisp.h (get_random): Change signature to match.
4839 * lread.c (hash_string): Use size_t, not int, for hash computation.
4840 Normally we prefer signed values; but hashing is special, because
4841 it's better to use unsigned division on hash table sizes so that
4842 the remainder is nonnegative. Also, size_t is the natural width
4843 for hashing into memory. The previous code used 'int', which doesn't
4844 retain enough info to hash well into very large tables.
4845 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4847 * dbusbind.c: Don't possibly lose pointer info when converting.
4848 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4849 Use XPNTR rather than XHASH, so that the high-order bits of
4850 the pointer aren't lost when converting through void *.
4852 * eval.c (Fautoload): Don't double-shift a pointer.
4854 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4856 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4858 * gnutls.c (DEF_GNUTLS_FN):
4859 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4861 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4863 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4866 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4868 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4869 New version that can reserve upto 2GB of heap space.
4871 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4873 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4875 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4877 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4878 `gnutls_certificate_set_x509_key_file'.
4880 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4882 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4883 Update dependencies.
4885 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4887 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4888 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4889 Remove unused parameter `fildes'.
4890 * process.c (read_process_output, send_process): Don't pass it.
4892 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4894 Fix previous change: the library cache is defined in w32.c.
4895 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4896 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4898 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4900 Implement dynamic loading of GnuTLS on Windows.
4902 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4903 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4904 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4907 * gnutls.c (Qgnutls_dll): Define.
4908 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4909 (gnutls_*): Declare function pointers.
4910 (init_gnutls_functions): New function to initialize function pointers.
4911 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4912 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4913 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4914 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4915 (emacs_gnutls_write, emacs_gnutls_read)
4916 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4917 (Fgnutls_available_p): New function.
4918 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4919 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4920 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4922 * image.c: Include w32.h.
4923 (Vimage_type_cache): Delete.
4924 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4925 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4926 (w32_delayed_load): Move to w32.c.
4928 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4930 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4931 (w32_delayed_load): Move from image.c. When loading a library, record
4932 its filename in the :loaded-from property of the library id.
4933 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4934 Initialize and staticpro them.
4935 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4937 * process.c: Include lisp.h before w32.h, not after.
4938 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4939 instead of gnutls_record_check_pending.
4941 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4943 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4945 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4946 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4949 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4951 * xterm.c (x_set_frame_alpha): Do not set property on anything
4952 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4954 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4956 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4958 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4960 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4961 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4962 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4963 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4964 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4965 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4966 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4967 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4968 (Qgnutls_bootprop_callbacks_verify): Make static.
4970 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4972 * callproc.c: Indentation fixup.
4974 * sysdep.c (wait_for_termination_1): Make static.
4975 (wait_for_termination, interruptible_wait_for_termination):
4976 Move after wait_for_termination_1.
4978 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4980 * sysdep.c (interruptible_wait_for_termination): New function
4981 which is like wait_for_termination, but allows keyboard
4984 * callproc.c (Fcall_process): Add (:file "file") as an option for
4986 (Fcall_process_region): Ditto.
4988 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4990 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4991 rather than `XVECTOR (FOO)->size'.
4993 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4994 inttypes.h, as a gnulib replacement is used if it not available in
4997 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4999 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5000 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5001 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5003 * coding.c (coding_alloc_by_realloc): Error out if destination
5004 will grow beyond MOST_POSITIVE_FIXNUM.
5005 (decode_coding_emacs_mule): Abort if there isn't enough place in
5006 charbuf for the composition carryover bytes. Reserve an extra
5007 space for up to 2 characters produced in a loop.
5008 (decode_coding_iso_2022): Abort if there isn't enough place in
5009 charbuf for the composition carryover bytes.
5011 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5013 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5014 aborting when %lld or %lll format is passed.
5015 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5016 %llo or %llx format is passed. (Bug#8545)
5018 * window.c (window_scroll_line_based): Use a marker instead of
5019 simple variables to record original value of point. (Bug#7952)
5021 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5022 produced by %s or %c overflows available buffer space. (Bug#8545)
5024 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5026 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5027 (SIZE_MAX): Move defn after all includes, as they might #define it.
5029 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5031 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5033 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5035 * keyboard.c (Qdelayed_warnings_hook): Define.
5036 (command_loop_1): Run `delayed-warnings-hook'
5037 if Vdelayed_warnings_list is non-nil.
5038 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5039 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5041 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5043 * doprnt.c (doprnt): Don't return value smaller than the buffer
5044 size if the message was truncated. (Bug#8545).
5046 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5048 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5049 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5051 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5053 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5055 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5057 * makefile.w32-in: Update dependencies.
5059 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5061 Improve `doprnt' and its usage. (Bug#8545)
5062 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5063 `format_end'. Remove support for %l as a conversion specifier.
5064 Don't use xrealloc. Improve diagnostics when the %l size modifier
5065 is used. Update the commentary.
5067 * eval.c (verror): Simplify calculation of size_t.
5069 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5072 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5074 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5077 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5079 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5080 This makes this file independent of the recent pseudovector change.
5082 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5084 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5086 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5087 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5088 Remove unused local.
5089 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5091 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5092 GCC 4.6.0 optimizes based on type-based alias analysis.
5093 For example, if b is of type struct buffer * and v of type struct
5094 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5095 != &v->size, and therefore "v->size = 1; b->size = 2; return
5096 v->size;" must therefore return 1. This assumption is incorrect
5097 for Emacs, since it type-puns struct Lisp_Vector * with many other
5098 types. To fix this problem, this patch adds a new type struct
5099 vectorlike_header that documents the constraints on layout of vectors
5100 and pseudovectors, and helps optimizing compilers not get fooled
5101 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5102 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5103 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5105 (XSETPVECTYPE): Rewrite in terms of new macro.
5106 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5107 This is a bit clearer, and further avoids the possibility of
5108 undesirable aliasing.
5109 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5110 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5111 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5112 since Lisp_Subr is a special case (no "next" field).
5113 (ASIZE): Now uses header.size rather than size.
5114 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5115 to avoid the hassle of writing XVECTOR (foo)->header.size.
5116 (struct vectorlike_header): New type.
5117 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5118 object, to help avoid aliasing.
5119 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5120 (SUBRP): Likewise, since Lisp_Subr is a special case.
5121 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5122 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5123 (struct Lisp_Hash_Table): Combine first two members into a single
5124 struct vectorlike_header member. All uses of "size" and "next" members
5125 changed to be "header.size" and "header.next".
5126 * buffer.h (struct buffer): Likewise.
5127 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5128 * frame.h (struct frame): Likewise.
5129 * process.h (struct Lisp_Process): Likewise.
5130 * termhooks.h (struct terminal): Likewise.
5131 * window.c (struct save_window_data, struct saved_window): Likewise.
5132 * window.h (struct window): Likewise.
5133 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5134 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5135 * buffer.c (init_buffer_once): Likewise.
5136 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5138 * process.c (Fformat_network_address): Use local var for size,
5141 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5143 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5144 * data.c (atof): Remove decl; no longer used or needed.
5145 (digit_to_number): Move to lread.c.
5146 (Fstring_to_number): Use new string_to_number function, to be
5147 consistent with how the Lisp reader treats infinities and NaNs.
5148 Do not assume that floating-point numbers represent EMACS_INT
5149 without losing information; this is not true on most 64-bit hosts.
5150 Avoid double-rounding errors, by insisting on integers when
5151 parsing non-base-10 numbers, as the documentation specifies.
5152 * lisp.h (string_to_number): New decl, replacing ...
5153 (isfloat_string): Remove.
5154 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5155 (read1): Do not accept +. and -. as integers; this
5156 appears to have been a coding error. Similarly, do not accept
5157 strings like +-1e0 as floating point numbers. Do not report
5158 overflow for integer overflows unless the base is not 10 which
5159 means we have no simple and reliable way to continue.
5160 Break out the floating-point parsing into a new
5161 function string_to_number, so that Fstring_to_number parses
5162 floating point numbers consistently with the Lisp reader.
5163 (digit_to_number): Move here from data.c. Make it static inline.
5164 (E_CHAR, EXP_INT): Remove, replacing with ...
5165 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5166 (string_to_number): New function, replacing isfloat_string.
5167 This function checks for valid syntax and produces the resulting
5168 Lisp float number too. Rework it so that string-to-number
5169 no longer mishandles examples like "1.0e+". Use strtoumax,
5170 so that overflow for non-base-10 numbers is reported only when
5171 there's no portable and simple way to convert to floating point.
5173 * textprop.c (set_text_properties_1): Rewrite for clarity,
5174 and to avoid GCC warning about integer overflow.
5176 * intervals.h (struct interval): Use EMACS_INT for members
5177 where EMACS_UINT might cause problems. See
5178 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5179 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5180 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5182 (offset_intervals): Tell GCC not to worry about length overflow
5183 when negating a negative length.
5185 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5186 (overrun_check_free): Likewise.
5188 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5189 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5192 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5193 (gnutls_make_error): Rename local to avoid shadowing.
5194 (gnutls_emacs_global_deinit): ifdef out; not used.
5195 (Fgnutls_boot): Use const for pointer to readonly storage.
5196 Comment out unused local. Fix pointer signedness problems.
5198 * lread.c (openp): Don't stuff size_t into an 'int'.
5199 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5200 about possible signed overflow.
5202 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5203 (GDK_KEY_g): Don't define if already defined.
5204 (xg_prepare_tooltip): Avoid pointer signedness problem.
5205 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5207 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5208 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5210 * xfns.c (Fx_window_property): Simplify a bit,
5211 to make a bit faster and to avoid GCC 4.6.0 warning.
5212 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5214 * fns.c (internal_equal): Don't assume size_t fits in int.
5216 * alloc.c (compact_small_strings): Tighten assertion a little.
5218 Replace pEd with more-general pI, and fix some printf arg casts.
5219 * lisp.h (pI): New macro, generalizing old pEd macro to other
5220 conversion specifiers. For example, use "...%"pI"d..." rather
5221 than "...%"pEd"...".
5222 (pEd): Remove. All uses replaced with similar uses of pI.
5223 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5224 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5225 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5226 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5227 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5228 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5229 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5231 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5232 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5233 * print.c (safe_debug_print, print_object): Likewise.
5234 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5236 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5237 avoiding the 0 flag, which is not portable.
5238 * process.c (Fmake_network_process): Use pI to avoid cast.
5239 * region-cache.c (pp_cache): Likewise.
5240 * xdisp.c (decode_mode_spec): Likewise.
5241 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5242 behavior on 64-bit hosts with printf arg.
5243 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5244 (x_stop_queuing_selection_requests): Likewise.
5245 (x_get_window_property): Don't truncate byte count to an 'int'
5248 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5249 here, since it parses constructs like leading '-' and spaces,
5250 which are not wanted; and it overflows with large numbers.
5251 Instead, simply match F[0-9]+, which is what is wanted anyway.
5253 * alloc.c: Remove unportable assumptions about struct layout.
5254 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5255 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5256 (allocate_vectorlike, make_pure_vector): Use the new macros,
5257 plus offsetof, to remove unportable assumptions about struct layout.
5258 These assumptions hold on all porting targets that I know of, but
5259 they are not guaranteed, they're easy to remove, and removing them
5260 makes further changes easier.
5262 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5263 This doesn't fix a bug but makes the code clearer.
5264 (string_overrun_cookie): Now const. Use initializers that
5265 don't formally overflow signed char, to avoid warnings.
5266 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5267 can cause Emacs to crash when string overrun checking is enabled.
5268 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5269 multiple of sizeof (EMACS_INT); it need not be, if
5270 alignof(EMACS_INT) < sizeof (EMACS_INT).
5271 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5273 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5275 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5277 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5279 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5280 supposed to be handshaking. (Bug#8556)
5281 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5283 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5285 * lisp.h (Qdebug): List symbol.
5286 * eval.c (Qdebug): Restore global linkage.
5287 * keyboard.c (debug-on-event): New variable.
5288 (handle_user_signal): Break into debugger when debug-on-event
5289 matches the current signal symbol.
5291 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5293 * alloc.c (check_sblock, check_string_bytes)
5294 (check_string_free_list): Convert to standard C.
5296 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5298 * w32.c (emacs_gnutls_push): Fix typo.
5300 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5302 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5303 "cast to pointer from integer of different size".
5305 Improve doprnt and its use in verror. (Bug#8545)
5306 * doprnt.c (doprnt): Document the set of format control sequences
5307 supported by the function. Use SAFE_ALLOCA instead of always
5310 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5311 is one byte too soon. Don't use xrealloc; instead xfree and
5314 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5316 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5319 * gnutls.c: Renamed global_initialized to
5320 gnutls_global_initialized. Added internals for the
5321 :verify-hostname-error, :verify-error, and :verify-flags
5322 parameters of `gnutls-boot' and documented those parameters in the
5323 docstring. Start callback support.
5324 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5325 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5326 on error. Return error code.
5327 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5328 (emacs_gnutls_read): Likewise.
5329 (Fgnutls_boot): Return handshake error code.
5330 (emacs_gnutls_handle_error): New function.
5331 (wsaerror_to_errno): Likewise.
5333 * w32.h (emacs_gnutls_pull): Add prototype.
5334 (emacs_gnutls_push): Likewise.
5336 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5337 (emacs_gnutls_push): Likewise.
5339 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5341 * process.c (wait_reading_process_output): Check if GnuTLS
5342 buffered some data internally if no FDs are set for TLS
5345 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5346 (LIBS): Link to USER_LIBS.
5347 ($(BLD)/gnutls.$(0)): New target.
5349 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5351 * xdisp.c (handle_single_display_spec): Rename the
5352 display_replaced_before_p argument into display_replaced_p, to
5353 make it consistent with the commentary. Fix typos in the
5356 * textprop.c (syms_of_textprop): Remove dead code.
5357 (copy_text_properties): Delete obsolete commentary about an
5358 interface that was deleted long ago. Fix typos in the description
5361 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5362 to changes in oldXMenu/XMenu.h from 2011-04-16.
5363 <menu_help_message, prev_menu_help_message>: Constify.
5364 (IT_menu_make_room): menu->help_text is now `const char **';
5367 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5368 to changes in oldXMenu/XMenu.h from 2011-04-16.
5369 (struct XMenu): Declare `help_text' `const char **'.
5371 * xfaces.c <Qunspecified>: Make extern again.
5373 * syntax.c: Include sys/types.h before including regex.h, as
5376 * doc.c (get_doc_string): Improve the format passed to `error'.
5378 * doprnt.c (doprnt): Improve commentary.
5380 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5382 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5385 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5386 changes in globals.h immediately force recompilation.
5387 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5388 $(CURDIR)/s/ms-w32.h.
5389 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5391 * character.c (Fchar_direction): Function deleted.
5392 (syms_of_character): Don't defsubr it.
5393 <char-direction-table>: Deleted.
5395 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5397 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5398 * doprnt.c: Include limits.h.
5399 (SIZE_MAX): New macro.
5400 (doprnt): Return a size_t value. 2nd arg is now size_t.
5401 Many local variables are now size_t instead of int or unsigned.
5402 Improve overflow protection. Support `l' modifier for integer
5403 conversions. Support %l conversion. Don't assume an EMACS_INT
5404 argument for integer conversions and for %c.
5406 * lisp.h (doprnt): Restore prototype.
5408 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5411 * Makefile.in (base_obj): Add back doprnt.o.
5413 * deps.mk (doprnt.o): Add back prerequisites.
5414 (callint.o): Depend on character.h.
5416 * eval.c (internal_lisp_condition_case): Include the handler
5417 representation in the error message.
5418 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5419 when breaking from the loop.
5421 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5423 * callint.c (Fcall_interactively): When displaying error message
5424 about invalid control letter, pass the character's codepoint, not
5425 a pointer to its multibyte form. Improve display of the character
5426 in octal and display also its hex code.
5428 * character.c (char_string): Use %x to display the (unsigned)
5429 codepoint of an invalid character, to avoid displaying a bogus
5432 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5433 `error', not SYMBOL_NAME itself.
5435 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5436 character arguments to `error'.
5438 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5439 to `error' in error message about FINAL_CHAR argument. Make sure
5440 FINAL_CHAR is a character, and use %c when it is passed as
5441 argument to `error'.
5443 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5445 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5447 * w32.c: Include <time.h>.
5448 (sys_localtime): New function.
5450 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5452 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5454 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5456 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5458 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5461 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5463 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5464 gl_state.e_property when gl_state.object is Qt.
5466 * insdel.c (make_gap_larger): Remove limitation of buffer size
5469 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5471 * xdisp.c (lookup_glyphless_char_display)
5472 (produce_glyphless_glyph): Handle cons cell entry in
5473 glyphless-char-display.
5474 (Vglyphless_char_display): Document it.
5476 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5477 glyphless-char-display.
5479 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5481 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5483 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5485 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5486 definition for no-X builds.
5488 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5490 Static checks with GCC 4.6.0 and non-default toolkits.
5492 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5494 * process.c (keyboard_bit_set): Define only if SIGIO.
5495 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5496 (send_process): Repair possible setjmp clobbering.
5498 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5500 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5502 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5504 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5505 Define only if needed.
5507 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5508 by pacifying GCC about it. Maybe it's time to retire it?
5509 * xfaces.c (USG, __TIMEVAL__): Likewise.
5511 * dispextern.h (struct redisplay_interface): Rename param
5513 * termhooks.h (struct terminal): Likewise.
5514 * xterm.c (xembed_send_message): Likewise.
5516 * insdel.c (make_gap_smaller): Define only if
5517 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5519 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5522 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5523 so that we aren't warned about unused symbols.
5525 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5527 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5529 * xfns.c (x_real_positions): Mark locals as initialized.
5531 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5533 * xterm.c: Fix problems found by static analysis with other toolkits.
5534 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5535 (x_dispatch_event): Declare static if USE_GTK, and
5536 define if USE_GTK || USE_X_TOOLKIT.
5537 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5538 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5539 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5540 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5542 * xmenu.c (menu_help_callback): Pointer type fixes.
5543 Use const pointers when pointing at readonly data. Avoid pointer
5545 (FALSE): Remove unused macro.
5546 (update_frame_menubar): Remove unused decl.
5548 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5550 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5551 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5552 (single_menu_item): Rename local to avoid shadowing.
5554 * keyboard.c (make_lispy_event): Remove unused local var.
5556 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5557 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5559 * bitmaps: Change bitmaps from unsigned char back to the X11
5560 compatible char. Avoid the old compiler warnings about
5561 out-of-range initializers by using, for example, '\xab' rather
5564 * xgselect.c (xgselect_initialize): Check vs interface
5565 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5567 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5569 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5570 to read-only memory.
5572 * fns.c (vector): Remove; this old hack is no longer needed.
5574 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5576 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5578 * xrdb.c (x_load_resources): Omit unused local.
5580 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5581 (x_window): Rename locals to avoid shadowing.
5582 (USG): Use the kludged USG macro, to pacify gcc.
5584 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5585 (x_term_init): Remove local to avoid shadowing.
5587 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5589 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5590 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5592 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5594 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5596 Fix regex.c, syntax.c and friends for buffers > 2GB.
5597 * syntax.h (struct gl_state_s): Declare character position members
5600 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5602 * textprop.c (verify_interval_modification, interval_of):
5603 Declare arguments EMACS_INT.
5605 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5608 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5610 * indent.c (Fvertical_motion): Local variable it_start is now
5613 * regex.c (re_match, re_match_2, re_match_2_internal)
5614 (bcmp_translate, regcomp, regexec, print_double_string)
5615 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5616 (re_compile_pattern, re_exec): Declare arguments and local
5617 variables `size_t' and `ssize_t' and return values `regoff_t', as
5619 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5620 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5621 <compile_stack_type>: `size' and `avail' are now `size_t'.
5623 * regex.h <regoff_t>: Use ssize_t, not int.
5624 (re_search, re_search_2, re_match, re_match_2): Arguments that
5625 specify buffer/string position and length are now ssize_t and
5626 size_t. Return type is regoff_t.
5628 2011-04-16 Ben Key <bkey76@gmail.com>
5630 * nsfont.m: Fixed bugs in ns_get_family and
5631 ns_descriptor_to_entity that were caused by using free to
5632 deallocate memory blocks that were allocated by xmalloc (via
5633 xstrdup). This caused Emacs to crash when compiled with
5634 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5635 --enable-checking=xmallocoverrun). xfree is now used to
5636 deallocate these memory blocks.
5638 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5640 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5642 emacs_write: Accept and return EMACS_INT for sizes.
5643 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5645 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5646 Accept and return EMACS_INT.
5647 (emacs_gnutls_write): Return the number of bytes written on
5649 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5650 (emacs_read, emacs_write): Remove check for negative size, as the
5651 Emacs source code has been audited now.
5652 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5653 (emacs_read, emacs_write): Use it.
5654 * process.c (send_process): Adjust to the new signatures of
5655 emacs_write and emacs_gnutls_write. Do not attempt to store
5656 a byte offset into an 'int'; it might overflow.
5657 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5659 * sound.c: Don't assume sizes fit in 'int'.
5660 (struct sound_device.period_size, alsa_period_size):
5661 Return EMACS_INT, not int.
5662 (struct sound_device.write, vox_write, alsa_write):
5663 Accept EMACS_INT, not int.
5664 (wav_play, au_play): Use EMACS_INT to store sizes and to
5665 record read return values.
5667 2011-04-15 Ben Key <bkey76@gmail.com>
5669 * keyboard.c (Qundefined): Don't declare static since it is used
5671 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5672 static since they are used in nsfont.m.
5674 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5676 * process.c (Qprocessp): Don't declare static.
5677 * lisp.h (Qprocessp): Declare again.
5679 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5681 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5683 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5685 Improve C-level modularity by making more things 'static'.
5687 Don't publish debugger-only interfaces to other modules.
5688 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5689 (verify_bytepos, count_markers): Move decls to the only modules
5691 * region-cache.h (pp_cache): Likewise.
5692 * window.h (check_all_windows): Likewise.
5693 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5695 * sysdep.c (croak): Now static, if
5696 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5697 * syssignal.h (croak): Declare only if not static.
5699 * alloc.c (refill_memory_reserve): Now static if
5700 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5701 * lisp.h (refill_memory_reserve): Declare only if not static.
5703 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5704 Define only if USE_LUCID.
5706 * xrdb.c (x_customization_string, x_rm_string): Now static.
5708 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5709 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5711 * xdisp.c (draw_row_with_mouse_face): Now static.
5712 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5714 * window.h (check_all_windows): Mark externally visible.
5716 * window.c (window_deletion_count): Now static.
5718 * undo.c: Make symbols static if they're not exported.
5719 (last_undo_buffer, last_boundary_position, pending_boundary):
5722 * textprop.c (interval_insert_behind_hooks): Now static.
5723 (interval_insert_in_front_hooks): Likewise.
5725 * term.c: Make symbols static if they're not exported.
5726 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5727 (max_frame_lines, tty_set_terminal_modes):
5728 (tty_reset_terminal_modes, tty_turn_off_highlight):
5729 (get_tty_terminal): Now static.
5730 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5731 * termhooks.h (term_mouse_moveto): Do not declare if
5733 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5734 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5736 * sysdep.c: Make symbols static if they're not exported.
5737 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5739 (sigprocmask_set, full_mask): Remove; unused.
5740 (wait_debugging): Mark as visible.
5741 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5742 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5744 * syntax.c (syntax_temp): Define only if !__GNUC__.
5746 * sound.c (current_sound_device, current_sound): Now static.
5748 * search.c (searchbufs, searchbuf_head): Now static.
5750 * scroll.c (scroll_cost): Remove; unused.
5751 * dispextern.h (scroll_cost): Remove decl.
5753 * region-cache.h (pp_cache): Mark as externally visible.
5755 * process.c: Make symbols static if they're not exported.
5756 (process_tick, update_tick, create_process, chan_process):
5757 (Vprocess_alist, proc_buffered_char, datagram_access):
5758 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5759 (deactivate_process): Mark defn as static, as well as decl.
5760 * lisp.h (create_process): Remove decl.
5761 * process.h (chan_process, Vprocess_alist): Remove decls.
5763 * print.c: Make symbols static if they're not exported.
5764 (print_depth, new_backquote_output, being_printed, print_buffer):
5765 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5766 (print_interval, print_number_index, initial_stderr_stream):
5768 * lisp.h (Fprinc): Remove decl.
5769 (debug_output_compilation_hack): Mark as externally visible.
5771 * sysdep.c (croak): Move decl from here to syssignal.h.
5772 * syssignal.h (croak): Put it here, so the API can be checked when
5773 'croak' is called from dissociate_if_controlling_tty.
5775 * minibuf.c: Make symbols static if they're not exported.
5776 (minibuf_save_list, choose_minibuf_frame): Now static.
5777 * lisp.h (choose_minibuf_frame): Remove decl.
5779 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5781 * lread.c: Make symbols static if they're not exported.
5782 (read_objects, initial_obarray, oblookup_last_bucket_number):
5784 (make_symbol): Remove; unused.
5785 * lisp.h (initial_obarray, make_symbol): Remove decls.
5787 * keyboard.c: Make symbols static if they're not exported.
5788 (single_kboard, recent_keys_index, total_keys, recent_keys):
5789 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5790 (this_single_command_key_start, echoing, last_auto_save):
5791 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5792 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5793 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5794 (Vlispy_mouse_stem, double_click_count):
5796 (force_auto_save_soon): Define only if SIGDANGER.
5797 (ignore_mouse_drag_p): Now static if
5798 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5799 (print_help): Remove; unused.
5800 (stop_character, last_timer_event): Mark as externally visible.
5801 * keyboard.h (ignore_mouse_drag_p): Declare only if
5802 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5803 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5804 * lisp.h (echoing): Remove decl.
5805 (force_auto_save_soon): Declare only if SIGDANGER.
5806 * xdisp.c (redisplay_window): Simplify code, to make it more
5807 obvious that ignore_mouse_drag_p is not accessed if !defined
5808 USE_GTK && !defined HAVE_NS.
5810 * intervals.c: Make symbols static if they're not exported.
5811 (merge_properties_sticky, merge_interval_right, delete_interval):
5813 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5815 * insdel.c: Make symbols static if they're not exported.
5816 However, leave prepare_to_modify_buffer alone. It's never
5817 called from outside this function, but that appears to be a bug.
5818 (combine_after_change_list, combine_after_change_buffer):
5819 (adjust_after_replace, signal_before_change): Now static.
5820 (adjust_after_replace_noundo): Remove; unused.
5821 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5822 (signal_before_change): Remove decls.
5824 * indent.c (val_compute_motion, val_vmotion): Now static.
5826 * image.c: Make symbols static if they're not exported.
5827 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5829 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5830 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5832 * fringe.c (standard_bitmaps): Now static.
5833 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5835 * frame.c: Make symbols static if they're not exported.
5836 (x_report_frame_params, make_terminal_frame): Now static.
5837 (get_frame_param): Now static, unless HAVE_NS.
5838 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5839 (x_get_resource_string): Remove; not used.
5840 * frame.h (make_terminal_frame, x_report_frame_params):
5841 (x_get_resource_string); Remove decls.
5842 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5843 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5845 * font.c, fontset.c: Make symbols static if they're not exported.
5846 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5847 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5848 * font.c (font_close_object): Now static.
5849 * font.h (font_close_object): Remove.
5850 * fontset.c (FONTSET_OBJLIST): Remove.
5851 (free_realized_fontset) #if-0 the body, which does nothing.
5852 (face_suitable_for_char_p): #if-0, as it's never called.
5853 * fontset.h (face_suitable_for_char_p): Remove decl.
5854 * xfaces.c (face_at_string_position):
5855 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5856 since 0 is always ASCII.
5858 * fns.c (weak_hash_tables): Now static.
5860 * fileio.c: Make symbols static if they're not exported.
5861 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5862 (Vwrite_region_annotation_buffers): Now static.
5864 * eval.c: Make symbols static if they're not exported.
5865 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5866 * lisp.h (backtrace_list): Remove decl.
5868 * emacs.c: Make symbols static if they're not exported.
5869 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5870 (fatal_error_code, fatal_error_signal_hook, standard_args):
5872 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5873 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5874 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5875 * lisp.h (fatal_error_signal_hook): Remove decl.
5876 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5878 * editfns.c: Move a (normally-unused) function to its only use.
5879 * editfns.c, lisp.h (get_operating_system_release): Remove.
5880 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5881 worth the hassle of breaking this out.
5883 * xterm.c: Make symbols static if they're not exported.
5884 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5885 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5886 (x_destroy_window, x_delete_display):
5888 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5889 (x_mouse_leave): Remove; unused.
5890 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5891 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5892 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5894 (x_mouse_leave): Declare only if WINDOWSNT.
5895 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5896 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5899 * ftxfont.c: Make symbols static if they're not exported.
5900 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5902 * font.h (ftxfont_driver): Likewise.
5904 * xfns.c: Make symbols static if they're not exported.
5905 (x_last_font_name, x_display_info_for_name):
5906 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5907 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5908 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5909 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5910 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5911 (last_show_tip_args): Now static.
5912 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5913 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5914 (x_screen_planes): Remove; unused.
5915 * dispextern.h (x_screen_planes): Remove decl.
5917 * dispnew.c: Make symbols static if they're not exported.
5918 * dispextern.h (redraw_garbaged_frames, scrolling):
5919 (increment_row_positions): Remove.
5920 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5921 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5923 (redraw_garbaged_frames): Remove; unused.
5925 * xfaces.c: Make symbols static if they're not exported.
5926 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5928 * xterm.h (defined_color): Remove decls.
5929 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5930 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5931 (menu_face_changed_default, defined_color, free_realized_face):
5932 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5933 (ascii_face_of_lisp_face): Remove; unused.
5935 * xdisp.c: Make symbols static if they're not exported.
5936 * dispextern.h (scratch_glyph_row, window_box_edges):
5937 (glyph_to_pixel_coords, set_cursor_from_row):
5938 (get_next_display_element, set_iterator_to_next):
5939 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5940 (show_mouse_face): Remove decls
5941 * frame.h (message_buf_print): Likewise.
5942 * lisp.h (pop_message, set_message, check_point_in_composition):
5944 * xterm.h (set_vertical_scroll_bar): Likewise.
5945 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5946 (message_buf_print, scratch_glyph_row, displayed_buffer):
5947 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5948 (get_next_display_element, show_mouse_face, window_box_edges):
5949 (frame_to_window_pixel_xy, check_point_in_composition):
5950 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5951 (glyph_to_pixel_coords): Remove; unused.
5953 * dired.c (file_name_completion): Now static.
5955 * dbusbind.c (xd_in_read_queued_messages): Now static.
5957 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5958 * data.c (circular_list_error): Remove.
5960 * commands.h (last_point_position, last_point_position_buffer):
5961 (last_point_position_window): Remove decls.
5962 * keyboard.c: Make these variables static.
5964 * coding.h (coding, code_convert_region, encode_coding_gap):
5966 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5967 (iso_code_class, detect_coding, code_convert_region): Now static.
5968 (encode_coding_gap): Remove; unused.
5970 * chartab.c (chartab_chars, chartab_bits): Now static.
5972 * charset.h (charset_iso_8859_1): Remove decl.
5973 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5976 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5977 * ccl.c (Vccl_program_table): Now static.
5978 (check_ccl_update): Remove; unused.
5980 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5981 * category.h: ... from here.
5982 * category.c (check_category_table, set_category_set): Now static.
5984 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5985 * lisp.h: Remove these decls.
5987 * buffer.c (buffer_count): Remove unused var.
5989 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5990 so that it's not optimized away.
5991 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5992 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5993 exported only to the debugger.
5995 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5996 * atimer.h (run_all_atimers): Remove; not exported.
5998 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5999 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6000 was inaccessible from Lisp.
6001 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6002 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6004 alloc.c: Import and export fewer symbols, and remove unused items.
6005 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6007 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6008 it's not optimized away by whole-program optimization.
6009 (message_enable_multibyte, free_misc): Remove.
6010 (catchlist, handlerlist, mark_backtrace):
6011 Declare only if BYTE_MARK_STACK.
6012 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6013 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6014 (message_enable_multibyte): Remove decl.
6015 (free_misc, interval_free_list, float_block, float_block_index):
6016 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6017 (cons_free_list, last_marked_index):
6019 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6020 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6021 (mark_backtrace): Define only if BYTE_MARK_STACK.
6022 * xdisp.c (message_enable_multibyte): Now static.
6024 Declare Lisp_Object Q* variables to be 'static' if not exported.
6025 This makes it easier for human readers (and static analyzers)
6026 to see whether these variables are used from other modules.
6027 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6028 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6029 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6030 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6031 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6032 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6033 * xmenu.c, xselect.c:
6034 Declare Q* vars static if they are not used in other modules.
6035 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6036 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6037 Remove decls of unexported vars.
6038 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6040 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6042 Make Emacs functions such as Fatom 'static' by default.
6043 This makes it easier for human readers (and static analyzers)
6044 to see whether these functions can be called from other modules.
6045 DEFUN now defines a static function. To make the function external
6046 so that it can be used in other C modules, use the new macro DEFUE.
6047 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6048 (Finit_image_library):
6049 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6050 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6051 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6052 Remove decls, since these functions are now static.
6053 (Funintern, Fget_internal_run_time): New decls, since these functions
6054 were already external.
6056 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6057 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6058 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6059 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6060 * keyboard.c, keymap.c, lread.c:
6061 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6062 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6063 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6064 Mark functions with DEFUE instead of DEFUN,
6065 if they are used in other modules.
6066 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6067 decls for now-static functions.
6068 * buffer.h (Fdelete_overlay): Remove decl.
6069 * callproc.c (Fgetenv_internal): Mark as internal.
6070 * composite.c (Fremove_list_of_text_properties): Remove decl.
6071 (Fcomposition_get_gstring): New forward static decl.
6072 * composite.h (Fcomposite_get_gstring): Remove decl.
6073 * dired.c (Ffile_attributes): New forward static decl.
6074 * doc.c (Fdocumntation_property): New forward static decl.
6075 * eval.c (Ffetch_bytecode): New forward static decl.
6076 (Funintern): Remove extern decl; now in .h file where it belongs.
6077 * fileio.c (Fmake_symbolic_link): New forward static decl.
6078 * image.c (Finit_image_library): New forward static decl.
6079 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6080 * intervals.h (Fprevious_property_change):
6081 (Fremove_list_of_text_properties): Remove decls.
6082 * keyboard.c (Fthis_command_keys): Remove decl.
6083 (Fcommand_execute): New forward static decl.
6084 * keymap.c (Flookup_key): New forward static decl.
6085 (Fcopy_keymap): Now static.
6086 * keymap.h (Flookup_key): Remove decl.
6087 * process.c (Fget_process): New forward static decl.
6088 (Fprocess_datagram_address): Mark as internal.
6089 * syntax.c (Fsyntax_table_p): New forward static decl.
6090 (skip_chars): Remove duplicate decl.
6091 * textprop.c (Fprevious_property_change): New forward static decl.
6092 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6094 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6095 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6097 * editfns.c (Fformat): Remove unreachable code.
6099 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6101 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6104 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6106 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6107 when at ZV. (Bug#8487)
6109 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6111 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6113 * keyboard.c (parse_tool_bar_item): Likewise.
6114 * sound.c (sound_cleanup, alsa_close): Likewise.
6115 * termcap.c (tgetent): Likewise.
6116 * xfns.c (x_default_font_parameter): Likewise.
6117 * xsettings.c (read_and_apply_settings): Likewise.
6119 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6120 (overrun_check_free): Protoize.
6122 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6124 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6125 since callers should never pass a negative size.
6126 Change the signature to match that of plain 'read' and 'write'; see
6127 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6128 * lisp.h: Update prototypes of emacs_write and emacs_read.
6130 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6132 * xdisp.c (redisplay_window): Don't try to determine the character
6133 position of the scroll margin if the window start point w->startp
6134 is outside the buffer's accessible region. (Bug#8468)
6136 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6138 Fix write-region and its subroutines for buffers > 2GB.
6139 * fileio.c (a_write, e_write): Modify declaration of arguments and
6140 local variables to support buffers larger than 2GB.
6141 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6143 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6144 argument, local variables, and return value.
6146 * lisp.h: Update prototypes of emacs_write and emacs_read.
6148 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6150 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6152 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6154 Fix more problems found by GCC 4.6.0's static checks.
6156 * xdisp.c (vmessage): Use a better test for character truncation.
6158 * charset.c (load_charset_map): <, not <=, for optimization,
6159 and to avoid potential problems with integer overflow.
6160 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6161 * casetab.c (set_identity, shuffle): Likewise.
6162 * editfns.c (Fformat): Likewise.
6163 * syntax.c (skip_chars): Likewise.
6165 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6166 This also lets GCC 4.6.0 generate slightly better loop code.
6168 * callint.c (Fcall_interactively): <, not <=, for optimization.
6169 (Fcall_interactively): Count the number of arguments produced,
6170 not the number of arguments given. This is simpler and lets GCC
6171 4.6.0 generate slightly better code.
6173 * ftfont.c: Distingish more carefully between FcChar8 and char.
6174 The previous code passed unsigned char * to a functions like
6175 strlen and xstrcasecmp that expect char *, which does not
6176 conform to the C standard.
6177 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6178 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6179 char * when the C standard requires it.
6181 * keyboard.c (read_char): Remove unused var.
6183 * eval.c: Port to Windows vsnprintf (Bug#8435).
6185 (SIZE_MAX): Define if the headers do not.
6186 (verror): Do not give up if vsnprintf returns a negative count.
6187 Instead, grow the buffer. This ports to Windows vsnprintf, which
6188 does not conform to C99. Problem reported by Eli Zaretskii.
6189 Also, simplify the allocation scheme, by avoiding the need for
6190 calling realloc, and removing the ALLOCATED variable.
6192 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6194 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6195 But keep the doprint source code for now, as we might revamp it
6196 and use it again (Bug#8435).
6197 * lisp.h (doprnt): Remove.
6198 * Makefile.in (base_obj): Remove doprnt.o.
6199 * deps.mk (doprnt.o): Remove.
6201 error: Print 32- and 64-bit integers portably (Bug#8435).
6202 Without this change, on typical 64-bit hosts error ("...%d...", N)
6203 was used to print both 32- and 64-bit integers N, which relied on
6205 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6207 * lisp.h (error, verror): Mark as printf-like functions.
6208 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6209 Report overflow in size calculations when allocating printf buffer.
6210 Do not truncate output string at its first null byte.
6211 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6212 Truncate the output at a character boundary, since vsnprintf does not
6214 * charset.c (check_iso_charset_parameter): Convert internal
6215 character to string before calling 'error', since %c now has the
6217 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6218 overflow when computing char to be passed to 'error'. Do not
6219 pass Lisp_Object to 'error'; pass the integer instead.
6220 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6221 formatted with plain %d.
6223 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6225 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6227 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6229 * xterm.c (x_catch_errors): Remove duplicate declaration.
6231 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6233 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6235 2011-04-10 Jim Meyering <meyering@redhat.com>
6237 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6238 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6239 return ssize_t not "int", and use size_t as the buffer length.
6240 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6241 * gnutls.h: Update declarations.
6242 * process.c (read_process_output): Use ssize_t, to match.
6243 (send_process): Likewise.
6245 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6247 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6249 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6251 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6252 Use unsigned char, to match FcChar8 type definition.
6254 * xterm.c (handle_one_xevent):
6255 * xmenu.c (create_and_show_popup_menu):
6256 * xselect.c (x_decline_selection_request)
6257 (x_reply_selection_request): Avoid type-punned deref of X events.
6259 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6261 Fix some uses of `int' instead of EMACS_INT.
6262 * search.c (string_match_1, fast_string_match)
6263 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6264 (scan_buffer, find_next_newline_no_quit)
6265 (find_before_next_newline, search_command, Freplace_match)
6266 (Fmatch_data): Make some `int' variables be EMACS_INT.
6268 * xdisp.c (display_count_lines): 3rd argument and return value now
6269 EMACS_INT. All callers changed.
6270 (pint2hrstr): Last argument is now EMACS_INT.
6272 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6273 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6274 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6275 (decode_coding_utf_16, decode_coding_emacs_mule)
6276 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6277 (decode_coding_ccl, decode_coding_charset)
6278 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6279 (decode_coding_iso_2022, decode_coding_emacs_mule)
6280 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6281 <char_offset, last_offset>: Declare EMACS_INT.
6282 (encode_coding_utf_8, encode_coding_utf_16)
6283 (encode_coding_emacs_mule, encode_invocation_designation)
6284 (encode_designation_at_bol, encode_coding_iso_2022)
6285 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6286 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6288 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6289 (encode_invocation_designation): Last argument P_NCHARS is now
6291 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6292 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6294 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6297 * ccl.c (Fccl_execute_on_string): Declare some variables
6300 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6302 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6304 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6306 * process.c (Fformat_network_address): Doc fix.
6308 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6310 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6312 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6314 * keyboard.c (read_char): Call Lisp function help-form-show,
6315 instead of using internal_with_output_to_temp_buffer.
6316 (Qhelp_form_show): New var.
6317 (syms_of_keyboard): Use DEFSYM macro.
6319 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6321 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6323 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6325 * process.c (Flist_processes): Remove to Lisp.
6326 (list_processes_1): Delete.
6328 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6330 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6332 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6334 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6336 Fix more problems found by GCC 4.6.0's static checks.
6338 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6340 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6342 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6344 * xdisp.c (vmessage): Mark as a printf-like function.
6346 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6348 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6350 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6351 printf-like functions.
6352 (tiff_load): Add casts to remove these marks before passing them
6353 to system-supplied API.
6355 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6357 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6358 This avoids several warnings with gcc -Wstrict-overflow.
6359 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6360 directly, rather than having caller test rule sign. This avoids
6361 some unnecessary tests.
6362 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6363 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6364 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6366 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6367 (xfont_open): Avoid unnecessary tests.
6369 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6371 * composite.h, composite.c (composition_gstring_put_cache):
6372 Use EMACS_INT, not int, for length.
6374 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6375 breaking out part of COMPOSITION_DECODE_RULE.
6376 (COMPOSITION_DECODE_RULE): Use it.
6377 * composite.c (get_composition_id): Remove unused local vars,
6378 by using the new macro.
6380 * textprop.c (set_text_properties_1): Change while to do-while,
6381 since the condition is always true at first.
6383 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6384 (interval_deletion_adjustment): Return unsigned value.
6387 * process.c (list_processes_1, create_pty, read_process_output):
6388 (exec_sentinel): Remove vars that were set but not used.
6389 (create_pty): Remove unnecessary "volatile"s.
6390 (Fnetwork_interface_info): Avoid possibility of int overflow.
6391 (read_process_output): Do adaptive read buffering even if carryover.
6392 (read_process_output): Simplify nbytes computation if buffered.
6394 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6396 * syntax.c (scan_words): Remove var that was set but not used.
6397 (update_syntax_table): Use unsigned instead of int.
6399 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6400 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6401 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6403 * print.c (print_error_message): Avoid int overflow.
6405 * font.c (font_list_entities): Redo for clarity,
6406 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6408 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6409 (font_score): Avoid potential overflow in diff calculation.
6411 * fns.c (substring_both): Remove var that is set but not used.
6412 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6414 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6416 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6417 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6418 can always succeed if overflow has undefined behavior.
6420 * search.c (boyer_moore, wordify): Remove vars set but not used.
6421 (wordify): Omit three unnecessary tests.
6423 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6424 All callers changed. This avoids the need for an unused var.
6426 * casefiddle.c (casify_region): Remove var that is set but not used.
6428 * dired.c (file_name_completion): Remove var that is set but not used.
6430 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6432 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6433 (Finsert_file_contents): Remove unnecessary code checking fd.
6435 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6436 Check for integer overflow on size calculations.
6438 * buffer.c (Fprevious_overlay_change): Remove var that is set
6441 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6442 Remove vars that are set but not used.
6443 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6444 (timer_check_2): Mark vars as initialized.
6446 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6448 * image.c (lookup_image): Remove var that is set but not used.
6449 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6451 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6452 that are set but not used.
6454 * xfns.c (make_invisible_cursor): Don't return garbage
6455 if XCreateBitmapFromData fails (Bug#8410).
6457 * xselect.c (x_get_local_selection, x_handle_property_notify):
6458 Remove vars that are set but not used.
6460 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6461 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6463 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6464 Remove var that is set but not used.
6465 (scroll_bar_windows_size): Now size_t, not int.
6466 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6469 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6470 (map_tty_color) [!defined MSDOS]: Likewise.
6472 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6474 * coding.c: Remove vars that are set but not used.
6475 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6476 All callers changed.
6477 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6478 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6479 (decode_coding_charset): Remove vars that are set but not used.
6481 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6482 that is set but not used.
6484 * print.c (print_object): Remove var that is set but not used.
6486 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6487 The gnulib version avoids calling malloc in the usual case,
6488 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6489 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6490 * filelock.c (current_lock_owner): Likewise.
6491 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6492 * sysdep.c: Include allocator.h, careadlinkat.h.
6493 (emacs_no_realloc_allocator): New static constant.
6494 (emacs_readlink): New function.
6495 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6496 ../lib/careadlinkat.h.
6498 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6500 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6501 first non-nil return value).
6503 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6505 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6506 if not defined (Bug#8403).
6508 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6510 * xdisp.c (display_count_lines): Remove parameter `start',
6511 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6512 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6513 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6514 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6515 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6516 and thereabouts. All callers changed.
6517 (get_per_char_metric): Remove parameter `f', unused since
6518 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6520 2011-04-02 Jim Meyering <meyering@redhat.com>
6522 do not dereference NULL upon failed strdup
6523 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6524 (ns_get_family): Likewise.
6526 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6528 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6530 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6532 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6535 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6537 Add lexical binding.
6539 * window.c (Ftemp_output_buffer_show): New fun.
6540 (Fsave_window_excursion):
6541 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6543 * lread.c (lisp_file_lexically_bound_p): New function.
6544 (Fload): Bind Qlexical_binding.
6545 (readevalloop): Remove `evalfun' arg.
6546 Bind Qinternal_interpreter_environment.
6547 (Feval_buffer): Bind Qlexical_binding.
6548 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6550 (syms_of_lread): Declare `lexical-binding'.
6552 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6554 * keyboard.c (eval_dyn): New fun.
6555 (menu_item_eval_property): Use it.
6557 * image.c (parse_image_spec): Use Ffunctionp.
6559 * fns.c (concat, mapcar1): Accept byte-code-functions.
6561 * eval.c (Fsetq): Handle lexical vars.
6562 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6563 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6564 (FletX, Flet): Obey lexical binding.
6565 (Fcommandp): Handle closures.
6566 (Feval): New `lexical' arg.
6567 (eval_sub): New function extracted from Feval. Use it almost
6568 everywhere where Feval was used. Look up vars in lexical env.
6570 (Ffunctionp): Move from subr.el.
6571 (Ffuncall): Handle closures.
6572 (apply_lambda): Remove `eval_flags'.
6573 (funcall_lambda): Handle closures and new byte-code-functions.
6574 (Fspecial_variable_p): New function.
6575 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6576 but without exporting it to Lisp.
6578 * doc.c (Fdocumentation, store_function_docstring):
6579 * data.c (Finteractive_form): Handle closures.
6581 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6584 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6586 (exec_byte_code): New function extracted from Fbyte_code to handle new
6587 calling convention for byte-code-functions. Add new byte-codes.
6589 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6591 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6593 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6595 * xdisp.c (redisplay_internal): Fix prototype.
6597 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6599 * xdisp.c (SCROLL_LIMIT): New macro.
6600 (try_scrolling): Use it when setting scroll_limit.
6601 Limit scrolling to 100 screen lines.
6602 (redisplay_window): Even when falling back on "recentering",
6603 position point in the window according to scroll-conservatively,
6604 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6606 (try_scrolling): When point is above the window, allow searching
6607 as far as scroll_max, or one screenful, to compute vertical
6608 distance from PT to the scroll margin position. This prevents
6609 try_scrolling from unnecessarily failing when
6610 scroll-conservatively is set to a value slightly larger than the
6611 window height. Clean up the case of PT below the margin at bottom
6612 of window: scroll_max can no longer be INT_MAX. When aggressive
6613 scrolling is in use, don't let point enter the opposite scroll
6614 margin as result of the scroll.
6615 (syms_of_xdisp) <scroll-conservatively>: Document the
6616 threshold of 100 lines for never-recentering scrolling.
6618 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6620 * dispextern.h (move_it_by_lines):
6621 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6622 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6623 (message_log_check_duplicate): Remove parameters `prev_bol' and
6624 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6625 (redisplay_internal): Remove parameter `preserve_echo_area',
6626 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6628 * indent.c (Fvertical_motion):
6629 * window.c (window_scroll_pixel_based, Frecenter):
6630 Don't pass `need_y_p' to `move_it_by_lines'.
6632 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6634 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6635 steal a few bits to be more compact.
6636 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6637 Remove unneeded casts.
6639 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6641 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6643 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6644 binding" message (bug#7967).
6646 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6648 Fix more problems found by GCC 4.6.0's static checks.
6650 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6651 Remove unused local var.
6653 * editfns.c (Fmessage_box): Remove unused local var.
6655 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6656 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6657 Omit unused local vars.
6658 * window.c (shrink_windows): Omit unused local var.
6659 * menu.c (digest_single_submenu): Omit unused local var.
6660 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6661 Omit unused local var.
6663 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6664 Don't assume string length fits in int.
6665 (keyremap_step, read_key_sequence): Use size_t for sizes.
6666 (read_key_sequence): Don't check last_real_key_start redundantly.
6668 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6669 instead of alloca (Bug#8344).
6671 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6672 (Fbacktrace_frame): Don't assume nframes fits in int.
6674 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6676 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6679 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6681 * cm.c (calccost): Turn while-do into do-while, for clarity.
6683 * keyboard.c (syms_of_keyboard): Use the same style as later
6684 in this function when indexing through an array. This also
6685 works around GCC bug 48267.
6687 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6689 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6691 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6692 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6694 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6695 This avoids undefined behavior on integer overflow, and is a bit
6696 more convenient anyway since it is compared to a size_t variable.
6698 Variadic C functions now count arguments with size_t, not int.
6699 This avoids an unnecessary limitation on 64-bit machines, which
6700 caused (substring ...) to crash on large vectors (Bug#8344).
6701 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6702 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6703 All variadic functions and their callers changed accordingly.
6704 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6705 * data.c (arith_driver, float_arith_driver): Likewise.
6706 * editfns.c (general_insert_function): Likewise.
6707 * eval.c (struct backtrace.nargs, interactive_p)
6708 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6709 (funcall_lambda, mark_backtrace): Likewise.
6710 * fns.c (concat): Likewise.
6711 * frame.c (x_set_frame_parameters): Likewise.
6712 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6713 0 if not found, not -1. All callers changed.
6715 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6716 (stack_copy_size): Now size_t, not int.
6717 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6719 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6721 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6722 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6723 All callers changed.
6725 * lisp.h (multibyte_char_to_unibyte):
6726 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6727 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6728 * character.h (CHAR_TO_BYTE8):
6729 * cmds.c (internal_self_insert):
6730 * editfns.c (general_insert_function):
6731 * keymap.c (push_key_description):
6732 * search.c (Freplace_match):
6733 * xdisp.c (message_dolog, set_message_1): All callers changed.
6735 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6737 * keyboard.c (safe_run_hook_funcall): New function.
6738 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6739 don't set the hook to nil, but remove the offending function instead.
6740 (Qcommand_hook_internal): Remove, unused.
6741 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6742 Vcommand_hook_internal.
6744 * eval.c (enum run_hooks_condition): Remove.
6745 (funcall_nil, funcall_not): New functions.
6746 (run_hook_with_args): Call each function through a `funcall' argument.
6747 Remove `cond' argument, now redundant.
6748 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6749 (Frun_hook_with_args_until_failure): Adjust accordingly.
6750 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6752 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6754 * dispextern.h (string_buffer_position): Remove declaration.
6756 * print.c (strout): Remove parameter `multibyte', unused since
6757 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6759 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6760 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6761 All callers changed.
6763 * w32.c (_wsa_errlist): Use braces for struct initializers.
6765 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6766 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6767 All callers changed.
6768 (string_buffer_position): Likewise. Also, make static (it's never
6769 used outside xdisp.c).
6770 (cursor_row_p): Remove parameter `w', unused since
6771 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6772 (decode_mode_spec): Remove parameter `precision', introduced during
6773 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6774 All callers changed.
6776 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6778 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6780 2011-03-27 Anders Lindgren <andlind@gmail.com>
6782 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6783 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6784 (ns_update_auto_hide_menu_bar): New functions.
6785 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6786 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6787 ns_constrain_all_frames.
6788 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6789 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6791 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6793 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6795 2011-03-27 Glenn Morris <rgm@gnu.org>
6797 * syssignal.h: Replace RETSIGTYPE with void.
6798 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6799 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6800 Replace SIGTYPE with void everywhere.
6801 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6802 * s/template.h (SIGTYPE): Remove commented out definition.
6804 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6806 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6807 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6809 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6811 * w32.c (read_unc_volume): Use parameter `henum', instead of
6812 global variable `wget_enum_handle'.
6814 * keymap.c (describe_vector): Remove parameters `indices' and
6815 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6816 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6818 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6820 * keyboard.c (timer_check): Remove parameter `do_it_now',
6821 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6822 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6823 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6825 * keyboard.c (read_char):
6826 * w32menu.c (w32_menu_display_help):
6827 * xmenu.c (show_help_event, menu_help_callback):
6828 Adjust calls to `show_help_echo'.
6830 * gtkutil.c (xg_maybe_add_timer):
6831 * keyboard.c (readable_events):
6832 * process.c (wait_reading_process_output):
6833 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6835 * insdel.c (adjust_markers_gap_motion):
6836 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6837 (gap_left, gap_right): Don't call it.
6839 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6841 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6842 incurred during fontification.
6844 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6846 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6847 (DEFVAR_PER_BUFFER): Don't pass it.
6849 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6850 (scrolling_window): Don't pass it.
6852 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6854 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6856 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6858 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6859 of variables specific to SELinux and computation of `encoded_absname'.
6861 * image.c (XPutPixel): Remove unused variable `height'.
6863 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6865 * unexw32.c (get_section_info): Remove unused variable `section'.
6867 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6868 (system_process_attributes): Remove unused variable `sess'.
6869 (sys_read): Remove unused variable `err'.
6871 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6872 (w32_wnd_proc): Remove unused variable `isdead'.
6873 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6874 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6875 (x_create_tip_frame): Remove unused variable `tem'.
6877 * w32inevt.c (w32_console_read_socket):
6878 Remove unused variable `no_events'.
6880 * w32term.c (x_draw_composite_glyph_string_foreground):
6881 Remove unused variable `width'.
6883 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6885 * w32term.c (x_set_glyph_string_clipping):
6886 Don't pass uninitialized region to CombineRgn.
6888 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6890 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6891 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6892 (Fx_close_connection): Remove unused variable `i'.
6894 * w32font.c (w32font_draw): Return number of glyphs.
6895 (w32font_open_internal): Remove unused variable `i'.
6896 (w32font_driver): Add missing initializer.
6898 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6899 (fill_in_menu): Remove unused variable `items_added'.
6901 * w32term.c (last_mouse_press_frame): Remove static global variable.
6902 (w32_clip_to_row): Remove unused variable `f'.
6903 (x_delete_terminal): Remove unused variable `i'.
6905 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6906 (NOTHING): Remove unused static global variable.
6907 (uniscribe_check_otf): Remove unused variable `table'.
6908 (uniscribe_font_driver): Add missing initializers.
6910 2011-03-23 Julien Danjou <julien@danjou.info>
6912 * term.c (Fsuspend_tty, Fresume_tty):
6913 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6914 * window.c (temp_output_buffer_show):
6915 * insdel.c (signal_before_change):
6916 * frame.c (Fhandle_switch_frame):
6917 * fileio.c (Fdo_auto_save):
6918 * emacs.c (Fkill_emacs):
6919 * editfns.c (save_excursion_restore):
6920 * cmds.c (internal_self_insert):
6921 * callint.c (Fcall_interactively):
6922 * buffer.c (Fkill_all_local_variables):
6923 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6925 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6926 unconditionnaly since it does the check itself.
6928 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6930 Fix more problems found by GCC 4.5.2's static checks.
6932 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6933 the first time through the loop, since we know p0 < p1 then.
6934 This also avoids a gcc -Wstrict-overflow warning.
6936 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6937 leading to a memory leak, possible in functions like
6938 load_charset_map_from_file that can allocate an unbounded number
6939 of objects (Bug#8318).
6941 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6942 that could (at least in theory) be that large.
6944 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6945 This is less likely to overflow, and avoids undefined behavior if
6946 overflow does occur. All callers changed. Use strtoul to scan
6947 for the unsigned long integer.
6948 (pint2hrstr): Simplify and tune code slightly.
6949 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6951 * scroll.c (do_scrolling): Work around GCC bug 48228.
6952 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6954 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6955 This also avoids a warning with gcc -Wstrict-overflow.
6956 (validate_x_resource_name): Simplify count usage.
6957 This also avoids a warning with gcc -Wstrict-overflow.
6959 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6962 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6964 * process.c (Fmake_network_process): Use socklen_t, not int,
6965 where POSIX says socklen_t is required in portable programs.
6966 This fixes a porting bug on hosts like 64-bit HP-UX, where
6967 socklen_t is wider than int (Bug#8277).
6968 (Fmake_network_process, server_accept_connection):
6969 (wait_reading_process_output, read_process_output):
6972 * process.c: Rename or move locals to avoid shadowing.
6973 (list_processes_1, Fmake_network_process):
6974 (read_process_output_error_handler, exec_sentinel_error_handler):
6975 Rename or move locals.
6976 (Fmake_network_process): Define label "retry_connect" only if needed.
6977 (Fnetwork_interface_info): Fix pointer signedness.
6978 (process_send_signal): Add cast to avoid pointer signedness problem.
6979 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6980 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6982 Make tparam.h and terminfo.c consistent.
6983 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6984 Include tparam.h instead, since it declares them.
6985 * cm.h (PC): Remove extern decl; tparam.h now does this.
6986 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6987 * terminfo.c: Include tparam.h, to check interfaces.
6988 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6989 (tparam): Adjust signature to match interface in tparam.h;
6990 this removes some undefined behavior. Check that outstring and len
6991 are zero, which they always are with Emacs.
6992 * tparam.h (PC, BC, UP): New extern decls.
6994 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6995 (xftfont_open): Rename locals to avoid shadowing.
6997 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6998 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6999 (OTF_TAG_SYM): Omit macro if not needed.
7000 (ftfont_list): Remove unused local.
7001 (get_adstyle_property, ftfont_pattern_entity):
7002 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7003 Rename locals to avoid shadowing.
7005 * xfont.c (xfont_list_family): Mark var as initialized.
7007 * xml.c (make_dom): Now static.
7009 * composite.c (composition_compute_stop_pos): Rename local to
7011 (composition_reseat_it): Remove unused locals.
7012 (find_automatic_composition, composition_adjust_point): Likewise.
7013 (composition_update_it): Mark var as initialized.
7014 (find_automatic_composition): Mark vars as initialized,
7015 with a FIXME (Bug#8290).
7017 character.h: Rename locals to avoid shadowing.
7018 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7019 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7020 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7021 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7024 * textprop.c (property_change_between_p): Remove; unused.
7026 * intervals.c (interval_start_pos): Now static.
7028 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7030 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7031 Rename locals to avoid shadowing.
7033 * sound.c (wav_play, au_play, Fplay_sound_internal):
7034 Fix pointer signedness.
7035 (alsa_choose_format): Remove unused local var.
7036 (wav_play): Initialize a variable to 0, to prevent undefined
7037 behavior (Bug#8278).
7039 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7041 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7043 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7044 clobbering (Bug#8298).
7045 * sysdep.c (sys_subshell): Likewise.
7046 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7048 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7049 This should get cleaned up, so that child_setup has the
7050 same signature on all platforms.
7052 * callproc.c (call_process_cleanup): Now static.
7053 (relocate_fd): Rename locals to avoid shadowing.
7055 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7057 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7058 not to be necessary, and produces flickering.
7060 2011-03-20 Glenn Morris <rgm@gnu.org>
7062 * config.in: Remove file.
7064 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7066 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7067 are now in src/globals.h.
7068 (syms_of_minibuf): Remove spurious & from previous change.
7070 2011-03-20 Leo <sdl.web@gmail.com>
7072 * minibuf.c (completing-read-function): New variable.
7073 (completing-read-default): Rename from completing-read.
7074 (completing-read): Call completing-read-function.
7076 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7078 * xfaces.c (Fx_load_color_file):
7079 Read color file from absolute filename (bug#8250).
7081 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7083 * makefile.w32-in: Update dependencies.
7085 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7087 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7089 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7091 Fix more problems found by GCC 4.5.2's static checks.
7093 * process.c (make_serial_process_unwind, send_process_trap):
7094 (sigchld_handler): Now static.
7096 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7097 That way, the code declares only the vars that it needs.
7098 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7099 * s/cygwin.h (PTY_ITERATION): Likewise.
7100 * s/darwin.h (PTY_ITERATION): Likewise.
7101 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7103 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7104 * process.c (allocate_pty): Don't declare stb unless it's needed.
7106 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7107 (CONSTANTLIM): Remove; unused.
7108 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7109 Define only if needed.
7111 * unexelf.c (unexec): Name an expression,
7112 to avoid gcc -Wbad-function-cast warning.
7113 Use a different way to cause a compilation error if anyone uses
7114 n rather than nn, a way that does not involve shadowing.
7115 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7117 * deps.mk (unexalpha.o): Remove; unused.
7119 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7120 * unexec.h: New file.
7121 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7122 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7124 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7125 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7126 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7127 Change as necessary to match prototype in unexec.h.
7129 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7131 (back_comment, skip_chars): Mark vars as initialized.
7133 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7134 Rename locals to avoid shadowing.
7136 * lread.c (read1): Rewrite so as not to use empty "else".
7137 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7139 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7141 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7142 warning when compiling print.c.
7144 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7145 instead of using an uninitialized var.
7146 (font_sort_entities): Mark var as initialized.
7148 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7150 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7151 pointers to constants.
7152 (font_parse_fcname): Remove unused vars.
7153 (font_delete_unmatched): Now static.
7154 (font_get_spec): Remove; unused.
7155 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7156 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7157 Rename or move locals to avoid shadowing.
7159 * fns.c (require_nesting_list, require_unwind): Now static.
7160 (Ffillarray): Rename locals to avoid shadowing.
7162 * floatfns.c (domain_error2): Define only if needed.
7163 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7165 * alloc.c (mark_backtrace): Move decl from here ...
7166 * lisp.h: ... to here, so that it can be checked.
7168 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7169 (Fdefvar): Rewrite so as not to use empty "else".
7170 (lisp_indirect_variable): Name an expression,
7171 to avoid gcc -Wbad-function-cast warning.
7172 (Fdefvar): Rename locals to avoid shadowing.
7174 * callint.c (quotify_arg, quotify_args): Now static.
7175 (Fcall_interactively): Rename locals to avoid shadowing.
7176 Use const pointer when appropriate.
7178 * lisp.h (get_system_name, get_operating_system_release):
7179 Move decls here, to check interfaces.
7180 * process.c (get_operating_system_release): Move decl to lisp.h.
7181 * xrdb.c (get_system_name): Likewise.
7182 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7183 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7184 some of which prompt warnings from gcc -Wbad-function-cast.
7185 (Fformat_time_string, Fencode_time, Finsert_char):
7186 (Ftranslate_region_internal, Fformat):
7187 Rename or remove local vars to avoid shadowing.
7188 (Ftranslate_region_internal): Mark var as initialized.
7190 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7193 * lisp.h (eassert): Check that the argument compiles, even if
7194 ENABLE_CHECKING is not defined.
7196 * data.c (Findirect_variable): Name an expression, to avoid
7197 gcc -Wbad-function-cast warning.
7198 (default_value, arithcompare, arith_driver, arith_error): Now static.
7199 (store_symval_forwarding): Rename local to avoid shadowing.
7200 (Fmake_variable_buffer_local, Fmake_local_variable):
7201 Mark variables as initialized.
7202 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7204 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7205 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7206 Rename locals to avoid shadowing.
7207 (mark_stack): Move local variables into the #ifdef region where
7209 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7210 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7212 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7213 (GC_STRING_CHARS): Remove; not used.
7214 (Fmemory_limit): Cast sbrk's returned value to char *.
7216 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7217 avoids undefined behavior in theory.
7219 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7221 Use functions, not macros, for up- and down-casing (Bug#8254).
7222 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7223 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7224 to use the following functions instead of these macros.
7225 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7226 EMACS_INT, since callers assume the returned value fits in int.
7227 (upcase1): Likewise, for UPCASE_TABLE.
7228 (uppercasep, lowercasep, upcase): New static inline functions.
7229 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7230 the race-condition problem in the old DOWNCASE.
7232 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7233 Rename locals to avoid shadowing.
7234 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7235 (regex_compile, re_search_2, re_match_2_internal):
7236 Remove unused local vars.
7237 (FREE_VAR): Rewrite so as not to use empty "else",
7238 which gcc can warn about.
7239 (regex_compile, re_match_2_internal): Mark locals as initialized.
7240 (RETALLOC_IF): Define only if needed.
7241 (WORDCHAR_P): Likewise. This one is never needed, but is used
7242 only in a comment talking about a compiler bug, so put inside
7243 the #if 0 of that comment.
7244 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7245 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7248 * search.c (boyer_moore): Rename locals to avoid shadowing.
7249 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7250 (PREV_CHAR_BOUNDARY): Likewise.
7252 * search.c (simple_search): Remove unused var.
7254 * dired.c (compile_pattern): Move decl from here ...
7255 * lisp.h: ... to here, so that it can be checked.
7256 (struct re_registers): New forward decl.
7258 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7260 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7262 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7263 Rename locals to avoid shadowing.
7264 (Fvertical_motion): Mark locals as initialized.
7266 * casefiddle.c (casify_object, casify_region): Now static.
7267 (casify_region): Mark local as initialized.
7269 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7271 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7272 New macros, so that the caller can use some names other than
7273 gcpro1, gcpro2, etc.
7274 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7276 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7277 argument, for consistency with GCPRO2_VAR, etc: it is now the
7278 prefix of the variable, not the variable itself. All uses
7280 * dired.c (directory_files_internal, file_name_completion):
7281 Rename locals to avoid shadowing.
7283 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7284 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7285 dired.c's scmp function, had undefined behavior.
7286 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7287 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7288 * buffer.h: ... to here, because these macros use current_buffer,
7289 and the new implementation with inline functions needs to have
7290 current_buffer in scope now, rather than later when the macros
7292 (downcase, upcase1): New static inline functions.
7293 (DOWNCASE, UPCASE1): Reimplement using these functions.
7294 This avoids undefined behavior in expressions like
7295 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7296 from race conditions in accessing the global variables
7297 case_temp1 and case_temp2.
7298 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7299 * lisp.h (case_temp1, case_temp2): Remove their decls.
7300 * character.h (ASCII_CHAR_P): Move from here ...
7301 * lisp.h: ... to here, so that the inline functions mentioned
7304 * dired.c (directory_files_internal_unwind): Now static.
7306 * fileio.c (file_name_as_directory, directory_file_name):
7307 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7309 (file_name_as_directory): Use const pointers when appropriate.
7310 (Fexpand_file_name): Likewise. In particular, newdir might
7311 point at constant storage, so make it a const pointer.
7312 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7313 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7315 (Fset_file_times, Finsert_file_contents, auto_save_error):
7316 Rename locals to avoid shadowing.
7318 * minibuf.c (choose_minibuf_frame_1): Now static.
7319 (Ftry_completion, Fall_completions): Rename or remove locals
7322 * marker.c (bytepos_to_charpos): Remove; unused.
7324 * lisp.h (verify_bytepos, count_markers): New decls,
7325 so that gcc does not warn that these functions aren't declared.
7327 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7328 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7329 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7330 (copy_text): Remove unused local var.
7332 * filelock.c (within_one_second): Now static.
7333 (lock_file_1): Rename local to avoid shadowing.
7335 * buffer.c (fix_overlays_before): Mark locals as initialized.
7336 (fix_start_end_in_overlays): Likewise. This function should be
7337 simplified by using pointers-to-pointers, but that's a different
7339 (switch_to_buffer_1): Now static.
7340 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7341 (report_overlay_modification): Rename locals to avoid shadowing.
7343 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7344 Fix pointer signedness issue.
7345 (sys_subshell): Mark local as volatile if checking for lint,
7346 to suppress a gcc -Wclobbered warning that does not seem to be right.
7347 (MAXPATHLEN): Define only if needed.
7349 * process.c (serial_open, serial_configure): Move decls from here ...
7350 * systty.h: ... to here, so that they can be checked.
7352 * fns.c (get_random, seed_random): Move extern decls from here ...
7353 * lisp.h: ... to here, so that they can be checked.
7355 * sysdep.c (reset_io): Now static.
7356 (wait_for_termination_signal): Remove; unused.
7358 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7359 (copy_keymap_item, append_key, push_text_char_description):
7361 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7362 (DENSE_TABLE_SIZE): Remove; unused.
7363 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7364 (describe_map_tree):
7365 Rename locals to avoid shadowing.
7367 * keyboard.c: Declare functions static if they are not used elsewhere.
7368 (echo_char, echo_dash, cmd_error, top_level_2):
7369 (poll_for_input, handle_async_input): Now static.
7370 (read_char, kbd_buffer_get_event, make_lispy_position):
7371 (make_lispy_event, make_lispy_movement, apply_modifiers):
7372 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7373 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7374 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7375 (read_key_sequence, read_char): Mark locals as initialized.
7376 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7378 * keyboard.h (make_ctrl_char): New decl.
7379 (mark_kboards): Move decl here ...
7380 * alloc.c (mark_kboards): ... from here.
7382 * lisp.h (force_auto_save_soon): New decl.
7384 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7385 (DEFINE_DUMMY_FUNCTION): New macro.
7386 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7388 (main): Add casts to avoid warnings
7389 if GCC considers string literals to be constants.
7391 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7393 * dbusbind.c: Pointer signedness fixes.
7394 (xd_signature, xd_append_arg, xd_initialize):
7395 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7396 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7397 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7398 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7400 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7401 if GCC considers string literals to be constants.
7402 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7404 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7406 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7407 (print_preprocess, print_object): New macro to fix last change.
7409 * print.c (print_preprocess): Don't forget font objects.
7411 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7413 * emacs.c (USAGE3): Doc fixes.
7415 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7417 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7420 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7422 * lisp.h (VWindow_system, Qfile_name_history):
7423 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7424 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7425 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7427 * w32select.c: Don't #include "keyboard.h".
7428 (run_protected): Add extern declaration for waiting_for_input.
7430 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7431 * w32console.c (detect_input_pending, read_input_pending)
7432 (encode_terminal_code):
7433 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7434 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7435 (w32_system_caret_y, Qfile_name_history):
7436 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7437 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7438 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7439 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7440 * w32proc.c (Qlocal, report_file_error):
7441 * w32term.c (Vwindow_system, updating_frame):
7442 * w32uniscribe.c (initialized, uniscribe_font_driver):
7443 Remove unneeded extern declarations.
7445 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7447 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7449 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7451 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7452 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7453 These macros can no longer be used for assignment.
7455 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7456 Assign struct members directly, instead of using BUF_BEGV etc.
7457 (record_buffer_markers, fetch_buffer_markers): New functions for
7458 recording and fetching special buffer markers.
7459 (set_buffer_internal_1, set_buffer_temp): Use them.
7461 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7463 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7465 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7466 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7468 * xdisp.c (hscroll_window_tree):
7469 (reconsider_clip_changes): Use PT instead of BUF_PT.
7471 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7473 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7474 $(EMACS_ROOT)/lib/intprops.h.
7476 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7478 Fix more problems found by GCC 4.5.2's static checks.
7480 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7481 to unsigned char * to avoid compiler diagnostic.
7482 (xg_free_frame_widgets): Make it clear that a local variable is
7483 needed only if USE_GTK_TOOLTIP.
7484 (gdk_window_get_screen): Make it clear that this macro is needed
7485 only if USE_GTK_TOOLTIP.
7486 (int_gtk_range_get_value): New function, which avoids a diagnostic
7487 from gcc -Wbad-function-cast.
7488 (xg_set_toolkit_scroll_bar_thumb): Use it.
7489 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7490 diagnostic from gcc -Wbad-function-cast.
7491 (get_utf8_string, xg_get_file_with_chooser):
7492 Rename locals to avoid shadowing.
7493 (create_dialog): Move locals to avoid shadowing.
7495 * xgselect.c (xg_select): Remove unused var.
7497 * image.c (four_corners_best): Mark locals as initialized.
7498 (gif_load): Initialize transparent_p to zero (Bug#8238).
7499 Mark another local as initialized.
7500 (my_png_error, my_error_exit): Mark with NO_RETURN.
7502 * image.c (clear_image_cache): Now static.
7503 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7504 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7505 (x_edge_detection): Remove unnecessary cast that
7506 gcc -Wbad-function-cast diagnoses.
7507 (gif_load): Fix pointer signedness.
7508 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7509 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7511 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7513 Improve quality of tests for time stamp overflow.
7514 For example, without this patch (encode-time 0 0 0 1 1
7515 1152921504606846976) returns the obviously-bogus value (-948597
7516 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7517 reports time overflow. See
7518 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7519 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7520 * editfns.c: Include limits.h and intprops.h.
7521 (TIME_T_MIN, TIME_T_MAX): New macros.
7522 (time_overflow): Move earlier, to before first use.
7523 (hi_time, lo_time): New functions, for an accurate test for
7525 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7526 (Fget_internal_run_time): Don't assume time_t fits in int.
7527 (make_time): Use list2 instead of Fcons twice.
7528 (Fdecode_time): More accurate test for out-of-range times.
7529 (check_tm_member): New function.
7530 (Fencode_time): Use it, to test for out-of-range times.
7531 (lisp_time_argument): Don't rely on undefined left-shift and
7532 right-shift behavior when checking for time stamp overflow.
7534 * editfns.c (time_overflow): New function, refactoring common code.
7535 (Fformat_time_string, Fdecode_time, Fencode_time):
7536 (Fcurrent_time_string): Use it.
7538 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7539 * dired.c (make_time): Move to ...
7540 * editfns.c (make_time): ... here.
7541 * systime.h: Note the move.
7543 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7545 * fringe.c (update_window_fringes): Remove unused variables.
7547 * unexmacosx.c (copy_data_segment): Also copy __got section.
7550 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7552 * termcap.c [MSDOS]: Include "msdos.h".
7553 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7554 Constify `char *' arguments and their references according to
7555 prototypes in tparam.h.
7557 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7559 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7560 Adapt all references accordingly.
7562 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7564 2011-03-11 Tom Tromey <tromey@redhat.com>
7566 * buffer.c (syms_of_buffer): Remove obsolete comment.
7568 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7570 * termhooks.h (encode_terminal_code): Declare prototype.
7572 * msdos.c (encode_terminal_code): Don't declare prototype.
7574 * term.c (encode_terminal_code): Now external again, used by
7575 w32console.c and msdos.c.
7577 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7578 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7580 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7582 Fix some minor problems found by GCC 4.5.2's static checks.
7584 * fringe.c (update_window_fringes): Mark locals as initialized
7586 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7588 * alloc.c (mark_fringe_data): Move decl from here ...
7589 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7590 to check its interface.
7591 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7593 * fontset.c (free_realized_fontset): Now static.
7594 (Fset_fontset_font): Rename local to avoid shadowing.
7595 (fontset_font): Mark local as initialized.
7596 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7598 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7600 * xselect.c (x_disown_buffer_selections): Remove; not used.
7601 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7602 (x_own_selection, Fx_disown_selection_internal): Rename locals
7604 (x_handle_dnd_message): Remove local to avoid shadowing.
7606 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7607 so that the caller can use some name other than gcpro1.
7608 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7609 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7610 (Fx_backspace_delete_keys_p):
7611 Use them to avoid shadowing, and rename vars to avoid shadowing.
7612 (x_decode_color, x_set_name, x_window): Now static.
7613 (Fx_create_frame): Add braces to silence GCC warning.
7614 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7615 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7616 Remove unused locals.
7617 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7618 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7619 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7622 * xterm.h (x_mouse_leave): New decl.
7624 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7625 Remove unused functions.
7626 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7627 (x_calc_absolute_position): Now static.
7628 (XTread_socket): Don't define label "out" unless it's used.
7629 Don't declare local "event" unless it's used.
7630 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7631 unless they are used.
7632 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7633 (x_fatal_error_signal): Remove; not used.
7634 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7635 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7636 (x_error_catcher, x_connection_closed, x_error_handler):
7637 (x_error_quitter, xembed_send_message, x_iconify_frame):
7638 (my_log_handler): Rename locals to avoid shadowing.
7639 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7640 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7642 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7643 Rename or move locals to avoid shadowing.
7644 (tty_defined_color, merge_face_heights): Now static.
7645 (free_realized_faces_for_fontset): Remove; not used.
7646 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7647 does not deduce is never used uninitialized.
7648 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7649 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7651 * terminal.c (store_terminal_param): Now static.
7653 * xmenu.c (menu_highlight_callback): Now static.
7654 (set_frame_menubar): Remove unused local.
7655 (xmenu_show): Rename parameter to avoid shadowing.
7656 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7657 since they might point to immutable storage.
7658 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7659 since it's unused otherwise.
7661 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7662 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7663 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7664 avoids a gcc -Wuninitialized diagnostic.
7665 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7666 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7667 does not deduce are never used uninitialized.
7669 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7671 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7672 * window.c (window_loop, size_window):
7673 (run_window_configuration_change_hook, enlarge_window): Likewise.
7675 * window.c (display_buffer): Now static.
7676 (size_window): Mark variables that gcc -Wuninitialized
7677 does not deduce are never used uninitialized.
7678 * window.h (check_all_windows): New decl, to forestall
7679 gcc -Wmissing-prototypes diagnostic.
7680 * dispextern.h (bidi_dump_cached_states): Likewise.
7682 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7684 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7686 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7687 and to avoid gcc -Wuninitialized warning.
7688 (load_charset_map): Mark variables that gcc -Wuninitialized
7689 does not deduce are never used uninitialized.
7690 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7692 * coding.c (coding_set_source, coding_set_destination):
7693 Use "else { /* comment */ }" rather than "else /* comment */;"
7694 for clarity, and to avoid gcc -Wempty-body warning.
7695 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7696 a block, when the outer 'i' will do.
7697 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7698 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7699 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7700 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7701 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7702 Rename locals to avoid shadowing.
7703 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7704 * coding.c (emacs_mule_char, encode_invocation_designation):
7705 Now static, since they're not used elsewhere.
7706 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7707 (decode_coding_object, encode_coding_object, detect_coding_system):
7708 (decode_coding_emacs_mule): Mark variables that gcc
7709 -Wuninitialized does not deduce are never used uninitialized.
7710 (detect_coding_iso_2022): Initialize a local variable that might
7711 be used uninitialized. Leave a FIXME because it's not clear that
7712 this initialization is needed. (Bug#8211)
7713 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7714 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7715 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7716 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7717 Remove unused macros.
7719 * category.c (hash_get_category_set): Remove unused local var.
7720 (copy_category_table): Now static, since it's not used elsewhere.
7721 * character.c (string_count_byte8): Likewise.
7723 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7724 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7726 * chartab.c (copy_sub_char_table): Now static, since it's not used
7728 (sub_char_table_ref_and_range, char_table_ref_and_range):
7729 Rename locals to avoid shadowing.
7730 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7732 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7733 (BIDI_BOB): Remove unused macro.
7735 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7736 deduce are never used uninitialized.
7737 * term.c (encode_terminal_code): Likewise.
7739 * term.c (encode_terminal_code): Now static. Remove unused local.
7741 * tparam.h: New file.
7742 * term.c, tparam.h: Include it.
7743 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7744 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7745 Move these decls to tparam.h, and make them agree with what
7746 is actually in tparam.c. The previous trick of using incompatible
7747 decls in different modules does not conform to the C standard.
7748 All callers of tparam changed to use tparam's actual API.
7749 * tparam.c (tparam1, tparam, tgoto):
7750 Use const pointers where appropriate.
7752 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7753 * cm.h (struct cm): Likewise.
7754 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7755 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7756 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7757 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7758 (turn_on_face, init_tty): Likewise.
7759 * termchar.h (struct tty_display_info): Likewise.
7761 * term.c (term_mouse_position): Rename local to avoid shadowing.
7763 * alloc.c (mark_ttys): Move decl from here ...
7764 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7766 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7768 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7770 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7772 * search.c (compile_pattern_1): Remove argument regp, unused since
7773 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7774 (compile_pattern): Don't pass it.
7776 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7778 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7779 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7781 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7783 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7785 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7786 gdk_window_get_screen, gdk_window_get_geometry,
7787 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7788 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7789 (xg_get_pixbuf_from_pixmap): New function.
7790 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7791 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7792 Call xg_get_pixbuf_from_pixmap instead of
7793 gdk_pixbuf_get_from_drawable.
7794 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7795 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7796 (xg_check_special_colors): Use GtkStyleContext and its functions
7798 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7799 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7800 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7801 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7802 Call gtk_widget_get_preferred_size.
7803 (xg_frame_resized): gdk_window_get_geometry only takes 5
7805 (xg_win_to_widget, xg_event_is_for_menubar):
7806 Call gdk_x11_window_lookup_for_display.
7807 (xg_set_widget_bg): New function.
7808 (delete_cb): New function.
7809 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7810 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7811 (xg_set_background_color): Call xg_set_widget_bg.
7812 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7813 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7814 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7815 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7817 (update_frame_tool_bar): Call gtk_widget_hide.
7818 (xg_initialize): Use GDK_KEY_g.
7820 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7822 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7824 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7825 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7826 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7828 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7830 * w32xfns.c (select_palette): Check success of RealizePalette against
7831 GDI_ERROR, not zero.
7833 See ChangeLog.11 for earlier changes.
7839 Copyright (C) 2011 Free Software Foundation, Inc.
7841 This file is part of GNU Emacs.
7843 GNU Emacs is free software: you can redistribute it and/or modify
7844 it under the terms of the GNU General Public License as published by
7845 the Free Software Foundation, either version 3 of the License, or
7846 (at your option) any later version.
7848 GNU Emacs is distributed in the hope that it will be useful,
7849 but WITHOUT ANY WARRANTY; without even the implied warranty of
7850 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7851 GNU General Public License for more details.
7853 You should have received a copy of the GNU General Public License
7854 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.