1 2011-05-12 Paul Eggert <eggert@cs.ucla.edu>
3 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4 Don't assume that the difference between two unsigned long values
5 can fit into an integer. At this point, we know button_down_time
6 <= event->timestamp, so the difference must be nonnegative, so
7 there's no need to cast the result if double-click-time is
8 nonnegative, as it should be; check that it's nonnegative, just in
9 case. This bug is triggered when events are more than 2**31 ms
10 apart (about 25 days). (Bug#8664)
12 * xselect.c (last_event_timestamp): Remove duplicate decl.
13 (x_own_selection): Remove needless cast to unsigned long.
15 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
16 that always fit in int. Use a sentinel instead of a counter, to
17 avoid a temp and to allay GCC's concerns about possible int overflow.
18 * frame.h (struct frame): Use int for menu_bar_items_used
19 instead of EMACS_INT, since it always fits in int.
21 * menu.c (grow_menu_items): Check for int overflow.
23 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
25 2011-05-11 Paul Eggert <eggert@cs.ucla.edu>
27 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
28 Before, the code was not consistent. These values cannot exceed
29 2**31 - 1 so there's no need to make them unsigned.
30 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
31 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
32 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
34 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
36 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
37 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
38 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
39 presumably because the widths might not match.
41 * window.c (size_window): Avoid needless test at loop start.
43 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
45 * image.c (Finit_image_library): Return t for built-in image types,
46 like pbm and xbm. (Bug#8640)
48 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
50 * w32menu.c (set_frame_menubar): Fix submenu allocation.
52 2011-05-07 Eli Zaretskii <eliz@gnu.org>
54 * w32console.c (Fset_screen_color): Doc fix.
55 (Fget_screen_color): New function.
56 (syms_of_ntterm): Defsubr it.
58 * callproc.c (call_process_cleanup): Don't close and unlink the
59 temporary file if Fcall_process didn't create it in the first
61 (Fcall_process): Don't create tempfile if stdout of the child
62 process will be redirected to a file specified with `:file'.
63 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
64 cue to call_process_cleanup not to close that handle.
66 2011-05-07 Ben Key <bkey76@gmail.com>
68 * makefile.w32-in: The bootstrap-temacs rule now makes use of
69 one of two shell specific rules, either bootstrap-temacs-CMD or
70 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
71 to the previous implementation of the bootstrap-temacs rule.
72 The bootstrap-temacs-CMD rule is similar to the previous
73 implementation of the bootstrap-temacs rule except that it
74 makes use of the ESC_CFLAGS variable instead of the CFLAGS
77 These changes, along with some changes to nt/configure.bat,
78 nt/gmake.defs, and nt/nmake.defs, are required to extend my
79 earlier fix to add support for --cflags and --ldflags options
80 that include quotes so that it works whether make uses cmd or
83 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
85 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
86 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
88 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
89 a string. Handle both cases.
90 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
91 (Fdbus_register_method): Use Qinvalid_function.
93 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
95 * makefile.w32-in: Update dependencies.
96 (LISP_H): Add inttypes.h and stdin.h.
97 (PROCESS_H): Add unistd.h.
99 2011-05-06 Eli Zaretskii <eliz@gnu.org>
101 * lread.c: Include limits.h (fixes the MS-Windows build broken by
102 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
104 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
106 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
108 * term.c (vfatal): Remove stray call to va_end.
109 It's not needed and the C Standard doesn't allow it here anyway.
111 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
112 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
114 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
117 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
119 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
121 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
123 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
125 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
127 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
128 * charset.c (Fdefine_charset_internal): Don't initialize
129 charset.code_space[15]. The value was garbage, on hosts with
130 32-bit int (Bug#8600).
132 * lread.c (read_integer): Be more consistent with string-to-number.
133 Use string_to_number to do the actual conversion; this avoids
134 rounding errors and fixes some other screwups. Without this fix,
135 for example, #x1fffffffffffffff was misread as -2305843009213693952.
136 (digit_to_number): Move earlier, for benefit of read_integer.
137 Return -1 if the digit is out of range for the base, -2 if it is
138 not a digit in any supported base. (Bug#8602)
140 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
142 * dispnew.c (scrolling_window): Return 1 if we scrolled,
143 to match comment at start of function. This also removes a
144 GCC warning about overflow in a 32+64-bit port.
146 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
148 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
149 Reported by Stefan Monnier in
150 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
151 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
152 SYMBOLP-guarded XSYMBOL, not XPNTR.
154 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
155 (EMACS_UINTPTR): Likewise, with uintptr_t.
157 * lisp.h: Prefer 64-bit EMACS_INT if available.
158 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
159 on 32-bit hosts that have 64-bit int, so that they can access
161 However, temporarily disable this change unless the temporary
162 symbol WIDE_EMACS_INT is defined.
164 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
166 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
167 This removes an assumption that EMACS_INT and long are the same
168 width as pointers. The assumption is true for Emacs porting targets
169 now, but we want to make other targets possible.
170 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
171 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
172 In the rest of the code, change types of integers that hold casted
173 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
174 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
175 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
176 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
177 No need to cast type when ORing.
178 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
179 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
180 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
181 assume EMACS_INT is the same width as char *.
182 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
183 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
184 Remove no-longer-needed casts.
185 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
186 (xg_tool_bar_help_callback, xg_make_tool_item):
187 Use EMACS_INTPTR to hold an integer
188 that will be cast to void *; this can avoid a GCC warning
189 if EMACS_INT is not the same width as void *.
190 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
191 * xdisp.c (display_echo_area_1, resize_mini_window_1):
192 (current_message_1, set_message_1):
193 Use a local to convert to proper width without a cast.
194 * xmenu.c (dialog_selection_callback): Likewise.
196 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
197 Also, don't assume VALBITS / RAND_BITS is less than 5,
198 and don't rely on undefined behavior when shifting a 1 left into
200 * lisp.h (get_random): Change signature to match.
202 * lread.c (hash_string): Use size_t, not int, for hash computation.
203 Normally we prefer signed values; but hashing is special, because
204 it's better to use unsigned division on hash table sizes so that
205 the remainder is nonnegative. Also, size_t is the natural width
206 for hashing into memory. The previous code used 'int', which doesn't
207 retain enough info to hash well into very large tables.
208 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
210 * dbusbind.c: Don't possibly lose pointer info when converting.
211 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
212 Use XPNTR rather than XHASH, so that the high-order bits of
213 the pointer aren't lost when converting through void *.
215 * eval.c (Fautoload): Don't double-shift a pointer.
217 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
219 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
221 * gnutls.c (DEF_GNUTLS_FN):
222 * image.c (DEF_IMGLIB_FN): Make function pointers static.
224 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
226 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
229 2011-05-05 Eli Zaretskii <eliz@gnu.org>
231 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
232 New version that can reserve upto 2GB of heap space.
234 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
236 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
238 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
240 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
241 `gnutls_certificate_set_x509_key_file'.
243 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
245 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
248 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
250 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
251 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
252 Remove unused parameter `fildes'.
253 * process.c (read_process_output, send_process): Don't pass it.
255 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
257 Fix previous change: the library cache is defined in w32.c.
258 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
259 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
261 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
263 Implement dynamic loading of GnuTLS on Windows.
265 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
266 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
267 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
270 * gnutls.c (Qgnutls_dll): Define.
271 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
272 (gnutls_*): Declare function pointers.
273 (init_gnutls_functions): New function to initialize function pointers.
274 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
275 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
276 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
277 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
278 (emacs_gnutls_write, emacs_gnutls_read)
279 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
280 (Fgnutls_available_p): New function.
281 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
282 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
283 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
285 * image.c: Include w32.h.
286 (Vimage_type_cache): Delete.
287 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
288 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
289 (w32_delayed_load): Move to w32.c.
291 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
293 * w32.c (QCloaded_from, Vlibrary_cache): Define.
294 (w32_delayed_load): Move from image.c. When loading a library, record
295 its filename in the :loaded-from property of the library id.
296 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
297 Initialize and staticpro them.
298 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
300 * process.c: Include lisp.h before w32.h, not after.
301 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
302 instead of gnutls_record_check_pending.
304 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
306 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
308 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
309 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
312 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
314 * xterm.c (x_set_frame_alpha): Do not set property on anything
315 else than FRAME_X_OUTER_WINDOW (Bug#8608).
317 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
319 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
321 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
323 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
324 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
325 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
326 (gnutls_global_initialized, Qgnutls_bootprop_priority)
327 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
328 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
329 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
330 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
331 (Qgnutls_bootprop_callbacks_verify): Make static.
333 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
335 * callproc.c: Indentation fixup.
337 * sysdep.c (wait_for_termination_1): Make static.
338 (wait_for_termination, interruptible_wait_for_termination): Move
339 after wait_for_termination_1.
341 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
343 * sysdep.c (interruptible_wait_for_termination): New function
344 which is like wait_for_termination, but allows keyboard
347 * callproc.c (Fcall_process): Add (:file "file") as an option for
349 (Fcall_process_region): Ditto.
351 2011-04-30 Eli Zaretskii <eliz@gnu.org>
353 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
354 rather than `XVECTOR (FOO)->size'.
356 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
357 inttypes.h, as a gnulib replacement is used if it not available in
360 2011-04-21 Eli Zaretskii <eliz@gnu.org>
362 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
363 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
364 of MOST_POSITIVE_FIXNUM. (Bug#8528)
366 * coding.c (coding_alloc_by_realloc): Error out if destination
367 will grow beyond MOST_POSITIVE_FIXNUM.
368 (decode_coding_emacs_mule): Abort if there isn't enough place in
369 charbuf for the composition carryover bytes. Reserve an extra
370 space for up to 2 characters produced in a loop.
371 (decode_coding_iso_2022): Abort if there isn't enough place in
372 charbuf for the composition carryover bytes.
374 2011-04-21 Eli Zaretskii <eliz@gnu.org>
376 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
377 aborting when %lld or %lll format is passed.
378 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
379 %llo or %llx format is passed. (Bug#8545)
381 * window.c (window_scroll_line_based): Use a marker instead of
382 simple variables to record original value of point. (Bug#7952)
384 * doprnt.c (doprnt): Fix the case where a multibyte sequence
385 produced by %s or %c overflows available buffer space. (Bug#8545)
387 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
389 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
390 (SIZE_MAX): Move defn after all includes, as they might #define it.
392 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
394 * w32.c (init_environment): Warn about defaulting HOME to C:\.
396 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
398 * keyboard.c (Qdelayed_warnings_hook): Define.
399 (command_loop_1): Run `delayed-warnings-hook'
400 if Vdelayed_warnings_list is non-nil.
401 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
402 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
404 2011-04-28 Eli Zaretskii <eliz@gnu.org>
406 * doprnt.c (doprnt): Don't return value smaller than the buffer
407 size if the message was truncated. (Bug#8545).
409 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
411 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
412 (Fx_window_property): #if-0 the whole functions, not just the bodies.
414 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
416 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
418 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
420 * makefile.w32-in: Update dependencies.
422 2011-04-27 Eli Zaretskii <eliz@gnu.org>
424 Improve `doprnt' and its usage. (Bug#8545)
425 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
426 `format_end'. Remove support for %l as a conversion specifier.
427 Don't use xrealloc. Improve diagnostics when the %l size modifier
428 is used. Update the commentary.
430 * eval.c (verror): Simplify calculation of size_t.
432 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
435 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
437 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
440 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
442 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
443 This makes this file independent of the recent pseudovector change.
445 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
447 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
449 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
450 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
452 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
454 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
455 GCC 4.6.0 optimizes based on type-based alias analysis. For
456 example, if b is of type struct buffer * and v of type struct
457 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
458 != &v->size, and therefore "v->size = 1; b->size = 2; return
459 v->size;" must therefore return 1. This assumption is incorrect
460 for Emacs, since it type-puns struct Lisp_Vector * with many other
461 types. To fix this problem, this patch adds a new type struct
462 vectorlike_header that documents the constraints on layout of vectors
463 and pseudovectors, and helps optimizing compilers not get fooled
464 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
465 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
466 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
468 (XSETPVECTYPE): Rewrite in terms of new macro.
469 (XSETPVECTYPESIZE): New macro, specifying both type and size.
470 This is a bit clearer, and further avoids the possibility of
471 undesirable aliasing.
472 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
473 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
474 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
475 since Lisp_Subr is a special case (no "next" field).
476 (ASIZE): Now uses header.size rather than size. All
477 previous uses of XVECTOR (foo)->size replaced to use this macro,
478 to avoid the hassle of writing XVECTOR (foo)->header.size.
479 (struct vectorlike_header): New type.
480 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
481 object, to help avoid aliasing.
482 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
483 (SUBRP): Likewise, since Lisp_Subr is a special case.
484 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
485 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
486 (struct Lisp_Hash_Table): Combine first two members into a single
487 struct vectorlike_header member. All uses of "size" and "next" members
488 changed to be "header.size" and "header.next".
489 * buffer.h (struct buffer): Likewise.
490 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
491 * frame.h (struct frame): Likewise.
492 * process.h (struct Lisp_Process): Likewise.
493 * termhooks.h (struct terminal): Likewise.
494 * window.c (struct save_window_data, struct saved_window): Likewise.
495 * window.h (struct window): Likewise.
496 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
497 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
498 * buffer.c (init_buffer_once): Likewise.
499 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
501 * process.c (Fformat_network_address): Use local var for size,
504 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
506 Make the Lisp reader and string-to-float more consistent (Bug#8525)
507 * data.c (atof): Remove decl; no longer used or needed.
508 (digit_to_number): Move to lread.c.
509 (Fstring_to_number): Use new string_to_number function, to be
510 consistent with how the Lisp reader treats infinities and NaNs.
511 Do not assume that floating-point numbers represent EMACS_INT
512 without losing information; this is not true on most 64-bit hosts.
513 Avoid double-rounding errors, by insisting on integers when
514 parsing non-base-10 numbers, as the documentation specifies.
515 * lisp.h (string_to_number): New decl, replacing ...
516 (isfloat_string): Remove.
517 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
518 (read1): Do not accept +. and -. as integers; this
519 appears to have been a coding error. Similarly, do not accept
520 strings like +-1e0 as floating point numbers. Do not report
521 overflow for integer overflows unless the base is not 10 which
522 means we have no simple and reliable way to continue.
523 Break out the floating-point parsing into a new
524 function string_to_number, so that Fstring_to_number parses
525 floating point numbers consistently with the Lisp reader.
526 (digit_to_number): Moved here from data.c. Make it static inline.
527 (E_CHAR, EXP_INT): Remove, replacing with ...
528 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
529 (string_to_number): New function, replacing isfloat_string.
530 This function checks for valid syntax and produces the resulting
531 Lisp float number too. Rework it so that string-to-number
532 no longer mishandles examples like "1.0e+". Use strtoumax,
533 so that overflow for non-base-10 numbers is reported only when
534 there's no portable and simple way to convert to floating point.
536 * textprop.c (set_text_properties_1): Rewrite for clarity,
537 and to avoid GCC warning about integer overflow.
539 * intervals.h (struct interval): Use EMACS_INT for members
540 where EMACS_UINT might cause problems. See
541 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
542 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
543 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
545 (offset_intervals): Tell GCC not to worry about length overflow
546 when negating a negative length.
548 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
549 (overrun_check_free): Likewise.
551 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
552 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
555 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
556 (gnutls_make_error): Rename local to avoid shadowing.
557 (gnutls_emacs_global_deinit): ifdef out; not used.
558 (Fgnutls_boot): Use const for pointer to readonly storage.
559 Comment out unused local. Fix pointer signedness problems.
561 * lread.c (openp): Don't stuff size_t into an 'int'.
562 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
563 about possible signed overflow.
565 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
566 (GDK_KEY_g): Don't define if already defined.
567 (xg_prepare_tooltip): Avoid pointer signedness problem.
568 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
570 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
571 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
573 * xfns.c (Fx_window_property): Simplify a bit,
574 to make a bit faster and to avoid GCC 4.6.0 warning.
575 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
577 * fns.c (internal_equal): Don't assume size_t fits in int.
579 * alloc.c (compact_small_strings): Tighten assertion a little.
581 Replace pEd with more-general pI, and fix some printf arg casts.
582 * lisp.h (pI): New macro, generalizing old pEd macro to other
583 conversion specifiers. For example, use "...%"pI"d..." rather
585 (pEd): Remove. All uses replaced with similar uses of pI.
586 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
587 * alloc.c (check_pure_size): Don't overflow by converting size to int.
588 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
589 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
590 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
591 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
592 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
594 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
595 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
596 * print.c (safe_debug_print, print_object): Likewise.
597 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
599 Use pI instead of if-then-else-abort. Use %p to avoid casts,
600 avoiding the 0 flag, which is not portable.
601 * process.c (Fmake_network_process): Use pI to avoid cast.
602 * region-cache.c (pp_cache): Likewise.
603 * xdisp.c (decode_mode_spec): Likewise.
604 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
605 behavior on 64-bit hosts with printf arg.
606 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
607 (x_stop_queuing_selection_requests): Likewise.
608 (x_get_window_property): Don't truncate byte count to an 'int'
611 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
612 here, since it parses constructs like leading '-' and spaces,
613 which are not wanted; and it overflows with large numbers.
614 Instead, simply match F[0-9]+, which is what is wanted anyway.
616 * alloc.c: Remove unportable assumptions about struct layout.
617 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
618 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
619 (allocate_vectorlike, make_pure_vector): Use the new macros,
620 plus offsetof, to remove unportable assumptions about struct layout.
621 These assumptions hold on all porting targets that I know of, but
622 they are not guaranteed, they're easy to remove, and removing them
623 makes further changes easier.
625 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
626 This doesn't fix a bug but makes the code clearer.
627 (string_overrun_cookie): Now const. Use initializers that
628 don't formally overflow signed char, to avoid warnings.
629 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
630 can cause Emacs to crash when string overrun checking is enabled.
631 (allocate_buffer): Don't assume sizeof (struct buffer) is a
632 multiple of sizeof (EMACS_INT); it need not be, if
633 alignof(EMACS_INT) < sizeof (EMACS_INT).
634 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
636 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
638 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
640 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
642 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
643 supposed to be handshaking. (Bug#8556)
644 Reported by Paul Eggert <eggert@cs.ucla.edu>.
646 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
648 * lisp.h (Qdebug): List symbol.
649 * eval.c (Qdebug): Restore global linkage.
650 * keyboard.c (debug-on-event): New variable.
651 (handle_user_signal): Break into debugger when debug-on-event
652 matches the current signal symbol.
654 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
656 * alloc.c (check_sblock, check_string_bytes)
657 (check_string_free_list): Convert to standard C.
659 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
661 * w32.c (emacs_gnutls_push): Fix typo.
663 2011-04-25 Eli Zaretskii <eliz@gnu.org>
665 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
666 "cast to pointer from integer of different size".
668 Improve doprnt and its use in verror. (Bug#8545)
669 * doprnt.c (doprnt): Document the set of format control sequences
670 supported by the function. Use SAFE_ALLOCA instead of always
673 * eval.c (verror): Don't limit the buffer size at size_max-1, that
674 is one byte too soon. Don't use xrealloc; instead xfree and
677 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
679 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
682 * gnutls.c: Renamed global_initialized to
683 gnutls_global_initialized. Added internals for the
684 :verify-hostname-error, :verify-error, and :verify-flags
685 parameters of `gnutls-boot' and documented those parameters in the
686 docstring. Start callback support.
687 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
688 unless a fatal error occured. Call gnutls_alert_send_appropriate
689 on error. Return error code.
690 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
691 (emacs_gnutls_read): Likewise.
692 (Fgnutls_boot): Return handshake error code.
693 (emacs_gnutls_handle_error): New function.
694 (wsaerror_to_errno): Likewise.
696 * w32.h (emacs_gnutls_pull): Add prototype.
697 (emacs_gnutls_push): Likewise.
699 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
700 (emacs_gnutls_push): Likewise.
702 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
704 * process.c (wait_reading_process_output): Check if GnuTLS
705 buffered some data internally if no FDs are set for TLS
708 * makefile.w32-in (OBJ2): Add gnutls.$(O).
709 (LIBS): Link to USER_LIBS.
710 ($(BLD)/gnutls.$(0)): New target.
712 2011-04-24 Eli Zaretskii <eliz@gnu.org>
714 * xdisp.c (handle_single_display_spec): Rename the
715 display_replaced_before_p argument into display_replaced_p, to
716 make it consistent with the commentary. Fix typos in the
719 * textprop.c (syms_of_textprop): Remove dead code.
720 (copy_text_properties): Delete obsolete commentary about an
721 interface that was deleted long ago. Fix typos in the description
724 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
725 to changes in oldXMenu/XMenu.h from 2011-04-16.
726 <menu_help_message, prev_menu_help_message>: Constify.
727 (IT_menu_make_room): menu->help_text is now `const char **';
730 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
731 to changes in oldXMenu/XMenu.h from 2011-04-16.
732 (struct XMenu): Declare `help_text' `const char **'.
734 * xfaces.c <Qunspecified>: Make extern again.
736 * syntax.c: Include sys/types.h before including regex.h, as
739 * doc.c (get_doc_string): Improve the format passed to `error'.
741 * doprnt.c (doprnt): Improve commentary.
743 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
745 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
748 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
749 changes in globals.h immediately force recompilation.
750 (TAGS): Depend on $(CURDIR)/m/intel386.h and
751 $(CURDIR)/s/ms-w32.h.
752 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
754 * character.c (Fchar_direction): Function deleted.
755 (syms_of_character): Don't defsubr it.
756 <char-direction-table>: Deleted.
758 2011-04-23 Eli Zaretskii <eliz@gnu.org>
760 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
761 * doprnt.c: Include limits.h.
762 (SIZE_MAX): New macro.
763 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
764 local variables are now size_t instead of int or unsigned.
765 Improve overflow protection. Support `l' modifier for integer
766 conversions. Support %l conversion. Don't assume an EMACS_INT
767 argument for integer conversions and for %c.
769 * lisp.h (doprnt): Restore prototype.
771 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
774 * Makefile.in (base_obj): Add back doprnt.o.
776 * deps.mk (doprnt.o): Add back prerequisites.
777 (callint.o): Depend on character.h.
779 * eval.c (internal_lisp_condition_case): Include the handler
780 representation in the error message.
781 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
782 when breaking from the loop.
784 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
786 * callint.c (Fcall_interactively): When displaying error message
787 about invalid control letter, pass the character's codepoint, not
788 a pointer to its multibyte form. Improve display of the character
789 in octal and display also its hex code.
791 * character.c (char_string): Use %x to display the (unsigned)
792 codepoint of an invalid character, to avoid displaying a bogus
795 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
796 `error', not SYMBOL_NAME itself.
798 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
799 character arguments to `error'.
801 * charset.c (check_iso_charset_parameter): Fix incorrect argument
802 to `error' in error message about FINAL_CHAR argument. Make sure
803 FINAL_CHAR is a character, and use %c when it is passed as
806 2011-04-23 Eli Zaretskii <eliz@gnu.org>
808 * s/ms-w32.h (localtime): Redirect to sys_localtime.
810 * w32.c: Include <time.h>.
811 (sys_localtime): New function.
813 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
815 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
817 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
819 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
821 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
824 2011-04-19 Eli Zaretskii <eliz@gnu.org>
826 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
827 gl_state.e_property when gl_state.object is Qt.
829 * insdel.c (make_gap_larger): Remove limitation of buffer size
832 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
834 * xdisp.c (lookup_glyphless_char_display)
835 (produce_glyphless_glyph): Handle cons cell entry in
836 glyphless-char-display.
837 (Vglyphless_char_display): Document it.
839 * term.c (produce_glyphless_glyph): Handle cons cell entry in
840 glyphless-char-display.
842 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
844 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
846 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
848 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
849 definition for no-X builds.
851 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
853 Static checks with GCC 4.6.0 and non-default toolkits.
855 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
857 * process.c (keyboard_bit_set): Define only if SIGIO.
858 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
859 (send_process): Repair possible setjmp clobbering.
861 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
863 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
865 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
867 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
868 Define only if needed.
870 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
871 by pacifying GCC about it. Maybe it's time to retire it?
872 * xfaces.c (USG, __TIMEVAL__): Likewise.
874 * dispextern.h (struct redisplay_interface): Rename param
876 * termhooks.h (struct terminal): Likewise.
877 * xterm.c (xembed_send_message): Likewise.
879 * insdel.c (make_gap_smaller): Define only if
880 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
882 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
885 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
886 so that we aren't warned about unused symbols.
888 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
890 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
892 * xfns.c (x_real_positions): Mark locals as initialized.
894 * xmenu.c (xmenu_show): Don't use uninitialized vars.
896 * xterm.c: Fix problems found by static analysis with other toolkits.
897 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
898 (x_dispatch_event): Declare static if USE_GTK, and
899 define if USE_GTK || USE_X_TOOLKIT.
900 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
901 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
902 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
903 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
905 * xmenu.c (menu_help_callback): Pointer type fixes.
906 Use const pointers when pointing at readonly data. Avoid pointer
908 (FALSE): Remove unused macro.
909 (update_frame_menubar): Remove unused decl.
911 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
913 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
914 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
915 (single_menu_item): Rename local to avoid shadowing.
917 * keyboard.c (make_lispy_event): Remove unused local var.
919 * frame.c, frame.h (x_get_resource_string): Bring this back, but
920 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
922 * bitmaps: Change bitmaps from unsigned char back to the X11
923 compatible char. Avoid the old compiler warnings about
924 out-of-range initializers by using, for example, '\xab' rather
927 * xgselect.c (xgselect_initialize): Check vs interface
928 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
930 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
932 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
935 * fns.c (vector): Remove; this old hack is no longer needed.
937 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
939 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
941 * xrdb.c (x_load_resources): Omit unused local.
943 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
944 (x_window): Rename locals to avoid shadowing.
945 (USG): Use the kludged USG macro, to pacify gcc.
947 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
948 (x_term_init): Remove local to avoid shadowing.
950 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
952 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
953 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
955 2011-04-16 Eli Zaretskii <eliz@gnu.org>
957 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
959 Fix regex.c, syntax.c and friends for buffers > 2GB.
960 * syntax.h (struct gl_state_s): Declare character position members
963 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
965 * textprop.c (verify_interval_modification, interval_of): Declare
968 * intervals.c (adjust_intervals_for_insertion): Declare arguments
971 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
973 * indent.c (Fvertical_motion): Local variable it_start is now
976 * regex.c (re_match, re_match_2, re_match_2_internal)
977 (bcmp_translate, regcomp, regexec, print_double_string)
978 (group_in_compile_stack, re_search, re_search_2, regex_compile)
979 (re_compile_pattern, re_exec): Declare arguments and local
980 variables `size_t' and `ssize_t' and return values `regoff_t', as
982 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
983 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
984 <compile_stack_type>: `size' and `avail' are now `size_t'.
986 * regex.h <regoff_t>: Use ssize_t, not int.
987 (re_search, re_search_2, re_match, re_match_2): Arguments that
988 specify buffer/string position and length are now ssize_t and
989 size_t. Return type is regoff_t.
991 2011-04-16 Ben Key <bkey76@gmail.com>
993 * nsfont.m: Fixed bugs in ns_get_family and
994 ns_descriptor_to_entity that were caused by using free to
995 deallocate memory blocks that were allocated by xmalloc (via
996 xstrdup). This caused Emacs to crash when compiled with
997 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
998 --enable-checking=xmallocoverrun). xfree is now used to
999 deallocate these memory blocks.
1001 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1003 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1005 emacs_write: Accept and return EMACS_INT for sizes.
1006 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1008 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1009 Accept and return EMACS_INT.
1010 (emacs_gnutls_write): Return the number of bytes written on
1012 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1013 (emacs_read, emacs_write): Remove check for negative size, as the
1014 Emacs source code has been audited now.
1015 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1016 (emacs_read, emacs_write): Use it.
1017 * process.c (send_process): Adjust to the new signatures of
1018 emacs_write and emacs_gnutls_write. Do not attempt to store
1019 a byte offset into an 'int'; it might overflow.
1020 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1022 * sound.c: Don't assume sizes fit in 'int'.
1023 (struct sound_device.period_size, alsa_period_size):
1024 Return EMACS_INT, not int.
1025 (struct sound_device.write, vox_write, alsa_write):
1026 Accept EMACS_INT, not int.
1027 (wav_play, au_play): Use EMACS_INT to store sizes and to
1028 record read return values.
1030 2011-04-15 Ben Key <bkey76@gmail.com>
1032 * keyboard.c (Qundefined): Don't declare static since it is used
1034 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1035 static since they are used in nsfont.m.
1037 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1039 * process.c (Qprocessp): Don't declare static.
1040 * lisp.h (Qprocessp): Declare again.
1042 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1044 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1046 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1048 Improve C-level modularity by making more things 'static'.
1050 Don't publish debugger-only interfaces to other modules.
1051 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1052 (verify_bytepos, count_markers): Move decls to the only modules
1054 * region-cache.h (pp_cache): Likewise.
1055 * window.h (check_all_windows): Likewise.
1056 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1058 * sysdep.c (croak): Now static, if
1059 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1060 * syssignal.h (croak): Declare only if not static.
1062 * alloc.c (refill_memory_reserve): Now static if
1063 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1064 * lisp.h (refill_memory_reserve): Declare only if not static.
1066 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1067 Define only if USE_LUCID.
1069 * xrdb.c (x_customization_string, x_rm_string): Now static.
1071 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1072 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1074 * xdisp.c (draw_row_with_mouse_face): Now static.
1075 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1077 * window.h (check_all_windows): Mark externally visible.
1079 * window.c (window_deletion_count): Now static.
1081 * undo.c: Make symbols static if they're not exported.
1082 (last_undo_buffer, last_boundary_position, pending_boundary):
1085 * textprop.c (interval_insert_behind_hooks): Now static.
1086 (interval_insert_in_front_hooks): Likewise.
1088 * term.c: Make symbols static if they're not exported.
1089 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1090 (max_frame_lines, tty_set_terminal_modes):
1091 (tty_reset_terminal_modes, tty_turn_off_highlight):
1092 (get_tty_terminal): Now static.
1093 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1094 * termhooks.h (term_mouse_moveto): Do not declare if
1096 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1097 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1099 * sysdep.c: Make symbols static if they're not exported.
1100 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1102 (sigprocmask_set, full_mask): Remove; unused.
1103 (wait_debugging): Mark as visible.
1104 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1105 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1107 * syntax.c (syntax_temp): Define only if !__GNUC__.
1109 * sound.c (current_sound_device, current_sound): Now static.
1111 * search.c (searchbufs, searchbuf_head): Now static.
1113 * scroll.c (scroll_cost): Remove; unused.
1114 * dispextern.h (scroll_cost): Remove decl.
1116 * region-cache.h (pp_cache): Mark as externally visible.
1118 * process.c: Make symbols static if they're not exported.
1119 (process_tick, update_tick, create_process, chan_process):
1120 (Vprocess_alist, proc_buffered_char, datagram_access):
1121 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1122 (deactivate_process): Mark defn as static, as well as decl.
1123 * lisp.h (create_process): Remove decl.
1124 * process.h (chan_process, Vprocess_alist): Remove decls.
1126 * print.c: Make symbols static if they're not exported.
1127 (print_depth, new_backquote_output, being_printed, print_buffer):
1128 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1129 (print_interval, print_number_index, initial_stderr_stream):
1131 * lisp.h (Fprinc): Remove decl.
1132 (debug_output_compilation_hack): Mark as externally visible.
1134 * sysdep.c (croak): Move decl from here to syssignal.h.
1135 * syssignal.h (croak): Put it here, so the API can be checked when
1136 'croak' is called from dissociate_if_controlling_tty.
1138 * minibuf.c: Make symbols static if they're not exported.
1139 (minibuf_save_list, choose_minibuf_frame): Now static.
1140 * lisp.h (choose_minibuf_frame): Remove decl.
1142 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1144 * lread.c: Make symbols static if they're not exported.
1145 (read_objects, initial_obarray, oblookup_last_bucket_number):
1147 (make_symbol): Remove; unused.
1148 * lisp.h (initial_obarray, make_symbol): Remove decls.
1150 * keyboard.c: Make symbols static if they're not exported.
1151 (single_kboard, recent_keys_index, total_keys, recent_keys):
1152 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1153 (this_single_command_key_start, echoing, last_auto_save):
1154 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1155 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1156 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1157 (Vlispy_mouse_stem, double_click_count):
1159 (force_auto_save_soon): Define only if SIGDANGER.
1160 (ignore_mouse_drag_p): Now static if
1161 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1162 (print_help): Remove; unused.
1163 (stop_character, last_timer_event): Mark as externally visible.
1164 * keyboard.h (ignore_mouse_drag_p): Declare only if
1165 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1166 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1167 * lisp.h (echoing): Remove decl.
1168 (force_auto_save_soon): Declare only if SIGDANGER.
1169 * xdisp.c (redisplay_window): Simplify code, to make it more
1170 obvious that ignore_mouse_drag_p is not accessed if !defined
1171 USE_GTK && !defined HAVE_NS.
1173 * intervals.c: Make symbols static if they're not exported.
1174 (merge_properties_sticky, merge_interval_right, delete_interval):
1176 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1178 * insdel.c: Make symbols static if they're not exported.
1179 However, leave prepare_to_modify_buffer alone. It's never
1180 called from outside this function, but that appears to be a bug.
1181 (combine_after_change_list, combine_after_change_buffer):
1182 (adjust_after_replace, signal_before_change): Now static.
1183 (adjust_after_replace_noundo): Remove; unused.
1184 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1185 (signal_before_change): Remove decls.
1187 * indent.c (val_compute_motion, val_vmotion): Now static.
1189 * image.c: Make symbols static if they're not exported.
1190 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1192 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1193 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1195 * fringe.c (standard_bitmaps): Now static.
1196 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1198 * frame.c: Make symbols static if they're not exported.
1199 (x_report_frame_params, make_terminal_frame): Now static.
1200 (get_frame_param): Now static, unless HAVE_NS.
1201 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1202 (x_get_resource_string): Remove; not used.
1203 * frame.h (make_terminal_frame, x_report_frame_params):
1204 (x_get_resource_string); Remove decls.
1205 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1206 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1208 * font.c, fontset.c: Make symbols static if they're not exported.
1209 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1210 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1211 * font.c (font_close_object): Now static.
1212 * font.h (font_close_object): Remove.
1213 * fontset.c (FONTSET_OBJLIST): Remove.
1214 (free_realized_fontset) #if-0 the body, which does nothing.
1215 (face_suitable_for_char_p): #if-0, as it's never called.
1216 * fontset.h (face_suitable_for_char_p): Remove decl.
1217 * xfaces.c (face_at_string_position): Use
1218 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1219 since 0 is always ASCII.
1221 * fns.c (weak_hash_tables): Now static.
1223 * fileio.c: Make symbols static if they're not exported.
1224 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1225 (Vwrite_region_annotation_buffers): Now static.
1227 * eval.c: Make symbols static if they're not exported.
1228 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1229 * lisp.h (backtrace_list): Remove decl.
1231 * emacs.c: Make symbols static if they're not exported.
1232 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1233 (fatal_error_code, fatal_error_signal_hook, standard_args):
1235 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1236 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1237 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1238 * lisp.h (fatal_error_signal_hook): Remove decl.
1239 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1241 * editfns.c: Move a (normally-unused) function to its only use.
1242 * editfns.c, lisp.h (get_operating_system_release): Remove.
1243 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1244 worth the hassle of breaking this out.
1246 * xterm.c: Make symbols static if they're not exported.
1247 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1248 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1249 (x_destroy_window, x_delete_display):
1251 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1252 (x_mouse_leave): Remove; unused.
1253 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1254 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1255 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1257 (x_mouse_leave): Declare only if WINDOWSNT.
1258 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1259 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1262 * ftxfont.c: Make symbols static if they're not exported.
1263 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1265 * font.h (ftxfont_driver): Likewise.
1267 * xfns.c: Make symbols static if they're not exported.
1268 (x_last_font_name, x_display_info_for_name):
1269 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1270 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1271 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1272 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1273 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1274 (last_show_tip_args): Now static.
1275 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1276 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1277 (x_screen_planes): Remove; unused.
1278 * dispextern.h (x_screen_planes): Remove decl.
1280 * dispnew.c: Make symbols static if they're not exported.
1281 * dispextern.h (redraw_garbaged_frames, scrolling):
1282 (increment_row_positions): Remove.
1283 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1284 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1286 (redraw_garbaged_frames): Remove; unused.
1288 * xfaces.c: Make symbols static if they're not exported.
1289 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1291 * xterm.h (defined_color): Remove decls.
1292 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1293 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1294 (menu_face_changed_default, defined_color, free_realized_face):
1295 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1296 (ascii_face_of_lisp_face): Remove; unused.
1298 * xdisp.c: Make symbols static if they're not exported.
1299 * dispextern.h (scratch_glyph_row, window_box_edges):
1300 (glyph_to_pixel_coords, set_cursor_from_row):
1301 (get_next_display_element, set_iterator_to_next):
1302 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1303 (show_mouse_face): Remove decls
1304 * frame.h (message_buf_print): Likewise.
1305 * lisp.h (pop_message, set_message, check_point_in_composition):
1307 * xterm.h (set_vertical_scroll_bar): Likewise.
1308 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1309 (message_buf_print, scratch_glyph_row, displayed_buffer):
1310 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1311 (get_next_display_element, show_mouse_face, window_box_edges):
1312 (frame_to_window_pixel_xy, check_point_in_composition):
1313 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1314 (glyph_to_pixel_coords): Remove; unused.
1316 * dired.c (file_name_completion): Now static.
1318 * dbusbind.c (xd_in_read_queued_messages): Now static.
1320 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1321 * data.c (circular_list_error): Remove.
1323 * commands.h (last_point_position, last_point_position_buffer):
1324 (last_point_position_window): Remove decls.
1325 * keyboard.c: Make these variables static.
1327 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1329 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1330 (iso_code_class, detect_coding, code_convert_region): Now static.
1331 (encode_coding_gap): Remove; unused.
1333 * chartab.c (chartab_chars, chartab_bits): Now static.
1335 * charset.h (charset_iso_8859_1): Remove decl.
1336 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1339 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1340 * ccl.c (Vccl_program_table): Now static.
1341 (check_ccl_update): Remove; unused.
1343 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1344 * category.h: ... from here.
1345 * category.c (check_category_table, set_category_set): Now static.
1347 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1348 * lisp.h: Remove these decls.
1350 * buffer.c (buffer_count): Remove unused var.
1352 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1353 so that it's not optimized away.
1354 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1355 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1356 exported only to the debugger.
1358 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1359 * atimer.h (run_all_atimers): Removed; not exported.
1361 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1362 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1363 was inaccessible from Lisp.
1364 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1365 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1367 alloc.c: Import and export fewer symbols, and remove unused items.
1368 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1370 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1371 it's not optimized away by whole-program optimization.
1372 (message_enable_multibyte, free_misc): Remove.
1373 (catchlist, handlerlist, mark_backtrace):
1374 Declare only if BYTE_MARK_STACK.
1375 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1376 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1377 (message_enable_multibyte): Remove decl.
1378 (free_misc, interval_free_list, float_block, float_block_index):
1379 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1380 (cons_free_list, last_marked_index):
1382 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1383 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1384 (mark_backtrace): Define only if BYTE_MARK_STACK.
1385 * xdisp.c (message_enable_multibyte): Now static.
1387 Declare Lisp_Object Q* variables to be 'static' if not exported.
1388 This makes it easier for human readers (and static analyzers)
1389 to see whether these variables are used from other modules.
1390 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1391 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1392 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1393 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1394 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1395 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1396 * xmenu.c, xselect.c:
1397 Declare Q* vars static if they are not used in other modules.
1398 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1399 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1400 Remove decls of unexported vars.
1401 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1403 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1405 Make Emacs functions such as Fatom 'static' by default.
1406 This makes it easier for human readers (and static analyzers)
1407 to see whether these functions can be called from other modules.
1408 DEFUN now defines a static function. To make the function external
1409 so that it can be used in other C modules, use the new macro DEFUE.
1410 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1411 (Finit_image_library):
1412 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1413 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1414 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1415 Remove decls, since these functions are now static.
1416 (Funintern, Fget_internal_run_time): New decls, since these functions
1417 were already external.
1419 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1420 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1421 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1422 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1423 * keyboard.c, keymap.c, lread.c:
1424 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1425 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1426 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1427 Mark functions with DEFUE instead of DEFUN,
1428 if they are used in other modules.
1429 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1430 decls for now-static functions.
1431 * buffer.h (Fdelete_overlay): Remove decl.
1432 * callproc.c (Fgetenv_internal): Mark as internal.
1433 * composite.c (Fremove_list_of_text_properties): Remove decl.
1434 (Fcomposition_get_gstring): New forward static decl.
1435 * composite.h (Fcomposite_get_gstring): Remove decl.
1436 * dired.c (Ffile_attributes): New forward static decl.
1437 * doc.c (Fdocumntation_property): New forward static decl.
1438 * eval.c (Ffetch_bytecode): New forward static decl.
1439 (Funintern): Remove extern decl; now in .h file where it belongs.
1440 * fileio.c (Fmake_symbolic_link): New forward static decl.
1441 * image.c (Finit_image_library): New forward static decl.
1442 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1443 * intervals.h (Fprevious_property_change):
1444 (Fremove_list_of_text_properties): Remove decls.
1445 * keyboard.c (Fthis_command_keys): Remove decl.
1446 (Fcommand_execute): New forward static decl.
1447 * keymap.c (Flookup_key): New forward static decl.
1448 (Fcopy_keymap): Now static.
1449 * keymap.h (Flookup_key): Remove decl.
1450 * process.c (Fget_process): New forward static decl.
1451 (Fprocess_datagram_address): Mark as internal.
1452 * syntax.c (Fsyntax_table_p): New forward static decl.
1453 (skip_chars): Remove duplicate decl.
1454 * textprop.c (Fprevious_property_change): New forward static decl.
1455 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1457 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1458 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1460 * editfns.c (Fformat): Remove unreachable code.
1462 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1464 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1467 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1469 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1470 when at ZV. (Bug#8487)
1472 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1474 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1476 * keyboard.c (parse_tool_bar_item): Likewise.
1477 * sound.c (sound_cleanup, alsa_close): Likewise.
1478 * termcap.c (tgetent): Likewise.
1479 * xfns.c (x_default_font_parameter): Likewise.
1480 * xsettings.c (read_and_apply_settings): Likewise.
1482 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1483 (overrun_check_free): Protoize.
1485 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1487 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1488 since callers should never pass a negative size.
1489 Change the signature to match that of plain 'read' and 'write'; see
1490 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1491 * lisp.h: Update prototypes of emacs_write and emacs_read.
1493 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1495 * xdisp.c (redisplay_window): Don't try to determine the character
1496 position of the scroll margin if the window start point w->startp
1497 is outside the buffer's accessible region. (Bug#8468)
1499 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1501 Fix write-region and its subroutines for buffers > 2GB.
1502 * fileio.c (a_write, e_write): Modify declaration of arguments and
1503 local variables to support buffers larger than 2GB.
1504 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1506 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1507 argument, local variables, and return value.
1509 * lisp.h: Update prototypes of emacs_write and emacs_read.
1511 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1513 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1515 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1517 Fix more problems found by GCC 4.6.0's static checks.
1519 * xdisp.c (vmessage): Use a better test for character truncation.
1521 * charset.c (load_charset_map): <, not <=, for optimization,
1522 and to avoid potential problems with integer overflow.
1523 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1524 * casetab.c (set_identity, shuffle): Likewise.
1525 * editfns.c (Fformat): Likewise.
1526 * syntax.c (skip_chars): Likewise.
1528 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1529 This also lets GCC 4.6.0 generate slightly better loop code.
1531 * callint.c (Fcall_interactively): <, not <=, for optimization.
1532 (Fcall_interactively): Count the number of arguments produced,
1533 not the number of arguments given. This is simpler and lets GCC
1534 4.6.0 generate slightly better code.
1536 * ftfont.c: Distingish more carefully between FcChar8 and char.
1537 The previous code passed unsigned char * to a functions like
1538 strlen and xstrcasecmp that expect char *, which does not
1539 conform to the C standard.
1540 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1541 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1542 char * when the C standard requires it.
1544 * keyboard.c (read_char): Remove unused var.
1546 * eval.c: Port to Windows vsnprintf (Bug#8435).
1548 (SIZE_MAX): Define if the headers do not.
1549 (verror): Do not give up if vsnprintf returns a negative count.
1550 Instead, grow the buffer. This ports to Windows vsnprintf, which
1551 does not conform to C99. Problem reported by Eli Zaretskii.
1552 Also, simplify the allocation scheme, by avoiding the need for
1553 calling realloc, and removing the ALLOCATED variable.
1555 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1557 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1558 But keep the doprint source code for now, as we might revamp it
1559 and use it again (Bug#8435).
1560 * lisp.h (doprnt): Remove.
1561 * Makefile.in (base_obj): Remove doprnt.o.
1562 * deps.mk (doprnt.o): Remove.
1564 error: Print 32- and 64-bit integers portably (Bug#8435).
1565 Without this change, on typical 64-bit hosts error ("...%d...", N)
1566 was used to print both 32- and 64-bit integers N, which relied on
1568 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1570 * lisp.h (error, verror): Mark as printf-like functions.
1571 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1572 Report overflow in size calculations when allocating printf buffer.
1573 Do not truncate output string at its first null byte.
1574 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1575 Truncate the output at a character boundary, since vsnprintf does not
1577 * charset.c (check_iso_charset_parameter): Convert internal
1578 character to string before calling 'error', since %c now has the
1580 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1581 overflow when computing char to be passed to 'error'. Do not
1582 pass Lisp_Object to 'error'; pass the integer instead.
1583 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1584 formatted with plain %d.
1586 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1588 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1590 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1592 * xterm.c (x_catch_errors): Remove duplicate declaration.
1594 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1596 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1598 2011-04-10 Jim Meyering <meyering@redhat.com>
1600 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1601 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1602 return ssize_t not "int", and use size_t as the buffer length.
1603 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1604 * gnutls.h: Update declarations.
1605 * process.c (read_process_output): Use ssize_t, to match.
1606 (send_process): Likewise.
1608 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1610 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1612 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1614 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1615 unsigned char, to match FcChar8 type definition.
1617 * xterm.c (handle_one_xevent):
1618 * xmenu.c (create_and_show_popup_menu):
1619 * xselect.c (x_decline_selection_request)
1620 (x_reply_selection_request): Avoid type-punned deref of X events.
1622 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1624 Fix some uses of `int' instead of EMACS_INT.
1625 * search.c (string_match_1, fast_string_match)
1626 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1627 (scan_buffer, find_next_newline_no_quit)
1628 (find_before_next_newline, search_command, Freplace_match)
1629 (Fmatch_data): Make some `int' variables be EMACS_INT.
1631 * xdisp.c (display_count_lines): 3rd argument and return value now
1632 EMACS_INT. All callers changed.
1633 (pint2hrstr): Last argument is now EMACS_INT.
1635 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1636 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1637 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1638 (decode_coding_utf_16, decode_coding_emacs_mule)
1639 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1640 (decode_coding_ccl, decode_coding_charset)
1641 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1642 (decode_coding_iso_2022, decode_coding_emacs_mule)
1643 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1644 <char_offset, last_offset>: Declare EMACS_INT.
1645 (encode_coding_utf_8, encode_coding_utf_16)
1646 (encode_coding_emacs_mule, encode_invocation_designation)
1647 (encode_designation_at_bol, encode_coding_iso_2022)
1648 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1649 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1651 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1652 (encode_invocation_designation): Last argument P_NCHARS is now
1654 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1655 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1657 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1660 * ccl.c (Fccl_execute_on_string): Declare some variables
1663 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1665 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1667 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1669 * process.c (Fformat_network_address): Doc fix.
1671 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1673 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1675 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1677 * keyboard.c (read_char): Call Lisp function help-form-show,
1678 instead of using internal_with_output_to_temp_buffer.
1679 (Qhelp_form_show): New var.
1680 (syms_of_keyboard): Use DEFSYM macro.
1682 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1684 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1686 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1688 * process.c (Flist_processes): Removed to Lisp.
1689 (list_processes_1): Deleted.
1691 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1693 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1695 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1697 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1699 Fix more problems found by GCC 4.6.0's static checks.
1701 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1703 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1705 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1707 * xdisp.c (vmessage): Mark as a printf-like function.
1709 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1711 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1713 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1714 printf-like functions.
1715 (tiff_load): Add casts to remove these marks before passing them
1716 to system-supplied API.
1718 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1720 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1721 This avoids several warnings with gcc -Wstrict-overflow.
1722 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1723 directly, rather than having caller test rule sign. This avoids
1724 some unnecessary tests.
1725 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1726 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1727 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1729 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1730 (xfont_open): Avoid unnecessary tests.
1732 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1734 * composite.h, composite.c (composition_gstring_put_cache):
1735 Use EMACS_INT, not int, for length.
1737 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1738 breaking out part of COMPOSITION_DECODE_RULE.
1739 (COMPOSITION_DECODE_RULE): Use it.
1740 * composite.c (get_composition_id): Remove unused local vars,
1741 by using the new macro.
1743 * textprop.c (set_text_properties_1): Change while to do-while,
1744 since the condition is always true at first.
1746 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1747 (interval_deletion_adjustment): Return unsigned value.
1750 * process.c (list_processes_1, create_pty, read_process_output):
1751 (exec_sentinel): Remove vars that were set but not used.
1752 (create_pty): Remove unnecessary "volatile"s.
1753 (Fnetwork_interface_info): Avoid possibility of int overflow.
1754 (read_process_output): Do adaptive read buffering even if carryover.
1755 (read_process_output): Simplify nbytes computation if buffered.
1757 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1759 * syntax.c (scan_words): Remove var that was set but not used.
1760 (update_syntax_table): Use unsigned instead of int.
1762 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1763 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1764 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1766 * print.c (print_error_message): Avoid int overflow.
1768 * font.c (font_list_entities): Redo for clarity,
1769 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1771 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1772 (font_score): Avoid potential overflow in diff calculation.
1774 * fns.c (substring_both): Remove var that is set but not used.
1775 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1777 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1779 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1780 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1781 can always succeed if overflow has undefined behavior.
1783 * search.c (boyer_moore, wordify): Remove vars set but not used.
1784 (wordify): Omit three unnecessary tests.
1786 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1787 All callers changed. This avoids the need for an unused var.
1789 * casefiddle.c (casify_region): Remove var that is set but not used.
1791 * dired.c (file_name_completion): Remove var that is set but not used.
1793 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1795 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1796 (Finsert_file_contents): Remove unnecessary code checking fd.
1798 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1799 Check for integer overflow on size calculations.
1801 * buffer.c (Fprevious_overlay_change): Remove var that is set
1804 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1805 Remove vars that are set but not used.
1806 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1807 (timer_check_2): Mark vars as initialized.
1809 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1811 * image.c (lookup_image): Remove var that is set but not used.
1812 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1814 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1815 that are set but not used.
1817 * xfns.c (make_invisible_cursor): Don't return garbage
1818 if XCreateBitmapFromData fails (Bug#8410).
1820 * xselect.c (x_get_local_selection, x_handle_property_notify):
1821 Remove vars that are set but not used.
1823 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1824 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1826 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1827 Remove var that is set but not used.
1828 (scroll_bar_windows_size): Now size_t, not int.
1829 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1832 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1833 (map_tty_color) [!defined MSDOS]: Likewise.
1835 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1837 * coding.c: Remove vars that are set but not used.
1838 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1839 All callers changed.
1840 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1841 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1842 (decode_coding_charset): Remove vars that are set but not used.
1844 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1845 that is set but not used.
1847 * print.c (print_object): Remove var that is set but not used.
1849 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1850 The gnulib version avoids calling malloc in the usual case,
1851 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1852 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1853 * filelock.c (current_lock_owner): Likewise.
1854 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1855 * sysdep.c: Include allocator.h, careadlinkat.h.
1856 (emacs_no_realloc_allocator): New static constant.
1857 (emacs_readlink): New function.
1858 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1859 ../lib/careadlinkat.h.
1861 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1863 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1864 first non-nil return value).
1866 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1868 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1869 if not defined (Bug#8403).
1871 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1873 * xdisp.c (display_count_lines): Remove parameter `start',
1874 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1875 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1876 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1877 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1878 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1879 and thereabouts. All callers changed.
1880 (get_per_char_metric): Remove parameter `f', unused since
1881 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1883 2011-04-02 Jim Meyering <meyering@redhat.com>
1885 do not dereference NULL upon failed strdup
1886 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1887 (ns_get_family): Likewise.
1889 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1891 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1893 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1895 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1898 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1900 Add lexical binding.
1902 * window.c (Ftemp_output_buffer_show): New fun.
1903 (Fsave_window_excursion):
1904 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1906 * lread.c (lisp_file_lexically_bound_p): New function.
1907 (Fload): Bind Qlexical_binding.
1908 (readevalloop): Remove `evalfun' arg.
1909 Bind Qinternal_interpreter_environment.
1910 (Feval_buffer): Bind Qlexical_binding.
1911 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1913 (syms_of_lread): Declare `lexical-binding'.
1915 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1917 * keyboard.c (eval_dyn): New fun.
1918 (menu_item_eval_property): Use it.
1920 * image.c (parse_image_spec): Use Ffunctionp.
1922 * fns.c (concat, mapcar1): Accept byte-code-functions.
1924 * eval.c (Fsetq): Handle lexical vars.
1925 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1926 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1927 (FletX, Flet): Obey lexical binding.
1928 (Fcommandp): Handle closures.
1929 (Feval): New `lexical' arg.
1930 (eval_sub): New function extracted from Feval. Use it almost
1931 everywhere where Feval was used. Look up vars in lexical env.
1933 (Ffunctionp): Move from subr.el.
1934 (Ffuncall): Handle closures.
1935 (apply_lambda): Remove `eval_flags'.
1936 (funcall_lambda): Handle closures and new byte-code-functions.
1937 (Fspecial_variable_p): New function.
1938 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1939 but without exporting it to Lisp.
1941 * doc.c (Fdocumentation, store_function_docstring):
1942 * data.c (Finteractive_form): Handle closures.
1944 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1947 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1949 (exec_byte_code): New function extracted from Fbyte_code to handle new
1950 calling convention for byte-code-functions. Add new byte-codes.
1952 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1954 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1956 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1958 * xdisp.c (redisplay_internal): Fix prototype.
1960 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1962 * xdisp.c (SCROLL_LIMIT): New macro.
1963 (try_scrolling): Use it when setting scroll_limit. Limit
1964 scrolling to 100 screen lines.
1965 (redisplay_window): Even when falling back on "recentering",
1966 position point in the window according to scroll-conservatively,
1967 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1969 (try_scrolling): When point is above the window, allow searching
1970 as far as scroll_max, or one screenful, to compute vertical
1971 distance from PT to the scroll margin position. This prevents
1972 try_scrolling from unnecessarily failing when
1973 scroll-conservatively is set to a value slightly larger than the
1974 window height. Clean up the case of PT below the margin at bottom
1975 of window: scroll_max can no longer be INT_MAX. When aggressive
1976 scrolling is in use, don't let point enter the opposite scroll
1977 margin as result of the scroll.
1978 (syms_of_xdisp) <scroll-conservatively>: Document the
1979 threshold of 100 lines for never-recentering scrolling.
1981 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1983 * dispextern.h (move_it_by_lines):
1984 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1985 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1986 (message_log_check_duplicate): Remove parameters `prev_bol' and
1987 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1988 (redisplay_internal): Remove parameter `preserve_echo_area',
1989 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1991 * indent.c (Fvertical_motion):
1992 * window.c (window_scroll_pixel_based, Frecenter):
1993 Don't pass `need_y_p' to `move_it_by_lines'.
1995 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1997 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1998 steal a few bits to be more compact.
1999 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2000 Remove unneeded casts.
2002 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2004 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2006 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2007 binding" message (bug#7967).
2009 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2011 Fix more problems found by GCC 4.6.0's static checks.
2013 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2014 Remove unused local var.
2016 * editfns.c (Fmessage_box): Remove unused local var.
2018 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2019 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2020 Omit unused local vars.
2021 * window.c (shrink_windows): Omit unused local var.
2022 * menu.c (digest_single_submenu): Omit unused local var.
2023 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2024 Omit unused local var.
2026 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2027 Don't assume string length fits in int.
2028 (keyremap_step, read_key_sequence): Use size_t for sizes.
2029 (read_key_sequence): Don't check last_real_key_start redundantly.
2031 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2032 instead of alloca (Bug#8344).
2034 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2035 (Fbacktrace_frame): Don't assume nframes fits in int.
2037 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2039 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2042 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2044 * cm.c (calccost): Turn while-do into do-while, for clarity.
2046 * keyboard.c (syms_of_keyboard): Use the same style as later
2047 in this function when indexing through an array. This also
2048 works around GCC bug 48267.
2050 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2052 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2054 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2055 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2057 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2058 This avoids undefined behavior on integer overflow, and is a bit
2059 more convenient anyway since it is compared to a size_t variable.
2061 Variadic C functions now count arguments with size_t, not int.
2062 This avoids an unnecessary limitation on 64-bit machines, which
2063 caused (substring ...) to crash on large vectors (Bug#8344).
2064 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2065 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2066 All variadic functions and their callers changed accordingly.
2067 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2068 * data.c (arith_driver, float_arith_driver): Likewise.
2069 * editfns.c (general_insert_function): Likewise.
2070 * eval.c (struct backtrace.nargs, interactive_p)
2071 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2072 (funcall_lambda, mark_backtrace): Likewise.
2073 * fns.c (concat): Likewise.
2074 * frame.c (x_set_frame_parameters): Likewise.
2075 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2076 0 if not found, not -1. All callers changed.
2078 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2079 (stack_copy_size): Now size_t, not int.
2080 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2082 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2084 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2085 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2086 All callers changed.
2088 * lisp.h (multibyte_char_to_unibyte):
2089 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2090 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2091 * character.h (CHAR_TO_BYTE8):
2092 * cmds.c (internal_self_insert):
2093 * editfns.c (general_insert_function):
2094 * keymap.c (push_key_description):
2095 * search.c (Freplace_match):
2096 * xdisp.c (message_dolog, set_message_1): All callers changed.
2098 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2100 * keyboard.c (safe_run_hook_funcall): New function.
2101 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2102 don't set the hook to nil, but remove the offending function instead.
2103 (Qcommand_hook_internal): Remove, unused.
2104 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2105 Vcommand_hook_internal.
2107 * eval.c (enum run_hooks_condition): Remove.
2108 (funcall_nil, funcall_not): New functions.
2109 (run_hook_with_args): Call each function through a `funcall' argument.
2110 Remove `cond' argument, now redundant.
2111 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2112 (Frun_hook_with_args_until_failure): Adjust accordingly.
2113 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2115 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2117 * dispextern.h (string_buffer_position): Remove declaration.
2119 * print.c (strout): Remove parameter `multibyte', unused since
2120 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2122 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2123 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2124 All callers changed.
2126 * w32.c (_wsa_errlist): Use braces for struct initializers.
2128 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2129 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2130 All callers changed.
2131 (string_buffer_position): Likewise. Also, make static (it's never
2132 used outside xdisp.c).
2133 (cursor_row_p): Remove parameter `w', unused since
2134 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2135 (decode_mode_spec): Remove parameter `precision', introduced during
2136 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2137 All callers changed.
2139 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2141 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2143 2011-03-27 Anders Lindgren <andlind@gmail.com>
2145 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2146 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2147 (ns_update_auto_hide_menu_bar): New functions.
2148 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2149 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2150 ns_constrain_all_frames.
2151 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2152 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2154 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2156 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2158 2011-03-27 Glenn Morris <rgm@gnu.org>
2160 * syssignal.h: Replace RETSIGTYPE with void.
2161 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2162 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2163 Replace SIGTYPE with void everywhere.
2164 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2165 * s/template.h (SIGTYPE): Remove commented out definition.
2167 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2169 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2170 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2172 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2174 * w32.c (read_unc_volume): Use parameter `henum', instead of
2175 global variable `wget_enum_handle'.
2177 * keymap.c (describe_vector): Remove parameters `indices' and
2178 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2179 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2181 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2183 * keyboard.c (timer_check): Remove parameter `do_it_now',
2184 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2185 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2186 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2188 * keyboard.c (read_char):
2189 * w32menu.c (w32_menu_display_help):
2190 * xmenu.c (show_help_event, menu_help_callback):
2191 Adjust calls to `show_help_echo'.
2193 * gtkutil.c (xg_maybe_add_timer):
2194 * keyboard.c (readable_events):
2195 * process.c (wait_reading_process_output):
2196 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2198 * insdel.c (adjust_markers_gap_motion):
2199 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2200 (gap_left, gap_right): Don't call it.
2202 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2204 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2205 incurred during fontification.
2207 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2209 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2210 (DEFVAR_PER_BUFFER): Don't pass it.
2212 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2213 (scrolling_window): Don't pass it.
2215 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2217 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2219 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2221 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2222 of variables specific to SELinux and computation of `encoded_absname'.
2224 * image.c (XPutPixel): Remove unused variable `height'.
2226 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2228 * unexw32.c (get_section_info): Remove unused variable `section'.
2230 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2231 (system_process_attributes): Remove unused variable `sess'.
2232 (sys_read): Remove unused variable `err'.
2234 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2235 (w32_wnd_proc): Remove unused variable `isdead'.
2236 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2237 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2238 (x_create_tip_frame): Remove unused variable `tem'.
2240 * w32inevt.c (w32_console_read_socket):
2241 Remove unused variable `no_events'.
2243 * w32term.c (x_draw_composite_glyph_string_foreground):
2244 Remove unused variable `width'.
2246 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2248 * w32term.c (x_set_glyph_string_clipping):
2249 Don't pass uninitialized region to CombineRgn.
2251 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2253 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2254 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2255 (Fx_close_connection): Remove unused variable `i'.
2257 * w32font.c (w32font_draw): Return number of glyphs.
2258 (w32font_open_internal): Remove unused variable `i'.
2259 (w32font_driver): Add missing initializer.
2261 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2262 (fill_in_menu): Remove unused variable `items_added'.
2264 * w32term.c (last_mouse_press_frame): Remove static global variable.
2265 (w32_clip_to_row): Remove unused variable `f'.
2266 (x_delete_terminal): Remove unused variable `i'.
2268 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2269 (NOTHING): Remove unused static global variable.
2270 (uniscribe_check_otf): Remove unused variable `table'.
2271 (uniscribe_font_driver): Add missing initializers.
2273 2011-03-23 Julien Danjou <julien@danjou.info>
2275 * term.c (Fsuspend_tty, Fresume_tty):
2276 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2277 * window.c (temp_output_buffer_show):
2278 * insdel.c (signal_before_change):
2279 * frame.c (Fhandle_switch_frame):
2280 * fileio.c (Fdo_auto_save):
2281 * emacs.c (Fkill_emacs):
2282 * editfns.c (save_excursion_restore):
2283 * cmds.c (internal_self_insert):
2284 * callint.c (Fcall_interactively):
2285 * buffer.c (Fkill_all_local_variables):
2286 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2288 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2289 unconditionnaly since it does the check itself.
2291 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2293 Fix more problems found by GCC 4.5.2's static checks.
2295 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2296 the first time through the loop, since we know p0 < p1 then.
2297 This also avoids a gcc -Wstrict-overflow warning.
2299 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2300 leading to a memory leak, possible in functions like
2301 load_charset_map_from_file that can allocate an unbounded number
2302 of objects (Bug#8318).
2304 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2305 that could (at least in theory) be that large.
2307 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2308 This is less likely to overflow, and avoids undefined behavior if
2309 overflow does occur. All callers changed. Use strtoul to scan
2310 for the unsigned long integer.
2311 (pint2hrstr): Simplify and tune code slightly.
2312 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2314 * scroll.c (do_scrolling): Work around GCC bug 48228.
2315 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2317 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2318 This also avoids a warning with gcc -Wstrict-overflow.
2319 (validate_x_resource_name): Simplify count usage.
2320 This also avoids a warning with gcc -Wstrict-overflow.
2322 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2325 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2327 * process.c (Fmake_network_process): Use socklen_t, not int,
2328 where POSIX says socklen_t is required in portable programs.
2329 This fixes a porting bug on hosts like 64-bit HP-UX, where
2330 socklen_t is wider than int (Bug#8277).
2331 (Fmake_network_process, server_accept_connection):
2332 (wait_reading_process_output, read_process_output):
2335 * process.c: Rename or move locals to avoid shadowing.
2336 (list_processes_1, Fmake_network_process):
2337 (read_process_output_error_handler, exec_sentinel_error_handler):
2338 Rename or move locals.
2339 (Fmake_network_process): Define label "retry_connect" only if needed.
2340 (Fnetwork_interface_info): Fix pointer signedness.
2341 (process_send_signal): Add cast to avoid pointer signedness problem.
2342 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2343 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2345 Make tparam.h and terminfo.c consistent.
2346 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2347 Include tparam.h instead, since it declares them.
2348 * cm.h (PC): Remove extern decl; tparam.h now does this.
2349 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2350 * terminfo.c: Include tparam.h, to check interfaces.
2351 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2352 (tparam): Adjust signature to match interface in tparam.h;
2353 this removes some undefined behavior. Check that outstring and len
2354 are zero, which they always are with Emacs.
2355 * tparam.h (PC, BC, UP): New extern decls.
2357 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2358 (xftfont_open): Rename locals to avoid shadowing.
2360 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2361 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2362 (OTF_TAG_SYM): Omit macro if not needed.
2363 (ftfont_list): Remove unused local.
2364 (get_adstyle_property, ftfont_pattern_entity):
2365 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2366 Rename locals to avoid shadowing.
2368 * xfont.c (xfont_list_family): Mark var as initialized.
2370 * xml.c (make_dom): Now static.
2372 * composite.c (composition_compute_stop_pos): Rename local to
2374 (composition_reseat_it): Remove unused locals.
2375 (find_automatic_composition, composition_adjust_point): Likewise.
2376 (composition_update_it): Mark var as initialized.
2377 (find_automatic_composition): Mark vars as initialized,
2378 with a FIXME (Bug#8290).
2380 character.h: Rename locals to avoid shadowing.
2381 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2382 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2383 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2384 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2387 * textprop.c (property_change_between_p): Remove; unused.
2389 * intervals.c (interval_start_pos): Now static.
2391 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2393 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2394 Rename locals to avoid shadowing.
2396 * sound.c (wav_play, au_play, Fplay_sound_internal):
2397 Fix pointer signedness.
2398 (alsa_choose_format): Remove unused local var.
2399 (wav_play): Initialize a variable to 0, to prevent undefined
2400 behavior (Bug#8278).
2402 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2404 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2406 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2407 clobbering (Bug#8298).
2408 * sysdep.c (sys_subshell): Likewise.
2409 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2411 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2412 This should get cleaned up, so that child_setup has the
2413 same signature on all platforms.
2415 * callproc.c (call_process_cleanup): Now static.
2416 (relocate_fd): Rename locals to avoid shadowing.
2418 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2420 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2421 not to be necessary, and produces flickering.
2423 2011-03-20 Glenn Morris <rgm@gnu.org>
2425 * config.in: Remove file.
2427 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2429 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2430 are now in src/globals.h.
2431 (syms_of_minibuf): Remove spurious & from previous change.
2433 2011-03-20 Leo <sdl.web@gmail.com>
2435 * minibuf.c (completing-read-function): New variable.
2436 (completing-read-default): Rename from completing-read.
2437 (completing-read): Call completing-read-function.
2439 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2441 * xfaces.c (Fx_load_color_file):
2442 Read color file from absolute filename (bug#8250).
2444 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2446 * makefile.w32-in: Update dependencies.
2448 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2450 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2452 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2454 Fix more problems found by GCC 4.5.2's static checks.
2456 * process.c (make_serial_process_unwind, send_process_trap):
2457 (sigchld_handler): Now static.
2459 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2460 That way, the code declares only the vars that it needs.
2461 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2462 * s/cygwin.h (PTY_ITERATION): Likewise.
2463 * s/darwin.h (PTY_ITERATION): Likewise.
2464 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2466 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2467 * process.c (allocate_pty): Don't declare stb unless it's needed.
2469 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2470 (CONSTANTLIM): Remove; unused.
2471 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2472 Define only if needed.
2474 * unexelf.c (unexec): Name an expression,
2475 to avoid gcc -Wbad-function-cast warning.
2476 Use a different way to cause a compilation error if anyone uses
2477 n rather than nn, a way that does not involve shadowing.
2478 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2480 * deps.mk (unexalpha.o): Remove; unused.
2482 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2483 * unexec.h: New file.
2484 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2485 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2487 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2488 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2489 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2490 Change as necessary to match prototype in unexec.h.
2492 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2494 (back_comment, skip_chars): Mark vars as initialized.
2496 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2497 Rename locals to avoid shadowing.
2499 * lread.c (read1): Rewrite so as not to use empty "else".
2500 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2502 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2504 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2505 warning when compiling print.c.
2507 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2508 instead of using an uninitialized var.
2509 (font_sort_entities): Mark var as initialized.
2511 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2513 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2514 pointers to constants.
2515 (font_parse_fcname): Remove unused vars.
2516 (font_delete_unmatched): Now static.
2517 (font_get_spec): Remove; unused.
2518 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2519 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2520 Rename or move locals to avoid shadowing.
2522 * fns.c (require_nesting_list, require_unwind): Now static.
2523 (Ffillarray): Rename locals to avoid shadowing.
2525 * floatfns.c (domain_error2): Define only if needed.
2526 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2528 * alloc.c (mark_backtrace): Move decl from here ...
2529 * lisp.h: ... to here, so that it can be checked.
2531 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2532 (Fdefvar): Rewrite so as not to use empty "else".
2533 (lisp_indirect_variable): Name an expression,
2534 to avoid gcc -Wbad-function-cast warning.
2535 (Fdefvar): Rename locals to avoid shadowing.
2537 * callint.c (quotify_arg, quotify_args): Now static.
2538 (Fcall_interactively): Rename locals to avoid shadowing.
2539 Use const pointer when appropriate.
2541 * lisp.h (get_system_name, get_operating_system_release):
2542 Move decls here, to check interfaces.
2543 * process.c (get_operating_system_release): Move decl to lisp.h.
2544 * xrdb.c (get_system_name): Likewise.
2545 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2546 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2547 some of which prompt warnings from gcc -Wbad-function-cast.
2548 (Fformat_time_string, Fencode_time, Finsert_char):
2549 (Ftranslate_region_internal, Fformat):
2550 Rename or remove local vars to avoid shadowing.
2551 (Ftranslate_region_internal): Mark var as initialized.
2553 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2556 * lisp.h (eassert): Check that the argument compiles, even if
2557 ENABLE_CHECKING is not defined.
2559 * data.c (Findirect_variable): Name an expression, to avoid
2560 gcc -Wbad-function-cast warning.
2561 (default_value, arithcompare, arith_driver, arith_error): Now static.
2562 (store_symval_forwarding): Rename local to avoid shadowing.
2563 (Fmake_variable_buffer_local, Fmake_local_variable):
2564 Mark variables as initialized.
2565 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2567 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2568 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2569 Rename locals to avoid shadowing.
2570 (mark_stack): Move local variables into the #ifdef region where
2572 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2573 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2575 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2576 (GC_STRING_CHARS): Remove; not used.
2577 (Fmemory_limit): Cast sbrk's returned value to char *.
2579 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2580 avoids undefined behavior in theory.
2582 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2584 Use functions, not macros, for up- and down-casing (Bug#8254).
2585 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2586 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2587 to use the following functions instead of these macros.
2588 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2589 EMACS_INT, since callers assume the returned value fits in int.
2590 (upcase1): Likewise, for UPCASE_TABLE.
2591 (uppercasep, lowercasep, upcase): New static inline functions.
2592 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2593 the race-condition problem in the old DOWNCASE.
2595 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2596 Rename locals to avoid shadowing.
2597 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2598 (regex_compile, re_search_2, re_match_2_internal):
2599 Remove unused local vars.
2600 (FREE_VAR): Rewrite so as not to use empty "else",
2601 which gcc can warn about.
2602 (regex_compile, re_match_2_internal): Mark locals as initialized.
2603 (RETALLOC_IF): Define only if needed.
2604 (WORDCHAR_P): Likewise. This one is never needed, but is used
2605 only in a comment talking about a compiler bug, so put inside
2606 the #if 0 of that comment.
2607 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2608 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2611 * search.c (boyer_moore): Rename locals to avoid shadowing.
2612 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2613 (PREV_CHAR_BOUNDARY): Likewise.
2615 * search.c (simple_search): Remove unused var.
2617 * dired.c (compile_pattern): Move decl from here ...
2618 * lisp.h: ... to here, so that it can be checked.
2619 (struct re_registers): New forward decl.
2621 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2623 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2625 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2626 Rename locals to avoid shadowing.
2627 (Fvertical_motion): Mark locals as initialized.
2629 * casefiddle.c (casify_object, casify_region): Now static.
2630 (casify_region): Mark local as initialized.
2632 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2634 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2635 New macros, so that the caller can use some names other than
2636 gcpro1, gcpro2, etc.
2637 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2639 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2640 argument, for consistency with GCPRO2_VAR, etc: it is now the
2641 prefix of the variable, not the variable itself. All uses
2643 * dired.c (directory_files_internal, file_name_completion):
2644 Rename locals to avoid shadowing.
2646 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2647 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2648 dired.c's scmp function, had undefined behavior.
2649 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2650 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2651 * buffer.h: ... to here, because these macros use current_buffer,
2652 and the new implementation with inline functions needs to have
2653 current_buffer in scope now, rather than later when the macros
2655 (downcase, upcase1): New static inline functions.
2656 (DOWNCASE, UPCASE1): Reimplement using these functions.
2657 This avoids undefined behavior in expressions like
2658 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2659 from race conditions in accessing the global variables
2660 case_temp1 and case_temp2.
2661 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2662 * lisp.h (case_temp1, case_temp2): Remove their decls.
2663 * character.h (ASCII_CHAR_P): Move from here ...
2664 * lisp.h: ... to here, so that the inline functions mentioned
2667 * dired.c (directory_files_internal_unwind): Now static.
2669 * fileio.c (file_name_as_directory, directory_file_name):
2670 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2672 (file_name_as_directory): Use const pointers when appropriate.
2673 (Fexpand_file_name): Likewise. In particular, newdir might
2674 point at constant storage, so make it a const pointer.
2675 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2676 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2678 (Fset_file_times, Finsert_file_contents, auto_save_error):
2679 Rename locals to avoid shadowing.
2681 * minibuf.c (choose_minibuf_frame_1): Now static.
2682 (Ftry_completion, Fall_completions): Rename or remove locals
2685 * marker.c (bytepos_to_charpos): Remove; unused.
2687 * lisp.h (verify_bytepos, count_markers): New decls,
2688 so that gcc does not warn that these functions aren't declared.
2690 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2691 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2692 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2693 (copy_text): Remove unused local var.
2695 * filelock.c (within_one_second): Now static.
2696 (lock_file_1): Rename local to avoid shadowing.
2698 * buffer.c (fix_overlays_before): Mark locals as initialized.
2699 (fix_start_end_in_overlays): Likewise. This function should be
2700 simplified by using pointers-to-pointers, but that's a different
2702 (switch_to_buffer_1): Now static.
2703 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2704 (report_overlay_modification): Rename locals to avoid shadowing.
2706 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2707 Fix pointer signedness issue.
2708 (sys_subshell): Mark local as volatile if checking for lint,
2709 to suppress a gcc -Wclobbered warning that does not seem to be right.
2710 (MAXPATHLEN): Define only if needed.
2712 * process.c (serial_open, serial_configure): Move decls from here ...
2713 * systty.h: ... to here, so that they can be checked.
2715 * fns.c (get_random, seed_random): Move extern decls from here ...
2716 * lisp.h: ... to here, so that they can be checked.
2718 * sysdep.c (reset_io): Now static.
2719 (wait_for_termination_signal): Remove; unused.
2721 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2722 (copy_keymap_item, append_key, push_text_char_description):
2724 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2725 (DENSE_TABLE_SIZE): Remove; unused.
2726 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2727 (describe_map_tree):
2728 Rename locals to avoid shadowing.
2730 * keyboard.c: Declare functions static if they are not used elsewhere.
2731 (echo_char, echo_dash, cmd_error, top_level_2):
2732 (poll_for_input, handle_async_input): Now static.
2733 (read_char, kbd_buffer_get_event, make_lispy_position):
2734 (make_lispy_event, make_lispy_movement, apply_modifiers):
2735 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2736 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2737 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2738 (read_key_sequence, read_char): Mark locals as initialized.
2739 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2741 * keyboard.h (make_ctrl_char): New decl.
2742 (mark_kboards): Move decl here ...
2743 * alloc.c (mark_kboards): ... from here.
2745 * lisp.h (force_auto_save_soon): New decl.
2747 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2748 (DEFINE_DUMMY_FUNCTION): New macro.
2749 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2751 (main): Add casts to avoid warnings
2752 if GCC considers string literals to be constants.
2754 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2756 * dbusbind.c: Pointer signedness fixes.
2757 (xd_signature, xd_append_arg, xd_initialize):
2758 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2759 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2760 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2761 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2763 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2764 if GCC considers string literals to be constants.
2765 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2767 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2769 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2770 (print_preprocess, print_object): New macro to fix last change.
2772 * print.c (print_preprocess): Don't forget font objects.
2774 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2776 * emacs.c (USAGE3): Doc fixes.
2778 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2780 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2783 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2785 * lisp.h (VWindow_system, Qfile_name_history):
2786 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2787 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2788 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2790 * w32select.c: Don't #include "keyboard.h".
2791 (run_protected): Add extern declaration for waiting_for_input.
2793 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2794 * w32console.c (detect_input_pending, read_input_pending)
2795 (encode_terminal_code):
2796 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2797 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2798 (w32_system_caret_y, Qfile_name_history):
2799 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2800 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2801 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2802 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2803 * w32proc.c (Qlocal, report_file_error):
2804 * w32term.c (Vwindow_system, updating_frame):
2805 * w32uniscribe.c (initialized, uniscribe_font_driver):
2806 Remove unneeded extern declarations.
2808 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2810 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2812 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2814 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2815 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2816 These macros can no longer be used for assignment.
2818 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2819 Assign struct members directly, instead of using BUF_BEGV etc.
2820 (record_buffer_markers, fetch_buffer_markers): New functions for
2821 recording and fetching special buffer markers.
2822 (set_buffer_internal_1, set_buffer_temp): Use them.
2824 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2826 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2828 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2829 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2831 * xdisp.c (hscroll_window_tree):
2832 (reconsider_clip_changes): Use PT instead of BUF_PT.
2834 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2836 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2837 $(EMACS_ROOT)/lib/intprops.h.
2839 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2841 Fix more problems found by GCC 4.5.2's static checks.
2843 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2844 to unsigned char * to avoid compiler diagnostic.
2845 (xg_free_frame_widgets): Make it clear that a local variable is
2846 needed only if USE_GTK_TOOLTIP.
2847 (gdk_window_get_screen): Make it clear that this macro is needed
2848 only if USE_GTK_TOOLTIP.
2849 (int_gtk_range_get_value): New function, which avoids a diagnostic
2850 from gcc -Wbad-function-cast.
2851 (xg_set_toolkit_scroll_bar_thumb): Use it.
2852 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2853 diagnostic from gcc -Wbad-function-cast.
2854 (get_utf8_string, xg_get_file_with_chooser):
2855 Rename locals to avoid shadowing.
2856 (create_dialog): Move locals to avoid shadowing.
2858 * xgselect.c (xg_select): Remove unused var.
2860 * image.c (four_corners_best): Mark locals as initialized.
2861 (gif_load): Initialize transparent_p to zero (Bug#8238).
2862 Mark another local as initialized.
2863 (my_png_error, my_error_exit): Mark with NO_RETURN.
2865 * image.c (clear_image_cache): Now static.
2866 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2867 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2868 (x_edge_detection): Remove unnecessary cast that
2869 gcc -Wbad-function-cast diagnoses.
2870 (gif_load): Fix pointer signedness.
2871 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2872 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2874 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2876 Improve quality of tests for time stamp overflow.
2877 For example, without this patch (encode-time 0 0 0 1 1
2878 1152921504606846976) returns the obviously-bogus value (-948597
2879 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2880 reports time overflow. See
2881 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2882 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2883 * editfns.c: Include limits.h and intprops.h.
2884 (TIME_T_MIN, TIME_T_MAX): New macros.
2885 (time_overflow): Move earlier, to before first use.
2886 (hi_time, lo_time): New functions, for an accurate test for
2888 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2889 (Fget_internal_run_time): Don't assume time_t fits in int.
2890 (make_time): Use list2 instead of Fcons twice.
2891 (Fdecode_time): More accurate test for out-of-range times.
2892 (check_tm_member): New function.
2893 (Fencode_time): Use it, to test for out-of-range times.
2894 (lisp_time_argument): Don't rely on undefined left-shift and
2895 right-shift behavior when checking for time stamp overflow.
2897 * editfns.c (time_overflow): New function, refactoring common code.
2898 (Fformat_time_string, Fdecode_time, Fencode_time):
2899 (Fcurrent_time_string): Use it.
2901 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2902 * dired.c (make_time): Move to ...
2903 * editfns.c (make_time): ... here.
2904 * systime.h: Note the move.
2906 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2908 * fringe.c (update_window_fringes): Remove unused variables.
2910 * unexmacosx.c (copy_data_segment): Also copy __got section.
2913 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2915 * termcap.c [MSDOS]: Include "msdos.h".
2916 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2917 Constify `char *' arguments and their references according to
2918 prototypes in tparam.h.
2920 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2922 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2923 Adapt all references accordingly.
2925 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2927 2011-03-11 Tom Tromey <tromey@redhat.com>
2929 * buffer.c (syms_of_buffer): Remove obsolete comment.
2931 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2933 * termhooks.h (encode_terminal_code): Declare prototype.
2935 * msdos.c (encode_terminal_code): Don't declare prototype.
2937 * term.c (encode_terminal_code): Now external again, used by
2938 w32console.c and msdos.c.
2940 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2941 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2943 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2945 Fix some minor problems found by GCC 4.5.2's static checks.
2947 * fringe.c (update_window_fringes): Mark locals as initialized
2949 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2951 * alloc.c (mark_fringe_data): Move decl from here ...
2952 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2953 to check its interface.
2954 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2956 * fontset.c (free_realized_fontset): Now static.
2957 (Fset_fontset_font): Rename local to avoid shadowing.
2958 (fontset_font): Mark local as initialized.
2959 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2961 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2963 * xselect.c (x_disown_buffer_selections): Remove; not used.
2964 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2965 (x_own_selection, Fx_disown_selection_internal): Rename locals
2967 (x_handle_dnd_message): Remove local to avoid shadowing.
2969 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2970 so that the caller can use some name other than gcpro1.
2971 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2972 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2973 (Fx_backspace_delete_keys_p):
2974 Use them to avoid shadowing, and rename vars to avoid shadowing.
2975 (x_decode_color, x_set_name, x_window): Now static.
2976 (Fx_create_frame): Add braces to silence GCC warning.
2977 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2978 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2979 Remove unused locals.
2980 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2981 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2982 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2985 * xterm.h (x_mouse_leave): New decl.
2987 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2988 Remove unused functions.
2989 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2990 (x_calc_absolute_position): Now static.
2991 (XTread_socket): Don't define label "out" unless it's used.
2992 Don't declare local "event" unless it's used.
2993 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2994 unless they are used.
2995 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2996 (x_fatal_error_signal): Remove; not used.
2997 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2998 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2999 (x_error_catcher, x_connection_closed, x_error_handler):
3000 (x_error_quitter, xembed_send_message, x_iconify_frame):
3001 (my_log_handler): Rename locals to avoid shadowing.
3002 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3003 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3005 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3006 Rename or move locals to avoid shadowing.
3007 (tty_defined_color, merge_face_heights): Now static.
3008 (free_realized_faces_for_fontset): Remove; not used.
3009 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3010 does not deduce is never used uninitialized.
3011 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3012 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3014 * terminal.c (store_terminal_param): Now static.
3016 * xmenu.c (menu_highlight_callback): Now static.
3017 (set_frame_menubar): Remove unused local.
3018 (xmenu_show): Rename parameter to avoid shadowing.
3019 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3020 since they might point to immutable storage.
3021 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3022 since it's unused otherwise.
3024 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3025 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3026 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3027 avoids a gcc -Wuninitialized diagnostic.
3028 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3029 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3030 does not deduce are never used uninitialized.
3032 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3034 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3035 * window.c (window_loop, size_window):
3036 (run_window_configuration_change_hook, enlarge_window): Likewise.
3038 * window.c (display_buffer): Now static.
3039 (size_window): Mark variables that gcc -Wuninitialized
3040 does not deduce are never used uninitialized.
3041 * window.h (check_all_windows): New decl, to forestall
3042 gcc -Wmissing-prototypes diagnostic.
3043 * dispextern.h (bidi_dump_cached_states): Likewise.
3045 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3047 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3049 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3050 and to avoid gcc -Wuninitialized warning.
3051 (load_charset_map): Mark variables that gcc -Wuninitialized
3052 does not deduce are never used uninitialized.
3053 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3055 * coding.c (coding_set_source, coding_set_destination):
3056 Use "else { /* comment */ }" rather than "else /* comment */;"
3057 for clarity, and to avoid gcc -Wempty-body warning.
3058 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3059 a block, when the outer 'i' will do.
3060 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3061 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3062 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3063 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3064 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3065 Rename locals to avoid shadowing.
3066 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3067 * coding.c (emacs_mule_char, encode_invocation_designation):
3068 Now static, since they're not used elsewhere.
3069 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3070 (decode_coding_object, encode_coding_object, detect_coding_system):
3071 (decode_coding_emacs_mule): Mark variables that gcc
3072 -Wuninitialized does not deduce are never used uninitialized.
3073 (detect_coding_iso_2022): Initialize a local variable that might
3074 be used uninitialized. Leave a FIXME because it's not clear that
3075 this initialization is needed. (Bug#8211)
3076 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3077 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3078 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3079 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3080 Remove unused macros.
3082 * category.c (hash_get_category_set): Remove unused local var.
3083 (copy_category_table): Now static, since it's not used elsewhere.
3084 * character.c (string_count_byte8): Likewise.
3086 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3087 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3089 * chartab.c (copy_sub_char_table): Now static, since it's not used
3091 (sub_char_table_ref_and_range, char_table_ref_and_range):
3092 Rename locals to avoid shadowing.
3093 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3095 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3096 (BIDI_BOB): Remove unused macro.
3098 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3099 deduce are never used uninitialized.
3100 * term.c (encode_terminal_code): Likewise.
3102 * term.c (encode_terminal_code): Now static. Remove unused local.
3104 * tparam.h: New file.
3105 * term.c, tparam.h: Include it.
3106 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3107 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3108 Move these decls to tparam.h, and make them agree with what
3109 is actually in tparam.c. The previous trick of using incompatible
3110 decls in different modules does not conform to the C standard.
3111 All callers of tparam changed to use tparam's actual API.
3112 * tparam.c (tparam1, tparam, tgoto):
3113 Use const pointers where appropriate.
3115 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3116 * cm.h (struct cm): Likewise.
3117 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3118 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3119 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3120 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3121 (turn_on_face, init_tty): Likewise.
3122 * termchar.h (struct tty_display_info): Likewise.
3124 * term.c (term_mouse_position): Rename local to avoid shadowing.
3126 * alloc.c (mark_ttys): Move decl from here ...
3127 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3129 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3131 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3133 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3135 * search.c (compile_pattern_1): Remove argument regp, unused since
3136 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3137 (compile_pattern): Don't pass it.
3139 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3141 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3142 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3144 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3146 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3148 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3149 gdk_window_get_screen, gdk_window_get_geometry,
3150 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3151 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3152 (xg_get_pixbuf_from_pixmap): New function.
3153 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3154 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3155 Call xg_get_pixbuf_from_pixmap instead of
3156 gdk_pixbuf_get_from_drawable.
3157 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3158 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3159 (xg_check_special_colors): Use GtkStyleContext and its functions
3161 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3162 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3163 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3164 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3165 Call gtk_widget_get_preferred_size.
3166 (xg_frame_resized): gdk_window_get_geometry only takes 5
3168 (xg_win_to_widget, xg_event_is_for_menubar):
3169 Call gdk_x11_window_lookup_for_display.
3170 (xg_set_widget_bg): New function.
3171 (delete_cb): New function.
3172 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3173 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3174 (xg_set_background_color): Call xg_set_widget_bg.
3175 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3176 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3177 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3178 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3180 (update_frame_tool_bar): Call gtk_widget_hide.
3181 (xg_initialize): Use GDK_KEY_g.
3183 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3185 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3187 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3188 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3189 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3191 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3193 * w32xfns.c (select_palette): Check success of RealizePalette against
3194 GDI_ERROR, not zero.
3196 See ChangeLog.11 for earlier changes.
3202 Copyright (C) 2011 Free Software Foundation, Inc.
3204 This file is part of GNU Emacs.
3206 GNU Emacs is free software: you can redistribute it and/or modify
3207 it under the terms of the GNU General Public License as published by
3208 the Free Software Foundation, either version 3 of the License, or
3209 (at your option) any later version.
3211 GNU Emacs is distributed in the hope that it will be useful,
3212 but WITHOUT ANY WARRANTY; without even the implied warranty of
3213 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3214 GNU General Public License for more details.
3216 You should have received a copy of the GNU General Public License
3217 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.