| blob | 32d0017d7ef74bdf26280bbc957e1dcea730fb85 |
1 2012-06-13 Glenn Morris <rgm@gnu.org>
3 * s/usg5-4-common.h, src/s/unixware.h:
4 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
6 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
8 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
10 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
11 * alloc.c (make_number) [!defined make_number]:
12 Remove, as lisp.h always defines this now.
13 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
14 (roundup_size): Verify that it is a power of 2.
15 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
16 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
17 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
18 -DUSE_LSB_TAG=0, to override the automatically-selected default.
19 USE_LSB_TAG now is always defined to be either 0 or 1.
20 All uses changed.
21 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
22 code works fine either way, and efficiency is not a concern here,
23 as the union type is for debugging, not for production.
24 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
25 Use an inline function on all platforms when using the union type,
26 since this is simpler and 'static inline' can be used portably
27 within Emacs now.
28 (LISP_INITIALLY_ZERO): New macro.
29 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
30 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
32 2012-06-12 Glenn Morris <rgm@gnu.org>
34 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
36 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
38 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
39 Move BROKEN_SIGIO to configure.
41 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
42 Move NO_TERMIO to configure.
44 2012-06-12 Chong Yidong <cyd@gnu.org>
46 * image.c (imagemagick_load_image): Use MagickFlattenImage if
47 MagickMergeImageLayers is undefined. Use pixel pusher loop if
48 MagickExportImagePixels is undefined.
50 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
52 * image.c (imagemagick_load_image): Remove unused label.
54 2012-06-11 Glenn Morris <rgm@gnu.org>
56 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
57 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
58 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
59 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
61 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
63 * alloc.c (make_byte_code): New function.
64 (Fmake_byte_code): Use it. Don't purify here.
65 * lread.c (read1): Use it as well to avoid extra allocation.
67 2012-06-11 Chong Yidong <cyd@gnu.org>
69 * image.c (imagemagick_load_image): Implement transparency.
71 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
73 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
74 account for preceding backslashes. (Bug#11663)
76 2012-06-09 Chong Yidong <cyd@gnu.org>
78 * term.c: Support italics in capable terminals (Bug#9652).
79 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
80 (turn_on_face): Output using TS_enter_italic_mode if available.
81 Don't handle unused blinking and alt-charset cases.
82 (turn_off_face): Handle italic case; discard unused tty_blinking_p
83 and tty_alt_charset_p cases.
84 (tty_capable_p, init_tty): Support italics.
86 * termchar.h (struct tty_display_info): Add field for italics.
87 Remove unused blink field.
89 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
90 Handle slant.
92 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
93 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
94 tty_alt_charset_p. Add tty_italic_p.
96 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
98 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
99 dbus_type_is_basic if available.
100 (xd_extract_signed, xd_extract_unsigned): Rename from
101 extract_signed and extract_unsigned, respectively. Adapt callers.
103 2012-06-09 Chong Yidong <cyd@gnu.org>
105 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
107 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
108 case (Bug#9752).
110 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
112 * xdisp.c (vmessage): Treat frame message as multibyte.
113 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
114 would generate the diagnostic "Making \302\247 buffer-local while
115 let-bound!".
117 2012-06-08 Eli Zaretskii <eliz@gnu.org>
119 * dispnew.c (showing_window_margins_p): Undo last change, which
120 was done due to an inadvertent commit.
121 (adjust_frame_glyphs_for_frame_redisplay): Do call
122 showing_window_margins_p.
124 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
126 * eval.c (Fmake_var_non_special): New primitive.
127 (syms_of_eval): Defsubr it.
128 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
130 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
132 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
133 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
135 2012-06-08 Eli Zaretskii <eliz@gnu.org>
137 * alloc.c (allocate_vectorlike): Fix last change.
139 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
141 Block-based vector allocation of small vectors.
142 * lisp.h (struct vectorlike_header): New field `nbytes',
143 adjust comment accordingly.
144 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
145 to denote vector blocks. Adjust users (live_vector_p,
146 mark_maybe_pointer, valid_lisp_object_p) accordingly.
147 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
148 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
149 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
150 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
151 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
152 (roundup_size): New constant.
153 (struct vector_block): New data type.
154 (vector_blocks, vector_free_lists, zero_vector): New variables.
155 (all_vectors): Rename to `large_vectors'.
156 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
157 (sweep_vectors): New functions.
158 (allocate_vectorlike): Return `zero_vector' as the only vector of
159 0 items. Allocate new vector from block if vector size is less than
160 or equal to VBLOCK_BYTES_MAX.
161 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
162 (init_alloc_once): Add call to init_vectors.
164 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
166 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
168 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
170 * doprnt.c (doprnt): Truncate multibyte char correctly.
171 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
172 would mishandle a string argument "Xc" if X was a multibyte
173 character of length 2: it would truncate after X's first byte
174 rather than including all of X.
176 2012-06-06 Chong Yidong <cyd@gnu.org>
178 * buffer.c (word_wrap): Doc fix.
180 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
182 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
184 2012-06-03 Glenn Morris <rgm@gnu.org>
186 * xdisp.c (tool-bar-style): Doc fix.
188 2012-06-03 Ulrich Müller <ulm@gentoo.org>
190 * Makefile.in (PAXCTL): Define.
191 (temacs$(EXEEXT)): Disable memory randomization for the temacs
192 binary via PaX flags if the paxctl utility is available.
193 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
194 Restore PaX flags to their default. (Bug#11398)
196 2012-06-03 Chong Yidong <cyd@gnu.org>
198 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
199 buffer (Bug#11226).
201 2012-06-03 Chong Yidong <cyd@gnu.org>
203 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
204 (note_mode_line_or_margin_highlight): If there is no help echo,
205 use mode-line-default-help-echo. Handle the case where the mouse
206 position is past the end of the mode line string.
208 * buffer.c (buffer_local_value_1): New function, split from
209 Fbuffer_local_value; can return Qunbound.
210 (Fbuffer_local_value): Use it.
211 (Vmode_line_format): Docstring tweaks.
213 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
215 * sysdep.c (system_process_attributes): Improve comment.
217 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
219 * keyboard.c: Export real-this-command to Elisp.
220 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
221 and DEFVAR it. Update all users.
223 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
225 * minibuf.c (Fassoc_string): Remove duplicate declaration.
227 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
228 Convert pctcpu and pctmem to Lisp float properly.
229 Let the compiler fold better, as 100.0/0x8000 is exact.
231 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
233 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
234 cons_block.
236 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
238 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
240 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
242 For a 'struct window', replace some Lisp_Object fields to
243 bitfields where appropriate, remove unused fields.
244 * window.h (struct window): Remove unused 'last_mark_x' and
245 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
246 change it's type from Lisp_Object to bitfield.
247 Change type of 'force_start', 'optional_new_start',
248 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
249 fields from Lisp_Object to bitfield. Adjust users accordingly.
251 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
253 Pacify gcc -Wdouble-precision when using Xaw.
254 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
255 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
256 Use 'float' consistently, rather than 'float' in most places
257 and 'double' in a couple of places.
259 2012-05-31 Eli Zaretskii <eliz@gnu.org>
261 * xdisp.c (handle_stop): Detect whether we have overlay strings
262 loaded by testing it->current.overlay_string_index to be
263 non-negative, instead of checking whether n_overlay_strings is
264 positive. (Bug#11587)
266 2012-05-31 Chong Yidong <cyd@gnu.org>
268 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
270 * doc.c (Fsubstitute_command_keys): Doc fix.
272 2012-05-31 Eli Zaretskii <eliz@gnu.org>
274 * search.c (search_buffer): Remove calls to
275 r_alloc_inhibit_buffer_relocation, as it is now called by
276 maybe_unify_char, which was the cause of relocation of buffer text
277 in bug#11519.
279 2012-05-31 Eli Zaretskii <eliz@gnu.org>
281 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
282 for the duration of call to load_charset, to avoid problems with
283 callers of maybe_unify_char that access buffer text through C
284 pointers.
286 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
287 decrement the inhibition flag, instead of just setting or
288 resetting it.
290 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
292 Remove obsolete '#define static' cruft.
293 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
294 This #undef was "temporary" in 2000; it is no longer needed
295 now that '#define static' has gone away.
296 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
297 (gray_bitmap_bits): Remove; no longer needed.
298 All uses replaced with definiens.
299 * xterm.c: Include "bitmaps/gray.xbm".
301 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
303 Clean up __executable_start, monstartup when --enable-profiling.
304 The following changes affect the code only when profiling.
305 * dispnew.c (__executable_start): Rename from safe_bcopy.
306 Define only on platforms that need it.
307 * emacs.c: Include <sys/gmon.h> when profiling.
308 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
309 (__executable_start): Remove decl, since lisp.h does it now.
310 (safe_bcopy): Remove decl; no longer has that name.
311 (main): Coalesce #if into single bit of code, for simplicity.
312 Cast pointers to uintptr_t, since standard libraries want integers
313 and not pointers.
314 * lisp.h (__executable_start): New decl.
316 2012-05-31 Glenn Morris <rgm@gnu.org>
318 * image.c (Fimagemagick_types): Doc fix.
320 2012-05-30 Jim Meyering <meyering@redhat.com>
322 * callproc.c (Fcall_process_region): Include directory component
323 in mkstemp error message (Bug#11586).
325 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
327 * alloc.c, lisp.h (make_pure_vector): Now static.
329 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
331 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
332 Move to byte-run.el.
333 (Fautoload): Do the hash-doc more carefully.
334 * data.c (Fdefalias): Purify definition, except for keymaps.
335 (Qdefun): Move from eval.c.
336 * lisp.h (Qdefun): Remove.
337 * lread.c (read1): Tiny simplification.
339 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
341 Do not create empty overlays with the evaporate property (Bug#9642).
342 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
343 Bug#9642, but explicitly check that the buffer the overlay would
344 be moved to is live and rearrange lines to make sure that errors
345 will not put the overlay in an inconsistent state.
346 (Fdelete_overlay): Cosmetics.
348 2012-05-28 Eli Zaretskii <eliz@gnu.org>
350 * w32term.c (my_bring_window_to_top): New function.
351 (x_raise_frame): Use handle returned by DeferWindowPos, which
352 could be different from the original one.
353 Call my_bring_window_to_top instead of my_set_foreground_window.
354 (Bug#11513)
356 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
357 by calling BringWindowToTop.
359 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
360 (WM_EMACS_END): Increase by one.
362 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
364 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
365 This avoids undefined behavior that might cause the eassert
366 to not catch an out-of-range value.
368 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
370 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
371 Update dependencies.
373 2012-05-27 Eli Zaretskii <eliz@gnu.org>
375 * bidi.c (bidi_mirror_char): Fix last change.
377 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
379 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
380 when referring to sectname field in printf format.
382 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
384 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
385 Only r_alloc_inhibit_buffer_relocation needed to be added;
386 the others were already declared.
388 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
389 before checking whether it's out of range. Put the check inside
390 eassert. See
391 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
393 2012-05-27 Ken Brown <kbrown@cornell.edu>
395 * callproc.c (Fcall_process): Restore a line that was accidentally
396 commented out in the 2011-02-13 change (bug#11547).
398 2012-05-27 Eli Zaretskii <eliz@gnu.org>
400 * lisp.h [REL_ALLOC]: Add prototypes for external functions
401 defined on ralloc.c.
403 * buffer.c [REL_ALLOC]: Remove prototypes of
404 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
405 they are now on lisp.h.
407 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
409 * search.c (search_buffer): Use it to inhibit relocation of buffer
410 text while re_search_2 is doing its job, because re_search_2 is
411 passed C pointers to buffer text. (Bug#11519)
413 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
414 Update value to 24.
416 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
417 state after an additional call to move_it_in_display_line_to, keep
418 the values of it->max_ascent and it->max_descent found for the
419 entire line.
420 (pos_visible_p): Revert the comparison against bottom_y to what it
421 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
422 (Bug#11464)
424 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
426 Fix coding-related core dumps with gcc -ftrapv.
427 The code was computing A - B, where A and B are pointers, and B is
428 random garbage. This can lead to core dumps on platforms that
429 have special pointer registers, and it also leads to core dumps on
430 x86-64 when compiled with gcc -ftrapv. The fix is to compute
431 A - B only when B is initialized properly.
432 * coding.c (coding_set_source, coding_set_destination): Return void.
433 (coding_change_source, coding_change_destinations): New functions,
434 with the old behaviors of coding_set_source and coding_set_destination.
435 All callers that need an offset changed to use these new functions.
437 2012-05-26 Glenn Morris <rgm@gnu.org>
439 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
441 2012-05-26 Eli Zaretskii <eliz@gnu.org>
443 Extend mouse support on W32 text-mode console.
444 * xdisp.c (draw_row_with_mouse_face):
445 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
447 * w32console.c: Include window.h.
448 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
449 New functions.
450 (initialize_w32_display): Initialize mouse-highlight data.
452 * w32inevt.c: Include termchar.h and window.h.
453 (do_mouse_event): Support mouse-autoselect-window. When the mouse
454 moves, call note_mouse_highlight. If help_echo changed, call
455 gen_help_event to produce help-echo message in the echo area.
456 Call clear_mouse_face if mouse_face_hidden is set in the mouse
457 highlight info.
459 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
461 * lread.c (read1): Simplify slightly to avoid an overflow warning
462 with GCC 4.7.0 on x86-64.
464 2012-05-26 Eli Zaretskii <eliz@gnu.org>
466 * bidi.c (bidi_mirror_char): Revert last change: an int is
467 definitely wide enough here.
469 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
471 Fix integer width and related bugs (Bug#9874).
472 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
473 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
474 (string_bytes, check_sblock, allocate_string_data):
475 (compact_small_strings, Fmake_bool_vector, make_string)
476 (make_unibyte_string, make_multibyte_string)
477 (make_string_from_bytes, make_specified_string)
478 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
479 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
480 (mark_vectorlike):
481 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
482 (allocate_pseudovector):
483 Use int, not EMACS_INT, where int is wide enough.
484 (inhibit_garbage_collection, Fgarbage_collect):
485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
486 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
487 int might not be wide enough.
488 (bidi_cache_search, bidi_cache_find, bidi_init_it)
489 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
490 (bidi_at_paragraph_end, bidi_find_paragraph_start)
491 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
492 (bidi_level_of_next_char, bidi_move_to_visually_next):
493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
494 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
495 (Fkill_buffer, Fset_buffer_major_mode)
496 (advance_to_char_boundary, Fbuffer_swap_text)
497 (Fset_buffer_multibyte, overlays_at, overlays_in)
498 (overlay_touches_p, struct sortvec, record_overlay_string)
499 (overlay_strings, recenter_overlay_lists)
500 (adjust_overlays_for_insert, adjust_overlays_for_delete)
501 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
502 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
503 (Foverlay_recenter, last_overlay_modification_hooks_used)
504 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
506 (validate_region): Omit unnecessary test for b <= e,
507 since that's guaranteed by the previous test.
508 (adjust_overlays_for_delete): Avoid pos + length overflow.
509 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
510 (report_overlay_modification):
511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
512 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
513 Omit pointer cast, which isn't needed anyway, and doesn't work
514 after the EMACS_INT -> ptrdiff_t change.
515 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
516 * buffer.h: Adjust decls to match defn changes elsewhere.
517 (struct buffer_text, struct buffer):
518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
519 Use EMACS_INT, not int, where int might not be wide enough.
520 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
521 not int, to avoid needless 32-bit limit on 64-bit hosts.
522 (exec_byte_code): Use tighter memory-full test, one that checks
523 for alloca overflow. Don't compute the address of the object just
524 before an array, as that's not portable. Use EMACS_INT, not
525 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
526 * callint.c (Fcall_interactively):
527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
528 * callproc.c (call_process_kill, Fcall_process):
529 Don't assume pid_t fits into an Emacs fixnum.
530 (call_process_cleanup, Fcall_process, child_setup):
531 Don't assume pid_t fits into int.
532 (call_process_cleanup, Fcall_process, delete_temp_file)
533 (Fcall_process_region):
534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
535 (Fcall_process): Simplify handling of volatile integers.
536 Use int, not EMACS_INT, where int will do.
537 * casefiddle.c (casify_object, casify_region, operate_on_word)
538 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
540 (casify_object): Avoid integer overflow when overallocating buffer.
541 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
542 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
543 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
544 * category.h (CATEGORYP): Don't assume arg is nonnegative.
545 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
546 integers are now checked earlier. All uses replaced with XINT.
547 (ccl_driver):
548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
549 For CCL_MapSingle, check that content and value are in int range.
550 (ccl_driver, Fregister_code_conversion_map):
551 Check that Vcode_version_map_vector is a vector.
552 (resolve_symbol_ccl_program): Check that vector header is in range.
553 Always copy the vector, so that we can check its contents reliably
554 now rather than having to recheck each instruction as it's being
555 executed. Check that vector words fit in 'int'.
556 (ccl_get_compiled_code, Fregister_ccl_program)
557 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
558 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
559 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
560 contents are in range.
561 (Fccl_execute_on_string): Check that status is in range.
562 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
563 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
564 Accept and return EMACS_INT, not int, because callers can pass values
565 out of 'int' range.
566 (c_string_width, strwidth, lisp_string_width, chars_in_text)
567 (multibyte_chars_in_text, parse_str_as_multibyte)
568 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
569 (str_as_unibyte, str_to_unibyte, string_count_byte8)
570 (string_escape_byte8, Fget_byte):
571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
572 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
573 avoid mishandling large integers.
574 * character.h: Adjust decls to match defn changes elsewhere.
575 * charset.c (load_charset_map_from_file, find_charsets_in_text)
576 (Ffind_charset_region):
577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
578 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
579 (load_charset_map_from_vector, Fdefine_charset_internal):
580 Don't assume fixnum fits in int.
581 (load_charset_map_from_vector, Fmap_charset_chars):
582 Remove now-unnecessary CHECK_NATNUMs.
583 (Fdefine_charset_internal): Check ranges here, more carefully.
584 Don't rely on undefined behavior with signed left shift overflow.
585 Don't assume unsigned int fits into fixnum, or that fixnum fits
586 into unsigned int. Don't require max_code to be a valid fixnum;
587 that's not true for gb10830 4-byte on a 32-bit host. Allow
588 invalid_code to be a cons, for the same reason. Require code_offset
589 to be a character. Avoid int overflow if max_char is close
590 to INT_MAX.
591 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
592 this is intended anyway and avoids some undefined behavior.
593 (load_charset_map): Pass unsigned, not int, as 2nd arg of
594 INDEX_TO_CODE_POINT, as that's what it expects.
595 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
596 * charset.h (DECODE_CHAR): Return int, not unsigned;
597 this is what was intended anyway, and it avoids undefined behavior.
598 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
599 integer-overflow issues.
600 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
601 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
602 where the argument is EMACS_INT, and this behavior is not intended.
603 * chartab.c (Fmake_char_table, Fset_char_table_range)
604 (uniprop_get_decoder, uniprop_get_encoder):
605 Don't assume fixnum fits in int.
606 * cmds.c (move_point): New function, that does the gist of
607 Fforward_char and Fbackward_char, but does so while checking
608 for integer overflow more accurately.
609 (Fforward_char, Fbackward_char): Use it.
610 (Fforward_line, Fend_of_line, internal_self_insert)
611 (internal_self_insert):
612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
613 Fix a FIXME, by checking for integer overflow when calculating
614 target_clm and actual_clm.
615 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
616 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
617 (ASSURE_DESTINATION, coding_alloc_by_realloc)
618 (coding_alloc_by_making_gap, alloc_destination)
619 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
620 (encode_coding_utf_16, detect_coding_emacs_mule)
621 (decode_coding_emacs_mule, encode_coding_emacs_mule)
622 (detect_coding_iso_2022, decode_coding_iso_2022)
623 (encode_invocation_designation, encode_designation_at_bol)
624 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
625 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
626 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
627 (encode_coding_ccl, encode_coding_raw_text)
628 (detect_coding_charset, decode_coding_charset)
629 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
630 (produce_composition, produce_charset, produce_annotation)
631 (decode_coding, handle_composition_annotation)
632 (handle_charset_annotation, consume_chars, decode_coding_gap)
633 (decode_coding_object, encode_coding_object, detect_coding_system)
634 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
635 (code_convert_region, code_convert_string)
636 (Fdefine_coding_system_internal)
637 (coding_set_source, coding_set_destination):
638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
639 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
640 (Fdefine_coding_system_internal):
641 Don't assume fixnums fit in int.
642 (decode_coding_gap, decode_coding_object, encode_coding_object)
643 (Fread_coding_system, Fdetect_coding_region)
644 (Funencodable_char_position, Fcheck_coding_systems_region)
645 (get_translation, handle_composition_annotation, consume_chars):
646 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
647 (consume_chars): Rewrite to not calculate an address outside buffer.
648 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
649 Don't access memory outside of the args array.
650 (Fdefine_coding_system_internal): Check for charset-id overflow.
651 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
652 result of ENCODE_CHAR.
653 * coding.h: Adjust decls to match defn changes elsewhere.
654 (struct coding_system):
655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
656 * composite.c (get_composition_id, find_composition)
657 (run_composition_function, update_compositions)
658 (compose_text, composition_gstring_put_cache)
659 (composition_gstring_p, composition_gstring_width)
660 (fill_gstring_header, fill_gstring_body, autocmp_chars)
661 (composition_compute_stop_pos, composition_reseat_it)
662 (composition_update_it, struct position_record)
663 (find_automatic_composition, composition_adjust_point)
664 (Fcomposition_get_gstring, Ffind_composition_internal):
665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
666 (update_compositions):
667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
668 * composite.h: Adjust decls to match defn changes elsewhere.
669 (struct composition):
670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
671 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
672 Do not attempt to compute the address of the object just before a
673 buffer; this is not portable.
674 (Faref, Faset):
675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
676 (Faset): Use int, not EMACS_INT, where int is wide enough.
677 (Fstring_to_number): Don't assume fixnums fit in int.
678 (Frem): Don't assume arg is nonnegative.
679 * dbusbind.c (xd_append_arg): Check for integers out of range.
680 (Fdbus_call_method): Don't overflow the timeout int.
681 (extract_signed, extract_unsigned): New functions.
682 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
683 (xd_get_connection_references): Return ptrdiff_t, not int.
684 All uses changed.
685 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
686 (xd_read_message_1):
687 Use int, not unsigned, where the dbus API uses int.
688 (Fdbus_message_internal): Don't overflow mtype.
689 (syms_of_dbusbind): Allocate right-sized buffer for integers.
690 * dired.c (directory_files_internal, file_name_completion, scmp)
691 (file_name_completion_stat):
692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
693 (file_name_completion): Don't overflow matchcount.
694 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
695 * dispextern.h: Adjust decls to match defn changes elsewhere.
696 (struct text_pos, struct glyph, struct bidi_saved_info)
697 (struct bidi_string_data, struct bidi_it, struct composition_it)
698 (struct it):
699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
700 (struct display_pos, struct composition_it, struct it):
701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
702 * dispnew.c (increment_matrix_positions)
703 (increment_row_positions, mode_line_string)
704 (marginal_area_string):
705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
706 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
707 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
708 (duration_to_sec_usec): New function, to check for overflow better.
709 (Fsleep_for, sit_for): Use it.
710 * doc.c (get_doc_string, store_function_docstring):
711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
712 (get_doc_string, Fsnarf_documentation):
713 Use int, not EMACS_INT, where int is wide enough.
714 (get_doc_string):
715 Use SAFE_ALLOCA, not alloca.
716 Check for overflow when converting EMACS_INT to off_t.
717 * doprnt.c (doprnt):
718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
719 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
720 Don't assume uid_t fits into fixnum.
721 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
722 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
723 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
724 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
725 (general_insert_function)
726 (Finsert_char, make_buffer_string, make_buffer_string_both)
727 (update_buffer_properties, Fbuffer_substring)
728 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
729 (Fsubst_char_in_region, check_translation)
730 (Ftranslate_region_internal, save_restriction_restore, Fformat)
731 (transpose_markers, Ftranspose_regions):
732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
733 (clip_to_bounds): Move to lisp.h as an inline function).
734 (Fconstrain_to_field): Don't assume integers are nonnegative.
735 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
736 (Fsubst_char_in_region, Fsave_restriction):
737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
738 (Femacs_pid): Don't assume pid_t fits into fixnum.
739 (lo_time): Use int, not EMACS_INT, when int suffices.
740 (lisp_time_argument): Check for usec out of range.
741 (Fencode_time): Don't assume fixnum fits in int.
742 (Fuser_login_name, Fuser_full_name): Signal an error
743 if a uid argument is out of range, rather than relying on
744 undefined behavior.
745 (Fformat_time_string): Remove now-unnecessary check.
746 lisp_time_argument checks for out-of-range usec now.
747 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
748 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
749 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
750 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
751 (init_cmdargs, Fdump_emacs):
752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
753 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
754 the bottom (typically) 32 bits of the fixnum.
755 * eval.c (specpdl_size, call_debugger):
756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
757 (when_entered_debugger, Fbacktrace_debug):
758 Don't assume fixnum can fit in int.
759 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
760 the object just before a buffer; this is not portable.
761 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
762 (grow_specpdl, unbind_to):
763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
764 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
765 (grow_specpdl): Simplify allocation by using xpalloc.
766 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
767 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
768 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
770 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
771 (a_write, e_write):
772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
773 (Fcopy_file, non_regular_nbytes, read_non_regular)
774 (Finsert_file_contents):
775 Use int, not EMACS_INT, where int is wide enough.
776 (READ_BUF_SIZE): Verify that it fits in int.
777 (Finsert_file_contents): Check that counts are in proper range,
778 rather than assuming fixnums fit into ptrdiff_t etc.
779 Don't assume fixnums fit into int.
780 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
781 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
782 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
783 (string_char_to_byte, string_byte_to_char)
784 (string_make_multibyte, string_to_multibyte)
785 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
786 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
787 (substring_both, Fdelete, internal_equal, Ffillarray)
788 (Fclear_string, mapcar1)
789 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
790 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
791 (larger_vector, make_hash_table, maybe_resize_hash_table)
792 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
793 (Fmaphash, secure_hash):
794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
795 (concat): Check for string index and length overflow.
796 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
797 (Frequire):
798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
799 (larger_vector): New API (vec, incr_min, size_max) replaces old
800 one (vec, new_size, init). This catches size overflow.
801 INIT was removed because it was always Qnil.
802 All callers changed.
803 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
804 the upper bound on a hash table index size.
805 (make_hash_table, maybe_resize_hash_table): Use it.
806 (secure_hash): Computer start_byte and end_byte only after
807 they're known to be in ptrdiff_t range.
808 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
809 (Ffont_get_glyphs, Ffont_at):
810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
811 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
812 (Flist_fonts, Fopen_font):
813 Don't assume fixnum can fit in int.
814 (check_gstring): Don't assume index can fit in int.
815 (font_match_p): Check that fixnum is a character, not a nonnegative
816 fixnum, since the later code needs to stuff it into an int.
817 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
818 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
819 conversion overflow issues.
820 (Fopen_font): Check for integer out of range.
821 (Ffont_get_glyphs): Don't assume index can fit in int.
822 * font.h: Adjust decls to match defn changes elsewhere.
823 * fontset.c (reorder_font_vector): Redo score calculation to avoid
824 integer overflow.
825 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
826 printmax_t, where ptrdiff_t is wide enough.
827 (Finternal_char_font):
828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
829 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
830 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
831 (Fset_frame_position, x_set_frame_parameters)
832 (x_set_line_spacing, x_set_border_width)
833 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
834 Check that fixnums are in proper range for system types.
835 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
837 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
838 Use SAFE_ALLOCA_LISP, not alloca.
839 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
840 intptr_t is wide enough.
841 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
842 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
843 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
844 Check for fixnum out of range.
845 * ftfont.c (ftfont_list): Don't assume index fits in int.
846 Check that fixnums are in proper range for system types.
847 (ftfont_shape_by_flt):
848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
849 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
850 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
851 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
852 Check that fixnums are in proper range for system types.
853 * gnutls.h: Adjust decls to match defn changes elsewhere.
854 * gtkutil.c (xg_dialog_run):
855 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
856 (update_frame_tool_bar):
857 Check that fixnums are in proper range for system types.
858 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
859 (lookup_image): Check that fixnums are in range for system types.
860 * indent.c (last_known_column, last_known_column_point):
861 (current_column_bol_cache):
862 (skip_invisible, current_column, check_display_width):
863 (check_display_width, scan_for_column, current_column_1)
864 (Findent_to, Fcurrent_indentation, position_indentation)
865 (indented_beyond_p, Fmove_to_column, compute_motion):
866 (Fcompute_motion, Fvertical_motion):
867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
868 (last_known_column_modified): Use EMACS_INT, not int.
869 (check_display_width):
870 (Fcompute_motion):
871 Check that fixnums and floats are in proper range for system types.
872 (compute_motion): Don't assume index or fixnum fits in int.
873 (compute_motion, Fcompute_motion):
874 Use int, not EMACS_INT, when it is wide enough.
875 (vmotion): Omit local var start_hpos that is always 0; that way
876 we don't need to worry about overflow in expressions involving it.
877 * indent.h: Adjust decls to match defn changes elsewhere.
878 (struct position):
879 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
880 Use int, not EMACS_INT, where int is wide enough.
881 Remove unused members ovstring_chars_done and tab_offset;
882 all uses removed.
883 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
884 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
885 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
886 (make_gap, copy_text, insert, insert_and_inherit)
887 (insert_before_markers, insert_before_markers_and_inherit)
888 (insert_1, count_combining_before, count_combining_after)
889 (insert_1_both, insert_from_string)
890 (insert_from_string_before_markers, insert_from_string_1)
891 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
892 (adjust_after_replace, adjust_after_insert, replace_range)
893 (replace_range_2, del_range, del_range_1, del_range_byte)
894 (del_range_both, del_range_2, modify_region)
895 (prepare_to_modify_buffer, signal_before_change)
896 (signal_after_change, Fcombine_after_change_execute):
897 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
898 * intervals.c (traverse_intervals, rotate_right, rotate_left)
899 (balance_an_interval, split_interval_right, split_interval_left)
900 (find_interval, next_interval, update_interval)
901 (adjust_intervals_for_insertion, delete_node, delete_interval)
902 (interval_deletion_adjustment, adjust_intervals_for_deletion)
903 (static_offset_intervals, offset_intervals)
904 (merge_interval_right, merge_interval_left, make_new_interval)
905 (graft_intervals_into_buffer, temp_set_point_both)
906 (temp_set_point, set_point, adjust_for_invis_intang)
907 (set_point_both, move_if_not_intangible, get_property_and_range)
908 (get_local_map, copy_intervals, copy_intervals_to_string)
909 (compare_string_intervals, set_intervals_multibyte_1):
910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
911 * intervals.h: Adjust decls to match defn changes elsewhere.
912 (struct interval):
913 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
914 * keyboard.c (this_command_key_count, this_single_command_key_start)
915 (before_command_key_count, before_command_echo_length, echo_now)
916 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
917 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
918 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
919 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
920 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
921 (last_non_minibuf_size, last_point_position, echo_truncate)
922 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
923 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
924 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
925 (stuff_buffered_input):
926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
927 (last_auto_save, command_loop_1, read_char):
928 Use EMACS_INT, not int, to avoid integer overflow.
929 (record_char): Avoid overflow in total_keys computation.
930 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
931 * keyboard.h: Adjust decls to match defn changes elsewhere.
932 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
933 (Fkey_description, Fdescribe_vector, Flookup_key):
934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
935 (click_position): New function, to check that positions are in range.
936 (Fcurrent_active_maps):
937 (describe_command):
938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
939 (Faccessible_keymaps, Fkey_description):
940 (preferred_sequence_p):
941 Don't assume fixnum can fit into int.
942 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
943 Check for integer overflow in size calculations.
944 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
945 avoid mishandling large integers.
946 * lisp.h: Adjust decls to match defn changes elsewhere.
947 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
948 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
949 (struct Lisp_Marker):
950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
951 (clip_to_bounds): Now an inline function, moved here from editfns.c.
952 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
953 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
954 All callers changed.
955 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
956 Assume the arg has valid form, since it always does.
957 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
958 unsigned integer system type.
959 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
960 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
961 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
962 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
963 (duration_to_sec_usec): New decl.
964 * lread.c (read_from_string_index, read_from_string_index_byte)
965 (read_from_string_limit, readchar, unreadchar, openp)
966 (read_internal_start, read1, oblookup):
967 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
968 (Fload, readevalloop, Feval_buffer, Feval_region):
969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
970 (openp): Check for out-of-range argument to 'access'.
971 (read1): Use int, not EMACS_INT, where int is wide enough.
972 Don't assume fixnum fits into int.
973 Fix off-by-one error that can read outside a buffer.
974 (read_filtered_event): Use duration_to_sec_usec
975 to do proper overflow checking on durations.
976 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
977 in size calculation.
978 (Fexecute_kbd_macro):
979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
980 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
981 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
982 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
983 (set_marker_both, set_marker_restricted_both, marker_position)
984 (marker_byte_position, Fbuffer_has_markers_at):
985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
986 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
987 * menu.c (ensure_menu_items): Rename from grow_menu_items.
988 It now merely ensures that the menu is large enough, without
989 necessarily growing it, as this avoids some integer overflow issues.
990 All callers changed.
991 (keymap_panes, parse_single_submenu, Fx_popup_menu):
992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
993 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
994 Use SAFE_ALLOCA_LISP, not alloca.
995 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
996 to EMACS_INT. Check that fixnums are in proper range for system types.
997 * minibuf.c (minibuf_prompt_width, string_to_object)
998 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
999 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1000 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1001 (get_minibuffer, read_minibuf_unwind):
1002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1003 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1004 this simplifies overflow checking. All callers changed.
1005 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1006 (Ftest_completion):
1007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1008 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1009 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1010 Check that fixnums are in proper range for system types.
1011 (Fx_create_frame, Fx_show_tip):
1012 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1013 * nsfont.m (ns_findfonts, nsfont_list_family):
1014 Don't assume fixnum fits in long.
1015 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1017 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1018 wide enough.
1019 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1020 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1021 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1022 (PRINTDECLARE, PRINTPREPARE):
1023 (strout, print_string):
1024 (print, print_preprocess, print_check_string_charset_prop)
1025 (print_object):
1026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1027 (PRINTDECLARE):
1028 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1030 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1031 (printchar, strout): Use xpalloc to catch size calculation overflow.
1032 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1033 (print_error_message): Use SAFE_ALLOCA, not alloca.
1034 (print_object): Use int, not EMACS_INT, where int is wide enough.
1035 (print_depth, new_backquote_output, print_number_index):
1036 Use ptrdiff_t, not int, where int might not be wide enough.
1037 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1038 (Fset_process_window_size, Fformat_network_address)
1039 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1040 (sigchld_handler):
1041 Check that fixnums are in proper range for system types.
1042 (Fsignal_process): Simplify by avoiding a goto.
1043 Check for process-ids out of pid_t range rather than relying on
1044 undefined behavior.
1045 (process_tick, update_tick): Use EMACS_INT, not int.
1046 (Fformat_network_address, read_process_output, send_process)
1047 (Fprocess_send_region, status_notify):
1048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1049 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1050 (wait_reading_process_output, read_process_output, exec_sentinel):
1051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1052 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1053 (Faccept_process_output): Use duration_to_sec_usec to do proper
1054 overflow checking on durations.
1055 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1056 Don't assume pid_t fits in int.
1057 * process.h (struct Lisp_Process): Members tick and update_tick
1058 are now of type EMACS_INT, not int.
1059 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1060 configured --with-wide-int.
1061 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1062 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1063 * search.c (looking_at_1, string_match_1):
1064 (fast_string_match, fast_c_string_match_ignore_case)
1065 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1066 (scan_newline, find_before_next_newline, search_command)
1067 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1068 (set_search_regs, wordify):
1069 (Freplace_match):
1070 (Fmatch_data):
1071 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1072 (string_match_1, search_buffer, set_search_regs):
1073 (Fmatch_data):
1074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1075 (wordify): Check for overflow in size calculation.
1076 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1077 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1078 Check that fixnums are in proper range for system types.
1079 * sound.c (struct sound_device)
1080 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1082 (Fplay_sound_internal):
1083 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1084 * syntax.c (struct lisp_parse_state, find_start_modiff)
1085 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1086 (Fparse_partial_sexp):
1087 Don't assume fixnums can fit in int.
1088 (struct lisp_parse_state, find_start_pos, find_start_value)
1089 (find_start_value_byte, find_start_begv)
1090 (update_syntax_table, char_quoted, dec_bytepos)
1091 (find_defun_start, prev_char_comend_first, back_comment):
1092 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1093 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1095 (Finternal_describe_syntax_value): Check that match_lisp is a
1096 character, not an integer, since the code stuffs it into int.
1097 (scan_words, scan_sexps_forward):
1098 Check that fixnums are in proper range for system types.
1099 (Fforward_word):
1100 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1101 (scan_sexps_forward):
1102 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1103 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1104 * syntax.h: Adjust decls to match defn changes elsewhere.
1105 (struct gl_state_s):
1106 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1107 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1108 MOST_POSITIVE_FIXNUM.
1109 * sysdep.c (wait_for_termination_1, wait_for_termination)
1110 (interruptible_wait_for_termination, mkdir):
1111 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1112 (emacs_read, emacs_write):
1113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1114 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1115 and double all fit in int.
1116 * term.c (set_tty_color_mode):
1117 Check that fixnums are in proper range for system types.
1118 * termhooks.h (struct input_event):
1119 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1120 * textprop.c (validate_interval_range, interval_of)
1121 (Fadd_text_properties, set_text_properties_1)
1122 (Fremove_text_properties, Fremove_list_of_text_properties)
1123 (Ftext_property_any, Ftext_property_not_all)
1124 (copy_text_properties, text_property_list, extend_property_ranges)
1125 (verify_interval_modification):
1126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1127 (Fnext_single_char_property_change)
1128 (Fprevious_single_char_property_change):
1129 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1130 (copy_text_properties):
1131 Check for integer overflow in index calculation.
1132 * undo.c (last_boundary_position, record_point, record_insert)
1133 (record_delete, record_marker_adjustment, record_change)
1134 (record_property_change):
1135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1136 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1137 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1138 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1139 (Fx_hide_tip, Fx_file_dialog):
1140 * w32menu.c (set_frame_menubar):
1141 Use ptrdiff_t, not int, for consistency with rest of code.
1142 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1143 (select_window, Fdelete_other_windows_internal)
1144 (window_scroll_pixel_based, window_scroll_line_based)
1145 (Frecenter, Fset_window_configuration):
1146 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1147 (Fset_window_hscroll, run_window_configuration_change_hook)
1148 (set_window_buffer, temp_output_buffer_show, scroll_command)
1149 (Fscroll_other_window, Frecenter):
1150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1151 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1152 Don't assume fixnum fits in int.
1153 (Fset_window_scroll_bars):
1154 Check that fixnums are in proper range for system types.
1155 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1156 (string_pos, c_string_pos, number_of_chars, init_iterator)
1157 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1158 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1159 (compute_display_string_end, handle_face_prop)
1160 (face_before_or_after_it_pos, handle_invisible_prop)
1161 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1162 (display_prop_intangible_p, string_buffer_position_lim)
1163 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1164 (get_overlay_strings_1, get_overlay_strings)
1165 (iterate_out_of_display_property, forward_to_next_line_start)
1166 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1167 (get_next_display_element, set_iterator_to_next)
1168 (get_visually_first_element, compute_stop_pos_backwards)
1169 (handle_stop_backwards, next_element_from_buffer)
1170 (move_it_in_display_line_to, move_it_in_display_line)
1171 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1172 (add_to_log, message_dolog, message_log_check_duplicate)
1173 (message2, message2_nolog, message3, message3_nolog
1174 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1175 (current_message_1, truncate_echo_area, truncate_message_1)
1176 (set_message, set_message_1, store_mode_line_noprop)
1177 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1178 (text_outside_line_unchanged_p, check_point_in_composition)
1179 (reconsider_clip_changes)
1180 (redisplay_internal, set_cursor_from_row, try_scrolling)
1181 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1182 (redisplay_window, find_last_unchanged_at_beg_row)
1183 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1184 (trailing_whitespace_p, find_row_edges, display_line)
1185 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1186 (display_mode_element, store_mode_line_string)
1187 (pint2str, pint2hrstr, decode_mode_spec)
1188 (display_count_lines, display_string, draw_glyphs)
1189 (x_produce_glyphs, x_insert_glyphs)
1190 (rows_from_pos_range, mouse_face_from_buffer_pos)
1191 (fast_find_string_pos, mouse_face_from_string_pos)
1192 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1194 (safe_call, init_from_display_pos, handle_fontified_prop)
1195 (handle_single_display_spec, load_overlay_strings)
1196 (with_echo_area_buffer, setup_echo_area_for_printing)
1197 (display_echo_area, echo_area_display)
1198 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1199 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1200 (redisplay_window, dump_glyph_row, display_mode_line)
1201 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1202 (handle_display_spec, display_prop_string_p):
1203 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1204 (handle_single_display_spec, build_desired_tool_bar_string)
1205 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1206 (get_specified_cursor_type):
1207 Check that fixnums are in proper range for system types.
1208 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1209 (Flookup_image_map):
1210 Don't assume fixnums fit in int.
1211 (compare_overlay_entries):
1212 Avoid mishandling comparisons due to subtraction overflow.
1213 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1214 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1215 (handle_tool_bar_click):
1216 Use int, not unsigned, since we prefer signed and the signedness
1217 doesn't matter here.
1218 (get_next_display_element, next_element_from_display_vector):
1219 Use int, not EMACS_INT, when int is wide enough.
1220 (start_hourglass): Use duration_to_sec_usec to do proper
1221 overflow checking on durations.
1222 * xfaces.c (Fbitmap_spec_p):
1223 Check that fixnums are in proper range for system types.
1224 (compare_fonts_by_sort_order):
1225 Avoid mishandling comparisons due to subtraction overflow.
1226 (Fx_family_fonts, realize_basic_faces):
1227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1228 (Fx_family_fonts):
1229 Don't assume fixnum fits in int.
1230 Use SAFE_ALLOCA_LISP, not alloca.
1231 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1232 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1233 (face_at_buffer_position, face_for_overlay_string)
1234 (face_at_string_position):
1235 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1236 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1237 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1238 (Fx_show_tip):
1239 Check that fixnums are in proper range for system types.
1240 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1241 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1242 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1243 (Fx_change_window_property): Don't assume fixnums fit in int.
1244 * xfont.c (xfont_chars_supported):
1245 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1246 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1247 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1248 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1249 * xml.c (parse_region):
1250 * xrdb.c (magic_file_p):
1251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1252 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1253 (x_get_local_selection, x_reply_selection_request)
1254 (x_handle_selection_request, wait_for_property_change):
1255 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1256 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1257 short is wide enough.
1258 (x_send_client_event): Don't assume fixnum fits in int.
1259 * xterm.c (x_x_to_emacs_modifiers):
1260 Don't assume EMACS_INT overflows nicely into int.
1261 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1262 may come from Lisp.
1263 (handle_one_xevent): NATNUMP can eval its arg twice.
1264 (x_connection_closed):
1265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1266 * xterm.h: Adjust decls to match defn changes elsewhere.
1267 (struct scroll_bar): Use struct vectorlike_header
1268 rather than rolling our own approximation.
1269 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1271 2012-05-25 Glenn Morris <rgm@gnu.org>
1273 * lisp.mk (lisp): Update for more files being compiled now.
1275 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1277 * lread.c: Remove `read_pure' which makes no difference.
1278 (read_pure): Remove var.
1279 (unreadpure): Remove function.
1280 (readevalloop): Don't call read_list with -1 flag.
1281 (read1, read_vector): Don't test read_pure any more.
1282 (read_list): Simplify.
1284 * fileio.c, character.h: Minor style tweaks.
1286 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1288 * window.h (clip_changed): Remove useless declaration.
1290 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1292 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1293 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1295 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1297 Remove src/m/*.
1298 This directory predates autoconf and is no longer needed nowadays.
1299 Move its few remaining bits of functionality to where they're needed.
1300 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1301 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1302 * m/template.h: Remove.
1303 * Makefile.in (M_FILE): Remove. All uses removed.
1304 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1305 * lisp.h (USE_LSB_TAG):
1306 * mem-limits.h (EXCEEDS_LISP_PTR):
1307 Use VAL_MAX, not VALBITS, in #if.
1308 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1309 (EMACS_UINT): Define unconditionally now.
1310 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1311 (BITS_PER_EMACS_INT): New constants, replacing
1312 what used to be in config.h, but not useful in #if.
1313 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1314 define them any more.
1315 (VAL_MAX): New macro.
1316 (VALMASK): Use it.
1317 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1318 BITS_PER_EMACS_INT, in #if.
1319 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1320 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1321 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1322 * s/ms-w32.h (DATA_START):
1323 Move here from removed file m/intel386.h.
1324 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1325 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1327 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1329 Assume C89 or later.
1330 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1331 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1332 (xrealloc):
1333 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1334 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1335 * textprop.c, tparam.c (NULL): Remove.
1336 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1337 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1338 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1339 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1340 * xterm.c (input_signal_count): Assume volatile works.
1342 2012-05-21 Ken Brown <kbrown@cornell.edu>
1344 * xgselect.c (xg_select): Fix first argument in call to 'select'
1345 (bug#11508).
1347 2012-05-20 Ken Brown <kbrown@cornell.edu>
1349 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1350 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1352 2012-05-19 Ken Brown <kbrown@cornell.edu>
1354 * xfns.c (x_in_use): Remove `static' qualifier.
1355 * xterm.h (x_in_use): Declare.
1356 * xgselect.c: Include xterm.h.
1357 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1358 and `display_arg' (bug#9754).
1360 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1362 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1364 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1365 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1367 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1369 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1371 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1372 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1374 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1375 reference to image_cache->refcount.
1376 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1378 2012-05-17 Juri Linkov <juri@jurta.org>
1380 * search.c (Fword_search_regexp, Fword_search_backward)
1381 (Fword_search_forward, Fword_search_backward_lax)
1382 (Fword_search_forward_lax): Move functions to isearch.el
1383 (bug#10145, bug#11381).
1385 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1387 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1389 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1391 * lread.c (init_obarray): Declare Qt and Qnil as special.
1393 2012-05-14 Glenn Morris <rgm@gnu.org>
1395 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1396 Put "libexec" before "bin", for the sake of init_callproc_1.
1398 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1400 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1402 * unexaix.c: Port to more-recent AIX compilers.
1403 (report_error, report_error_1, make_hdr, copy_sym)
1404 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1405 Make arguments const char *, not char *, to avoid violations of C
1406 standard and to fix some AIX warnings reported by Gilles Pion.
1408 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1410 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1411 already have overlays loaded.
1412 (handle_single_display_spec): Before returning without displaying
1413 fringe bitmap, synchronize the bidi iterator with the main display
1414 iterator, by calling iterate_out_of_display_property.
1415 (iterate_out_of_display_property): Detect buffer iteration by
1416 testing that it->string is a Lisp string.
1417 (get_next_display_element): When the current object is exhausted,
1418 and there's something on it->stack, call set_iterator_to_next to
1419 proceed with what's on the stack, instead of returning zero.
1420 (set_iterator_to_next): If called at the end of a Lisp string,
1421 proceed to consider_string_end without incrementing string
1422 position. Don't increment display vector index past the end of
1423 the display vector. (Bug#11417)
1424 (pos_visible_p): Don't report a position visible when move_it_to
1425 stopped at the last line of window, which happens to be scanned
1426 backwards by the bidi iteration. (Bug#11464)
1428 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1430 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1431 and right-margin display specs even if the spec is invalid or we
1432 are on a TTY, and thus unable to display on the fringes.
1433 That's because the text with the property will not be displayed anyway,
1434 so we need to signal to the caller that this is a "replacing"
1435 display spec. This fixes display when the spec is invalid or we
1436 are on a TTY.
1438 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1440 * unexaix.c (make_hdr): Fix typo in prototype.
1441 This bug broke the build on AIX. Problem reported by Gilles Pion.
1443 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1445 * keyboard.c (kbd_buffer_get_event): Read special events also in
1446 batch mode. (Bug#11415)
1448 2012-05-12 Glenn Morris <rgm@gnu.org>
1450 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1452 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1454 * lisp.mk (lisp): Add newcomment.elc.
1456 2012-05-12 Glenn Morris <rgm@gnu.org>
1458 * Makefile.in (MKDIR_P): New, set by configure.
1459 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1461 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1463 Remove unused function hourglass_started.
1464 * dispextern.h (hourglass_started):
1465 * w32fns.c (hourglass_started):
1466 * xdisp.c (hourglass_started): Remove.
1468 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1470 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1471 Update dependencies.
1473 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1475 * xgselect.c (xg_select): Put maxfds+1 into a var.
1476 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1478 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1480 2012-05-10 Dave Abrahams <dave@boostpro.com>
1482 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1483 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1485 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1487 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1488 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1489 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1490 Initialize xd_registered_buses.
1492 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1494 Untag more efficiently if USE_LSB_TAG.
1495 This is based on a proposal by YAMAMOTO Mitsuharu in
1496 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1497 For an admittedly artificial (nth 8000 longlist) benchmark on
1498 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1499 Emacs's overall text size by 1%.
1500 * lisp.h (XUNTAG): New macro.
1501 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1502 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1503 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1504 * eval.c (Fautoload):
1505 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1506 * frame.h (XFRAME): Use XUNTAG.
1508 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1509 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1510 Remove unportable assumptions about print widths of types like
1511 dbus_uint32_t.
1512 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1513 intptr_t when converting between pointer and integer, to avoid GCC
1514 warnings about wrong width.
1516 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1518 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1519 stack for each reader_thread, instead of defaulting to 8MB
1520 determined by the linker. This avoids failures in creating
1521 subprocesses on Windows 7, see the discussion in this thread:
1522 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1524 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1526 Fix up display of the *Minibuf-0* buffer in the mini window.
1527 * keyboard.c (read_char): Don't clear the echo area if there's no
1528 message to clear.
1529 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1530 contents of *Minibuf-0*) if there's no message displayed in its stead.
1532 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1534 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1535 batch mode.
1537 2012-05-06 Chong Yidong <cyd@gnu.org>
1539 * lisp.mk (lisp): Update.
1541 2012-05-05 Jim Meyering <meyering@redhat.com>
1543 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1545 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1547 * data.c (PUT_ERROR): New macro.
1548 (syms_of_data): Use it. Add new error type `user-error'.
1549 * undo.c (user_error): New function.
1550 (Fprimitive_undo): Use it.
1551 * print.c (print_error_message): Adjust print style for `user-error'.
1552 * keyboard.c (user_error): New function.
1553 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1555 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1557 Do not limit current-time-string to years 1000..9999.
1558 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1559 (Fcurrent_time_string): Support any year that is supported by the
1560 underlying localtime representation. Don't use asctime, as it
1561 has undefined behavior for years outside the range -999..9999.
1563 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1565 Fix race conditions involving setenv, gmtime, localtime, asctime.
1566 Without this fix, interrupts could mess up code that uses these
1567 nonreentrant functions, since setting TZ invalidates existing
1568 tm_zone or tzname values, and since most of these functions return
1569 pointers to static storage.
1570 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1571 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1572 Grow the critical sections to include not just invoking
1573 localtime/gmtime, but also accessing these functions' results
1574 including their tm_zone values if any, and any related TZ setting.
1575 (format_time_string): Last arg is now struct tm *, not struct tm **,
1576 so that the struct tm is saved in the critical section.
1577 All callers changed. Simplify allocation of initial buffer, partly
1578 motivated by the fact that memory allocation needs to be outside
1579 the critical section.
1581 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1583 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1584 with RESET_INTERVAL.
1586 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1587 Remove duplicated buffer name initialization.
1589 2012-05-02 Jim Meyering <jim@meyering.net>
1591 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1593 * xfns.c (x_window): Use xstrdup (Bug#11375).
1595 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1597 * xdisp.c (pos_visible_p): If already at a newline from the
1598 display string before the 'while' loop, don't walk back the glyphs
1599 from it3.glyph_row. Solves assertion violation when the display
1600 string begins with a newline (egg.el). (Bug#11367)
1602 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1604 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1605 Move to simple.el.
1607 2012-05-01 Glenn Morris <rgm@gnu.org>
1609 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1610 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1611 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1612 All were removed before 23.1.
1614 * dispnew.c: Remove HAVE_LIBNCURSES test;
1615 it is always true on relevant platforms.
1617 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1618 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1620 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1622 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1624 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1625 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1626 Remove.
1628 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1630 Do not avoid creating empty evaporating overlays (Bug#9642).
1631 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1632 That is, do not delete an evaporating overlay if it becomes
1633 empty after its bounds are adjusted to fit within its buffer.
1634 This fix caused other problems, and I'm reverting it until we get
1635 to the bottom of them.
1637 2012-04-27 Chong Yidong <cyd@gnu.org>
1639 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1641 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1643 * xdisp.c (pos_visible_p): If the window start position is beyond
1644 ZV, start the display from buffer beginning. Prevents assertion
1645 violation in init_iterator when the minibuffer window is scrolled
1646 via the scroll bar.
1648 * window.c (window_scroll_pixel_based): Likewise.
1650 2012-04-27 Chong Yidong <cyd@gnu.org>
1652 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1654 2012-04-27 Glenn Morris <rgm@gnu.org>
1656 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1657 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1659 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1661 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1662 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1664 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1666 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1667 display element, check also the underlying string or buffer
1668 character. (Bug#11341)
1670 * w32menu.c: Include w32heap.h.
1671 (add_menu_item): If the call to AppendMenuW (via
1672 unicode_append_menu) fails, disable Unicode menus only if we are
1673 running on Windows 9X/Me.
1675 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1677 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1678 (xgetint): Add missing shift for LSB tags.
1680 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1682 * keyboard.c (read_char): Don't wipe echo area for select window
1683 events: These might get delayed via `mouse-autoselect-window'
1684 (Bug#11304).
1686 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1688 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1689 manipulation of :loaded-from data.
1691 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1693 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1694 now a cons (bug#11311).
1696 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1698 Do not create empty overlays with the evaporate property (Bug#9642).
1699 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1700 if it becomes empty after its bounds are adjusted to fit within
1701 its buffer. Without this fix, in a nonempty buffer (let ((o
1702 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1703 yields an empty overlay that has the evaporate property, which is
1704 not supposed to happen.
1706 Fix minor GTK3 problems found by static checking.
1707 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1708 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1709 (struct _EmacsFixedClass, emacs_fixed_get_type):
1710 Move decls here from emacsgtkfixed.h, since they needn't be public.
1711 (emacs_fixed_get_type): Now static.
1712 (emacs_fixed_class_init): Omit unused local.
1713 (emacs_fixed_child_type): Remove; unused.
1714 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1715 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1716 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1717 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1718 (EMACS_FIXED_GET_CLASS): Remove; unused.
1719 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1721 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1722 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1724 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1726 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1727 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1728 (__malloc_size_t, __malloc_ptrdiff_t):
1729 Remove. All uses removed, replaced by the definiens if needed,
1730 since we can assume C89 or better now.
1731 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1732 (protect_malloc_state, align, get_contiguous_space)
1733 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1734 (malloc_atfork_handler_child, malloc_enable_thread)
1735 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1736 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1737 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1738 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1739 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1740 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1741 Define using prototypes, not old style.
1742 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1743 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1744 (align): Don't assume that signed integer overflow wraps around.
1745 Omit unused local var.
1746 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1747 (_free_internal_nolock, memalign, mallochook, reallochook):
1748 Omit no-longer-needed casts.
1749 (valloc): Use getpagesize, not __getpagesize.
1750 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1751 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1753 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1755 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1757 Move functions from C to Lisp. Make non-blocking method calls
1758 the default. Implement further D-Bus standard interfaces.
1760 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1761 (QCdbus_request_name_allow_replacement)
1762 (QCdbus_request_name_replace_existing)
1763 (QCdbus_request_name_do_not_queue)
1764 (QCdbus_request_name_reply_primary_owner)
1765 (QCdbus_request_name_reply_in_queue)
1766 (QCdbus_request_name_reply_exists)
1767 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1768 (QCdbus_registered_serial, QCdbus_registered_method)
1769 (QCdbus_registered_signal): New Lisp objects.
1770 (XD_DEBUG_MESSAGE): Use sizeof.
1771 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1772 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1773 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1774 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1775 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1776 (xd_signature, xd_append_arg): Allow float for integer types.
1777 (xd_get_connection_references): New function.
1778 (xd_get_connection_address): Rename from xd_initialize.
1779 Return cached address.
1780 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1781 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1782 level.
1783 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1784 Return number of refcounts.
1785 (Fdbus_get_unique_name): Make stronger parameter check.
1786 (Fdbus_message_internal): New defun.
1787 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1788 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1789 (Fdbus_send_signal, Fdbus_register_service)
1790 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1791 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1792 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1793 (Vdbus_compiled_version, Vdbus_runtime_version)
1794 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1795 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1796 (Vdbus_message_type_signal): New defvars.
1797 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1798 Adapt docstring.
1800 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1802 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1803 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1804 Do not assume ptrdiff_t is the same width as 'int'.
1806 * alloc.c: Handle unusual debugging option combinations.
1807 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1808 since the two debugging options are incompatible.
1809 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1810 is defined.
1811 (mem_init, mem_insert, mem_insert_fixup):
1812 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1813 (NEED_MEM_INSERT): Remove; no longer needed.
1815 2012-04-22 Leo Liu <sdl.web@gmail.com>
1817 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1819 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1821 * sysdep.c [__FreeBSD__]: Minor cleanups.
1822 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1823 Use Emacs indenting style more consistently. Avoid some casts.
1824 Use 'double' consistently rather than mixing 'float' and 'double'.
1826 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1828 * sysdep.c (list_system_processes, system_process_attributes):
1829 Add implementation for FreeBSD (Bug#5243).
1831 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1833 * lisp.mk (lisp): Update.
1835 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1837 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1838 It is never used otherwise.
1840 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1842 * print.c (print_preprocess): Only check print_depth if print-circle
1843 is nil.
1844 (print_object): Check for cycles even when print-circle is nil and
1845 print-gensym is t, but only check print_depth if print-circle is nil.
1847 2012-04-20 Chong Yidong <cyd@gnu.org>
1849 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1850 set the status to "failed" and ensure that sentinel is run.
1852 2012-04-20 Glenn Morris <rgm@gnu.org>
1854 * process.c (Fset_process_inherit_coding_system_flag)
1855 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1856 (Fmake_network_process, Fmake_serial_process): Doc fix.
1858 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1860 * xdisp.c (string_buffer_position_lim): Limit starting position to
1861 BEGV.
1862 (set_cursor_from_row): If called for a mode-line or header-line
1863 row, return zero immediately.
1864 (try_cursor_movement): If inside continuation line, don't back up
1865 farther than the first row after the header line, if any.
1866 Don't consider the header-line row as "partially visible", even if
1867 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1869 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1871 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1872 (bug#11238).
1874 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1875 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1877 configure: new option --enable-gcc-warnings (Bug#11207)
1878 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1879 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1880 (ALL_CFLAGS): Use new macros rather than old.
1881 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1882 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1883 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1884 -Wunused-result, -Wunused-variable. This should go away once
1885 the Emacs and Gnulib regex code is merged.
1886 (xmalloc, xrealloc): Now static.
1888 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1890 * dired.c (Fsystem_groups): Remove unused local.
1892 2012-04-17 Glenn Morris <rgm@gnu.org>
1894 * dired.c (Fsystem_users): Doc fix.
1896 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1898 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1899 (syms_of_dired): Add them.
1901 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1903 Fix minor alloc.c problems found by static checking.
1904 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1905 New extern decls, to avoid calling undeclared functions.
1906 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1907 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1908 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1909 (NEED_MEM_INSERT): New macro.
1910 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1911 Remove one incorrect comment and fix another.
1913 Fix minor ralloc.c problems found by static checking.
1914 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1915 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1916 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1917 (r_alloc_sbrk): Now static.
1919 Improve ralloc.c interface checking.
1920 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1921 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1922 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1923 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1924 [REL_ALLOC]: ... to here, to check interface.
1925 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1926 Remove decls. This fixes an "It stinks!".
1928 * alloc.c (which_symbols): Fix alignment issue / type clash.
1930 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1932 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1933 (struct Lisp_Misc_Any): Likewise.
1934 (struct Lisp_Free): Likewise.
1935 * alloc.c (union aligned_Lisp_Symbol): Define.
1936 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1937 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1938 (union aligned_Lisp_Misc): Define.
1939 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1940 aligned_Lisp_Misc instead of union Lisp_Misc.
1941 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1943 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1945 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1946 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1947 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1948 * s/netbsd.h, s/sol2-6.h:
1949 Remove definition of GC_MARK_STACK, since the default now works.
1950 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1951 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1952 no longer the default.
1953 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1955 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1957 * lread.c (lisp_file_lexically_bound_p):
1958 Fix hang at ";-*-\n" (bug#11238).
1960 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1962 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1963 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1965 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1967 * nsterm.m (constrainFrameRect): Always constrain when there is only
1968 one screen (Bug#10962).
1970 2012-04-13 Ken Brown <kbrown@cornell.edu>
1972 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1974 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1976 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1978 2012-04-11 Daniel Colascione <dancol@dancol.org>
1980 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1981 against is gone. It's better to use vfork now so that when Cygwin
1982 gains a new, working vfork, we use it automatically (bug#10398).
1984 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1986 * window.c (save_window_save): Obey window-point-insertion-type.
1988 2012-04-11 Glenn Morris <rgm@gnu.org>
1990 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1992 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1994 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1996 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1998 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1999 (force_quit_count): New var.
2000 (handle_interrupt): Use it.
2002 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2004 * w32.c (w32_delayed_load): Record the full path of the library
2005 being loaded (bug#10424).
2007 2012-04-09 Glenn Morris <rgm@gnu.org>
2009 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2010 not just in the obarray, before snarfing them. (Bug#11036)
2012 * Makefile.in ($(leimdir)/leim-list.el):
2013 Pass EMACS rather than BUILT_EMACS.
2015 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2017 * process.c (make_process):
2018 * process.h: Add integer `gnutls_handshakes_tried' member to
2019 process struct.
2021 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2022 Add convenience `GNUTLS_LOG2i' macro.
2024 * gnutls.c (gnutls_log_function2i): Convenience log function.
2025 (emacs_gnutls_read): Use new log functions,
2026 `gnutls_handshakes_tried' process member, and
2027 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2028 attempts per process (connection).
2030 2012-04-09 Chong Yidong <cyd@gnu.org>
2032 * eval.c (Fuser_variable_p, user_variable_p_eh)
2033 (lisp_indirect_variable): Functions deleted.
2034 (Fdefvar): Caller changed.
2036 * callint.c (Finteractive, Fcall_interactively):
2037 * minibuf.c (Fread_variable): Callers changed.
2039 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2041 * xdisp.c (set_cursor_from_row): If the display string appears in
2042 the buffer at position that is closer to point than the position
2043 after the display string, display the cursor on the first glyph of
2044 the display string. Fixes cursor display when a 'display' text
2045 property immediately follows invisible text. (Bug#11094)
2047 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2049 composite.c: use 'double' consistently
2050 * composite.c (get_composition_id): Use 'double' consistently
2051 instead of converting 'float' to 'double' and vice versa; this is
2052 easier to understand and avoids a GCC warning.
2054 2012-04-09 Glenn Morris <rgm@gnu.org>
2056 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2057 preparation for dumping it with emacs. (Bug#4789)
2058 (leimdir): New variable.
2059 ($(leimdir)/leim-list.el): New rule.
2060 (emacs$(EXEEXT)): Depend on leim-list.el.
2062 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2063 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2064 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2066 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2068 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2069 proper alignment.
2071 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2073 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2074 Remove unused local variable.
2076 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2078 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2079 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2080 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2081 objects, as mark_maybe_pointer will catch them otherwise.
2082 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2083 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2085 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2087 Fix typo that broke non-Windows builds.
2088 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2090 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2092 Support building on MS-Windows with libxml2.
2094 * makefile.w32-in (OBJ2): Add xml.$(O).
2095 (GLOBAL_SOURCES): Add xml.c.
2096 ($(BLD)/xml.$(O)): New dependency list.
2098 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2099 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2100 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2101 [!WINDOWSNT]: New macros.
2102 (init_libxml2_functions, libxml2_loaded_p): New functions.
2103 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2104 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2105 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2106 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2107 linked in).
2108 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2109 Call init_libxml2_functions before calling libxml2 functions.
2110 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2112 * emacs.c: Don't include libxml/parser.h.
2113 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2114 xmlCleanupParser directly.
2116 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2118 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2120 * indent.c (Fvertical_motion): If there is a display string at
2121 point, use it.vpos to compute how many lines to backtrack after
2122 move_it_to point. (Bug#11133)
2124 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2126 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2127 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2128 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2129 macros related to unification of CJK characters. For the details,
2130 see the discussion following the message here:
2131 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2133 2012-04-04 Chong Yidong <cyd@gnu.org>
2135 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2137 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2139 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2140 instead of alloca. (Bug#11138)
2142 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2144 * w32menu.c (is_simple_dialog): Properly check lisp types.
2145 (Bug#11141)
2147 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2149 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2150 position we get to after a call to move_it_to fails the
2151 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2152 only if we wind up in a string from display property. (Bug#11063)
2154 * window.c (Fdelete_other_windows_internal): Invalidate the row
2155 and column information about mouse highlight, so that redisplay
2156 restores it after reallocating the glyph matrices. (Bug#7464)
2158 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2159 string comes from a `display' text property, use the buffer
2160 position of that property as if we actually saw that position in
2161 the row's glyphs.
2162 (move_it_by_lines): Remove the assertion that
2163 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2164 violated when there's a before-string at the beginning of a line.
2165 (Bug#11063)
2167 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2169 * xdisp.c (append_space_for_newline): If the default face was
2170 remapped, use the remapped face for the appended newline.
2171 (extend_face_to_end_of_line): Use the remapped default face for
2172 extending the face to the end of the line.
2173 (display_line): Call extend_face_to_end_of_line when the default
2174 face was remapped. (Bug#11068)
2176 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2178 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2180 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2182 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2184 2012-03-27 Glenn Morris <rgm@gnu.org>
2186 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2187 Doc fixes.
2189 2012-03-26 Kenichi Handa <handa@m17n.org>
2191 * dispextern.h (struct glyph): Fix previous change. Change the
2192 bit length of glyphless.ch to 25 (Bug#11082).
2194 2012-03-26 Chong Yidong <cyd@gnu.org>
2196 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2197 (command_loop_1): Use it; inhibit selection update for
2198 handle-select-window too (Bug#8996).
2200 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2202 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2204 2012-03-25 Kenichi Handa <handa@m17n.org>
2206 * dispextern.h (struct glyph): Change the bit length of
2207 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2209 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2211 * s/ms-w32.h (tzname): Include time.h before redirecting to
2212 _tzname. Fixes the MSVC build. (Bug#9960)
2214 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2216 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2217 characters.
2219 * xterm.c (XTread_socket): Only modify handling_signal if
2220 !SYNC_INPUT. (Bug#11080)
2222 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2224 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2225 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2226 when fetching a multibyte character consumes more bytes than
2227 CHAR_BYTES returns, due to unification of CJK characters in
2228 string_char. (Bug#11073)
2230 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2232 * process.c (wait_reading_process_output): Handle pty disconnect
2233 by refraining from sending oneself a SIGCHLD (bug#10933).
2235 2012-03-22 Chong Yidong <cyd@gnu.org>
2237 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2239 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2240 Mark string as coming from a prefix property.
2241 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2242 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2244 2012-03-21 Chong Yidong <cyd@gnu.org>
2246 * xfaces.c (Vface_remapping_alist): Doc fix.
2248 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2250 * w32proc.c (Fw32_set_console_codepage)
2251 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2252 Doc fixes.
2254 2012-03-20 Chong Yidong <cyd@gnu.org>
2256 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2257 to reflect default non-nil value of redisplay-dont-pause.
2259 2012-03-19 Kenichi Handa <handa@m17n.org>
2261 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2262 it fit in a valid range (Bug#11003).
2264 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2266 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2267 that is not from display property, accept the row as a "cursor
2268 row" if one of the string's character has a non-nil `cursor'
2269 property. Fixes cursor positioning when there are newlines in
2270 overlay strings, e.g. in icomplete.el. (Bug#11035)
2272 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2274 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2276 2012-03-12 Chong Yidong <cyd@gnu.org>
2278 * eval.c (inhibit_lisp_code): Rename from
2279 inhibit_window_configuration_change_hook; move from window.c.
2281 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2282 * window.c (run_window_configuration_change_hook)
2283 (syms_of_window): Callers changed.
2285 2012-03-11 Chong Yidong <cyd@gnu.org>
2287 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2289 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2291 2012-03-10 Chong Yidong <cyd@gnu.org>
2293 * frame.c (other_visible_frames): Don't assume the selected frame
2294 is visible (Bug#10955).
2296 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2298 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2300 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2302 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2303 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2304 zero (Bug#10954).
2306 2012-03-03 Glenn Morris <rgm@gnu.org>
2308 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2310 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2312 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2313 position past the first glyph_row that ends at ZV. (Bug#10902)
2314 (redisplay_window, next_element_from_string): Fix typos in
2315 comments.
2316 (redisplay_window): Pass to move_it_vertically the margin in
2317 pixels, not in screen lines.
2319 2012-03-02 Glenn Morris <rgm@gnu.org>
2321 * buffer.c (buffer-list-update-hook): Doc fix.
2323 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2325 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2326 push_it before setting up the iterator for the first overlay
2327 string, even if we have an empty string loaded.
2328 (next_overlay_string): If there's an empty string on the iterator
2329 stack, pop the stack. (Bug#10903)
2331 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2333 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2334 Suggested by Stefan Monnier in
2335 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2336 * alloc.c (widen_to_Lisp_Object): New static function.
2337 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2338 and widening them to Lisp_Objects. This would work even if
2339 USE_LSB_TAG is defined and wide integers are used, which might
2340 happen in a future version of Emacs.
2342 2012-02-25 Chong Yidong <cyd@gnu.org>
2344 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2345 Doc fix.
2347 * xselect.c (Fx_selection_exists_p): Doc fix.
2348 (x_clipboard_manager_save_all): Print an informative message
2349 before saving to clipboard manager.
2351 2012-02-24 Chong Yidong <cyd@gnu.org>
2353 * keyboard.c (process_special_events): Handle all X selection
2354 requests in kbd_buffer, not just the next one (Bug#8869).
2356 2012-02-23 Chong Yidong <cyd@gnu.org>
2358 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2359 call when setting menu-bar-lines and tool-bar-lines parameters.
2360 (unwind_create_frame_1): New helper function.
2362 * window.c (inhibit_window_configuration_change_hook): New var.
2363 (run_window_configuration_change_hook): Obey it.
2364 (syms_of_window): Initialize it.
2366 2012-02-22 Chong Yidong <cyd@gnu.org>
2368 * xterm.c (x_draw_image_relief): Add missing type check for
2369 Vtool_bar_button_margin (Bug#10743).
2371 2012-02-21 Chong Yidong <cyd@gnu.org>
2373 * fileio.c (Vfile_name_handler_alist): Doc fix.
2375 * buffer.c (Fget_file_buffer): Protect against invalid file
2376 handler return value.
2378 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2380 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2381 when computing $valmask.
2383 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2384 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2385 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2386 It's useless in that case, and it can cause problems on hosts
2387 that allocate halves of EMACS_INT values separately.
2388 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2389 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2390 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2391 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2392 it avoids undefined behavior on hosts where shifting right by more
2393 than the word width has undefined behavior.
2395 2012-02-19 Chong Yidong <cyd@gnu.org>
2397 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2398 (Funhandled_file_name_directory, Ffile_name_as_directory)
2399 (Fdirectory_file_name, Fexpand_file_name)
2400 (Fsubstitute_in_file_name): Protect against invalid file handler
2401 return values (Bug#10845).
2403 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2405 * .gdbinit (pitx): Fix incorrect references to fields of the
2406 iterator stack.
2408 2012-02-17 Chong Yidong <cyd@gnu.org>
2410 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2412 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2414 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2415 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2417 2012-02-15 Chong Yidong <cyd@gnu.org>
2419 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2420 marked as special. Also, starting docstrings with * is obsolete.
2422 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2424 * gnutls.c (emacs_gnutls_write): Fix last change.
2426 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2428 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2429 send_process.
2431 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2433 * keymap.c (Fsingle_key_description): Handle char ranges.
2435 2012-02-12 Chong Yidong <cyd@gnu.org>
2437 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2438 as that creates a dangerous corner case.
2440 * window.c (Fdelete_window_internal): Invalidate the mouse
2441 highlight (Bug#9904).
2443 2012-02-12 Glenn Morris <rgm@gnu.org>
2445 * xselect.c (Fx_own_selection_internal)
2446 (Fx_get_selection_internal, Fx_disown_selection_internal)
2447 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2448 * nsselect.m (Fx_own_selection_internal)
2449 (Fx_disown_selection_internal, Fx_selection_exists_p)
2450 (Fx_selection_owner_p, Fx_get_selection_internal):
2451 Sync docs and argument specs with the xselect.c versions.
2453 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2455 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2457 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2459 * w32select.c (Fx_selection_exists_p): Sync doc string and
2460 argument list with xselect.c. (Bug#10783)
2462 * w16select.c (Fx_selection_exists_p): Sync doc string and
2463 argument list with xselect.c. (Bug#10783)
2465 2012-02-10 Glenn Morris <rgm@gnu.org>
2467 * fns.c (Fsecure_hash): Doc fix.
2469 2012-02-09 Kenichi Handa <handa@m17n.org>
2471 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2473 2012-02-07 Chong Yidong <cyd@gnu.org>
2475 * buffer.c (Fbuffer_local_variables)
2476 (buffer_lisp_local_variables): Handle unbound vars correctly;
2477 don't let Qunbound leak into Lisp.
2479 2012-02-07 Glenn Morris <rgm@gnu.org>
2481 * image.c (Fimagemagick_types): Doc fix.
2483 * image.c (imagemagick-render-type): Change it from a lisp object
2484 to an integer. Move the doc here from the lisp manual.
2485 Treat all values not equal to 0 the same.
2487 2012-02-06 Chong Yidong <cyd@gnu.org>
2489 * doc.c (store_function_docstring): Avoid applying docstring of
2490 alias to base function (Bug#2603).
2492 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2494 * .gdbinit (pp1, pv1): Remove redundant defines.
2495 (pr): Use pp.
2497 2012-02-04 Chong Yidong <cyd@gnu.org>
2499 * nsterm.m: Declare a global (Bug#10694).
2501 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2503 * w32.c (get_emacs_configuration_options):
2504 Include --enable-checking, if specified, in the return value.
2506 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2508 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2509 after rounding frame sizes. (Bug#9723)
2511 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2513 * keyboard.c (adjust_point_for_property): Don't position point
2514 before BEGV. (Bug#10696)
2516 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2518 Handle overflow when computing char display width (Bug#9496).
2519 * character.c (char_width): Return EMACS_INT, not int.
2520 (char_width, c_string_width): Check for overflow when
2521 computing the width; this is possible now that individual
2522 characters can have unbounded width. Problem introduced
2523 by merge from Emacs 23 on 2012-01-19.
2525 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2527 * dbusbind.c (Fdbus_register_method): Mention the return value
2528 :ignore in the docstring.
2530 2012-02-02 Glenn Morris <rgm@gnu.org>
2532 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2534 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2535 Unconditionally set to t. (Bug#10673)
2536 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2537 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2538 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2540 2012-02-02 Kenichi Handa <handa@m17n.org>
2542 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2543 0, do not call append_composite_glyph.
2545 2012-02-02 Kenichi Handa <handa@m17n.org>
2547 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2548 NULL (Bug#6988).
2549 (x_produce_glyphs): If the component of a composition is a null
2550 string, set it->pixel_width to 1 to avoid zero-width glyph.
2552 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2554 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2555 first 2 arguments are identical. This makes inserting large
2556 output from a subprocess an order of magnitude faster on
2557 MS-Windows, where all sbrk'ed memory is always contiguous.
2559 2012-01-31 Glenn Morris <rgm@gnu.org>
2561 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2562 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2563 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2565 2012-01-29 Glenn Morris <rgm@gnu.org>
2567 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2569 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2571 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2573 2012-01-28 Chong Yidong <cyd@gnu.org>
2575 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2577 2012-01-26 Chong Yidong <cyd@gnu.org>
2579 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2581 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2582 repeat counts (Bug#10507).
2584 2012-01-26 Glenn Morris <rgm@gnu.org>
2586 * lread.c (syms_of_lread): Doc fix.
2588 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2590 * coding.c (encode_designation_at_bol): Change return value to
2591 EMACS_INT.
2593 2012-01-25 Chong Yidong <cyd@gnu.org>
2595 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2597 2012-01-21 Chong Yidong <cyd@gnu.org>
2599 * floatfns.c (Fcopysign): Make the second argument non-optional,
2600 since nil is not allowed anyway.
2602 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2604 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2605 (send_process): Likewise.
2607 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2609 * window.c (save_window_save, Fcurrent_window_configuration)
2610 (Vwindow_persistent_parameters): Do not use Qstate.
2611 Rewrite doc-strings.
2613 2012-01-19 Kenichi Handa <handa@m17n.org>
2615 * character.c (char_width): New function.
2616 (Fchar_width, c_string_width, lisp_string_width):
2617 Use char_width (Bug#9496).
2619 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2621 * window.c (Vwindow_persistent_parameters): New variable.
2622 (Fset_window_configuration, save_window_save): Handle persistent
2623 window parameters.
2625 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2627 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2628 thrashing the stack of the thread. (Bug#9087)
2630 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2632 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2634 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2636 * xdisp.c (rows_from_pos_range): Handle the case where the
2637 highlight ends on a newline. (Bug#10464)
2638 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2639 he end column for display of highlight that ends on a newline
2640 before a R2L line.
2642 2012-01-11 Glenn Morris <rgm@gnu.org>
2644 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2645 from load-path also when installation-directory is nil. (Bug#10208)
2647 2012-01-10 Glenn Morris <rgm@gnu.org>
2649 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2651 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2652 Update template values to be closer to their typical values these days.
2654 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2656 * xdisp.c (rows_from_pos_range): Accept additional argument
2657 DISP_STRING, and accept any glyph in a row whose object is that
2658 string as eligible for mouse highlight. Fixes mouse highlight of
2659 display strings from overlays. (Bug#10464)
2661 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2663 emacs: fix an auto-save permissions race condition (Bug#10400)
2664 * fileio.c (auto_saving_dir_umask): New static var.
2665 (Fmake_directory_internal): Use it.
2666 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2667 creating the directory. The old code temporarily assigns
2668 too-generous permissions to the directory.
2669 (do_auto_save_eh): Clear it.
2670 (Fdo_auto_save): Catch all errors, not just file errors, so
2671 that the var is always cleared.
2673 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2675 * search.c (scan_buffer): Pass character positions to
2676 know_region_cache, not byte positions. (Bug#6540)
2678 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2680 * w32.c (sys_rename): Report EXDEV when rename of a directory
2681 fails because the target is on another logical disk. (Bug#10284)
2683 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2685 * xterm.c (x_embed_request_focus): New function.
2687 * xterm.h: Add prototype.
2689 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2691 2012-01-05 Glenn Morris <rgm@gnu.org>
2693 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2695 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2697 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2698 Load gnutls_transport_set_lowat only if GnuTLS version is below
2699 2.11.1.
2700 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2701 GnuTLS versions below 2.11.1.
2703 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2705 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2706 to the doc string advising against its use for altering the way
2707 windows are scrolled.
2709 2011-12-28 Kenichi Handa <handa@m17n.org>
2711 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2712 coding-system ASCII compatible only when it does not produce BOM
2713 on encoding (Bug#10383).
2715 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2717 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2718 can scroll.
2719 (create_and_show_popup_menu): Always use menu_position_func for
2720 Gtk3 (Bug#10361).
2722 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2724 * callint.c (Fcall_interactively): Don't truncate prompt string.
2726 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2728 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2729 property that ends at ZV, so that the bidi iteration could be
2730 resumed from there (after widening). (Bug#10360)
2732 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2734 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2736 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2738 * nsterm.m (x_free_frame_resources):
2739 Release f->output_data.ns->miniimage.
2740 (ns_index_color): Fix indentation. Do not retain
2741 color_table->colors[i].
2743 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2744 before returning.
2746 * nsfns.m (x_set_background_color): Assign return value from
2747 ns_index_color to face-background instead of NSColor*.
2748 (ns_implicitly_set_icon_type): Fix indentation.
2749 Change assignment in for loop to comparison.
2751 * emacs.c (ns_pool): New variable.
2752 (main): Assign ns_pool.
2753 (Fkill_emacs): Call ns_release_autorelease_pool.
2755 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2756 autorelease fdesc, release fdAttrs and tdict.
2757 (ns_get_covering_families): Release charset.
2758 (ns_findfonts): Release NSFontDescriptor created with new.
2759 (ns_uni_to_glyphs): Fix indentation.
2760 (setString): Release attrStr before assigning new value.
2762 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2764 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2765 and NS_IMPL_COCOA.
2766 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2767 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2769 2011-12-18 David Reitter <reitter@cmu.edu>
2771 * nsterm.m (ns_term_init): Subscribe for notifications
2772 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2773 to method trackingNotification in EmacsMenu.
2775 * nsmenu.m (trackingMenu): New variable.
2776 (trackingNotification): New method (from Aquamacs).
2777 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2778 from Aquamacs (Bug#7030).
2780 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2782 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2783 (symbol_to_nsstring): Fix indentation.
2784 (ns_symbol_to_pb): New function.
2785 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2786 (Fns_rotate_cut_buffers_internal): Remove.
2787 (Fns_store_selection_internal): Rename from
2788 Fns_store_cut_buffer_internal.
2789 (ns_get_foreign_selection, Fx_own_selection_internal)
2790 (Fx_disown_selection_internal, Fx_selection_exists_p)
2791 (Fns_get_selection_internal, Fns_store_selection_internal):
2792 Use ns_symbol_to_pb and check if return value is nil.
2793 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2794 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2795 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2796 renamed to Sns_store_selection_internal.
2797 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2798 and remove this function.
2799 (ns_handle_selection_clear): Remove, never used.
2800 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2801 here.
2803 2011-12-17 Ken Brown <kbrown@cornell.edu>
2805 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2806 GID is unknown (Bug#10257).
2808 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2810 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2811 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2812 which caused a build failure on GNU/Linux IA-64. This problem was
2813 introduced by my 2011-10-07 patch.
2815 2011-12-15 Juri Linkov <juri@jurta.org>
2817 * image.c (imagemagick_error): New function. (Bug#10112)
2818 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2819 Use `imagemagick_error' where ImageMagick functions return
2820 `MagickFalse'.
2821 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2822 proper order.
2824 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2826 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2827 fill background (Bug#8992).
2829 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2831 * window.c (Vwindow_combination_resize)
2832 (Vwindow_combination_limit): Use t instead of non-nil in
2833 doc-strings.
2834 (Vrecenter_redisplay): Add first sentence of doc-string on
2835 separate line.
2836 (Frecenter): Fix doc-string typo.
2838 2011-12-11 Kenichi Handa <handa@m17n.org>
2840 * coding.c (Funencodable_char_position): Pay attention to the
2841 buffer text relocation (Bug#9389).
2843 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2845 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2846 gtk_init (Bug#10100).
2848 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2850 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2851 IT->string is nil. (Bug#10263)
2853 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2855 * nsterm.h (x_free_frame_resources): Declare.
2857 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2858 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2860 * nsterm.h (ns_get_defaults_value): Declare.
2862 * nsterm.m (ns_default): Call ns_get_defaults_value.
2864 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2866 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2867 (Bug#10170)
2869 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2871 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2872 that where the value of an _OBJC_* symbol points to is in the .bss
2873 section (Bug#10240).
2875 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2877 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2878 after the loop to call ccl_driver at least once (Bug#8619).
2880 2011-12-08 Kenichi Handa <handa@m17n.org>
2882 * ftfont.c (get_adstyle_property): Fix previous change
2883 (Bug#10233).
2885 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2887 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2888 dirs from the default value of EMACSLOADPATH (bug#10208).
2890 2011-12-07 Glenn Morris <rgm@gnu.org>
2892 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2893 installation and source directories as well. (Bug#10208)
2895 2011-12-06 Chong Yidong <cyd@gnu.org>
2897 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2899 2011-12-06 Glenn Morris <rgm@gnu.org>
2901 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2902 as an error, not just -1. (Bug#10217)
2904 2011-12-05 Chong Yidong <cyd@gnu.org>
2906 * keyboard.c (process_special_events): New function.
2907 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2909 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2911 * coding.c (encode_designation_at_bol): Don't use uninitialized
2912 local variable (Bug#9318).
2914 2011-12-05 Kenichi Handa <handa@m17n.org>
2916 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2917 return Qnil (Bug#8046, Bug#10193).
2919 2011-12-05 Kenichi Handa <handa@m17n.org>
2921 * coding.c (encode_designation_at_bol): New args charbuf_end and
2922 dst. Return the number of produced bytes. Callers changed.
2923 (coding_set_source): Return how many bytes coding->source was
2924 relocated.
2925 (coding_set_destination): Return how many bytes
2926 coding->destination was relocated.
2927 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2928 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2930 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2932 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2933 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2934 macro (Bug#9318).
2936 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2938 The following changes are to fix Bug#9318.
2940 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2941 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2942 (encode_coding_iso_2022, encode_coding_sjis)
2943 (encode_coding_big5, encode_coding_charset): Use the above macros.
2945 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2947 * lisp.h (process_quit_flag): Fix external declaration.
2949 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2951 Don't macro-inline non-performance-critical code.
2952 * eval.c (process_quit_flag): New function.
2953 * lisp.h (QUIT): Use it.
2955 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2957 * nsfns.m (get_geometry_from_preferences): New function.
2958 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2960 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2962 * emacs.c (Qkill_emacs): Define.
2963 (syms_of_emacs): Initialize it.
2964 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2965 Qquit_flag to `kill-emacs' instead.
2966 (quit_throw_to_read_char): Add parameter `from_signal'.
2967 All callers changed. Call Fkill_emacs if requested and safe.
2968 * lisp.h (QUIT): Call Fkill_emacs if requested.
2970 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2972 * widget.c (update_wm_hints): Return if wmshell is null.
2973 (widget_update_wm_size_hints): New function.
2975 * widget.h (widget_update_wm_size_hints): Declare.
2977 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2978 widget_update_wm_size_hints (Bug#10104).
2980 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2982 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2983 before a newline, prepare the bidi iterator for consuming the
2984 newline, and keep the current paragraph direction. (Bug#10183)
2985 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2987 2011-12-02 Juri Linkov <juri@jurta.org>
2989 * search.c (Fword_search_regexp): New Lisp function created from
2990 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2991 (Fword_search_backward, Fword_search_forward)
2992 (Fword_search_backward_lax, Fword_search_forward_lax):
2993 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2994 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2996 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2998 * fileio.c (Finsert_file_contents): Move after-change-function call
2999 to before the "handled:" label, since all "goto handled" appear in
3000 cases where the *-change-functions have already been properly called
3001 (bug#10117).
3003 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3005 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3006 waiting for input. (Bug#10169)
3008 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3010 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3011 verifies glyph row's hash code--we have just reallocated the
3012 glyphs, so their contents can be complete garbage. (Bug#10164)
3014 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3016 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3018 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3020 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3021 attributes are tested _before_ calling verify_row_hash, to protect
3022 against GCC re-ordering of the tests. (Bug#10164)
3024 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3026 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3028 * xterm.c (handle_one_xevent): Only set async_visible and friends
3029 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3030 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3031 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3033 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3035 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3036 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3037 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3038 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3039 All uses changed to use GCPRO1 etc.
3040 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3041 Revert to old implementation (i.e., before 2011-03-11).
3043 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3045 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3046 of scroll runs so as to avoid assigning disabled bogus rows and
3047 unnecessary graphics copy operations.
3049 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3051 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3052 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3053 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3054 (malloc, free, realloc, calloc): Redirect to e_* only when
3055 compiling Emacs.
3057 * lisp.h (GCTYPEBITS): Move before first use.
3058 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3059 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3060 this macro definition.
3062 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3063 _MSC_VER.
3065 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3067 * gtkutil.c (xg_create_frame_widgets):
3068 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3069 present with Gtk+ 2.0.
3071 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3073 * fileio.c (Finsert_file_contents): Undo previous change; see
3074 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3076 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3078 Rename locals to avoid shadowing.
3079 * fileio.c (Finsert_file_contents):
3080 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3081 * process.c (wait_reading_process_output):
3082 Rename inner 'proc' to 'p' to avoid shadowing.
3083 Indent for consistency with usual Emacs style.
3085 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3087 * xdisp.c (redisplay_window): If cursor row is not fully visible
3088 after recentering, and scroll-conservatively is set to a large
3089 number, scroll window by a few more lines to make the cursor fully
3090 visible and out of scroll-margin. (Bug#10105)
3091 (start_display): Don't move to the next line if the display should
3092 start at a newline that is part of a display vector or an overlay
3093 string. (Bug#10119)
3095 2011-11-24 Juri Linkov <juri@jurta.org>
3097 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3098 after the `MagickPingImage' call. (Bug#10112)
3100 2011-11-23 Chong Yidong <cyd@gnu.org>
3102 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3104 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3106 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3107 making another buffer current. (Bug#10114)
3109 2011-11-23 Glenn Morris <rgm@gnu.org>
3111 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3113 2011-11-23 Chong Yidong <cyd@gnu.org>
3115 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3116 using it (Bug#5984).
3118 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3120 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3121 and header-lines, as they don't have one computed for them.
3122 (Bug#10098)
3124 * .gdbinit (prow): Make displayed values more self-explaining.
3125 Add row's hash code.
3127 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3129 * process.c (wait_reading_process_output): Fix asynchrounous
3130 GnuTLS socket handling on some versions of the GnuTLS library.
3131 (wait_reading_process_output): Add comment and URL.
3133 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3135 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3137 2011-11-21 Chong Yidong <cyd@gnu.org>
3139 * window.c (Fnext_window, Fprevious_window): Doc fix.
3141 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3143 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3145 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3147 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3149 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3151 * window.c (Fset_window_combination_limit): Rename argument
3152 STATUS to LIMIT.
3153 (Vwindow_combination_limit): Remove "status" from doc-string.
3155 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3157 * m/ibms390.h: Remove.
3158 * m/ibms390x.h: Don't include "ibms390.h".
3160 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3162 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3163 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3165 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3167 * casetab.c (Fset_case_table):
3168 * charset.c (Fcharset_after): Fix typos.
3170 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3172 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3173 Otherwise, valgrind does not work on some platforms.
3174 Problem reported by Andreas Schwab in
3175 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3176 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3177 is set, removing the need for VIRT_ADDRESS_VARIES.
3178 (PURE_P): Use a more-efficient implementation that needs just one
3179 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3180 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3181 to 4 (xorl, subq, cmpq, setbe).
3182 * alloc.c (pure): Always extern now, since that's the
3183 VIRT_ADDR_VARIES behavior.
3184 (PURE_POINTER_P): Use a single comparison, not two, for
3185 consistency with the new puresize.h.
3186 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3187 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3188 Remove VIRT_ADDR_VARIES no longer needed.
3190 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3192 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3193 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3194 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3195 behave as if the cursor position were at the window margin.
3197 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3198 and the cursor position is out of bounds, behave as if the cursor
3199 position were at the window margin. (Bug#10075)
3201 2011-11-18 Chong Yidong <cyd@gnu.org>
3203 * window.c (Fwindow_combination_limit): Make first argument
3204 non-optional, since it is meaningless for live windows like the
3205 selected window.
3207 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3209 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3211 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3213 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3214 (graft_intervals_into_buffer): Simplify.
3216 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3218 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3219 hash values of the two rows.
3220 (copy_row_except_pointers): Preserve the used[] arrays and the
3221 hash values of the two rows. (Bug#10035)
3222 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3224 * xdisp.c (row_hash): New function, body extracted from
3225 compute_line_metrics.
3226 (compute_line_metrics): Call row_hash, instead of computing the
3227 hash code inline.
3229 * dispnew.c (verify_row_hash): Call row_hash for computing the
3230 hash code of a row, instead of duplicating code from xdisp.c.
3232 * dispextern.h (row_hash): Add prototype.
3234 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3236 * frame.c (delete_frame): Don't delete the terminal when the last
3237 X frame is closed if emacs is built with GTK toolkit.
3239 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3241 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3243 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3245 * window.c (Vwindow_splits): Rename to
3246 Vwindow_combination_resize. Suggested by Juri Linkov.
3247 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3248 of Vwindow_splits.
3250 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3252 * nsfns.m (Fns_font_name):
3253 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3255 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3257 * window.h (window): Rename slot "nest" to "combination_limit".
3258 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3259 (Fset_window_nest): Rename to Fset_window_combination_limit.
3260 (Vwindow_nest): Rename to Vwindow_combination_limit.
3261 (recombine_windows, make_parent_window, make_window)
3262 (Fsplit_window_internal, saved_window)
3263 (Fset_window_configuration, save_window_save): Rename all
3264 occurrences of window_nest to window_combination_limit.
3266 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3268 * image.c (imagemagick_load_image): Fix typo.
3270 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3272 * xdisp.c (display_line): Move the call to
3273 highlight_trailing_whitespace before the call to
3274 compute_line_metrics, since the latter needs to see the final
3275 faces of all the glyphs to compute ROW's hash value.
3276 Fixes assertion violations in row_equal_p. (Bug#10035)
3278 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3280 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3281 just return (bug#10044).
3283 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3285 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3286 with user-defined heap size. Bump the default size of the temacs
3287 heap to 27MB, to avoid memory warning when running temacs.
3288 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3290 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3291 current_matrix and desired_matrix. (Bug#9990)
3292 (verify_row_hash) [XASSERTS]: New function.
3293 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3294 that the hash value of glyph rows is correct.
3296 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3298 * window.h (window): Remove splits slot.
3299 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3300 (Fdelete_other_windows_internal, make_parent_window)
3301 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3302 (Fset_window_configuration, save_window_save): Don't deal with
3303 split status of windows.
3304 (saved_window): Remove splits slot.
3305 (Vwindow_splits): Rewrite doc-string.
3307 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3309 * xfns.c (unwind_create_frame):
3310 * nsfns.m (unwind_create_frame):
3311 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3312 Vframe_list (Bug#9999).
3314 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3316 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3318 2011-11-11 Kenichi Handa <handa@m17n.org>
3320 * callproc.c (Fcall_process): Set the member dst_multibyte of
3321 process_coding.
3323 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3325 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3326 avoid a crash (bug#9496).
3328 2011-11-09 Chong Yidong <cyd@gnu.org>
3330 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3331 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3333 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3335 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3337 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3339 Avoid some portability problems by eschewing 'extern inline' functions.
3340 The trivial performance wins aren't worth the portability hassles; see
3341 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3342 et seq.
3343 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3344 (window_box_width, window_box_left, window_box_left_offset)
3345 (window_box_right, window_box_right_offset): Undo previous change,
3346 by removing the "extern"s.
3347 * intervals.c (adjust_intervals_for_insertion)
3348 (adjust_intervals_for_deletion): Undo previous change,
3349 making these static again.
3350 (offset_intervals, temp_set_point_both, temp_set_point)
3351 (copy_intervals_to_string): No longer inline.
3352 * xdisp.c (window_text_bottom_y, window_box_width)
3353 (window_box_height, window_box_left_offset)
3354 (window_box_right_offset, window_box_left, window_box_right)
3355 (window_box): No longer inline.
3357 2011-11-08 Chong Yidong <cyd@gnu.org>
3359 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3360 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3361 Signal an error if not a live window.
3362 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3363 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3365 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3367 * lisp.h (syms_of_abbrev): Remove declaration.
3368 Reported by CHENG Gao <chenggao@royau.me>.
3370 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3372 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3373 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3374 of temacs in GUI mode.
3376 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3378 * window.h: Declare delete_all_child_windows instead of
3379 delete_all_subwindows.
3380 * window.c (Fwindow_nest, Fset_window_nest)
3381 (Fset_window_new_total, Fset_window_new_normal)
3382 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3383 (delete_all_subwindows): Rename to delete_all_child_windows.
3384 (Fdelete_other_windows_internal, Fset_window_configuration):
3385 Call delete_all_child_windows instead of delete_all_subwindows.
3386 * frame.c (delete_frame): Call delete_all_child_windows instead
3387 of delete_all_subwindows.
3389 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3391 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3392 This is also needed for porting to any host where GC_MARK_STACK is
3393 not GC_MAKE_GCPROS_NOOPS.
3394 (which_symbols): Use it.
3396 2011-11-07 Kenichi Handa <handa@m17n.org>
3398 * coding.c (coding_set_destination): Check coding->src_pos only
3399 when coding->src_object is a buffer (bug#9910).
3401 * process.c (send_process): Set the member src_multibyte of coding
3402 to 0 (bug#9911) when sending a unibyte text.
3404 * callproc.c (Fcall_process): Set the member src_multibyte of
3405 process_coding to 0 (bug#9912).
3407 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3409 * xmenu.c (cleanup_widget_value_tree): New function.
3410 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3411 calling free_menubar_widget_value_tree directly (Bug#9830).
3413 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3415 Fix some portability problems with 'inline'.
3416 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3417 (window_box_width, window_box_left, window_box_left_offset)
3418 (window_box_right, window_box_right_offset): Declare extern.
3419 Otherwise, these inline functions do not conform to C99 and
3420 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3421 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3422 * intervals.c (adjust_intervals_for_insertion)
3423 (adjust_intervals_for_deletion): Now extern, because otherwise the
3424 extern inline functions 'offset_intervals' couldn't refer to it.
3425 (static_offset_intervals): Remove.
3426 (offset_intervals): Rewrite using the old contents of
3427 static_offset_intervals. The old version didn't conform to C99
3428 because an extern inline function contained a reference to an
3429 identifier with static linkage.
3431 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3433 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3434 GC.
3436 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3438 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3439 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3440 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3441 return Qleft_to_right.
3443 2011-11-06 Chong Yidong <cyd@gnu.org>
3445 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3446 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3447 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3448 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3449 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3450 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3451 (Fwindow_vscroll): Doc fix.
3452 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3453 argument, since it makes no sense to pass a live window and for
3454 consistency with window-child.
3456 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3458 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3459 support MSVC.
3461 2011-11-05 Jason Rumney <jasonr@gnu.org>
3463 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3464 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3465 fonts (Bug#6029).
3466 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3467 bitwise arithmetic preventing use of unicode-sip and non-truetype
3468 opentype fonts.
3470 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3472 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3473 "emacs"-only part.
3475 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3476 initialization code to keep similarity to xfns.c after changes
3477 from 2011-11-05.
3479 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3481 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3482 (unwind_create_frame): New function (Bug#9943).
3483 (Fx_create_frame): Restructure code to be more similar to the one in
3484 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3485 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3486 Move terminal->reference_count++ just before making the frame official
3487 (Bug#9943).
3489 * nsterm.m (x_free_frame_resources): New function.
3490 (x_destroy_window): Move code to x_free_frame_resources.
3492 * xfns.c (unwind_create_frame): Fix comment.
3493 (Fx_create_frame, x_create_tip_frame):
3494 Move terminal->reference_count++ just before making the frame
3495 official. Move initialization of image_cache_refcount and
3496 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3498 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3500 Support MSVC build with newer versions of Visual Studio.
3501 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3502 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3503 nt/gmake.defs.
3505 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3506 which are not supported by MSVC.
3507 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3508 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3509 bitfields.
3510 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3511 types in bitfields.
3512 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3514 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3516 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3518 Support MSVC build with newer versions of Visual Studio.
3519 * w32.c: Don't include w32api.h for MSVC.
3520 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3522 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3523 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3524 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3525 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3526 e_* cousins.
3527 (alloca) [_MSC_VER]: Define to _alloca.
3529 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3531 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3533 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3535 * xdisp.c (note_mouse_highlight): If either of
3536 previous/next-single-property-change returns nil, treat that as
3537 the beginning or the end of the buffer. (Bug#9955)
3539 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3541 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3542 label is not null (Bug#9951).
3543 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3544 may be NULL.
3546 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3548 * window.c (Fwindow_body_size): Mention in the doc string that the
3549 return value is in frame's canonical units. (Bug#9949)
3551 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3553 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3555 * w32fns.c (unwind_create_frame): If needed, free the glyph
3556 matrices of the partially constructed frame. (Bug#9943)
3557 * xfns.c (unwind_create_frame): Likewise.
3559 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3561 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3562 Don't stop backward scan on the continuation glyph, even though
3563 its CHARPOS is positive.
3564 (mouse_face_from_buffer_pos, note_mouse_highlight):
3565 Rename cover_string to disp_string.
3567 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3569 * window.c (temp_output_buffer_show): Don't use
3570 Vtemp_buffer_show_specifiers.
3571 (Vtemp_buffer_show_specifiers): Remove unused variable.
3573 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3575 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3576 past the beginning of the current glyph matrix.
3578 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3580 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3581 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3582 HAVE_GTK3 (Bug#9869).
3584 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3585 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3587 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3589 * xterm.c: Declare x_handle_net_wm_state to return int.
3590 (handle_one_xevent): Check if we are iconified but don't have
3591 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3592 (get_current_wm_state): Return non-zero if not hidden,
3593 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3594 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3595 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3596 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3598 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3600 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3601 so that this new function doesn't get optimized away by a
3602 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3604 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3606 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3608 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3610 Fix the `xbytecode' command.
3611 * .gdbinit (xprintbytestr): New command.
3612 (xwhichsymbols): Rename from `which'; all callers changed.
3613 (xbytecode): Print the byte-code string as well.
3615 2011-10-29 Kim Storm <storm@cua.dk>
3617 * alloc.c (which_symbols): New function.
3619 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3621 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3622 line. (Bug#9903)
3624 2011-10-29 Glenn Morris <rgm@gnu.org>
3626 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3627 Not clear what it was for, and it causes various bugs. (Bug#9839)
3629 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3631 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3632 possible random value that matches one of those tested as
3633 condition to clear the mouse face.
3635 2011-10-28 Chong Yidong <cyd@gnu.org>
3637 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3639 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3641 * window.c (make_window): Initialize phys_cursor_on_p.
3643 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3645 * lisp.h (struct Lisp_Symbol): Update comments.
3647 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3649 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3651 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3653 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3654 <oslsachem@gmail.com> for helping to debug this.
3656 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3657 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3658 (g_b_init_get_glyph_outline_w): New static variables.
3659 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3660 (GetGlyphOutlineW_Proc): New typedefs.
3661 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3662 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3663 New functions.
3664 (w32font_open_internal, compute_metrics):
3665 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3666 instead of calling the "wide" APIs directly.
3668 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3670 * w32.h (syms_of_w32font): Add prototype.
3672 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3674 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3675 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3676 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3677 (Fmove_to_window_line): Doc fix.
3679 2011-10-27 Chong Yidong <cyd@gnu.org>
3681 * process.c (make_process): Set gnutls_state to NULL.
3683 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3684 non-NULL, regardless of GNUTLS_INITSTAGE.
3685 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3686 an error. Set process slots as soon as we allocate them.
3688 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3690 2011-10-27 Chong Yidong <cyd@gnu.org>
3692 * gnutls.c (emacs_gnutls_deinit): New function.
3693 Deallocate credentials structures as well as calling gnutls_deinit.
3694 (Fgnutls_deinit, Fgnutls_boot): Use it.
3696 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3697 (deactivate_process): Call emacs_gnutls_deinit.
3699 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3701 * image.c (x_create_x_image_and_pixmap):
3702 * w32.c (sys_rename, w32_delayed_load):
3703 * w32font.c (fill_in_logfont):
3704 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3706 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3708 * w32fns.c (w32_default_color_map): New function,
3709 extracted from Fw32_default_color_map.
3710 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3712 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3714 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3716 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3718 * keyboard.c (test_undefined): New function (bug#9751).
3719 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3721 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3723 * sysdep.c (init_sys_modes): Fix the check for the controlling
3724 terminal (Bug#6649).
3726 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3728 * dispextern.h (struct bidi_it): New member next_en_type.
3730 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3731 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3732 current character, check also for next_en_type being WEAK_EN.
3733 (bidi_resolve_weak): Don't enter the expensive loop if the current
3734 position is before next_en_pos. Record the bidi type of the first
3735 non-ET, non-BN character we find, in addition to its position.
3736 (bidi_level_of_next_char): Invalidate next_en_type when
3737 next_en_pos is over-stepped.
3739 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3741 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3742 * editfns.c: Rewrite current-time-zone so that it invokes
3743 the equivalent of (format-time-string "%Z") to get the time zone name.
3744 This fixes a bug when the time zone name contains characters that
3745 need converting from the system time locale to Emacs internal format.
3746 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3747 that patch fixed format-time-string to do the conversion, but
3748 I forgot to fix current-time-zone.
3749 (format_time_string): New function, containing most of
3750 what Fformat_time_string used to contain.
3751 (Fformat_time_string): Rewrite in terms of format_time_string.
3752 This doesn't change this function's behavior.
3753 (current-time-zone): Rewrite to use format_time_string.
3754 This fixes the bug reported by Michael Schierl in
3755 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3756 Jason Rumney's 2007-06-07 change worked around this bug, but
3757 didn't fix it.
3758 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3760 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3762 * xdisp.c (start_display): If the character at POS is displayed
3763 via a display vector, reset IT->current.dpvec_index to zero.
3764 (try_window_reusing_current_matrix): If a line ends in a display
3765 vector or the next line starts in a display vector, continue
3766 redrawing the window even though the character position of
3767 start_row was reached.
3768 (Bug#9771, part 2)
3770 2011-10-18 Chong Yidong <cyd@gnu.org>
3772 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3773 with nobreak-char-display too.
3775 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3777 Fix part 3 of bug#9771.
3778 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3779 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3780 non-neutral characters if the current character is a paragraph
3781 separator (a.k.a. Newline). This avoids running the same
3782 expensive loop twice, once when we consume the preceding newline
3783 and the other time when the line actually needs to be displayed.
3784 Avoid the loop when we see neutrals on the base embedding level
3785 following a character whose directionality is the same as the
3786 paragraph's. This avoids running the expensive loop when a line
3787 ends in a long sequence of neutrals, like control characters.
3788 Add assertion against STRONG_AL type. Slightly rearrange code
3789 that determines the type of a neutral given the first non-neutral
3790 that follows it.
3791 (bidi_level_of_next_char): Set next_en_pos to zero when
3792 invalidating its info.
3794 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3796 * xdisp.c (push_display_prop): Determine whether to record string
3797 or buffer position by IT->string, not by IT->method. Allow
3798 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3799 (move_it_vertically_backward): Don't look for character position
3800 immediately after the newline when in a continuation line.
3801 (Bug#9771, part 1)
3803 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3805 * window.c (coordinates_in_window): Rewrite and delabelize
3806 vertical border check. (Bug#5357) (Bug#9618)
3808 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3810 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3811 errors in XSetWindowBorder (bug#9310).
3813 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3815 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3816 avoid crash when xmalloc overrun checking is enabled.
3818 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3820 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3821 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3822 cursor motion with <left> and <right> arrow keys.
3824 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3825 some callers set that themselves.
3827 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3829 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3830 display string and the previous row comes from the same string and
3831 is empty. (Bug#9739) (Bug#9738)
3833 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3835 * doc.c (get_doc_string): Encode file name (bug#9735).
3837 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3839 * bidi.c (bidi_level_of_next_char):
3840 * xdisp.c (get_visually_first_element): Remove old incorrect
3841 comments regarding the Unicode Line Separator character.
3843 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3845 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3847 * alloc.c (Fgc_status): Do not access beyond zombies array
3848 boundary if nzombies > MAX_ZOMBIES.
3849 * alloc.c (dump_zombies): Add missing format specifier.
3851 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3853 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3854 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3856 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3857 Some packages use them to denote characters with modifiers.
3859 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3861 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3862 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3863 matching a pp-number. Rename parameter var to var1.
3865 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3867 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3869 2011-10-08 Glenn Morris <rgm@gnu.org>
3871 * callint.c (Fcall_interactively): Give a more explicit error for the
3872 'c' case with a non-character input. (Bug#8479)
3874 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3876 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3877 lines.
3878 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3879 lines that are hscrolled on the left.
3881 * dispnew.c (buffer_posn_from_coords): Account for a possible
3882 presence of header-line. (Bug#4426)
3884 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3886 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3887 Don't advertise functionality which we discourage or doesn't work.
3889 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3891 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3892 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3893 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3894 this makes Emacs dump core during garbage collection on rare
3895 occasions. sizeof is obviously inferior to offsetof here, so
3896 stick with offsetof.
3897 (GC_POINTER_ALIGNMENT): New macro.
3898 (mark_memory): Omit 3rd (offset) arg; caller changed.
3899 Don't assume EMACS_INT alignment is the same as pointer alignment.
3901 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3903 * keyboard.c (read_key_sequence_remapped): New var.
3904 (read_key_sequence): Compute remapping in the right buffer.
3905 (command_loop_1): Use read_key_sequence's remapping directly.
3907 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3909 * dired.c (file_name_completion): Don't expand file name.
3910 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3911 before checking file name handler.
3913 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3914 they've been requested explicitly (bug#9591).
3916 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3918 * keymap.c (Fsingle_key_description): Use make_specified_string
3919 instead of build_string to build string from push_key_description.
3920 (Bug#5193)
3922 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3924 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3925 This fixes a Y2038 bug on 64-bit hosts.
3926 * buffer.c (reset_buffer):
3927 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3928 (Fclear_buffer_auto_save_failure):
3929 Use 0, not -1, to represent an unset failure time, since time_t
3930 might not be signed.
3932 Remove dependency on glibc malloc internals.
3933 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3934 Move back here from lisp.h, but with their new implementations.
3935 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3936 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3937 * charset.c (charset_table_init): New static var.
3938 (syms_of_charset): Use it instead of xmalloc. This removes a
3939 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3940 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3941 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3942 Move back to alloc.c.
3943 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3944 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3946 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3948 * nsterm.m (windowDidResize): Call x_set_window_size only when
3949 ns_in_resize is true. Otherwise set pixelwidth/height and
3950 call change_frame_size (Bug#9628).
3952 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3954 Port --enable-checking=all to Fedora 14 x86-64.
3955 * charset.c (syms_of_charset): Also account for glibc malloc's
3956 internal overhead when calculating the initial malloc maximum.
3958 Port --enable-checking=all to Fedora 14 x86.
3959 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3960 Move to lisp.h.
3961 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3962 (overrun_check_realloc, overrun_check_free):
3963 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3964 That way, xmalloc returns a properly-aligned pointer even if
3965 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3966 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3967 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3968 into account when calculating the initial malloc maximum.
3969 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3970 Move here from alloc.c, so that charset.c can use it too.
3971 Properly align; the old code wasn't right for common 32-bit hosts
3972 when configured with --enable-checking=all.
3973 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3974 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3976 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3978 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3979 use EDOM.
3981 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3983 * xdisp.c (compute_display_string_end): If there's no display
3984 string at CHARPOS, return -1.
3986 * bidi.c (bidi_fetch_char): When compute_display_string_end
3987 returns a negative value, treat the character as a normal
3988 character not covered by a display string. (Bug#9624)
3990 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3992 * lread.c (Fread_from_string): Fix typo in docstring.
3994 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3996 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3997 newline, reseat the iterator instead of bidi-iterating there one
3998 character at a time. (Bug#9610)
3999 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4000 TO_CHARPOS if the bidi iterator is at base embedding level.
4002 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4004 * lread.c (readevalloop): Use correct code for NBSP.
4005 (read1): Likewise. (Bug#9608)
4007 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4009 * dbusbind.c (Fdbus_register_signal): When service is not
4010 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4012 2011-09-25 Glenn Morris <rgm@gnu.org>
4014 * buffer.c (truncate-lines): Doc fix.
4016 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4018 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4019 (Fset_window_next_buffers): Doc fix.
4021 2011-09-24 Glenn Morris <rgm@gnu.org>
4023 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4025 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4027 Fix minor problems found by static checking.
4028 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4029 * indent.c (Fvertical_motion): Fix == vs = typo.
4031 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4033 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4034 Default value is now t. Doc fix.
4036 * indent.c (Fvertical_motion): Compute and apply the overshoot
4037 logic when moving up, not only when moving down. Fix the
4038 confusing name and values of the it_overshoot_expected variable;
4039 logic changes accordingly. (Bug#9254) (Bug#9549)
4041 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4042 CHARPOS is covered by a display string which includes newlines.
4043 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4044 is covered by a display string with embedded newlines.
4046 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4048 * dbusbind.c (Fdbus_register_signal): Add match rule to
4049 Vdbus_registered_objects_table. (Bug#9581)
4050 (Fdbus_register_method, Vdbus_registered_objects_table):
4051 Fix docstring.
4053 2011-09-24 Jim Meyering <meyering@redhat.com>
4055 do not ignore write error for any output size
4056 The previous change was incomplete.
4057 While it makes emacs --batch detect the vast majority of stdout
4058 write failures, errors were still ignored whenever the output size is
4059 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4060 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4061 && echo FAIL: ignored write error
4062 FAIL: ignored write error
4063 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4064 && echo FAIL: ignored write error
4065 FAIL: ignored write error
4066 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4068 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4070 * emacs.c (Fkill_emacs): In noninteractive mode exit
4071 non-successfully if a write error occurred on stdout. (Bug#9574)
4073 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4075 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4076 the xassert test.
4078 * dispextern.h (struct it): Update the comment documenting what
4079 can it->OBJECT be.
4081 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4083 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4084 a display string, extend search for cursor position to end of row.
4085 (find_row_edges): If the row ends in a newline from a display
4086 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4087 Handle the case of a display string with multiple newlines.
4088 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4089 non-empty line. Fixes confusing cursor motion with arrow keys at
4090 the beginning of a line that starts with whitespace.
4092 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4094 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4095 (bug#9493).
4097 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4099 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4100 boolean (Bug#9154).
4102 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4104 * xdisp.c (display_line): Record maximum and minimum buffer
4105 positions even if no glyphs were produced (e.g., by a zero-width
4106 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4107 buffer positions that will be removed from the glyph row because
4108 they don't fit.
4109 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4110 column is beyond frame width: don't subtract 1 "pixel" when
4111 computing width of the stretch.
4112 (reseat_at_next_visible_line_start): Undo the change made on
4113 2011-09-17 that saved paragraph information and restored it after
4114 the call to `reseat'. (Bug#9545)
4116 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4118 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4119 and turn window cursor on if cleared (Bug#9415).
4121 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4123 * search.c (boyer_moore): Take unibyte characters from pattern
4124 literally. (Bug#9458)
4126 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4128 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4130 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4132 Fix minor problem found by static checking.
4133 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4134 initialized, to pacify gcc -Wuninitialized.
4136 * fileio.c: Report proper errno when syscall falls.
4137 (Finsert_file_contents): Save and restore errno,
4138 so that report_file_error outputs the correct diagnostic.
4139 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4141 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4143 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4145 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4147 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4148 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4150 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4152 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4153 about the current paragraph and restore it after the call to reseat.
4155 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4156 (bidi_find_paragraph_start): Search back for paragraph beginning
4157 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4158 (bidi_move_to_visually_next): Only trigger paragraph-related
4159 computations when the last character is a newline or at EOB, not
4160 just any NEUTRAL_B. (Bug#9470)
4162 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4163 truncated lines if point is covered by a display string. (Bug#9524)
4165 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4167 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4168 (cons_to_x_long): New function.
4169 (lisp_data_to_selection_data): Use it. Correct the test for
4170 short-versus-long data; it was negated. Break out of vector
4171 loop, for efficiency, when a long datum is discovered.
4173 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4175 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4177 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4179 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4180 GCC PR/17406) by declaring this function with external scope.
4182 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4184 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4185 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4187 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4189 * editfns.c (Fformat): Correctly handle text properties on "%%".
4191 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4193 * xterm.c (x_draw_composite_glyph_string_foreground):
4194 * w32term.c (x_draw_composite_glyph_string_foreground):
4195 * term.c (encode_terminal_code):
4196 * composite.c (composition_update_it, get_composition_id):
4197 * xdisp.c (get_next_display_element)
4198 (fill_composite_glyph_string): Add comments about special meaning
4199 of TAB characters in a composition.
4201 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4203 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4204 This occurs when processing a multibyte format.
4205 Problem reported by Wolfgang Jenker.
4207 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4209 * xdisp.c (try_cursor_movement): Only check for exact match if
4210 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4212 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4214 Remove unused external symbols.
4215 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4216 * xdisp.c (calc_pixel_width_or_height): Now static.
4217 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4218 * indent.c (check_display_width):
4219 * w32term.c: Fix comment to match code.
4220 * xterm.c, xterm.h (x_catching_errors): Remove.
4222 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4224 * xselect.c: Use signed conversions more consistently (Bug#9498).
4225 (selection_data_to_lisp_data): Assume incoming selection data are
4226 signed integers, not unsigned. This is to be consistent with
4227 outgoing selection data, which was modified to use signed integers
4228 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4229 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4230 expects long, not unsigned long.
4232 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4234 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4235 computation of loop end. Reported by Johan Bockgård
4236 <bojohan@gnu.org>.
4238 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4240 * frame.c (Fother_visible_frames_p): Function deleted.
4242 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4244 * indent.c (compute_motion): Process display vector front to back
4245 rather than the other way around. (Bug#2496)
4247 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4249 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4251 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4253 * minibuf.c (Fread_from_minibuffer): Doc fix.
4255 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4257 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4258 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4260 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4262 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4263 value for non-existent files.
4265 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4267 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4268 set its "size" to -1. This will set the modtime_size field of
4269 the corresponding buffer to -1, which is what
4270 verify-visited-file-modtime expects for files that do not exist.
4271 (Bug#9139)
4273 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4275 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4276 here ...
4277 * lisp.h: ... from here. push_key_description is no longer
4278 defined in keyboard.c, so its declaration should not be in
4279 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4280 logically belongs with push_key_description.
4282 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4284 * buffer.h: Include <sys/types.h> instead of <time.h>.
4285 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4286 Problem reported by Herbert J. Skuhra.
4288 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4290 * xml.c (parse_region): Make the parsing work for
4291 non-comment-starting XML files again (bug#9144).
4293 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4295 * image.c (gif_load): Fix calculation of bottom and right corner.
4296 (Bug#9468)
4298 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4300 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4301 redisplay in small windows.
4303 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4305 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4307 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4309 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4310 Operate on live windows only.
4312 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4314 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4316 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4318 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4319 only under bidi iteration.
4321 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4323 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4325 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4327 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4328 Without this fix, the command to link temacs failed due to an
4329 undefined symbol __builtin_isnan. This is because
4330 /usr/include/iso/math_c99.h #defines isnan(x) to
4331 __builtin_isnan(x), but the bundled gcc, which identifies itself
4332 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4333 a __builtin_isnan.
4334 * floatfns.c (isnan): #undef, and then #define to a clone of
4335 what's in data.c.
4336 (Fisnan): Always define, since it's always available now.
4337 (syms_of_floatfns): Always define isnan at the Lisp level.
4339 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4341 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4343 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4345 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4346 The previous code assumed that file offsets (off_t values) fit in
4347 EMACS_INT variables, which is not true on typical 32-bit hosts.
4348 The code messed up by falsely reporting buffer overflow in cases
4349 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4350 when "big" contains more than 2**29 bytes, even though this
4351 inserts just one byte and does not overflow the buffer.
4352 (Finsert_file_contents): Store file offsets as off_t
4353 values, not as EMACS_INT values. Check for overflow when
4354 converting between EMACS_INT and off_t. When checking for
4355 buffer overflow or for overlap, take the offsets into account.
4356 Don't use EMACS_INT for small values where int suffices.
4357 When checking for overlap, fix a typo: ZV was used where
4358 ZV_BYTE was intended.
4359 (Fwrite_region): Don't assume off_t fits into 'long'.
4360 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4362 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4364 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4366 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4368 sprintf-related integer and memory overflow issues (Bug#9412).
4370 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4371 (esprintf, exprintf, evxprintf): New functions.
4372 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4373 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4374 (modify_event_symbol): Do not assume that the length of
4375 name_alist_or_stem is safe to alloca and fits in int.
4376 (Fexecute_extended_command): Likewise for function name and binding.
4377 (Frecursion_depth): Wrap around reliably on integer overflow.
4378 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4379 since some callers pass EMACS_INT values.
4380 (Fsingle_key_description): Don't crash if symbol name contains more
4381 than MAX_ALLOCA bytes.
4382 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4383 (get_minibuffer): Arg is now EMACS_INT, not int.
4384 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4385 (esprintf, exprintf, evxprintf): New decls.
4386 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4388 * dbusbind.c (signature_cat): New function.
4389 (xd_signature, Fdbus_register_signal):
4390 Do not overrun buffer; instead, report string overflow.
4392 * dispnew.c (add_window_display_history): Don't overrun buffer.
4393 Truncate instead; this is OK since it's just a log.
4395 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4396 even if the time zone offset is outlandishly large.
4397 Don't mishandle offset == INT_MIN.
4399 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4400 when creating daemon; the previous buffer-overflow check was incorrect.
4402 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4403 which has the guts of the old verror function.
4405 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4406 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4408 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4409 (font_unparse_xlfd): Don't blindly alloca long strings.
4410 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4411 fits in int, when using sprintf. Use single snprintf to count
4412 length of string rather than counting it via multiple sprintfs;
4413 that's simpler and more reliable.
4414 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4415 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4416 sprintf, in case result does not fit in int.
4418 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4419 (fontset_from_font): Print it.
4421 * frame.c (tty_frame_count): Now printmax_t, not int.
4422 (make_terminal_frame, set_term_frame_name): Print it.
4423 (x_report_frame_params): In X, window IDs are unsigned long,
4424 not signed long, so print them as unsigned.
4425 (validate_x_resource_name): Check for implausibly long names,
4426 and don't assume name length fits in 'int'.
4427 (x_get_resource_string): Don't blindly alloca invocation name;
4428 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4429 not fit in int.
4431 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4432 (xg_check_special_colors, xg_set_geometry):
4433 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4435 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4436 Use esprintf, not sprintf, in case result does not fit in int.
4438 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4439 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4440 it as a large positive number.
4441 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4442 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4444 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4445 in case result does not fit in int.
4447 * print.c (float_to_string): Detect width overflow more reliably.
4448 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4449 buffer overrun. Don't assume list length fits in 'int'. Treat
4450 print length of 0 as 0, not as infinity; to be consistent with other
4451 uses of print length in this function. Don't overflow print length
4452 index. Don't assume hash table size fits in 'long', or that
4453 vectorlike size fits in 'unsigned long'.
4455 * process.c (make_process): Use printmax_t, not int, to format
4456 process-name gensyms.
4458 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4460 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4461 to avoid potential buffer overrun.
4463 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4464 if X resource line is longer than 512 bytes.
4466 * xfns.c (x_window): Make sprintf buffer a bit bigger
4467 to avoid potential buffer overrun.
4469 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4471 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4473 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4475 Integer overflow fixes for scrolling, etc.
4476 Without these, Emacs silently mishandles large integers sometimes.
4477 For example, "C-u 4294967297 M-x recenter" was treated as if
4478 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4480 * xdisp.c (try_window_id): Check Emacs fixnum range before
4481 converting to 'int'.
4483 * window.c (window_scroll_line_based, Frecenter):
4484 Check that an Emacs fixnum is in range before assigning it to 'int'.
4485 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4486 values converted from Emacs fixnums.
4487 (Frecenter): Don't wrap around a line count if it is out of 'int'
4488 range; instead, treat it as an extreme value.
4489 (Fset_window_configuration, compare_window_configurations):
4490 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4492 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4493 that can exceed INT_MAX. Check that EMACS_INT value is in range
4494 before assigning it to the (possibly-narrower) index.
4495 (match_limit): Don't assume that a fixnum can fit in 'int'.
4497 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4498 exceed INT_MAX.
4500 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4501 (Fvertical_motion): Don't wrap around LINES values that don't fit
4502 in 'int'. Instead, treat them as extreme values. This is good
4503 enough for windows, which can't have more than INT_MAX lines anyway.
4505 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4507 * Require libxml/parser.h to avoid compilation warning.
4509 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4511 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4512 since this reportedly can destroy thread storage.
4514 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4516 * syntax.c (find_defun_start): Update all cache variables if
4517 exiting early (Bug#9401).
4519 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4521 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4523 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4524 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4525 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4527 * term.c (tty_append_glyph): New function.
4528 (produce_stretch_glyph): Static function and its prototype deleted.
4530 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4531 Add prototypes.
4533 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4535 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4536 when checking :margin (Bug#9390).
4537 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4538 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4539 so that the name doesn't mislead. All uses changed.
4541 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4543 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4544 set_tty_hooks.
4546 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4548 * xdisp.c (move_it_to): Don't bail out early when reaching
4549 position beyond to_charpos, if we are scanning backwards.
4550 (move_it_vertically_backward): When DY == 0, make sure we get to
4551 the first character in the line after the newline.
4553 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4555 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4556 (ccl_driver): Do not generate an out-of-range pointer.
4557 (Fccl_execute_on_string): Remove unnecessary check for
4558 integer overflow, noted by Stefan Monnier in
4559 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4560 Remove a FIXME that didn't need fixing.
4561 Simplify the newly-introduced buffer reallocation code.
4563 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4565 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4567 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4569 Integer and memory overflow issues (Bug#9196).
4571 * doc.c (get_doc_string): Rework so that
4572 get_doc_string_buffer_size is the actual buffer size, rather than
4573 being 1 less than the actual buffer size; this makes xpalloc more
4574 convenient.
4576 * image.c (x_allocate_bitmap_record, cache_image):
4577 * xselect.c (Fx_register_dnd_atom):
4578 Simplify previous changes by using xpalloc.
4580 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4581 since either will do and ptrdiff_t is convenient with xpalloc.
4583 * charset.c (charset_table_size)
4584 (struct charset_sort_data.priority): Now ptrdiff_t.
4585 (charset_compare): Don't overflow if priorities differ greatly.
4586 (Fsort_charsets): Don't assume list length fits in int.
4587 Check for size-calculation overflow when allocating sort data.
4588 (syms_of_charset): Allocate an initial charset table that is
4589 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4591 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4593 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4594 The actual value is always <= INT_MAX, and leaving it unsigned made
4595 overflow checking harder.
4597 * dispextern.h (struct glyph_matrix.rows_allocated)
4598 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4599 with xpalloc. The values are still always <= INT_MAX.
4601 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4603 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4604 (SAFE_NALLOCA): New macro.
4606 * region-cache.c (struct boundary.pos, find_cache_boundary)
4607 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4608 (set_cache_region, invalidate_region_cache)
4609 (revalidate_region_cache, know_region_cache, region_cache_forward)
4610 (region_cache_backward, pp_cache):
4611 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4612 so that ptrdiff_t * can be passed to xpalloc.
4613 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4614 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4615 (pp_cache): Don't assume cache_len fits in int.
4616 * region-cache.h: Adjust extern decls to match.
4618 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4619 EMACS_INT, since either will do, for xpalloc.
4621 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4622 (xnmalloc, xnrealloc, xpalloc): New functions.
4624 * bidi.c (bidi_shelve_header_size): New constant.
4625 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4626 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4628 * bidi.c (bidi_cache_shrink):
4629 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4630 (overlay_strings):
4631 Don't update size of array until after memory allocation succeeds,
4632 because xmalloc/xrealloc may not return.
4633 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4634 now that we have proper integer overflow checking.
4635 (record_overlay_string, overlay_strings): Catch overflows when
4636 calculating size of overlay_str_buf.
4638 * callproc.c (Fcall_process): Check for size overflow when
4639 calculating size of args2.
4640 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4641 Normally we prefer signed values, but sticking with ptrdiff_t would
4642 require adding more-complicated checks.
4644 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4645 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4646 Redo buffer-overflow calculations to avoid integer overflow.
4647 Add a FIXME comment where memory seems to be over-allocated.
4649 * character.c (Fstring): Check for size-calculation overflow.
4651 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4652 unnecessary integer overflow. Check for size overflow.
4653 (encode_coding_object): Don't update size until xmalloc succeeds.
4655 * composite.c (get_composition_id): Check for overflow in glyph
4656 length calculations.
4658 Integer and memory overflow fixes for display code.
4659 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4660 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4661 (scrolling_window): Check for overflow in size calculations.
4662 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4663 Don't assume glyph table len fits in int.
4664 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4665 (row_table_size): Now ptrdiff_t, not int.
4666 (scrolling_window): Avoid overflow in size calculations.
4667 Don't update size until allocation succeeds.
4668 * fns.c (concat): Check for overflow in size calculations.
4669 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4670 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4671 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4673 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4674 (get_doc_string): Check for size calculation overflow.
4675 Don't update size until allocation succeeds.
4676 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4677 EMACS_INT, where ptrdiff_t will do.
4678 (Fsubstitute_command_keys): Check for string overflow.
4680 * editfns.c (set_time_zone_rule): Don't assume environment length
4681 fits in int.
4682 (message_length): Now ptrdiff_t, not int.
4683 (Fmessage_box): Don't update size until allocation succeeds.
4684 Don't assume message length fits in int.
4685 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4687 * emacs.c (main): Do not reallocate argv, since there is a null at
4688 the end that can be overwritten, and this way there's no need to
4689 worry about size-calculation overflow.
4690 (sort_args): Check for size-calculation overflow.
4692 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4693 alloc succeeds.
4694 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4696 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4697 (x_set_scroll_bar_width, x_figure_window_size):
4698 Check for integer overflow.
4699 (x_set_alpha): Do not assume XINT fits in int.
4701 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4702 This is for the members text_lines, text_cols, total_lines, total_cols,
4703 where the system imposes an 'int' limit.
4705 * fringe.c (Fdefine_fringe_bitmap):
4706 Don't update size until alloc works.
4708 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4709 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4711 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4712 Check for size-calculation overflow.
4713 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4714 do, as we prefer signed integers.
4715 (id_to_widget.max_size, id_to_widget.used)
4716 (xg_store_widget_in_map, xg_remove_widget_from_map)
4717 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4718 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4719 Use and return ptrdiff_t, not int.
4720 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4721 * gtkutil.h: Change prototypes to match the above.
4723 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4724 are duplicate now that they've been promoted to lisp.h.
4725 (x_allocate_bitmap_record, x_alloc_image_color)
4726 (make_image_cache, cache_image, xpm_load):
4727 Don't update size until alloc is done.
4728 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4729 (x_detect_edges):
4730 Check for size calculation overflow.
4731 (ct_colors_allocated_max): New constant.
4732 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4733 overflow.
4735 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4736 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4737 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4738 Use ptrdiff_t, not int, to count maps.
4739 (read_char_minibuf_menu_prompt): Check for overflow in size
4740 calculations. Don't update size until allocation succeeds.
4741 Redo calculations to avoid overflow.
4742 * keyboard.h: Change prototypes to match the above.
4744 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4745 to count maps.
4746 (current_minor_maps): Check for size calculation overflow.
4747 * keymap.h: Change prototypes to match the above.
4749 * lread.c (read1, init_obarray): Don't update size until alloc done.
4751 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4752 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4754 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4755 Now ptrdiff_t, not int.
4756 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4757 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4759 * process.c (Fnetwork_interface_list): Check for overflow
4760 in size calculation.
4762 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4764 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4765 overflow. Don't bother calling xmalloc when xrealloc will do.
4767 * search.c (Freplace_match): Check for size calculation overflow.
4768 (Fset_match_data): Don't assume list lengths fit in 'int'.
4770 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4771 for command line length. Do not attempt to address one before the
4772 beginning of an array, as that's not portable.
4774 * term.c (max_frame_lines): Remove; unused.
4775 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4776 not int.
4777 (encode_terminal_code, calculate_costs): Check for size
4778 calculation overflow.
4779 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4780 table lengths and related sizes. Don't update size until alloc
4781 done. Redo calculations to avoid overflow.
4782 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4784 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4785 subtracting pointers.
4786 (gobble_line): Check for overflow more carefully. Don't update size
4787 until alloc done.
4789 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4790 Don't update size until alloc done.
4791 Redo size calculations to avoid overflow.
4792 Check for size calculation overflow.
4793 (main) [DEBUG]: Fix typo in invoking tparam1.
4795 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4796 Use ptrdiff_t, not int, for sizes.
4797 (store_mode_line_noprop_char): Don't update size until alloc done.
4799 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4800 Use ptrdiff_t, not int, for sizes.
4801 (Finternal_make_lisp_face, cache_face):
4802 Check for size calculation overflow.
4803 (cache_face): Treat size calculation overflows as if they were
4804 memory exhaustion (the usual treatment), rather than aborting.
4806 * xfns.c (x_encode_text, x_set_name_internal)
4807 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4808 sizes, since they can exceed INT_MAX in size. Check for size
4809 calculation overflow.
4811 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4812 (xg_select): Check for size calculation overflow.
4813 Don't update size until alloc done.
4815 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4816 as sprintf is limited to int lengths.
4818 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4819 (X_LONG_MIN): New macros.
4820 Use them to make the following changes clearer.
4821 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4822 This change doesn't affect the value now, but it may help remind
4823 future maintainers not to raise the value too much later.
4824 (SELECTION_QUANTUM): Remove, replacing with ...
4825 (selection_quantum): ... new function, which avoids overflow.
4826 All uses changed.
4827 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4828 assumption that selection length fits in 'int'.
4829 (x_reply_selection_request, x_handle_selection_request)
4830 (x_get_window_property, receive_incremental_selection)
4831 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4832 (lisp_data_to_selection_data, clean_local_selection_data):
4833 Use ptrdiff_t, not int, to record length of selection.
4834 (x_reply_selection_request, x_get_window_property)
4835 (receive_incremental_selection, x_property_data_to_lisp):
4836 Redo calculations to avoid overflow.
4837 (x_reply_selection_request): When sending hint, ceiling it at
4838 X_LONG_MAX rather than relying on wraparound overflow to send
4839 something.
4840 (x_get_window_property, receive_incremental_selection)
4841 (lisp_data_to_selection_data, x_property_data_to_lisp):
4842 Check for size-calculation overflow.
4843 (x_get_window_property, receive_incremental_selection)
4844 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4845 Don't store size until memory allocation succeeds.
4846 (x_get_window_property): Plug memory leak on memory exhaustion.
4847 Don't double-block input; malloc is safe here. Don't assume 2**34
4848 - 4 fits in unsigned long. Add an xassert to check
4849 XGetWindowProperty overflow. Be more careful about overflow
4850 calculations, and distinguish size from memory overflow better.
4851 (receive_incremental_selection): When tracing, don't assume
4852 unsigned int is less than INT_MAX.
4853 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4854 harmful) conversions of unsigned short to int.
4855 (lisp_data_to_selection_data): Don't assume that integers
4856 in the range -65535 through -1 fit in an X unsigned short.
4857 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4858 result parameters unless successful. Rely on cons_to_unsigned
4859 to report problems with elements; the old code wasn't right anyway.
4860 (x_check_property_data): Check for int overflow; we cannot use
4861 a wider type due to X limits.
4862 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4864 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4866 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4867 (x_term_init): Check for size calculation overflow.
4868 (x_color_cells): Don't store size until memory allocation succeeds.
4869 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4870 Don't assume alloca size is less than MAX_ALLOCA.
4871 (x_term_init): Don't assume length fits in int (sprintf is limited
4872 to int size).
4874 Use ptrdiff_t for composition IDs.
4875 * character.c (lisp_string_width):
4876 * composite.c (composition_table_size, n_compositions)
4877 (get_composition_id, composition_gstring_from_id):
4878 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4879 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4880 * window.c (Frecenter):
4881 Use ptrdiff_t, not int, for composition IDs.
4882 * composite.c (get_composition_id): Check for integer overflow.
4883 * composite.h: Adjust prototypes to match the above changes.
4885 Use ptrdiff_t for hash table indexes.
4886 * category.c (hash_get_category_set):
4887 * ccl.c (ccl_driver):
4888 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4889 * coding.c (coding_system_charset_list, detect_coding_system):
4890 * coding.h (struct coding_system.id):
4891 * composite.c (get_composition_id, gstring_lookup_cache):
4892 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4893 * image.c (xpm_get_color_table_h):
4894 * lisp.h (hash_lookup, hash_put):
4895 * minibuf.c (Ftest_completion):
4896 Use ptrdiff_t for hash table indexes, not int (which is too
4897 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4898 32-bit --with-wide-int hosts).
4900 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4901 Add a FIXME comment about memory leaks.
4902 (syms_of_charset): Don't assume xmalloc returns.
4904 Don't assume that stated character widths fit in int.
4905 * character.c (Fchar_width, c_string_width, lisp_string_width):
4906 * character.h (CHAR_WIDTH):
4907 * indent.c (MULTIBYTE_BYTES_WIDTH):
4908 Use sanitize_char_width to avoid undefined and/or bad behavior
4909 with outlandish widths.
4910 * character.h (sanitize_tab_width): Rename from sanitize_width,
4911 now that we have two such functions. All uses changed.
4912 (sanitize_char_width): New inline function.
4914 Don't assume that tab-width fits in int.
4915 * character.h (sanitize_width): New inline function.
4916 (SANE_TAB_WIDTH): New macro.
4917 (ASCII_CHAR_WIDTH): Use it.
4918 * indent.c (sane_tab_width): Remove. All uses replaced by
4919 SANE_TAB_WIDTH (current_buffer).
4920 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4922 * fileio.c: Integer overflow issues with file modes.
4923 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4925 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4926 Remove unreachable code.
4927 (read_hex, load_charset_map_from_file): Check for integer overflow.
4929 * xterm.c: Don't go over XClientMessageEvent limit.
4930 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4931 (x_send_scroll_bar_event): Likewise. Check that the size does not
4932 exceed limits imposed by XClientMessageEvent, as well as the usual
4933 ptrdiff_t and size_t limits.
4935 * keyboard.c: Overflow, signedness and related fixes.
4936 (make_lispy_movement): Use same integer type in forward decl
4937 that is used in the definition.
4938 (read_key_sequence, keyremap_step):
4939 Change bufsize argument back to int, undoing my 2011-03-30 change.
4940 We prefer signed types, and int is wide enough here.
4941 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4942 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4943 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4944 length, not size_t. Use ptrdiff_t for index, not int.
4945 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4946 possibility of integer overflow.
4948 Overflow, signedness and related fixes for images.
4950 * dispextern.h (struct it.stack[0].u.image.image_id)
4951 (struct_it.image_id, struct image.id, struct image_cache.size)
4952 (struct image_cache.used, struct image_cache.ref_count):
4953 * gtkutil.c (update_frame_tool_bar):
4954 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4955 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4956 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4957 * nsmenu.m (update_frame_tool_bar):
4958 * xdisp.c (calc_pixel_width_or_height):
4959 * xfns.c (image_cache_refcount):
4960 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4961 on typical 64-bit hosts.
4963 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4964 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4965 Omit unnecessary casts to int.
4966 (parse_image_spec): Check that integers fall into 'int' range
4967 when the callers expect that.
4968 (image_ascent): Redo ascent calculation to avoid int overflow.
4969 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4970 (lookup_image): Remove unnecessary tests.
4971 (xbm_image_p): Locals are now of int, not EMACS_INT,
4972 since parse_image_check makes sure they fit into int.
4973 (png_load, gif_load, svg_load_image):
4974 Prefer int to unsigned where either will do.
4975 (tiff_handler): New function, combining the cores of the
4976 old tiff_error_handler and tiff_warning_handler.
4977 This function is rewritten to use vsnprintf and thereby avoid
4978 stack buffer overflows. It uses only the features of vsnprintf
4979 that are common to both POSIX and native Microsoft.
4980 (tiff_error_handler, tiff_warning_handler): Use it.
4981 (tiff_load, gif_load, imagemagick_load_image):
4982 Don't assume :index value fits in 'int'.
4983 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4984 (imagemagick_load_image): Check that crop parameters fit into
4985 the integer types that MagickCropImage accepts. Don't assume
4986 Vimagemagick_render_type has a nonnegative value. Don't assume
4987 size_t fits in 'long'.
4988 (gs_load): Use printmax_t to print the widest integers possible.
4989 Check for integer overflow when computing image height and width.
4991 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4993 * xdisp.c (redisplay_window): Don't force window start if point
4994 will be invisible in the resulting window. (Bug#9324)
4996 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4998 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4999 the display spec is of the form `(space ...)'.
5000 (handle_display_spec): Return the value returned by
5001 handle_single_display_spec, not just 1 or zero.
5002 (handle_single_display_spec): If the display spec is of the form
5003 `(space ...)', and specifies display in the text area, return 2
5004 rather than 1.
5005 (try_cursor_movement): Check for the need to scroll more
5006 accurately, and prefer exact match for point under bidi.
5007 Don't advance `row' beyond the last row of the window.
5009 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5010 into disp_prop; all users changed.
5012 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5013 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5014 for the text covered by the display property.
5016 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5018 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5019 Change return value to nil.
5020 (Frecord_buffer): Delete unused function.
5022 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5024 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5025 buffers, return left-to-right.
5026 (set_cursor_from_row): Consider candidate row a win if its glyph
5027 represents a newline and point is on that newline. Fixes cursor
5028 positioning on the newline at EOL of R2L text within L2R
5029 paragraph, and vice versa.
5030 (try_cursor_movement): Check continued rows, in addition to
5031 continuation rows. Fixes unwarranted scroll when point enters a
5032 continued line of R2L text within an L2R paragraph, or vice versa.
5033 (cursor_row_p): Consider the case of point being equal to
5034 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5035 from the end of a short line to the beginning of a continued line
5036 of R2L text within L2R paragraph.
5037 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5038 composed characters.
5040 * bidi.c (bidi_check_type): Use xassert.
5041 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5042 members.
5044 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5046 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5047 a character.
5049 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5051 * nsfont.m (ns_otf_to_script): Fix typo.
5053 2011-08-22 Kenichi Handa <handa@m17n.org>
5055 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5056 extra slot even if the purpose is char-code-property-table.
5058 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5060 * xdisp.c (redisplay_window): When computing centering_position,
5061 account for the height of the header line. (Bug#8874)
5063 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5064 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5065 candidate is selected by the mouse, and that candidate has a
5066 composed character under the mouse.
5068 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5069 coordinates reported by pos-visible-in-window-p for a composed
5070 character in column zero.
5072 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5074 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5076 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5078 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5079 consider it a hit if to_charpos is anywhere in the range of the
5080 composed buffer positions.
5082 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5084 * image.c (gif_load): Don't assume that each subimage has the same
5085 dimensions as the base image. Handle disposal method that is
5086 "undefined" by the gif spec (Bug#9335).
5088 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5090 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5091 (Fcondition_case): Document `debug' symbol in error handler.
5093 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5095 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5096 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5097 from an Org mode buffer to a Speedbar frame.
5099 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5100 a composition, take its buffer position from IT->cmp_it.charpos.
5101 Fixes cursor positioning at the beginning of a line that begins
5102 with a composed character.
5104 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5106 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5107 character bidirectional type, use STRONG_L instead. Fixes crashes
5108 in a buffer produced by `describe-categories'.
5110 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5111 members before the level stack, so they would be saved and
5112 restored when copying iterator state. Fixes incorrect reordering
5113 around TABs covered by display properties.
5115 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5117 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5119 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5121 * eval.c (internal_condition_case, internal_condition_case_1)
5122 (internal_condition_case_2, internal_condition_case_n):
5123 Remove unnecessary aborts (Bug#9081).
5125 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5127 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5128 has no `load' handler, try opening the file locally. (Bug#9311)
5130 2011-08-16 Ken Brown <kbrown@cornell.edu>
5132 * gmalloc.c: Expand comment.
5134 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5136 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5137 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5139 2011-08-16 Ken Brown <kbrown@cornell.edu>
5141 Fix memory allocation problems in Cygwin build (Bug#9273).
5143 * unexcw.c ( __malloc_initialized): Declare external variable.
5144 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5146 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5147 New variables.
5148 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5149 dumped emacs.
5150 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5151 in the static heap.
5152 [CYGWIN] (special_realloc): New function.
5153 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5154 requests to realloc storage in the static heap.
5156 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5158 * bidi.c (bidi_initialize): Remove unused local.
5160 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5162 * bidimirror.h:
5163 * biditype.h: Remove file.
5164 * makefile.w32-in ($(BLD)/bidi.$(O)):
5165 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5167 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5169 * chartab.c: Improve commentary for the uniprop_table API.
5171 * bidi.c (bidi_paragraph_init): Support zero value of
5172 bidi_ignore_explicit_marks_for_paragraph_level.
5173 (bidi_initialize): Use uniprop_table instead of including
5174 biditype.h and bidimirror.h.
5176 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5177 coordinates of the iterator when restoring from ppos_it.
5178 (Bug#9296)
5180 2011-08-14 Kenichi Handa <handa@m17n.org>
5182 * process.c (create_process): Call setup_process_coding_systems
5183 after the pid of the process is set to -1 (Bug#8162).
5185 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5187 * xdisp.c (move_it_in_display_line_to): Don't invoke
5188 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5189 ppos_it. Fixes vertical cursor motion when line beginning is
5190 covered by an image. (Bug#9296)
5192 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5194 * nsterm.h (ns_run_ascript): Declare.
5195 (NSAPP_DATA2_RUNASSCRIPT): Define.
5197 * nsfns.m (as_script, as_result, as_status): New static variables.
5198 (ns_run_ascript): New function.
5199 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5200 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5201 the event loop. Get status from as_status (Bug#7276).
5203 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5204 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5205 the event loop (Bug#7276).
5207 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5209 * gnutls.c (QCgnutls_bootprop_priority)
5210 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5211 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5212 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5213 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5214 (QCgnutls_bootprop_verify_hostname_error)
5215 (QCgnutls_bootprop_callbacks_verify): Rename from
5216 Qgnutls_bootprop_..., all uses changed.
5218 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5219 uses changed.
5221 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5223 * xfaces.c (Qframe_set_background_mode): Now static.
5224 * dispextern.h (Qframe_set_background_mode): Remove decl.
5226 * process.c (Fnetwork_interface_info): Declare local only if needed.
5228 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5230 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5231 (Fnetwork_interface_list): Allocate in increments of bytes instead
5232 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5233 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5234 sockaddr.
5235 (struct ifflag_def): notrailers is smart on OSX.
5236 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5237 Get hardware address with getifaddrs if available.
5239 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5241 * xdisp.c (iterate_out_of_display_property): xassert that
5242 IT->position is set to within IT->object's boundaries. Break from
5243 the loop as soon as EOB is reached; avoids infloops in redisplay
5244 when IT->position is set up wrongly due to some bug.
5245 Set IT->current to match the bidi iterator unconditionally.
5246 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5247 entry. Force push_it to save on the stack the current
5248 buffer/string position, to be restored by pop_it. Fix flags in
5249 the iterator structure wrt the object coming from a display
5250 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5251 properties. (Bug#9284)
5253 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5255 * fontset.c (fontset_get_font_group): Add proper type checks.
5256 (Bug#9172)
5258 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5260 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5261 and LC_VERSION_MIN_MACOSX.
5262 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5263 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5265 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5267 * xdisp.c (forward_to_next_line_start): Allow to use the
5268 no-display-properties-and-no-overlays under bidi display.
5269 Set disp_pos in the bidi iterator to avoid searches for display
5270 properties and overlays.
5272 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5274 * editfns.c (Fset_time_zone_rule): Document relationship with the
5275 setenv function.
5277 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5278 the font entity extracted from the cache (Bug#8109).
5280 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5282 * composite.c (autocmp_chars): Don't reset point. That is done by
5283 restore_point_unwind (Bug#5984).
5285 2011-08-07 Juri Linkov <juri@jurta.org>
5287 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5288 to show the arg `TIME' instead of `TIMEVAL'.
5290 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5292 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5293 display property strides EOL and includes a newline, as in
5294 longlines-mode. (Bug#9254)
5295 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5296 word-wrap under bidirectional display. (Bug#9224)
5298 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5299 is non-zero, even if the data buffer is NULL. Fixes a crash in
5300 vertical-motion with longlines-mode. (Bug#9254)
5302 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5304 * bidi.c <bidi_cache_total_alloc>: Now static.
5305 (bidi_initialize): Initialize bidi_cache_total_alloc.
5307 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5308 cache. (Bug#9221)
5310 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5311 amount allocated this far in `bidi_cache_total_alloc'.
5312 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5313 non-zero, only free the data buffer without restoring the cache
5314 contents. All callers changed.
5316 * dispextern.h (bidi_unshelve_cache): Update prototype.
5318 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5319 (move_it_in_display_line, move_it_to)
5320 (move_it_vertically_backward, move_it_by_lines): Replace the call
5321 to xfree to an equivalent call to bidi_unshelve_cache.
5322 (move_it_in_display_line_to): Fix logic of returning
5323 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5325 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5327 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5328 came from a string character with a `cursor' property. (Bug#9229)
5330 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5332 * Makefile.in (LIB_PTHREAD): New variable.
5333 (LIBES): Add LIB_PTHREAD (Bug#9216).
5335 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5336 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5338 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5340 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5342 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5344 * xterm.c (x_find_topmost_parent): New function.
5345 (x_set_frame_alpha): Find topmost parent window with
5346 x_find_topmost_parent and set the property there also (bug#9181).
5347 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5349 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5351 * callproc.c (Fcall_process): Avoid vfork clobbering
5352 the local vars buffer, coding_systems, current_dir.
5354 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5356 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5358 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5360 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5361 so that it is not optimized away.
5363 * xdisp.c (compute_display_string_pos): Remove unused local.
5365 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5367 Fix slow cursor motion and scrolling in large buffers with
5368 selective display, like Org Mode buffers. (Bug#9218)
5370 * dispextern.h (struct bidi_it): New member disp_prop_p.
5372 * xdisp.c: Remove one-slot cache of display string positions.
5373 (compute_display_string_pos): Accept an additional argument
5374 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5375 for a display string or property. If found, set DISP_PROP_P
5376 non-zero.
5378 * bidi.c (bidi_fetch_char): Accept an additional argument
5379 DISP_PROP_P, and pass it to compute_display_string_pos.
5380 Only handle text covered by a display string if DISP_PROP_P is returned
5381 non-zero. All callers of bidi_fetch_char changed.
5383 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5385 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5387 2010-12-03 Don March <don@ohspite.net>
5389 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5390 last character M-[char] is translated to ESC [char] (bug#7541).
5392 2011-08-02 Kenichi Handa <handa@m17n.org>
5394 * lisp.h (uniprop_table): Extern it.
5396 * chartab.c (uniprop_table): Make it non-static.
5398 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5400 * xdisp.c (forward_to_next_line_start): Accept additional argument
5401 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5402 on the newline.
5403 (reseat_at_next_visible_line_start): Use the bidi iterator state
5404 returned by forward_to_next_line_start to restore the state of
5405 it->bidi_it after backing up to previous newline. (Bug#9212)
5407 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5409 * regex.c (re_comp): Protoize.
5410 (re_exec): Fix return type.
5411 (regexec): Fix type of `ret'. (Bug#9203)
5413 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5415 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5416 This is needed if max-image-size is a floating-point number.
5418 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5420 * print.c (print_object): Print empty symbol as ##.
5422 * lread.c (read1): Read ## as empty symbol.
5424 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5426 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5427 setting frame foreground color (Bug#9175).
5428 (x_set_background_color): Likewise.
5430 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5431 contents (Bug#9176).
5432 (EmacsTooltip -init): Remove bezels and add shadows to
5433 tooltip windows.
5435 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5436 or scroll bar (Bug#8470).
5438 * nsfont.m (nsfont_open): Remove assignment to voffset and
5439 unnecessary vars hshink, expand, hd, full_height, min_height.
5440 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5442 * nsterm.h (nsfont_info): Remove voffset field.
5444 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5446 Implement strike-through and overline on NextStep (Bug#8863).
5448 * nsfont.m (nsfont_open): Use underline position provided by font,
5449 instead of hard-coded value of 2.
5450 (nsfont_draw): Call ns_draw_text_decoration instead.
5452 * nsterm.h: Add declaration for ns_draw_text_decoration.
5454 * nsterm.m (ns_draw_text_decoration): New function for drawing
5455 underline, overline, and strike-through.
5456 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5457 ns_draw_text_decoration. Change treatment of cursor drawing to
5458 accommodate underlining, etc.
5460 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5462 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5463 default.
5465 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5467 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5468 Without this fix, if a signal arrives just after memory fills up,
5469 'malloc' might be invoked reentrantly.
5471 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5472 In other words, assume that every image size is allowed, on non-X
5473 hosts. This assumption is probably wrong, but it lets Emacs compile.
5475 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5477 * regex.c (re_iswctype): Convert return values to boolean.
5479 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5481 * xdisp.c (compute_display_string_pos): Don't use cached display
5482 string position if the buffer had its restriction changed.
5483 (Bug#9184)
5485 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5487 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5489 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5491 Integer signedness and overflow and related fixes. (Bug#9079)
5493 * bidi.c: Integer size and overflow fixes.
5494 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5495 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5496 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5497 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5498 (bidi_find_other_level_edge):
5499 Use ptrdiff_t instead of EMACS_INT where either will do.
5500 This works better on 32-bit hosts configured --with-wide-int.
5501 (bidi_cache_ensure_space): Check for size-calculation overflow.
5502 Use % rather than repeated addition, for better worst-case speed.
5503 Don't set bidi_cache_size until after xrealloc returns, because it
5504 might not return.
5505 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5506 (bidi_cache_ensure_space): Also check that the bidi cache size
5507 does not exceed that of the largest Lisp string or buffer. See Eli
5508 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5510 * alloc.c (__malloc_size_t): Remove.
5511 All uses replaced by size_t. See Andreas Schwab's note
5512 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5514 * image.c: Improve checking for integer overflow.
5515 (check_image_size): Assume that f is nonnull, since
5516 it is always nonnull in practice. This is one less thing to
5517 worry about when checking for integer overflow later.
5518 (x_check_image_size): New function, which checks for integer
5519 overflow issues inside X.
5520 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5521 This removes the need for a memory_full check.
5522 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5523 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5524 (xbm_read_bitmap_data): Change locals back to 'int', since
5525 their values must fit in 'int'.
5526 (xpm_load_image, png_load, tiff_load):
5527 Invoke x_create_x_image_and_pixmap earlier,
5528 to avoid much needless work if the image is too large.
5529 (tiff_load): Treat overly large images as if
5530 x_create_x_image_and_pixmap failed, not as malloc failures.
5531 (gs_load): Use x_check_image_size.
5533 * gtkutil.c: Omit integer casts.
5534 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5535 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5537 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5539 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5540 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5541 would wrongly return t on a 64-bit host.
5543 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5544 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5545 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5546 and therefore cause GCC to emit a bogus diagnostic in some cases.
5548 * image.c: Integer signedness and overflow and related fixes.
5549 This is not an exhaustive set of fixes, but it's time to
5550 record what I've got.
5551 (lookup_pixel_color, check_image_size): Remove redundant decls.
5552 (check_image_size): Don't assume that arbitrary EMACS_INT values
5553 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5554 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5555 (tiff_load, imagemagick_load_image):
5556 Check for overflow in size calculations.
5557 (x_create_x_image_and_pixmap): Remove unnecessary test for
5558 xmalloc returning NULL; that can't happen.
5559 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5560 (xpm_color_bucket): Use better integer hashing function.
5561 (xpm_cache_color): Don't possibly over-allocate memory.
5562 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5563 (gif_memory_source):
5564 Use ptrdiff_t, not int or size_t, to record sizes.
5565 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5566 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5567 either works, as we prefer signed integers.
5568 (tiff_read_from_memory, tiff_write_from_memory):
5569 Return tsize_t, not size_t, since that's what the TIFF API wants.
5570 (tiff_read_from_memory): Don't fail simply because the read would
5571 go past EOF; instead, return a short read.
5572 (tiff_load): Omit no-longer-needed casts.
5573 (Fimagemagick_types): Don't assume size fits into 'int'.
5575 Improve hashing quality when configured --with-wide-int.
5576 * fns.c (hash_string): New function, taken from sxhash_string.
5577 Do not discard information about ASCII character case; this
5578 discarding is no longer needed.
5579 (sxhash-string): Use it. Change sig to match it. Caller changed.
5580 * lisp.h: Declare it.
5581 * lread.c (hash_string): Remove, since we now use fns.c's version.
5582 The fns.c version returns a wider integer if --with-wide-int is
5583 specified, so this should help the quality of the hashing a bit.
5585 * emacs.c: Integer overflow minor fix.
5586 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5587 Define only if GNU_LINUX.
5588 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5590 * dispnew.c: Integer signedness and overflow fixes.
5591 Remove unnecessary forward decls, that were a maintenance hassle.
5592 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5593 All uses changed.
5594 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5595 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5596 (prepare_desired_row, line_draw_cost):
5597 Use int, not unsigned, where either works.
5598 (save_current_matrix, restore_current_matrix):
5599 Use ptrdiff_t, not size_t, where either works.
5600 (init_display): Check for overflow more accurately, and without
5601 relying on undefined behavior.
5603 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5604 Remove, replacing with the new symbols in lisp.h. All uses changed.
5605 * fileio.c (make_temp_name):
5606 * filelock.c (lock_file_1, lock_file):
5607 * xdisp.c (message_dolog):
5608 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5609 Use pMd etc. instead.
5610 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5611 replacing the pWIDE etc. symbols removed from editfns.c.
5613 * keyboard.h (num_input_events): Now uintmax_t.
5614 This is (very slightly) less likely to mess up due to wraparound.
5615 All uses changed.
5617 * buffer.c: Integer signedness fixes.
5618 (alloc_buffer_text, enlarge_buffer_text):
5619 Use ptrdiff_t rather than size_t when either will do, as we prefer
5620 signed integers.
5622 * alloc.c: Integer signedness and overflow fixes.
5623 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5624 (__malloc_size_t): Default to size_t, not to int.
5625 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5626 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5627 Prefer ptrdiff_t to size_t when either would do, as we prefer
5628 signed integers.
5629 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5630 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5631 Now const. Initialize with values that are in range even if char
5632 is signed.
5633 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5634 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5635 These functions do the right thing with sizes > 2**32.
5636 (check_depth): Now ptrdiff_t, not int.
5637 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5638 Adjust to new way of storing sizes. Check for size overflow bugs
5639 in rest of code.
5640 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5641 slightly wrong anyway, as it missed one instance of
5642 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5643 (refill_memory_reserve): Omit needless cast to size_t.
5644 (mark_object_loop_halt): Mark as externally visible.
5646 * xselect.c: Integer signedness and overflow fixes.
5647 (Fx_register_dnd_atom, x_handle_dnd_message):
5648 Use ptrdiff_t, not size_t, since we prefer signed.
5649 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5650 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5651 x_dnd_atoms_size and x_dnd_atoms_length.
5653 * doprnt.c: Prefer signed to unsigned when either works.
5654 * eval.c (verror):
5655 * doprnt.c (doprnt):
5656 * lisp.h (doprnt):
5657 * xdisp.c (vmessage):
5658 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5659 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5660 prefer signed arithmetic to avoid comparison confusion.
5661 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5662 but is a bit tricky.
5664 Assume freestanding C89 headers, string.h, stdlib.h.
5665 * data.c, doprnt.c, floatfns.c, print.c:
5666 Include float.h unconditionally.
5667 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5668 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5669 * regex.c: Likewise for stddef.h, string.h.
5670 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5671 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5672 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5673 (STDC_HEADERS): Remove obsolete defines.
5674 * sysdep.c: Include limits.h unconditionally.
5676 Assume support for memcmp, memcpy, memmove, memset.
5677 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5678 * regex.c (memcmp, memcpy):
5679 Remove; we assume C89 now.
5681 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5682 (__malloc_safe_bcopy): Remove; no longer needed.
5684 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5685 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5686 well either way, and we prefer signed to unsigned.
5688 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5690 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5691 closes the connection while we're reading (bug#9182).
5693 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5695 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5696 are specified (Bug#9168).
5698 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5700 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5701 Found by GCC static checking and --with-wide-int on a 32-bit host.
5703 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5705 * xdisp.c (compute_display_string_pos): Fix logic of caching
5706 previous display string position. Initialize cached_prev_pos to
5707 -1. Fixes slow-down at the beginning of a buffer.
5709 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5711 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5712 for attrs[LFACE_FONTSET_INDEX].
5714 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5716 * xml.c (parse_region): Remove unused local
5717 that was recently introduced.
5719 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5721 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5722 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5724 * xdisp.c (move_it_in_display_line_to): Record the best matching
5725 position for TO_CHARPOS while scanning the line, and restore it on
5726 exit if none of the characters scanned was an exact match.
5727 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5728 when exact match is impossible due to invisible text, and the
5729 lines are truncated.
5731 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5733 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5734 for OSX >= 10.7.
5736 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5738 Fix a significant slow-down of cursor motion with C-n, C-p,
5739 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5740 auto-repeat under bidi redisplay in fontified buffers.
5741 * xdisp.c (compute_stop_pos_backwards): New function.
5742 (next_element_from_buffer): Call compute_stop_pos_backwards to
5743 find a suitable prev_stop when we find ourselves before
5744 base_level_stop.
5745 (reseat): Don't look for prev_stop, as that could mean a very long
5746 run.
5747 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5748 <cached_disp_overlay_modiff>: Cache for last found display string
5749 position.
5750 (compute_display_string_pos): Return the cached position if asked
5751 about the same buffer in the same area of character positions, and
5752 the buffer wasn't changed since the time the display string
5753 position was cached.
5755 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5757 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5758 is an integer, which is important for empty lines. (Bug#9149)
5760 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5762 * frame.c (Fmodify_frame_parameters): In tty case, update the
5763 default face if necessary (Bug#4238).
5765 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5767 * editfns.c (Fstring_to_char): No need to explain what a character
5768 is in the docstring (Bug#6576).
5770 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5772 * xml.c (parse_region): Make sure we always return a tree.
5774 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5776 * xml.c (parse_region): If a document contains only comments,
5777 return that, too.
5779 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5781 * xml.c (make_dom): Return comments, too.
5783 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5785 Port to OpenBSD.
5786 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5787 and the surrounding thread.
5788 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5789 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5790 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5791 timer goes off.
5792 * s/openbsd.h (BROKEN_SIGIO): Define.
5793 * unexelf.c (unexec) [__OpenBSD__]:
5794 Don't update the .mdebug section of the Alpha COFF symbol table.
5796 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5798 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5799 (bug#8460).
5801 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5803 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5804 This fixes some race conditions on the permissions of any newly
5805 created file.
5807 * alloc.c (valid_pointer_p): Use pipe, not open.
5808 This fixes some permissions issues when debugging.
5810 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5811 If fchown fails to set both uid and gid, try to set just gid,
5812 as that is sometimes allowed. Adjust the file's mode to eliminate
5813 setuid or setgid bits that are inappropriate if fchown fails.
5815 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5817 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5818 to compare Lisp_Objects.
5819 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5820 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5821 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5823 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5825 * lread.c (read_integer): Unread even EOF character.
5826 (read1): Likewise. Properly record start position of symbol.
5828 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5829 symbol character follows.
5831 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5833 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5834 This works around a problem with the previous change to Fcopy_file.
5835 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5836 and without this change, GCC might complain about discarding
5837 fchown's return value.
5839 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5841 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5843 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5845 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5847 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5849 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5850 it's used from the C level.
5852 * process.c: Use the same condition for POLL_FOR_INPUT in both
5853 keyboard.c and process.c (bug#1858).
5855 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5857 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5858 (Fgnutls_boot): Use it.
5860 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5862 * doc.c (Fsubstitute_command_keys): Revert last change.
5864 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5866 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5867 quotes the next character, and doesn't affect other longer
5868 sequences (bug#8935).
5870 * lread.c (syms_of_lread): Clarify that is isn't only
5871 `eval-buffer' and `eval-defun' that's affected by
5872 `lexical-binding' (bug#8460).
5874 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5876 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5877 bidi redisplay when a line includes both an image and is truncated.
5879 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5881 Fix minor problems found by static checking.
5882 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5883 (elsz): Now a signed constant, not a size_t var. We prefer signed
5884 types to unsigned, to avoid integer comparison confusion. Without
5885 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5886 "cannot optimize loop, the loop counter may overflow", a symptom
5887 of the confusion.
5888 * indent.c (Fvertical_motion): Mark locals as initialized.
5889 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5891 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5893 * search.c (Fre_search_backward): Mention `case-fold-search' in
5894 all the re_search_* functions (bug#8138).
5896 * keyboard.c (Fopen_dribble_file): Document when the file is
5897 closed (bug#8056).
5899 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5901 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5902 bidi_cache_idx.
5904 Support bidi reordering of display and overlay strings.
5905 * xdisp.c (compute_display_string_pos)
5906 (compute_display_string_end): Accept additional argument STRING.
5907 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5908 (reseat_to_string): Initialize bidi_it->string.s and
5909 bidi_it->string.schars.
5910 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5911 NULL (avoids a crash in bidi_paragraph_init).
5912 Initialize itb.string.lstring.
5913 (init_iterator): Call bidi_init_it only of a valid
5914 buffer position was specified. Initialize paragraph_embedding to
5915 L2R.
5916 (reseat_to_string): Initialize the bidi iterator.
5917 (display_string): If we need to ignore text properties of
5918 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5919 original value of -1 will not work with bidi.)
5920 (compute_display_string_pos): First arg is now struct
5921 `text_pos *'; all callers changed. Support display properties on
5922 Lisp strings.
5923 (compute_display_string_end): Support display properties on Lisp
5924 strings.
5925 (init_iterator, reseat_1, reseat_to_string): Initialize the
5926 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5927 when iterating on a string not from display properties).
5928 (compute_display_string_pos, compute_display_string_end):
5929 Fix calculation of the object to scan. Fixes an error when using
5930 arrow keys.
5931 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5932 base_level_stop; instead, set base_level_stop to BEGV.
5933 Fixes crashes in vertical-motion.
5934 (next_element_from_buffer): Improve commentary for when
5935 the iterator is before prev_stop.
5936 (init_iterator): Initialize bidi_p from the default value of
5937 bidi-display-reordering, not from buffer-local value. Use the
5938 buffer-local value only if initializing for buffer iteration.
5939 (handle_invisible_prop): Support invisible properties on strings
5940 that are being bidi-reordered.
5941 (set_iterator_to_next): Support bidi reordering of C strings and
5942 Lisp strings.
5943 (next_element_from_string): Support bidi reordering of Lisp
5944 strings.
5945 (handle_stop_backwards): Support Lisp strings as well.
5946 (display_string): Support display of R2L glyph rows.
5947 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5948 (init_iterator): Don't initialize it->bidi_p for strings
5949 here.
5950 (reseat_to_string): Initialize it->bidi_p for strings here.
5951 (next_element_from_string, next_element_from_c_string)
5952 (next_element_from_buffer): Add xassert's for correspondence
5953 between IT's object being iterated and it->bidi_it.string
5954 structure.
5955 (face_before_or_after_it_pos): Support bidi iteration.
5956 (next_element_from_c_string): Handle the case of the first string
5957 character that is not the first one in the visual order.
5958 (get_visually_first_element): New function, refactored from common
5959 parts of next_element_from_buffer, next_element_from_string, and
5960 next_element_from_c_string.
5961 (tool_bar_lines_needed, redisplay_tool_bar)
5962 (display_menu_bar): Force left-to-right direction. Add a FIXME
5963 comment for making that be controlled by a user option.
5964 (push_it, pop_it): Save and restore the state of the
5965 bidi iterator. Save and restore the bidi_p flag.
5966 (pop_it): Iterate out of display property for string iteration as
5967 well.
5968 (iterate_out_of_display_property): Support iteration over strings.
5969 (handle_single_display_spec): Set up it->bidi_it for iteration
5970 over a display string, and call bidi_init_it.
5971 (handle_single_display_spec, next_overlay_string)
5972 (get_overlay_strings_1, push_display_prop): Set up the bidi
5973 iterator for displaying display or overlay strings.
5974 (forward_to_next_line_start): Don't use the shortcut if
5975 bidi-iterating.
5976 (back_to_previous_visible_line_start): If handle_display_prop
5977 pushed the iterator stack, restore the internal state of the bidi
5978 iterator by calling bidi_pop_it same number of times.
5979 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5980 and we are bidi-iterating, don't decrement the iterator position;
5981 instead, set the first_elt flag in the bidi iterator, to produce
5982 the same effect.
5983 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5984 (push_display_prop): xassert that we are iterating a buffer.
5985 (push_it, pop_it): Save and restore paragraph_embedding member.
5986 (handle_single_display_spec, next_overlay_string)
5987 (get_overlay_strings_1, reseat_1, reseat_to_string)
5988 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5989 correctly. Don't assume unibyte strings are not bidi-reordered.
5990 (compute_display_string_pos)
5991 (compute_display_string_end): Fix handling the case of C string.
5992 (push_it, pop_it): Save and restore from_disp_prop_p.
5993 (handle_single_display_spec, push_display_prop): Set the
5994 from_disp_prop_p flag.
5995 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5996 (pop_it): Call iterate_out_of_display_property only if we are
5997 popping after iteration over a string that came from a display
5998 property. Fix a typo in popping stretch info. Add an assertion
5999 for verifying that the iterator position is in sync with the bidi
6000 iterator.
6001 (handle_single_display_spec, get_overlay_strings_1)
6002 (push_display_prop): Fix initialization of paragraph direction for
6003 string when that of the parent object is not yet determined.
6004 (reseat_1): Call bidi_init_it to resync the bidi
6005 iterator with IT's position. (Bug#7616)
6006 (find_row_edges): If ROW->start.pos gives position
6007 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6008 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6009 Reset the from_disp_prop_p flag.
6010 (SAVE_IT, RESTORE_IT): New macros.
6011 (pos_visible_p, face_before_or_after_it_pos)
6012 (back_to_previous_visible_line_start)
6013 (move_it_in_display_line_to, move_it_in_display_line)
6014 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6015 (try_scrolling, redisplay_window, display_line): Use them when
6016 saving a temporary copy of the iterator and restoring it back.
6017 (back_to_previous_visible_line_start, reseat_1)
6018 (init_iterator): Empty the bidi cache "stack".
6019 (move_it_in_display_line_to): If iterator ended up at
6020 EOL, but we never saw any buffer positions smaller than
6021 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6022 motion in bidi-reordered lines.
6023 (move_it_in_display_line_to): Record prev_method and prev_pos
6024 immediately before the call to set_iterator_to_next. Fixes cursor
6025 motion in bidi-reordered lines with stretch glyphs and strings
6026 displayed in margins. (Bug#8133) (Bug#8867)
6027 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6028 TO_CHARPOS.
6029 (pos_visible_p): Support positions in bidi-reordered lines.
6030 Save and restore bidi cache.
6032 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6033 (bidi_paragraph_info): Delete unused struct.
6034 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6035 (bidi_cache_start): New variable.
6036 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6037 to zero.
6038 (bidi_cache_fetch_state, bidi_cache_search)
6039 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6040 (bidi_cache_find, bidi_peek_at_next_level)
6041 (bidi_level_of_next_char, bidi_find_other_level_edge)
6042 (bidi_move_to_visually_next): Compare cache index with
6043 bidi_cache_start rather than with zero.
6044 (bidi_fetch_char): Accept new argument STRING; all callers
6045 changed. Support iteration over a string. Support strings with
6046 display properties. Support unibyte strings. Fix the type of
6047 `len' according to what STRING_CHAR_AND_LENGTH expects.
6048 (bidi_paragraph_init, bidi_resolve_explicit_1)
6049 (bidi_resolve_explicit, bidi_resolve_weak)
6050 (bidi_level_of_next_char, bidi_move_to_visually_next):
6051 Support iteration over a string.
6052 (bidi_set_sor_type, bidi_resolve_explicit_1)
6053 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6054 can now be zero (for strings); special values 0 and -1 were
6055 changed to -1 and -2, respectively.
6056 (bidi_char_at_pos): New function.
6057 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6058 Call it instead of FETCH_MULTIBYTE_CHAR.
6059 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6060 initialized to valid values.
6061 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6062 values.
6063 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6064 the test for valid cached positions. Fix the logic for looking up
6065 the sentinel state in the cache. GCPRO the Lisp string we are
6066 iterating.
6067 (bidi_push_it, bidi_pop_it): New functions.
6068 (bidi_initialize): Initialize the bidi cache start stack pointer.
6069 (bidi_cache_ensure_space): New function, refactored from part of
6070 bidi_cache_iterator_state. Don't assume the required size is just
6071 one BIDI_CACHE_CHUNK away.
6072 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6073 (bidi_count_bytes, bidi_char_at_pos): New functions.
6074 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6075 always valid if bidi_cache_idx is valid.
6076 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6077 is valid if it's going to be used.
6078 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6079 (bidi_cache_fetch_state, bidi_cache_search)
6080 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6081 (bidi_cache_iterator_state, bidi_cache_find)
6082 (bidi_find_other_level_edge, bidi_cache_start_stack):
6083 All variables related to cache indices are now EMACS_INT.
6085 * dispextern.h (struct bidi_string_data): New structure.
6086 (struct bidi_it): New member `string'. Make flag members be 1-bit
6087 fields, and put them last in the struct.
6088 (compute_display_string_pos, compute_display_string_end):
6089 Update prototypes.
6090 (bidi_push_it, bidi_pop_it): Add prototypes.
6091 (struct iterator_stack_entry): New members bidi_p,
6092 paragraph_embedding, and from_disp_prop_p.
6093 (struct it): Member bidi_p is now a bit field 1 bit wide.
6094 (bidi_shelve_cache, bidi_unshelve_cache):
6095 Declare prototypes.
6097 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6098 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6099 and vector-like objects.
6101 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6102 cache around display iteration.
6104 * window.c (Fwindow_end, window_scroll_pixel_based)
6105 (displayed_window_lines, Frecenter): Save and restore the bidi
6106 cache around display iteration.
6108 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6110 * editfns.c (Fdelete_region): Clarify the use of the named
6111 parameters (bug#6788).
6113 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6115 * indent.c (Fvertical_motion): Set and restore w->pointm when
6116 saving and restoring the window's buffer (Bug#9006).
6118 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6120 * editfns.c (Fstring_to_char): Clarify just what is returned
6121 (bug#6576). Text by Eli Zaretskii.
6123 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6125 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6127 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6129 * buffer.c (mmap_find): Fix a typo.
6131 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6133 Fix execution of x selection hooks.
6134 * xselect.c (Qx_lost_selection_functions)
6135 (Qx_sent_selection_functions): New vars.
6136 (syms_of_xselect): DEFSYM them.
6137 (x_handle_selection_request): Pass Qx_sent_selection_functions
6138 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6139 (x_handle_selection_clear,x_clear_frame_selections):
6140 Pass Qx_lost_selection_functions rather than
6141 Vx_lost_selection_functions to Frun_hook_with_args.
6143 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6145 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6146 The old code sometimes used this field without initializing it.
6148 * alloc.c (gc_sweep): Don't read past end of array.
6149 In theory, the old code could also have corrupted Emacs internals,
6150 though it'd be very unlikely.
6152 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6154 * character.c (Fcharacterp): Don't advertise optional ignored
6155 argument. (Bug#4026)
6157 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6159 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6160 key" (bug#4257).
6162 * window.c (Fset_window_start): Doc fix (bug#4199).
6163 (Fset_window_hscroll): Ditto.
6165 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6167 Fix minor new problems caught by GCC 4.6.1.
6168 * term.c (init_tty): Remove unused local.
6169 * xsettings.c (store_monospaced_changed): Define this function only
6170 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6171 not used otherwise.
6173 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6175 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6177 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6179 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6180 are the mini-buffer and the echo area (bug#3320).
6182 * term.c (init_tty): Remove support for supdup, c10 and perq
6183 terminals, which are no longer supported (bug#1482).
6185 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6187 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6189 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6191 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6192 for non-popups (Bug#3642).
6194 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6196 * alloc.c (reset_malloc_hooks): Protoize.
6197 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6198 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6199 * cm.c (losecursor): Likewise.
6200 * data.c (fmod): Likewise.
6201 * dispnew.c (swap_glyphs_in_rows): Likewise.
6202 * emacs.c (memory_warning_signal): Likewise.
6203 * floatfns.c (float_error): Likewise.
6204 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6205 (otf_open, font_otf_capability, generate_otf_features)
6206 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6207 Likewise.
6208 * image.c (pbm_read_file): Likewise.
6209 * indent.c (string_display_width): Likewise.
6210 * intervals.c (check_for_interval, search_for_interval)
6211 (inc_interval_count, count_intervals, root_interval)
6212 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6213 * lread.c (defalias): Likewise.
6214 * ralloc.c (r_alloc_check): Likewise.
6215 * regex.c (set_image_of_range_1, set_image_of_range)
6216 (regex_grow_registers): Likewise.
6217 * sysdep.c (strerror): Likewise.
6218 * termcap.c (valid_filename_p, tprint, main): Likewise.
6219 * tparam.c (main): Likewise.
6220 * unexhp9k800.c (run_time_remap, save_data_space)
6221 (update_file_ptrs, read_header, write_header, calculate_checksum)
6222 (copy_file, copy_rest, display_header): Likewise.
6223 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6224 Likewise.
6225 * xdisp.c (check_it): Likewise.
6226 * xfaces.c (register_color, unregister_color, unregister_colors):
6227 Likewise.
6228 * xfns.c (print_fontset_result): Likewise.
6229 * xrdb.c (member, fatal, main): Likewise.
6231 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6233 Fix minor problems found by static checking (Bug#9031).
6234 * chartab.c (char_table_set_range, map_sub_char_table):
6235 Remove unused locals.
6236 (uniprop_table): Now static.
6237 * composite.c (_work_char): Remove unused static var.
6239 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6241 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6243 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6245 * gtkutil.c (qttip_cb): Remove code without function.
6247 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6249 * w32.c (pthread_sigmask): New stub.
6251 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6253 Use pthread_sigmask, not sigprocmask (Bug#9010).
6254 sigprocmask is portable only for single-threaded applications, and
6255 Emacs can be multi-threaded when it uses GTK.
6256 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6257 (LIBES): Use it.
6258 * callproc.c (Fcall_process):
6259 * process.c (create_process):
6260 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6261 Use pthread_sigmask, not sigprocmask.
6263 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6265 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6266 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6267 wrong (Bug#8591).
6269 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6271 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6272 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6273 (xg_hide_tooltip): Fix comment.
6275 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6276 in registerServicesMenuSendTypes.
6277 (validRequestorForSendType): Don't check ns_return_types.
6279 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6280 ns_return_type.
6282 2011-07-08 Jason Rumney <jasonr@gnu.org>
6284 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6285 SH_SHOW for hidden windows (Bug#5482).
6287 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6288 frame struct members of non-existent frames (Bug#6284).
6290 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6292 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6293 variable firstTime not needed on OSX >= 10.6.
6294 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6295 >= 10.5. Use setKnobProportion, setDoubleValue.
6297 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6298 (MAC_OS_X_VERSION_10_5): Define if not defined.
6299 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6300 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6301 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6303 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6304 cString and lossyCString on OSX >= 10.4
6306 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6307 sizeToFit on OSX >= 10.2.
6309 * nsimage.m (allocInitFromFile): Don't use deprecated method
6310 bestRepresentationForDevice on OSX >= 10.6.
6312 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6313 to avoid warning.
6315 * emacs.c: Declare unexec_init_emacs_zone.
6317 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6319 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6321 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6322 on svcsMenu (Bug#8842).
6324 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6325 ns_return_types.
6326 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6328 * nsterm.m (QUTF8_STRING): Declare.
6329 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6330 (validRequestorForSendType): Return type is (id).
6331 Change indexOfObjectIdenticalTo to indexOfObject.
6332 Check if we have local selection before returning self (Bug#8842).
6333 (writeSelectionToPasteboard): Put local selection into paste board
6334 if we have a local selection (Bug#8842).
6335 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6337 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6338 (ns_get_local_selection): Declare.
6340 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6342 * keymap.c (describe_map_tree): Don't insert a double newline at
6343 the end of the buffer (bug#1169) and return whether we inserted
6344 something.
6346 * callint.c (Fcall_interactively): Change "reading args" to
6347 "providing args" to try to clarify what it does (bug#1010).
6349 2011-07-07 Kenichi Handa <handa@m17n.org>
6351 * composite.c (composition_compute_stop_pos): Ignore a static
6352 composition starting before CHARPOS (Bug#8915).
6354 * xdisp.c (handle_composition_prop): Likewise.
6356 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6358 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6359 (Bug#9015)
6361 2011-07-07 Kenichi Handa <handa@m17n.org>
6363 * character.h (unicode_category_t): New enum type.
6365 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6366 (Qchar_code_property_table): New variable.
6367 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6368 (UNIPROP_COMPRESSED_FORM_P): New macros.
6369 (char_table_ascii): Uncompress the compressed values.
6370 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6371 Uncompress the compressed values.
6372 (sub_char_table_ref_and_range): Likewise.
6373 (char_table_ref_and_range): Uncompress the compressed values.
6374 (sub_char_table_set): New arg is_uniprop. Callers changed.
6375 Uncompress the compressed values.
6376 (sub_char_table_set_range): Args changed. Callers changed.
6377 (char_table_set_range): Adjuted for the above change.
6378 (map_sub_char_table): Delete args default_val and parent. Add arg
6379 top. Give decoded values to a Lisp function.
6380 (map_char_table): Adjust for the above change. Give decoded
6381 values to a Lisp function. Gcpro more variables.
6382 (uniprop_table_uncompress)
6383 (uniprop_decode_value_run_length): New functions.
6384 (uniprop_decoder, uniprop_decoder_count): New variables.
6385 (uniprop_get_decoder, uniprop_encode_value_character)
6386 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6387 New functions.
6388 (uniprop_encoder, uniprop_encoder_count): New variables.
6389 (uniprop_get_encoder, uniprop_table)
6390 (Funicode_property_table_internal, Fget_unicode_property_internal)
6391 (Fput_unicode_property_internal): New functions.
6392 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6393 Sunicode_property_table_internal, Sget_unicode_property_internal,
6394 and Sput_unicode_property_internal. Defvar_lisp
6395 char-code-property-alist.
6397 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6398 Vunicode_category_table.
6400 * font.c (font_range): Adjust for the change of
6401 Vunicode_category_table.
6403 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6405 * m/iris4d.h: Remove file, move contents ...
6406 * s/irix6-5.h: ... here.
6408 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6410 Remove unportable assumption about struct layout (Bug#8884).
6411 * alloc.c (mark_buffer):
6412 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6413 (clone_per_buffer_values): Don't assume that
6414 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6415 This isn't true in general, and it's particularly not true
6416 if Emacs is configured with --with-wide-int.
6417 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6418 New macros, used in the buffer.c change.
6420 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6422 * xsettings.c: Use both GConf and GSettings if both are available.
6423 (store_config_changed_event): Add comment.
6424 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6425 (store_tool_bar_style_changed): New functions.
6426 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6427 (struct xsettings): Move font inside HAVE_XFT.
6428 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6429 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6430 Move inside HAVE_XFT.
6431 (something_changed_gsettingsCB): Rename from something_changedCB.
6432 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6433 also.
6434 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6435 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6436 (something_changed_gconfCB): Rename from something_changedCB.
6437 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6438 (parse_settings): Move check for font inside HAVE_XFT.
6439 (read_settings, apply_xft_settings): Add comment.
6440 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6441 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6442 call store_font_name_changed.
6443 (xft_settings_event): Add comment.
6444 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6445 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6446 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6447 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6448 (xsettings_initialize): Call init_gsettings last.
6449 (xsettings_get_system_font, xsettings_get_system_normal_font):
6450 Add comment.
6452 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6454 Random fixes. E.g., (random) never returned negative values.
6455 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6456 subseconds part to the entropy, as that's a bit more random.
6457 Prefer signed to unsigned, since the signedness doesn't matter and
6458 in general we prefer signed. When given a limit, use a
6459 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6460 latter isn't right if USE_2_TAGS_FOR_INTS.
6461 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6462 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6464 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6466 * textprop.c (text_property_stickiness):
6467 Obey Vtext_property_default_nonsticky.
6468 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6469 * w32fns.c (syms_of_w32fns):
6470 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6472 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6474 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6475 This is more efficient than Ffile_directory_p and avoids a minor race.
6477 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6479 * buffer.c (Foverlay_put): Say what the return value is
6480 (bug#7835).
6482 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6483 is a directory before asking whether to use the file name
6484 (bug#7564).
6485 (barf_or_query_if_file_exists): Make the "File is a directory"
6486 error be more correct.
6488 * fns.c (Frequire): Remove the mention of the .gz files, since
6489 that's installation-specific, but keep the mention of
6490 `get-load-suffixes'.
6492 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6494 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6495 Report string overflow if the output is too long.
6497 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6499 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6500 (syms_of_gnutls): Remove duplicate DEFSYM for
6501 Qgnutls_bootprop_verify_hostname_error, an error for
6502 Qgnutls_bootprop_verify_error (which is no longer used).
6504 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6505 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6506 Also (re)move comments that are misplaced or no longer relevant.
6508 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6510 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6512 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6514 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6515 and background color parameters if they have been changed.
6517 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6519 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6521 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6523 * xsettings.c (SYSTEM_FONT): Define only when used.
6524 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6526 * keymap.c (access_keymap_1): Now static.
6528 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6530 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6531 leave any prefix arg for the up event (Bug#1586).
6533 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6535 * lread.c (syms_of_lread): Mention single symbols defined by
6536 `defvar' or `defconst' (bug#7154).
6538 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6539 (Frequire): Mention get-load-suffixes.
6541 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6543 * window.h (window): Remove clone_number slot.
6544 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6545 Remove.
6546 (make_parent_window, make_window, saved_window)
6547 (Fset_window_configuration, save_window_save): Don't deal with
6548 clone numbers.
6549 * buffer.c (Qclone_number): Remove declaration.
6550 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6552 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6554 Add multiple inheritance to keymaps.
6555 * keymap.c (Fmake_composed_keymap): New function.
6556 (Fset_keymap_parent): Simplify.
6557 (fix_submap_inheritance): Remove.
6558 (access_keymap_1): New function extracted from access_keymap to handle
6559 embedded parents and handle lists of maps.
6560 (access_keymap): Use it.
6561 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6562 (Fcopy_keymap): Handle embedded parents.
6563 (Fcommand_remapping, define_as_prefix): Simplify.
6564 (Fkey_binding): Simplify.
6565 (syms_of_keymap): Move minibuffer-local-completion-map,
6566 minibuffer-local-filename-completion-map,
6567 minibuffer-local-must-match-map, and
6568 minibuffer-local-filename-must-match-map to Elisp.
6569 (syms_of_keymap): Defsubr make-composed-keymap.
6570 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6571 (parse_menu_item): Trivial simplification.
6573 2011-07-01 Glenn Morris <rgm@gnu.org>
6575 * Makefile.in (SETTINGS_LIBS): Fix typo.
6577 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6579 * coding.c (Fencode_coding_string): Record the last coding system
6580 used, as the function doc string says (bug#8738).
6582 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6584 * xsettings.c (store_monospaced_changed): Take new font as arg and
6585 check for change against current_mono_font.
6586 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6587 (emacs_settings_constructor, emacs_settings_get_property)
6588 (emacs_settings_set_property, emacs_settings_class_init)
6589 (emacs_settings_init, gsettings_obj): Remove.
6590 (something_changedCB): New function for HAVE_GSETTINGS.
6591 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6592 with value as argument.
6593 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6594 g_settings_new (Bug#8967). Do not create gsettings_obj.
6595 Remove calls to g_settings_bind. Connect something_changedCB to
6596 "changed".
6598 * xgselect.c: Add defined (HAVE_GSETTINGS).
6599 (xgselect_initialize): Ditto.
6601 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6602 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6603 xg_select.
6605 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6607 * eval.c (struct backtrace): Simplify and port the data structure.
6608 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6609 signed bit field, as this assumption is not portable and it makes
6610 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6611 "char debug_on_exit : 1" as this is not portable either; instead,
6612 use the portable "unsigned int debug_on_exit : 1". Remove unused
6613 member evalargs. Remove obsolete comments about cc bombing out.
6615 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6617 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6618 Let HAVE_GSETTINGS override HAVE_GCONF.
6619 (store_monospaced_changed): New function.
6620 (EMACS_SETTINGS): A new type derived from GObject to handle
6621 GSettings notifications.
6622 (emacs_settings_constructor, emacs_settings_get_property)
6623 (emacs_settings_set_property, emacs_settings_class_init):
6624 New functions.
6625 (gsettings_client, gsettings_obj): New variables.
6626 (GSETTINGS_SCHEMA): New define.
6627 (something_changedCB): Call store_monospaced_changed.
6628 (init_gsettings): New function.
6629 (xsettings_initialize): Call init_gsettings.
6630 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6631 to NULL.
6633 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6634 GCONF_CFLAGS/LIBS.
6636 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6638 * window.c (resize_root_window, grow_mini_window)
6639 (shrink_mini_window): Rename Qresize_root_window to
6640 Qwindow_resize_root_window and Qresize_root_window_vertically to
6641 Qwindow_resize_root_window_vertically.
6643 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6645 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6647 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6649 * makefile.w32-in: Redesign dependencies so they reflect more
6650 clearly which files are directly included by each source file,
6651 and not through other includes.
6653 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6655 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6656 (sort_overlays, overlay_strings): When an overlay's clone number
6657 matches the window's clone number process the overlay even if
6658 the overlay's window property doesn't match the current window.
6660 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6661 (Fwindow_hchild): Rename to Fwindow_left_child.
6662 (Fwindow_next): Rename to Fwindow_next_sibling.
6663 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6664 (resize_window_check): Rename to window_resize_check.
6665 (resize_window_apply): Rename to window_resize_apply.
6666 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6667 (Fdelete_other_windows_internal, resize_frame_windows)
6668 (Fsplit_window_internal, Fdelete_window_internal)
6669 (grow_mini_window, shrink_mini_window)
6670 (Fresize_mini_window_internal): Fix callers accordingly.
6672 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6674 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6675 (emacs_fixed_set_min_size): Remove.
6676 (emacs_fixed_new): Take frame as argument.
6678 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6679 (_EmacsFixedPrivate): Remove minwidth/height.
6680 Add struct frame *f.
6681 (emacs_fixed_init): Initialize priv->f.
6682 (get_parent_class, emacs_fixed_set_min_size): Remove.
6683 (emacs_fixed_new): Set priv->f to argument.
6684 (emacs_fixed_get_preferred_width)
6685 (emacs_fixed_get_preferred_height): Use min_width/height from
6686 frames size_hint to set minimum and natural (Bug#8919).
6687 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6688 and use min_width/height from frames size_hint to set
6689 min_width/height (Bug#8919).
6691 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6692 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6693 Fix indentation.
6695 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6697 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6698 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6699 called at ZV.
6701 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6703 * process.c (wait_reading_process_output): Bypass select if
6704 waiting for a cell while ignoring keyboard input, and input is
6705 pending. Suggested by Jan Djärv (Bug#8869).
6707 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6709 Use gnulib's dup2 module instead of rolling our own.
6710 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6712 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6714 * dispnew.c (scrolling_window): Before scrolling, turn off a
6715 mouse-highlight in the window being scrolled.
6717 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6719 Move DEFSYM to lisp.h and use everywhere.
6721 * character.h (DEFSYM): Move declaration...
6722 * lisp.h (DEFSYM): ...here.
6724 * gnutls.c:
6725 * minibuf.c:
6726 * w32menu.c:
6727 * w32proc.c:
6728 * w32select.c: Don't include character.h.
6730 * alloc.c (syms_of_alloc):
6731 * buffer.c (syms_of_buffer):
6732 * bytecode.c (syms_of_bytecode):
6733 * callint.c (syms_of_callint):
6734 * casefiddle.c (syms_of_casefiddle):
6735 * casetab.c (init_casetab_once):
6736 * category.c (init_category_once, syms_of_category):
6737 * ccl.c (syms_of_ccl):
6738 * cmds.c (syms_of_cmds):
6739 * composite.c (syms_of_composite):
6740 * dbusbind.c (syms_of_dbusbind):
6741 * dired.c (syms_of_dired):
6742 * dispnew.c (syms_of_display):
6743 * doc.c (syms_of_doc):
6744 * editfns.c (syms_of_editfns):
6745 * emacs.c (syms_of_emacs):
6746 * eval.c (syms_of_eval):
6747 * fileio.c (syms_of_fileio):
6748 * fns.c (syms_of_fns):
6749 * frame.c (syms_of_frame):
6750 * fringe.c (syms_of_fringe):
6751 * insdel.c (syms_of_insdel):
6752 * keymap.c (syms_of_keymap):
6753 * lread.c (init_obarray, syms_of_lread):
6754 * macros.c (syms_of_macros):
6755 * msdos.c (syms_of_msdos):
6756 * print.c (syms_of_print):
6757 * process.c (syms_of_process):
6758 * search.c (syms_of_search):
6759 * sound.c (syms_of_sound):
6760 * syntax.c (init_syntax_once, syms_of_syntax):
6761 * terminal.c (syms_of_terminal):
6762 * textprop.c (syms_of_textprop):
6763 * undo.c (syms_of_undo):
6764 * w32.c (globals_of_w32):
6765 * window.c (syms_of_window):
6766 * xdisp.c (syms_of_xdisp):
6767 * xfaces.c (syms_of_xfaces):
6768 * xfns.c (syms_of_xfns):
6769 * xmenu.c (syms_of_xmenu):
6770 * xsettings.c (syms_of_xsettings):
6771 * xterm.c (syms_of_xterm): Use DEFSYM.
6773 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6775 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6777 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6779 Integer and buffer overflow fixes (Bug#8873).
6781 * print.c (printchar, strout): Check for string overflow.
6782 (PRINTPREPARE, printchar, strout):
6783 Don't set size unless allocation succeeds.
6785 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6786 for sizes. Check for string overflow more accurately.
6787 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6789 * macros.c: Integer and buffer overflow fixes.
6790 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6791 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6792 Use ptrdiff_t, not int, for sizes.
6793 Don't increment bufsize until after realloc succeeds.
6794 Check for size-calculation overflow.
6795 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6797 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6799 * lread.c: Integer overflow fixes.
6800 (read_integer): Radix is now EMACS_INT, not int,
6801 to improve quality of diagnostics for out-of-range radices.
6802 Calculate buffer size correctly for out-of-range radices.
6803 (read1): Check for integer overflow in radices, and in
6804 read-circle numbers.
6805 (read_escape): Avoid int overflow.
6806 (Fload, openp, read_buffer_size, read1)
6807 (substitute_object_recurse, read_vector, read_list, map_obarray):
6808 Use ptrdiff_t, not int, for sizes.
6809 (read1): Use EMACS_INT, not int, for sizes.
6810 Check for size overflow.
6812 * image.c (cache_image): Check for size arithmetic overflow.
6814 * lread.c: Integer overflow issues.
6815 (saved_doc_string_size, saved_doc_string_length)
6816 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6817 Now ptrdiff_t, not int.
6818 (read1): Don't assume doc string length fits in int. Check for
6819 out-of-range doc string lengths.
6820 (read_list): Don't assume file position fits in int.
6821 (read_escape): Check for hex character overflow.
6823 2011-06-22 Leo Liu <sdl.web@gmail.com>
6825 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6826 Move to minibuffer.el.
6828 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6830 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6831 The following patches are for when GLYPH_DEBUG && !XASSERT.
6832 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6833 * dispnew.c (flush_stdout):
6834 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6835 Mark as externally visible.
6836 * dispnew.c (check_window_matrix_pointers): Now static.
6837 * dispnew.c (window_to_frame_vpos):
6838 * xfns.c (unwind_create_frame):
6839 * xterm.c (x_check_font): Remove unused local.
6840 * scroll.c (CHECK_BOUNDS):
6841 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6842 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6843 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6844 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6845 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6846 Now static.
6847 (debug_method_add): Use va_list and vsprintf rather than relying
6848 on undefined behavior with wrong number of arguments.
6849 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6850 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6851 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6852 since we're not interested in debugging glyphs with old libraries.
6853 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6854 GCC 4.6.0's static checking.
6856 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6858 Integer overflow and signedness fixes (Bug#8873).
6859 A few related buffer overrun fixes, too.
6861 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6863 * dispextern.h (struct face.stipple):
6864 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6865 (x_bitmap_mask, x_allocate_bitmap_record)
6866 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6867 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6868 (x_create_bitmap_from_xpm_data):
6869 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6870 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6871 (.bitmaps_last):
6872 * xfaces.c (load_pixmap):
6873 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6874 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6875 (.bitmaps_last, struct x_output.icon_bitmap):
6876 Use ptrdiff_t, not int, for bitmap indexes.
6877 (x_allocate_bitmap_record): Check for size overflow.
6878 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6880 Use ptrdiff_t, not int, for overlay counts.
6881 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6882 * editfns.c (overlays_around, get_pos_property):
6883 * textprop.c (get_char_property_and_overlay):
6884 * xdisp.c (next_overlay_change, note_mouse_highlight):
6885 * xfaces.c (face_at_buffer_position):
6886 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6887 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6888 (Fnext_overlay_change, Fprevious_overlay_change)
6889 (mouse_face_overlay_overlaps, Foverlays_in):
6890 Use ptrdiff_t, not int, for sizes.
6891 (overlays_at, overlays_in): Check for size-calculation overflow.
6893 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6895 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6896 (x_session_initialize): Do not assume string length fits in int.
6898 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6899 This is unlikely, but can occur if DPI is outlandish.
6901 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6902 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6904 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6905 * xrdb.c (magic_file_p, search_magic_path):
6906 Omit last arg SUFFIX; it was always 0. All callers changed.
6907 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6909 * xfont.c (xfont_match): Avoid need for strlen.
6911 * xfns.c: Don't assume strlen fits in int.
6912 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6914 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6915 not unsigned long, as we prefer signed integers. All callers changed.
6916 Detect integer overflow in repeat count.
6917 (message_dolog): Don't assume print length fits in 39 bytes.
6918 (display_mode_element): Don't assume strlen fits in int.
6920 * termcap.c: Don't assume sizes fit in int and never overflow.
6921 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6922 (gobble_line): Check for size-calculation overflow.
6924 * minibuf.c (Fread_buffer):
6925 * lread.c (intern, intern_c_string):
6926 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6927 Don't assume string length fits in int.
6929 * keyboard.c (parse_tool_bar_item):
6930 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6932 * font.c: Don't assume string length fits in int.
6933 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6934 Use ptrdiff_t, not int.
6935 (font_intern_prop): Don't assume string length fits in int.
6936 Don't assume integer property fits in fixnum.
6937 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6939 * filelock.c: Fix some buffer overrun and integer overflow issues.
6940 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6941 Reformulate so as not to need the command string.
6942 Invoke gzip -cd rather than gunzip, as it's more portable.
6943 (lock_info_type, lock_file_1, lock_file):
6944 Don't assume pid_t and time_t fit in unsigned long.
6945 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6946 (current_lock_owner): Prefer signed type for sizes.
6947 Use memcpy, not strncpy, where memcpy is what is really wanted.
6948 Don't assume (via atoi) that time_t and pid_t fit in int.
6949 Check for time_t and/or pid_t out of range, e.g., via a network share.
6950 Don't alloca where an auto var works fine.
6952 * fileio.c: Fix some integer overflow issues.
6953 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6954 Don't assume string length fits in int.
6955 (directory_file_name): Don't assume string length fits in long.
6956 (make_temp_name): Don't assume pid fits in int, or that its print
6957 length is less than 20.
6959 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6961 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6963 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6965 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6966 We prefer signed integers, even for size calculations.
6968 * emacs.c: Don't assume string length fits in 'int'.
6969 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6970 (main): Don't invoke strlen when not needed.
6972 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6973 (XD_DEBUG_MESSAGE): Don't waste a byte.
6975 * callproc.c (getenv_internal_1, getenv_internal)
6976 (Fgetenv_internal):
6977 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6979 * lread.c (invalid_syntax): Omit length argument.
6980 All uses changed. This doesn't fix a bug, but it simplifies the
6981 code away from its former Hollerith-constant appearance, and it's
6982 one less 'int' to worry about when looking at integer-overflow issues.
6983 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6985 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6986 This didn't break anything, but it didn't help either.
6987 It's confusing to put a bogus integer in a place where the actual
6988 value does not matter.
6989 (LIST_END_P): Remove unused macro and its bogus comment.
6990 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6992 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6993 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6994 implementation.
6995 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6996 We prefer signed types, and the value cannot exceed the EMACS_INT
6997 range anyway (because otherwise the length would not be representable).
6998 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6999 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7000 This avoids a GCC warning when WIDE_EMACS_INT.
7002 * indent.c (sane_tab_width): New function.
7003 (current_column, scan_for_column, Findent_to, position_indentation)
7004 (compute_motion): Use it. This is just for clarity.
7005 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7007 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7009 * lisp.h (lint_assume): New macro.
7010 * composite.c (composition_gstring_put_cache):
7011 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7013 * editfns.c, insdel.c:
7014 Omit unnecessary forward decls, to simplify future changes.
7016 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7018 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7020 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7021 Use much-faster test for byte-length change.
7022 Don't assume string byte-length fits in 'int'.
7023 Check that character arg fits in 'int'.
7024 (mapcar1): Declare byte as byte, for clarity.
7026 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7028 * fns.c (concat): Catch string overflow earlier.
7029 Do not rely on integer wraparound.
7031 * dispextern.h (struct it.overlay_strings_charpos)
7032 (struct it.selective): Now EMACS_INT, not int.
7033 * xdisp.c (forward_to_next_line_start)
7034 (back_to_previous_visible_line_start)
7035 (reseat_at_next_visible_line_start, next_element_from_buffer):
7036 Don't arbitrarily truncate the value of 'selective' to int.
7038 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7040 * composite.c: Don't truncate sizes to 'int'.
7041 (composition_gstring_p, composition_reseat_it)
7042 (composition_adjust_point): Use EMACS_INT, not int.
7043 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7044 not EMACS_UINT, for indexes.
7046 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7048 * buffer.c: Include <verify.h>.
7049 (struct sortvec.priority, struct sortstr.priority):
7050 Now EMACS_INT, not int.
7051 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7052 (struct sortstr.size, record_overlay_string)
7053 (struct sortstrlist.size, struct sortlist.used):
7054 Don't truncate size to int.
7055 (record_overlay_string): Check for size-calculation overflow.
7056 (init_buffer_once): Check at compile-time, not run-time.
7058 2011-06-22 Jim Meyering <meyering@redhat.com>
7060 Don't leak an XBM-image-sized buffer
7061 * image.c (xbm_load): Free the image buffer after using it.
7063 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7065 Port to Sun C.
7066 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7067 that Sun C diagnosed.
7068 * fns.c (secure_hash): Fix pointer signedness issue.
7069 * intervals.c (static_offset_intervals): New function.
7070 (offset_intervals): Use it.
7072 2011-06-21 Leo Liu <sdl.web@gmail.com>
7074 * deps.mk (fns.o):
7075 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7076 sha512.h.
7078 * fns.c (secure_hash): Rename from crypto_hash_function and change
7079 the first arg to accept symbols.
7080 (Fsecure_hash): New primitive.
7081 (syms_of_fns): New symbols.
7083 2011-06-20 Deniz Dogan <deniz@dogan.se>
7085 * process.c (Fset_process_buffer): Clarify return value in
7086 docstring.
7088 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7090 * dispnew.c (add_window_display_history): Use BVAR.
7092 * xdisp.c (debug_method_add): Use BVAR.
7093 (check_window_end, dump_glyph_matrix, dump_glyph)
7094 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7096 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7097 Likewise.
7099 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7100 check till after the cache is created in init_frame_faces.
7102 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7104 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7106 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7108 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7109 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7110 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7112 Improve buffer-overflow checking (Bug#8873).
7113 * fileio.c (Finsert_file_contents):
7114 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7115 Remove the old (too-loose) buffer overflow checks.
7116 They weren't needed, since make_gap checks for buffer overflow.
7117 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7118 The old code merely checked for Emacs fixnum overflow, and relied
7119 on undefined (wraparound) behavior. The new code avoids undefined
7120 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7122 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7123 Tune. Don't use wider integers than needed. Don't use alloca.
7124 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7126 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7128 * insdel.c, lisp.h (buffer_overflow): New function.
7129 (insert_from_buffer_1, replace_range, replace_range_2):
7130 * insdel.c (make_gap_larger):
7131 * editfns.c (Finsert_char):
7132 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7134 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7136 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7138 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7140 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7141 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7143 * fileio.c: Don't assume EMACS_INT fits in off_t.
7144 (emacs_lseek): New static function.
7145 (Finsert_file_contents, Fwrite_region): Use it.
7146 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7148 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7150 * fns.c: Don't overflow int when computing a list length.
7151 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7152 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7153 truncation on 64-bit hosts. Check for QUIT every
7154 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7155 faster and is responsive enough.
7156 (Flength): Report an error instead of overflowing an integer.
7157 (Fsafe_length): Return a float if the value is not representable
7158 as a fixnum. This shouldn't happen except in contrived situations.
7159 (Fnthcdr, Fsort): Don't assume list length fits in int.
7160 (Fcopy_sequence): Don't assume vector length fits in int.
7162 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7163 (header_size, word_size): New constants.
7164 (allocate_vectorlike): Don't check size overflow here.
7165 (allocate_vector): Check it here instead, since this is the only
7166 caller of allocate_vectorlike that could cause overflow.
7167 Check that the new vector's length is representable as a fixnum.
7169 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7170 The previous code was bogus. For example, next_almost_prime (32)
7171 returned 39, which is undesirable as it is a multiple of 3; and
7172 next_almost_prime (24) returned 25, which is a multiple of 5 so
7173 why was the code bothering to check for multiples of 7?
7175 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7177 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7179 Variadic C functions now count arguments with ptrdiff_t.
7180 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7181 Back then I didn't know that the Emacs coding style prefers signed int.
7182 Also, in the meantime I found a few more instances where arguments
7183 were being counted with int, which may truncate counts on 64-bit
7184 machines, or EMACS_INT, which may be unnecessarily wide.
7185 * lisp.h (struct Lisp_Subr.function.aMANY)
7186 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7187 Arg counts are now ptrdiff_t, not size_t.
7188 All variadic functions and their callers changed accordingly.
7189 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7190 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7191 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7192 * callint.c (Fcall_interactively): Check arg count for overflow,
7193 to avoid potential buffer overrun. Use signed char, not 'int',
7194 for 'varies' array, so that we needn't bother to check its size
7195 calculation for overflow.
7196 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7197 * eval.c (apply_lambda):
7198 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7199 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7200 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7202 * callint.c (Fcall_interactively): Don't use index var as event count.
7204 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7205 * mem-limits.h (SIZE): Remove; no longer used.
7207 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7209 Remove unnecessary casts.
7210 * xterm.c (x_term_init):
7211 * xfns.c (x_set_border_pixel):
7212 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7213 These aren't needed now that we assume ANSI C.
7215 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7216 It's more likely to cause problems (due to unsigned overflow)
7217 than to cure them.
7219 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7221 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7223 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7225 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7227 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7229 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7231 GLYPH_CODE_FACE returns EMACS_INT, not int.
7232 * dispextern.h (merge_faces):
7233 * xfaces.c (merge_faces):
7234 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7235 Don't assume EMACS_INT fits in int.
7237 * character.h (CHAR_VALID_P): Remove unused parameter.
7238 * fontset.c, lisp.h, xdisp.c: All uses changed.
7240 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7242 * fns.c (concat): Minor tuning based on overflow analysis.
7243 This doesn't fix any bugs. Use int to hold character, instead
7244 of constantly refetching from Emacs object. Use XFASTINT, not
7245 XINT, for value known to be a character. Don't bother comparing
7246 a single byte to 0400, as it's always less.
7248 * floatfns.c (Fexpt):
7249 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7251 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7252 for characters.
7254 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7256 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7257 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7258 incorrectly succeed when S was a string, because 4294967386 was
7259 truncated before it was used.
7261 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7262 Otherwise, an out-of-range integer could cause undefined behavior
7263 on a 64-bit host.
7265 * composite.c: Use int, not EMACS_INT, for characters.
7266 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7267 EMACS_INT, for values that are known to be in character range.
7268 This doesn't fix any bugs but is the usual style inside Emacs and
7269 may generate better code on 32-bit machines.
7271 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7272 This is for reasons similar to the recent CHAR_STRING fix.
7273 * charset.c (Fencode_char): Check that character arg is actually
7274 a character. Pass an int to ENCODE_CHAR.
7275 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7276 wider than 'int', as a compile-time check to prevent future regressions
7277 in this area.
7279 * character.c (char_string): Remove unnecessary casts.
7281 Make sure a 64-bit char is never passed to CHAR_STRING.
7282 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7283 by silently ignoring the top 32 bits, allowing some values
7284 that were far too large to be valid characters.
7285 * character.h: Include <verify.h>.
7286 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7287 arguments are no wider than unsigned, as a compile-time check
7288 to prevent future regressions in this area.
7289 * data.c (Faset):
7290 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7291 (Fsubst_char_in_region):
7292 * fns.c (concat):
7293 * xdisp.c (decode_mode_spec_coding):
7294 Adjust to CHAR_STRING's new requirement.
7295 * editfns.c (Finsert_char, Fsubst_char_in_region):
7296 * fns.c (concat): Check that character args are actually
7297 characters. Without this test, these functions did the wrong
7298 thing with wildly out-of-range values on 64-bit hosts.
7300 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7301 These casts should not be needed on 32-bit hosts, either.
7302 * keyboard.c (read_char):
7303 * lread.c (Fload): Remove casts to unsigned.
7305 * lisp.h (UNSIGNED_CMP): New macro.
7306 This fixes comparison bugs on 64-bit hosts.
7307 (ASCII_CHAR_P): Use it.
7308 * casefiddle.c (casify_object):
7309 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7310 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7311 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7312 * dispextern.h (FACE_FROM_ID):
7313 * keyboard.c (read_char): Use UNSIGNED_CMP.
7315 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7316 not to EMACS_INT, to avoid GCC warning.
7318 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7320 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7321 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7322 isn't needed on 32-bit machines.
7324 * buffer.c (Fgenerate_new_buffer_name):
7325 Use EMACS_INT for count, not int.
7326 (advance_to_char_boundary): Return EMACS_INT, not int.
7328 * data.c (Qcompiled_function): Now static.
7330 * window.c (window_body_lines): Now static.
7332 * image.c (gif_load): Rename local to avoid shadowing.
7334 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7335 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7336 * alloc.c (make_save_value): Integer argument is now of type
7337 ptrdiff_t, not int.
7338 (mark_object): Use ptrdiff_t, not int.
7339 * lisp.h (pD): New macro.
7340 * print.c (print_object): Use it.
7342 * alloc.c: Use EMACS_INT, not int, to count objects.
7343 (total_conses, total_markers, total_symbols, total_vector_size)
7344 (total_free_conses, total_free_markers, total_free_symbols)
7345 (total_free_floats, total_floats, total_free_intervals)
7346 (total_intervals, total_strings, total_free_strings):
7347 Now EMACS_INT, not int. All uses changed.
7348 (Fgarbage_collect): Compute overall total using a double, so that
7349 integer overflow is less likely to be a problem. Check for overflow
7350 when converting back to an integer.
7351 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7352 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7353 These were 'int' variables that could overflow on 64-bit hosts;
7354 they were never used, so remove them instead of repairing them.
7355 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7356 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7357 Previously, this ceilinged at INT_MAX, but that doesn't work on
7358 64-bit machines.
7359 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7361 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7362 (allocate_vectorlike): Check for ptrdiff_t overflow.
7363 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7364 when a (possibly-narrower) signed value would do just as well.
7365 We prefer using signed arithmetic, to avoid comparison confusion.
7367 * alloc.c: Catch some string size overflows that we were missing.
7368 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7369 for convenience in STRING_BYTES_MAX.
7370 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7371 The definition here is exact; the one in lisp.h was approximate.
7372 (allocate_string_data): Check for string overflow. This catches
7373 some instances we weren't catching before. Also, it catches
7374 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7375 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7376 and ptrdiff_t and EMACS_INT are both 64 bits.
7378 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7379 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7380 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7382 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7384 * alloc.c (Fmake_string): Check for out-of-range init.
7386 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7388 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7390 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7392 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7393 xg_get_default_scrollbar_width.
7395 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7396 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7397 (style_changed_cb): Call update_theme_scrollbar_width and call
7398 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7399 all frames (Bug#8505).
7400 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7401 Call gtk_window_set_resizable if HAVE_GTK3.
7402 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7403 and height if HAVE_GTK3 (Bug#8505).
7404 (scroll_bar_width_for_theme): New variable.
7405 (update_theme_scrollbar_width): New function.
7406 (xg_get_default_scrollbar_width): Move code to
7407 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7408 (xg_initialize): Call update_theme_scrollbar_width.
7410 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7412 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7414 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7416 * frame.c (make_frame): Call other_buffer_safely instead of
7417 other_buffer.
7419 * window.c (temp_output_buffer_show): Call display_buffer with
7420 second argument Vtemp_buffer_show_specifiers and reset latter
7421 immediately after the call.
7422 (Vtemp_buffer_show_specifiers): New variable.
7423 (auto_window_vscroll_p, next_screen_context_lines)
7424 (Vscroll_preserve_screen_position): Remove leading asterisks from
7425 doc-strings.
7427 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7429 Fix minor problems found by GCC 4.6.0 static checking.
7430 * buffer.c (Qclone_number): Remove for now, as it's unused.
7431 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7432 (record_buffer): Remove unused local.
7433 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7434 (set_frame_buffer_list): Remove; unused.
7435 * frame.h (other_visible_frames): Remove decl.
7436 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7437 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7438 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7439 if HAVE_GPM.
7440 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7441 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7442 Define only if HAVE_GPM.
7443 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7444 (update_hints_inhibit): Remove; never set. All uses removed.
7445 * widgetprv.h (emacsFrameClassRec): Remove decl.
7446 * window.c (delete_deletable_window): Now returns void, since it
7447 wasn't returning anything.
7448 (compare_window_configurations): Remove unused locals.
7449 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7450 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7451 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7452 the same widths as pointers. This follows up on the 2011-05-06 patch.
7453 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7454 * xterm.h: Likewise.
7455 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7457 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7459 * makefile.w32-in: Update dependencies.
7460 (LISP_H): Add lib/intprops.h.
7462 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7464 * image.c (gif_load): Add animation frame delay to the metadata.
7465 (syms_of_image): Use DEFSYM. New symbol `delay'.
7467 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7469 * window.c (delete_deletable_window): Re-add.
7470 (Fset_window_configuration): Rewrite to handle dead buffers and
7471 consequently deletable windows.
7472 (window_tree, Fwindow_tree): Remove. Supply functionality in
7473 window.el.
7474 (compare_window_configurations): Simplify code.
7476 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7478 * image.c (imagemagick_load_image): Fix type mismatch.
7479 (Fimagemagick_types): Likewise.
7481 * window.h (replace_buffer_in_windows): Declare.
7483 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7485 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7486 Qclone_number. Remove external declaration of Qdelete_window.
7487 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7488 code.
7489 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7490 Run Qbuffer_list_update_hook if allowed.
7491 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7492 buffer list implementation.
7493 (other_buffer_safely): New function.
7494 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7495 calls to replace_buffer_in_windows and
7496 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7497 if allowed.
7498 (record_buffer): Inhibit quitting and rewrite using quittable
7499 functions. Run Qbuffer_list_update_hook if allowed.
7500 (Frecord_buffer, Funrecord_buffer): New functions.
7501 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7502 Move switch-to-buffer to window.el.
7503 (bury-buffer): Move to window.el.
7504 (Vbuffer_list_update_hook): New variable.
7506 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7507 section.
7509 * window.h (resize_frame_windows): Move up in code.
7510 (Fwindow_frame): Remove EXFUN.
7511 (replace_buffer_in_all_windows): Remove prototype.
7512 (replace_buffer_in_windows_safely): Add prototype.
7514 * window.c: Declare Qdelete_window static again. Move down
7515 declaration of select_count.
7516 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7517 (Fother_window): Move to window.el.
7518 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7519 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7520 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7521 window.el.
7522 (replace_buffer_in_windows): Implement by calling
7523 Qreplace_buffer_in_windows.
7524 (replace_buffer_in_all_windows): Remove with some functionality
7525 moved into replace_buffer_in_windows_safely.
7526 (replace_buffer_in_windows_safely): New function.
7527 (select_window_norecord, select_frame_norecord): Move in front
7528 of run_window_configuration_change_hook. Remove now obsolete
7529 declarations.
7530 (Fset_window_buffer): Rewrite doc-string.
7531 Call Qrecord_window_buffer.
7532 (keys_of_window): Move binding for other-window to window.el.
7534 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7536 * dispextern.h (struct image): Replace data member, whose int_val
7537 and ptr_val fields were not used by anything, with a single
7538 lisp_val object.
7540 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7541 (gif_clear_image, gif_load, imagemagick_load_image)
7542 (gs_clear_image, gs_load): Callers changed.
7544 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7546 * buffer.h: Include <time.h>, for time_t.
7547 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7549 Fix minor problems found by static checking.
7551 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7553 Make identifiers static if they are not used in other modules.
7554 * data.c (Qcompiled_function, Qframe, Qvector):
7555 * image.c (QimageMagick, Qsvg):
7556 * minibuf.c (Qmetadata):
7557 * window.c (resize_window_check, resize_root_window): Now static.
7558 * window.h (resize_window_check, resize_root_window): Remove decls.
7560 * window.c (window_deletion_count, delete_deletable_window):
7561 Remove; unused.
7562 (window_body_lines): Now static.
7563 (Fdelete_other_windows_internal): Mark vars as initialized.
7564 Make sure 'resize_failed' is initialized.
7565 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7566 (resize_window_apply): Remove unused local.
7567 * window.h (delete_deletable_window): Remove decl.
7569 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7570 (imagemagick_load_image): Fix pointer signedness problem by changing
7571 last arg from unsigned char * to char *. All uses changed.
7572 Also, fix a local for similar reasons.
7573 Remove unused locals. Remove locals to avoid shadowing.
7574 (fn_rsvg_handle_free): Remove; unused.
7575 (svg_load, svg_load_image): Fix pointer signedness problem.
7576 (imagemagick_load_image): Don't use garbage pointer image_wand.
7578 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7580 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7582 * image.c (gif_load): Fix omitted cast error introduced by
7583 2011-06-06 change.
7585 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7587 * window.h (resize_proportionally, orig_total_lines)
7588 (orig_top_line): Remove from window structure.
7589 (set_window_height, set_window_width, change_window_heights)
7590 (Fdelete_window): Remove prototypes.
7591 (resize_frame_windows): Remove duplicate declaration.
7593 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7595 * window.h (resize_frame_windows, resize_window_check)
7596 (delete_deletable_window, resize_root_window)
7597 (resize_frame_windows): Declare prototypes.
7599 * window.c (resize_window_apply): Make definition be "static" to
7600 match the prototype.
7602 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7604 * window.c: Remove declarations of Qwindow_size_fixed,
7605 window_min_size_1, window_min_size_2, window_min_size,
7606 size_window, window_fixed_size_p, enlarge_window, delete_window.
7607 Remove static from declaration of Qdelete_window, it's
7608 temporarily needed by Fbury_buffer.
7609 (replace_window): Don't assign orig_top_line and
7610 orig_total_lines.
7611 (Fdelete_window, delete_window): Remove. Window deletion is
7612 handled by window.el.
7613 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7614 Replace Fdelete_window calls with calls to Qdelete_window.
7615 (Fdelete_other_windows): Remove. Deleting other windows is
7616 handled by window.el.
7617 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7618 handled in window.el.
7619 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7620 Window minimum sizes are handled in window.el.
7621 (shrink_windows, size_window, set_window_height)
7622 (set_window_width, change_window_heights, window_height)
7623 (window_width, CURBEG, CURSIZE, enlarge_window)
7624 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7625 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7626 handled in window.el.
7627 (make_dummy_parent): Rename to make_parent_window and give it a
7628 second argument horflag.
7629 (make_window): Don't set resize_proportionally any more.
7630 (Fsplit_window): Remove. Windows are split in window.el.
7631 (save_restore_action, save_restore_orig_size)
7632 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7633 Resize mini windows in window.el.
7634 (grow_mini_window, shrink_mini_window): Implement by calling
7635 Qresize_root_window_vertically, resize_window_check and
7636 resize_window_apply.
7637 (saved_window, Fset_window_configuration, save_window_save):
7638 Do not handle orig_top_line, orig_total_lines, and
7639 resize_proportionally.
7640 (window_min_height, window_min_width): Move to window.el.
7641 (keys_of_window): Move bindings for delete-other-windows,
7642 split-window, delete-window and enlarge-window to window.el.
7644 * buffer.c: Temporarily extern Qdelete_window.
7645 (Fbury_buffer): Temporarily call Qdelete_window instead of
7646 Fdelete_window (Fbury_buffer will move to window.el soon).
7648 * frame.c (set_menu_bar_lines_1): Remove code handling
7649 orig_top_line and orig_total_lines.
7651 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7652 set_window_height but set heights directly.
7653 (change_frame_size_1): Use resize_frame_windows.
7655 * xdisp.c (init_xdisp): Don't use set_window_height but set
7656 heights directly.
7658 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7659 Use resize_frame_windows instead of change_window_heights and run
7660 run_window_configuration_change_hook.
7662 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7663 instead of change_window_heights and run
7664 run_window_configuration_change_hook.
7666 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7668 * window.c (replace_window): Rename second argument REPLACEMENT to
7669 NEW. New third argument SETFLAG. Rewrite.
7670 (delete_window, make_dummy_parent): Call replace_window with
7671 third argument 1.
7672 (window_list_1): Move down in code.
7673 (run_window_configuration_change_hook): Move set_buffer part
7674 before select_frame_norecord part in order to unwind correctly.
7675 Rename count1 to count.
7676 (recombine_windows, delete_deletable_window, resize_root_window)
7677 (Fdelete_other_windows_internal)
7678 (Frun_window_configuration_change_hook, make_parent_window)
7679 (resize_window_check, resize_window_apply, Fresize_window_apply)
7680 (resize_frame_windows, Fsplit_window_internal)
7681 (Fdelete_window_internal, Fresize_mini_window_internal):
7682 New functions.
7683 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7685 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7687 * window.h (window): Add some new members to window structure -
7688 normal_lines, normal_cols, new_total, new_normal, clone_number,
7689 splits, nest, prev_buffers, next_buffers.
7690 (WINDOW_TOTAL_SIZE): Move here from window.c.
7691 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7693 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7694 Remove.
7695 (make_dummy_parent): Set new members of windows structure.
7696 (make_window): Move down in code. Handle new members of window
7697 structure.
7698 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7699 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7700 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7701 (Fset_window_prev_buffers, Fwindow_next_buffers)
7702 (Fset_window_next_buffers, Fset_window_clone_number):
7703 New functions.
7704 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7705 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7706 Doc-string fixes.
7707 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7708 Argument WINDOW can be now internal window too.
7709 (Fwindow_use_time): Move up in code.
7710 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7711 Rewrite doc-string.
7712 (Fset_window_configuration, saved_window)
7713 (Fcurrent_window_configuration, save_window_save): Handle new
7714 members of window structure.
7715 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7716 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7717 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7718 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7719 Qget_mru_window, Qresize_root_window,
7720 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7721 Qauto_buffer_name; staticpro them.
7723 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7725 * window.c (Fwindow_total_size, Fwindow_left_column)
7726 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7727 (Fwindow_list_1): New functions.
7728 (window_box_text_cols): Replace with window_body_cols.
7729 (Fwindow_width, Fscroll_left, Fscroll_right):
7730 Use window_body_cols instead of window_box_text_cols.
7731 (delete_window, Fset_window_configuration):
7732 Call delete_all_subwindows with window as argument.
7733 (delete_all_subwindows): Take a window as argument and not a
7734 structure. Rewrite.
7735 (window_loop): Remove handling of GET_LRU_WINDOW and
7736 GET_LARGEST_WINDOW.
7737 (Fget_lru_window, Fget_largest_window): Move to window.el.
7739 * window.h: Extern window_body_cols instead of
7740 window_box_text_cols. delete_all_subwindows now takes a
7741 Lisp_Object as argument.
7743 * indent.c (compute_motion, Fcompute_motion):
7744 Use window_body_cols instead of window_box_text_cols.
7746 * frame.c (delete_frame): Call delete_all_subwindows with root
7747 window as argument.
7749 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7751 * fns.c (Fputhash): Document return value.
7753 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7755 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7757 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7759 Cons<->int and similar integer overflow fixes (Bug#8794).
7761 Check for overflow when converting integer to cons and back.
7762 * charset.c (Fdefine_charset_internal, Fdecode_char):
7763 Use cons_to_unsigned to catch overflow.
7764 (Fencode_char): Use INTEGER_TO_CONS.
7765 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7766 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7767 * data.c (long_to_cons, cons_to_long): Remove.
7768 (cons_to_unsigned, cons_to_signed): New functions.
7769 These signal an error for invalid or out-of-range values.
7770 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7771 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7772 * font.c (Ffont_variation_glyphs):
7773 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7774 * lisp.h: Include <intprops.h>.
7775 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7776 (cons_to_signed, cons_to_unsigned): New decls.
7777 (long_to_cons, cons_to_long): Remove decls.
7778 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7779 (Fprimitive_undo): Use CONS_TO_INTEGER.
7780 * xfns.c (Fx_window_property): Likewise.
7781 * xselect.c: Include <limits.h>.
7782 (x_own_selection, selection_data_to_lisp_data):
7783 Use INTEGER_TO_CONS.
7784 (x_handle_selection_request, x_handle_selection_clear)
7785 (x_get_foreign_selection, Fx_disown_selection_internal)
7786 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7787 (lisp_data_to_selection_data): Use cons_to_unsigned.
7788 (x_fill_property_data): Use cons_to_signed.
7789 Report values out of range.
7791 Check for buffer and string overflow more precisely.
7792 * buffer.h (BUF_BYTES_MAX): New macro.
7793 * lisp.h (STRING_BYTES_MAX): New macro.
7794 * alloc.c (Fmake_string):
7795 * character.c (string_escape_byte8):
7796 * coding.c (coding_alloc_by_realloc):
7797 * doprnt.c (doprnt):
7798 * editfns.c (Fformat):
7799 * eval.c (verror):
7800 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7801 since they may not be the same number.
7802 * editfns.c (Finsert_char):
7803 * fileio.c (Finsert_file_contents):
7804 Likewise for BUF_BYTES_MAX.
7806 * image.c: Use ptrdiff_t, not int, for sizes.
7807 (slurp_file): Switch from int to ptrdiff_t.
7808 All uses changed.
7809 (slurp_file): Check that file size fits in both size_t (for
7810 malloc) and ptrdiff_t (for sanity and safety).
7812 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7813 if b->modtime has its maximal value.
7815 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7817 Don't assume time_t can fit into int.
7818 * buffer.h (struct buffer.modtime): Now time_t, not int.
7819 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7820 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7822 Minor fixes for signed vs unsigned integers.
7823 * character.h (MAYBE_UNIFY_CHAR):
7824 * charset.c (maybe_unify_char):
7825 * keyboard.c (read_char, reorder_modifiers):
7826 XINT -> XFASTINT, since the integer must be nonnegative.
7827 * ftfont.c (ftfont_spec_pattern):
7828 * keymap.c (access_keymap, silly_event_symbol_error):
7829 XUINT -> XFASTINT, since the integer must be nonnegative.
7830 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7831 since it makes no difference and we prefer signed.
7832 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7833 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7834 nonnegative.
7836 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7838 * window.h (Fwindow_frame): Declare.
7840 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7842 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7843 (SPARE_MEMORY): Always define.
7844 (LARGE_REQUEST): Remove.
7845 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7847 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7849 * lisp.h: Move EXFUNS for Fframe_root_window,
7850 Fframe_first_window and Fset_frame_selected_window to window.h.
7852 * window.h: Move EXFUNS for Fframe_root_window,
7853 Fframe_first_window and Fset_frame_selected_window here from
7854 lisp.h.
7856 * frame.c (Fwindow_frame, Fframe_first_window)
7857 (Fframe_root_window, Fframe_selected_window)
7858 (Fset_frame_selected_window): Move to window.c.
7859 (Factive_minibuffer_window): Move to minibuf.c.
7860 (Fother_visible_frames_p): New function.
7862 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7864 * window.c (decode_window, decode_any_window): Move up in code.
7865 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7866 (inhibit_frame_unsplittable): Remove unused variable.
7867 (Fwindow_buffer): Move up and rewrite doc-string.
7868 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7869 (Fwindow_prev): New functions.
7870 (Fwindow_frame): Move here from frame.c. Accept any window as
7871 argument.
7872 (Fframe_root_window, Fframe_first_window)
7873 (Fframe_selected_window): Move here from frame.c. Accept frame
7874 or arbitrary window as argument. Update doc-strings.
7875 (Fminibuffer_window): Move up in code.
7876 (Fwindow_minibuffer_p): Move up in code and simplify.
7877 (Fset_frame_selected_window): Move here from frame.c.
7878 Marginal rewrite.
7879 (Fselected_window, select_window, Fselect_window): Move up in
7880 code. Minor doc-string fixes.
7882 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7884 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7885 Do not assume that spare memory exists; that assumption is valid
7886 only if SYSTEM_MALLOC.
7887 (LARGE_REQUEST): New macro, so that the issue of large requests
7888 is separated from the issue of spare memory.
7890 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7892 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7893 format. (Bug#8806)
7895 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7897 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7898 before statements.
7900 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7902 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7904 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7906 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7907 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7909 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7911 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7913 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7915 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7916 (x_clipboard_manager_save): Add return value.
7917 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7918 New error handlers.
7919 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7920 Obey Vx_select_enable_clipboard_manager. Catch errors in
7921 x_clipboard_manager_save (Bug#8779).
7922 (Vx_select_enable_clipboard_manager): New variable.
7923 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7925 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7927 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7929 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7931 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7932 in the current matrix if keep_current_p is non-zero.
7934 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7936 * bidi.c (bidi_level_of_next_char): Fix last change.
7938 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7940 Support bidi reordering of text covered by display properties.
7942 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7943 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7944 (bidi_cache_search, bidi_cache_iterator_state)
7945 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7946 (bidi_level_of_next_char, bidi_move_to_visually_next):
7947 Support character positions inside a run of characters covered by a
7948 display string.
7949 (bidi_paragraph_init, bidi_resolve_explicit_1)
7950 (bidi_level_of_next_char): Call bidi_fetch_char and
7951 bidi_fetch_char_advance instead of FETCH_CHAR and
7952 FETCH_CHAR_ADVANCE.
7953 (bidi_init_it): Initialize new members.
7954 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7955 definitions.
7956 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7957 instead of using explicit *_CHAR codes.
7958 (bidi_resolve_explicit, bidi_resolve_weak):
7959 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7960 bidirectional text is supported only in multibyte buffers.
7961 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7962 it to initialize the frame_window_p member of struct bidi_it.
7963 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7964 (bidi_resolve_explicit, bidi_resolve_weak)
7965 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7966 bidi_it->nchars is non-positive.
7967 (bidi_level_of_next_char): Don't try to lookup the cache for the
7968 next/previous character if nothing is cached there yet, or if we
7969 were just reseat()'ed to a new position.
7971 * xdisp.c (set_cursor_from_row): Set start and stop points
7972 according to the row's direction when priming the loop that looks
7973 for the glyph on which to display cursor.
7974 (single_display_spec_intangible_p): Function deleted.
7975 (display_prop_intangible_p): Reimplement to call
7976 handle_display_spec instead of single_display_spec_intangible_p.
7977 Accept 3 additional arguments needed by handle_display_spec.
7978 This fixes incorrect cursor motion across display property with complex
7979 values: lists, `(when COND...)' forms, etc.
7980 (single_display_spec_string_p): Support property values that are
7981 lists with the argument STRING its top-level element.
7982 (display_prop_string_p): Fix the condition for processing a
7983 property that is a list to be consistent with handle_display_spec.
7984 (handle_display_spec): New function, refactored from the
7985 last portion of handle_display_prop.
7986 (compute_display_string_pos): Accept additional argument
7987 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7988 value of a `display' property is a "replacing spec".
7989 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7990 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7991 the display property, but just return a value indicating whether
7992 the display property will replace the characters it covers.
7993 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7994 frame_window_p members of struct bidi_it.
7995 (compute_display_string_pos, compute_display_string_end):
7996 New functions.
7997 (push_it): Accept second argument POSITION, where pop_it should
7998 jump to continue iteration.
7999 (reseat_1): Initialize bidi_it.disp_pos.
8001 * keyboard.c (adjust_point_for_property): Adjust the call to
8002 display_prop_intangible_p to its new signature.
8004 * dispextern.h (struct bidi_it): New member frame_window_p.
8005 (bidi_init_it): Update prototypes.
8006 (display_prop_intangible_p): Update prototype.
8007 (compute_display_string_pos, compute_display_string_end):
8008 Declare prototypes.
8009 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8010 EMACS_INT.
8012 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8014 Malloc failure behavior now depends on size of allocation.
8015 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8016 * lisp.h: Change signatures accordingly.
8017 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8018 All callers changed. (Bug#8762)
8020 * gnutls.c: Use Emacs's memory allocators.
8021 Without this change, the gnutls library would invoke malloc etc.
8022 directly, which causes problems on non-SYNC_INPUT hosts, and which
8023 runs afoul of improving memory_full behavior. (Bug#8761)
8024 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8025 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8026 xfree instead of the default malloc, realloc, free.
8027 (Fgnutls_boot): No need to check for memory allocation failure,
8028 since xmalloc does that for us.
8030 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8031 * category.c (hash_get_category_set):
8032 * ccl.c (ccl_driver):
8033 * charset.c (Fdefine_charset_internal):
8034 * charset.h (struct charset.hash_index):
8035 * composite.c (get_composition_id, gstring_lookup_cache)
8036 (composition_gstring_put_cache):
8037 * composite.h (struct composition.hash_index):
8038 * dispextern.h (struct image.hash):
8039 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8040 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8041 (hashfn_equal, hashfn_user_defined, make_hash_table)
8042 (maybe_resize_hash_table, hash_lookup, hash_put)
8043 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8044 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8045 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8046 * image.c (make_image, search_image_cache, lookup_image)
8047 (xpm_put_color_table_h):
8048 * lisp.h (struct Lisp_Hash_Table):
8049 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8050 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8051 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8052 * alloc.c (allocate_vectorlike):
8053 Check for overflow in vector size calculations.
8054 * ccl.c (ccl_driver):
8055 Check for overflow when converting EMACS_INT to int.
8056 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8057 need to be updated by these changes.
8058 * fns.c (make_hash_table, maybe_resize_hash_table):
8059 Check for integer overflow with large hash tables.
8060 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8061 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8062 (SXHASH_REDUCE): New macro.
8063 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8064 Use it instead of discarding useful hash info with large hash values.
8065 (sxhash_float): New function.
8066 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8067 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8068 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8069 Rewrite to use FIXNUM_BITS, as this simplifies things.
8070 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8071 Adjust signatures to match updated version of code.
8072 (consing_since_gc): Now EMACS_INT, since a single hash table can
8073 use more than INT_MAX bytes.
8075 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8077 Make it possible to build with GCC-4.6+ -O2 -flto.
8079 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8081 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8083 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8084 Call minibuffer-inactive-mode.
8086 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8088 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8089 Update dependencies.
8091 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8093 * data.c (init_data): Remove code for UTS, this system is not
8094 supported anymore.
8096 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8098 Don't force ./temacs to start in terminal mode.
8100 * frame.c (make_initial_frame): Initialize faces in all cases, not
8101 only when CANNOT_DUMP is defined.
8102 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8104 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8106 * dispnew.c (add_window_display_history): Use const for the string
8107 pointer. Remove declaration, not needed.
8109 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8111 Use 'inline', not 'INLINE'.
8112 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8113 * alloc.c, fontset.c (INLINE): Remove.
8114 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8115 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8116 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8117 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8118 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8120 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8122 Make it possible to run ./temacs.
8124 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8125 syms_of_callproc does the same thing. Remove test for
8126 "initialized", do it in the caller.
8127 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8129 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8131 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8132 (read_minibuf): Use get_minibuffer.
8133 (syms_of_minibuf): Use DEFSYM.
8134 (Qmetadata): New var.
8135 * data.c (Qbuffer): Don't make it static.
8136 (syms_of_data): Use DEFSYM.
8138 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8140 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8141 (CCL_CODE_MIN): New macro.
8143 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8145 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8147 * eval.c (Qdebug): Now static.
8148 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8149 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8150 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8152 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8154 * image.c: Various fixes to ImageMagick code comments.
8155 (Fimagemagick_types): Doc fix.
8157 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8159 Minor fixes prompted by GCC 4.6.0 warnings.
8161 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8163 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8164 (x_clipboard_manager_save_all): Move extern decl to ...
8165 * xterm.h: ... here, so that it can be checked for consistency.
8167 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8169 * xselect.c (x_clipboard_manager_save_frame)
8170 (x_clipboard_manager_save_all): New functions.
8171 (Fx_clipboard_manager_save): Lisp function deleted.
8173 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8174 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8176 * xterm.h: Update prototype.
8178 2011-05-28 William Xu <william.xwl@gmail.com>
8180 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8181 exiting (Bug#8239).
8183 2011-05-28 Jim Meyering <meyering@redhat.com>
8185 Avoid a sign-extension bug in crypto_hash_function.
8186 * fns.c (to_uchar): Define.
8187 (crypto_hash_function): Use it to convert some newly-signed
8188 variables to unsigned, to avoid sign-extension bugs. For example,
8189 without this change, (md5 "truc") would evaluate to
8190 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8191 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8192 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8194 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8196 Integer overflow fixes.
8198 * dbusbind.c: Serial number integer overflow fixes.
8199 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8200 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8201 to hold a serial number that is too large for a fixnum.
8202 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8203 Check for serial numbers out of range. Decode any serial number
8204 that was so large that it became a float. (Bug#8722)
8206 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8207 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8208 Use XFASTINT rather than XUINT when numbers are nonnegative.
8209 (xd_append_arg, Fdbus_method_return_internal):
8210 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8211 arguments, check that Lisp number is nonnegative, rather than
8212 silently wrapping negative numbers around. (Bug#8722)
8213 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8214 (Bug#8722)
8216 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8218 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8220 ccl: Add integer overflow checks.
8221 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8222 (IN_INT_RANGE): New macros.
8223 (ccl_driver): Use them to check for integer overflow when
8224 decoding a CCL program. Many of the new checks are whether XINT (x)
8225 fits in int; it doesn't always, on 64-bit hosts. The new version
8226 doesn't catch all possible integer overflows, but it's an
8227 improvement. (Bug#8719)
8229 * alloc.c (make_event_array): Use XINT, not XUINT.
8230 There's no need for unsigned here.
8232 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8233 This follows up to the 2011-05-06 change that substituted uintptr_t
8234 for EMACS_INT. This case wasn't caught back then.
8236 Rework Fformat to avoid integer overflow issues.
8237 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8238 now (part of C89). Include <verify.h>.
8239 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8240 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8241 (Fformat): Avoid the prepass trying to compute sizes; it was only
8242 approximate and thus did not catch overflow reliably. Instead, walk
8243 through the format just once, formatting and computing sizes as we go,
8244 checking for integer overflow at every step, and allocating a larger
8245 buffer as needed. Keep track separately whether the format is
8246 multibyte. Keep only the most-recently calculated precision, rather
8247 than them all. Record whether each argument has been converted to
8248 string. Use EMACS_INT, not int, for byte and char and arg counts.
8249 Support field widths and precisions larger than INT_MAX. Avoid
8250 sprintf's undefined behavior with conversion specifications such as %#d
8251 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8252 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8253 formatting out-of-range floating point numbers with int
8254 formats. (Bug#8668)
8256 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8258 * data.c: Avoid integer truncation in expressions involving floats.
8259 * data.c: Include <intprops.h>.
8260 (arith_driver): When there's an integer overflow in an expression
8261 involving floating point, convert the integers to floating point
8262 so that the resulting value does not suffer from catastrophic
8263 integer truncation. For example, on a 64-bit host (* 4
8264 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8265 Do not rely on undefined behavior after integer overflow.
8267 merge count_size_as_multibyte, parse_str_to_multibyte
8268 * character.c, character.h (count_size_as_multibyte):
8269 Rename from parse_str_to_multibyte; all uses changed.
8270 Check for integer overflow.
8271 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8272 since it's now a duplicate of the other. This is more of
8273 a character than a buffer op, so better that it's in character.c.
8274 * fns.c, print.c: Adjust to above changes.
8276 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8278 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8280 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8282 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8283 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8284 (x_clipboard_manager_save): Now static.
8285 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8287 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8288 (crypto_hash_function): Now static.
8289 Fix pointer signedness problems. Avoid unnecessary initializations.
8291 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8293 * termhooks.h (Vselection_alist): Make it terminal-local.
8295 * terminal.c (create_terminal): Initialize it.
8297 * xselect.c: Support for clipboard managers.
8298 (Vselection_alist): Move to termhooks.h as terminal-local var.
8299 (LOCAL_SELECTION): New macro.
8300 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8301 (symbol_to_x_atom): Remove gratuitous arg.
8302 (x_handle_selection_request, lisp_data_to_selection_data)
8303 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8304 (x_own_selection, x_get_local_selection, x_convert_selection):
8305 New arg, specifying work frame. Use terminal-local Vselection_alist.
8306 (some_frame_on_display): Delete unused function.
8307 (Fx_own_selection_internal, Fx_get_selection_internal)
8308 (Fx_disown_selection_internal, Fx_selection_owner_p)
8309 (Fx_selection_exists_p): New optional frame arg.
8310 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8311 (x_handle_selection_clear): Don't treat other terminals with the
8312 same keyboard specially. Use the terminal-local Vselection_alist.
8313 (x_clear_frame_selections): Use Frun_hook_with_args.
8315 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8317 * xterm.h: Add support for those atoms.
8319 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8321 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8322 (converted_selections, conversion_fail_tag): New global variables.
8323 (x_selection_request_lisp_error): Free the above.
8324 (x_get_local_selection): Remove unnecessary code.
8325 (x_reply_selection_request): Args changed; handle arbitrary array
8326 of converted selections stored in converted_selections.
8327 Separate the XChangeProperty and SelectionNotify steps.
8328 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8329 (x_convert_selection): New function.
8330 (x_handle_selection_event): Simplify.
8331 (x_get_foreign_selection): Don't ignore incoming requests while
8332 waiting for an answer; this will fail when we implement
8333 SAVE_TARGETS, and seems unnecessary anyway.
8334 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8335 (Vx_sent_selection_functions): Doc fix.
8337 2011-05-26 Leo Liu <sdl.web@gmail.com>
8339 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8341 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8343 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8345 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8346 for fringe update if it has periodic bitmap.
8347 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8348 and fringe_bitmap_periodic_p.
8350 * fringe.c (get_fringe_bitmap_data): New function.
8351 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8352 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8353 row. Mark glyph row for fringe update if periodicity changed.
8355 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8356 for fringe update unless it has periodic bitmap.
8358 2011-05-25 Kenichi Handa <handa@m17n.org>
8360 * xdisp.c (get_next_display_element): Set correct it->face_id for
8361 a static composition.
8363 2011-05-24 Leo Liu <sdl.web@gmail.com>
8365 * deps.mk (fns.o):
8366 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8368 * fns.c (crypto_hash_function, Fsha1): New function.
8369 (Fmd5): Use crypto_hash_function.
8370 (syms_of_fns): Add Ssha1.
8372 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8374 * gnutls.c: Remove unused macros.
8375 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8376 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8377 Remove macros that are defined and never used.
8378 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8380 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8382 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8383 (Fx_get_selection_internal): Minor cleanup.
8384 (Fx_own_selection_internal): Rename arguments for consistency with
8385 select.el.
8387 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8389 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8391 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8393 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8395 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8397 * dispnew.c (scrolling_window): Don't exclude the case that the
8398 last enabled row in the desired matrix touches the bottom boundary.
8400 2011-05-21 Glenn Morris <rgm@gnu.org>
8402 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8403 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8404 and add some more files.
8406 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8408 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8409 report_file_error introduced by the change from 2011-05-07.
8411 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8413 * systime.h (Time): Define only if emacs is defined.
8414 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8415 where the include path doesn't have X11/X.h by default. See
8416 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8418 2011-05-20 Kenichi Handa <handa@m17n.org>
8420 * composite.c (find_automatic_composition): Fix previous change.
8422 2011-05-20 Glenn Morris <rgm@gnu.org>
8424 * lisp.mk: New file, split from Makefile.in.
8425 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8426 (shortlisp): Remove.
8427 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8429 2011-05-19 Glenn Morris <rgm@gnu.org>
8431 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8432 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8433 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8434 (lisp): Set the order to that of loadup.el.
8435 (shortlisp): Make it a copy of $lisp.
8436 (SOME_MACHINE_LISP): Remove.
8437 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8438 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8440 2011-05-18 Kenichi Handa <handa@m17n.org>
8442 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8443 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8444 (find_automatic_composition): Mostly rewrite for efficiency.
8446 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8448 * makefile.w32-in: Update dependencies.
8450 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8452 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8453 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8455 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8457 Fix some integer overflow issues, such as string length overflow.
8459 * insdel.c (count_size_as_multibyte): Check for string overflow.
8461 * character.c (lisp_string_width): Check for string overflow.
8462 Use EMACS_INT, not int, for string indexes and lengths; in
8463 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8464 the resulting string length overflows an EMACS_INT; instead,
8465 report a string overflow if no precision given. When checking for
8466 precision exhaustion, use a check that cannot possibly have
8467 integer overflow. (Bug#8675)
8468 * character.h (lisp_string_width): Adjust to new signature.
8470 * alloc.c (string_overflow): New function.
8471 (Fmake_string): Use it. This doesn't change behavior, but saves
8472 a few bytes and will simplify future changes.
8473 * character.c (string_escape_byte8): Likewise.
8474 * lisp.h (string_overflow): New decl.
8476 Fixups, following up to the user-interface timestamp change.
8477 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8478 for UI timestamps, instead of unsigned long.
8479 * msdos.c (mouse_get_pos): Likewise.
8480 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8481 * w32gui.h (Time): Define by including "systime.h" rather than by
8482 declaring it ourselves. (Bug#8664)
8484 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8485 * image.c (clear_image_cache): Likewise.
8487 * term.c (term_mouse_position): Don't assume time_t wraparound.
8489 Be more systematic about user-interface timestamps.
8490 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8491 and sometimes 'EMACS_UINT', to represent these timestamps.
8492 This change causes it to use 'Time' uniformly, as that's what X uses.
8493 This makes the code easier to follow, and makes it easier to catch
8494 integer overflow bugs such as Bug#8664.
8495 * frame.c (Fmouse_position, Fmouse_pixel_position):
8496 Use Time, not unsigned long, for user-interface timestamps.
8497 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8498 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8499 * keyboard.h (last_event_timestamp): Likewise.
8500 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8501 * menu.h (xmenu_show): Likewise.
8502 * term.c (term_mouse_position): Likewise.
8503 * termhooks.h (struct input_event.timestamp): Likewise.
8504 (struct terminal.mouse_position_hook): Likewise.
8505 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8506 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8507 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8508 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8509 what it was before.
8510 * menu.h, termhooks.h: Include "systime.h", for Time.
8512 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8513 Don't assume that the difference between two unsigned long values
8514 can fit into an integer. At this point, we know button_down_time
8515 <= event->timestamp, so the difference must be nonnegative, so
8516 there's no need to cast the result if double-click-time is
8517 nonnegative, as it should be; check that it's nonnegative, just in
8518 case. This bug is triggered when events are more than 2**31 ms
8519 apart (about 25 days). (Bug#8664)
8521 * xselect.c (last_event_timestamp): Remove duplicate decl.
8522 (x_own_selection): Remove needless cast to unsigned long.
8524 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8525 that always fit in int. Use a sentinel instead of a counter, to
8526 avoid a temp and to allay GCC's concerns about possible int overflow.
8527 * frame.h (struct frame): Use int for menu_bar_items_used
8528 instead of EMACS_INT, since it always fits in int.
8530 * menu.c (grow_menu_items): Check for int overflow.
8532 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8534 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8535 Before, the code was not consistent. These values cannot exceed
8536 2**31 - 1 so there's no need to make them unsigned.
8537 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8538 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8539 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8540 as modifiers.
8541 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8543 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8544 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8545 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8546 presumably because the widths might not match.
8548 * window.c (size_window): Avoid needless test at loop start.
8550 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8552 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8554 2011-05-12 Drew Adams <drew.adams@oracle.com>
8556 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8558 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8560 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8561 `width' to `bar_area_x' and `bar_area_width', respectively.
8562 (x_scroll_run): Take account of fringe background extension.
8564 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8565 Rename local vars `left' and `width' to `bar_area_x' and
8566 `bar_area_width', respectively.
8567 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8568 background extension.
8570 2011-05-10 Jim Meyering <meyering@redhat.com>
8572 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8574 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8576 * image.c (Finit_image_library): Return t for built-in image types,
8577 like pbm and xbm. (Bug#8640)
8579 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8581 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8583 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8585 * w32console.c (Fset_screen_color): Doc fix.
8586 (Fget_screen_color): New function.
8587 (syms_of_ntterm): Defsubr it.
8589 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8590 unlink the temporary file if Fcall_process didn't create it in the
8591 first place.
8592 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8593 child process will be redirected to a file specified with `:file'.
8594 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8595 cue to call_process_cleanup not to close that handle.
8597 2011-05-07 Ben Key <bkey76@gmail.com>
8599 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8600 one of two shell specific rules, either bootstrap-temacs-CMD or
8601 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8602 to the previous implementation of the bootstrap-temacs rule.
8603 The bootstrap-temacs-CMD rule is similar to the previous
8604 implementation of the bootstrap-temacs rule except that it
8605 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8606 variable.
8608 These changes, along with some changes to nt/configure.bat,
8609 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8610 earlier fix to add support for --cflags and --ldflags options
8611 that include quotes so that it works whether make uses cmd or
8612 sh as the shell.
8614 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8616 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8617 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8618 is a constant.
8619 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8620 a string. Handle both cases.
8621 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8622 (Fdbus_register_method): Use Qinvalid_function.
8624 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8626 * makefile.w32-in: Update dependencies.
8627 (LISP_H): Add inttypes.h and stdin.h.
8628 (PROCESS_H): Add unistd.h.
8630 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8632 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8633 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8635 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8637 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8639 * term.c (vfatal): Remove stray call to va_end.
8640 It's not needed and the C Standard doesn't allow it here anyway.
8642 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8643 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8645 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8646 bytes.
8648 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8650 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8652 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8654 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8656 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8658 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8659 * charset.c (Fdefine_charset_internal): Don't initialize
8660 charset.code_space[15]. The value was garbage, on hosts with
8661 32-bit int (Bug#8600).
8663 * lread.c (read_integer): Be more consistent with string-to-number.
8664 Use string_to_number to do the actual conversion; this avoids
8665 rounding errors and fixes some other screwups. Without this fix,
8666 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8667 (digit_to_number): Move earlier, for benefit of read_integer.
8668 Return -1 if the digit is out of range for the base, -2 if it is
8669 not a digit in any supported base. (Bug#8602)
8671 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8673 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8674 to match comment at start of function. This also removes a
8675 GCC warning about overflow in a 32+64-bit port.
8677 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8679 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8680 Reported by Stefan Monnier in
8681 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8682 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8683 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8685 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8686 (EMACS_UINTPTR): Likewise, with uintptr_t.
8688 * lisp.h: Prefer 64-bit EMACS_INT if available.
8689 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8690 on 32-bit hosts that have 64-bit int, so that they can access
8691 large files.
8692 However, temporarily disable this change unless the temporary
8693 symbol WIDE_EMACS_INT is defined.
8695 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8697 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8698 This removes an assumption that EMACS_INT and long are the same
8699 width as pointers. The assumption is true for Emacs porting targets
8700 now, but we want to make other targets possible.
8701 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8702 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8703 In the rest of the code, change types of integers that hold casted
8704 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8705 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8706 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8707 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8708 No need to cast type when ORing.
8709 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8710 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8711 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8712 assume EMACS_INT is the same width as char *.
8713 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8714 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8715 Remove no-longer-needed casts.
8716 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8717 (xg_tool_bar_help_callback, xg_make_tool_item):
8718 Use EMACS_INTPTR to hold an integer
8719 that will be cast to void *; this can avoid a GCC warning
8720 if EMACS_INT is not the same width as void *.
8721 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8722 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8723 (current_message_1, set_message_1):
8724 Use a local to convert to proper width without a cast.
8725 * xmenu.c (dialog_selection_callback): Likewise.
8727 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8728 Also, don't assume VALBITS / RAND_BITS is less than 5,
8729 and don't rely on undefined behavior when shifting a 1 left into
8730 the sign bit.
8731 * lisp.h (get_random): Change signature to match.
8733 * lread.c (hash_string): Use size_t, not int, for hash computation.
8734 Normally we prefer signed values; but hashing is special, because
8735 it's better to use unsigned division on hash table sizes so that
8736 the remainder is nonnegative. Also, size_t is the natural width
8737 for hashing into memory. The previous code used 'int', which doesn't
8738 retain enough info to hash well into very large tables.
8739 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8741 * dbusbind.c: Don't possibly lose pointer info when converting.
8742 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8743 Use XPNTR rather than XHASH, so that the high-order bits of
8744 the pointer aren't lost when converting through void *.
8746 * eval.c (Fautoload): Don't double-shift a pointer.
8748 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8750 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8752 * gnutls.c (DEF_GNUTLS_FN):
8753 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8755 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8757 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8758 marker. (Bug#8610)
8760 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8762 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8763 New version that can reserve upto 2GB of heap space.
8765 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8767 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8769 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8771 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8772 `gnutls_certificate_set_x509_key_file'.
8774 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8776 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8777 Update dependencies.
8779 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8781 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8782 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8783 Remove unused parameter `fildes'.
8784 * process.c (read_process_output, send_process): Don't pass it.
8786 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8788 Fix previous change: the library cache is defined in w32.c.
8789 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8790 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8792 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8794 Implement dynamic loading of GnuTLS on Windows.
8796 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8797 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8798 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8799 Declare.
8801 * gnutls.c (Qgnutls_dll): Define.
8802 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8803 (gnutls_*): Declare function pointers.
8804 (init_gnutls_functions): New function to initialize function pointers.
8805 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8806 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8807 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8808 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8809 (emacs_gnutls_write, emacs_gnutls_read)
8810 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8811 (Fgnutls_available_p): New function.
8812 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8813 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8814 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8816 * image.c: Include w32.h.
8817 (Vimage_type_cache): Delete.
8818 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8819 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8820 (w32_delayed_load): Move to w32.c.
8822 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8824 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8825 (w32_delayed_load): Move from image.c. When loading a library, record
8826 its filename in the :loaded-from property of the library id.
8827 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8828 Initialize and staticpro them.
8829 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8831 * process.c: Include lisp.h before w32.h, not after.
8832 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8833 instead of gnutls_record_check_pending.
8835 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8837 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8839 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8840 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8841 as passed in.
8843 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8845 * xterm.c (x_set_frame_alpha): Do not set property on anything
8846 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8848 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8850 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8852 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8854 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8855 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8856 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8857 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8858 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8859 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8860 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8861 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8862 (Qgnutls_bootprop_callbacks_verify): Make static.
8864 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8866 * callproc.c: Indentation fixup.
8868 * sysdep.c (wait_for_termination_1): Make static.
8869 (wait_for_termination, interruptible_wait_for_termination):
8870 Move after wait_for_termination_1.
8872 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8874 * sysdep.c (interruptible_wait_for_termination): New function
8875 which is like wait_for_termination, but allows keyboard
8876 interruptions.
8878 * callproc.c (Fcall_process): Add (:file "file") as an option for
8879 the STDOUT buffer.
8880 (Fcall_process_region): Ditto.
8882 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8884 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8885 rather than `XVECTOR (FOO)->size'.
8887 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8888 inttypes.h, as a gnulib replacement is used if it not available in
8889 system headers.
8891 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8893 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8894 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8895 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8897 * coding.c (coding_alloc_by_realloc): Error out if destination
8898 will grow beyond MOST_POSITIVE_FIXNUM.
8899 (decode_coding_emacs_mule): Abort if there isn't enough place in
8900 charbuf for the composition carryover bytes. Reserve an extra
8901 space for up to 2 characters produced in a loop.
8902 (decode_coding_iso_2022): Abort if there isn't enough place in
8903 charbuf for the composition carryover bytes.
8905 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8907 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8908 aborting when %lld or %lll format is passed.
8909 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8910 %llo or %llx format is passed. (Bug#8545)
8912 * window.c (window_scroll_line_based): Use a marker instead of
8913 simple variables to record original value of point. (Bug#7952)
8915 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8916 produced by %s or %c overflows available buffer space. (Bug#8545)
8918 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8920 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8921 (SIZE_MAX): Move defn after all includes, as they might #define it.
8923 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8925 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8927 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8929 * keyboard.c (Qdelayed_warnings_hook): Define.
8930 (command_loop_1): Run `delayed-warnings-hook'
8931 if Vdelayed_warnings_list is non-nil.
8932 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8933 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8935 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8937 * doprnt.c (doprnt): Don't return value smaller than the buffer
8938 size if the message was truncated. (Bug#8545).
8940 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8942 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8943 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8945 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8947 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8949 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8951 * makefile.w32-in: Update dependencies.
8953 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8955 Improve `doprnt' and its usage. (Bug#8545)
8956 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8957 `format_end'. Remove support for %l as a conversion specifier.
8958 Don't use xrealloc. Improve diagnostics when the %l size modifier
8959 is used. Update the commentary.
8961 * eval.c (verror): Simplify calculation of size_t.
8963 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8964 messages.
8966 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8968 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8969 change.
8971 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8973 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8974 This makes this file independent of the recent pseudovector change.
8976 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8978 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8980 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8981 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8982 Remove unused local.
8983 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8985 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8986 GCC 4.6.0 optimizes based on type-based alias analysis.
8987 For example, if b is of type struct buffer * and v of type struct
8988 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8989 != &v->size, and therefore "v->size = 1; b->size = 2; return
8990 v->size;" must therefore return 1. This assumption is incorrect
8991 for Emacs, since it type-puns struct Lisp_Vector * with many other
8992 types. To fix this problem, this patch adds a new type struct
8993 vectorlike_header that documents the constraints on layout of vectors
8994 and pseudovectors, and helps optimizing compilers not get fooled
8995 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8996 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8997 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8998 the size member.
8999 (XSETPVECTYPE): Rewrite in terms of new macro.
9000 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9001 This is a bit clearer, and further avoids the possibility of
9002 undesirable aliasing.
9003 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9004 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9005 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9006 since Lisp_Subr is a special case (no "next" field).
9007 (ASIZE): Now uses header.size rather than size.
9008 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9009 to avoid the hassle of writing XVECTOR (foo)->header.size.
9010 (struct vectorlike_header): New type.
9011 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9012 object, to help avoid aliasing.
9013 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9014 (SUBRP): Likewise, since Lisp_Subr is a special case.
9015 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9016 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9017 (struct Lisp_Hash_Table): Combine first two members into a single
9018 struct vectorlike_header member. All uses of "size" and "next" members
9019 changed to be "header.size" and "header.next".
9020 * buffer.h (struct buffer): Likewise.
9021 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9022 * frame.h (struct frame): Likewise.
9023 * process.h (struct Lisp_Process): Likewise.
9024 * termhooks.h (struct terminal): Likewise.
9025 * window.c (struct save_window_data, struct saved_window): Likewise.
9026 * window.h (struct window): Likewise.
9027 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9028 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9029 * buffer.c (init_buffer_once): Likewise.
9030 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9031 special case.
9032 * process.c (Fformat_network_address): Use local var for size,
9033 for brevity.
9035 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9037 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9038 * data.c (atof): Remove decl; no longer used or needed.
9039 (digit_to_number): Move to lread.c.
9040 (Fstring_to_number): Use new string_to_number function, to be
9041 consistent with how the Lisp reader treats infinities and NaNs.
9042 Do not assume that floating-point numbers represent EMACS_INT
9043 without losing information; this is not true on most 64-bit hosts.
9044 Avoid double-rounding errors, by insisting on integers when
9045 parsing non-base-10 numbers, as the documentation specifies.
9046 * lisp.h (string_to_number): New decl, replacing ...
9047 (isfloat_string): Remove.
9048 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9049 (read1): Do not accept +. and -. as integers; this
9050 appears to have been a coding error. Similarly, do not accept
9051 strings like +-1e0 as floating point numbers. Do not report
9052 overflow for integer overflows unless the base is not 10 which
9053 means we have no simple and reliable way to continue.
9054 Break out the floating-point parsing into a new
9055 function string_to_number, so that Fstring_to_number parses
9056 floating point numbers consistently with the Lisp reader.
9057 (digit_to_number): Move here from data.c. Make it static inline.
9058 (E_CHAR, EXP_INT): Remove, replacing with ...
9059 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9060 (string_to_number): New function, replacing isfloat_string.
9061 This function checks for valid syntax and produces the resulting
9062 Lisp float number too. Rework it so that string-to-number
9063 no longer mishandles examples like "1.0e+". Use strtoumax,
9064 so that overflow for non-base-10 numbers is reported only when
9065 there's no portable and simple way to convert to floating point.
9067 * textprop.c (set_text_properties_1): Rewrite for clarity,
9068 and to avoid GCC warning about integer overflow.
9070 * intervals.h (struct interval): Use EMACS_INT for members
9071 where EMACS_UINT might cause problems. See
9072 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9073 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9074 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9075 All uses changed.
9076 (offset_intervals): Tell GCC not to worry about length overflow
9077 when negating a negative length.
9079 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9080 (overrun_check_free): Likewise.
9082 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9083 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9084 word size.
9086 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9087 (gnutls_make_error): Rename local to avoid shadowing.
9088 (gnutls_emacs_global_deinit): ifdef out; not used.
9089 (Fgnutls_boot): Use const for pointer to readonly storage.
9090 Comment out unused local. Fix pointer signedness problems.
9092 * lread.c (openp): Don't stuff size_t into an 'int'.
9093 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9094 about possible signed overflow.
9096 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9097 (GDK_KEY_g): Don't define if already defined.
9098 (xg_prepare_tooltip): Avoid pointer signedness problem.
9099 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9101 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9102 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9104 * xfns.c (Fx_window_property): Simplify a bit,
9105 to make a bit faster and to avoid GCC 4.6.0 warning.
9106 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9108 * fns.c (internal_equal): Don't assume size_t fits in int.
9110 * alloc.c (compact_small_strings): Tighten assertion a little.
9112 Replace pEd with more-general pI, and fix some printf arg casts.
9113 * lisp.h (pI): New macro, generalizing old pEd macro to other
9114 conversion specifiers. For example, use "...%"pI"d..." rather
9115 than "...%"pEd"...".
9116 (pEd): Remove. All uses replaced with similar uses of pI.
9117 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9118 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9119 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9120 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9121 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9122 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9123 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9124 64-bit hosts.
9125 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9126 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9127 * print.c (safe_debug_print, print_object): Likewise.
9128 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9129 to int.
9130 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9131 avoiding the 0 flag, which is not portable.
9132 * process.c (Fmake_network_process): Use pI to avoid cast.
9133 * region-cache.c (pp_cache): Likewise.
9134 * xdisp.c (decode_mode_spec): Likewise.
9135 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9136 behavior on 64-bit hosts with printf arg.
9137 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9138 (x_stop_queuing_selection_requests): Likewise.
9139 (x_get_window_property): Don't truncate byte count to an 'int'
9140 when tracing.
9142 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9143 here, since it parses constructs like leading '-' and spaces,
9144 which are not wanted; and it overflows with large numbers.
9145 Instead, simply match F[0-9]+, which is what is wanted anyway.
9147 * alloc.c: Remove unportable assumptions about struct layout.
9148 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9149 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9150 (allocate_vectorlike, make_pure_vector): Use the new macros,
9151 plus offsetof, to remove unportable assumptions about struct layout.
9152 These assumptions hold on all porting targets that I know of, but
9153 they are not guaranteed, they're easy to remove, and removing them
9154 makes further changes easier.
9156 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9157 This doesn't fix a bug but makes the code clearer.
9158 (string_overrun_cookie): Now const. Use initializers that
9159 don't formally overflow signed char, to avoid warnings.
9160 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9161 can cause Emacs to crash when string overrun checking is enabled.
9162 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9163 multiple of sizeof (EMACS_INT); it need not be, if
9164 alignof(EMACS_INT) < sizeof (EMACS_INT).
9165 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9167 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9169 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9171 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9173 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9174 supposed to be handshaking. (Bug#8556)
9175 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9177 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9179 * lisp.h (Qdebug): List symbol.
9180 * eval.c (Qdebug): Restore global linkage.
9181 * keyboard.c (debug-on-event): New variable.
9182 (handle_user_signal): Break into debugger when debug-on-event
9183 matches the current signal symbol.
9185 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9187 * alloc.c (check_sblock, check_string_bytes)
9188 (check_string_free_list): Convert to standard C.
9190 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9192 * w32.c (emacs_gnutls_push): Fix typo.
9194 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9196 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9197 "cast to pointer from integer of different size".
9199 Improve doprnt and its use in verror. (Bug#8545)
9200 * doprnt.c (doprnt): Document the set of format control sequences
9201 supported by the function. Use SAFE_ALLOCA instead of always
9202 using `alloca'.
9204 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9205 is one byte too soon. Don't use xrealloc; instead xfree and
9206 xmalloc anew.
9208 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9210 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9211 callbacks stage.
9213 * gnutls.c: Renamed global_initialized to
9214 gnutls_global_initialized. Added internals for the
9215 :verify-hostname-error, :verify-error, and :verify-flags
9216 parameters of `gnutls-boot' and documented those parameters in the
9217 docstring. Start callback support.
9218 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9219 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9220 on error. Return error code.
9221 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9222 (emacs_gnutls_read): Likewise.
9223 (Fgnutls_boot): Return handshake error code.
9224 (emacs_gnutls_handle_error): New function.
9225 (wsaerror_to_errno): Likewise.
9227 * w32.h (emacs_gnutls_pull): Add prototype.
9228 (emacs_gnutls_push): Likewise.
9230 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9231 (emacs_gnutls_push): Likewise.
9233 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9235 * process.c (wait_reading_process_output): Check if GnuTLS
9236 buffered some data internally if no FDs are set for TLS
9237 connections.
9239 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9240 (LIBS): Link to USER_LIBS.
9241 ($(BLD)/gnutls.$(0)): New target.
9243 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9245 * xdisp.c (handle_single_display_spec): Rename the
9246 display_replaced_before_p argument into display_replaced_p, to
9247 make it consistent with the commentary. Fix typos in the
9248 commentary.
9250 * textprop.c (syms_of_textprop): Remove dead code.
9251 (copy_text_properties): Delete obsolete commentary about an
9252 interface that was deleted long ago. Fix typos in the description
9253 of arguments.
9255 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9256 to changes in oldXMenu/XMenu.h from 2011-04-16.
9257 <menu_help_message, prev_menu_help_message>: Constify.
9258 (IT_menu_make_room): menu->help_text is now `const char **';
9259 adjust.
9261 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9262 to changes in oldXMenu/XMenu.h from 2011-04-16.
9263 (struct XMenu): Declare `help_text' `const char **'.
9265 * xfaces.c <Qunspecified>: Make extern again.
9267 * syntax.c: Include sys/types.h before including regex.h, as
9268 required by POSIX.
9270 * doc.c (get_doc_string): Improve the format passed to `error'.
9272 * doprnt.c (doprnt): Improve commentary.
9274 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9276 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9277 them with etags.
9279 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9280 changes in globals.h immediately force recompilation.
9281 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9282 $(CURDIR)/s/ms-w32.h.
9283 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9285 * character.c (Fchar_direction): Function deleted.
9286 (syms_of_character): Don't defsubr it.
9287 <char-direction-table>: Deleted.
9289 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9291 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9292 * doprnt.c: Include limits.h.
9293 (SIZE_MAX): New macro.
9294 (doprnt): Return a size_t value. 2nd arg is now size_t.
9295 Many local variables are now size_t instead of int or unsigned.
9296 Improve overflow protection. Support `l' modifier for integer
9297 conversions. Support %l conversion. Don't assume an EMACS_INT
9298 argument for integer conversions and for %c.
9300 * lisp.h (doprnt): Restore prototype.
9302 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9303 $(SRC)/character.h.
9305 * Makefile.in (base_obj): Add back doprnt.o.
9307 * deps.mk (doprnt.o): Add back prerequisites.
9308 (callint.o): Depend on character.h.
9310 * eval.c (internal_lisp_condition_case): Include the handler
9311 representation in the error message.
9312 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9313 when breaking from the loop.
9315 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9317 * callint.c (Fcall_interactively): When displaying error message
9318 about invalid control letter, pass the character's codepoint, not
9319 a pointer to its multibyte form. Improve display of the character
9320 in octal and display also its hex code.
9322 * character.c (char_string): Use %x to display the (unsigned)
9323 codepoint of an invalid character, to avoid displaying a bogus
9324 negative value.
9326 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9327 `error', not SYMBOL_NAME itself.
9329 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9330 character arguments to `error'.
9332 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9333 to `error' in error message about FINAL_CHAR argument. Make sure
9334 FINAL_CHAR is a character, and use %c when it is passed as
9335 argument to `error'.
9337 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9339 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9341 * w32.c: Include <time.h>.
9342 (sys_localtime): New function.
9344 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9346 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9348 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9350 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9352 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9353 zombies (Bug#8467).
9355 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9357 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9358 gl_state.e_property when gl_state.object is Qt.
9360 * insdel.c (make_gap_larger): Remove limitation of buffer size
9361 to <= INT_MAX.
9363 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9365 * xdisp.c (lookup_glyphless_char_display)
9366 (produce_glyphless_glyph): Handle cons cell entry in
9367 glyphless-char-display.
9368 (Vglyphless_char_display): Document it.
9370 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9371 glyphless-char-display.
9373 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9375 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9377 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9379 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9380 definition for no-X builds.
9382 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9384 Static checks with GCC 4.6.0 and non-default toolkits.
9386 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9388 * process.c (keyboard_bit_set): Define only if SIGIO.
9389 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9390 (send_process): Repair possible setjmp clobbering.
9392 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9394 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9396 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9398 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9399 Define only if needed.
9401 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9402 by pacifying GCC about it. Maybe it's time to retire it?
9403 * xfaces.c (USG, __TIMEVAL__): Likewise.
9405 * dispextern.h (struct redisplay_interface): Rename param
9406 to avoid shadowing.
9407 * termhooks.h (struct terminal): Likewise.
9408 * xterm.c (xembed_send_message): Likewise.
9410 * insdel.c (make_gap_smaller): Define only if
9411 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9413 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9414 it.
9416 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9417 so that we aren't warned about unused symbols.
9419 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9421 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9423 * xfns.c (x_real_positions): Mark locals as initialized.
9425 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9427 * xterm.c: Fix problems found by static analysis with other toolkits.
9428 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9429 (x_dispatch_event): Declare static if USE_GTK, and
9430 define if USE_GTK || USE_X_TOOLKIT.
9431 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9432 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9433 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9434 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9436 * xmenu.c (menu_help_callback): Pointer type fixes.
9437 Use const pointers when pointing at readonly data. Avoid pointer
9438 signedness clashes.
9439 (FALSE): Remove unused macro.
9440 (update_frame_menubar): Remove unused decl.
9442 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9444 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9445 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9446 (single_menu_item): Rename local to avoid shadowing.
9448 * keyboard.c (make_lispy_event): Remove unused local var.
9450 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9451 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9453 * bitmaps: Change bitmaps from unsigned char back to the X11
9454 compatible char. Avoid the old compiler warnings about
9455 out-of-range initializers by using, for example, '\xab' rather
9456 than 0xab.
9458 * xgselect.c (xgselect_initialize): Check vs interface
9459 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9461 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9463 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9464 to read-only memory.
9466 * fns.c (vector): Remove; this old hack is no longer needed.
9468 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9469 Remove unused var.
9470 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9472 * xrdb.c (x_load_resources): Omit unused local.
9474 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9475 (x_window): Rename locals to avoid shadowing.
9476 (USG): Use the kludged USG macro, to pacify gcc.
9478 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9479 (x_term_init): Remove local to avoid shadowing.
9481 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9483 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9484 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9486 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9488 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9490 Fix regex.c, syntax.c and friends for buffers > 2GB.
9491 * syntax.h (struct gl_state_s): Declare character position members
9492 EMACS_INT.
9494 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9496 * textprop.c (verify_interval_modification, interval_of):
9497 Declare arguments EMACS_INT.
9499 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9500 EMACS_INT.
9502 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9504 * indent.c (Fvertical_motion): Local variable it_start is now
9505 EMACS_INT.
9507 * regex.c (re_match, re_match_2, re_match_2_internal)
9508 (bcmp_translate, regcomp, regexec, print_double_string)
9509 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9510 (re_compile_pattern, re_exec): Declare arguments and local
9511 variables `size_t' and `ssize_t' and return values `regoff_t', as
9512 appropriate.
9513 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9514 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9515 <compile_stack_type>: `size' and `avail' are now `size_t'.
9517 * regex.h <regoff_t>: Use ssize_t, not int.
9518 (re_search, re_search_2, re_match, re_match_2): Arguments that
9519 specify buffer/string position and length are now ssize_t and
9520 size_t. Return type is regoff_t.
9522 2011-04-16 Ben Key <bkey76@gmail.com>
9524 * nsfont.m: Fixed bugs in ns_get_family and
9525 ns_descriptor_to_entity that were caused by using free to
9526 deallocate memory blocks that were allocated by xmalloc (via
9527 xstrdup). This caused Emacs to crash when compiled with
9528 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9529 --enable-checking=xmallocoverrun). xfree is now used to
9530 deallocate these memory blocks.
9532 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9534 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9536 emacs_write: Accept and return EMACS_INT for sizes.
9537 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9538 et seq.
9539 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9540 Accept and return EMACS_INT.
9541 (emacs_gnutls_write): Return the number of bytes written on
9542 partial writes.
9543 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9544 (emacs_read, emacs_write): Remove check for negative size, as the
9545 Emacs source code has been audited now.
9546 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9547 (emacs_read, emacs_write): Use it.
9548 * process.c (send_process): Adjust to the new signatures of
9549 emacs_write and emacs_gnutls_write. Do not attempt to store
9550 a byte offset into an 'int'; it might overflow.
9551 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9553 * sound.c: Don't assume sizes fit in 'int'.
9554 (struct sound_device.period_size, alsa_period_size):
9555 Return EMACS_INT, not int.
9556 (struct sound_device.write, vox_write, alsa_write):
9557 Accept EMACS_INT, not int.
9558 (wav_play, au_play): Use EMACS_INT to store sizes and to
9559 record read return values.
9561 2011-04-15 Ben Key <bkey76@gmail.com>
9563 * keyboard.c (Qundefined): Don't declare static since it is used
9564 in nsfns.m.
9565 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9566 static since they are used in nsfont.m.
9568 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9570 * process.c (Qprocessp): Don't declare static.
9571 * lisp.h (Qprocessp): Declare again.
9573 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9575 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9577 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9579 Improve C-level modularity by making more things 'static'.
9581 Don't publish debugger-only interfaces to other modules.
9582 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9583 (verify_bytepos, count_markers): Move decls to the only modules
9584 that need them.
9585 * region-cache.h (pp_cache): Likewise.
9586 * window.h (check_all_windows): Likewise.
9587 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9589 * sysdep.c (croak): Now static, if
9590 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9591 * syssignal.h (croak): Declare only if not static.
9593 * alloc.c (refill_memory_reserve): Now static if
9594 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9595 * lisp.h (refill_memory_reserve): Declare only if not static.
9597 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9598 Define only if USE_LUCID.
9600 * xrdb.c (x_customization_string, x_rm_string): Now static.
9602 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9603 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9605 * xdisp.c (draw_row_with_mouse_face): Now static.
9606 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9608 * window.h (check_all_windows): Mark externally visible.
9610 * window.c (window_deletion_count): Now static.
9612 * undo.c: Make symbols static if they're not exported.
9613 (last_undo_buffer, last_boundary_position, pending_boundary):
9614 Now static.
9616 * textprop.c (interval_insert_behind_hooks): Now static.
9617 (interval_insert_in_front_hooks): Likewise.
9619 * term.c: Make symbols static if they're not exported.
9620 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9621 (max_frame_lines, tty_set_terminal_modes):
9622 (tty_reset_terminal_modes, tty_turn_off_highlight):
9623 (get_tty_terminal): Now static.
9624 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9625 * termhooks.h (term_mouse_moveto): Do not declare if
9626 HAVE_WINDOW_SYSTEM.
9627 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9628 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9630 * sysdep.c: Make symbols static if they're not exported.
9631 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9632 Now static.
9633 (sigprocmask_set, full_mask): Remove; unused.
9634 (wait_debugging): Mark as visible.
9635 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9636 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9638 * syntax.c (syntax_temp): Define only if !__GNUC__.
9640 * sound.c (current_sound_device, current_sound): Now static.
9642 * search.c (searchbufs, searchbuf_head): Now static.
9644 * scroll.c (scroll_cost): Remove; unused.
9645 * dispextern.h (scroll_cost): Remove decl.
9647 * region-cache.h (pp_cache): Mark as externally visible.
9649 * process.c: Make symbols static if they're not exported.
9650 (process_tick, update_tick, create_process, chan_process):
9651 (Vprocess_alist, proc_buffered_char, datagram_access):
9652 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9653 (deactivate_process): Mark defn as static, as well as decl.
9654 * lisp.h (create_process): Remove decl.
9655 * process.h (chan_process, Vprocess_alist): Remove decls.
9657 * print.c: Make symbols static if they're not exported.
9658 (print_depth, new_backquote_output, being_printed, print_buffer):
9659 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9660 (print_interval, print_number_index, initial_stderr_stream):
9661 Now static.
9662 * lisp.h (Fprinc): Remove decl.
9663 (debug_output_compilation_hack): Mark as externally visible.
9665 * sysdep.c (croak): Move decl from here to syssignal.h.
9666 * syssignal.h (croak): Put it here, so the API can be checked when
9667 'croak' is called from dissociate_if_controlling_tty.
9669 * minibuf.c: Make symbols static if they're not exported.
9670 (minibuf_save_list, choose_minibuf_frame): Now static.
9671 * lisp.h (choose_minibuf_frame): Remove decl.
9673 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9675 * lread.c: Make symbols static if they're not exported.
9676 (read_objects, initial_obarray, oblookup_last_bucket_number):
9677 Now static.
9678 (make_symbol): Remove; unused.
9679 * lisp.h (initial_obarray, make_symbol): Remove decls.
9681 * keyboard.c: Make symbols static if they're not exported.
9682 (single_kboard, recent_keys_index, total_keys, recent_keys):
9683 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9684 (this_single_command_key_start, echoing, last_auto_save):
9685 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9686 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9687 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9688 (Vlispy_mouse_stem, double_click_count):
9689 Now static.
9690 (force_auto_save_soon): Define only if SIGDANGER.
9691 (ignore_mouse_drag_p): Now static if
9692 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9693 (print_help): Remove; unused.
9694 (stop_character, last_timer_event): Mark as externally visible.
9695 * keyboard.h (ignore_mouse_drag_p): Declare only if
9696 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9697 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9698 * lisp.h (echoing): Remove decl.
9699 (force_auto_save_soon): Declare only if SIGDANGER.
9700 * xdisp.c (redisplay_window): Simplify code, to make it more
9701 obvious that ignore_mouse_drag_p is not accessed if !defined
9702 USE_GTK && !defined HAVE_NS.
9704 * intervals.c: Make symbols static if they're not exported.
9705 (merge_properties_sticky, merge_interval_right, delete_interval):
9706 Now static.
9707 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9709 * insdel.c: Make symbols static if they're not exported.
9710 However, leave prepare_to_modify_buffer alone. It's never
9711 called from outside this function, but that appears to be a bug.
9712 (combine_after_change_list, combine_after_change_buffer):
9713 (adjust_after_replace, signal_before_change): Now static.
9714 (adjust_after_replace_noundo): Remove; unused.
9715 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9716 (signal_before_change): Remove decls.
9718 * indent.c (val_compute_motion, val_vmotion): Now static.
9720 * image.c: Make symbols static if they're not exported.
9721 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9722 if USE_GTK.
9723 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9724 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9726 * fringe.c (standard_bitmaps): Now static.
9727 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9729 * frame.c: Make symbols static if they're not exported.
9730 (x_report_frame_params, make_terminal_frame): Now static.
9731 (get_frame_param): Now static, unless HAVE_NS.
9732 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9733 (x_get_resource_string): Remove; not used.
9734 * frame.h (make_terminal_frame, x_report_frame_params):
9735 (x_get_resource_string); Remove decls.
9736 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9737 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9739 * font.c, fontset.c: Make symbols static if they're not exported.
9740 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9741 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9742 * font.c (font_close_object): Now static.
9743 * font.h (font_close_object): Remove.
9744 * fontset.c (FONTSET_OBJLIST): Remove.
9745 (free_realized_fontset) #if-0 the body, which does nothing.
9746 (face_suitable_for_char_p): #if-0, as it's never called.
9747 * fontset.h (face_suitable_for_char_p): Remove decl.
9748 * xfaces.c (face_at_string_position):
9749 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9750 since 0 is always ASCII.
9752 * fns.c (weak_hash_tables): Now static.
9754 * fileio.c: Make symbols static if they're not exported.
9755 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9756 (Vwrite_region_annotation_buffers): Now static.
9758 * eval.c: Make symbols static if they're not exported.
9759 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9760 * lisp.h (backtrace_list): Remove decl.
9762 * emacs.c: Make symbols static if they're not exported.
9763 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9764 (fatal_error_code, fatal_error_signal_hook, standard_args):
9765 Now static.
9766 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9767 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9768 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9769 * lisp.h (fatal_error_signal_hook): Remove decl.
9770 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9772 * editfns.c: Move a (normally-unused) function to its only use.
9773 * editfns.c, lisp.h (get_operating_system_release): Remove.
9774 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9775 worth the hassle of breaking this out.
9777 * xterm.c: Make symbols static if they're not exported.
9778 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9779 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9780 (x_destroy_window, x_delete_display):
9781 Now static.
9782 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9783 (x_mouse_leave): Remove; unused.
9784 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9785 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9786 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9787 Remove decls.
9788 (x_mouse_leave): Declare only if WINDOWSNT.
9789 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9790 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9791 USE_X_TOOLKIT.
9793 * ftxfont.c: Make symbols static if they're not exported.
9794 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9795 HAVE_FREETYPE.
9796 * font.h (ftxfont_driver): Likewise.
9798 * xfns.c: Make symbols static if they're not exported.
9799 (x_last_font_name, x_display_info_for_name):
9800 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9801 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9802 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9803 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9804 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9805 (last_show_tip_args): Now static.
9806 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9807 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9808 (x_screen_planes): Remove; unused.
9809 * dispextern.h (x_screen_planes): Remove decl.
9811 * dispnew.c: Make symbols static if they're not exported.
9812 * dispextern.h (redraw_garbaged_frames, scrolling):
9813 (increment_row_positions): Remove.
9814 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9815 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9816 Now static.
9817 (redraw_garbaged_frames): Remove; unused.
9819 * xfaces.c: Make symbols static if they're not exported.
9820 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9821 Remove decls.
9822 * xterm.h (defined_color): Remove decls.
9823 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9824 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9825 (menu_face_changed_default, defined_color, free_realized_face):
9826 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9827 (ascii_face_of_lisp_face): Remove; unused.
9829 * xdisp.c: Make symbols static if they're not exported.
9830 * dispextern.h (scratch_glyph_row, window_box_edges):
9831 (glyph_to_pixel_coords, set_cursor_from_row):
9832 (get_next_display_element, set_iterator_to_next):
9833 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9834 (show_mouse_face): Remove decls
9835 * frame.h (message_buf_print): Likewise.
9836 * lisp.h (pop_message, set_message, check_point_in_composition):
9837 Likewise.
9838 * xterm.h (set_vertical_scroll_bar): Likewise.
9839 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9840 (message_buf_print, scratch_glyph_row, displayed_buffer):
9841 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9842 (get_next_display_element, show_mouse_face, window_box_edges):
9843 (frame_to_window_pixel_xy, check_point_in_composition):
9844 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9845 (glyph_to_pixel_coords): Remove; unused.
9847 * dired.c (file_name_completion): Now static.
9849 * dbusbind.c (xd_in_read_queued_messages): Now static.
9851 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9852 * data.c (circular_list_error): Remove.
9854 * commands.h (last_point_position, last_point_position_buffer):
9855 (last_point_position_window): Remove decls.
9856 * keyboard.c: Make these variables static.
9858 * coding.h (coding, code_convert_region, encode_coding_gap):
9859 Remove decls.
9860 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9861 (iso_code_class, detect_coding, code_convert_region): Now static.
9862 (encode_coding_gap): Remove; unused.
9864 * chartab.c (chartab_chars, chartab_bits): Now static.
9866 * charset.h (charset_iso_8859_1): Remove decl.
9867 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9868 Now static.
9870 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9871 * ccl.c (Vccl_program_table): Now static.
9872 (check_ccl_update): Remove; unused.
9874 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9875 * category.h: ... from here.
9876 * category.c (check_category_table, set_category_set): Now static.
9878 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9879 * lisp.h: Remove these decls.
9881 * buffer.c (buffer_count): Remove unused var.
9883 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9884 so that it's not optimized away.
9885 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9886 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9887 exported only to the debugger.
9889 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9890 * atimer.h (run_all_atimers): Remove; not exported.
9892 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9893 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9894 was inaccessible from Lisp.
9895 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9896 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9898 alloc.c: Import and export fewer symbols, and remove unused items.
9899 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9900 is defined.
9901 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9902 it's not optimized away by whole-program optimization.
9903 (message_enable_multibyte, free_misc): Remove.
9904 (catchlist, handlerlist, mark_backtrace):
9905 Declare only if BYTE_MARK_STACK.
9906 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9907 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9908 (message_enable_multibyte): Remove decl.
9909 (free_misc, interval_free_list, float_block, float_block_index):
9910 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9911 (cons_free_list, last_marked_index):
9912 Now static.
9913 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9914 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9915 (mark_backtrace): Define only if BYTE_MARK_STACK.
9916 * xdisp.c (message_enable_multibyte): Now static.
9918 Declare Lisp_Object Q* variables to be 'static' if not exported.
9919 This makes it easier for human readers (and static analyzers)
9920 to see whether these variables are used from other modules.
9921 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9922 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9923 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9924 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9925 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9926 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9927 * xmenu.c, xselect.c:
9928 Declare Q* vars static if they are not used in other modules.
9929 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9930 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9931 Remove decls of unexported vars.
9932 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9934 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9936 Make Emacs functions such as Fatom 'static' by default.
9937 This makes it easier for human readers (and static analyzers)
9938 to see whether these functions can be called from other modules.
9939 DEFUN now defines a static function. To make the function external
9940 so that it can be used in other C modules, use the new macro DEFUE.
9941 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9942 (Finit_image_library):
9943 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9944 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9945 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9946 Remove decls, since these functions are now static.
9947 (Funintern, Fget_internal_run_time): New decls, since these functions
9948 were already external.
9950 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9951 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9952 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9953 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9954 * keyboard.c, keymap.c, lread.c:
9955 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9956 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9957 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9958 Mark functions with DEFUE instead of DEFUN,
9959 if they are used in other modules.
9960 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9961 decls for now-static functions.
9962 * buffer.h (Fdelete_overlay): Remove decl.
9963 * callproc.c (Fgetenv_internal): Mark as internal.
9964 * composite.c (Fremove_list_of_text_properties): Remove decl.
9965 (Fcomposition_get_gstring): New forward static decl.
9966 * composite.h (Fcomposite_get_gstring): Remove decl.
9967 * dired.c (Ffile_attributes): New forward static decl.
9968 * doc.c (Fdocumntation_property): New forward static decl.
9969 * eval.c (Ffetch_bytecode): New forward static decl.
9970 (Funintern): Remove extern decl; now in .h file where it belongs.
9971 * fileio.c (Fmake_symbolic_link): New forward static decl.
9972 * image.c (Finit_image_library): New forward static decl.
9973 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9974 * intervals.h (Fprevious_property_change):
9975 (Fremove_list_of_text_properties): Remove decls.
9976 * keyboard.c (Fthis_command_keys): Remove decl.
9977 (Fcommand_execute): New forward static decl.
9978 * keymap.c (Flookup_key): New forward static decl.
9979 (Fcopy_keymap): Now static.
9980 * keymap.h (Flookup_key): Remove decl.
9981 * process.c (Fget_process): New forward static decl.
9982 (Fprocess_datagram_address): Mark as internal.
9983 * syntax.c (Fsyntax_table_p): New forward static decl.
9984 (skip_chars): Remove duplicate decl.
9985 * textprop.c (Fprevious_property_change): New forward static decl.
9986 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9987 Now internal.
9988 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9989 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9991 * editfns.c (Fformat): Remove unreachable code.
9993 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9995 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9996 change. (Bug#8496)
9998 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10000 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10001 when at ZV. (Bug#8487)
10003 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10005 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10006 (Bug#8437)
10007 * keyboard.c (parse_tool_bar_item): Likewise.
10008 * sound.c (sound_cleanup, alsa_close): Likewise.
10009 * termcap.c (tgetent): Likewise.
10010 * xfns.c (x_default_font_parameter): Likewise.
10011 * xsettings.c (read_and_apply_settings): Likewise.
10013 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10014 (overrun_check_free): Protoize.
10016 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10018 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10019 since callers should never pass a negative size.
10020 Change the signature to match that of plain 'read' and 'write'; see
10021 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10022 * lisp.h: Update prototypes of emacs_write and emacs_read.
10024 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10026 * xdisp.c (redisplay_window): Don't try to determine the character
10027 position of the scroll margin if the window start point w->startp
10028 is outside the buffer's accessible region. (Bug#8468)
10030 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10032 Fix write-region and its subroutines for buffers > 2GB.
10033 * fileio.c (a_write, e_write): Modify declaration of arguments and
10034 local variables to support buffers larger than 2GB.
10035 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10037 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10038 argument, local variables, and return value.
10040 * lisp.h: Update prototypes of emacs_write and emacs_read.
10042 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10044 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10046 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10048 Fix more problems found by GCC 4.6.0's static checks.
10050 * xdisp.c (vmessage): Use a better test for character truncation.
10052 * charset.c (load_charset_map): <, not <=, for optimization,
10053 and to avoid potential problems with integer overflow.
10054 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10055 * casetab.c (set_identity, shuffle): Likewise.
10056 * editfns.c (Fformat): Likewise.
10057 * syntax.c (skip_chars): Likewise.
10059 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10060 This also lets GCC 4.6.0 generate slightly better loop code.
10062 * callint.c (Fcall_interactively): <, not <=, for optimization.
10063 (Fcall_interactively): Count the number of arguments produced,
10064 not the number of arguments given. This is simpler and lets GCC
10065 4.6.0 generate slightly better code.
10067 * ftfont.c: Distingish more carefully between FcChar8 and char.
10068 The previous code passed unsigned char * to a functions like
10069 strlen and xstrcasecmp that expect char *, which does not
10070 conform to the C standard.
10071 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10072 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10073 char * when the C standard requires it.
10075 * keyboard.c (read_char): Remove unused var.
10077 * eval.c: Port to Windows vsnprintf (Bug#8435).
10078 Include <limits.h>.
10079 (SIZE_MAX): Define if the headers do not.
10080 (verror): Do not give up if vsnprintf returns a negative count.
10081 Instead, grow the buffer. This ports to Windows vsnprintf, which
10082 does not conform to C99. Problem reported by Eli Zaretskii.
10083 Also, simplify the allocation scheme, by avoiding the need for
10084 calling realloc, and removing the ALLOCATED variable.
10086 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10088 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10089 But keep the doprint source code for now, as we might revamp it
10090 and use it again (Bug#8435).
10091 * lisp.h (doprnt): Remove.
10092 * Makefile.in (base_obj): Remove doprnt.o.
10093 * deps.mk (doprnt.o): Remove.
10095 error: Print 32- and 64-bit integers portably (Bug#8435).
10096 Without this change, on typical 64-bit hosts error ("...%d...", N)
10097 was used to print both 32- and 64-bit integers N, which relied on
10098 undefined behavior.
10099 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10100 * lisp.h (error, verror): Mark as printf-like functions.
10101 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10102 Report overflow in size calculations when allocating printf buffer.
10103 Do not truncate output string at its first null byte.
10104 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10105 Truncate the output at a character boundary, since vsnprintf does not
10106 do that.
10107 * charset.c (check_iso_charset_parameter): Convert internal
10108 character to string before calling 'error', since %c now has the
10109 printf meaning.
10110 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10111 overflow when computing char to be passed to 'error'. Do not
10112 pass Lisp_Object to 'error'; pass the integer instead.
10113 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10114 formatted with plain %d.
10116 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10118 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10120 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10122 * xterm.c (x_catch_errors): Remove duplicate declaration.
10124 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10126 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10128 2011-04-10 Jim Meyering <meyering@redhat.com>
10130 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10131 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10132 return ssize_t not "int", and use size_t as the buffer length.
10133 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10134 * gnutls.h: Update declarations.
10135 * process.c (read_process_output): Use ssize_t, to match.
10136 (send_process): Likewise.
10138 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10140 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10142 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10144 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10145 Use unsigned char, to match FcChar8 type definition.
10147 * xterm.c (handle_one_xevent):
10148 * xmenu.c (create_and_show_popup_menu):
10149 * xselect.c (x_decline_selection_request)
10150 (x_reply_selection_request): Avoid type-punned deref of X events.
10152 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10154 Fix some uses of `int' instead of EMACS_INT.
10155 * search.c (string_match_1, fast_string_match)
10156 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10157 (scan_buffer, find_next_newline_no_quit)
10158 (find_before_next_newline, search_command, Freplace_match)
10159 (Fmatch_data): Make some `int' variables be EMACS_INT.
10161 * xdisp.c (display_count_lines): 3rd argument and return value now
10162 EMACS_INT. All callers changed.
10163 (pint2hrstr): Last argument is now EMACS_INT.
10165 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10166 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10167 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10168 (decode_coding_utf_16, decode_coding_emacs_mule)
10169 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10170 (decode_coding_ccl, decode_coding_charset)
10171 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10172 (decode_coding_iso_2022, decode_coding_emacs_mule)
10173 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10174 <char_offset, last_offset>: Declare EMACS_INT.
10175 (encode_coding_utf_8, encode_coding_utf_16)
10176 (encode_coding_emacs_mule, encode_invocation_designation)
10177 (encode_designation_at_bol, encode_coding_iso_2022)
10178 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10179 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10180 Declare EMACS_INT.
10181 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10182 (encode_invocation_designation): Last argument P_NCHARS is now
10183 EMACS_INT.
10184 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10185 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10187 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10188 All users changed.
10190 * ccl.c (Fccl_execute_on_string): Declare some variables
10191 EMACS_INT.
10193 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10195 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10197 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10199 * process.c (Fformat_network_address): Doc fix.
10201 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10203 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10205 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10207 * keyboard.c (read_char): Call Lisp function help-form-show,
10208 instead of using internal_with_output_to_temp_buffer.
10209 (Qhelp_form_show): New var.
10210 (syms_of_keyboard): Use DEFSYM macro.
10212 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10214 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10216 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10218 * process.c (Flist_processes): Remove to Lisp.
10219 (list_processes_1): Delete.
10221 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10223 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10225 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10227 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10229 Fix more problems found by GCC 4.6.0's static checks.
10231 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10233 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10235 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10237 * xdisp.c (vmessage): Mark as a printf-like function.
10239 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10241 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10243 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10244 printf-like functions.
10245 (tiff_load): Add casts to remove these marks before passing them
10246 to system-supplied API.
10248 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10250 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10251 This avoids several warnings with gcc -Wstrict-overflow.
10252 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10253 directly, rather than having caller test rule sign. This avoids
10254 some unnecessary tests.
10255 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10256 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10257 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10259 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10260 (xfont_open): Avoid unnecessary tests.
10262 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10264 * composite.h, composite.c (composition_gstring_put_cache):
10265 Use EMACS_INT, not int, for length.
10267 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10268 breaking out part of COMPOSITION_DECODE_RULE.
10269 (COMPOSITION_DECODE_RULE): Use it.
10270 * composite.c (get_composition_id): Remove unused local vars,
10271 by using the new macro.
10273 * textprop.c (set_text_properties_1): Change while to do-while,
10274 since the condition is always true at first.
10276 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10277 (interval_deletion_adjustment): Return unsigned value.
10278 All uses changed.
10280 * process.c (list_processes_1, create_pty, read_process_output):
10281 (exec_sentinel): Remove vars that were set but not used.
10282 (create_pty): Remove unnecessary "volatile"s.
10283 (Fnetwork_interface_info): Avoid possibility of int overflow.
10284 (read_process_output): Do adaptive read buffering even if carryover.
10285 (read_process_output): Simplify nbytes computation if buffered.
10287 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10289 * syntax.c (scan_words): Remove var that was set but not used.
10290 (update_syntax_table): Use unsigned instead of int.
10292 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10293 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10294 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10296 * print.c (print_error_message): Avoid int overflow.
10298 * font.c (font_list_entities): Redo for clarity,
10299 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10301 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10302 (font_score): Avoid potential overflow in diff calculation.
10304 * fns.c (substring_both): Remove var that is set but not used.
10305 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10307 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10309 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10310 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10311 can always succeed if overflow has undefined behavior.
10313 * search.c (boyer_moore, wordify): Remove vars set but not used.
10314 (wordify): Omit three unnecessary tests.
10316 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10317 All callers changed. This avoids the need for an unused var.
10319 * casefiddle.c (casify_region): Remove var that is set but not used.
10321 * dired.c (file_name_completion): Remove var that is set but not used.
10323 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10325 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10326 (Finsert_file_contents): Remove unnecessary code checking fd.
10328 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10329 Check for integer overflow on size calculations.
10331 * buffer.c (Fprevious_overlay_change): Remove var that is set
10332 but not used.
10334 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10335 Remove vars that are set but not used.
10336 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10337 (timer_check_2): Mark vars as initialized.
10339 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10341 * image.c (lookup_image): Remove var that is set but not used.
10342 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10344 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10345 that are set but not used.
10347 * xfns.c (make_invisible_cursor): Don't return garbage
10348 if XCreateBitmapFromData fails (Bug#8410).
10350 * xselect.c (x_get_local_selection, x_handle_property_notify):
10351 Remove vars that are set but not used.
10353 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10354 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10356 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10357 Remove var that is set but not used.
10358 (scroll_bar_windows_size): Now size_t, not int.
10359 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10360 Check for overflow.
10362 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10363 (map_tty_color) [!defined MSDOS]: Likewise.
10365 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10367 * coding.c: Remove vars that are set but not used.
10368 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10369 All callers changed.
10370 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10371 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10372 (decode_coding_charset): Remove vars that are set but not used.
10374 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10375 that is set but not used.
10377 * print.c (print_object): Remove var that is set but not used.
10379 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10380 The gnulib version avoids calling malloc in the usual case,
10381 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10382 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10383 * filelock.c (current_lock_owner): Likewise.
10384 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10385 * sysdep.c: Include allocator.h, careadlinkat.h.
10386 (emacs_no_realloc_allocator): New static constant.
10387 (emacs_readlink): New function.
10388 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10389 ../lib/careadlinkat.h.
10391 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10393 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10394 first non-nil return value).
10396 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10398 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10399 if not defined (Bug#8403).
10401 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10403 * xdisp.c (display_count_lines): Remove parameter `start',
10404 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10405 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10406 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10407 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10408 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10409 and thereabouts. All callers changed.
10410 (get_per_char_metric): Remove parameter `f', unused since
10411 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10413 2011-04-02 Jim Meyering <meyering@redhat.com>
10415 do not dereference NULL upon failed strdup
10416 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10417 (ns_get_family): Likewise.
10419 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10421 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10423 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10425 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10426 later (Bug#8403).
10428 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10430 Add lexical binding.
10432 * window.c (Ftemp_output_buffer_show): New fun.
10433 (Fsave_window_excursion):
10434 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10436 * lread.c (lisp_file_lexically_bound_p): New function.
10437 (Fload): Bind Qlexical_binding.
10438 (readevalloop): Remove `evalfun' arg.
10439 Bind Qinternal_interpreter_environment.
10440 (Feval_buffer): Bind Qlexical_binding.
10441 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10442 Mark as dynamic.
10443 (syms_of_lread): Declare `lexical-binding'.
10445 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10447 * keyboard.c (eval_dyn): New fun.
10448 (menu_item_eval_property): Use it.
10450 * image.c (parse_image_spec): Use Ffunctionp.
10452 * fns.c (concat, mapcar1): Accept byte-code-functions.
10454 * eval.c (Fsetq): Handle lexical vars.
10455 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10456 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10457 (FletX, Flet): Obey lexical binding.
10458 (Fcommandp): Handle closures.
10459 (Feval): New `lexical' arg.
10460 (eval_sub): New function extracted from Feval. Use it almost
10461 everywhere where Feval was used. Look up vars in lexical env.
10462 Handle closures.
10463 (Ffunctionp): Move from subr.el.
10464 (Ffuncall): Handle closures.
10465 (apply_lambda): Remove `eval_flags'.
10466 (funcall_lambda): Handle closures and new byte-code-functions.
10467 (Fspecial_variable_p): New function.
10468 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10469 but without exporting it to Lisp.
10471 * doc.c (Fdocumentation, store_function_docstring):
10472 * data.c (Finteractive_form): Handle closures.
10474 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10475 interactive spec.
10477 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10478 New byte-codes.
10479 (exec_byte_code): New function extracted from Fbyte_code to handle new
10480 calling convention for byte-code-functions. Add new byte-codes.
10482 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10484 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10486 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10488 * xdisp.c (redisplay_internal): Fix prototype.
10490 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10492 * xdisp.c (SCROLL_LIMIT): New macro.
10493 (try_scrolling): Use it when setting scroll_limit.
10494 Limit scrolling to 100 screen lines.
10495 (redisplay_window): Even when falling back on "recentering",
10496 position point in the window according to scroll-conservatively,
10497 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10499 (try_scrolling): When point is above the window, allow searching
10500 as far as scroll_max, or one screenful, to compute vertical
10501 distance from PT to the scroll margin position. This prevents
10502 try_scrolling from unnecessarily failing when
10503 scroll-conservatively is set to a value slightly larger than the
10504 window height. Clean up the case of PT below the margin at bottom
10505 of window: scroll_max can no longer be INT_MAX. When aggressive
10506 scrolling is in use, don't let point enter the opposite scroll
10507 margin as result of the scroll.
10508 (syms_of_xdisp) <scroll-conservatively>: Document the
10509 threshold of 100 lines for never-recentering scrolling.
10511 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10513 * dispextern.h (move_it_by_lines):
10514 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10515 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10516 (message_log_check_duplicate): Remove parameters `prev_bol' and
10517 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10518 (redisplay_internal): Remove parameter `preserve_echo_area',
10519 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10521 * indent.c (Fvertical_motion):
10522 * window.c (window_scroll_pixel_based, Frecenter):
10523 Don't pass `need_y_p' to `move_it_by_lines'.
10525 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10527 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10528 steal a few bits to be more compact.
10529 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10530 Remove unneeded casts.
10532 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10534 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10536 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10537 binding" message (bug#7967).
10539 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10541 Fix more problems found by GCC 4.6.0's static checks.
10543 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10544 Remove unused local var.
10546 * editfns.c (Fmessage_box): Remove unused local var.
10548 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10549 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10550 Omit unused local vars.
10551 * window.c (shrink_windows): Omit unused local var.
10552 * menu.c (digest_single_submenu): Omit unused local var.
10553 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10554 Omit unused local var.
10556 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10557 Don't assume string length fits in int.
10558 (keyremap_step, read_key_sequence): Use size_t for sizes.
10559 (read_key_sequence): Don't check last_real_key_start redundantly.
10561 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10562 instead of alloca (Bug#8344).
10564 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10565 (Fbacktrace_frame): Don't assume nframes fits in int.
10567 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10569 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10570 concerns.
10572 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10574 * cm.c (calccost): Turn while-do into do-while, for clarity.
10576 * keyboard.c (syms_of_keyboard): Use the same style as later
10577 in this function when indexing through an array. This also
10578 works around GCC bug 48267.
10580 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10582 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10584 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10585 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10587 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10588 This avoids undefined behavior on integer overflow, and is a bit
10589 more convenient anyway since it is compared to a size_t variable.
10591 Variadic C functions now count arguments with size_t, not int.
10592 This avoids an unnecessary limitation on 64-bit machines, which
10593 caused (substring ...) to crash on large vectors (Bug#8344).
10594 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10595 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10596 All variadic functions and their callers changed accordingly.
10597 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10598 * data.c (arith_driver, float_arith_driver): Likewise.
10599 * editfns.c (general_insert_function): Likewise.
10600 * eval.c (struct backtrace.nargs, interactive_p)
10601 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10602 (funcall_lambda, mark_backtrace): Likewise.
10603 * fns.c (concat): Likewise.
10604 * frame.c (x_set_frame_parameters): Likewise.
10605 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10606 0 if not found, not -1. All callers changed.
10608 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10609 (stack_copy_size): Now size_t, not int.
10610 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10612 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10614 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10615 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10616 All callers changed.
10618 * lisp.h (multibyte_char_to_unibyte):
10619 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10620 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10621 * character.h (CHAR_TO_BYTE8):
10622 * cmds.c (internal_self_insert):
10623 * editfns.c (general_insert_function):
10624 * keymap.c (push_key_description):
10625 * search.c (Freplace_match):
10626 * xdisp.c (message_dolog, set_message_1): All callers changed.
10628 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10630 * keyboard.c (safe_run_hook_funcall): New function.
10631 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10632 don't set the hook to nil, but remove the offending function instead.
10633 (Qcommand_hook_internal): Remove, unused.
10634 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10635 Vcommand_hook_internal.
10637 * eval.c (enum run_hooks_condition): Remove.
10638 (funcall_nil, funcall_not): New functions.
10639 (run_hook_with_args): Call each function through a `funcall' argument.
10640 Remove `cond' argument, now redundant.
10641 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10642 (Frun_hook_with_args_until_failure): Adjust accordingly.
10643 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10645 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10647 * dispextern.h (string_buffer_position): Remove declaration.
10649 * print.c (strout): Remove parameter `multibyte', unused since
10650 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10652 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10653 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10654 All callers changed.
10656 * w32.c (_wsa_errlist): Use braces for struct initializers.
10658 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10659 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10660 All callers changed.
10661 (string_buffer_position): Likewise. Also, make static (it's never
10662 used outside xdisp.c).
10663 (cursor_row_p): Remove parameter `w', unused since
10664 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10665 (decode_mode_spec): Remove parameter `precision', introduced during
10666 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10667 All callers changed.
10669 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10671 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10673 2011-03-27 Anders Lindgren <andlind@gmail.com>
10675 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10676 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10677 (ns_update_auto_hide_menu_bar): New functions.
10678 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10679 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10680 ns_constrain_all_frames.
10681 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10682 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10684 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10686 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10688 2011-03-27 Glenn Morris <rgm@gnu.org>
10690 * syssignal.h: Replace RETSIGTYPE with void.
10691 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10692 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10693 Replace SIGTYPE with void everywhere.
10694 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10695 * s/template.h (SIGTYPE): Remove commented out definition.
10697 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10699 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10700 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10702 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10704 * w32.c (read_unc_volume): Use parameter `henum', instead of
10705 global variable `wget_enum_handle'.
10707 * keymap.c (describe_vector): Remove parameters `indices' and
10708 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10709 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10711 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10713 * keyboard.c (timer_check): Remove parameter `do_it_now',
10714 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10715 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10716 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10718 * keyboard.c (read_char):
10719 * w32menu.c (w32_menu_display_help):
10720 * xmenu.c (show_help_event, menu_help_callback):
10721 Adjust calls to `show_help_echo'.
10723 * gtkutil.c (xg_maybe_add_timer):
10724 * keyboard.c (readable_events):
10725 * process.c (wait_reading_process_output):
10726 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10728 * insdel.c (adjust_markers_gap_motion):
10729 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10730 (gap_left, gap_right): Don't call it.
10732 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10734 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10735 incurred during fontification.
10737 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10739 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10740 (DEFVAR_PER_BUFFER): Don't pass it.
10742 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10743 (scrolling_window): Don't pass it.
10745 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10747 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10749 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10750 and `suffix'.
10751 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10752 of variables specific to SELinux and computation of `encoded_absname'.
10754 * image.c (XPutPixel): Remove unused variable `height'.
10756 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10758 * unexw32.c (get_section_info): Remove unused variable `section'.
10760 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10761 (system_process_attributes): Remove unused variable `sess'.
10762 (sys_read): Remove unused variable `err'.
10764 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10765 (w32_wnd_proc): Remove unused variable `isdead'.
10766 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10767 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10768 (x_create_tip_frame): Remove unused variable `tem'.
10770 * w32inevt.c (w32_console_read_socket):
10771 Remove unused variable `no_events'.
10773 * w32term.c (x_draw_composite_glyph_string_foreground):
10774 Remove unused variable `width'.
10776 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10778 * w32term.c (x_set_glyph_string_clipping):
10779 Don't pass uninitialized region to CombineRgn.
10781 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10783 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10784 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10785 (Fx_close_connection): Remove unused variable `i'.
10787 * w32font.c (w32font_draw): Return number of glyphs.
10788 (w32font_open_internal): Remove unused variable `i'.
10789 (w32font_driver): Add missing initializer.
10791 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10792 (fill_in_menu): Remove unused variable `items_added'.
10794 * w32term.c (last_mouse_press_frame): Remove static global variable.
10795 (w32_clip_to_row): Remove unused variable `f'.
10796 (x_delete_terminal): Remove unused variable `i'.
10798 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10799 (NOTHING): Remove unused static global variable.
10800 (uniscribe_check_otf): Remove unused variable `table'.
10801 (uniscribe_font_driver): Add missing initializers.
10803 2011-03-23 Julien Danjou <julien@danjou.info>
10805 * term.c (Fsuspend_tty, Fresume_tty):
10806 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10807 * window.c (temp_output_buffer_show):
10808 * insdel.c (signal_before_change):
10809 * frame.c (Fhandle_switch_frame):
10810 * fileio.c (Fdo_auto_save):
10811 * emacs.c (Fkill_emacs):
10812 * editfns.c (save_excursion_restore):
10813 * cmds.c (internal_self_insert):
10814 * callint.c (Fcall_interactively):
10815 * buffer.c (Fkill_all_local_variables):
10816 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10817 Use Frun_hooks.
10818 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10819 unconditionally since it does the check itself.
10821 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10823 Fix more problems found by GCC 4.5.2's static checks.
10825 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10826 the first time through the loop, since we know p0 < p1 then.
10827 This also avoids a gcc -Wstrict-overflow warning.
10829 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10830 leading to a memory leak, possible in functions like
10831 load_charset_map_from_file that can allocate an unbounded number
10832 of objects (Bug#8318).
10834 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10835 that could (at least in theory) be that large.
10837 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10838 This is less likely to overflow, and avoids undefined behavior if
10839 overflow does occur. All callers changed. Use strtoul to scan
10840 for the unsigned long integer.
10841 (pint2hrstr): Simplify and tune code slightly.
10842 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10844 * scroll.c (do_scrolling): Work around GCC bug 48228.
10845 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10847 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10848 This also avoids a warning with gcc -Wstrict-overflow.
10849 (validate_x_resource_name): Simplify count usage.
10850 This also avoids a warning with gcc -Wstrict-overflow.
10852 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10853 fail (Bug#8306).
10855 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10857 * process.c (Fmake_network_process): Use socklen_t, not int,
10858 where POSIX says socklen_t is required in portable programs.
10859 This fixes a porting bug on hosts like 64-bit HP-UX, where
10860 socklen_t is wider than int (Bug#8277).
10861 (Fmake_network_process, server_accept_connection):
10862 (wait_reading_process_output, read_process_output):
10863 Likewise.
10865 * process.c: Rename or move locals to avoid shadowing.
10866 (list_processes_1, Fmake_network_process):
10867 (read_process_output_error_handler, exec_sentinel_error_handler):
10868 Rename or move locals.
10869 (Fmake_network_process): Define label "retry_connect" only if needed.
10870 (Fnetwork_interface_info): Fix pointer signedness.
10871 (process_send_signal): Add cast to avoid pointer signedness problem.
10872 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10873 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10875 Make tparam.h and terminfo.c consistent.
10876 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10877 Include tparam.h instead, since it declares them.
10878 * cm.h (PC): Remove extern decl; tparam.h now does this.
10879 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10880 * terminfo.c: Include tparam.h, to check interfaces.
10881 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10882 (tparam): Adjust signature to match interface in tparam.h;
10883 this removes some undefined behavior. Check that outstring and len
10884 are zero, which they always are with Emacs.
10885 * tparam.h (PC, BC, UP): New extern decls.
10887 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10888 (xftfont_open): Rename locals to avoid shadowing.
10890 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10891 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10892 (OTF_TAG_SYM): Omit macro if not needed.
10893 (ftfont_list): Remove unused local.
10894 (get_adstyle_property, ftfont_pattern_entity):
10895 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10896 Rename locals to avoid shadowing.
10898 * xfont.c (xfont_list_family): Mark var as initialized.
10900 * xml.c (make_dom): Now static.
10902 * composite.c (composition_compute_stop_pos): Rename local to
10903 avoid shadowing.
10904 (composition_reseat_it): Remove unused locals.
10905 (find_automatic_composition, composition_adjust_point): Likewise.
10906 (composition_update_it): Mark var as initialized.
10907 (find_automatic_composition): Mark vars as initialized,
10908 with a FIXME (Bug#8290).
10910 character.h: Rename locals to avoid shadowing.
10911 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10912 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10913 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10914 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10915 to avoid shadowing.
10917 * textprop.c (property_change_between_p): Remove; unused.
10919 * intervals.c (interval_start_pos): Now static.
10921 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10923 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10924 Rename locals to avoid shadowing.
10926 * sound.c (wav_play, au_play, Fplay_sound_internal):
10927 Fix pointer signedness.
10928 (alsa_choose_format): Remove unused local var.
10929 (wav_play): Initialize a variable to 0, to prevent undefined
10930 behavior (Bug#8278).
10932 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10934 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10936 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10937 clobbering (Bug#8298).
10938 * sysdep.c (sys_subshell): Likewise.
10939 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10941 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10942 This should get cleaned up, so that child_setup has the
10943 same signature on all platforms.
10945 * callproc.c (call_process_cleanup): Now static.
10946 (relocate_fd): Rename locals to avoid shadowing.
10948 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10950 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10951 not to be necessary, and produces flickering.
10953 2011-03-20 Glenn Morris <rgm@gnu.org>
10955 * config.in: Remove file.
10957 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10959 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10960 are now in src/globals.h.
10961 (syms_of_minibuf): Remove spurious & from previous change.
10963 2011-03-20 Leo Liu <sdl.web@gmail.com>
10965 * minibuf.c (completing-read-function): New variable.
10966 (completing-read-default): Rename from completing-read.
10967 (completing-read): Call completing-read-function.
10969 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10971 * xfaces.c (Fx_load_color_file):
10972 Read color file from absolute filename (bug#8250).
10974 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10976 * makefile.w32-in: Update dependencies.
10978 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10980 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10982 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10984 Fix more problems found by GCC 4.5.2's static checks.
10986 * process.c (make_serial_process_unwind, send_process_trap):
10987 (sigchld_handler): Now static.
10989 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10990 That way, the code declares only the vars that it needs.
10991 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10992 * s/cygwin.h (PTY_ITERATION): Likewise.
10993 * s/darwin.h (PTY_ITERATION): Likewise.
10994 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10996 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10997 * process.c (allocate_pty): Don't declare stb unless it's needed.
10999 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11000 (CONSTANTLIM): Remove; unused.
11001 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11002 Define only if needed.
11004 * unexelf.c (unexec): Name an expression,
11005 to avoid gcc -Wbad-function-cast warning.
11006 Use a different way to cause a compilation error if anyone uses
11007 n rather than nn, a way that does not involve shadowing.
11008 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11010 * deps.mk (unexalpha.o): Remove; unused.
11012 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11013 * unexec.h: New file.
11014 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11015 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11016 Depend on unexec.h.
11017 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11018 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11019 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11020 Change as necessary to match prototype in unexec.h.
11022 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11023 shadowing.
11024 (back_comment, skip_chars): Mark vars as initialized.
11026 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11027 Rename locals to avoid shadowing.
11029 * lread.c (read1): Rewrite so as not to use empty "else".
11030 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11032 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11034 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11035 warning when compiling print.c.
11037 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11038 instead of using an uninitialized var.
11039 (font_sort_entities): Mark var as initialized.
11041 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11043 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11044 pointers to constants.
11045 (font_parse_fcname): Remove unused vars.
11046 (font_delete_unmatched): Now static.
11047 (font_get_spec): Remove; unused.
11048 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11049 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11050 Rename or move locals to avoid shadowing.
11052 * fns.c (require_nesting_list, require_unwind): Now static.
11053 (Ffillarray): Rename locals to avoid shadowing.
11055 * floatfns.c (domain_error2): Define only if needed.
11056 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11058 * alloc.c (mark_backtrace): Move decl from here ...
11059 * lisp.h: ... to here, so that it can be checked.
11061 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11062 (Fdefvar): Rewrite so as not to use empty "else".
11063 (lisp_indirect_variable): Name an expression,
11064 to avoid gcc -Wbad-function-cast warning.
11065 (Fdefvar): Rename locals to avoid shadowing.
11067 * callint.c (quotify_arg, quotify_args): Now static.
11068 (Fcall_interactively): Rename locals to avoid shadowing.
11069 Use const pointer when appropriate.
11071 * lisp.h (get_system_name, get_operating_system_release):
11072 Move decls here, to check interfaces.
11073 * process.c (get_operating_system_release): Move decl to lisp.h.
11074 * xrdb.c (get_system_name): Likewise.
11075 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11076 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11077 some of which prompt warnings from gcc -Wbad-function-cast.
11078 (Fformat_time_string, Fencode_time, Finsert_char):
11079 (Ftranslate_region_internal, Fformat):
11080 Rename or remove local vars to avoid shadowing.
11081 (Ftranslate_region_internal): Mark var as initialized.
11083 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11084 avoid shadowing.
11086 * lisp.h (eassert): Check that the argument compiles, even if
11087 ENABLE_CHECKING is not defined.
11089 * data.c (Findirect_variable): Name an expression, to avoid
11090 gcc -Wbad-function-cast warning.
11091 (default_value, arithcompare, arith_driver, arith_error): Now static.
11092 (store_symval_forwarding): Rename local to avoid shadowing.
11093 (Fmake_variable_buffer_local, Fmake_local_variable):
11094 Mark variables as initialized.
11095 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11097 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11098 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11099 Rename locals to avoid shadowing.
11100 (mark_stack): Move local variables into the #ifdef region where
11101 they're used.
11102 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11103 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11104 needed otherwise.
11105 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11106 (GC_STRING_CHARS): Remove; not used.
11107 (Fmemory_limit): Cast sbrk's returned value to char *.
11109 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11110 avoids undefined behavior in theory.
11112 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11114 Use functions, not macros, for up- and down-casing (Bug#8254).
11115 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11116 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11117 to use the following functions instead of these macros.
11118 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11119 EMACS_INT, since callers assume the returned value fits in int.
11120 (upcase1): Likewise, for UPCASE_TABLE.
11121 (uppercasep, lowercasep, upcase): New static inline functions.
11122 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11123 the race-condition problem in the old DOWNCASE.
11125 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11126 Rename locals to avoid shadowing.
11127 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11128 (regex_compile, re_search_2, re_match_2_internal):
11129 Remove unused local vars.
11130 (FREE_VAR): Rewrite so as not to use empty "else",
11131 which gcc can warn about.
11132 (regex_compile, re_match_2_internal): Mark locals as initialized.
11133 (RETALLOC_IF): Define only if needed.
11134 (WORDCHAR_P): Likewise. This one is never needed, but is used
11135 only in a comment talking about a compiler bug, so put inside
11136 the #if 0 of that comment.
11137 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11138 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11139 Remove; unused.
11141 * search.c (boyer_moore): Rename locals to avoid shadowing.
11142 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11143 (PREV_CHAR_BOUNDARY): Likewise.
11145 * search.c (simple_search): Remove unused var.
11147 * dired.c (compile_pattern): Move decl from here ...
11148 * lisp.h: ... to here, so that it can be checked.
11149 (struct re_registers): New forward decl.
11151 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11153 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11154 All uses changed.
11155 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11156 Rename locals to avoid shadowing.
11157 (Fvertical_motion): Mark locals as initialized.
11159 * casefiddle.c (casify_object, casify_region): Now static.
11160 (casify_region): Mark local as initialized.
11162 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11164 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11165 New macros, so that the caller can use some names other than
11166 gcpro1, gcpro2, etc.
11167 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11168 of the new macros.
11169 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11170 argument, for consistency with GCPRO2_VAR, etc: it is now the
11171 prefix of the variable, not the variable itself. All uses
11172 changed.
11173 * dired.c (directory_files_internal, file_name_completion):
11174 Rename locals to avoid shadowing.
11176 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11177 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11178 dired.c's scmp function, had undefined behavior.
11179 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11180 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11181 * buffer.h: ... to here, because these macros use current_buffer,
11182 and the new implementation with inline functions needs to have
11183 current_buffer in scope now, rather than later when the macros
11184 are used.
11185 (downcase, upcase1): New static inline functions.
11186 (DOWNCASE, UPCASE1): Reimplement using these functions.
11187 This avoids undefined behavior in expressions like
11188 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11189 from race conditions in accessing the global variables
11190 case_temp1 and case_temp2.
11191 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11192 * lisp.h (case_temp1, case_temp2): Remove their decls.
11193 * character.h (ASCII_CHAR_P): Move from here ...
11194 * lisp.h: ... to here, so that the inline functions mentioned
11195 above can use them.
11197 * dired.c (directory_files_internal_unwind): Now static.
11199 * fileio.c (file_name_as_directory, directory_file_name):
11200 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11201 Now static.
11202 (file_name_as_directory): Use const pointers when appropriate.
11203 (Fexpand_file_name): Likewise. In particular, newdir might
11204 point at constant storage, so make it a const pointer.
11205 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11206 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11207 signedness issues.
11208 (Fset_file_times, Finsert_file_contents, auto_save_error):
11209 Rename locals to avoid shadowing.
11211 * minibuf.c (choose_minibuf_frame_1): Now static.
11212 (Ftry_completion, Fall_completions): Rename or remove locals
11213 to avoid shadowing.
11215 * marker.c (bytepos_to_charpos): Remove; unused.
11217 * lisp.h (verify_bytepos, count_markers): New decls,
11218 so that gcc does not warn that these functions aren't declared.
11220 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11221 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11222 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11223 (copy_text): Remove unused local var.
11225 * filelock.c (within_one_second): Now static.
11226 (lock_file_1): Rename local to avoid shadowing.
11228 * buffer.c (fix_overlays_before): Mark locals as initialized.
11229 (fix_start_end_in_overlays): Likewise. This function should be
11230 simplified by using pointers-to-pointers, but that's a different
11231 matter.
11232 (switch_to_buffer_1): Now static.
11233 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11234 (report_overlay_modification): Rename locals to avoid shadowing.
11236 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11237 Fix pointer signedness issue.
11238 (sys_subshell): Mark local as volatile if checking for lint,
11239 to suppress a gcc -Wclobbered warning that does not seem to be right.
11240 (MAXPATHLEN): Define only if needed.
11242 * process.c (serial_open, serial_configure): Move decls from here ...
11243 * systty.h: ... to here, so that they can be checked.
11245 * fns.c (get_random, seed_random): Move extern decls from here ...
11246 * lisp.h: ... to here, so that they can be checked.
11248 * sysdep.c (reset_io): Now static.
11249 (wait_for_termination_signal): Remove; unused.
11251 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11252 (copy_keymap_item, append_key, push_text_char_description):
11253 Now static.
11254 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11255 (DENSE_TABLE_SIZE): Remove; unused.
11256 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11257 (describe_map_tree):
11258 Rename locals to avoid shadowing.
11260 * keyboard.c: Declare functions static if they are not used elsewhere.
11261 (echo_char, echo_dash, cmd_error, top_level_2):
11262 (poll_for_input, handle_async_input): Now static.
11263 (read_char, kbd_buffer_get_event, make_lispy_position):
11264 (make_lispy_event, make_lispy_movement, apply_modifiers):
11265 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11266 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11267 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11268 (read_key_sequence, read_char): Mark locals as initialized.
11269 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11271 * keyboard.h (make_ctrl_char): New decl.
11272 (mark_kboards): Move decl here ...
11273 * alloc.c (mark_kboards): ... from here.
11275 * lisp.h (force_auto_save_soon): New decl.
11277 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11278 (DEFINE_DUMMY_FUNCTION): New macro.
11279 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11280 Use it.
11281 (main): Add casts to avoid warnings
11282 if GCC considers string literals to be constants.
11284 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11286 * dbusbind.c: Pointer signedness fixes.
11287 (xd_signature, xd_append_arg, xd_initialize):
11288 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11289 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11290 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11291 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11293 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11294 if GCC considers string literals to be constants.
11295 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11297 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11299 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11300 (print_preprocess, print_object): New macro to fix last change.
11302 * print.c (print_preprocess): Don't forget font objects.
11304 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11306 * emacs.c (USAGE3): Doc fixes.
11308 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11310 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11311 structure.
11313 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11315 * lisp.h (VWindow_system, Qfile_name_history):
11316 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11317 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11318 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11320 * w32select.c: Don't #include "keyboard.h".
11321 (run_protected): Add extern declaration for waiting_for_input.
11323 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11324 * w32console.c (detect_input_pending, read_input_pending)
11325 (encode_terminal_code):
11326 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11327 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11328 (w32_system_caret_y, Qfile_name_history):
11329 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11330 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11331 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11332 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11333 * w32proc.c (Qlocal, report_file_error):
11334 * w32term.c (Vwindow_system, updating_frame):
11335 * w32uniscribe.c (initialized, uniscribe_font_driver):
11336 Remove unneeded extern declarations.
11338 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11340 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11342 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11344 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11345 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11346 These macros can no longer be used for assignment.
11348 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11349 Assign struct members directly, instead of using BUF_BEGV etc.
11350 (record_buffer_markers, fetch_buffer_markers): New functions for
11351 recording and fetching special buffer markers.
11352 (set_buffer_internal_1, set_buffer_temp): Use them.
11354 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11356 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11358 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11359 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11361 * xdisp.c (hscroll_window_tree):
11362 (reconsider_clip_changes): Use PT instead of BUF_PT.
11364 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11366 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11367 $(EMACS_ROOT)/lib/intprops.h.
11369 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11371 Fix more problems found by GCC 4.5.2's static checks.
11373 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11374 to unsigned char * to avoid compiler diagnostic.
11375 (xg_free_frame_widgets): Make it clear that a local variable is
11376 needed only if USE_GTK_TOOLTIP.
11377 (gdk_window_get_screen): Make it clear that this macro is needed
11378 only if USE_GTK_TOOLTIP.
11379 (int_gtk_range_get_value): New function, which avoids a diagnostic
11380 from gcc -Wbad-function-cast.
11381 (xg_set_toolkit_scroll_bar_thumb): Use it.
11382 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11383 diagnostic from gcc -Wbad-function-cast.
11384 (get_utf8_string, xg_get_file_with_chooser):
11385 Rename locals to avoid shadowing.
11386 (create_dialog): Move locals to avoid shadowing.
11388 * xgselect.c (xg_select): Remove unused var.
11390 * image.c (four_corners_best): Mark locals as initialized.
11391 (gif_load): Initialize transparent_p to zero (Bug#8238).
11392 Mark another local as initialized.
11393 (my_png_error, my_error_exit): Mark with NO_RETURN.
11395 * image.c (clear_image_cache): Now static.
11396 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11397 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11398 (x_edge_detection): Remove unnecessary cast that
11399 gcc -Wbad-function-cast diagnoses.
11400 (gif_load): Fix pointer signedness.
11401 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11402 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11404 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11406 Improve quality of tests for time stamp overflow.
11407 For example, without this patch (encode-time 0 0 0 1 1
11408 1152921504606846976) returns the obviously-bogus value (-948597
11409 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11410 reports time overflow. See
11411 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11412 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11413 * editfns.c: Include limits.h and intprops.h.
11414 (TIME_T_MIN, TIME_T_MAX): New macros.
11415 (time_overflow): Move earlier, to before first use.
11416 (hi_time, lo_time): New functions, for an accurate test for
11417 out-of-range times.
11418 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11419 (Fget_internal_run_time): Don't assume time_t fits in int.
11420 (make_time): Use list2 instead of Fcons twice.
11421 (Fdecode_time): More accurate test for out-of-range times.
11422 (check_tm_member): New function.
11423 (Fencode_time): Use it, to test for out-of-range times.
11424 (lisp_time_argument): Don't rely on undefined left-shift and
11425 right-shift behavior when checking for time stamp overflow.
11427 * editfns.c (time_overflow): New function, refactoring common code.
11428 (Fformat_time_string, Fdecode_time, Fencode_time):
11429 (Fcurrent_time_string): Use it.
11431 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11432 * dired.c (make_time): Move to ...
11433 * editfns.c (make_time): ... here.
11434 * systime.h: Note the move.
11436 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11438 * fringe.c (update_window_fringes): Remove unused variables.
11440 * unexmacosx.c (copy_data_segment): Also copy __got section.
11441 (Bug#8223)
11443 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11445 * termcap.c [MSDOS]: Include "msdos.h".
11446 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11447 Constify `char *' arguments and their references according to
11448 prototypes in tparam.h.
11450 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11452 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11453 Adapt all references accordingly.
11455 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11457 2011-03-11 Tom Tromey <tromey@redhat.com>
11459 * buffer.c (syms_of_buffer): Remove obsolete comment.
11461 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11463 * termhooks.h (encode_terminal_code): Declare prototype.
11465 * msdos.c (encode_terminal_code): Don't declare prototype.
11467 * term.c (encode_terminal_code): Now external again, used by
11468 w32console.c and msdos.c.
11470 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11471 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11473 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11475 Fix some minor problems found by GCC 4.5.2's static checks.
11477 * fringe.c (update_window_fringes): Mark locals as initialized
11478 (Bug#8227).
11479 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11481 * alloc.c (mark_fringe_data): Move decl from here ...
11482 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11483 to check its interface.
11484 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11486 * fontset.c (free_realized_fontset): Now static.
11487 (Fset_fontset_font): Rename local to avoid shadowing.
11488 (fontset_font): Mark local as initialized.
11489 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11491 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11493 * xselect.c (x_disown_buffer_selections): Remove; not used.
11494 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11495 (x_own_selection, Fx_disown_selection_internal): Rename locals
11496 to avoid shadowing.
11497 (x_handle_dnd_message): Remove local to avoid shadowing.
11499 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11500 so that the caller can use some name other than gcpro1.
11501 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11502 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11503 (Fx_backspace_delete_keys_p):
11504 Use them to avoid shadowing, and rename vars to avoid shadowing.
11505 (x_decode_color, x_set_name, x_window): Now static.
11506 (Fx_create_frame): Add braces to silence GCC warning.
11507 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11508 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11509 Remove unused locals.
11510 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11511 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11512 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11513 macros.
11515 * xterm.h (x_mouse_leave): New decl.
11517 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11518 Remove unused functions.
11519 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11520 (x_calc_absolute_position): Now static.
11521 (XTread_socket): Don't define label "out" unless it's used.
11522 Don't declare local "event" unless it's used.
11523 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11524 unless they are used.
11525 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11526 (x_fatal_error_signal): Remove; not used.
11527 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11528 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11529 (x_error_catcher, x_connection_closed, x_error_handler):
11530 (x_error_quitter, xembed_send_message, x_iconify_frame):
11531 (my_log_handler): Rename locals to avoid shadowing.
11532 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11533 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11535 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11536 Rename or move locals to avoid shadowing.
11537 (tty_defined_color, merge_face_heights): Now static.
11538 (free_realized_faces_for_fontset): Remove; not used.
11539 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11540 does not deduce is never used uninitialized.
11541 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11542 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11544 * terminal.c (store_terminal_param): Now static.
11546 * xmenu.c (menu_highlight_callback): Now static.
11547 (set_frame_menubar): Remove unused local.
11548 (xmenu_show): Rename parameter to avoid shadowing.
11549 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11550 since they might point to immutable storage.
11551 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11552 since it's unused otherwise.
11554 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11555 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11556 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11557 avoids a gcc -Wuninitialized diagnostic.
11558 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11559 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11560 does not deduce are never used uninitialized.
11562 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11564 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11565 * window.c (window_loop, size_window):
11566 (run_window_configuration_change_hook, enlarge_window): Likewise.
11568 * window.c (display_buffer): Now static.
11569 (size_window): Mark variables that gcc -Wuninitialized
11570 does not deduce are never used uninitialized.
11571 * window.h (check_all_windows): New decl, to forestall
11572 gcc -Wmissing-prototypes diagnostic.
11573 * dispextern.h (bidi_dump_cached_states): Likewise.
11575 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11576 shadowing.
11577 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11578 Include <limits.h>.
11579 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11580 and to avoid gcc -Wuninitialized warning.
11581 (load_charset_map): Mark variables that gcc -Wuninitialized
11582 does not deduce are never used uninitialized.
11583 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11585 * coding.c (coding_set_source, coding_set_destination):
11586 Use "else { /* comment */ }" rather than "else /* comment */;"
11587 for clarity, and to avoid gcc -Wempty-body warning.
11588 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11589 a block, when the outer 'i' will do.
11590 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11591 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11592 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11593 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11594 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11595 Rename locals to avoid shadowing.
11596 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11597 * coding.c (emacs_mule_char, encode_invocation_designation):
11598 Now static, since they're not used elsewhere.
11599 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11600 (decode_coding_object, encode_coding_object, detect_coding_system):
11601 (decode_coding_emacs_mule): Mark variables that gcc
11602 -Wuninitialized does not deduce are never used uninitialized.
11603 (detect_coding_iso_2022): Initialize a local variable that might
11604 be used uninitialized. Leave a FIXME because it's not clear that
11605 this initialization is needed. (Bug#8211)
11606 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11607 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11608 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11609 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11610 Remove unused macros.
11612 * category.c (hash_get_category_set): Remove unused local var.
11613 (copy_category_table): Now static, since it's not used elsewhere.
11614 * character.c (string_count_byte8): Likewise.
11616 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11617 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11619 * chartab.c (copy_sub_char_table): Now static, since it's not used
11620 elsewhere.
11621 (sub_char_table_ref_and_range, char_table_ref_and_range):
11622 Rename locals to avoid shadowing.
11623 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11625 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11626 (BIDI_BOB): Remove unused macro.
11628 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11629 deduce are never used uninitialized.
11630 * term.c (encode_terminal_code): Likewise.
11632 * term.c (encode_terminal_code): Now static. Remove unused local.
11634 * tparam.h: New file.
11635 * term.c, tparam.h: Include it.
11636 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11637 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11638 Move these decls to tparam.h, and make them agree with what
11639 is actually in tparam.c. The previous trick of using incompatible
11640 decls in different modules does not conform to the C standard.
11641 All callers of tparam changed to use tparam's actual API.
11642 * tparam.c (tparam1, tparam, tgoto):
11643 Use const pointers where appropriate.
11645 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11646 * cm.h (struct cm): Likewise.
11647 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11648 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11649 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11650 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11651 (turn_on_face, init_tty): Likewise.
11652 * termchar.h (struct tty_display_info): Likewise.
11654 * term.c (term_mouse_position): Rename local to avoid shadowing.
11656 * alloc.c (mark_ttys): Move decl from here ...
11657 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11659 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11661 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11663 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11665 * search.c (compile_pattern_1): Remove argument regp, unused since
11666 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11667 (compile_pattern): Don't pass it.
11669 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11671 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11672 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11673 for ! HAVE_GTK3.
11674 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11676 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11678 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11679 gdk_window_get_screen, gdk_window_get_geometry,
11680 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11681 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11682 (xg_get_pixbuf_from_pixmap): New function.
11683 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11684 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11685 Call xg_get_pixbuf_from_pixmap instead of
11686 gdk_pixbuf_get_from_drawable.
11687 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11688 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11689 (xg_check_special_colors): Use GtkStyleContext and its functions
11690 for HAVE_GTK3.
11691 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11692 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11693 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11694 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11695 Call gtk_widget_get_preferred_size.
11696 (xg_frame_resized): gdk_window_get_geometry only takes 5
11697 parameters.
11698 (xg_win_to_widget, xg_event_is_for_menubar):
11699 Call gdk_x11_window_lookup_for_display.
11700 (xg_set_widget_bg): New function.
11701 (delete_cb): New function.
11702 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11703 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11704 (xg_set_background_color): Call xg_set_widget_bg.
11705 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11706 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11707 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11708 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11709 if ! HAVE_GTK3.
11710 (update_frame_tool_bar): Call gtk_widget_hide.
11711 (xg_initialize): Use GDK_KEY_g.
11713 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11714 if ! HAVE_GTK3
11715 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11717 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11718 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11719 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11721 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11723 * w32xfns.c (select_palette): Check success of RealizePalette against
11724 GDI_ERROR, not zero.
11726 See ChangeLog.11 for earlier changes.
11728 ;; Local Variables:
11729 ;; coding: utf-8
11730 ;; End:
11732 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11734 This file is part of GNU Emacs.
11736 GNU Emacs is free software: you can redistribute it and/or modify
11737 it under the terms of the GNU General Public License as published by
11738 the Free Software Foundation, either version 3 of the License, or
11739 (at your option) any later version.
11741 GNU Emacs is distributed in the hope that it will be useful,
11742 but WITHOUT ANY WARRANTY; without even the implied warranty of
11743 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11744 GNU General Public License for more details.
11746 You should have received a copy of the GNU General Public License
11747 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.