1 2013-08-28 Paul Eggert <eggert@cs.ucla.edu>
3 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
4 for portability to hosts where /bin/sh has problems.
6 2013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
8 Redesign redisplay interface to drop global output_cursor.
9 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
10 (toplevel): Remove declaration of output_cursor.
11 (set_output_cursor, x_cursor_to): Remove prototype.
12 * window.h (struct window): New member output_cursor.
13 (output_cursor_to): New function to replace RIF member.
14 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
15 (update_text_area, set_window_cursor_after_update): Use it.
16 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
17 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
18 * nsterm.m (ns_update_window_begin, ns_update_window_end):
19 * w32term.c (x_update_window_begin, x_update_window_end):
20 * xterm.c (x_update_window_begin, x_update_window_end):
21 Adjust to use per-window output cursor.
23 2013-08-27 Paul Eggert <eggert@cs.ucla.edu>
25 Simplify SELECT_TYPE-related code.
26 Like EMACS_TIME, this portability layer is no longer needed, since
27 Emacs has been using fd_set as a portability layer for some time.
28 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
29 (SELECT_TYPE): Remove. All uses changed to fd_set.
30 (fd_set) [!FD_SET]: New typedef.
32 Simplify EMACS_TIME-related code.
33 This portability layer is no longer needed, since Emacs has been
34 using struct timespec as a portability layer for some time.
35 * atimer.h, buffer.h, dispextern.h, xgselect.h:
36 Include <time.h> rather than "systime.h"; that's all that's needed now.
37 * dispnew.c: Include <timespec.h> rather than "systime.h";
38 that's all that's needed now.
39 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
40 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
42 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
43 LOG10_TIMESPEC_RESOLUTION.
44 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
45 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
46 (make_emacs_time): Remove. All used changed to make_timespec.
47 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
48 (current_timespec): Rename from current_emacs_time. All uses changed.
49 (add_emacs_time): Remove. All uses changed to timespec_add.
50 (sub_emacs_time): Remove. All uses change dot timespec_sub.
51 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
52 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
53 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
54 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
55 (current_timespec): Rename from current_emacs_time. All uses changed.
56 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
57 changed to timespec_cmp.
58 * xgselect.c: Include <timespec.h>, since our .h files don't.
60 2013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
62 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
63 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
65 * gtkutil.c (toplevel): Do not declare Qxft but include
67 * image.c (toplevel): Do not declare Vlibrary_cache because
68 it's already done in lisp.h.
70 2013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
72 * lisp.h (Mouse_HLInfo): Move from here...
73 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
74 (reset_mouse_highlight): New function.
75 * msdos.c (dos_set_window_size, IT_update_begin)
76 (internal_terminal_init):
77 * nsterm.m (ns_update_window_end, x_free_frame_resources)
78 (ns_initialize_display_info):
79 * w32console.c (initialize_w32_display):
80 * w32term.c (x_update_window_end, x_free_frame_resources)
81 (w32_initialize_display_info):
82 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
83 * window.c (Fdelete_other_windows_internal):
84 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
85 * termchar.h (toplevel):
86 * xterm.h (toplevel): Include dispextern.h.
88 2013-08-26 Paul Eggert <eggert@cs.ucla.edu>
90 Fix minor problems found by static checking.
91 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
92 (expect): Avoid nested-if warning.
93 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
94 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
95 * nsterm.h, nsterm.m (ns_select):
96 * xgselect.c, xgselect.h (xg_select):
97 Adjust signature to better match pselect's.
98 * nsterm.m (ns_select):
99 Don't set *TIMEOUT, since pselect doesn't.
100 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
101 diagnostic about assigning const char * to it.
102 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
104 2013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
106 * lread.c (substitute_object_recurse): Handle hash-tables as well
109 2013-08-26 Paul Eggert <eggert@cs.ucla.edu>
111 Fix unlikely core dump in init_tty, and simplify terminfo case.
112 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
113 The old version incorrectly dumped core if malloc returned a
114 buffer containing only non-NUL bytes.
115 (init_tty): Do not allocate or free termcap buffers; the
116 struct does that for us now.
117 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
118 (struct tty_display_info): Define members termcap_term_buffer and
119 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
120 use them. Allocate them directly in struct rather than indirectly
121 via a pointer, to simplify init_tty.
123 * frame.c (check_minibuf_window): Initialize 'window' properly,
124 so that Emacs reliably aborts later if 'window' is not initialized.
126 2013-08-26 Jan Djärv <jan.h.d@swipnet.se>
128 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
129 of VoidSymbol (Bug#15154).
131 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
133 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
134 mouse_face_beg_y and mouse_face_end_y.
135 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
136 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
137 Adjust users and update comment where appropriate.
139 2013-08-26 Martin Rudalics <rudalics@gmx.at>
141 * frame.c (check_minibuf_window): New function.
142 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
143 Call check_minibuf_window (Bug#15183).
145 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
147 * window.h (struct window): Replace last_cursor with last_cursor_vpos
148 because this is the only last cursor data we need to keep and consult.
149 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
150 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
153 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
155 Fix recovering from possible decompression error.
156 Since insert_from_gap doesn't always move point, we can't use PT as
157 the position where the partially decompressed data ends, and
158 should count how many bytes was produced so far.
159 * decompress.c (struct decompress_unwind_data): Add nbytes member.
160 (unwind_decompress): Really delete partially uncompressed data.
161 (Fzlib_decompress_region): Take decompressed data size into account.
163 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
165 * syntax.c (init_syntax_once): Adjust comment and do an early
166 initialization of Qchar_table_extra_slots just once...
167 * casetab.c (init_casetab_once):
168 * category.c (init_category_once):
169 * character.c (syms_of_character):
170 * coding.c (syms_of_coding):
171 * xdisp.c (syms_of_xdisp): ...and omit it here.
173 2013-08-24 Eli Zaretskii <eliz@gnu.org>
175 * xdisp.c (get_next_display_element): Don't apply to characters
176 from a display vector the logic of setting it->end_of_box_run_p
177 suitable for characters from a buffer. (Bug#15175)
179 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
180 to handle directories, rather than '_utime' which doesn't.
183 2013-08-24 Jan Djärv <jan.h.d@swipnet.se>
185 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
186 or fullscreen (Bug#14627).
188 2013-08-24 Paul Eggert <eggert@cs.ucla.edu>
190 System-dependent integer overflow fixes.
191 * process.c (Fset_process_window_size): Signal an error if
192 the window size is outside the range supported by the lower level.
193 * sysdep.c (set_window_size): Return negative on error,
194 nonnegative on success, rather than -1, 0, 1 on not in system,
195 failure, success. This is simpler. Caller changed.
196 (serial_configure): Remove unnecessary initialization of local.
197 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
198 size fits in unsigned long; this isn't true on some 32-bit hosts.
199 Avoid buffer overrun if some future version of /proc/meminfo has a
200 variable name longer than 20 bytes.
201 (system_process_attributes) [__FreeBSD__]:
202 Don't assume hw.availpages fits in 'int'.
204 2013-08-23 Paul Eggert <eggert@cs.ucla.edu>
206 Don't let very long directory names overrun the stack.
207 Fix some related minor problems involving "//", vfork.
208 * callproc.c (encode_current_directory): New function.
209 (call_process): Don't append "/"; not needed.
210 * fileio.c (file_name_as_directory_slop): New constant.
211 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
212 this can save the caller having to alloca.
213 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
214 Use SAFE_ALLOCA, not alloca.
215 (directory_file_name, Fexpand_file_name): Leave leading "//"
216 alone, since it can be special even on POSIX platforms.
217 * callproc.c (call_process):
218 * process.c (Fformat_network_address):
219 * sysdep.c (sys_subshell):
220 Use encode_current_directory rather than rolling our own.
221 (create_process): No need to encode directory; caller does that now.
222 * process.h (encode_current_directory): New decl.
223 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
224 Rework to avoid 'goto xyzzy;'.
226 2013-08-23 Eli Zaretskii <eliz@gnu.org>
228 * xdisp.c (handle_face_prop): If the default face was remapped use
229 the remapped face for strings from prefix properties. (Bug#15155)
231 2013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
233 Minor cleanup for redisplay interface and few related functions.
234 * frame.h (enum text_cursor_kinds): Move from here...
235 * dispextern.h (enum text_cursor_kinds): ...to here.
236 (toplevel): Drop unnecessary declarations.
237 (struct redisplay_interface): Use bool and enum text_cursor_kinds
238 in update_window_end_hook and draw_window_cursor functions.
239 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
240 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
241 * w32term.c (x_update_window_end,w32_draw_window_cursor):
242 * xterm.c (x_update_window_end, x_draw_window_cursor):
243 * xdisp.c (display_and_set_cursor, update_window_cursor)
244 (update_cursor_in_window_tree, x_update_cursor): Use bool and
245 enum text_cursor_kinds where appropriate.
247 2013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
249 Redesign redisplay interface to drop updated_row and updated_area.
250 * dispextern.h (updated_row, updated_area): Remove declaration.
251 (struct redisplay_interface): Pass glyph row and row area parameters
252 to write_glyphs, insert_glyphs and clear_end_of_line functions.
253 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
255 * dispnew.c (updated_row, updated_area): Remove.
256 (redraw_overlapped_rows, update_window_line): Adjust user.
257 (update_marginal_area, update_text_area): Likewise. Pass updated row
258 as a parameter. Prefer enum glyph_row_area to int where appropriate.
259 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
262 2013-08-22 Paul Eggert <eggert@cs.ucla.edu>
264 * process.c (flush_pending_output): Remove stub.
267 2013-08-21 Paul Eggert <eggert@cs.ucla.edu>
269 * callproc.c: Fix race that killed background processes (Bug#15144).
270 (call_process): New arg TEMPFILE_INDEX. Callers changed.
271 Record deleted process-id in critical section, not afterwards.
272 Don't mistakenly kill process created by a call-process invocation
273 that discards output and does not wait.
275 2013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
277 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
278 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
279 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
280 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
281 to shut up compiler in mark_object.
282 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
284 2013-08-21 Paul Eggert <eggert@cs.ucla.edu>
286 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
287 We can't portably rely on PTY_OPEN doing that, even if
288 it calls posix_openpt with O_CLOEXEC.
290 2013-08-20 Kenichi Handa <handa@gnu.org>
292 * character.c (string_char): Improve commentary.
294 2013-08-20 Paul Eggert <eggert@cs.ucla.edu>
296 * image.c (SIGNATURE_DIGESTSIZE): Remove.
297 (struct animation_cache): Make signature a flexible array member.
298 All uses changed. This is a tad slower but may insulate us better
299 from future changes to ImageMagick.
301 2013-08-19 Paul Eggert <eggert@cs.ucla.edu>
303 * image.c: Shrink memory needed for animation cache.
304 (SIGNATURE_DIGESTSIZE): New constant.
305 (struct animation_cache): Make 'signature' a fixed size array of bytes.
306 (imagemagick_create_cache): Copy the signature. This saves
307 several KB of memory that ImageMagick wastes per signature.
308 Don't bother updating the update_time, as the caller does that now.
309 (imagemagick_prune_animation_cache): Don't destroy the signature, as
310 it's a fixed size struct member now.
311 (imagemagick_get_animation_cache): Always destroy the signature,
312 as it's now imagemagick_create_cache's responsibility to copy it.
313 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
314 and use memcmp rather than strcmp.
315 eassert that ImageMagick returns a signature of the specified length.
317 2013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
319 * image.c (imagemagick_get_animation_cache): Don't segfault on
321 (imagemagick_get_animation_cache): Revert to previous definition
322 so that it actually works. But keep the memory leak fix.
323 (imagemagick_get_animation_cache): Fix memory leak.
325 2013-08-19 Paul Eggert <eggert@cs.ucla.edu>
327 * image.c: Fix animation cache signature memory leak.
328 Fix some other minor performance problems while we're at it.
329 (imagemagick_create_cache): Clear just the members that
330 need clearing. Don't set update_time, as caller does that now.
331 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
332 Simplify by using pointer-to-pointer instead of a prev pointer.
333 (imagemagick_prune_animation_cache): Use make_emacs_time rather
334 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
335 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
336 it's already a copy. Free the signature probe unless it's cached.
338 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
339 This was introduced by my 2013-08-12 fix for Bug#15035.
341 2013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
343 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
344 (imagemagick_prune_animation_cache): Now static.
346 2013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
348 * image.c (imagemagick_get_animation_cache): Don't segfault when
351 2013-08-18 Ken Brown <kbrown@cornell.edu>
353 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
354 static heap if ENABLE_CHECKING is defined.
355 (max_bss_sbrk_ptr): New variable.
357 (report_sheap_usage): Report maximum static heap usage instead of
358 ending static heap usage.
360 2013-08-17 Eli Zaretskii <eliz@gnu.org>
362 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
363 of zlib_initialized according to the results of calling
366 2013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
368 * image.c: Implement an ImageMagick per-image cache.
369 (imagemagick_get_animation_cache): Fix a double-free error.
370 (imagemagick_load_image): Remove the ping_wand code, which only
371 apparently saved time on invalid animated images, and slowed down
372 everything else. Optimise for the common case.
374 2013-08-16 Xue Fuqiao <xfq.free@gmail.com>
376 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
378 * editfns.c (insert_before_markers): Mention overlay in the doc string.
380 * marker.c (set_marker): Remove documentation of undefined behavior.
382 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
384 * image.c (imagemagick_compute_animated_image): Animate correctly
385 when sub-images are smaller than the main image.
386 (imagemagick_compute_animated_image): Setting the iterator row to
387 zero is apparently not allowed.
388 (imagemagick_compute_animated_image): Allow images that say they
389 have sub-images that are bigger than the main image, but just crop
392 2013-08-15 Jan Djärv <jan.h.d@swipnet.se>
394 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
396 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
398 * image.c (imagemagick_compute_animated_image): Respect the GIF
401 2013-08-15 Ken Brown <kbrown@cornell.edu>
403 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
404 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
407 2013-08-15 Paul Eggert <eggert@cs.ucla.edu>
409 Fix minor problems found by static checking.
410 * frame.c (delete_frame):
411 * xdisp.c (next_element_from_display_vector):
412 Avoid uninitialized local.
413 * image.c (imagemagick_compute_animated_image): Port to C89.
414 Prefer usual GNU indentation style for loops.
415 Be more careful about bizarrely large sizes, by using ptrdiff_t
418 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
420 Fix infinite frame selection loop (Bug#15025).
421 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
423 2013-08-15 Eli Zaretskii <eliz@gnu.org>
425 * xdisp.c (compute_window_start_on_continuation_line):
426 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
427 to make sure we end up setting the window start at the leftmost
428 visible character of the display line. This avoids funky
429 horizontal shifting because the window start is not kept on the
430 same position. (Bug#15090)
431 (next_element_from_display_vector): Support 'box' face attribute
432 in the face definitions of a display vector. (Bug#15099)
434 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
436 * image.c (imagemagick_compute_animated_image): Implement animated
438 (imagemagick_compute_animated_image): Fix some compilation
439 warnings. Implement a very simple cache to make the animation
440 usable at all, but it should be replaced with a per-image cache.
442 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
444 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
445 to do `for' loops over alist values.
446 * buffer.h (FOR_EACH_BUFFER):
447 * process.c (FOR_EACH_PROCESS): Use it.
448 (handle_child_signal, status_notify, Fget_buffer_process)
449 (kill_buffer_processes): Use FOR_EACH_PROCESS.
451 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
453 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
454 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
455 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
456 to xzalloc and so avoid redundant call to memset.
457 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
458 members because it is allocated with xzalloc and so already zeroed.
460 2013-08-14 Ken Brown <kbrown@cornell.edu>
462 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
465 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
467 Utility function and macro to copy Lisp string to C string.
468 * lisp.h (xlispstrdupa): New macro.
469 (xlispstrdup): New prototype.
470 * alloc.c (xlispstrdup): New function.
471 * callint.c (Fcall_interactively):
472 * fileio.c (Ffile_name_directory, Fexpand_file_name)
473 (Fsubstitute_in_file_name):
474 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
475 * image.c (x_create_bitmap_from_file):
476 * w32term.c (w32_term_init):
477 * xterm.c (x_term_init): Use xlispstrdup.
479 2013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
481 * image.c (imagemagick_load_image): Make animated pictures work.
482 There's still some problems with background color settings, though
485 * decompress.c (unwind_decompress): Always restore point.
487 2013-08-14 Xue Fuqiao <xfq.free@gmail.com>
489 * marker.c (set_marker): Reformat documentation.
491 2013-08-14 Paul Eggert <eggert@cs.ucla.edu>
493 * xdisp.c (cursor_type_changed): Now static.
495 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
496 Use changed. This avoids the need to call xmalloc and for the
497 caller to call xfree, and avoids memory leaks in some situations.
499 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
501 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
502 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
503 (redisplay_window): If window_end_valid is cleared due to non-zero
504 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
505 so do not call to try_cursor_movement for that window.
507 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
509 * window.h (struct window): Convert window_end_pos and
510 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
511 (wset_window_end_pos, wset_window_end_vpos): Remove.
512 * dispnew.c (adjust_glyph_matrix):
513 * window.c (Fwindow_end, replace_window, set_window_buffer)
515 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
516 (set_vertical_scroll_bar, redisplay_window, try_window)
517 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
518 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
519 (note_mouse_highlight): Adjust users.
520 (try_cursor_movement): Likewise. Convert old precondition to eassert.
523 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
525 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
526 * image.c (imagemagick_filename_hint): Use `const char *' and
527 prefer SSDATA to SDATA to avoid warnings.
529 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
531 Cleanup window fringes, margins and scroll bars adjustments.
532 * window.c (set_window_fringes, set_window_margins)
533 (set_window_scroll_bars, apply_window_adjustment): New functions.
534 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
535 (Fset_window_scroll_bars): Use them.
537 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
539 * window.h (struct window): Convert scroll_bar_width
540 from Lisp_Object to integer. Adjust comment.
541 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
543 * window.c (wset_scroll_bar_width): Remove.
544 (make_window): Initialize scroll_bar_width.
545 (Fsplit_window_internal): Use direct assignment.
546 (Fset_window_configuration, save_window_save):
547 Convert Lisp_Object to integer and back where appropriate.
548 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
549 bar was actually changed, and mention this in docstring.
551 2013-08-13 Paul Eggert <eggert@cs.ucla.edu>
553 * decompress.c: Minor simplifications.
554 (Fzlib_decompress_region): Don't bother verifying
555 that avail_out <= UINT_MAX, as that was confusing.
556 Mention the restriction in a comment instead.
557 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
559 2013-08-13 Jan Djärv <jan.h.d@swipnet.se>
561 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
562 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
564 2013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
566 * image.c (imagemagick_filename_hint): Check for errors in the
569 2013-08-13 Eli Zaretskii <eliz@gnu.org>
571 * window.c (Fwindow_margins): Return nil when there's no marginal
572 area, as per the documented API.
574 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
575 Fmake_vector, as scroll bar's struct members are not all Lisp
576 objects now. This avoids crashes in GC.
578 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
579 bool, so its address could be taken.
581 2013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
583 * image.c (imagemagick_filename_hint): New function to possibly
584 apply `image-content-type-suffixes'.
585 (imagemagick_load_image): Use it.
587 2013-08-13 Eli Zaretskii <eliz@gnu.org>
589 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
590 if loading zlib failed.
592 2013-08-13 Jan Djärv <jan.h.d@swipnet.se>
594 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
595 2013-08-13 checkin below. Change bool to BOOL, rule is:
596 All Obj-C code uses BOOL, except for interfaces callable from C.
598 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
600 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
602 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
603 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
604 bool instead of BOOL.
605 * w32term.h (struct scroll_bar): Convert fringe_extended_p
606 from Lisp_Object to bitfield. Adjust comment.
607 * w32term.c (x_scroll_bar_create): Adjust user.
608 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
609 * xterm.c (XTset_vertical_scroll_bar): Likewise.
610 Use bool for boolean.
611 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
612 to `unsigned int' when defining a bitfield.
614 2013-08-13 Paul Eggert <eggert@cs.ucla.edu>
616 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
618 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
620 * window.h (struct window): Convert left_margin_cols and
621 right_margin_cols from Lisp_Objects to integers. Adjust comment.
622 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
623 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
625 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
627 (showing_window_margins_p, update_window_line, update_frame_1):
628 * fringe.c (draw_fringe_bitmap_1):
629 * xdisp.c (window_box_width): Adjust users.
630 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
631 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
632 Use direct assignment.
633 (Fset_window_configuration, save_window_save, Fwindow_margins):
634 Convert Lisp_Object to integer and back where appropriate.
635 (Fset_window_margins): Adjust user. Return t if any margin
636 was actually changed, and mention this in docstring.
638 2013-08-13 Xue Fuqiao <xfq.free@gmail.com>
640 * syntax.c (forward_word):
641 * cmds.c (forward_char, backward_char): Mention the optional argument.
643 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
645 * window.h (struct window): Convert left_fringe_width
646 and right_fringe_width from Lisp_Objects to integers.
648 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
649 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
650 * window.c (wset_left_fringe_width, wset_right_fringe_width):
652 (make_window): Initialize new integer fields to -1.
653 (Fsplit_window_internal): Use direct assignment.
654 (Fset_window_configuration, save_window_save):
655 Convert Lisp_Object to integer and back where appropriate.
656 (Fset_window_fringes): Adjust user. Return t if any fringe
657 was actually changed, and mention this in docstring.
659 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
661 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
662 * nsfns.m (x_set_cursor_type):
663 * w32fns.c (x_set_cursor_type):
664 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
665 * xdisp.c (set_frame_cursor_types): ...but in common code.
667 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
669 * font.c (clear_font_cache): New function, stripped from...
670 (Fclear_font_cache): ...here, which now uses the function
671 above. Adjust comment.
672 * font.h (clear_font_cache): Add prototype.
673 * xfaces.c (clear_face_cache): Use clear_font_cache.
675 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
677 * window.c (Fset_window_start): Compare `w', not `window' because
678 `w' might not be equal to `window' after call to decode_live_window.
680 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
682 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
683 This fixes a problem introduced by the Bug#15035 patch
684 when using GPG. Reported by Herbert J. Skuhra.
686 2013-08-12 Eli Zaretskii <eliz@gnu.org>
688 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
689 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
692 2013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
694 * decompress.c (Fzlib_decompress_region): Support zlib
695 decompression, too, and rename.
697 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
699 Minor zlib configuration tweaks.
700 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
701 Don't assume presence of fn_inflateInit2_ zlib internal function.
703 2013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
705 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
706 include the zlib prefix.
708 2013-08-12 Eli Zaretskii <eliz@gnu.org>
710 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
711 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
712 define static variables that are pointers to zlib functions to be
714 (init_zlib_functions) [WINDOWSNT]: New function.
715 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
717 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
718 macros instead of invoking the zlib functions directly.
719 (syms_of_decompress): DEFSYM Qzlib_dll.
720 Staticpro Szlib_available_p.
722 2013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
724 Avoid looping over all frame windows to freeze and unfreeze.
725 * window.h (struct window): Drop frozen_window_start_p.
726 (freeze_window_starts): Drop prototype.
727 * frame.h (struct frame): New frozen_window_starts flag.
728 (FRAME_WINDOWS_FROZEN): New macro.
729 * window.c (freeze_window_start, freeze_window_starts):
731 (select_window, replace_window): Adjust users.
732 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
733 (window_frozen_p): New function.
734 (redisplay_window): Use it.
736 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
738 Fix some fd issues when running subprocesses (Bug#15035).
739 Fix bugs that can leak files or file descriptors on errors.
740 Don't unlink open temp files, as that's hard for users to diagnose
741 when things go awry (e.g., temp disk exhausted).
742 Don't bother to lock temp files. Check for invalid recursion.
743 * callproc.c (synch_process_fd): Remove. All uses removed.
744 (synch_process_tempfile): New var or macro.
745 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
747 (record_kill_process): New arg, the temp name. All callers changed.
748 (delete_temp_file): Now just a simple wrapper around unlink.
749 (call_process_kill): New arg, the call_process_fd array.
750 Close them all. Clear synch_process_pid. Remove the temp file,
751 or arrange for it to be removed.
752 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
753 that's been moved to synch_process_tempfile. Caller changed.
754 Do not remove the tempfile; that's now call_process_kill's
756 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
757 call_process_kill; the caller now does that.
758 (call_process_cleanup): Do not close the process fd; that's now
759 call_process_kill's responsibility.
760 (Fcall_process): Implement via new function call_process, which
761 has most of the old body of Fcall_process, but with a different API.
762 (call_process): New function that does not open or close filefd if
763 it is nonnegative. Record which fds need to be closed, and let
764 call_process_kill close (and remove the tempfile, on MSDOS) on error.
765 Signal an error if invoked recursively (could be done via a hook).
766 Simplify creation of the tempfile in the MSDOS case.
767 Don't create the output file until after checking for the executable.
768 Report any failure to open /dev/null.
769 Don't open /dev/null for writing twice; once is enough.
770 Don't create pipe if all output is being discarded or sent to file.
771 Don't worry about setting up the coding system or reading from the
772 pipe if all output is being discarded.
773 Hoist fd_error local into top level, to lessen block nesting.
774 Don't record deleted pid here; now done by Fcall_process_region.
775 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
776 and note its success in synch_process_tempfile.
777 Do not leak resources when child_setup fails.
778 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
779 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
780 (create_temp_file): Now returns open fd, with an additional
781 Lisp_Object * argument to return the name. All callers changed.
782 Do not close the file; rewind it instead, and leave it open for
783 the caller. Do not lock the temp file. Unwind-protect the file
784 and the file-descriptor.
785 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
786 If an asynchrounous process, record it here, not in call_process.
787 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
788 * eval.c (set_unwind_protect): New function.
789 * fileio.c (write_region): New function, generalized from the
790 old Fwrite_region. Do not lock temp files.
791 (Fwrite_region): Use it.
792 * lisp.h (set_unwind_protect, write_region): New decls.
793 * process.c: Include <verify.h>.
794 (make_process): Mark fds as initially closed.
795 (deleted_pid_list): Now a list of pid-filename pairs.
797 (close_process_fd): New function.
798 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
799 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
800 New constants. Verify that their number matches PROCESS_OPEN_FDS.
801 (create_process, create_pty, Fmake_serial_process)
802 (server_accept_connection): Record which fds need to be closed,
803 and let deactivate_process close them.
804 (Fmake_network_process): Do not discard the unwind-protect
805 until it's safe to do so.
806 (deactivate_process): Close the fds opened by create_process etc.
807 (Fprocess_send_eof): Adjust to new way of recording open fds.
808 Report an error if /dev/null can't be opened, instead of aborting.
809 * process.h (PROCESS_OPEN_FDS): New constant.
810 (struct Lisp_Process): New member open_fds.
811 (record_kill_process, record_deleted_pid): Adjust signatures.
812 (record_deleted_pid): Move decl here ...
813 * syswait.h (record_deleted_pid): ... from here.
815 2013-08-11 Paul Eggert <eggert@cs.ucla.edu>
817 * decompress.c: Fix bugs with large buffers and weird inputs.
818 Tune a bit. Reindent as per usual Emacs style.
819 (BUFFER_SIZE): Remove.
820 (Fdecompress_gzipped_region): Do not mishandle input buffers with
821 more than UINT_MAX bytes. Decompress into the gap instead of into
822 an auto buffer, as this should avoid copying. Return nil if
823 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
824 set immediate_quit; we shouldn't trust zlib code that much.
826 2013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
828 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
829 errors, and really move the gap to where we want it.
831 * lisp.h: Include decompress.c support.
833 * emacs.c (main): Include decompress.c support.
835 * Makefile.in: Include -lz if present.
837 2013-08-11 Jan Djärv <jan.h.d@swipnet.se>
839 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
840 (initWithTitle:): Initialize frame to 0.
841 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
842 (fillWithWidgetValue:frame:): Rename from
843 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
845 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
846 fillWithWidgetValue:frame:
848 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
849 remove memory leak warnings.
851 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
852 (ns_check_menu_open): Handle menu == nil. Remove assignment to
855 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
856 (x_activate_menubar): Update the whole menu.
857 (trackingNotification:): Call ns_check_menu_open if tracking ends.
858 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
859 current event is not NSSystemDefined (Bug#15001).
860 Call ns_check_menu_open only if trackingMenu is 2.
861 (menuDidClose:): New method, decrease trackingMenu.
862 (fillWithWidgetValue:setDelegate:): New method.
863 (fillWithWidgetValue:): Call the above.
865 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
867 2013-08-11 Paul Eggert <eggert@cs.ucla.edu>
869 Omit some unnecessary casts.
870 Many of these go back to the old pre-C89 days, when they may have
871 been needed, but we've been assuming C89 or later for a while now.
872 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
873 (live_float_p, live_misc_p, live_vector_p):
874 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
875 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
877 * callint.c (Fcall_interactively):
878 * doc.c (Fsubstitute_command_keys):
879 * filelock.c (get_boot_time):
880 * frame.c (xrdb_get_resource):
881 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
882 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
883 (xg_get_file_name_from_selector, menuitem_destroy_callback)
884 (menuitem_highlight_callback, menu_destroy_callback)
885 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
886 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
887 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
888 (xg_tool_bar_help_callback, tb_size_cb):
889 * image.c (xpm_alloc_color, png_read_from_memory)
890 (png_read_from_file, png_load_body, our_memory_skip_input_data)
891 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
893 * keymap.c (describe_map):
894 * nsfns.m (Fns_display_monitor_attributes_list):
895 * nsmenu.m (process_dialog:):
896 * nsterm.m (hold_event):
897 * process.c (wait_reading_process_output):
898 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
899 * scroll.c (do_direct_scrolling, scrolling_1):
900 * termcap.c (tgetent):
901 * window.c (check_window_containing, add_window_to_list)
902 (freeze_window_starts):
903 * xdisp.c (compare_overlay_entries, vmessage):
904 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
905 (x_get_monitor_attributes_xrandr)
906 (Fx_display_monitor_attributes_list, x_display_info_for_name)
907 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
908 * xfont.c (xfont_match, xfont_open):
909 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
910 (menubar_selection_callback, menu_position_func)
911 (popup_selection_callback, create_and_show_popup_menu)
912 (dialog_selection_callback, create_and_show_dialog):
913 * xrdb.c (x_get_string_resource):
915 * xsmfns.c (x_session_check_input):
916 * xterm.c (x_draw_glyphless_glyph_string_foreground)
917 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
918 (xaw_jump_callback, xaw_scroll_callback):
919 Omit unnecessary casts.
921 2013-08-10 Paul Eggert <eggert@cs.ucla.edu>
923 Minor string-length refactoring.
924 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
925 * frame.c (make_monitor_attribute_list):
926 Prefer build_string to strlen + make_string.
928 2013-08-10 Jan Djärv <jan.h.d@swipnet.se>
930 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
931 don't check minor_code (Bug#14417).
933 2013-08-09 Eli Zaretskii <eliz@gnu.org>
935 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
936 vertical positions instead. This avoids calling MATRIX_ROW with
937 row numbers that are possibly beyond valid limits. (Bug#15064)
939 2013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
941 Use xstrdup and build_unibyte_string where applicable.
942 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
944 * xrdb.c (x_get_customization_string):
945 * xterm.c (xim_initialize):
946 * w32fns.c (w32_window): Use xstrdup.
947 (w32_display_monitor_attributes_list):
948 * emacs.c (init_cmdargs):
949 * keyboard.c (PUSH_C_STR):
950 * nsfont.m (nsfont_open):
951 * sysdep.c (system_process_attributes):
952 * w32.c (system_process_attributes):
953 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
955 2013-08-09 Eli Zaretskii <eliz@gnu.org>
957 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
958 variables of these types so that GDB would know about them, as aid
959 for debugging fatal exceptions. (Bug#15024) See also
960 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
963 2013-08-08 Jan Djärv <jan.h.d@swipnet.se>
965 * nsterm.m (ns_update_begin): Don't change clip path if it would be
966 larger than the NSWindow (Bug#14934).
968 2013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
970 Redesign redisplay interface to drop global variable updated_window.
971 Always pass currently updated window as a parameter to update routines.
972 * dispextern.h (updated_window): Remove declaration.
973 (struct redisplay_interface): Pass window parameter to
974 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
975 and after_update_window_hook.
976 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
978 * dispnew.c (updated_window): Remove.
979 (redraw_overlapped_rows, update_marginal_area, update_text_area)
980 (update_window_line): Adjust to match redisplay interface changes.
981 * nsterm.m (ns_update_window_begin, ns_update_window_end)
982 (ns_scroll_run, ns_after_update_window_line):
983 * w32term.c (x_update_window_begin, x_update_window_end)
984 (x_after_update_window_line, x_scroll_run):
985 * xterm.c (x_update_window_begin, x_update_window_end)
986 (x_after_update_window_line, x_scroll_run):
987 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
988 Likewise. Adjust comments where appropriate.
989 (x_cursor_to): Simplify because this is always called during window
990 update (but install debugging check anyway).
991 (expose_window): Check must_be_updated_p flag to see whether this
992 function is called during window update.
994 2013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
996 Do not reset window modification event counters excessively.
997 These leftovers and poor man's tricky methods to catch extra
998 redisplay's attention are no longer needed.
999 * frame.c (set_menu_bar_lines_1):
1000 * minibuf.c (read_minibuf_unwind):
1001 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1002 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1003 (window_scroll_line_based, Fset_window_configuration):
1004 * xdisp.c (redisplay_window): Do not reset last_modified and
1005 last_overlay_modified counters.
1007 2013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1009 * xselect.c (x_send_client_event): Set send_event and serial, memset
1010 data.l as it might be bigger than data.b. Use 24 bit mask to
1011 XSendEvent (Bug#15034).
1013 2013-08-07 Eli Zaretskii <eliz@gnu.org>
1015 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1016 for TTY frames that are not the top frame on their console.
1019 2013-08-07 Martin Rudalics <rudalics@gmx.at>
1021 * w32term.c (w32fullscreen_hook): Really maximize frame when
1022 asked for (Bug#14841).
1024 2013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1026 Prefer selected_window to Fselected_window, likewise for frames.
1027 * buffer.c (Fbuffer_swap_text):
1028 * data.c (Fvariable_binding_locus):
1029 * window.c (run_window_configuration_change_hook): Adjust users.
1030 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1031 Use decode_live_frame.
1033 2013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1035 Be more careful if selected window shows the buffer other than current,
1036 use window_outdated only if this is not so. This change should also
1037 address some weird issues discussed in Bug#13012.
1038 * window.h (window_outdated): New prototype.
1039 * window.c (window_outdated): Now here. Convert from static and
1040 always assume window's buffer.
1041 (Fwindow_end, Fwindow_line_height): Use it.
1042 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1043 and always assume window's buffer.
1044 (redisplay_window): Adjust user.
1045 (redisplay_internal): Call to reconsider_clip_changes once and
1046 check whether mode line should be updated only if selected window
1047 shows current buffer.
1048 (run_window_scroll_functions): Use eassert for debugging check.
1049 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1051 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1053 * window.c (window_scroll, window_scroll_pixel_based)
1054 (window_scroll_line_based): Use bool for booleans.
1056 2013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1058 * process.c: Fix minor off-by-one issues in descriptor counts.
1059 This shouldn't fix any real bugs, but it cleans up the code a bit.
1060 (max_process_desc, max_input_desc): -1, not 0, means none.
1062 (delete_input_desc): New function.
1063 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1064 (deactivate_process): Scan backwards when recomuting max_process_desc;
1065 that should be faster.
1066 (init_process_emacs): Initialize max_input_desc.
1068 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1070 Use region cache to speedup bidi_find_paragraph_start.
1071 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1072 Rename cache_long_line_scans to cache_long_scans.
1073 * buffer.c (bset_cache_long_line_scans): Rename to
1074 bset_cache_long_scans.
1075 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1076 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1078 (syms_of_buffer): Rename cache-long-line-scans to
1079 cache-long-scans. Adjust docstring.
1080 * search.c (newline_cache_on_off):
1081 * indent.c (width_run_cache_on_off): Adjust users.
1082 * bidi.c (bidi_paragraph_cache_on_off): New function.
1083 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
1084 * insdel.c (prepare_to_modify_buffer):
1085 Invalidate bidi_paragraph_cache if enabled.
1087 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1089 Invalidate region caches only if buffer text is going to be changed.
1090 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1091 (modify_text): ...new prototype.
1092 (prepare_to_modify_buffer_1): New prototype.
1093 * textprop.c (modify_region): Rename to...
1094 (modify_text_properties): ...new function.
1095 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1096 (Fremove_list_of_text_properties): Adjust users.
1097 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1098 (modify_text): ...new function.
1099 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1100 (prepare_to_modify_buffer_1): ...new function.
1101 * casefiddle.c (casify_region):
1102 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1103 (Ftranspose_regions): Use modify_text.
1105 2013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1107 * lisp.mk (lisp): Add nadvice.elc.
1109 2013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1111 New macro to iterate over live buffers similar to frames.
1112 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1113 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1114 Declare buffer-related variables here to offload lisp.h.
1115 * buffer.c (Vbuffer_alist): Adjust comment.
1116 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1117 (other_buffer_safely):
1118 * data.c (store_symval_forwarding):
1119 * dispnew.c (Fframe_or_buffer_changed_p):
1120 * fileio.c (Fdo_auto_save):
1121 * filelock.c (unlock_all_files):
1122 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1124 2013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1126 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1127 * callproc.c (create_temp_file):
1128 * filelock.c (create_lock_file):
1129 Assume mkostemp, since it's now provided by Gnulib.
1131 2013-08-04 Eli Zaretskii <eliz@gnu.org>
1133 * w32.c (mkostemp): New function.
1134 (mktemp): Remove, no longer used. Most of the code reused in
1135 mkostemp. (Bug#15015)
1136 (mktemp): Don't undef.
1138 2013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1140 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1141 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1142 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1143 (free_glyph_pool, check_glyph_memory): Likewise for
1144 all users. Adjust comments where appropriate.
1146 2013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1148 * composite.h: Minor fixups.
1149 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1150 to fix a misspelling, and change it to an inline function while
1151 we're at it (it need not be a macro). All uses changed.
1152 (composition_method, composition_valid_p):
1153 Rewrite to avoid assignments in if-conditions.
1155 2013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1157 Do not use global Lisp_Object in composition macros.
1158 * composite.h (composition_temp): Remove declaration.
1159 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1160 (composition_method, composition_valid_p): ...inline functions.
1161 (compose_region): Remove the leftover.
1162 * composite.c (composition_temp): Remove.
1163 (run_composition_function, update_compositions)
1164 (composition_compute_stop_pos, composition_adjust_point)
1165 (Ffind_composition_internal):
1166 * coding.c (handle_composition_annotation):
1167 * xdisp.c (handle_composition_prop, check_point_in_composition):
1168 Related users changed.
1170 2013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1172 Drop FRAME_PTR typedef.
1173 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1174 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1175 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1176 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1177 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1178 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1179 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1180 All related users changed.
1182 2013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1184 * eval.c (default_toplevel_binding): New function.
1186 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1187 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1188 (syms_of_eval): Export them.
1189 * data.c (Fdefault_value): Micro cleanup.
1190 * term.c (init_tty): Use "false".
1192 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1194 Fix X GC leak in GTK and raw (no toolkit) X ports.
1195 * xterm.c (x_free_frame_resources): If white and black relief
1196 GCs are allocated, always free them here.
1197 * xfns.c (x_make_gc): Omit redundant initialization.
1198 * widget.c (create_frame_gcs): Remove the leftover.
1199 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1200 in x_free_frame_resources.
1202 2013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1204 * nsterm.m (windowWillResize:toSize:): Only change title if
1205 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1207 (viewDidEndLiveResize): New method.
1209 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1210 inside NS_IMPL_COCOA.
1212 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1214 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1215 Do not check whether undo is enabled because record_insert and
1216 record_delete does that themselves.
1218 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1220 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1221 member which is not really used any more.
1222 (FRAME_XIC_BASE_FONTNAME): Remove.
1223 * xfns.c (xic_free_fontset): Adjust user.
1224 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1225 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1226 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1227 (xdialog_show): Use eassert for debugging check.
1228 * w32term.c (x_unfocus_frame): Remove unused dummy function.
1230 2013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1232 * fileio.c, fns.c (merge): Move extern decl from here ...
1233 * lisp.h (merge): ... to here.
1235 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1237 Fix last font-related change.
1238 * w32font.h (w32font_list_internal, w32font_match_internal):
1240 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1241 (uniscribe_list_family): Adjust to match font API change.
1242 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1243 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1245 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1247 * frame.h (FRAME_MOUSE_UPDATE):
1248 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1249 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1251 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1253 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1254 * font.h (struct font_driver): Change list, match, and list_family
1255 functions to accept struct frame * as first arg.
1256 * font.c (font_score, font_compare, font_sort_entities):
1258 (font_sort_entities, font_list_entities, font_select_entity):
1259 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1260 match font API change.
1261 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1262 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1263 * ftxfont.c (ftxfont_list, ftxfont_match):
1264 * xftfont.c (xftfont_list, xftfont_match):
1265 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1266 * w32font.c (w32font_list, w32font_match, w32font_list):
1267 (w32font_list_internal, w32_font_match_internal): Likewise.
1268 * xfaces.c (Fx_family_fonts): Adjust user.
1270 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1272 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1273 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1274 only if HAVE_X_WINDOWS is in use.
1275 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1276 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1277 * w32term.c (x_wm_set_icon_position): Likewise.
1278 * w32fns.c (x_icon): Adjust user.
1280 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1282 * xterm.c (last_mouse_press_frame): Remove the
1283 leftover which is not really used any more.
1284 (handle_one_xevent, syms_of_xterm): Adjust users.
1285 (x_flush): Call XFlush once per each X display, not frame.
1286 This is better because this code always unconditionally skips
1287 non-X frames in Vframe_list and issues the only XFlush if we
1288 have more than one X frame on the same X display.
1289 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1290 Use bool for booleans.
1291 (x_draw_glyph_string_background, cvt_string_to_pixel):
1292 (cvt_pixel_dtor): Drop unnecessary prototypes.
1293 * xterm.h (x_display_ok): Adjust prototype.
1295 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1297 Drop unnecessary functions that deals with frame pixel size.
1298 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1299 (x_pixel_height): Drop prototypes.
1300 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1301 (x_pixel_height): Drop implementations.
1302 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1303 which should be always valid for window frame.
1304 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1305 * w32menu.c (Fx_popup_dialog):
1306 * xmenu.c (Fx_popup_dialog): Likewise for both.
1308 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1310 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1311 frame parameters and call to Fmodify_frame_parameters just once.
1312 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1313 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1314 and mention nil frame in docstring.
1316 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1318 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1319 (x_figure_window_size): Likewise. Adjust to return long.
1320 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1321 (toplevel): Move Qterminal_live_p to...
1322 * terminal.c (toplevel): ...here, make it static, and...
1323 (syms_of_terminal): ...DEFSYM here.
1324 * frame.h (Qterminal_live_p): Remove declaration.
1325 (make_frame, x_figure_window_size): Adjust prototype.
1326 * nsfns.m (Fx_create_frame): Use long for window flags.
1328 2013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1330 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1331 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1332 Do not assume that emacs_close (INT_MAX) is a no-op.
1334 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1336 * xfaces.c (make_face_cache): For struct face_cache, prefer
1337 xmalloc to xzalloc and so avoid redundant call to memset.
1338 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1340 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1342 * fringe.c (draw_window_fringes, update_window_fringes)
1343 (compute_fringe_widths):
1344 * w32term.c (x_draw_glyph_string):
1345 * window.c (candidate_window_p, Frecenter):
1346 * xfaces.c (realize_basic_faces, realize_default_face)
1347 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1348 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1349 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1350 * xmenu.c (Fx_menu_bar_open_internal):
1351 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1352 * xsettings.c (xft_settings_event):
1353 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1354 Use bool for booleans. Adjust style and comments where
1356 * dispextern.h (draw_window_fringes, update_window_fringes)
1357 (compute_fringe_widths):
1358 * xterm.h (x_had_errors_p): Adjust prototype.
1360 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1362 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1363 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1365 2013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1367 * fns.c (toplevel): Remove comment before Fsafe_length because
1370 2013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1372 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1374 2013-07-28 Eli Zaretskii <eliz@gnu.org>
1376 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1377 frame which got the message is still alive, before dereferencing
1378 its pointer. (Bug#14970)
1380 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1381 be a live window, before using it as such. (Bug#14970)
1383 2013-07-27 Eli Zaretskii <eliz@gnu.org>
1385 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1386 w32_detect_focus_change instead of doing part of its job by hand.
1387 This fixes the problem whereby FOCUS_OUT events were not sent to
1390 2013-07-26 Eli Zaretskii <eliz@gnu.org>
1392 * process.c (Fprocess_list): Doc fix.
1394 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1395 being re-exposed only if it didn't ask to become visible.
1396 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1397 was previously iconified. (Bug#14841)
1398 (x_iconify_frame): Mark the frame iconified.
1400 2013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1402 Fix minor problems found by static checking.
1403 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1404 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1406 2013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1408 * eval.c (set_specpdl_old_value): New function.
1409 (unbind_to): Minor simplification.
1410 (get_backtrace_frame): New function.
1411 (Fbacktrace_frame): Use it. Add `base' argument.
1412 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1413 (syms_of_eval): Export backtrace-eval.
1414 * xterm.c (x_focus_changed): Simplify.
1416 2013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1418 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1420 2013-07-24 Eli Zaretskii <eliz@gnu.org>
1422 * xdisp.c (redisplay_window): Instead of moving point out of
1423 scroll margin, reject the force_start method, and try scrolling
1424 instead. (Bug#14780)
1426 2013-07-24 Ken Brown <kbrown@cornell.edu>
1428 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1431 2013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1433 * eval.c (Fprogn): Do not check that BODY is a proper list.
1434 This undoes the previous change. The check slows down the
1435 interpreter, and is not needed to prevent a crash. See
1436 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1438 2013-07-23 Glenn Morris <rgm@gnu.org>
1440 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1442 2013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1444 Port to GNU/Linux systems with tinfo but not ncurses.
1445 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1446 to decide whether ncurses is being used. Without this change,
1447 GCC complains about tgetent not being declared, on a system
1448 that has tinfo installed but ncurses not installed.
1450 * eval.c (Fprogn): Check that BODY is a proper list.
1452 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1453 * data.c (Fsetq_default):
1454 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1455 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1457 Tune by taking advantage of the fact that ARGS is always a list
1458 when a function is declared to have UNEVALLED args.
1460 * emacsgtkfixed.c: Port to GCC 4.6.
1461 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1463 2013-07-23 Juanma Barranquero <lekktu@gmail.com>
1465 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1466 here to silence compiler warnings.
1468 2013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1470 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1471 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1472 from messing up Emacs's 'struct frame' (Bug#14923).
1474 2013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1476 * alloc.c (make_save_ptr_ptr): Define this function.
1477 It was inadvertently omitted. It's needed only if
1478 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1480 2013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1482 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1483 frame have focus (Bug#14895).
1485 2013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1487 Avoid vfork-related deadlock more cleanly.
1488 * callproc.c (child_setup): When the child's exec fails, output
1489 the program name, as that's more useful. Use O_NONBLOCK to avoid
1491 * process.c (create_process_1): Remove; no longer needed.
1492 (create_process): Remove timer hack; no longer needed, now that
1493 the child avoids deadlock.
1495 2013-07-20 Glenn Morris <rgm@gnu.org>
1497 * image.c (Fimage_flush): Fix doc typo.
1499 2013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1501 Fix array bounds violation when pty allocation fails.
1502 * process.c (PTY_NAME_SIZE): New constant.
1503 (pty_name): Remove static variable; it's now auto.
1504 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1505 Take pty_name as an arg rather than using a static variable.
1506 All callers changed.
1507 (create_process): Recover pty_flag from process, not from volatile local.
1508 (create_pty): Stay inside array even when pty allocation fails.
1509 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1511 * lread.c (Fload): Avoid initialization only when lint checking.
1512 Mention that it's needed only for older GCCs.
1514 2013-07-20 Kenichi Handa <handa@gnu.org>
1516 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1517 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1519 2013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1521 * lread.c (Fload): Avoid uninitialized warning.
1523 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1525 Fix some minor file descriptor leaks and related glitches.
1526 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1527 (create_lock_file): Use write, not emacs_write.
1528 * image.c (slurp_file, png_load_body):
1529 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1530 (server_accept_connection):
1531 Don't leak an fd on memory allocation failure.
1532 * image.c (slurp_file): Add a cheap heuristic for growing files.
1533 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1534 as that's what the other routines do. Maybe input need not be
1535 blocked at all, but it's better to be consistent.
1536 Avoid undefined behavior when strlen is zero.
1538 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1539 (NSTATICS): Now a constant; doesn't need to be a macro.
1541 2013-07-19 Richard Stallman <rms@gnu.org>
1543 * coding.c (decode_coding_utf_8): Add simple loop for fast
1544 processing of ASCII characters.
1546 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1548 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1550 2013-07-19 Eli Zaretskii <eliz@gnu.org>
1552 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1553 unportable 'struct x_display_info'.
1554 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1557 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1559 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1560 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1562 (system_process_attributes): Prefer plain char to unsigned char
1563 when either will do. Clean up properly if interrupted or if
1564 memory allocations fail. Don't assume sscanf succeeds.
1565 Remove no-longer-needed workaround to stop GCC from whining.
1566 Read command-line once, instead of multiple times. Check read status a
1569 Fix obscure porting bug with varargs functions.
1570 The code assumed that int is treated like ptrdiff_t in a vararg
1571 function, which is not a portable assumption. There was a similar
1572 -- though these days less likely -- porting problem with various
1573 assumptions that pointers of different types all smell the same as
1574 far as vararg functions is conserved. To make this problem less
1575 likely in the future, redo the API to use varargs functions.
1576 * alloc.c (make_save_value): Remove this vararg function.
1577 All uses changed to ...
1578 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1579 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1581 (make_save_ptr): Rename from make_save_pointer, for consistency with
1582 the above. Define only on platforms that need it. All uses changed.
1584 2013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1586 * keyboard.c: Try to fix typos in previous change.
1587 (DISPLAY_LIST_INFO): New macro.
1588 (kbd_buffer_get_event): Do not access members that are not present
1589 in X11. Revert inadvertent change of "!=" to "=".
1591 2013-07-18 Juanma Barranquero <lekktu@gmail.com>
1593 * keyboard.c (kbd_buffer_get_event):
1594 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1595 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1597 2013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1599 * filelock.c: Fix unlikely file descriptor leaks.
1600 (get_boot_time_1): Rework to avoid using emacs_open.
1601 This doesn't actually fix a leak, but is better anyway.
1602 (read_lock_data): Use read, not emacs_read.
1604 * doc.c: Fix minor memory and file descriptor leaks.
1605 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1606 (get_doc_string, Fsnarf_documentation):
1607 Fix file descriptor leak on error.
1609 * term.c: Fix minor fdopen-related file descriptor leaks.
1610 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1611 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1613 * charset.c: Fix file descriptor leaks and errno issues.
1615 (load_charset_map_from_file): Don't leak file descriptor on error.
1616 Use plain record_xmalloc since the allocation is larger than
1617 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1619 * eval.c (record_unwind_protect_nothing):
1620 * fileio.c (fclose_unwind):
1622 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1623 The replacement doesn't block input, but that no longer seems
1626 2013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1628 * lread.c: Fix file descriptor leaks and errno issues.
1629 (Fload): Close some races that leaked fds or streams when 'load'
1631 (Fload, openp): Report error number of last nontrivial failure to open.
1632 ENOENT counts as trivial.
1633 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1635 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1636 now that the function is always called with a nonnegative arg.
1637 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1638 All uses replaced with ...
1639 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1641 A few more minor file errno-reporting bugs.
1642 * callproc.c (Fcall_process):
1643 * doc.c (Fsnarf_documentation):
1644 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1645 * process.c (set_socket_option):
1646 Don't let a constructor trash errno.
1647 * doc.c: Include <errno.h>.
1649 2013-07-16 Juanma Barranquero <lekktu@gmail.com>
1651 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1653 2013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1655 Fix w32 bug with call-process-region (Bug#14885).
1656 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1657 to Fcall_process when the input is empty. This simplifies the
1658 code a bit. It makes no difference on POSIXish platforms but
1659 apparently it fixes a bug on w32.
1661 Fix bug where insert-file-contents closes a file twice (Bug#14839).
1662 * fileio.c (close_file_unwind): Don't close if FD is negative;
1663 this can happen when unwinding a zapped file descriptor.
1664 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1665 in case Emacs runs out of memory between the two unwind-protects.
1666 Don't trash errno when closing FD.
1667 Zap the FD in the specpdl when closing it, instead of deferring
1668 the removal of the unwind-protect; this fixes a bug where a child
1669 function unwinds the stack past us.
1671 New unwind-protect flavors to better type-check C callbacks.
1672 This also lessens the need to write wrappers for callbacks,
1673 and the need for make_save_pointer.
1674 * alloca.c (free_save_value):
1675 * atimer.c (run_all_atimers):
1677 * alloc.c (safe_alloca_unwind):
1678 * atimer.c (unwind_stop_other_atimers):
1679 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1680 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1681 * minibuf.c (choose_minibuf_frame_1):
1682 * process.c (make_serial_process_unwind):
1683 * xdisp.h (pop_message_unwind):
1684 * xselect.c (queue_selection_requests_unwind):
1685 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1686 * alloca.c (record_xmalloc):
1687 Prefer record_unwind_protect_ptr to record_unwind_protect with
1689 * alloca.c (Fgarbage_collect):
1690 Prefer record_unwind_protect_void to passing a dummy.
1691 * buffer.c (restore_buffer):
1692 * window.c (restore_window_configuration):
1693 * xfns.c, w32fns.c (do_unwind_create_frame)
1694 New wrapper. All record-unwind uses of wrappee changed.
1695 * buffer.c (set_buffer_if_live):
1696 * callproc.c (call_process_cleanup, delete_temp_file):
1697 * coding.c (code_conversion_restore):
1698 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1699 * editfns.c (save_excursion_restore)
1700 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1701 (save_restriction_restore):
1702 * eval.c (restore_stack_limits, un_autoload):
1703 * fns.c (require_unwind):
1704 * keyboard.c (recursive_edit_unwind, tracking_off):
1705 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1706 * macros.c (pop_kbd_macro, restore_menu_items):
1707 * nsfns.m (unwind_create_frame):
1708 * print.c (print_unwind):
1709 * process.c (start_process_unwind):
1710 * search.c (unwind_set_match_data):
1711 * window.c (select_window_norecord, select_frame_norecord):
1712 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1713 (fast_set_selected_frame):
1714 * xfns.c, w32fns.c (unwind_create_tip_frame):
1715 Return void, not a dummy Lisp_Object. All uses changed.
1716 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1717 * callproc.c (call_process_kill):
1718 * fileio.c (restore_point_unwind, decide_coding_unwind)
1719 (build_annotations_unwind):
1720 * insdel.c (Fcombine_after_change_execute_1):
1721 * keyboard.c (read_char_help_form_unwind):
1722 * menu.c (unuse_menu_items):
1723 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1724 * sound.c (sound_cleanup):
1725 * xdisp.c (unwind_redisplay):
1726 * xfns.c (clean_up_dialog):
1727 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1728 Accept no args and return void, instead of accepting and returning
1729 a dummy Lisp_Object. All uses changed.
1730 * cygw32.c (fchdir_unwind):
1731 * fileio.c (close_file_unwind):
1732 * keyboard.c (restore_kboard_configuration):
1733 * lread.c (readevalllop_1):
1734 * process.c (wait_reading_process_output_unwind):
1735 Accept int and return void, rather than accepting an Emacs integer
1736 and returning a dummy object. In some cases this fixes an
1737 unlikely bug when the corresponding int is outside Emacs integer
1738 range. All uses changed.
1739 * dired.c (directory_files_internal_unwind):
1740 * fileio.c (do_auto_save_unwind):
1741 * gtkutil.c (pop_down_dialog):
1742 * insdel.c (reset_var_on_error):
1743 * lread.c (load_unwind):
1744 * xfns.c (clean_up_file_dialog):
1745 * xmenu.c, nsmenu.m (pop_down_menu):
1746 * xmenu.c (cleanup_widget_value_tree):
1747 * xselect.c (wait_for_property_change_unwind):
1748 Accept pointer and return void, rather than accepting an Emacs
1749 save value encapsulating the pointer and returning a dummy object.
1751 * editfns.c (Fformat): Update the saved pointer directly via
1752 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1753 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1754 (unwind_body): New function.
1755 (record_unwind_protect): First arg is now a function returning void,
1756 not a dummy Lisp_Object.
1757 (record_unwind_protect_ptr, record_unwind_protect_int)
1758 (record_unwind_protect_void): New functions.
1759 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1760 * fileio.c (struct auto_save_unwind): New type.
1761 (do_auto_save_unwind): Use it.
1762 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1763 * insdel.c (struct rvoe_arg): New type.
1764 (reset_var_on_error): Use it.
1765 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1767 (specbinding_func): Remove; there are now several such functions.
1768 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1769 (set_unwind_protect_ptr): New function.
1770 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1772 Be simpler and more consistent about reporting I/O errors.
1773 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1774 Say "Read error" and "Write error", rather than "I/O error", or
1775 "IO error reading", or "IO error writing", when a read or write
1777 * process.c (Fmake_network_process, wait_reading_process_output)
1778 (send_process, Fprocess_send_eof, wait_reading_process_output):
1779 Capitalize diagnostics consistently. Put "failed foo" at the
1780 start of the diagnostic, so that we don't capitalize the
1781 function name "foo". Consistently say "failed" for such
1783 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1784 All callers changed. This is so it can use report_file_error.
1785 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1786 diagnostics consistently as above.
1788 * fileio.c (report_file_errno): Fix errno reporting bug.
1789 If the file name is neither null nor a pair, package it up as a
1790 singleton list. All callers changed, both to this function and to
1791 report_file_error. This fixes a bug where the memory allocator
1792 invoked by list1 set errno so that the immediately following
1793 report_file_error reported the wrong errno value.
1795 Fix minor problems found by --enable-gcc-warnings.
1796 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1797 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1799 2013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1801 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1802 Set event->arg to Qt if switch-event shall be generated.
1803 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1805 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1807 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1810 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1811 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1812 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1813 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
1814 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
1815 and there is a focused frame.
1816 (head_table): Add focus-in and focus-out.
1817 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1818 bind to handle-focus-in/out.
1820 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1821 (Fhandle_switch_frame): Call Fhandle_focus_in.
1822 (syms_of_frame): defsubr handle-focus-in/out.
1824 2013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1826 Fix porting bug to older POSIXish platforms (Bug#14862).
1827 * sysdep.c (emacs_pipe): New function, that implements
1828 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1829 This should port better to CentOS 5 and to Mac OS X 10.6.
1830 All calls to pipe2 changed.
1832 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1833 This makes the code easier to read and the executable a bit smaller.
1834 Do not replace all calls to Fcons that happen to create lists,
1835 just calls that are intended to create lists. For example, when
1836 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1837 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1838 Similarly for list2 through list5.
1839 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1840 * bytecode.c (exec_byte_code):
1841 * callint.c (quotify_arg, Fcall_interactively):
1842 * callproc.c (Fcall_process, create_temp_file):
1843 * charset.c (load_charset_map_from_file)
1844 (Fdefine_charset_internal, init_charset):
1845 * coding.c (get_translation_table, detect_coding_system)
1846 (Fcheck_coding_systems_region)
1847 (Fset_terminal_coding_system_internal)
1848 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1849 * composite.c (update_compositions, Ffind_composition_internal):
1850 * dired.c (directory_files_internal, file_name_completion)
1852 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1853 * doc.c (Fsnarf_documentation):
1854 * editfns.c (Fmessage_box):
1856 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1857 (Feval, eval_sub, Ffuncall, apply_lambda):
1858 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1859 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1860 (Fset_file_times, Finsert_file_contents)
1861 (Fchoose_write_coding_system, Fwrite_region):
1862 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1863 * font.c (font_registry_charsets, font_parse_fcname)
1864 (font_prepare_cache, font_update_drivers, Flist_fonts):
1865 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1866 * frame.c (make_frame, Fmake_terminal_frame)
1867 (x_set_frame_parameters, x_report_frame_params)
1868 (x_default_parameter, Fx_parse_geometry):
1869 * ftfont.c (syms_of_ftfont):
1870 * image.c (gif_load):
1871 * keyboard.c (command_loop_1):
1872 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1873 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1874 (Fminor_mode_key_binding, accessible_keymaps_1)
1875 (Faccessible_keymaps, Fwhere_is_internal):
1876 * lread.c (read_emacs_mule_char):
1877 * menu.c (find_and_return_menu_selection):
1878 * minibuf.c (get_minibuffer):
1879 * nsfns.m (Fns_perform_service):
1880 * nsfont.m (ns_script_to_charset):
1881 * nsmenu.m (ns_popup_dialog):
1882 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1883 (Fx_own_selection_internal):
1884 * nsterm.m (append2):
1885 * print.c (Fredirect_debugging_output)
1886 (print_prune_string_charset):
1887 * process.c (Fdelete_process, Fprocess_contact)
1888 (Fformat_network_address, set_socket_option)
1889 (read_and_dispose_of_process_output, write_queue_push)
1890 (send_process, exec_sentinel):
1891 * sound.c (Fplay_sound_internal):
1892 * textprop.c (validate_plist, add_properties)
1893 (Fput_text_property, Fadd_face_text_property)
1894 (copy_text_properties, text_property_list, syms_of_textprop):
1895 * unexaix.c (report_error):
1896 * unexcoff.c (report_error):
1897 * unexsol.c (unexec):
1898 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1899 (Fformat_mode_line, syms_of_xdisp):
1900 * xfaces.c (set_font_frame_param)
1901 (Finternal_lisp_face_attribute_values)
1902 (Finternal_merge_in_global_face, syms_of_xfaces):
1903 * xfns.c (x_default_scroll_bar_color_parameter)
1904 (x_default_font_parameter, x_create_tip_frame):
1905 * xfont.c (xfont_supported_scripts):
1906 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1907 (menu_help_callback, xmenu_show):
1909 * xterm.c (set_wm_state):
1910 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1911 and similarly for list2 through list5.
1913 2013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1915 * callproc.c (Fcall_process_region): Fix minor race and tune.
1916 (create_temp_file): New function, with the temp-file-creation part
1917 of the old Fcall_process_region. Use Fcopy_sequence to create the
1918 temp file name, rather than alloca + build_string, for simplicity.
1919 Don't bother to block input around the temp file creation;
1920 shouldn't be needed. Simplify use of mktemp.
1921 Use record_unwind_protect immediately after creating the temp file;
1922 this closes an unlikely race where the temp file was not removed.
1923 Use memcpy rather than an open-coded loop.
1924 (Fcall_process_region): Use the new function. If the input is
1925 empty, redirect from /dev/null rather than from a newly created
1926 empty temp file; this avoids unnecessary file system traffic.
1928 2013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1930 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1931 Simplify by making this case like the other two. This is a bit
1932 slower on obsolete hosts, but the extra complexity isn't worth it.
1934 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1935 * process.c (create_process) [!DOS_NT]:
1936 Remove now-unnecessary calls to emacs_close.
1938 2013-07-13 Eli Zaretskii <eliz@gnu.org>
1940 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1941 returning early. (Bug#14850)
1943 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1944 and inhibit-iso-escape-detection attributes of 'undecided'.
1947 2013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1949 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1950 Reported by Herbert J. Skuhra in
1951 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1953 Don't lose top specpdl entry when memory is exhausted.
1954 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1955 specpdl overflow here, to simplify callers; all callers changed.
1956 Always reserve an unused entry at the stack top; this avoids
1957 losing the top entry's information when memory is exhausted.
1959 2013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1961 Clean up errno reporting and fix some errno-reporting bugs.
1962 * callproc.c (Fcall_process):
1963 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1964 * process.c (create_process, Fmake_network_process):
1965 * unexaix.c (report_error):
1966 * unexcoff.c (report_error):
1967 Be more careful about reporting the errno of failed operations.
1968 The code previously reported the wrong errno sometimes.
1969 Also, prefer report_file_errno to setting errno + report_file_error.
1970 (Fcall_process): Look at openp return value rather than at path,
1971 as that's a bit faster and clearer when there's a numeric predicate.
1972 * fileio.c (report_file_errno): New function, with most of the
1973 old contents of report_file_error.
1974 (report_file_error): Use it.
1975 (Ffile_exists_p, Ffile_accessible_directory_p):
1976 Set errno to 0 when it is junk.
1977 * fileio.c (Faccess_file):
1978 * image.c (x_create_bitmap_from_file):
1979 Use faccessat rather than opening the file, to avoid the hassle of
1980 having a file descriptor open.
1981 * lisp.h (report_file_errno): New decl.
1982 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1985 * process.c (create_process, wait_reading_process_output) [AIX]:
1986 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1987 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1988 a multithreaded environment anyway).
1989 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1991 2013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1993 * image.c (x_find_image_file): Don't close a remote file handle.
1995 2013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1997 Fix races with threads and file descriptors.
1998 * callproc.c (Fcall_process_region):
1999 * dired.c (open_directory):
2000 * emacs.c (main, Fdaemon_initialized):
2001 * image.c (x_find_image_file):
2002 * inotify.c (Finotify_rm_watch):
2003 * lread.c (Flocate_file_internal):
2004 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2005 * term.c (term_mouse_moveto, init_tty):
2006 * termcap.c (tgetent):
2007 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2008 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2009 * unexhp9k800.c, unexmacosx.c (unexec):
2010 * callproc.c (Fcall_process_region):
2011 Use emacs_close, not close.
2012 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2013 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2014 and posix_close function on current platforms (which all lack them).
2015 (emacs_close): Use it. This should fix the races on GNU/Linux and
2016 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2017 and it should avoid closing random victim file descriptors on
2020 2013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2022 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2023 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2026 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2027 This is for .gdbinit xbacktrace.
2029 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2030 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2031 (emacs_set_tty): Now static.
2032 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2033 * term.c (tty_capable_p, tty_default_color_capabilities)
2034 (get_tty_terminal, term_mouse_movement)
2035 (handle_one_term_event, init_tty, maybe_fatal):
2036 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2037 (tgetent, scan_file, name_match, compare_contin):
2038 * terminal.c (get_terminal):
2039 Use bool for boolean.
2040 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2041 Prefer char to unsigned char if either will do.
2042 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2043 (tty_write_glyphs): Prefer int to unsigned.
2044 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2045 All callers changed.
2046 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2048 2013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2051 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2052 (B__dummy__): New dummy symbol, to pacify C89.
2053 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2054 they can't grok varargs macros.
2055 * dispnew.c (add_window_display_history)
2056 (add_frame_display_history):
2057 * print.c (print_object):
2058 * xdisp.c (debug_method_add):
2059 Use %p printf format only for void pointers.
2060 * emacs.c (usage_message): New constant, replacing ...
2061 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2062 (main): Adjust to usage reorg.
2063 * fns.c (syms_of_fns):
2064 * profiler.c (syms_of_profiler):
2065 Don't use non-constant struct initializers.
2066 * gnutls.h (gnutls_initstage_t):
2067 * lisp.h (enum Lisp_Fwd_Type):
2068 * lread.c (lisp_file_lexically_bound_p):
2069 * xsettings.c (anonymous enum):
2070 Remove trailing comma.
2071 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2072 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2073 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2075 * regex.c (const_re_char): New type, to pacify strict C89.
2076 All uses of 'const re_char' replaced to use it.
2077 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2078 with glibc when strict C89. This change is imported from gnulib.
2080 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2081 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2082 Omit GNU_LINUX implementation, since it requires long long.
2083 * xterm.c (x_draw_underwave):
2084 Do not assume the traditional order of struct's members.
2085 (x_term_init): Rewrite to avoid the need for non-constant structure
2088 Syntax cleanup, mostly replacing macros with functions.
2089 This removes the need for the syntax_temp hack.
2090 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2091 * syntax.c (SYNTAX_INLINE): New macro.
2092 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2093 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2094 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2095 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2096 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2097 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2098 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2099 Now constants, not macros.
2100 (syntax_temp) [!__GNUC__]: Remove.
2101 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2102 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2103 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2104 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2105 Move here from syntax.h; now functions, not macros. Except for the
2106 last function, these are static since only syntax.c uses them.
2107 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2108 All uses changed. Now a function, not a macro; use this fact
2109 to simplify the code.
2110 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2111 compiler bugs; no longer relevant.
2112 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2113 (SYNTAX_INLINE): New macro.
2114 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2115 for the new functions. Use bool for boolean member.
2116 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2117 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2118 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2119 (SETUP_BUFFER_SYNTAX_TABLE):
2120 Now extern inline functions, not macros.
2121 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2122 Remove; all uses replaced by implementation.
2123 (syntax_temp) [!__GNUC__]: Remove decl.
2124 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2126 2013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2128 * emacs.c (main): Fix syntax error.
2130 2013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2132 Timestamp fixes for undo (Bug#14824).
2133 * atimer.c (schedule_atimer):
2134 * fileio.c (Ffile_newer_than_file_p):
2135 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2136 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2137 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2138 (syms_of_fileio): Remove Sclear_visited_file_name.
2139 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2140 file doesn't exist; this avoids an ambiguity with negative timestamps.
2141 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2142 * systime.h (make_emacs_time, invalid_emacs_time):
2143 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2144 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2145 * undo.c (record_first_change): Push (visited-file-modtime) onto
2146 undo list rather than reimplementing it by hand, incorrectly.
2148 2013-07-09 Ken Brown <kbrown@cornell.edu>
2150 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2152 2013-07-09 Juanma Barranquero <lekktu@gmail.com>
2154 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2156 2013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2158 Handle errno and exit status a bit more carefully.
2159 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2160 number into an exit status. Instead, use EXIT_CANCELED.
2161 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2162 * callproc.c (relocate_fd):
2163 * emacs.c (close_output_streams, main):
2164 * process.c (create_process):
2165 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2166 Use emacs_perror for simplicity.
2167 * callproc.c (relocate_fd, main):
2168 * sysdep.c (sys_subshell):
2169 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2170 (shut_down_emacs): Use emacs_write, not write.
2171 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2172 * fileio.c (Fcopy_file, e_write):
2173 * nsterm.m (ns_select):
2174 * process.c (send_process):
2175 * sound.c (vox_write):
2176 Use emacs_write_sig, not emacs_write.
2177 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2178 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2180 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2182 (emacs_full_write): New function.
2183 (emacs_write): Rewrite to use it.
2184 (emacswrite_sig, emacs_perror): New functions.
2185 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2187 2013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
2189 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2190 on NS even if it is present. Pixmap on NS is a void*.
2192 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2194 Port to Ubuntu 10 (Bug#14803).
2195 Problem reported by T.V. Raman.
2196 * process.c (close_on_exec, accept4, process_socket):
2197 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2199 2013-07-07 Eli Zaretskii <eliz@gnu.org>
2201 * w32.c (sys_dup): Declare prototype.
2205 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2207 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2209 Make file descriptors close-on-exec when possible (Bug#14803).
2210 This simplifies Emacs a bit, since it no longer needs to worry
2211 about closing file descriptors by hand in some cases.
2212 It also fixes some unlikely races. Not all such races, as
2213 libraries often open files internally without setting
2214 close-on-exec, but it's an improvement.
2215 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2216 * callproc.c (Fcall_process) [!MSDOS]:
2217 * emacs.c (main) [!DOS_NT]:
2218 * nsterm.m (ns_term_init):
2219 * process.c (create_process):
2220 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2221 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2222 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2223 Prefer mkostemp with O_CLOEXEC to mkstemp.
2224 * callproc.c (relocate_fd) [!WINDOWSNT]:
2225 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2226 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2228 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2229 Make the resulting file descriptor close-on-exec.
2230 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2231 * lread.c (load_descriptor_list, load_descriptor_unwind):
2232 Remove; no longer needed. All uses removed.
2233 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2234 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2236 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2237 (Fmake_network_process, Fnetwork_interface_list):
2238 (Fnetwork_interface_info, server_accept_connection):
2239 Make newly-created socket close-on-exec.
2240 * sysdep.c (emacs_open, emacs_fopen):
2241 Make new-created descriptor close-on-exec.
2242 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2243 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2245 2013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2247 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2248 for NS_IMPL_GNUSTEP.
2250 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2252 Fix openp errno handling.
2253 * callproc.c (Fcall_process): Preserve openp errno around close.
2254 * lread.c (openp): Set errno when returning -1, as some callers
2257 2013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2259 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2261 * nsterm.h (NSSavePanel): Update comment.
2262 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2263 (ns_run_file_dialog): Declare.
2265 * nsfns.m: Remove panelOK.
2267 (ns_run_file_dialog): New function.
2268 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2269 event loop, so file dialog is popped up by ns_run_file_dialog, called
2270 by sendEvent (Bug#14578).
2271 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2273 2013-07-06 Eli Zaretskii <eliz@gnu.org>
2275 * xdisp.c (default_line_pixel_height): New function.
2276 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2277 (try_cursor_movement, redisplay_window, try_window)
2278 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2280 * window.c (window_scroll_pixel_based):
2281 use default_line_pixel_height.
2283 * dispextern.h (default_line_pixel_height): Add prototype.
2285 * frame.c (x_set_line_spacing): Accept a float value for
2286 line-spacing parameter, per the documentation.
2288 * data.c (Fmultibyte_string_p): Doc fix.
2290 2013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2292 Use emacs_open more consistently when opening files.
2293 This handles EINTR more consistently now, and makes it easier
2294 to introduce other uniform changes to file descriptor handling.
2295 * src/systdio.h: New file.
2296 * src/buffer.c (mmap_init):
2297 * cygw32.c (chdir_to_default_directory):
2298 * dispnew.c (Fopen_termscript):
2299 * emacs.c (Fdaemon_initialized):
2300 * fileio.c (Fdo_auto_save):
2301 * image.c (slurp_file, png_load_body, jpeg_load_body):
2302 * keyboard.c (Fopen_dribble_file):
2304 * print.c (Fredirect_debugging_output):
2305 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2306 * termcap.c (tgetent):
2307 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2308 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2309 * w32term.c (w32_initialize) [CYGWIN]:
2310 * xfaces.c (Fx_load_color_file):
2311 Use emacs_open instead of plain open, and emacs_fopen instead of
2313 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2314 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2315 * callproc.c (default_output_mode): New constant.
2316 (Fcall_process): Use it to call emacs_open instead of plain creat.
2317 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2318 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2319 (emacs_fopen): New function.
2320 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2321 Include <lisp.h>, for emacs_open.
2322 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2324 Remove duplicate #include directives.
2325 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2327 Don't include stdio.h twice.
2328 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2329 Don't include sys/types.h or stdio.h twice.
2330 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2331 * lread.c: Don't include coding.h twice.
2332 * nsfont.m: Don't include frame.h twice.
2333 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2334 * ralloc.c: Don't include <unistd.h> twice.
2335 * xdisp.c: Don't include font.h twice.
2336 * xterm.c: Don't include fontset.h twice.
2337 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2339 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2341 Scale ImageMagick images more carefully.
2342 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2343 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2344 Be more careful about avoiding undefined behavior after
2345 integer overflow and division by zero.
2347 2013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2349 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2350 (syms_of_w32fns): DEFSYM them.
2351 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2352 (CCHDEVICENAME): Define macros if not defined.
2353 (struct MONITOR_INFO_EX): New struct.
2354 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2355 (enum_display_monitors_fn): New variable.
2356 (globals_of_w32fns): Initialize it.
2357 (Fx_display_pixel_width, Fx_display_pixel_height)
2358 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2359 multi-monitor setups in docstrings.
2360 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2361 screen size by primary monitor's millimeter per pixel.
2362 (w32_monitor_enum, w32_display_monitor_attributes_list)
2363 (w32_display_monitor_attributes_list_fallback)
2364 (Fw32_display_monitor_attributes_list): New functions.
2365 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2367 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2369 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2371 2013-07-04 Michael Albinus <michael.albinus@gmx.de>
2373 * fileio.c (Qfile_notify_error): New error symbol.
2375 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2376 * inotify.c (inotify_callback, symbol_to_inotifymask)
2377 (Finotify_add_watch, Finotify_rm_watch): Use it.
2378 (inotifyevent_to_event): Exchange order of cookie and file name.
2379 (Finotify_add_watch): Adapt docstring.
2381 * lisp.h (Qfile_notify_error): Declare.
2383 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2385 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2386 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2387 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2388 which did not work (see <http://bugs.gnu.org/14569#307>).
2389 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2390 && (!noninteractive || initialized)). This attempts to thread
2391 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2393 2013-07-04 Juanma Barranquero <lekktu@gmail.com>
2395 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2396 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2398 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2400 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2401 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2402 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2403 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2405 2013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2407 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2408 Define to __sys_siglist.
2410 2013-07-02 Eli Zaretskii <eliz@gnu.org>
2412 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2413 word-wrap, so that overflow-newline-into-fringe would work in
2414 visual-line-mode. (Bug#2749)
2415 (move_it_in_display_line_to): When the last scanned display
2416 element fits exactly on the display line, and
2417 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2418 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2419 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2420 finding buffer position that corresponds to pixel coordinates,
2421 e.g. in buffer_posn_from_coords.
2423 2013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2425 * process.c (handle_child_signal): Call catch_child_signal if
2428 2013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2430 Don't convert function pointers to void * and back.
2431 It isn't portable C, and it's easy enough to avoid.
2432 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2433 (make_save_value): Add support for SAVE_FUNCPOINTER.
2434 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2435 * print.c (print_object):
2436 Distinguish function from object pointers.
2437 * lisp.h (SAVE_FUNCPOINTER): New constant.
2438 (SAVE_SLOT_BITS): Adjust to it.
2439 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2440 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2441 (voidfuncptr): New typedef.
2442 (struct Lisp_Save_Value): New member data[0].funcpointer.
2443 (XSAVE_FUNCPOINTER): New function.
2445 Simplify buildobj processing.
2446 * Makefile.in (buildobj.h): Make it a sequence of strings each
2447 followed by comma, rather than a single string. Put it into a
2448 .tmp file in case there's an error while generating it.
2449 (gl-stamp): Use .tmp for temp files.
2450 (mostlyclean): Clean .tmp files.
2451 * doc.c (buildobj): Move to just the routine that needs it.
2452 It's now an array of strings, so processing is simpler.
2454 2013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2456 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2457 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2458 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2459 Invoke malloc_enable_thread even when not interactive.
2460 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2461 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2462 in this case, since the underlying bug has now been fixed.
2464 2013-07-01 Juanma Barranquero <lekktu@gmail.com>
2466 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2467 unlinking it (bug#14691).
2469 2013-06-30 Michal Nazarewicz <mina86@mina86.com>
2471 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2472 before checking whether buffer is modified. This lets
2473 `kill-buffer-query-functions' cancel killing of the buffer or save
2474 its content before `kill-buffer' asks user the "Buffer %s
2475 modified; kill anyway?" question.
2477 2013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2479 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2480 Let the super performKeyEquivalent deal with them (Bug#14747).
2482 2013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2484 * widget.c (resize_cb): Remove unused local.
2486 Do not use GTK 3 if it exists but cannot be compiled.
2487 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2488 * xterm.c (x_error_handler) [!USE_GTK]:
2491 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2493 2013-06-30 Eli Zaretskii <eliz@gnu.org>
2495 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2496 to the valid range of values. (Bug#14753)
2498 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2499 when moving point by using the current glyph matrix. This avoids
2500 the need to force redisplay when this function is called in a
2503 2013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2505 Fix minor problems found by static checking.
2506 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2507 Redo the latter's body to sidestep GCC parenthesization warnings.
2508 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2509 * coding.c (detect_coding, detect_coding_system):
2510 * coding.h (struct undecided_spec):
2511 Use bool for boolean.
2512 * image.c (QCmax_width, QCmax_height): Now static.
2513 * xdisp.c (Fmove_point_visually): Remove unused local.
2515 2013-06-29 Eli Zaretskii <eliz@gnu.org>
2517 * xdisp.c (Fmove_point_visually): New function.
2519 2013-06-28 Kenichi Handa <handa@gnu.org>
2521 * coding.h (define_coding_undecided_arg_index): New enum.
2522 (coding_attr_index): New members
2523 coding_attr_undecided_inhibit_null_byte_detection,
2524 coding_attr_undecided_inhibit_iso_escape_detection,
2525 coding_attr_undecided_prefer_utf_8.
2526 (undecided_spec): New struct.
2527 (struct coding_system): New member `undecided' of the member
2530 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2531 (detect_coding): Likewise.
2532 (detect_coding_system): Likewise.
2533 (Fdefine_coding_system_internal): New coding system properties
2534 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2536 (syms_of_coding): Adjust for coding_arg_undecided_max.
2538 2013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2540 * image.c (x_from_xcolors): Remove unused local.
2542 2013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2544 Defer image data transfer between X client and server until actual
2547 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2550 * image.c (Destroy_Image): Remove.
2551 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2552 `mask_p', and `colors_p'. All uses changed.
2553 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
2554 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2555 New macros for `flags' arg to x_clear_image_1.
2556 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2557 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
2558 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
2559 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2560 (image_get_x_image, image_unget_x_image): New functions or macros.
2561 (image_background, image_background_transparent, x_to_xcolors)
2562 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2563 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2564 instead of Destroy_Image.
2565 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2566 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2567 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2568 (imagemagick_load_image, svg_load_image): Use them instead of
2569 x_create_x_image_and_pixmap, and x_put_x_image followed by
2570 x_destroy_x_image, respectively.
2571 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2572 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2573 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2574 background_transparent fields.
2575 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2576 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2578 2013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2580 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2581 This mostly consists of undoing recent changes.
2582 * callproc.c (Fcall_process):
2583 * process.c (create_process):
2584 Do not worry about catching SIGCHLD here, undoing previous change.
2585 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2586 * process.c, process.h (catch_child_signal):
2587 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2588 * process.c (catch_child_handler): Don't worry about being called
2589 lazily and do not assume caller has blocked SIGCHLD, undoing
2590 previous change. Move first-time stuff back to
2591 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2592 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2593 set lib_child_handler if it's already initialized, which may
2594 help avoid problems on GNUStep.
2596 2013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2598 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2599 * callproc.c (Fcall_process):
2600 * process.c (create_process):
2601 Make sure SIGCHLD is caught before we fork,
2602 since Emacs startup no arranges to catch SIGCHLD.
2603 * process.c (lib_child_handler): Initialize to null, not to
2605 (catch_child_signal): Allow self to be called lazily.
2606 Do nothing if it's already been called.
2607 Assume caller has blocked SIGCHLD (all callers do now).
2608 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2609 just before it's really needed.
2610 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2611 since it hasn't been caught yet.
2613 2013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2615 * image.c (compute_image_size): New function to implement
2616 :max-width and :max-height.
2617 (imagemagick_load_image): Use it.
2619 2013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2621 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2622 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2624 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2625 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2626 the SIGCHLD handler, since the code is not atomic and (due to glib)
2627 signals may be arriving now.
2628 * sysdep.c (init_signals): Do not catch child signals here;
2629 'main' now does that later, at a safer time.
2631 2013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2633 Clean up SIGCHLD handling a bit (Bug#14569).
2634 * process.c, process.h (catch_child_signal):
2635 Now always extern, even if !NS_IMPL_GNUSTEP.
2636 * process.c (catch_child_signal): Move glib tickler here from
2637 init_process_emacs, so that it's done earlier in Emacs
2638 initialization. Also move the noninteractive && !initialized
2639 check here from init_process_emacs. This is all a bit cleaner for
2640 GNUish platforms, and I hope it works around the Cygwin bug.
2641 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2642 that glib signal handling is tickled before glib creates threads.
2644 * process.c (wait_reading_process_output): Avoid int overflow
2645 when reading more than 2 GiB total from a process.
2647 2013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2649 * process.c (create_process): Handle a couple more cases,
2650 i.e., work even if new_argv and wait_child_setup[i] are cached.
2651 Use Fcall_process's style for volatile vars.
2653 2013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2655 * process.c (create_process): Mark PROCESS volatile.
2657 2013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2659 Use C99-style flexible array members if available.
2660 This avoids some subtle aliasing issues, which typically
2661 aren't a problem with GCC but may be a problem elsewhere.
2662 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2663 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2664 In either case, it uses a flexible array member rather than
2665 the old struct hack. All uses changed.
2666 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2667 Adjust to sdata reorganization.
2668 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2669 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2670 that ports better to pre-C99 non-GCC.
2671 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2672 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2673 as the latter has changed.
2674 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2675 and port better to pre-C99 GCC.
2676 * image.c (struct xpm_cached_color):
2677 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2678 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2679 Use FLEXIBLE_ARRAY_MEMBER.
2680 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2681 Move decl to top level so it gets checked against implementation.
2682 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2683 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2685 2013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2687 * syntax.c: Integer cleanups.
2688 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2689 All uses that need 0-or-2 changed to:
2690 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2691 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2692 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2693 (char_quoted, prev_char_comend_first, back_comment)
2694 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2695 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2696 Use bool for boolean.
2697 (update_syntax_table, skip_chars, skip_syntaxes):
2698 Prefer int to unsigned when either will do.
2699 (back_comment): Return boolean success flag, like forw_comment,
2700 instead of positive-or-minus-1 (which might have overflowed int anyway).
2701 Don't stuff ptrdiff_t into int.
2702 (syntax_spec_code, syntax_code_spec): Now const.
2703 (Fmatching_paren, scan_lists, scan_sexps_forward):
2704 Use enum syntaxcode for syntax code.
2705 (Fmatching_paren): Check that arg is a character, not just an integer.
2706 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2707 (Finternal_describe_syntax_value): Omit no-longer-needed
2709 (skip_chars): Use char, not unsigned char, when the distinction
2711 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2712 * bytecode.c (exec_byte_code):
2713 * syntax.c (syntax_spec_code, Fchar_syntax)
2714 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2716 * syntax.h (SYNTAX_WITH_FLAGS):
2717 Omit unnecessary casts.
2719 2013-06-20 Eli Zaretskii <eliz@gnu.org>
2721 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2722 line dimensions here, to avoid race conditions with the main
2723 thread. (Bug#14062, bug#14630, bug#14669)
2725 * w32term.c (w32_draw_window_cursor): Compute the header line and
2726 mode line dimensions here.
2727 <w32_system_caret_window, w32_system_caret_hdr_height>:
2728 <w32_system_caret_mode_height>: New variables.
2730 * w32term.h: Declare them.
2732 2013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2734 * alloc.c (die): Move "assertion failed" string here ...
2735 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2736 COND when SUPPRESS_CHECKING. This shrinks the executable text
2737 size by 0.8% to 2.2% when configured with --enable-checking,
2738 depending on optimization flags (GCC 4.8.1 x86-64).
2740 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2742 2013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
2744 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2745 base is 2; this is more accurate.
2747 2013-06-19 Juanma Barranquero <lekktu@gmail.com>
2749 * sound.c (string_default): Move to !WINDOWSNT section.
2750 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2752 2013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2754 * sound.c: Integer cleanups.
2755 Remove unnecessary forward decls.
2756 (struct sound_device): The 'file' member is now a Lisp_Object, not
2757 a char *, so that we needn't invoke alloca on a huge size.
2758 (Fplay_sound_internal): Adjust to this.
2759 (string_default): New function.
2760 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2761 Use it to adjust to the struct sound_device change.
2762 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2763 (be2hs) [0]: Remove.
2765 * syntax.c (skip_chars): Don't use uninitialized storage
2766 when searching a multibyte buffer for characters that are not in a
2767 unibyte string that contains non-ASCII characters.
2769 2013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2771 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2772 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2774 2013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2776 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2778 2013-06-18 Kenichi Handa <handa@gnu.org>
2780 * font.c (Ffont_spec): Signal an error for an invalid font name
2783 2013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2785 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2786 In particular this ports to 32-bit sparc Sun cc.
2787 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2788 array with a dummy element at specpdl[-1], so that its address can
2790 (unbind_to): Do not copy the binding; not needed, now that we
2791 copy old_value in the one place where the copy is needed.
2792 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2793 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2794 (union specbinding): Rename from struct specbinding. Redo layout
2795 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2796 which is not portable. With Sun C 5.12 32-bit sparc, the
2797 declaration causes nargs to be an unsigned bitfield, a behavior
2798 that the C standard allows; but Emacs wants nargs to be signed.
2799 The overall type is now a union of structures rather than a
2800 structure of union of structures, and the 'kind' member is now a
2801 bitfield, so that the overall type doesn't grow. All uses changed.
2802 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2804 2013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2806 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2807 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2809 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2811 2013-06-17 Eli Zaretskii <eliz@gnu.org>
2813 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2814 unless we know that the window w's frame is a frame object.
2815 Another attempt at solving bug#14062 and bug#14630.
2817 2013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2819 * textprop.c (property_set_type): New enum.
2820 (add_properties): Allow appending/prepending text properties.
2821 (add_text_properties_1): Factored out of Fadd_text_properties.
2822 (Fadd_text_properties): Move all the code into
2823 add_text_properties_1.
2824 (Fadd_face_text_property): New function that calls
2825 add_text_properties_1.
2827 2013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2829 Move functions from lisp.h to individual modules when possible.
2830 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2831 * alloc.c (XFLOAT_INIT, set_symbol_name):
2832 * buffer.c (CHECK_OVERLAY):
2833 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2834 (set_char_table_parent):
2835 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2836 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2837 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2838 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2840 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2841 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2842 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2843 (backtrace_args, backtrace_debug_on_exit):
2844 * floatfns.c (CHECK_FLOAT):
2845 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2846 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2847 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2848 (set_hash_index_slot):
2849 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2850 * marker.c (CHECK_MARKER):
2851 * textprop.c (CHECK_STRING_OR_BUFFER):
2852 * window.c (CHECK_WINDOW_CONFIGURATION):
2853 Move here from lisp.h, and make these functions static rather than
2855 * buffer.c (Qoverlayp):
2857 * fns.c (Qhash_table_p):
2858 * window.c (Qwindow_configuration_p):
2860 * lisp.h: Remove the abovementioned defns and decls.
2862 Use functions, not macros, for XINT etc (Bug#11935).
2863 In lisp.h, prefer functions to function-like macros, and
2864 constants to object-like macros, when either will do. This:
2865 . simplifies use, as there's no more need to worry about
2866 arguments' side effects being evaluated multiple times.
2867 . makes the code easier to debug on some platforms.
2868 However, when using gcc -O0, keep using function-like macros
2869 for a few critical operations, for performance reasons.
2870 This sort of thing isn't needed with gcc -Og, but -Og
2871 is a GCC 4.8 feature and isn't widely-enough available yet.
2872 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2873 Remove enum lsb_bits; no longer needed.
2874 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2875 * buffer.c (Qoverlap):
2877 * fns.c (Qhash_table_p):
2878 Now extern, so lisp.h can use these symbols.
2879 * dispextern.h: Include character.h, for MAX_CHAR etc.
2880 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2881 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2882 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2883 (GLYPH_CODE_P): Move here from lisp.h.
2884 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2885 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2886 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2887 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2888 XUNTAG now returns void *.
2889 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2890 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2891 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2892 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2893 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2894 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2895 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2896 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2897 New macros, renamed from their sans-lisp_h_ counterparts.
2898 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2899 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2900 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2901 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2902 If compiling via GCC without optimization, define these as macros
2903 in addition to inline functions.
2904 To disable this, compile with -DINLINING=0.
2905 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2906 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2907 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2908 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2909 (INTMASK, VALMASK): Now macros, since static values cannot be
2910 accessed from extern inline functions.
2911 (VALMASK): Also a constant, for benefit of old GDB.
2912 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2913 is INTEGERP, which can fold it in.
2914 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
2915 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2916 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2917 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2918 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2919 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2920 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2921 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2922 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2923 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2924 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2925 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2926 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2927 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2928 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2929 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2930 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2931 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2932 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2933 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2934 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2935 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2936 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2937 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2938 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2939 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2940 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2941 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2942 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2943 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2944 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2945 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2946 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2948 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2949 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2950 (VALMASK): Define in one place rather than in two, merging the
2951 USE_LSB_TAG parts; this is simpler.
2952 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2953 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2954 Move up, to avoid use before definition.
2955 Also include "globals.h" earlier, for the same reason.
2956 (make_natnum): New function.
2957 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2958 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2959 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2960 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2961 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2962 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2963 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2964 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2965 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2966 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2967 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2968 (Qwindow_configuration_p, Qimage): New forward declarations.
2969 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2970 (STRING_COPYIN): Remove; unused.
2971 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2972 (xcar_addr, xcdr_addr): New functions. All uses changed.
2973 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2974 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2975 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2976 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2977 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2978 (TYPE_RANGED_INTEGERP): Simplify.
2979 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2980 (setlocale, fixup_locale, synchronize_system_messages_locale)
2981 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2982 Now empty functions, not macros.
2983 (functionp): Return bool, not int.
2984 * window.c (Qwindow_configuration_p): Now extern,
2985 so window.h can use it.
2986 * window.h (Qwindowp): Move decl back to lisp.h.
2988 2013-06-15 Eli Zaretskii <eliz@gnu.org>
2990 * xdisp.c (Fline_pixel_height): New function, required for solving
2993 2013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2995 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2997 2013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2999 * lread.c (syms_of_lread):
3000 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3002 2013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3004 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3006 2013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3008 * fileio.c (expand_file_name): Doc fix.
3010 2013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3012 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3013 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3014 Wait for self, not for 0. This can't hurt on GNU or similar
3015 system, and may help with Cygwin.
3017 * keyboard.c: Don't use PROP (...) as an lvalue.
3018 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3019 Use set_prop (A, B), not PROP (A) = B.
3021 2013-06-10 Eli Zaretskii <eliz@gnu.org>
3023 * xdisp.c (get_it_property): Use it->window instead of generating
3024 a Lisp object from it->w.
3026 2013-06-09 Eli Zaretskii <eliz@gnu.org>
3028 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3029 get-char-property the window that is being rendered, instead of
3030 the buffer, to support window-specific overlays. (Bug#14575)
3031 (compute_display_string_pos): When W is NULL, use the current
3032 buffer as the object to pass to get-char-property.
3033 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3034 pointer member of the bidi iterator, since no window is pertinent
3037 2013-06-08 Eli Zaretskii <eliz@gnu.org>
3039 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3040 being displayed, and pass it to compute_display_string_pos.
3041 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3042 (bidi_paragraph_init): All callers changed.
3044 * xdisp.c (init_from_display_pos, init_iterator)
3045 (handle_single_display_spec, next_overlay_string)
3046 (get_overlay_strings_1, reseat_1, reseat_to_string)
3047 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3048 Set bidi_it.w member from it->w.
3049 (compute_display_string_pos): Accept additional argument, the
3050 window being displayed, and pass it to Fget_char_property.
3053 * dispextern.h (struct bidi_it): New member w, the window being
3055 (compute_display_string_pos): Adjust prototype.
3057 2013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3059 * xgselect.c: Remove unneeded include xterm.h.
3061 * process.c (wait_reading_process_output): Check for NS before GLIB.
3062 GLIB may be linked in due to rsvg, but ns_select must be called.
3064 * xgselect.c (xg_select): Remove call to window_system_available
3065 and g_main_context_pending at the top, so Gdk events (i.e. file
3066 notify) are processed when Emacs is started with -nw.
3068 2013-06-07 Eli Zaretskii <eliz@gnu.org>
3070 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3071 (ctagsfiles3): New variable, includes only *.m files.
3072 (TAGS): Use an explicit language name in the regular expressions,
3073 to avoid transformation of '/SOMETHING' by MSYS to
3074 'c:\MSYS\SOMETHING'.
3076 2013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3078 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3080 2013-06-06 Eli Zaretskii <eliz@gnu.org>
3082 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3083 still need to set the mouse pointer shape and activate help-echo.
3086 2013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3088 A few porting etc. fixes for the new file monitor code.
3089 See the thread containing
3090 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3091 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3092 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3093 (dir_monitor_callback, Fgfile_rm_watch):
3094 Use assq_no_quit instead of Fassoc, for speed.
3095 (dir_monitor_callback, Fgfile_rm_watch):
3096 eassert that the monitor is a fixnum.
3097 (dir_monitor_callback): No need for CDR_SAFE.
3098 Simplify building of lisp with alternative tails.
3099 (Fgfile_add_watch, Fgfile_rm_watch):
3100 Do not assume glib functions set errno reliably on failure.
3101 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3102 and signal an error otherwise.
3103 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3104 Use Fdelq instead of Fdelete, for speed.
3106 2013-06-05 Eli Zaretskii <eliz@gnu.org>
3108 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3109 don't insist on being invoked on a highlighted tool-bar button.
3110 Avoids losing tool-bar functionality when mouse-highlight is nil.
3111 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3112 Don't highlight when mouse-highlight is nil.
3113 (note_mouse_highlight): When mouse-highlight is nil, don't return
3114 right away; instead, run tool-bar and mode-line highlight
3115 subroutine, clear any existing highlight, and revert the mouse
3116 pointer to its default shape. (Bug#14558)
3118 2013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3120 * lisp.mk (lisp): Add prog-mode.el.
3122 2013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3124 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3125 * process.c (dummy_handler): New function.
3126 (lib_child_handler): New static var.
3127 (handle_child_signal): Invoke it.
3128 (catch_child_signal): If a library has set up a signal handler,
3129 save it into lib_child_handler.
3130 (init_process_emacs): If using glib and not on Windows, tickle glib's
3131 child-handling code so that it initializes its private SIGCHLD handler.
3132 * syssignal.h (SA_SIGINFO): Default to 0.
3133 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3134 31; it should no longer be needed now.
3136 2013-06-05 Michael Albinus <michael.albinus@gmx.de>
3138 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3140 * gfilenotify.c (globals_of_gfilenotify): New function.
3141 (syms_of_gfilenotify): Move global initialization there.
3143 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3145 2013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3147 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3148 * keyboard.c (menu_bar_items, tool_bar_items):
3149 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3150 not override local keymaps any more.
3152 2013-06-04 Eli Zaretskii <eliz@gnu.org>
3154 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3156 2013-06-03 Eli Zaretskii <eliz@gnu.org>
3158 * w32console.c (initialize_w32_display): Return the dimensions of
3159 the console window via 2 additional arguments, not via the current
3160 frame. This avoids crashes due to overrunning the bounds of
3161 frame's decode_mode_spec_buffer, which is not resized following
3162 the change of the frame dimensions from the initial 10x10.
3164 * w32term.h (w32_initialize_display_info): Adjust prototype.
3166 * term.c (init_tty): Take dimensions of the frame from the values
3167 returned by initialize_w32_display.
3169 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3170 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3171 (LIBES): Add $(GFILENOTIFY_LIBS).
3173 * w32inevt.c (handle_file_notifications): Add dummy implementation
3174 for !HAVE_W32NOTIFY.
3176 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3178 2013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3180 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3182 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3184 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3186 2013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3188 Fix minor problems found by static checking.
3189 * data.c (pure_write_error):
3190 Use xsignal2, not Fsignal, as Fsignal might return.
3191 * eval.c (set_backtrace_debug_on_exit): Now static.
3192 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3193 No longer inline. EXTERN_INLINE is needed only for functions
3194 defined in .h files. Reindent function header as per GNU style.
3195 (backtrace_p, backtrace_top, backtrace_next):
3196 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3197 compiler or linker. Add extern decls to pacify gcc -Wall.
3198 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3200 * frame.c (free_monitors): Define only on platforms that need it.
3201 * nsterm.m (ns_term_init):
3202 * process.c (catch_child_signal):
3203 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3204 defined on all porting targets these days.
3205 * process.c, process.h (catch_child_signal):
3206 Make it extern only if NS_IMPL_GNUSTEP is defined.
3208 2013-06-03 Eli Zaretskii <eliz@gnu.org>
3210 * w32.c (gettimeofday): Make the signature identical to prototype
3211 in nt/inc/sys/time.h.
3213 2013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3215 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3218 * keyboard.c (safe_run_hooks_error): Improve error message.
3220 * data.c (pure_write_error): Add `object' argument.
3221 * puresize.h (CHECK_IMPURE): Use it.
3223 2013-06-03 Michael Albinus <michael.albinus@gmx.de>
3225 * Makefile.in (NOTIFY_OBJ): New variable.
3226 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3228 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3229 Call syms_of_gfilenotify.
3231 * gfilenotify.c: New file.
3233 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3234 and Qfile_w32notify.
3235 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3236 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3238 * lisp.h: Declare syms_of_gfilenotify.
3240 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3242 2013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3244 Merge the specpdl and backtrace stacks. Make the structure of the
3245 specpdl entries more obvious via a tagged union of structs.
3246 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3247 (enum specbind_tag): New enum.
3248 (struct specbinding): Make it a tagged union of structs.
3249 Add a case for backtrace records.
3250 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3251 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3252 (backtrace_debug_on_exit): New accessors.
3253 (struct backtrace): Remove.
3254 (struct catchtag): Remove backlist field.
3255 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3257 (Flocal_variable_p): Speed up the common case where the binding is
3259 * eval.c (backtrace_list): Remove.
3260 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3261 (set_backtrace_args, set_backtrace_nargs)
3262 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3263 (backtrace_next): New functions.
3264 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3265 (unwind_to_catch, internal_lisp_condition_case)
3266 (internal_condition_case, internal_condition_case_1)
3267 (internal_condition_case_2, internal_condition_case_n): Don't bother
3268 with backtrace_list any more.
3269 (Fsignal): Adjust to new backtrace format.
3270 (grow_specpdl): Move up.
3271 (record_in_backtrace): New function.
3272 (eval_sub, Ffuncall): Use it.
3273 (apply_lambda): Adjust to new backtrace format.
3274 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3276 (specbind): Adjust to new specpdl format. Simplify.
3277 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3278 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3280 (mark_backtrace): Remove.
3281 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3282 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3283 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3285 * profiler.c (record_backtrace): Use get_backtrace.
3286 (handle_profiler_signal): Use backtrace_top_function.
3287 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3290 2013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3292 * process.h (catch_child_signal): Declare.
3294 * process.c (catch_child_signal): New function.
3295 (init_process_emacs): Call it.
3297 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3298 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3300 (x_set_cursor_type): Remove declaration.
3301 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3302 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3303 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3304 (ns_get_color): Use F suffix on float.
3305 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3306 (ns_get_rgb_color): Remove.
3307 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3308 (note_mouse_movement): x and y are CGFloat.
3309 (ns_draw_fringe_bitmap): Remove unused rowY.
3310 Change #if to COCOA && >= 10_6.
3311 (ns_draw_window_cursor): Remove unused overspill.
3312 (ns_draw_underwave): width and x are EamcsCGFloat.
3313 (ns_draw_box): thickness is CGFloat.
3314 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3315 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3316 if not in main thread.
3317 (ns_get_pending_menu_title, ns_check_menu_open)
3318 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3319 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3320 (sendFromMainThread:): New method.
3321 (changeFont:): size is CGFloat.
3322 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3323 Disable warning about permanent text.
3324 (characterIndexForPoint:): Adjust return type depending on GNUStep
3326 (mouseDown:): delta is CGFloat.
3327 (updateFrameSize): Remove unised variable f.
3328 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3329 Cast float to EmacsCGFloat.
3330 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3331 also to -1 when restoring.
3332 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3333 inside NS_IMPL_COCOA.
3334 (toggleFullScreen:): Put call to toggleFullScreen inside
3335 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3336 (setPosition:portion:whole:): por is CGFloat.
3337 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3338 (mouseDown:): Use CGFloat.
3339 (mouseDragged:): Remove unised variable edge.
3340 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3342 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3344 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3345 when NS_IMPL_GNUSTEP.
3346 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3347 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3348 (EmacsToolbar): Add clearAll. Add tag argument to
3349 addDisplayItemWithImage.
3350 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3352 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3354 * nsmenu.m (ns_update_menubar): Make static.
3355 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3356 (fillWithWidgetValue:): Add cast to SEL for setAction.
3357 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3358 (update_frame_tool_bar): Update code for GNUStep.
3359 (clearAll): New method.
3360 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
3361 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
3362 Move identifierToItem setObject and activeIdentifiers addObject before
3363 call to insertItemWithItemIdentifier.
3364 (validateVisibleItems): Fix indentation.
3365 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3366 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3367 UtilityWindow to aStyle, remove call to setStyleMask.
3369 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3371 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3372 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3373 Use F suffix on floats.
3374 (ns_char_width): Returns CGFloat.
3375 (ns_ascii_average_width): w is CGFloat instead of float.
3376 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
3378 (ns_glyph_metrics): CGFloat instead of float.
3380 * nsfns.m (x_set_foreground_color, x_set_background_color):
3382 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3383 remove unused variables.
3384 (Fns_read_file_name): Keep track if panel is for save.
3385 Use ns_filename_from_panel/ns_directory_from_panel.
3386 (Fns_list_services): delegate only used for COCOA.
3387 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3388 Just return the input if GNUStep.
3389 (x_screen_planes): Remove.
3390 (Fxw_color_values): Use EmacsCGFloat
3391 (Fns_display_monitor_attributes_list): Only get screen number for
3393 (getDirectory, getFilename): Remove from EmacsOpenPanel and
3395 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3396 ns_directory_from_panel.
3398 2013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3400 * process.c (handle_child_signal): Also use WCONTINUED.
3401 This is so that list-processes doesn't mistakenly list the process
3402 as stopped, when the process has actually been continued and is
3405 2013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3407 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3408 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3409 not already configured.
3411 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3413 2013-05-29 Eli Zaretskii <eliz@gnu.org>
3415 * Makefile.in (mostlyclean): Remove *.res files.
3417 2013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3419 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3420 a buffer (bug#8447).
3422 2013-05-27 Eli Zaretskii <eliz@gnu.org>
3424 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3425 display vector, and we backtrack, handle the case that the
3426 previous character position is also displayed from a display
3427 vector or covered by a display string or image. (Bug#14476)
3429 2013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3431 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3432 (struct MonitorInfo, free_monitors): Remove.
3433 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3434 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3435 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3438 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3439 (struct MonitorInfo, free_monitors): Remove.
3440 (ns_screen_name): Make static.
3441 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3442 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3445 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3446 (struct MonitorInfo): New struct.
3447 (free_monitors, make_monitor_attribute_list): Declare.
3449 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3451 (free_monitors, make_monitor_attribute_list): New functions.
3452 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3455 2013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3457 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3459 2013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3461 * keyboard.c: Apply keyboard decoding only to events that come directly
3462 from the tty, not from unread-command-events (bug#14368).
3463 (read_event_from_main_queue): New function, extracted from read_char).
3464 (read_decoded_char): Remove.
3465 (read_decoded_event_from_main_queue): New function to replace it.
3466 (read_char): Use it.
3467 (read_key_sequence): Use read_char rather than read_decoded_char.
3469 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3471 2013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3473 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3475 2013-05-22 Kenichi Handa <handa@gnu.org>
3477 The following changes are to fix the setting of
3478 buffer-file-coding-system on, for instance, C-x RET c unix RET
3479 _FILE_OF_DOS_EOL_TYPE_ RET.
3481 * coding.h (struct coding_system): New member detected_utf8_chars.
3483 * coding.c (detect_coding_utf_8): Count characters and check EOL
3484 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3486 (setup_coding_system): Do not initialize coding->head_ascii.
3487 (check_ascii): Do not set coding->eol_seen but update it. Do not
3488 call adjust_coding_eol_type here.
3489 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3490 If the eol-type of CODING is already specified, adjust the eol type
3491 of the found coding-system.
3492 (decode_coding_gap): Cancel previous change. Utilize the
3493 character numbers counted by detect_coding_utf_8. Fix detection
3496 2013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3498 * search.c (looking_at_1): Only set last_thing_searched if the match
3499 changed the match-data (bug#14281).
3501 2013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3503 * xdisp.c (reseat_at_previous_visible_line_start):
3504 Already declared in dispextern.h, so remove it here.
3505 (move_it_vertically_backward): Likewise.
3507 2013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3509 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
3510 (Fx_display_pixel_width, Fx_display_pixel_height)
3511 (Fx_display_mm_width, Fx_display_mm_height):
3512 Mention `display-monitor-attributes-list' in docstrings.
3514 * nsfns.m (ns_get_screen): Remove function. All uses removed.
3515 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
3516 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3517 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3518 (Fx_display_backing_store, Fx_display_visual_class)
3519 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3520 (Fx_display_grayscale_p, Fx_display_pixel_width)
3521 (Fx_display_pixel_height, Fx_display_planes)
3522 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3523 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3524 (Fx_display_mm_width, Fx_display_mm_height)
3525 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3526 height for all physical monitors as in X11.
3528 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3529 Return pixel width or height for all physical monitors as in X11.
3531 2013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3533 Port --enable-gcc-warnings to clang.
3534 * bytecode.c (exec_byte_code):
3536 Redo diagnostic pragmas to pacify clang, too.
3537 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3538 * editfns.c (Fencode_time):
3539 * fileio.c (file_accessible_directory_p):
3540 * font.c (font_unparse_xlfd):
3541 Use '&"string"[index]' instead of '"string" + (index)'.
3542 * undo.c (user_error): Remove; unused.
3544 2013-05-16 Eli Zaretskii <eliz@gnu.org>
3546 * insdel.c (insert_1_both): Document the arguments, instead of
3547 referring to insert_1, which no longer exists.
3549 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3550 some window, increment windows_or_buffers_changed, so that
3551 *Messages* display in that window is updated. (Bug#14408)
3553 * w32.c: Include epaths.h.
3554 (init_environment): Use cmdproxy.exe without leading directories.
3555 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3557 (gettimeofday): Adjust signature and return value to Posix
3560 * unexw32.c (open_output_file): Delete the existing emacs.exe
3561 before creating it, to break the hard link to the versioned
3564 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3565 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3566 (FIRSTFILE_OBJ): New variables.
3567 (W32_RES): Rename to EMACSRES. All users changed.
3568 (base_obj): Use $(CM_OBJ).
3569 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3570 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3571 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3572 $(W32_RES_LINK) before $(LIBES).
3573 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3575 2013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3577 * makefile.w32-in (DOC): Use just "DOC".
3579 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3581 * process.c: Export default filters and sentinels to Elisp.
3582 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3584 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3585 (Fset_process_sentinel, Fformat_network_address):
3586 Default to them instead of nil.
3587 (server_accept_connection): Sentinels can't be nil any more.
3588 (read_and_dispose_of_process_output): New function, extracted from
3589 read_process_output.
3590 (read_process_output): Use it; filters can't be nil.
3591 (Finternal_default_process_filter): New function, extracted from
3592 read_process_output.
3593 (exec_sentinel_unwind): Remove function.
3594 (exec_sentinel): Don't zilch sentinel while running.
3595 (status_notify): Sentinels can't be nil.
3596 (Finternal_default_process_sentinel): New function extracted from
3598 (setup_process_coding_systems): Default filter is not nil any more.
3599 (syms_of_process): Export new Elisp functions and initialize
3601 * lisp.h (make_lisp_proc): New function.
3603 2013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3605 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3607 2013-05-14 Eli Zaretskii <eliz@gnu.org>
3609 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3610 unless we know that the window w is a leaf window.
3611 Another attempt at solving bug#14062.
3613 2013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3615 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3618 2013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3620 * image.c (gif_load): Check that subimages fit (Bug#14345).
3622 2013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3624 * lread.c (skip_dyn_eof): New function.
3625 (read1): Use it to skip the end of a file in response to #@00.
3627 * doc.c (get_doc_string): Slightly relax the sanity checking.
3629 2013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3631 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3632 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3633 (MonitorInfo): New struct.
3634 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3635 (Fns_display_monitor_attributes_list): New functions.
3636 (display-usable-bounds): Remove.
3637 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3640 2013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3642 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3643 (GTK_CHECK_VERSION): New macro, if not already defined.
3644 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3645 replaced by GTK_CHECK_VERSION.
3647 2013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3649 * xterm.h (GTK_PREREQ): New macro.
3650 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3651 to use this macro instead, for consistency and clarity.
3653 2013-05-08 Eli Zaretskii <eliz@gnu.org>
3655 * xdisp.c (row_for_charpos_p): New function, with code of
3656 cursor_row_p, but accepts an additional argument CHARPOS instead
3657 of using a hardcoded PT.
3658 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3659 (row_containing_pos): Call row_for_charpos_p instead of partially
3660 doing the same. Fixes cursor positioning under longlines-mode
3661 when longlines-show-effect includes more than one newline, when
3662 moving the cursor vertically up.
3664 2013-05-08 Juanma Barranquero <lekktu@gmail.com>
3666 * makefile.w32-in (ACL_H): New macro.
3667 ($(BLD)/fileio.$(O)): Update dependencies.
3669 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3671 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
3672 * Makefile.in (LIB_ACL): New macro.
3673 (LIBACL_LIBS): Remove.
3674 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3675 * fileio.c: Include <acl.h>.
3676 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3677 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3679 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3682 * unexelf.c: Don't assume ElfW (Half) fits in int.
3683 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3684 when dealing with ElfW (Half) values, since they can exceed 2**31
3685 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3686 (entry_address): Omit unused NUM arg. All uses changed.
3688 2013-05-07 Juri Linkov <juri@jurta.org>
3690 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3691 to the string converted from number with `Fnumber_to_string'.
3694 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3696 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3697 This fixes a problem introduced by my previous change.
3699 2013-05-07 Glenn Morris <rgm@gnu.org>
3701 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3703 2013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3705 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3707 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3709 Static checking by GCC 4.8.0.
3710 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3711 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3712 (x_get_monitor_attributes_fallback)
3713 (x_get_monitor_attributes_xinerama)
3714 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3715 Define only if USE_GTK.
3716 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3717 (x_get_monitor_attributes_fallback): Omit unused locals.
3718 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3719 Use double, not float, to avoid mixed-mode floating point arithmetic.
3721 2013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3722 Jan Djärv <jan.h.d@swipnet.se>
3724 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3725 (XINERAMA_CFLAGS): New macros.
3726 (ALL_CFLAGS, LIBES): Use them.
3728 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3729 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3730 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3731 (syms_of_xfns): DEFSYM them.
3732 (struct MonitorInfo): New struct.
3733 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3734 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3735 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3736 (x_get_monitor_attributes_xinerama): New functions.
3737 (Fx_display_monitor_attributes_list): New primitive.
3738 (syms_of_xfns): Defsubr it.
3740 * xterm.h (x_display_info): Add Xatom_net_workarea and
3741 Xatom_net_current_desktop.
3743 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3744 and dpyinfo->Xatom_net_current_desktop.
3746 2013-05-06 Eli Zaretskii <eliz@gnu.org>
3748 * xdisp.c (pos_visible_p): Use the special code for finding the
3749 beginning of a display property or overlay for any "replacing"
3750 display property, not just for display strings. This solves
3751 incorrect reporting of position by posn-at-point. (Bug#14241)
3753 2013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3755 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3756 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3757 Verify that ElfW (Half) fits in int.
3758 (fatal): Use same signature as lisp.h.
3759 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3760 configure and build with -DUNEXELF_DEBUG without worrying about
3761 other modules that use DEBUG.
3762 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3763 possibly-wide integers now uses it instead of plain fprintf.
3764 (entry_address): New function, which avoids problems with 32-bit
3765 overflow on 64-bit hosts.
3766 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3767 (round_up): Don't assume the remainder fits in int.
3768 (find_section): Use bool for boolean. Simplify debug code.
3769 (unexec): Don't assume file sizes fit in int or size_t.
3770 Omit unnecessary trailing newline in 'fatal' format.
3771 Use strerror rather than outputting decimal error number.
3772 Remove unused code when emacs is not defined;
3773 this file relies on Emacs now.
3774 Don't assume e_phnum and e_shnum are positive.
3776 * regex.c: Fix problems when DEBUG is defined.
3777 (extract_number, extract_number_and_incr): Define regardless of
3778 whether DEBUG is defined; that's simpler and makes the code less
3779 likely to go stale in the normal case when DEBUG is not defined.
3780 Return int rather than taking an int * arg. All callers changed.
3781 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3782 Remove, replacing with ...
3783 (DEBUG_PRINT): New macro. All callers changed.
3784 (DEBUG_COMPILES_ARGUMENTS): New macro.
3785 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3786 (print_compiled_pattern, print_double_string) [DEBUG]:
3787 Use prototype rather than old-style definition.
3788 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3789 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3790 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3791 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3792 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3793 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3794 This matters only when DEBUG is defined.
3796 2013-05-05 Eli Zaretskii <eliz@gnu.org>
3798 * xdisp.c (set_iterator_to_next): Set the
3799 ignore_overlay_strings_at_pos_p flag only if we are _really_
3800 iterating over an overlay string, as indicated by the
3801 current.overlay_string_index member. (Bug#14306)
3803 2013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3805 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3806 to where it is used, to avoid autorelease issues (Bug#14050).
3808 2013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3810 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3811 * fileio.c (syms_of_fileio): Implement this.
3812 * filelock.c (create_lock_file): If symbolic links don't work, so
3813 we use a regular file as a lock file, do not fsync the lock file;
3816 2013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3818 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3819 (syms_of_minibuf): Adjust accodingly.
3821 * callint.c (Fcall_interactively): Adjust calls accordingly.
3823 2013-05-04 Eli Zaretskii <eliz@gnu.org>
3825 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
3826 w->contents is a buffer before computing everything else.
3827 Use parentheses to disambiguate last part of the condition.
3829 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3830 assertion violations. (Bug#14062)
3832 2013-05-01 David Reitter <david.reitter@gmail.com>
3834 * nsfns.m (ns_tooltip): Initialize.
3836 2013-04-28 Eli Zaretskii <eliz@gnu.org>
3838 * coding.c (decode_coding_gap): Don't remove the character before
3839 a newline unless it's a CR character. (Bug#14287)
3841 2013-04-28 Dan Nicolaescu <dann@gnu.org>
3843 * dispextern.h (struct face): Move enum face_underline_type
3844 earlier so that bitfields can be in the same word.
3846 2013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3848 * nsfns.m (handlePanelKeys): New function.
3849 (EmacsOpenPanel:performKeyEquivalent:)
3850 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3851 arrows/function/control and copy/paste keys (Bug#14296).
3853 2013-04-27 Juri Linkov <juri@jurta.org>
3855 * callint.c (Fcall_interactively): Call `Qread_number' for
3856 interactive code letter `n' instead of using duplicate code.
3859 2013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3861 * systime.h (make_timeval): Declare as 'const'.
3863 2013-04-27 Kenichi Handa <handa@gnu.org>
3865 * font.c (font_open_entity): Always open a font of manageable
3868 2013-04-26 Paul Eggert <eggert@cs.ucla.edu>
3870 Port better to AIX (Bug#14258).
3871 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3874 2013-04-24 Kenichi Handa <handa@gnu.org>
3876 * coding.c (decode_coding_iso_2022): When an invalid escape
3877 sequence is encountered, reset the invocation and designation
3878 status to the safest one.
3880 2013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3882 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3883 Without this fix, "make distclean" leaves stamp-h1 behind.
3885 2013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3887 * w32fns.c (w32_fullscreen_rect): New function to compute the
3888 window rectangle for the given fullscreen mode.
3889 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3890 longer tunes the window size. This keeps the window's edges flush
3891 with the screen and allows the taskbar to hide itself in fullboth.
3893 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3894 window decorations and uses the entire screen.
3896 * w32term.h (w32_fullscreen_rect) Add prototype.
3897 (struct w32_output): Replace normal_width, normal_height,
3898 normal_top, and normal_left members with a single normal_placement
3900 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3902 (FRAME_NORMAL_PLACEMENT): New macro.
3904 2013-04-16 Juanma Barranquero <lekktu@gmail.com>
3906 * minibuf.c (Ftest_completion): Silence compiler warning.
3908 2013-04-15 Eli Zaretskii <eliz@gnu.org>
3910 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
3913 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3916 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3917 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3918 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3919 parentheses where appropriate.
3921 2013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3923 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3925 2013-04-14 Eli Zaretskii <eliz@gnu.org>
3927 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3928 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3929 Mention in the doc string that setting these variables takes
3930 effect only after a call to set-window-buffer. (Bug#14200)
3932 2013-04-13 Eli Zaretskii <eliz@gnu.org>
3934 * indent.c (Fvertical_motion): Don't consider display strings on
3935 overlay strings as display strings on the buffer position we
3936 started from. This prevents vertical cursor motion from jumping
3937 more than one line when there's an overlay string with a display
3938 property at end of line.
3939 Reported by Karl Chen <Karl.Chen@quarl.org> in
3940 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3942 2013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3944 * window.c (select_window): `record_buffer' even if window is
3945 already selected (bug#14191).
3947 2013-04-11 Eli Zaretskii <eliz@gnu.org>
3949 * window.c (Fwindow_end): Test more flags, including the buffer's
3950 last_overlay_modified flag, to determine whether the window's
3951 display is really up-to-date. Prevents the function from
3952 returning a stale value. (Bug#14170)
3953 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3956 2013-04-10 Eli Zaretskii <eliz@gnu.org>
3958 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
3959 garbaged only if it is not already the top frame on its TTY.
3960 This prevents flickering due to constant redrawing of TTY frames when
3961 there are GUI frames open in the same session. (Bug#13864)
3963 2013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3965 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3966 of marking the idle timers directly.
3968 2013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3970 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3973 2013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3975 * window.c (select_window): Don't record_buffer while the invariant is
3976 temporarily broken (bug#14161).
3978 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3980 2013-04-07 Eli Zaretskii <eliz@gnu.org>
3982 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3984 2013-04-07 Romain Francoise <romain@orebokech.com>
3986 Ignore additional platform-specific ACL errors (Bug#13702).
3987 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3988 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3990 2013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3992 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3995 2013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3997 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3998 This bug was introduced by my 2013-02-25 change that simplified
3999 data_start configuration. Without this change, on GNU/Linux
4000 an Emacs configured with --enable-profiling fails immediately
4001 due to a profiler signal.
4002 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4003 with these flags. On platforms where special flags are needed
4004 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4005 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4006 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4008 2013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4010 Get rid of some platform-specific functions examining window
4011 system and its capabilities. This is a partial rework of the
4013 * lisp.h (have_menus_p): Remove prototype. This function is
4014 replaced with platform-independent window_system_available.
4015 (check_window_system): Move to...
4016 * frame.h (decode_window_system_frame, window_system_available):
4017 ...here, add new prototypes.
4018 * frame.c (window_system_available, decode_window_system_frame):
4020 (check_window_system): Platform-independent now.
4021 * xterm.h (x_in_use): Remove declaration.
4023 * w32term.h (check_x_frame):
4024 * nsterm.h (check_x_frame): Remove prototypes. This function
4025 is replaced with platform-independent decode_window_system_frame.
4026 * msdos.c (have_menus_p): Remove.
4027 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4028 Remove platform-specific functions. Use check_window_system,
4029 decode_window_system_frame and check_ns_display_info where
4030 appropriate. Minor style and comment tweaks.
4031 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4032 (check_x_frame): Likewise.
4033 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4035 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4036 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4037 * xmenu.c, xselect.c: All related users changed.
4039 2013-04-03 Kenichi Handa <handa@gnu.org>
4041 The following changes is to optimize the code for reading UTF-8
4044 * coding.c (check_ascii): Rename from detect_ascii. Return value
4045 changed. Check EOL format. Do not call adjust_coding_eol_type
4047 (check_utf_8): New function.
4048 (adjust_coding_eol_type): Do nothing if already adjusted.
4049 (detect_coding): Compare the return value of check_ascii with
4050 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4051 (decode_coding_gap): Optimize for valid UTF-8.
4053 2013-03-21 Kenichi Handa <handa@gnu.org>
4055 * coding.c (syms_of_coding): Cancel previous change.
4057 * insdel.c (insert_from_gap): Fix previous change.
4059 2013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4061 Consistently use platform-specific function to detect window system.
4062 * lisp.h (check_window_system): New prototype. This function is
4063 going to replace check_x, check_w32 and check_ns.
4064 (have_menus_p): Mention msdos.c in comment.
4065 * fontset.c (check_window_system_func): Remove. Adjust all users.
4066 * fontset.h (check_window_system_func): Remove prototype.
4067 * nsterm.h (check_ns):
4068 * xterm.h (check_x):
4069 * w32term.h (check_w32): Likewise.
4070 * menu.c (Fx_popup_menu): Use check_window_system.
4071 * msdos.c (check_window_system): Define for MS-DOS.
4072 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4073 * w32fns.c (check_window_system): Likewise for MS-Windows.
4074 * xfns.c (check_window_system): Likewise for X.
4075 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4076 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4078 2013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4080 Prefer < to > in range checks such as 0 <= i && i < N.
4081 This makes it easier to visualize quantities on a number line.
4082 This patch doesn't apply to all such range checks,
4083 only to the range checks affected by the 2013-03-24 change.
4084 This patch reverts most of the 2013-03-24 change.
4085 * alloc.c (xpalloc, Fgarbage_collect):
4086 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4087 * character.c (string_escape_byte8):
4088 * charset.c (read_hex):
4089 * data.c (cons_to_unsigned):
4090 * dispnew.c (update_frame_1):
4091 * doc.c (Fsubstitute_command_keys):
4092 * doprnt.c (doprnt):
4093 * editfns.c (hi_time, decode_time_components):
4094 * fileio.c (file_offset):
4095 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4096 * font.c (font_intern_prop):
4097 * frame.c (x_set_alpha):
4098 * gtkutil.c (get_utf8_string):
4099 * indent.c (check_display_width):
4100 * keymap.c (Fkey_description):
4101 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4103 * minibuf.c (read_minibuf_noninteractive):
4104 * process.c (wait_reading_process_output):
4105 * search.c (Freplace_match):
4106 * window.c (get_phys_cursor_glyph):
4107 * xdisp.c (redisplay_internal):
4108 * xsmfns.c (smc_save_yourself_CB):
4109 Prefer < to > for range checks.
4110 * dispnew.c (sit_for): Don't mishandle NaNs.
4111 This fixes a bug introduced in the 2013-03-24 change.
4112 * editfns.c (decode_time_components): Don't hoist comparison.
4113 This fixes another bug introduced in the 2013-03-24 change.
4115 2013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4117 * frame.h (struct frame): Drop scroll_bottom_vpos
4118 member becaue all real users are dead long ago.
4119 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4120 * xdisp.c (redisplay_internal): Adjust user.
4122 2013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4124 * nsmenu.m (showAtX:Y:for:): setLevel to
4125 NSPopUpMenuWindowLevel (Bug#13998).
4127 2013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4129 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4130 (ns_check_pending_open_menu): Declare.
4132 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4133 (x_activate_menubar): Update the menu with title that matches
4134 ns_get_pending_menu_title, and call
4135 ns_check_pending_openmenu (Bug#12698).
4136 (menuWillOpen:): New method.
4137 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4139 * nsterm.m (menu_will_open_state, menu_mouse_point)
4140 (menu_pending_title): New varaibles.
4141 (ns_get_pending_menu_title, ns_check_menu_open)
4142 (ns_check_pending_open_menu): New functions.
4144 2013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4146 * indent.c (current_column_bol_cache): Remove leftover which is not
4147 used in Fmove_to_column any more.
4148 (current_column, scan_for_column): Adjust users.
4149 * keyboard.c (last_point_position_buffer, last_point_position_window):
4150 Remove leftovers which are not used for recording undo any more.
4151 (command_loop_1, syms_of_keyboard): Adjust users.
4152 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4153 redisplay_window any more.
4154 (move_it_to): Adjust user.
4156 2013-03-29 Juanma Barranquero <lekktu@gmail.com>
4158 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4159 Update dependencies.
4161 2013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4163 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4164 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4167 2013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4169 * window.h (struct window): Replace hchild, vchild and buffer slots
4170 with the only contents slot. This is possible because each valid
4171 window may have either the child window (in vertical or horizontal
4172 combination) or buffer to display (for the leaf window). Using that,
4173 a lof of operations to traverse and/or change window hierarchies may
4174 be simplified. New member horizontal is used to distinguish between
4175 horizontal and vertical combinations of internal windows.
4176 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4177 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4178 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4179 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4180 Use contents slot, not buffer, where appropriate.
4181 (wset_combination): New function.
4182 (wset_buffer): Add eassert.
4183 (Fframe_first_window): Simplify the loop reaching first window.
4184 (Fwindow_buffer): Use WINDOW_LEAF_P.
4185 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4186 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4187 (unshow_buffer): Convert initial debugging check to eassert.
4188 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4189 (make_parent_window, window_resize_check, window_resize_apply)
4190 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4191 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4192 Adjust to match struct window changes.
4193 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4194 (mark_window_cursors_off, count_windows, get_leaf_windows)
4195 (foreach_window_1): Simplify the loop.
4196 * alloc.c (mark_object): Do not check for the leaf window because
4197 internal windows has no glyph matrices anyway.
4198 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4199 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4200 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4201 (build_frame_matrix_from_window_tree, mirror_make_current)
4202 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4203 (update_window_tree, set_window_update_flags): Simplify the loop.
4204 (sync_window_with_frame_matrix_rows): Enforce live window.
4205 Use contents slot, not buffer, where appropriate.
4206 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4207 and WINDOW_HORIZONTAL_COMBINATION_P.
4208 (make_frame_visible_1): Simplify the loop.
4209 Use contents slot, not buffer, where appropriate.
4210 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4211 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4212 (expose_window_tree): Likewise.
4213 Use contents slot, not buffer, where appropriate.
4214 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4215 to avoid deleted windows. Use contents slot instead of buffer.
4216 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4217 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4218 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4219 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4221 2013-03-28 Eli Zaretskii <eliz@gnu.org>
4223 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4224 identify the reasons for assertion violations in bug#14062 and
4226 (Fx_show_tip): Fix compilation error under
4227 "--enable-check-lisp-object-type". (Bug#14073)
4229 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4230 Reported by <rzl24ozi@gmail.com>.
4232 2013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4234 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4236 (unwind_with_echo_area_buffer): ...to restore it here.
4237 This is needed to ensure that...
4238 (redisplay_window): ...both window markers are valid here,
4239 which is verified by eassert.
4240 * editfns.c (save_excursion_save): Do not assume that
4241 selected_window always displays the buffer.
4242 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4245 2013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4247 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4250 2013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4252 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4254 2013-03-27 Eli Zaretskii <eliz@gnu.org>
4256 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4257 since MinGW's w32api headers do. This avoids compiler warnings.
4259 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4262 2013-03-26 Eli Zaretskii <eliz@gnu.org>
4264 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4266 2013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4268 * gtkutil.c (style_changed_cb): Check if frame is live and an
4269 X frame (Bug#14038).
4271 2013-03-26 Eli Zaretskii <eliz@gnu.org>
4273 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4274 Define only for _WIN32_WINNT less than 0x0500.
4275 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4277 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4278 see its own definitions of 'struct timeval' and 'struct timezone'.
4280 Fix incompatibilities between MinGW.org and MinGW64 headers.
4281 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4283 * w32.c (REPARSE_DATA_BUFFER): Guard with
4284 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4286 2013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4288 * xterm.c: Include X11/XKBlib.h
4289 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4291 2013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4293 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4295 * blockinput.h (input_blocked_p): Likewise.
4296 * bytecode.c (exec_byte_code): Likewise.
4297 * callproc.c (call_process_kill, call_process_cleanup)
4298 (Fcall_process): Likewise.
4299 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4300 (Fccl_execute_on_string): Likewise.
4301 * character.c (string_escape_byte8): Likewise.
4302 * charset.c (read_hex): Likewise.
4303 * cm.c (calccost): Likewise.
4304 * data.c (cons_to_unsigned): Likewise.
4305 * dired.c (directory_files_internal, file_name_completion):
4307 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4308 (sit_for): Likewise.
4309 * doc.c (Fsubstitute_command_keys): Likewise.
4310 * doprnt.c (doprnt): Likewise.
4311 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4312 * emacsgtkfixed.c: Likewise.
4313 * fileio.c (file_offset, Fwrite_region): Likewise.
4314 * floatfns.c (Fexpt, fmod_float): Likewise.
4315 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4317 * font.c (font_intern_prop): Likewise.
4318 * frame.c (x_set_alpha): Likewise.
4319 * gtkutil.c (get_utf8_string): Likewise.
4320 * indent.c (check_display_width): Likewise.
4321 * intervals.c (create_root_interval, rotate_right, rotate_left)
4322 (split_interval_right, split_interval_left)
4323 (adjust_intervals_for_insertion, delete_node)
4324 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4325 (merge_interval_right, merge_interval_left, copy_intervals)
4326 (set_intervals_multibyte_1): Likewise.
4327 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4328 * keymap.c (Fkey_description): Likewise.
4329 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4330 * lread.c (openp, read_integer, read1, string_to_number):
4332 * menu.c (ensure_menu_items): Likewise.
4333 * minibuf.c (read_minibuf_noninteractive): Likewise.
4334 * print.c (printchar, strout): Likewise.
4335 * process.c (create_process, Faccept_process_output)
4336 (wait_reading_process_output, read_process_output, send_process)
4337 (wait_reading_process_output): Likewise.
4338 * profiler.c (make_log, handle_profiler_signal): Likewise.
4339 * regex.c (re_exec): Likewise.
4340 * regex.h: Likewise.
4341 * search.c (looking_at_1, Freplace_match): Likewise.
4342 * sysdep.c (get_child_status, procfs_ttyname)
4343 (procfs_get_total_memory): Likewise.
4344 * systime.h (EMACS_TIME_VALID_P): Likewise.
4345 * term.c (dissociate_if_controlling_tty): Likewise.
4346 * window.c (get_phys_cursor_glyph): Likewise.
4347 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4348 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4350 * xfns.c (Fx_window_property): Likewise.
4351 * xmenu.c (set_frame_menubar): Likewise.
4352 * xselect.c (x_get_window_property, x_handle_dnd_message):
4354 * xsmfns.c (smc_save_yourself_CB): Likewise.
4355 * xterm.c (x_scroll_bar_set_handle): Likewise.
4357 2013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4359 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4360 to be optional or nil. Adjust comment and convert it to docstring.
4361 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4362 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4364 2013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4366 Static checking by GCC 4.8-20130319.
4367 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4368 * process.c (Fset_process_datagram_address)
4369 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4370 * xdisp.c (get_char_face_and_encoding):
4371 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4372 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4373 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4375 2013-03-24 Ken Brown <kbrown@cornell.edu>
4377 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4378 fix compilation on 64-bit Cygwin, where underscores are not
4379 automatically prepended.
4381 * w32term.c (w32_initialize): Silence compiler warning.
4383 2013-03-23 Eli Zaretskii <eliz@gnu.org>
4385 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4386 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
4387 variables, to save and restore frame dimensions.
4388 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4389 after returning from a 'fullscreen' configuration.
4390 use SendMessage instead of PostMessage to send the SC_RESTORE message,
4391 to avoid races between the main thread and the input thread.
4393 * w32term.h (struct w32_output): New members normal_width,
4394 normal_height, normal_top, normal_left, and prev_fsmode.
4395 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4396 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4399 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4400 'fullscreen' parameter. Always record previous width and height
4401 of the frame, except when switching out of maximized modes, so
4402 that they could be restored correctly, instead of resetting to the
4403 default frame dimensions. Send SC_RESTORE command to the frame,
4404 unless we are going to send SC_MAXIMIZE, to restore the frame
4405 resize hints in the mouse pointer shown by the window manager.
4408 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4410 * lisp.h (get_frame_param): Adjust conditions for prototype
4413 2013-03-22 Ken Brown <kbrown@cornell.edu>
4415 * unexcw.c: Drop unneeded inclusion of w32common.h.
4416 (report_sheap_usage): Declare.
4417 (read_exe_header): Add magic numbers for x86_64.
4418 (fixup_executable): Fix printf format specifier for unsigned long
4421 2013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4423 * frame.h (struct frame): Put menu_bar_window under #ifdef
4424 because this member is not needed when X toolkit is in use.
4425 (fset_menu_bar_window):
4426 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4427 (free_glyphs, update_frame):
4428 * xdisp.c (expose_frame): Likewise.
4429 (display_menu_bar): Likewise. Remove redundant eassert.
4430 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4433 2013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4435 Use functions and constants to manipulate Lisp_Save_Value objects.
4436 This replaces code that used macros and strings and token-pasting.
4437 The change makes the C source a bit easier to follow,
4438 and shrinks the Emacs executable a bit.
4439 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4440 (make_save_value): Change 1st arg from string to enum. All callers
4443 (mark_object): Use if, not #if, for GC_MARK_STACK.
4444 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4445 (XSAVE_OBJECT): Now functions, not macros.
4446 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4447 the constant was never used.
4448 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4449 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4450 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4451 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4453 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4454 type3 with a single member save_type. All uses changed.
4455 (save_type, set_save_pointer, set_save_integer): New functions.
4456 * print.c (PRINTX): Remove.
4458 * alloc.c: Remove redundant static declarations.
4460 2013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4462 * window.h (struct window): Convert left_col, top_line, total_lines
4463 and total_cols from Lisp_Objects to integers. Adjust comments.
4464 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4466 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4467 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4468 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4469 Adjust users where appropriate.
4471 2013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4473 * frame.h (struct frame): Drop resx and resy because the same data is
4474 available from window system-specific output context. Adjust users.
4475 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4476 New functions to provide defaults when no window system available.
4477 (FRAME_RES_X, FRAME_RES_Y): New macros.
4478 (NUMVAL): Move from xdisp.c.
4479 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4480 (Ffont_face_attributes, Fopen_font):
4481 * image.c (gs_load):
4482 * w32font.c (fill_in_logfont):
4483 * xdisp.c (calc_pixel_width_or_height):
4484 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4485 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4487 2013-03-20 Kenichi Handa <handa@gnu.org>
4489 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4490 to 1 (temporary workaround until a bug related to ASCII
4491 optimization is fixed).
4493 2013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4495 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4496 Signal error if window is not internal. Adjust docstring.
4497 (delete_all_child_windows): Use combination_limit to save the buffer.
4498 (Fset_window_configuration): Adjust accordingly.
4499 * print.c (syms_of_print): Initialize debugging output not here...
4500 (init_print_once): ...but in a new function here.
4501 * lisp.h (init_print_once): Add prototype.
4502 * emacs.c (main): Add call to init_print_once. Adjust comments.
4504 2013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4506 * window.c (window_resize_check, window_resize_apply)
4507 (window_from_coordinates, recombine_windows, set_window_buffer)
4508 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4509 (Fsplit_window_internal, Fdelete_window_internal)
4510 (freeze_window_starts): Use bool for booleans.
4511 * window.h (window_frame_coordinates, resize_frame_windows)
4512 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4514 2013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4516 * dispnew.c (bitch_at_user): Use `user-error'.
4518 2013-03-17 Ken Brown <kbrown@cornell.edu>
4520 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4521 as return type of image_background. (Bug#13981)
4522 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4524 2013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4526 * nsterm.m (updateFrameSize:): Change resize increments if needed.
4527 (ns_select): Don't return with result uninitialized.
4529 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4532 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4534 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4535 directories. If filename is nil, get directory name (Bug#13932).
4536 Use getFilename and getDirectory.
4537 (getFilename, getDirectory): New methods for EmacsSavePanel and
4539 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4541 2013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4543 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4545 2013-03-15 Kenichi Handa <handa@gnu.org>
4547 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4548 (adjust_after_replace): Make it back to static. Delete the third
4549 arg text_at_gap_tail. Cancel the code for handling it.
4551 * coding.h (struct coding_system): New member eol_seen.
4553 * coding.c (detect_ascii): New function.
4554 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4555 when the source bytes are actually scanned. On detecting for
4556 coding_category_utf_8_auto, call detect_ascii instead of scanning
4557 source bytes directly.
4558 (produce_chars): Call insert_from_gap with the new arg 0.
4559 (encode_coding): Likewise.
4560 (decode_coding_gap): Control ASCII optimization by the variable
4561 disable_ascii_optimization instead of #ifndef .. #endif.
4562 Deccode EOL format according to coding->eol_seen.
4563 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4566 * lisp.h (adjust_after_replace): Cancel externing it.
4567 (insert_from_gap): Adjust prototype.
4569 2013-03-15 Eli Zaretskii <eliz@gnu.org>
4571 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4572 FULLSCREEN_MAXIMIZED. (Bug#13935)
4574 2013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4576 * region-cache.c (find_cache_boundary, move_cache_gap)
4577 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4578 Simplify debugging check and convert to eassert. Adjust comment.
4579 (pp_cache): Put under ENABLE_CHECKING.
4581 2013-03-14 Eli Zaretskii <eliz@gnu.org>
4583 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4584 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4586 (w32fullscreen_hook): If the frame is visible, reset
4587 f->want_fullscreen flag after changing the frame size. If the
4588 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4591 2013-03-13 Daniel Colascione <dancol@dancol.org>
4593 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4594 too so that these builds can use Cygwin's file conversion
4595 functions. (We've been building and linking cygw32.o all along
4596 and just not using it.)
4598 2013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4600 File synchronization fixes (Bug#13944).
4601 * Makefile.in (LIB_FDATASYNC): New macro.
4603 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4604 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4605 Don't worry about HAVE_FSYNC, since a substitute fsync is
4606 available if the system lacks one.
4607 (Fwrite_regin): Retry fsync if interrupted.
4609 2013-03-13 Eli Zaretskii <eliz@gnu.org>
4611 * w32term.c (w32_read_socket): If the Emacs frame is being
4612 activated, call w32fullscreen_hook, to make sure the new frame
4613 dimensions are in effect. (Bug#13937)
4615 2013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4617 * xdisp.c (init_iterator): Simplify because both character and byte
4618 positions are either specified or -1. Add eassert. Adjust comment.
4619 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4620 character and byte positions can be obtained from marker.
4622 2013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4624 Static checking by Sun C 5.12.
4625 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4626 * bytecode.c (exec_byte_code):
4627 * dispnew.c (init_display):
4629 * fileio.c (Fsubstitute_in_file_name):
4630 * keyboard.c (Fevent_convert_list):
4631 * keymap.c (Fsingle_key_description):
4632 * term.c (maybe_fatal, fatal):
4633 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4634 * xsmfns.c (Fhandle_save_session):
4635 Omit unreachable code.
4636 * keymap.c (map_keymap_char_table_item): Cast void * to
4637 a function pointer type; the C Standard requires this.
4639 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4640 Include <sys/param.h> unconditionally, as that works elsewhere and
4641 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4642 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4645 See ChangeLog.12 for earlier changes.
4651 Copyright (C) 2011-2013 Free Software Foundation, Inc.
4653 This file is part of GNU Emacs.
4655 GNU Emacs is free software: you can redistribute it and/or modify
4656 it under the terms of the GNU General Public License as published by
4657 the Free Software Foundation, either version 3 of the License, or
4658 (at your option) any later version.
4660 GNU Emacs is distributed in the hope that it will be useful,
4661 but WITHOUT ANY WARRANTY; without even the implied warranty of
4662 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4663 GNU General Public License for more details.
4665 You should have received a copy of the GNU General Public License
4666 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.