1 2011-05-03 Paul Eggert <eggert@cs.ucla.edu>
3 Arithmetic overflows now return float rather than wrapping around.
4 * data.c: Include <intprops.h>.
5 (arith_driver): Use floating point if the accumulator would otherwise
6 go out of EMACS_INT range.
7 (arith_driver, Fadd1, Fsub1): Use floating point if the result is
8 out of Emacs fixnum range.
9 * bytecode.c (exec_byte_code): Likewise, for Bsub1, Badd1, Bnegate.
10 * floatfns.c (Fexpt): Likewise.
12 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
14 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
16 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
18 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
20 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
21 * charset.c (Fdefine_charset_internal): Don't initialize
22 charset.code_space[15]. The value was garbage, on hosts with
23 32-bit int (Bug#8600).
25 * lread.c (read_integer): Be more consistent with string-to-number.
26 Use string_to_number to do the actual conversion; this avoids
27 rounding errors and fixes some other screwups. Without this fix,
28 for example, #x1fffffffffffffff was misread as -2305843009213693952.
29 (digit_to_number): Move earlier, for benefit of read_integer.
30 Return -1 if the digit is out of range for the base, -2 if it is
31 not a digit in any supported base. (Bug#8602)
33 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
35 * dispnew.c (scrolling_window): Return 1 if we scrolled,
36 to match comment at start of function. This also removes a
37 GCC warning about overflow in a 32+64-bit port.
39 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
41 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
42 Reported by Stefan Monnier in
43 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
44 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
45 SYMBOLP-guarded XSYMBOL, not XPNTR.
47 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
48 (EMACS_UINTPTR): Likewise, with uintptr_t.
50 * lisp.h: Prefer 64-bit EMACS_INT if available.
51 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
52 on 32-bit hosts that have 64-bit int, so that they can access
55 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
57 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
58 This removes an assumption that EMACS_INT and long are the same
59 width as pointers. The assumption is true for Emacs porting targets
60 now, but we want to make other targets possible.
61 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
62 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
63 In the rest of the code, change types of integers that hold casted
64 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
65 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
66 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
67 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
68 No need to cast type when ORing.
69 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
70 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
71 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
72 assume EMACS_INT is the same width as char *.
73 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
74 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
75 Remove no-longer-needed casts.
76 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
77 (xg_tool_bar_help_callback, xg_make_tool_item):
78 Use EMACS_INTPTR to hold an integer
79 that will be cast to void *; this can avoid a GCC warning
80 if EMACS_INT is not the same width as void *.
81 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
82 * xdisp.c (display_echo_area_1, resize_mini_window_1):
83 (current_message_1, set_message_1):
84 Use a local to convert to proper width without a cast.
85 * xmenu.c (dialog_selection_callback): Likewise.
87 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
88 Also, don't assume VALBITS / RAND_BITS is less than 5,
89 and don't rely on undefined behavior when shifting a 1 left into
91 * lisp.h (get_random): Change signature to match.
93 * lread.c (hash_string): Use size_t, not int, for hash computation.
94 Normally we prefer signed values; but hashing is special, because
95 it's better to use unsigned division on hash table sizes so that
96 the remainder is nonnegative. Also, size_t is the natural width
97 for hashing into memory. The previous code used 'int', which doesn't
98 retain enough info to hash well into very large tables.
99 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
101 * dbusbind.c: Don't possibly lose pointer info when converting.
102 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
103 Use XPNTR rather than XHASH, so that the high-order bits of
104 the pointer aren't lost when converting through void *.
106 * eval.c (Fautoload): Don't double-shift a pointer.
108 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
110 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
112 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
114 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
116 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
117 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
118 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
119 (gnutls_global_initialized, Qgnutls_bootprop_priority)
120 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
121 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
122 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
123 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
124 (Qgnutls_bootprop_callbacks_verify): Make static.
126 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
128 * callproc.c: Indentation fixup.
130 * sysdep.c (wait_for_termination_1): Make static.
131 (wait_for_termination, interruptible_wait_for_termination): Move
132 after wait_for_termination_1.
134 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
136 * sysdep.c (interruptible_wait_for_termination): New function
137 which is like wait_for_termination, but allows keyboard
140 * callproc.c (Fcall_process): Add (:file "file") as an option for
142 (Fcall_process_region): Ditto.
144 2011-04-30 Eli Zaretskii <eliz@gnu.org>
146 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
147 rather than `XVECTOR (FOO)->size'.
149 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
150 inttypes.h, as a gnulib replacement is used if it not available in
153 2011-04-21 Eli Zaretskii <eliz@gnu.org>
155 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
156 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
157 of MOST_POSITIVE_FIXNUM. (Bug#8528)
159 * coding.c (coding_alloc_by_realloc): Error out if destination
160 will grow beyond MOST_POSITIVE_FIXNUM.
161 (decode_coding_emacs_mule): Abort if there isn't enough place in
162 charbuf for the composition carryover bytes. Reserve an extra
163 space for up to 2 characters produced in a loop.
164 (decode_coding_iso_2022): Abort if there isn't enough place in
165 charbuf for the composition carryover bytes.
167 2011-04-21 Eli Zaretskii <eliz@gnu.org>
169 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
170 aborting when %lld or %lll format is passed.
171 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
172 %llo or %llx format is passed. (Bug#8545)
174 * window.c (window_scroll_line_based): Use a marker instead of
175 simple variables to record original value of point. (Bug#7952)
177 * doprnt.c (doprnt): Fix the case where a multibyte sequence
178 produced by %s or %c overflows available buffer space. (Bug#8545)
180 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
182 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
183 (SIZE_MAX): Move defn after all includes, as they might #define it.
185 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
187 * w32.c (init_environment): Warn about defaulting HOME to C:\.
189 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
191 * keyboard.c (Qdelayed_warnings_hook): Define.
192 (command_loop_1): Run `delayed-warnings-hook'
193 if Vdelayed_warnings_list is non-nil.
194 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
195 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
197 2011-04-28 Eli Zaretskii <eliz@gnu.org>
199 * doprnt.c (doprnt): Don't return value smaller than the buffer
200 size if the message was truncated. (Bug#8545).
202 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
204 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
205 (Fx_window_property): #if-0 the whole functions, not just the bodies.
207 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
209 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
211 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
213 * makefile.w32-in: Update dependencies.
215 2011-04-27 Eli Zaretskii <eliz@gnu.org>
217 Improve `doprnt' and its usage. (Bug#8545)
218 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
219 `format_end'. Remove support for %l as a conversion specifier.
220 Don't use xrealloc. Improve diagnostics when the %l size modifier
221 is used. Update the commentary.
223 * eval.c (verror): Simplify calculation of size_t.
225 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
228 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
230 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
233 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
235 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
236 This makes this file independent of the recent pseudovector change.
238 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
240 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
242 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
243 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
245 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
247 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
248 GCC 4.6.0 optimizes based on type-based alias analysis. For
249 example, if b is of type struct buffer * and v of type struct
250 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
251 != &v->size, and therefore "v->size = 1; b->size = 2; return
252 v->size;" must therefore return 1. This assumption is incorrect
253 for Emacs, since it type-puns struct Lisp_Vector * with many other
254 types. To fix this problem, this patch adds a new type struct
255 vectorlike_header that documents the constraints on layout of vectors
256 and pseudovectors, and helps optimizing compilers not get fooled
257 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
258 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
259 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
261 (XSETPVECTYPE): Rewrite in terms of new macro.
262 (XSETPVECTYPESIZE): New macro, specifying both type and size.
263 This is a bit clearer, and further avoids the possibility of
264 undesirable aliasing.
265 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
266 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
267 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
268 since Lisp_Subr is a special case (no "next" field).
269 (ASIZE): Now uses header.size rather than size. All
270 previous uses of XVECTOR (foo)->size replaced to use this macro,
271 to avoid the hassle of writing XVECTOR (foo)->header.size.
272 (struct vectorlike_header): New type.
273 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
274 object, to help avoid aliasing.
275 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
276 (SUBRP): Likewise, since Lisp_Subr is a special case.
277 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
278 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
279 (struct Lisp_Hash_Table): Combine first two members into a single
280 struct vectorlike_header member. All uses of "size" and "next" members
281 changed to be "header.size" and "header.next".
282 * buffer.h (struct buffer): Likewise.
283 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
284 * frame.h (struct frame): Likewise.
285 * process.h (struct Lisp_Process): Likewise.
286 * termhooks.h (struct terminal): Likewise.
287 * window.c (struct save_window_data, struct saved_window): Likewise.
288 * window.h (struct window): Likewise.
289 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
290 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
291 * buffer.c (init_buffer_once): Likewise.
292 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
294 * process.c (Fformat_network_address): Use local var for size,
297 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
299 Make the Lisp reader and string-to-float more consistent (Bug#8525)
300 * data.c (atof): Remove decl; no longer used or needed.
301 (digit_to_number): Move to lread.c.
302 (Fstring_to_number): Use new string_to_number function, to be
303 consistent with how the Lisp reader treats infinities and NaNs.
304 Do not assume that floating-point numbers represent EMACS_INT
305 without losing information; this is not true on most 64-bit hosts.
306 Avoid double-rounding errors, by insisting on integers when
307 parsing non-base-10 numbers, as the documentation specifies.
308 * lisp.h (string_to_number): New decl, replacing ...
309 (isfloat_string): Remove.
310 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
311 (read1): Do not accept +. and -. as integers; this
312 appears to have been a coding error. Similarly, do not accept
313 strings like +-1e0 as floating point numbers. Do not report
314 overflow for integer overflows unless the base is not 10 which
315 means we have no simple and reliable way to continue.
316 Break out the floating-point parsing into a new
317 function string_to_number, so that Fstring_to_number parses
318 floating point numbers consistently with the Lisp reader.
319 (digit_to_number): Moved here from data.c. Make it static inline.
320 (E_CHAR, EXP_INT): Remove, replacing with ...
321 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
322 (string_to_number): New function, replacing isfloat_string.
323 This function checks for valid syntax and produces the resulting
324 Lisp float number too. Rework it so that string-to-number
325 no longer mishandles examples like "1.0e+". Use strtoumax,
326 so that overflow for non-base-10 numbers is reported only when
327 there's no portable and simple way to convert to floating point.
329 * textprop.c (set_text_properties_1): Rewrite for clarity,
330 and to avoid GCC warning about integer overflow.
332 * intervals.h (struct interval): Use EMACS_INT for members
333 where EMACS_UINT might cause problems. See
334 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
335 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
336 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
338 (offset_intervals): Tell GCC not to worry about length overflow
339 when negating a negative length.
341 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
342 (overrun_check_free): Likewise.
344 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
345 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
348 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
349 (gnutls_make_error): Rename local to avoid shadowing.
350 (gnutls_emacs_global_deinit): ifdef out; not used.
351 (Fgnutls_boot): Use const for pointer to readonly storage.
352 Comment out unused local. Fix pointer signedness problems.
354 * lread.c (openp): Don't stuff size_t into an 'int'.
355 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
356 about possible signed overflow.
358 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
359 (GDK_KEY_g): Don't define if already defined.
360 (xg_prepare_tooltip): Avoid pointer signedness problem.
361 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
363 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
364 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
366 * xfns.c (Fx_window_property): Simplify a bit,
367 to make a bit faster and to avoid GCC 4.6.0 warning.
368 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
370 * fns.c (internal_equal): Don't assume size_t fits in int.
372 * alloc.c (compact_small_strings): Tighten assertion a little.
374 Replace pEd with more-general pI, and fix some printf arg casts.
375 * lisp.h (pI): New macro, generalizing old pEd macro to other
376 conversion specifiers. For example, use "...%"pI"d..." rather
378 (pEd): Remove. All uses replaced with similar uses of pI.
379 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
380 * alloc.c (check_pure_size): Don't overflow by converting size to int.
381 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
382 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
383 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
384 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
385 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
387 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
388 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
389 * print.c (safe_debug_print, print_object): Likewise.
390 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
392 Use pI instead of if-then-else-abort. Use %p to avoid casts,
393 avoiding the 0 flag, which is not portable.
394 * process.c (Fmake_network_process): Use pI to avoid cast.
395 * region-cache.c (pp_cache): Likewise.
396 * xdisp.c (decode_mode_spec): Likewise.
397 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
398 behavior on 64-bit hosts with printf arg.
399 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
400 (x_stop_queuing_selection_requests): Likewise.
401 (x_get_window_property): Don't truncate byte count to an 'int'
404 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
405 here, since it parses constructs like leading '-' and spaces,
406 which are not wanted; and it overflows with large numbers.
407 Instead, simply match F[0-9]+, which is what is wanted anyway.
409 * alloc.c: Remove unportable assumptions about struct layout.
410 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
411 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
412 (allocate_vectorlike, make_pure_vector): Use the new macros,
413 plus offsetof, to remove unportable assumptions about struct layout.
414 These assumptions hold on all porting targets that I know of, but
415 they are not guaranteed, they're easy to remove, and removing them
416 makes further changes easier.
418 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
419 This doesn't fix a bug but makes the code clearer.
420 (string_overrun_cookie): Now const. Use initializers that
421 don't formally overflow signed char, to avoid warnings.
422 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
423 can cause Emacs to crash when string overrun checking is enabled.
424 (allocate_buffer): Don't assume sizeof (struct buffer) is a
425 multiple of sizeof (EMACS_INT); it need not be, if
426 alignof(EMACS_INT) < sizeof (EMACS_INT).
427 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
429 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
431 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
433 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
435 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
436 supposed to be handshaking. (Bug#8556)
437 Reported by Paul Eggert <eggert@cs.ucla.edu>.
439 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
441 * lisp.h (Qdebug): List symbol.
442 * eval.c (Qdebug): Restore global linkage.
443 * keyboard.c (debug-on-event): New variable.
444 (handle_user_signal): Break into debugger when debug-on-event
445 matches the current signal symbol.
447 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
449 * alloc.c (check_sblock, check_string_bytes)
450 (check_string_free_list): Convert to standard C.
452 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
454 * w32.c (emacs_gnutls_push): Fix typo.
456 2011-04-25 Eli Zaretskii <eliz@gnu.org>
458 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
459 "cast to pointer from integer of different size".
461 Improve doprnt and its use in verror. (Bug#8545)
462 * doprnt.c (doprnt): Document the set of format control sequences
463 supported by the function. Use SAFE_ALLOCA instead of always
466 * eval.c (verror): Don't limit the buffer size at size_max-1, that
467 is one byte too soon. Don't use xrealloc; instead xfree and
470 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
472 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
475 * gnutls.c: Renamed global_initialized to
476 gnutls_global_initialized. Added internals for the
477 :verify-hostname-error, :verify-error, and :verify-flags
478 parameters of `gnutls-boot' and documented those parameters in the
479 docstring. Start callback support.
480 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
481 unless a fatal error occured. Call gnutls_alert_send_appropriate
482 on error. Return error code.
483 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
484 (emacs_gnutls_read): Likewise.
485 (Fgnutls_boot): Return handshake error code.
486 (emacs_gnutls_handle_error): New function.
487 (wsaerror_to_errno): Likewise.
489 * w32.h (emacs_gnutls_pull): Add prototype.
490 (emacs_gnutls_push): Likewise.
492 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
493 (emacs_gnutls_push): Likewise.
495 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
497 * process.c (wait_reading_process_output): Check if GnuTLS
498 buffered some data internally if no FDs are set for TLS
501 * makefile.w32-in (OBJ2): Add gnutls.$(O).
502 (LIBS): Link to USER_LIBS.
503 ($(BLD)/gnutls.$(0)): New target.
505 2011-04-24 Eli Zaretskii <eliz@gnu.org>
507 * xdisp.c (handle_single_display_spec): Rename the
508 display_replaced_before_p argument into display_replaced_p, to
509 make it consistent with the commentary. Fix typos in the
512 * textprop.c (syms_of_textprop): Remove dead code.
513 (copy_text_properties): Delete obsolete commentary about an
514 interface that was deleted long ago. Fix typos in the description
517 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
518 to changes in oldXMenu/XMenu.h from 2011-04-16.
519 <menu_help_message, prev_menu_help_message>: Constify.
520 (IT_menu_make_room): menu->help_text is now `const char **';
523 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
524 to changes in oldXMenu/XMenu.h from 2011-04-16.
525 (struct XMenu): Declare `help_text' `const char **'.
527 * xfaces.c <Qunspecified>: Make extern again.
529 * syntax.c: Include sys/types.h before including regex.h, as
532 * doc.c (get_doc_string): Improve the format passed to `error'.
534 * doprnt.c (doprnt): Improve commentary.
536 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
538 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
541 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
542 changes in globals.h immediately force recompilation.
543 (TAGS): Depend on $(CURDIR)/m/intel386.h and
544 $(CURDIR)/s/ms-w32.h.
545 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
547 * character.c (Fchar_direction): Function deleted.
548 (syms_of_character): Don't defsubr it.
549 <char-direction-table>: Deleted.
551 2011-04-23 Eli Zaretskii <eliz@gnu.org>
553 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
554 * doprnt.c: Include limits.h.
555 (SIZE_MAX): New macro.
556 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
557 local variables are now size_t instead of int or unsigned.
558 Improve overflow protection. Support `l' modifier for integer
559 conversions. Support %l conversion. Don't assume an EMACS_INT
560 argument for integer conversions and for %c.
562 * lisp.h (doprnt): Restore prototype.
564 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
567 * Makefile.in (base_obj): Add back doprnt.o.
569 * deps.mk (doprnt.o): Add back prerequisites.
570 (callint.o): Depend on character.h.
572 * eval.c (internal_lisp_condition_case): Include the handler
573 representation in the error message.
574 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
575 when breaking from the loop.
577 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
579 * callint.c (Fcall_interactively): When displaying error message
580 about invalid control letter, pass the character's codepoint, not
581 a pointer to its multibyte form. Improve display of the character
582 in octal and display also its hex code.
584 * character.c (char_string): Use %x to display the (unsigned)
585 codepoint of an invalid character, to avoid displaying a bogus
588 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
589 `error', not SYMBOL_NAME itself.
591 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
592 character arguments to `error'.
594 * charset.c (check_iso_charset_parameter): Fix incorrect argument
595 to `error' in error message about FINAL_CHAR argument. Make sure
596 FINAL_CHAR is a character, and use %c when it is passed as
599 2011-04-23 Eli Zaretskii <eliz@gnu.org>
601 * s/ms-w32.h (localtime): Redirect to sys_localtime.
603 * w32.c: Include <time.h>.
604 (sys_localtime): New function.
606 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
608 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
610 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
612 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
614 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
617 2011-04-19 Eli Zaretskii <eliz@gnu.org>
619 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
620 gl_state.e_property when gl_state.object is Qt.
622 * insdel.c (make_gap_larger): Remove limitation of buffer size
625 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
627 * xdisp.c (lookup_glyphless_char_display)
628 (produce_glyphless_glyph): Handle cons cell entry in
629 glyphless-char-display.
630 (Vglyphless_char_display): Document it.
632 * term.c (produce_glyphless_glyph): Handle cons cell entry in
633 glyphless-char-display.
635 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
637 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
639 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
641 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
642 definition for no-X builds.
644 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
646 Static checks with GCC 4.6.0 and non-default toolkits.
648 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
650 * process.c (keyboard_bit_set): Define only if SIGIO.
651 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
652 (send_process): Repair possible setjmp clobbering.
654 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
656 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
658 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
660 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
661 Define only if needed.
663 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
664 by pacifying GCC about it. Maybe it's time to retire it?
665 * xfaces.c (USG, __TIMEVAL__): Likewise.
667 * dispextern.h (struct redisplay_interface): Rename param
669 * termhooks.h (struct terminal): Likewise.
670 * xterm.c (xembed_send_message): Likewise.
672 * insdel.c (make_gap_smaller): Define only if
673 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
675 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
678 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
679 so that we aren't warned about unused symbols.
681 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
683 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
685 * xfns.c (x_real_positions): Mark locals as initialized.
687 * xmenu.c (xmenu_show): Don't use uninitialized vars.
689 * xterm.c: Fix problems found by static analysis with other toolkits.
690 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
691 (x_dispatch_event): Declare static if USE_GTK, and
692 define if USE_GTK || USE_X_TOOLKIT.
693 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
694 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
695 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
696 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
698 * xmenu.c (menu_help_callback): Pointer type fixes.
699 Use const pointers when pointing at readonly data. Avoid pointer
701 (FALSE): Remove unused macro.
702 (update_frame_menubar): Remove unused decl.
704 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
706 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
707 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
708 (single_menu_item): Rename local to avoid shadowing.
710 * keyboard.c (make_lispy_event): Remove unused local var.
712 * frame.c, frame.h (x_get_resource_string): Bring this back, but
713 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
715 * bitmaps: Change bitmaps from unsigned char back to the X11
716 compatible char. Avoid the old compiler warnings about
717 out-of-range initializers by using, for example, '\xab' rather
720 * xgselect.c (xgselect_initialize): Check vs interface
721 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
723 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
725 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
728 * fns.c (vector): Remove; this old hack is no longer needed.
730 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
732 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
734 * xrdb.c (x_load_resources): Omit unused local.
736 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
737 (x_window): Rename locals to avoid shadowing.
738 (USG): Use the kludged USG macro, to pacify gcc.
740 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
741 (x_term_init): Remove local to avoid shadowing.
743 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
745 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
746 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
748 2011-04-16 Eli Zaretskii <eliz@gnu.org>
750 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
752 Fix regex.c, syntax.c and friends for buffers > 2GB.
753 * syntax.h (struct gl_state_s): Declare character position members
756 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
758 * textprop.c (verify_interval_modification, interval_of): Declare
761 * intervals.c (adjust_intervals_for_insertion): Declare arguments
764 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
766 * indent.c (Fvertical_motion): Local variable it_start is now
769 * regex.c (re_match, re_match_2, re_match_2_internal)
770 (bcmp_translate, regcomp, regexec, print_double_string)
771 (group_in_compile_stack, re_search, re_search_2, regex_compile)
772 (re_compile_pattern, re_exec): Declare arguments and local
773 variables `size_t' and `ssize_t' and return values `regoff_t', as
775 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
776 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
777 <compile_stack_type>: `size' and `avail' are now `size_t'.
779 * regex.h <regoff_t>: Use ssize_t, not int.
780 (re_search, re_search_2, re_match, re_match_2): Arguments that
781 specify buffer/string position and length are now ssize_t and
782 size_t. Return type is regoff_t.
784 2011-04-16 Ben Key <bkey76@gmail.com>
786 * nsfont.m: Fixed bugs in ns_get_family and
787 ns_descriptor_to_entity that were caused by using free to
788 deallocate memory blocks that were allocated by xmalloc (via
789 xstrdup). This caused Emacs to crash when compiled with
790 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
791 --enable-checking=xmallocoverrun). xfree is now used to
792 deallocate these memory blocks.
794 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
796 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
798 emacs_write: Accept and return EMACS_INT for sizes.
799 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
801 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
802 Accept and return EMACS_INT.
803 (emacs_gnutls_write): Return the number of bytes written on
805 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
806 (emacs_read, emacs_write): Remove check for negative size, as the
807 Emacs source code has been audited now.
808 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
809 (emacs_read, emacs_write): Use it.
810 * process.c (send_process): Adjust to the new signatures of
811 emacs_write and emacs_gnutls_write. Do not attempt to store
812 a byte offset into an 'int'; it might overflow.
813 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
815 * sound.c: Don't assume sizes fit in 'int'.
816 (struct sound_device.period_size, alsa_period_size):
817 Return EMACS_INT, not int.
818 (struct sound_device.write, vox_write, alsa_write):
819 Accept EMACS_INT, not int.
820 (wav_play, au_play): Use EMACS_INT to store sizes and to
821 record read return values.
823 2011-04-15 Ben Key <bkey76@gmail.com>
825 * keyboard.c (Qundefined): Don't declare static since it is used
827 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
828 static since they are used in nsfont.m.
830 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
832 * process.c (Qprocessp): Don't declare static.
833 * lisp.h (Qprocessp): Declare again.
835 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
837 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
839 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
841 Improve C-level modularity by making more things 'static'.
843 Don't publish debugger-only interfaces to other modules.
844 * lisp.h (safe_debug_print, debug_output_compilation_hack):
845 (verify_bytepos, count_markers): Move decls to the only modules
847 * region-cache.h (pp_cache): Likewise.
848 * window.h (check_all_windows): Likewise.
849 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
851 * sysdep.c (croak): Now static, if
852 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
853 * syssignal.h (croak): Declare only if not static.
855 * alloc.c (refill_memory_reserve): Now static if
856 !defined REL_ALLOC || defined SYSTEM_MALLOC.
857 * lisp.h (refill_memory_reserve): Declare only if not static.
859 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
860 Define only if USE_LUCID.
862 * xrdb.c (x_customization_string, x_rm_string): Now static.
864 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
865 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
867 * xdisp.c (draw_row_with_mouse_face): Now static.
868 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
870 * window.h (check_all_windows): Mark externally visible.
872 * window.c (window_deletion_count): Now static.
874 * undo.c: Make symbols static if they're not exported.
875 (last_undo_buffer, last_boundary_position, pending_boundary):
878 * textprop.c (interval_insert_behind_hooks): Now static.
879 (interval_insert_in_front_hooks): Likewise.
881 * term.c: Make symbols static if they're not exported.
882 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
883 (max_frame_lines, tty_set_terminal_modes):
884 (tty_reset_terminal_modes, tty_turn_off_highlight):
885 (get_tty_terminal): Now static.
886 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
887 * termhooks.h (term_mouse_moveto): Do not declare if
889 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
890 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
892 * sysdep.c: Make symbols static if they're not exported.
893 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
895 (sigprocmask_set, full_mask): Remove; unused.
896 (wait_debugging): Mark as visible.
897 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
898 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
900 * syntax.c (syntax_temp): Define only if !__GNUC__.
902 * sound.c (current_sound_device, current_sound): Now static.
904 * search.c (searchbufs, searchbuf_head): Now static.
906 * scroll.c (scroll_cost): Remove; unused.
907 * dispextern.h (scroll_cost): Remove decl.
909 * region-cache.h (pp_cache): Mark as externally visible.
911 * process.c: Make symbols static if they're not exported.
912 (process_tick, update_tick, create_process, chan_process):
913 (Vprocess_alist, proc_buffered_char, datagram_access):
914 (fd_callback_data, send_process_frame, process_sent_to): Now static.
915 (deactivate_process): Mark defn as static, as well as decl.
916 * lisp.h (create_process): Remove decl.
917 * process.h (chan_process, Vprocess_alist): Remove decls.
919 * print.c: Make symbols static if they're not exported.
920 (print_depth, new_backquote_output, being_printed, print_buffer):
921 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
922 (print_interval, print_number_index, initial_stderr_stream):
924 * lisp.h (Fprinc): Remove decl.
925 (debug_output_compilation_hack): Mark as externally visible.
927 * sysdep.c (croak): Move decl from here to syssignal.h.
928 * syssignal.h (croak): Put it here, so the API can be checked when
929 'croak' is called from dissociate_if_controlling_tty.
931 * minibuf.c: Make symbols static if they're not exported.
932 (minibuf_save_list, choose_minibuf_frame): Now static.
933 * lisp.h (choose_minibuf_frame): Remove decl.
935 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
937 * lread.c: Make symbols static if they're not exported.
938 (read_objects, initial_obarray, oblookup_last_bucket_number):
940 (make_symbol): Remove; unused.
941 * lisp.h (initial_obarray, make_symbol): Remove decls.
943 * keyboard.c: Make symbols static if they're not exported.
944 (single_kboard, recent_keys_index, total_keys, recent_keys):
945 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
946 (this_single_command_key_start, echoing, last_auto_save):
947 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
948 (command_loop, echo_now, keyboard_init_hook, help_char_p):
949 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
950 (Vlispy_mouse_stem, double_click_count):
952 (force_auto_save_soon): Define only if SIGDANGER.
953 (ignore_mouse_drag_p): Now static if
954 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
955 (print_help): Remove; unused.
956 (stop_character, last_timer_event): Mark as externally visible.
957 * keyboard.h (ignore_mouse_drag_p): Declare only if
958 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
959 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
960 * lisp.h (echoing): Remove decl.
961 (force_auto_save_soon): Declare only if SIGDANGER.
962 * xdisp.c (redisplay_window): Simplify code, to make it more
963 obvious that ignore_mouse_drag_p is not accessed if !defined
964 USE_GTK && !defined HAVE_NS.
966 * intervals.c: Make symbols static if they're not exported.
967 (merge_properties_sticky, merge_interval_right, delete_interval):
969 * intervals.h (merge_interval_right, delete_interval): Remove decls.
971 * insdel.c: Make symbols static if they're not exported.
972 However, leave prepare_to_modify_buffer alone. It's never
973 called from outside this function, but that appears to be a bug.
974 (combine_after_change_list, combine_after_change_buffer):
975 (adjust_after_replace, signal_before_change): Now static.
976 (adjust_after_replace_noundo): Remove; unused.
977 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
978 (signal_before_change): Remove decls.
980 * indent.c (val_compute_motion, val_vmotion): Now static.
982 * image.c: Make symbols static if they're not exported.
983 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
985 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
986 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
988 * fringe.c (standard_bitmaps): Now static.
989 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
991 * frame.c: Make symbols static if they're not exported.
992 (x_report_frame_params, make_terminal_frame): Now static.
993 (get_frame_param): Now static, unless HAVE_NS.
994 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
995 (x_get_resource_string): Remove; not used.
996 * frame.h (make_terminal_frame, x_report_frame_params):
997 (x_get_resource_string); Remove decls.
998 (x_fullscreen_adjust): Declare only if WINDOWSNT.
999 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1001 * font.c, fontset.c: Make symbols static if they're not exported.
1002 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1003 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1004 * font.c (font_close_object): Now static.
1005 * font.h (font_close_object): Remove.
1006 * fontset.c (FONTSET_OBJLIST): Remove.
1007 (free_realized_fontset) #if-0 the body, which does nothing.
1008 (face_suitable_for_char_p): #if-0, as it's never called.
1009 * fontset.h (face_suitable_for_char_p): Remove decl.
1010 * xfaces.c (face_at_string_position): Use
1011 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1012 since 0 is always ASCII.
1014 * fns.c (weak_hash_tables): Now static.
1016 * fileio.c: Make symbols static if they're not exported.
1017 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1018 (Vwrite_region_annotation_buffers): Now static.
1020 * eval.c: Make symbols static if they're not exported.
1021 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1022 * lisp.h (backtrace_list): Remove decl.
1024 * emacs.c: Make symbols static if they're not exported.
1025 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1026 (fatal_error_code, fatal_error_signal_hook, standard_args):
1028 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1029 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1030 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1031 * lisp.h (fatal_error_signal_hook): Remove decl.
1032 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1034 * editfns.c: Move a (normally-unused) function to its only use.
1035 * editfns.c, lisp.h (get_operating_system_release): Remove.
1036 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1037 worth the hassle of breaking this out.
1039 * xterm.c: Make symbols static if they're not exported.
1040 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1041 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1042 (x_destroy_window, x_delete_display):
1044 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1045 (x_mouse_leave): Remove; unused.
1046 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1047 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1048 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1050 (x_mouse_leave): Declare only if WINDOWSNT.
1051 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1052 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1055 * ftxfont.c: Make symbols static if they're not exported.
1056 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1058 * font.h (ftxfont_driver): Likewise.
1060 * xfns.c: Make symbols static if they're not exported.
1061 (x_last_font_name, x_display_info_for_name):
1062 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1063 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1064 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1065 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1066 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1067 (last_show_tip_args): Now static.
1068 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1069 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1070 (x_screen_planes): Remove; unused.
1071 * dispextern.h (x_screen_planes): Remove decl.
1073 * dispnew.c: Make symbols static if they're not exported.
1074 * dispextern.h (redraw_garbaged_frames, scrolling):
1075 (increment_row_positions): Remove.
1076 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1077 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1079 (redraw_garbaged_frames): Remove; unused.
1081 * xfaces.c: Make symbols static if they're not exported.
1082 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1084 * xterm.h (defined_color): Remove decls.
1085 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1086 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1087 (menu_face_changed_default, defined_color, free_realized_face):
1088 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1089 (ascii_face_of_lisp_face): Remove; unused.
1091 * xdisp.c: Make symbols static if they're not exported.
1092 * dispextern.h (scratch_glyph_row, window_box_edges):
1093 (glyph_to_pixel_coords, set_cursor_from_row):
1094 (get_next_display_element, set_iterator_to_next):
1095 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1096 (show_mouse_face): Remove decls
1097 * frame.h (message_buf_print): Likewise.
1098 * lisp.h (pop_message, set_message, check_point_in_composition):
1100 * xterm.h (set_vertical_scroll_bar): Likewise.
1101 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1102 (message_buf_print, scratch_glyph_row, displayed_buffer):
1103 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1104 (get_next_display_element, show_mouse_face, window_box_edges):
1105 (frame_to_window_pixel_xy, check_point_in_composition):
1106 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1107 (glyph_to_pixel_coords): Remove; unused.
1109 * dired.c (file_name_completion): Now static.
1111 * dbusbind.c (xd_in_read_queued_messages): Now static.
1113 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1114 * data.c (circular_list_error): Remove.
1116 * commands.h (last_point_position, last_point_position_buffer):
1117 (last_point_position_window): Remove decls.
1118 * keyboard.c: Make these variables static.
1120 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1122 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1123 (iso_code_class, detect_coding, code_convert_region): Now static.
1124 (encode_coding_gap): Remove; unused.
1126 * chartab.c (chartab_chars, chartab_bits): Now static.
1128 * charset.h (charset_iso_8859_1): Remove decl.
1129 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1132 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1133 * ccl.c (Vccl_program_table): Now static.
1134 (check_ccl_update): Remove; unused.
1136 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1137 * category.h: ... from here.
1138 * category.c (check_category_table, set_category_set): Now static.
1140 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1141 * lisp.h: Remove these decls.
1143 * buffer.c (buffer_count): Remove unused var.
1145 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1146 so that it's not optimized away.
1147 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1148 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1149 exported only to the debugger.
1151 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1152 * atimer.h (run_all_atimers): Removed; not exported.
1154 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1155 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1156 was inaccessible from Lisp.
1157 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1158 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1160 alloc.c: Import and export fewer symbols, and remove unused items.
1161 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1163 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1164 it's not optimized away by whole-program optimization.
1165 (message_enable_multibyte, free_misc): Remove.
1166 (catchlist, handlerlist, mark_backtrace):
1167 Declare only if BYTE_MARK_STACK.
1168 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1169 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1170 (message_enable_multibyte): Remove decl.
1171 (free_misc, interval_free_list, float_block, float_block_index):
1172 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1173 (cons_free_list, last_marked_index):
1175 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1176 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1177 (mark_backtrace): Define only if BYTE_MARK_STACK.
1178 * xdisp.c (message_enable_multibyte): Now static.
1180 Declare Lisp_Object Q* variables to be 'static' if not exported.
1181 This makes it easier for human readers (and static analyzers)
1182 to see whether these variables are used from other modules.
1183 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1184 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1185 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1186 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1187 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1188 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1189 * xmenu.c, xselect.c:
1190 Declare Q* vars static if they are not used in other modules.
1191 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1192 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1193 Remove decls of unexported vars.
1194 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1196 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1198 Make Emacs functions such as Fatom 'static' by default.
1199 This makes it easier for human readers (and static analyzers)
1200 to see whether these functions can be called from other modules.
1201 DEFUN now defines a static function. To make the function external
1202 so that it can be used in other C modules, use the new macro DEFUE.
1203 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1204 (Finit_image_library):
1205 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1206 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1207 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1208 Remove decls, since these functions are now static.
1209 (Funintern, Fget_internal_run_time): New decls, since these functions
1210 were already external.
1212 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1213 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1214 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1215 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1216 * keyboard.c, keymap.c, lread.c:
1217 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1218 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1219 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1220 Mark functions with DEFUE instead of DEFUN,
1221 if they are used in other modules.
1222 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1223 decls for now-static functions.
1224 * buffer.h (Fdelete_overlay): Remove decl.
1225 * callproc.c (Fgetenv_internal): Mark as internal.
1226 * composite.c (Fremove_list_of_text_properties): Remove decl.
1227 (Fcomposition_get_gstring): New forward static decl.
1228 * composite.h (Fcomposite_get_gstring): Remove decl.
1229 * dired.c (Ffile_attributes): New forward static decl.
1230 * doc.c (Fdocumntation_property): New forward static decl.
1231 * eval.c (Ffetch_bytecode): New forward static decl.
1232 (Funintern): Remove extern decl; now in .h file where it belongs.
1233 * fileio.c (Fmake_symbolic_link): New forward static decl.
1234 * image.c (Finit_image_library): New forward static decl.
1235 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1236 * intervals.h (Fprevious_property_change):
1237 (Fremove_list_of_text_properties): Remove decls.
1238 * keyboard.c (Fthis_command_keys): Remove decl.
1239 (Fcommand_execute): New forward static decl.
1240 * keymap.c (Flookup_key): New forward static decl.
1241 (Fcopy_keymap): Now static.
1242 * keymap.h (Flookup_key): Remove decl.
1243 * process.c (Fget_process): New forward static decl.
1244 (Fprocess_datagram_address): Mark as internal.
1245 * syntax.c (Fsyntax_table_p): New forward static decl.
1246 (skip_chars): Remove duplicate decl.
1247 * textprop.c (Fprevious_property_change): New forward static decl.
1248 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1250 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1251 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1253 * editfns.c (Fformat): Remove unreachable code.
1255 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1257 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1260 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1262 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1263 when at ZV. (Bug#8487)
1265 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1267 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1269 * keyboard.c (parse_tool_bar_item): Likewise.
1270 * sound.c (sound_cleanup, alsa_close): Likewise.
1271 * termcap.c (tgetent): Likewise.
1272 * xfns.c (x_default_font_parameter): Likewise.
1273 * xsettings.c (read_and_apply_settings): Likewise.
1275 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1276 (overrun_check_free): Protoize.
1278 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1280 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1281 since callers should never pass a negative size.
1282 Change the signature to match that of plain 'read' and 'write'; see
1283 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1284 * lisp.h: Update prototypes of emacs_write and emacs_read.
1286 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1288 * xdisp.c (redisplay_window): Don't try to determine the character
1289 position of the scroll margin if the window start point w->startp
1290 is outside the buffer's accessible region. (Bug#8468)
1292 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1294 Fix write-region and its subroutines for buffers > 2GB.
1295 * fileio.c (a_write, e_write): Modify declaration of arguments and
1296 local variables to support buffers larger than 2GB.
1297 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1299 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1300 argument, local variables, and return value.
1302 * lisp.h: Update prototypes of emacs_write and emacs_read.
1304 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1306 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1308 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1310 Fix more problems found by GCC 4.6.0's static checks.
1312 * xdisp.c (vmessage): Use a better test for character truncation.
1314 * charset.c (load_charset_map): <, not <=, for optimization,
1315 and to avoid potential problems with integer overflow.
1316 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1317 * casetab.c (set_identity, shuffle): Likewise.
1318 * editfns.c (Fformat): Likewise.
1319 * syntax.c (skip_chars): Likewise.
1321 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1322 This also lets GCC 4.6.0 generate slightly better loop code.
1324 * callint.c (Fcall_interactively): <, not <=, for optimization.
1325 (Fcall_interactively): Count the number of arguments produced,
1326 not the number of arguments given. This is simpler and lets GCC
1327 4.6.0 generate slightly better code.
1329 * ftfont.c: Distingish more carefully between FcChar8 and char.
1330 The previous code passed unsigned char * to a functions like
1331 strlen and xstrcasecmp that expect char *, which does not
1332 conform to the C standard.
1333 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1334 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1335 char * when the C standard requires it.
1337 * keyboard.c (read_char): Remove unused var.
1339 * eval.c: Port to Windows vsnprintf (Bug#8435).
1341 (SIZE_MAX): Define if the headers do not.
1342 (verror): Do not give up if vsnprintf returns a negative count.
1343 Instead, grow the buffer. This ports to Windows vsnprintf, which
1344 does not conform to C99. Problem reported by Eli Zaretskii.
1345 Also, simplify the allocation scheme, by avoiding the need for
1346 calling realloc, and removing the ALLOCATED variable.
1348 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1350 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1351 But keep the doprint source code for now, as we might revamp it
1352 and use it again (Bug#8435).
1353 * lisp.h (doprnt): Remove.
1354 * Makefile.in (base_obj): Remove doprnt.o.
1355 * deps.mk (doprnt.o): Remove.
1357 error: Print 32- and 64-bit integers portably (Bug#8435).
1358 Without this change, on typical 64-bit hosts error ("...%d...", N)
1359 was used to print both 32- and 64-bit integers N, which relied on
1361 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1363 * lisp.h (error, verror): Mark as printf-like functions.
1364 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1365 Report overflow in size calculations when allocating printf buffer.
1366 Do not truncate output string at its first null byte.
1367 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1368 Truncate the output at a character boundary, since vsnprintf does not
1370 * charset.c (check_iso_charset_parameter): Convert internal
1371 character to string before calling 'error', since %c now has the
1373 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1374 overflow when computing char to be passed to 'error'. Do not
1375 pass Lisp_Object to 'error'; pass the integer instead.
1376 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1377 formatted with plain %d.
1379 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1381 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1383 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1385 * xterm.c (x_catch_errors): Remove duplicate declaration.
1387 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1389 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1391 2011-04-10 Jim Meyering <meyering@redhat.com>
1393 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1394 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1395 return ssize_t not "int", and use size_t as the buffer length.
1396 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1397 * gnutls.h: Update declarations.
1398 * process.c (read_process_output): Use ssize_t, to match.
1399 (send_process): Likewise.
1401 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1403 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1405 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1407 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1408 unsigned char, to match FcChar8 type definition.
1410 * xterm.c (handle_one_xevent):
1411 * xmenu.c (create_and_show_popup_menu):
1412 * xselect.c (x_decline_selection_request)
1413 (x_reply_selection_request): Avoid type-punned deref of X events.
1415 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1417 Fix some uses of `int' instead of EMACS_INT.
1418 * search.c (string_match_1, fast_string_match)
1419 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1420 (scan_buffer, find_next_newline_no_quit)
1421 (find_before_next_newline, search_command, Freplace_match)
1422 (Fmatch_data): Make some `int' variables be EMACS_INT.
1424 * xdisp.c (display_count_lines): 3rd argument and return value now
1425 EMACS_INT. All callers changed.
1426 (pint2hrstr): Last argument is now EMACS_INT.
1428 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1429 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1430 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1431 (decode_coding_utf_16, decode_coding_emacs_mule)
1432 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1433 (decode_coding_ccl, decode_coding_charset)
1434 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1435 (decode_coding_iso_2022, decode_coding_emacs_mule)
1436 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1437 <char_offset, last_offset>: Declare EMACS_INT.
1438 (encode_coding_utf_8, encode_coding_utf_16)
1439 (encode_coding_emacs_mule, encode_invocation_designation)
1440 (encode_designation_at_bol, encode_coding_iso_2022)
1441 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1442 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1444 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1445 (encode_invocation_designation): Last argument P_NCHARS is now
1447 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1448 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1450 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1453 * ccl.c (Fccl_execute_on_string): Declare some variables
1456 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1458 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1460 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1462 * process.c (Fformat_network_address): Doc fix.
1464 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1466 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1468 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1470 * keyboard.c (read_char): Call Lisp function help-form-show,
1471 instead of using internal_with_output_to_temp_buffer.
1472 (Qhelp_form_show): New var.
1473 (syms_of_keyboard): Use DEFSYM macro.
1475 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1477 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1479 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1481 * process.c (Flist_processes): Removed to Lisp.
1482 (list_processes_1): Deleted.
1484 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1486 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1488 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1490 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1492 Fix more problems found by GCC 4.6.0's static checks.
1494 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1496 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1498 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1500 * xdisp.c (vmessage): Mark as a printf-like function.
1502 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1504 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1506 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1507 printf-like functions.
1508 (tiff_load): Add casts to remove these marks before passing them
1509 to system-supplied API.
1511 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1513 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1514 This avoids several warnings with gcc -Wstrict-overflow.
1515 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1516 directly, rather than having caller test rule sign. This avoids
1517 some unnecessary tests.
1518 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1519 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1520 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1522 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1523 (xfont_open): Avoid unnecessary tests.
1525 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1527 * composite.h, composite.c (composition_gstring_put_cache):
1528 Use EMACS_INT, not int, for length.
1530 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1531 breaking out part of COMPOSITION_DECODE_RULE.
1532 (COMPOSITION_DECODE_RULE): Use it.
1533 * composite.c (get_composition_id): Remove unused local vars,
1534 by using the new macro.
1536 * textprop.c (set_text_properties_1): Change while to do-while,
1537 since the condition is always true at first.
1539 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1540 (interval_deletion_adjustment): Return unsigned value.
1543 * process.c (list_processes_1, create_pty, read_process_output):
1544 (exec_sentinel): Remove vars that were set but not used.
1545 (create_pty): Remove unnecessary "volatile"s.
1546 (Fnetwork_interface_info): Avoid possibility of int overflow.
1547 (read_process_output): Do adaptive read buffering even if carryover.
1548 (read_process_output): Simplify nbytes computation if buffered.
1550 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1552 * syntax.c (scan_words): Remove var that was set but not used.
1553 (update_syntax_table): Use unsigned instead of int.
1555 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1556 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1557 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1559 * print.c (print_error_message): Avoid int overflow.
1561 * font.c (font_list_entities): Redo for clarity,
1562 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1564 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1565 (font_score): Avoid potential overflow in diff calculation.
1567 * fns.c (substring_both): Remove var that is set but not used.
1568 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1570 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1572 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1573 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1574 can always succeed if overflow has undefined behavior.
1576 * search.c (boyer_moore, wordify): Remove vars set but not used.
1577 (wordify): Omit three unnecessary tests.
1579 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1580 All callers changed. This avoids the need for an unused var.
1582 * casefiddle.c (casify_region): Remove var that is set but not used.
1584 * dired.c (file_name_completion): Remove var that is set but not used.
1586 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1588 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1589 (Finsert_file_contents): Remove unnecessary code checking fd.
1591 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1592 Check for integer overflow on size calculations.
1594 * buffer.c (Fprevious_overlay_change): Remove var that is set
1597 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1598 Remove vars that are set but not used.
1599 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1600 (timer_check_2): Mark vars as initialized.
1602 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1604 * image.c (lookup_image): Remove var that is set but not used.
1605 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1607 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1608 that are set but not used.
1610 * xfns.c (make_invisible_cursor): Don't return garbage
1611 if XCreateBitmapFromData fails (Bug#8410).
1613 * xselect.c (x_get_local_selection, x_handle_property_notify):
1614 Remove vars that are set but not used.
1616 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1617 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1619 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1620 Remove var that is set but not used.
1621 (scroll_bar_windows_size): Now size_t, not int.
1622 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1625 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1626 (map_tty_color) [!defined MSDOS]: Likewise.
1628 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1630 * coding.c: Remove vars that are set but not used.
1631 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1632 All callers changed.
1633 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1634 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1635 (decode_coding_charset): Remove vars that are set but not used.
1637 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1638 that is set but not used.
1640 * print.c (print_object): Remove var that is set but not used.
1642 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1643 The gnulib version avoids calling malloc in the usual case,
1644 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1645 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1646 * filelock.c (current_lock_owner): Likewise.
1647 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1648 * sysdep.c: Include allocator.h, careadlinkat.h.
1649 (emacs_no_realloc_allocator): New static constant.
1650 (emacs_readlink): New function.
1651 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1652 ../lib/careadlinkat.h.
1654 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1656 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1657 first non-nil return value).
1659 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1661 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1662 if not defined (Bug#8403).
1664 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1666 * xdisp.c (display_count_lines): Remove parameter `start',
1667 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1668 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1669 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1670 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1671 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1672 and thereabouts. All callers changed.
1673 (get_per_char_metric): Remove parameter `f', unused since
1674 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1676 2011-04-02 Jim Meyering <meyering@redhat.com>
1678 do not dereference NULL upon failed strdup
1679 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1680 (ns_get_family): Likewise.
1682 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1684 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1686 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1688 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1691 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1693 Add lexical binding.
1695 * window.c (Ftemp_output_buffer_show): New fun.
1696 (Fsave_window_excursion):
1697 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1699 * lread.c (lisp_file_lexically_bound_p): New function.
1700 (Fload): Bind Qlexical_binding.
1701 (readevalloop): Remove `evalfun' arg.
1702 Bind Qinternal_interpreter_environment.
1703 (Feval_buffer): Bind Qlexical_binding.
1704 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1706 (syms_of_lread): Declare `lexical-binding'.
1708 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1710 * keyboard.c (eval_dyn): New fun.
1711 (menu_item_eval_property): Use it.
1713 * image.c (parse_image_spec): Use Ffunctionp.
1715 * fns.c (concat, mapcar1): Accept byte-code-functions.
1717 * eval.c (Fsetq): Handle lexical vars.
1718 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1719 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1720 (FletX, Flet): Obey lexical binding.
1721 (Fcommandp): Handle closures.
1722 (Feval): New `lexical' arg.
1723 (eval_sub): New function extracted from Feval. Use it almost
1724 everywhere where Feval was used. Look up vars in lexical env.
1726 (Ffunctionp): Move from subr.el.
1727 (Ffuncall): Handle closures.
1728 (apply_lambda): Remove `eval_flags'.
1729 (funcall_lambda): Handle closures and new byte-code-functions.
1730 (Fspecial_variable_p): New function.
1731 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1732 but without exporting it to Lisp.
1734 * doc.c (Fdocumentation, store_function_docstring):
1735 * data.c (Finteractive_form): Handle closures.
1737 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1740 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1742 (exec_byte_code): New function extracted from Fbyte_code to handle new
1743 calling convention for byte-code-functions. Add new byte-codes.
1745 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1747 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1749 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1751 * xdisp.c (redisplay_internal): Fix prototype.
1753 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1755 * xdisp.c (SCROLL_LIMIT): New macro.
1756 (try_scrolling): Use it when setting scroll_limit. Limit
1757 scrolling to 100 screen lines.
1758 (redisplay_window): Even when falling back on "recentering",
1759 position point in the window according to scroll-conservatively,
1760 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1762 (try_scrolling): When point is above the window, allow searching
1763 as far as scroll_max, or one screenful, to compute vertical
1764 distance from PT to the scroll margin position. This prevents
1765 try_scrolling from unnecessarily failing when
1766 scroll-conservatively is set to a value slightly larger than the
1767 window height. Clean up the case of PT below the margin at bottom
1768 of window: scroll_max can no longer be INT_MAX. When aggressive
1769 scrolling is in use, don't let point enter the opposite scroll
1770 margin as result of the scroll.
1771 (syms_of_xdisp) <scroll-conservatively>: Document the
1772 threshold of 100 lines for never-recentering scrolling.
1774 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1776 * dispextern.h (move_it_by_lines):
1777 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1778 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1779 (message_log_check_duplicate): Remove parameters `prev_bol' and
1780 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1781 (redisplay_internal): Remove parameter `preserve_echo_area',
1782 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1784 * indent.c (Fvertical_motion):
1785 * window.c (window_scroll_pixel_based, Frecenter):
1786 Don't pass `need_y_p' to `move_it_by_lines'.
1788 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1790 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1791 steal a few bits to be more compact.
1792 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1793 Remove unneeded casts.
1795 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1797 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1799 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1800 binding" message (bug#7967).
1802 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1804 Fix more problems found by GCC 4.6.0's static checks.
1806 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1807 Remove unused local var.
1809 * editfns.c (Fmessage_box): Remove unused local var.
1811 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1812 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1813 Omit unused local vars.
1814 * window.c (shrink_windows): Omit unused local var.
1815 * menu.c (digest_single_submenu): Omit unused local var.
1816 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1817 Omit unused local var.
1819 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1820 Don't assume string length fits in int.
1821 (keyremap_step, read_key_sequence): Use size_t for sizes.
1822 (read_key_sequence): Don't check last_real_key_start redundantly.
1824 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1825 instead of alloca (Bug#8344).
1827 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1828 (Fbacktrace_frame): Don't assume nframes fits in int.
1830 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1832 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1835 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1837 * cm.c (calccost): Turn while-do into do-while, for clarity.
1839 * keyboard.c (syms_of_keyboard): Use the same style as later
1840 in this function when indexing through an array. This also
1841 works around GCC bug 48267.
1843 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1845 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1847 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1848 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1850 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1851 This avoids undefined behavior on integer overflow, and is a bit
1852 more convenient anyway since it is compared to a size_t variable.
1854 Variadic C functions now count arguments with size_t, not int.
1855 This avoids an unnecessary limitation on 64-bit machines, which
1856 caused (substring ...) to crash on large vectors (Bug#8344).
1857 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1858 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1859 All variadic functions and their callers changed accordingly.
1860 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1861 * data.c (arith_driver, float_arith_driver): Likewise.
1862 * editfns.c (general_insert_function): Likewise.
1863 * eval.c (struct backtrace.nargs, interactive_p)
1864 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1865 (funcall_lambda, mark_backtrace): Likewise.
1866 * fns.c (concat): Likewise.
1867 * frame.c (x_set_frame_parameters): Likewise.
1868 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1869 0 if not found, not -1. All callers changed.
1871 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1872 (stack_copy_size): Now size_t, not int.
1873 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1875 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1877 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1878 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1879 All callers changed.
1881 * lisp.h (multibyte_char_to_unibyte):
1882 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1883 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1884 * character.h (CHAR_TO_BYTE8):
1885 * cmds.c (internal_self_insert):
1886 * editfns.c (general_insert_function):
1887 * keymap.c (push_key_description):
1888 * search.c (Freplace_match):
1889 * xdisp.c (message_dolog, set_message_1): All callers changed.
1891 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1893 * keyboard.c (safe_run_hook_funcall): New function.
1894 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1895 don't set the hook to nil, but remove the offending function instead.
1896 (Qcommand_hook_internal): Remove, unused.
1897 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1898 Vcommand_hook_internal.
1900 * eval.c (enum run_hooks_condition): Remove.
1901 (funcall_nil, funcall_not): New functions.
1902 (run_hook_with_args): Call each function through a `funcall' argument.
1903 Remove `cond' argument, now redundant.
1904 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1905 (Frun_hook_with_args_until_failure): Adjust accordingly.
1906 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1908 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1910 * dispextern.h (string_buffer_position): Remove declaration.
1912 * print.c (strout): Remove parameter `multibyte', unused since
1913 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1915 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1916 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1917 All callers changed.
1919 * w32.c (_wsa_errlist): Use braces for struct initializers.
1921 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1922 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1923 All callers changed.
1924 (string_buffer_position): Likewise. Also, make static (it's never
1925 used outside xdisp.c).
1926 (cursor_row_p): Remove parameter `w', unused since
1927 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1928 (decode_mode_spec): Remove parameter `precision', introduced during
1929 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1930 All callers changed.
1932 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1934 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1936 2011-03-27 Anders Lindgren <andlind@gmail.com>
1938 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1939 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1940 (ns_update_auto_hide_menu_bar): New functions.
1941 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1942 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1943 ns_constrain_all_frames.
1944 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1945 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1947 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1949 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1951 2011-03-27 Glenn Morris <rgm@gnu.org>
1953 * syssignal.h: Replace RETSIGTYPE with void.
1954 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1955 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1956 Replace SIGTYPE with void everywhere.
1957 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1958 * s/template.h (SIGTYPE): Remove commented out definition.
1960 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1962 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1963 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1965 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1967 * w32.c (read_unc_volume): Use parameter `henum', instead of
1968 global variable `wget_enum_handle'.
1970 * keymap.c (describe_vector): Remove parameters `indices' and
1971 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1972 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1974 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1976 * keyboard.c (timer_check): Remove parameter `do_it_now',
1977 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1978 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1979 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1981 * keyboard.c (read_char):
1982 * w32menu.c (w32_menu_display_help):
1983 * xmenu.c (show_help_event, menu_help_callback):
1984 Adjust calls to `show_help_echo'.
1986 * gtkutil.c (xg_maybe_add_timer):
1987 * keyboard.c (readable_events):
1988 * process.c (wait_reading_process_output):
1989 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1991 * insdel.c (adjust_markers_gap_motion):
1992 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1993 (gap_left, gap_right): Don't call it.
1995 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1997 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1998 incurred during fontification.
2000 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2002 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2003 (DEFVAR_PER_BUFFER): Don't pass it.
2005 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2006 (scrolling_window): Don't pass it.
2008 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2010 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2012 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2014 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2015 of variables specific to SELinux and computation of `encoded_absname'.
2017 * image.c (XPutPixel): Remove unused variable `height'.
2019 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2021 * unexw32.c (get_section_info): Remove unused variable `section'.
2023 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2024 (system_process_attributes): Remove unused variable `sess'.
2025 (sys_read): Remove unused variable `err'.
2027 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2028 (w32_wnd_proc): Remove unused variable `isdead'.
2029 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2030 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2031 (x_create_tip_frame): Remove unused variable `tem'.
2033 * w32inevt.c (w32_console_read_socket):
2034 Remove unused variable `no_events'.
2036 * w32term.c (x_draw_composite_glyph_string_foreground):
2037 Remove unused variable `width'.
2039 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2041 * w32term.c (x_set_glyph_string_clipping):
2042 Don't pass uninitialized region to CombineRgn.
2044 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2046 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2047 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2048 (Fx_close_connection): Remove unused variable `i'.
2050 * w32font.c (w32font_draw): Return number of glyphs.
2051 (w32font_open_internal): Remove unused variable `i'.
2052 (w32font_driver): Add missing initializer.
2054 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2055 (fill_in_menu): Remove unused variable `items_added'.
2057 * w32term.c (last_mouse_press_frame): Remove static global variable.
2058 (w32_clip_to_row): Remove unused variable `f'.
2059 (x_delete_terminal): Remove unused variable `i'.
2061 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2062 (NOTHING): Remove unused static global variable.
2063 (uniscribe_check_otf): Remove unused variable `table'.
2064 (uniscribe_font_driver): Add missing initializers.
2066 2011-03-23 Julien Danjou <julien@danjou.info>
2068 * term.c (Fsuspend_tty, Fresume_tty):
2069 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2070 * window.c (temp_output_buffer_show):
2071 * insdel.c (signal_before_change):
2072 * frame.c (Fhandle_switch_frame):
2073 * fileio.c (Fdo_auto_save):
2074 * emacs.c (Fkill_emacs):
2075 * editfns.c (save_excursion_restore):
2076 * cmds.c (internal_self_insert):
2077 * callint.c (Fcall_interactively):
2078 * buffer.c (Fkill_all_local_variables):
2079 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2081 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2082 unconditionnaly since it does the check itself.
2084 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2086 Fix more problems found by GCC 4.5.2's static checks.
2088 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2089 the first time through the loop, since we know p0 < p1 then.
2090 This also avoids a gcc -Wstrict-overflow warning.
2092 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2093 leading to a memory leak, possible in functions like
2094 load_charset_map_from_file that can allocate an unbounded number
2095 of objects (Bug#8318).
2097 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2098 that could (at least in theory) be that large.
2100 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2101 This is less likely to overflow, and avoids undefined behavior if
2102 overflow does occur. All callers changed. Use strtoul to scan
2103 for the unsigned long integer.
2104 (pint2hrstr): Simplify and tune code slightly.
2105 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2107 * scroll.c (do_scrolling): Work around GCC bug 48228.
2108 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2110 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2111 This also avoids a warning with gcc -Wstrict-overflow.
2112 (validate_x_resource_name): Simplify count usage.
2113 This also avoids a warning with gcc -Wstrict-overflow.
2115 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2118 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2120 * process.c (Fmake_network_process): Use socklen_t, not int,
2121 where POSIX says socklen_t is required in portable programs.
2122 This fixes a porting bug on hosts like 64-bit HP-UX, where
2123 socklen_t is wider than int (Bug#8277).
2124 (Fmake_network_process, server_accept_connection):
2125 (wait_reading_process_output, read_process_output):
2128 * process.c: Rename or move locals to avoid shadowing.
2129 (list_processes_1, Fmake_network_process):
2130 (read_process_output_error_handler, exec_sentinel_error_handler):
2131 Rename or move locals.
2132 (Fmake_network_process): Define label "retry_connect" only if needed.
2133 (Fnetwork_interface_info): Fix pointer signedness.
2134 (process_send_signal): Add cast to avoid pointer signedness problem.
2135 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2136 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2138 Make tparam.h and terminfo.c consistent.
2139 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2140 Include tparam.h instead, since it declares them.
2141 * cm.h (PC): Remove extern decl; tparam.h now does this.
2142 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2143 * terminfo.c: Include tparam.h, to check interfaces.
2144 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2145 (tparam): Adjust signature to match interface in tparam.h;
2146 this removes some undefined behavior. Check that outstring and len
2147 are zero, which they always are with Emacs.
2148 * tparam.h (PC, BC, UP): New extern decls.
2150 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2151 (xftfont_open): Rename locals to avoid shadowing.
2153 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2154 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2155 (OTF_TAG_SYM): Omit macro if not needed.
2156 (ftfont_list): Remove unused local.
2157 (get_adstyle_property, ftfont_pattern_entity):
2158 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2159 Rename locals to avoid shadowing.
2161 * xfont.c (xfont_list_family): Mark var as initialized.
2163 * xml.c (make_dom): Now static.
2165 * composite.c (composition_compute_stop_pos): Rename local to
2167 (composition_reseat_it): Remove unused locals.
2168 (find_automatic_composition, composition_adjust_point): Likewise.
2169 (composition_update_it): Mark var as initialized.
2170 (find_automatic_composition): Mark vars as initialized,
2171 with a FIXME (Bug#8290).
2173 character.h: Rename locals to avoid shadowing.
2174 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2175 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2176 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2177 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2180 * textprop.c (property_change_between_p): Remove; unused.
2182 * intervals.c (interval_start_pos): Now static.
2184 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2186 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2187 Rename locals to avoid shadowing.
2189 * sound.c (wav_play, au_play, Fplay_sound_internal):
2190 Fix pointer signedness.
2191 (alsa_choose_format): Remove unused local var.
2192 (wav_play): Initialize a variable to 0, to prevent undefined
2193 behavior (Bug#8278).
2195 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2197 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2199 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2200 clobbering (Bug#8298).
2201 * sysdep.c (sys_subshell): Likewise.
2202 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2204 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2205 This should get cleaned up, so that child_setup has the
2206 same signature on all platforms.
2208 * callproc.c (call_process_cleanup): Now static.
2209 (relocate_fd): Rename locals to avoid shadowing.
2211 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2213 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2214 not to be necessary, and produces flickering.
2216 2011-03-20 Glenn Morris <rgm@gnu.org>
2218 * config.in: Remove file.
2220 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2222 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2223 are now in src/globals.h.
2224 (syms_of_minibuf): Remove spurious & from previous change.
2226 2011-03-20 Leo <sdl.web@gmail.com>
2228 * minibuf.c (completing-read-function): New variable.
2229 (completing-read-default): Rename from completing-read.
2230 (completing-read): Call completing-read-function.
2232 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2234 * xfaces.c (Fx_load_color_file):
2235 Read color file from absolute filename (bug#8250).
2237 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2239 * makefile.w32-in: Update dependencies.
2241 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2243 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2245 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2247 Fix more problems found by GCC 4.5.2's static checks.
2249 * process.c (make_serial_process_unwind, send_process_trap):
2250 (sigchld_handler): Now static.
2252 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2253 That way, the code declares only the vars that it needs.
2254 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2255 * s/cygwin.h (PTY_ITERATION): Likewise.
2256 * s/darwin.h (PTY_ITERATION): Likewise.
2257 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2259 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2260 * process.c (allocate_pty): Don't declare stb unless it's needed.
2262 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2263 (CONSTANTLIM): Remove; unused.
2264 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2265 Define only if needed.
2267 * unexelf.c (unexec): Name an expression,
2268 to avoid gcc -Wbad-function-cast warning.
2269 Use a different way to cause a compilation error if anyone uses
2270 n rather than nn, a way that does not involve shadowing.
2271 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2273 * deps.mk (unexalpha.o): Remove; unused.
2275 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2276 * unexec.h: New file.
2277 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2278 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2280 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2281 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2282 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2283 Change as necessary to match prototype in unexec.h.
2285 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2287 (back_comment, skip_chars): Mark vars as initialized.
2289 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2290 Rename locals to avoid shadowing.
2292 * lread.c (read1): Rewrite so as not to use empty "else".
2293 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2295 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2297 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2298 warning when compiling print.c.
2300 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2301 instead of using an uninitialized var.
2302 (font_sort_entities): Mark var as initialized.
2304 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2306 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2307 pointers to constants.
2308 (font_parse_fcname): Remove unused vars.
2309 (font_delete_unmatched): Now static.
2310 (font_get_spec): Remove; unused.
2311 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2312 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2313 Rename or move locals to avoid shadowing.
2315 * fns.c (require_nesting_list, require_unwind): Now static.
2316 (Ffillarray): Rename locals to avoid shadowing.
2318 * floatfns.c (domain_error2): Define only if needed.
2319 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2321 * alloc.c (mark_backtrace): Move decl from here ...
2322 * lisp.h: ... to here, so that it can be checked.
2324 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2325 (Fdefvar): Rewrite so as not to use empty "else".
2326 (lisp_indirect_variable): Name an expression,
2327 to avoid gcc -Wbad-function-cast warning.
2328 (Fdefvar): Rename locals to avoid shadowing.
2330 * callint.c (quotify_arg, quotify_args): Now static.
2331 (Fcall_interactively): Rename locals to avoid shadowing.
2332 Use const pointer when appropriate.
2334 * lisp.h (get_system_name, get_operating_system_release):
2335 Move decls here, to check interfaces.
2336 * process.c (get_operating_system_release): Move decl to lisp.h.
2337 * xrdb.c (get_system_name): Likewise.
2338 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2339 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2340 some of which prompt warnings from gcc -Wbad-function-cast.
2341 (Fformat_time_string, Fencode_time, Finsert_char):
2342 (Ftranslate_region_internal, Fformat):
2343 Rename or remove local vars to avoid shadowing.
2344 (Ftranslate_region_internal): Mark var as initialized.
2346 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2349 * lisp.h (eassert): Check that the argument compiles, even if
2350 ENABLE_CHECKING is not defined.
2352 * data.c (Findirect_variable): Name an expression, to avoid
2353 gcc -Wbad-function-cast warning.
2354 (default_value, arithcompare, arith_driver, arith_error): Now static.
2355 (store_symval_forwarding): Rename local to avoid shadowing.
2356 (Fmake_variable_buffer_local, Fmake_local_variable):
2357 Mark variables as initialized.
2358 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2360 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2361 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2362 Rename locals to avoid shadowing.
2363 (mark_stack): Move local variables into the #ifdef region where
2365 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2366 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2368 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2369 (GC_STRING_CHARS): Remove; not used.
2370 (Fmemory_limit): Cast sbrk's returned value to char *.
2372 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2373 avoids undefined behavior in theory.
2375 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2377 Use functions, not macros, for up- and down-casing (Bug#8254).
2378 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2379 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2380 to use the following functions instead of these macros.
2381 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2382 EMACS_INT, since callers assume the returned value fits in int.
2383 (upcase1): Likewise, for UPCASE_TABLE.
2384 (uppercasep, lowercasep, upcase): New static inline functions.
2385 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2386 the race-condition problem in the old DOWNCASE.
2388 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2389 Rename locals to avoid shadowing.
2390 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2391 (regex_compile, re_search_2, re_match_2_internal):
2392 Remove unused local vars.
2393 (FREE_VAR): Rewrite so as not to use empty "else",
2394 which gcc can warn about.
2395 (regex_compile, re_match_2_internal): Mark locals as initialized.
2396 (RETALLOC_IF): Define only if needed.
2397 (WORDCHAR_P): Likewise. This one is never needed, but is used
2398 only in a comment talking about a compiler bug, so put inside
2399 the #if 0 of that comment.
2400 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2401 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2404 * search.c (boyer_moore): Rename locals to avoid shadowing.
2405 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2406 (PREV_CHAR_BOUNDARY): Likewise.
2408 * search.c (simple_search): Remove unused var.
2410 * dired.c (compile_pattern): Move decl from here ...
2411 * lisp.h: ... to here, so that it can be checked.
2412 (struct re_registers): New forward decl.
2414 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2416 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2418 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2419 Rename locals to avoid shadowing.
2420 (Fvertical_motion): Mark locals as initialized.
2422 * casefiddle.c (casify_object, casify_region): Now static.
2423 (casify_region): Mark local as initialized.
2425 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2427 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2428 New macros, so that the caller can use some names other than
2429 gcpro1, gcpro2, etc.
2430 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2432 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2433 argument, for consistency with GCPRO2_VAR, etc: it is now the
2434 prefix of the variable, not the variable itself. All uses
2436 * dired.c (directory_files_internal, file_name_completion):
2437 Rename locals to avoid shadowing.
2439 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2440 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2441 dired.c's scmp function, had undefined behavior.
2442 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2443 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2444 * buffer.h: ... to here, because these macros use current_buffer,
2445 and the new implementation with inline functions needs to have
2446 current_buffer in scope now, rather than later when the macros
2448 (downcase, upcase1): New static inline functions.
2449 (DOWNCASE, UPCASE1): Reimplement using these functions.
2450 This avoids undefined behavior in expressions like
2451 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2452 from race conditions in accessing the global variables
2453 case_temp1 and case_temp2.
2454 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2455 * lisp.h (case_temp1, case_temp2): Remove their decls.
2456 * character.h (ASCII_CHAR_P): Move from here ...
2457 * lisp.h: ... to here, so that the inline functions mentioned
2460 * dired.c (directory_files_internal_unwind): Now static.
2462 * fileio.c (file_name_as_directory, directory_file_name):
2463 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2465 (file_name_as_directory): Use const pointers when appropriate.
2466 (Fexpand_file_name): Likewise. In particular, newdir might
2467 point at constant storage, so make it a const pointer.
2468 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2469 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2471 (Fset_file_times, Finsert_file_contents, auto_save_error):
2472 Rename locals to avoid shadowing.
2474 * minibuf.c (choose_minibuf_frame_1): Now static.
2475 (Ftry_completion, Fall_completions): Rename or remove locals
2478 * marker.c (bytepos_to_charpos): Remove; unused.
2480 * lisp.h (verify_bytepos, count_markers): New decls,
2481 so that gcc does not warn that these functions aren't declared.
2483 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2484 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2485 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2486 (copy_text): Remove unused local var.
2488 * filelock.c (within_one_second): Now static.
2489 (lock_file_1): Rename local to avoid shadowing.
2491 * buffer.c (fix_overlays_before): Mark locals as initialized.
2492 (fix_start_end_in_overlays): Likewise. This function should be
2493 simplified by using pointers-to-pointers, but that's a different
2495 (switch_to_buffer_1): Now static.
2496 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2497 (report_overlay_modification): Rename locals to avoid shadowing.
2499 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2500 Fix pointer signedness issue.
2501 (sys_subshell): Mark local as volatile if checking for lint,
2502 to suppress a gcc -Wclobbered warning that does not seem to be right.
2503 (MAXPATHLEN): Define only if needed.
2505 * process.c (serial_open, serial_configure): Move decls from here ...
2506 * systty.h: ... to here, so that they can be checked.
2508 * fns.c (get_random, seed_random): Move extern decls from here ...
2509 * lisp.h: ... to here, so that they can be checked.
2511 * sysdep.c (reset_io): Now static.
2512 (wait_for_termination_signal): Remove; unused.
2514 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2515 (copy_keymap_item, append_key, push_text_char_description):
2517 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2518 (DENSE_TABLE_SIZE): Remove; unused.
2519 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2520 (describe_map_tree):
2521 Rename locals to avoid shadowing.
2523 * keyboard.c: Declare functions static if they are not used elsewhere.
2524 (echo_char, echo_dash, cmd_error, top_level_2):
2525 (poll_for_input, handle_async_input): Now static.
2526 (read_char, kbd_buffer_get_event, make_lispy_position):
2527 (make_lispy_event, make_lispy_movement, apply_modifiers):
2528 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2529 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2530 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2531 (read_key_sequence, read_char): Mark locals as initialized.
2532 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2534 * keyboard.h (make_ctrl_char): New decl.
2535 (mark_kboards): Move decl here ...
2536 * alloc.c (mark_kboards): ... from here.
2538 * lisp.h (force_auto_save_soon): New decl.
2540 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2541 (DEFINE_DUMMY_FUNCTION): New macro.
2542 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2544 (main): Add casts to avoid warnings
2545 if GCC considers string literals to be constants.
2547 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2549 * dbusbind.c: Pointer signedness fixes.
2550 (xd_signature, xd_append_arg, xd_initialize):
2551 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2552 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2553 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2554 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2556 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2557 if GCC considers string literals to be constants.
2558 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2560 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2562 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2563 (print_preprocess, print_object): New macro to fix last change.
2565 * print.c (print_preprocess): Don't forget font objects.
2567 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2569 * emacs.c (USAGE3): Doc fixes.
2571 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2573 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2576 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2578 * lisp.h (VWindow_system, Qfile_name_history):
2579 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2580 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2581 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2583 * w32select.c: Don't #include "keyboard.h".
2584 (run_protected): Add extern declaration for waiting_for_input.
2586 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2587 * w32console.c (detect_input_pending, read_input_pending)
2588 (encode_terminal_code):
2589 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2590 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2591 (w32_system_caret_y, Qfile_name_history):
2592 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2593 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2594 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2595 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2596 * w32proc.c (Qlocal, report_file_error):
2597 * w32term.c (Vwindow_system, updating_frame):
2598 * w32uniscribe.c (initialized, uniscribe_font_driver):
2599 Remove unneeded extern declarations.
2601 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2603 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2605 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2607 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2608 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2609 These macros can no longer be used for assignment.
2611 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2612 Assign struct members directly, instead of using BUF_BEGV etc.
2613 (record_buffer_markers, fetch_buffer_markers): New functions for
2614 recording and fetching special buffer markers.
2615 (set_buffer_internal_1, set_buffer_temp): Use them.
2617 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2619 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2621 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2622 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2624 * xdisp.c (hscroll_window_tree):
2625 (reconsider_clip_changes): Use PT instead of BUF_PT.
2627 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2629 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2630 $(EMACS_ROOT)/lib/intprops.h.
2632 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2634 Fix more problems found by GCC 4.5.2's static checks.
2636 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2637 to unsigned char * to avoid compiler diagnostic.
2638 (xg_free_frame_widgets): Make it clear that a local variable is
2639 needed only if USE_GTK_TOOLTIP.
2640 (gdk_window_get_screen): Make it clear that this macro is needed
2641 only if USE_GTK_TOOLTIP.
2642 (int_gtk_range_get_value): New function, which avoids a diagnostic
2643 from gcc -Wbad-function-cast.
2644 (xg_set_toolkit_scroll_bar_thumb): Use it.
2645 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2646 diagnostic from gcc -Wbad-function-cast.
2647 (get_utf8_string, xg_get_file_with_chooser):
2648 Rename locals to avoid shadowing.
2649 (create_dialog): Move locals to avoid shadowing.
2651 * xgselect.c (xg_select): Remove unused var.
2653 * image.c (four_corners_best): Mark locals as initialized.
2654 (gif_load): Initialize transparent_p to zero (Bug#8238).
2655 Mark another local as initialized.
2656 (my_png_error, my_error_exit): Mark with NO_RETURN.
2658 * image.c (clear_image_cache): Now static.
2659 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2660 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2661 (x_edge_detection): Remove unnecessary cast that
2662 gcc -Wbad-function-cast diagnoses.
2663 (gif_load): Fix pointer signedness.
2664 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2665 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2667 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2669 Improve quality of tests for time stamp overflow.
2670 For example, without this patch (encode-time 0 0 0 1 1
2671 1152921504606846976) returns the obviously-bogus value (-948597
2672 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2673 reports time overflow. See
2674 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2675 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2676 * editfns.c: Include limits.h and intprops.h.
2677 (TIME_T_MIN, TIME_T_MAX): New macros.
2678 (time_overflow): Move earlier, to before first use.
2679 (hi_time, lo_time): New functions, for an accurate test for
2681 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2682 (Fget_internal_run_time): Don't assume time_t fits in int.
2683 (make_time): Use list2 instead of Fcons twice.
2684 (Fdecode_time): More accurate test for out-of-range times.
2685 (check_tm_member): New function.
2686 (Fencode_time): Use it, to test for out-of-range times.
2687 (lisp_time_argument): Don't rely on undefined left-shift and
2688 right-shift behavior when checking for time stamp overflow.
2690 * editfns.c (time_overflow): New function, refactoring common code.
2691 (Fformat_time_string, Fdecode_time, Fencode_time):
2692 (Fcurrent_time_string): Use it.
2694 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2695 * dired.c (make_time): Move to ...
2696 * editfns.c (make_time): ... here.
2697 * systime.h: Note the move.
2699 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2701 * fringe.c (update_window_fringes): Remove unused variables.
2703 * unexmacosx.c (copy_data_segment): Also copy __got section.
2706 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2708 * termcap.c [MSDOS]: Include "msdos.h".
2709 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2710 Constify `char *' arguments and their references according to
2711 prototypes in tparam.h.
2713 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2715 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2716 Adapt all references accordingly.
2718 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2720 2011-03-11 Tom Tromey <tromey@redhat.com>
2722 * buffer.c (syms_of_buffer): Remove obsolete comment.
2724 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2726 * termhooks.h (encode_terminal_code): Declare prototype.
2728 * msdos.c (encode_terminal_code): Don't declare prototype.
2730 * term.c (encode_terminal_code): Now external again, used by
2731 w32console.c and msdos.c.
2733 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2734 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2736 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2738 Fix some minor problems found by GCC 4.5.2's static checks.
2740 * fringe.c (update_window_fringes): Mark locals as initialized
2742 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2744 * alloc.c (mark_fringe_data): Move decl from here ...
2745 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2746 to check its interface.
2747 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2749 * fontset.c (free_realized_fontset): Now static.
2750 (Fset_fontset_font): Rename local to avoid shadowing.
2751 (fontset_font): Mark local as initialized.
2752 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2754 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2756 * xselect.c (x_disown_buffer_selections): Remove; not used.
2757 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2758 (x_own_selection, Fx_disown_selection_internal): Rename locals
2760 (x_handle_dnd_message): Remove local to avoid shadowing.
2762 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2763 so that the caller can use some name other than gcpro1.
2764 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2765 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2766 (Fx_backspace_delete_keys_p):
2767 Use them to avoid shadowing, and rename vars to avoid shadowing.
2768 (x_decode_color, x_set_name, x_window): Now static.
2769 (Fx_create_frame): Add braces to silence GCC warning.
2770 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2771 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2772 Remove unused locals.
2773 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2774 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2775 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2778 * xterm.h (x_mouse_leave): New decl.
2780 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2781 Remove unused functions.
2782 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2783 (x_calc_absolute_position): Now static.
2784 (XTread_socket): Don't define label "out" unless it's used.
2785 Don't declare local "event" unless it's used.
2786 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2787 unless they are used.
2788 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2789 (x_fatal_error_signal): Remove; not used.
2790 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2791 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2792 (x_error_catcher, x_connection_closed, x_error_handler):
2793 (x_error_quitter, xembed_send_message, x_iconify_frame):
2794 (my_log_handler): Rename locals to avoid shadowing.
2795 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2796 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2798 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2799 Rename or move locals to avoid shadowing.
2800 (tty_defined_color, merge_face_heights): Now static.
2801 (free_realized_faces_for_fontset): Remove; not used.
2802 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2803 does not deduce is never used uninitialized.
2804 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2805 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2807 * terminal.c (store_terminal_param): Now static.
2809 * xmenu.c (menu_highlight_callback): Now static.
2810 (set_frame_menubar): Remove unused local.
2811 (xmenu_show): Rename parameter to avoid shadowing.
2812 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2813 since they might point to immutable storage.
2814 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2815 since it's unused otherwise.
2817 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2818 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2819 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2820 avoids a gcc -Wuninitialized diagnostic.
2821 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2822 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2823 does not deduce are never used uninitialized.
2825 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2827 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2828 * window.c (window_loop, size_window):
2829 (run_window_configuration_change_hook, enlarge_window): Likewise.
2831 * window.c (display_buffer): Now static.
2832 (size_window): Mark variables that gcc -Wuninitialized
2833 does not deduce are never used uninitialized.
2834 * window.h (check_all_windows): New decl, to forestall
2835 gcc -Wmissing-prototypes diagnostic.
2836 * dispextern.h (bidi_dump_cached_states): Likewise.
2838 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2840 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2842 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2843 and to avoid gcc -Wuninitialized warning.
2844 (load_charset_map): Mark variables that gcc -Wuninitialized
2845 does not deduce are never used uninitialized.
2846 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2848 * coding.c (coding_set_source, coding_set_destination):
2849 Use "else { /* comment */ }" rather than "else /* comment */;"
2850 for clarity, and to avoid gcc -Wempty-body warning.
2851 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2852 a block, when the outer 'i' will do.
2853 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2854 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2855 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2856 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2857 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2858 Rename locals to avoid shadowing.
2859 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2860 * coding.c (emacs_mule_char, encode_invocation_designation):
2861 Now static, since they're not used elsewhere.
2862 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2863 (decode_coding_object, encode_coding_object, detect_coding_system):
2864 (decode_coding_emacs_mule): Mark variables that gcc
2865 -Wuninitialized does not deduce are never used uninitialized.
2866 (detect_coding_iso_2022): Initialize a local variable that might
2867 be used uninitialized. Leave a FIXME because it's not clear that
2868 this initialization is needed. (Bug#8211)
2869 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2870 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2871 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2872 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2873 Remove unused macros.
2875 * category.c (hash_get_category_set): Remove unused local var.
2876 (copy_category_table): Now static, since it's not used elsewhere.
2877 * character.c (string_count_byte8): Likewise.
2879 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2880 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2882 * chartab.c (copy_sub_char_table): Now static, since it's not used
2884 (sub_char_table_ref_and_range, char_table_ref_and_range):
2885 Rename locals to avoid shadowing.
2886 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2888 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2889 (BIDI_BOB): Remove unused macro.
2891 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2892 deduce are never used uninitialized.
2893 * term.c (encode_terminal_code): Likewise.
2895 * term.c (encode_terminal_code): Now static. Remove unused local.
2897 * tparam.h: New file.
2898 * term.c, tparam.h: Include it.
2899 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2900 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2901 Move these decls to tparam.h, and make them agree with what
2902 is actually in tparam.c. The previous trick of using incompatible
2903 decls in different modules does not conform to the C standard.
2904 All callers of tparam changed to use tparam's actual API.
2905 * tparam.c (tparam1, tparam, tgoto):
2906 Use const pointers where appropriate.
2908 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2909 * cm.h (struct cm): Likewise.
2910 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2911 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2912 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2913 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2914 (turn_on_face, init_tty): Likewise.
2915 * termchar.h (struct tty_display_info): Likewise.
2917 * term.c (term_mouse_position): Rename local to avoid shadowing.
2919 * alloc.c (mark_ttys): Move decl from here ...
2920 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2922 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2924 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2926 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2928 * search.c (compile_pattern_1): Remove argument regp, unused since
2929 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2930 (compile_pattern): Don't pass it.
2932 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2934 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2935 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2937 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2939 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2941 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2942 gdk_window_get_screen, gdk_window_get_geometry,
2943 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2944 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2945 (xg_get_pixbuf_from_pixmap): New function.
2946 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2947 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2948 Call xg_get_pixbuf_from_pixmap instead of
2949 gdk_pixbuf_get_from_drawable.
2950 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2951 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2952 (xg_check_special_colors): Use GtkStyleContext and its functions
2954 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2955 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2956 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2957 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2958 Call gtk_widget_get_preferred_size.
2959 (xg_frame_resized): gdk_window_get_geometry only takes 5
2961 (xg_win_to_widget, xg_event_is_for_menubar):
2962 Call gdk_x11_window_lookup_for_display.
2963 (xg_set_widget_bg): New function.
2964 (delete_cb): New function.
2965 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2966 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2967 (xg_set_background_color): Call xg_set_widget_bg.
2968 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2969 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2970 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2971 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2973 (update_frame_tool_bar): Call gtk_widget_hide.
2974 (xg_initialize): Use GDK_KEY_g.
2976 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2978 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2980 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2981 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2982 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2984 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2986 * w32xfns.c (select_palette): Check success of RealizePalette against
2987 GDI_ERROR, not zero.
2989 See ChangeLog.11 for earlier changes.
2995 Copyright (C) 2011 Free Software Foundation, Inc.
2997 This file is part of GNU Emacs.
2999 GNU Emacs is free software: you can redistribute it and/or modify
3000 it under the terms of the GNU General Public License as published by
3001 the Free Software Foundation, either version 3 of the License, or
3002 (at your option) any later version.
3004 GNU Emacs is distributed in the hope that it will be useful,
3005 but WITHOUT ANY WARRANTY; without even the implied warranty of
3006 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3007 GNU General Public License for more details.
3009 You should have received a copy of the GNU General Public License
3010 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.