1 2012-06-11 Chong Yidong <cyd@gnu.org>
3 * image.c (imagemagick_load_image): Implement transparency.
5 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
7 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
8 account for preceding backslashes. (Bug#11663)
10 2012-06-09 Chong Yidong <cyd@gnu.org>
12 * term.c: Support italics in capable terminals (Bug#9652).
13 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
14 (turn_on_face): Output using TS_enter_italic_mode if available.
15 Don't handle unused blinking and alt-charset cases.
16 (turn_off_face): Handle italic case; discard unused tty_blinking_p
17 and tty_alt_charset_p cases.
18 (tty_capable_p, init_tty): Support italics.
20 * termchar.h (struct tty_display_info): Add field for italics.
21 Remove unused blink field.
23 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
26 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
27 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
28 tty_alt_charset_p. Add tty_italic_p.
30 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
32 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
33 dbus_type_is_basic if available.
34 (xd_extract_signed, xd_extract_unsigned): Rename from
35 extract_signed and extract_unsigned, respectively. Adapt callers.
37 2012-06-09 Chong Yidong <cyd@gnu.org>
39 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
41 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
44 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
46 * xdisp.c (vmessage): Treat frame message as multibyte.
47 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
48 would generate the diagnostic "Making \302\247 buffer-local while
51 2012-06-08 Eli Zaretskii <eliz@gnu.org>
53 * dispnew.c (showing_window_margins_p): Undo last change, which
54 was done due to an inadvertent commit.
55 (adjust_frame_glyphs_for_frame_redisplay): Do call
56 showing_window_margins_p.
58 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
60 * eval.c (Fmake_var_non_special): New primitive.
61 (syms_of_eval): Defsubr it.
62 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
64 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
66 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
67 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
69 2012-06-08 Eli Zaretskii <eliz@gnu.org>
71 * alloc.c (allocate_vectorlike): Fix last change.
73 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
75 Block-based vector allocation of small vectors.
76 * lisp.h (struct vectorlike_header): New field `nbytes',
77 adjust comment accordingly.
78 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
79 to denote vector blocks. Adjust users (live_vector_p,
80 mark_maybe_pointer, valid_lisp_object_p) accordingly.
81 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
82 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
83 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
84 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
85 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
86 (roundup_size): New constant.
87 (struct vector_block): New data type.
88 (vector_blocks, vector_free_lists, zero_vector): New variables.
89 (all_vectors): Rename to `large_vectors'.
90 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
91 (sweep_vectors): New functions.
92 (allocate_vectorlike): Return `zero_vector' as the only vector of
93 0 items. Allocate new vector from block if vector size is less than
94 or equal to VBLOCK_BYTES_MAX.
95 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
96 (init_alloc_once): Add call to init_vectors.
98 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
100 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
102 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
104 * doprnt.c (doprnt): Truncate multibyte char correctly.
105 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
106 would mishandle a string argument "Xc" if X was a multibyte
107 character of length 2: it would truncate after X's first byte
108 rather than including all of X.
110 2012-06-06 Chong Yidong <cyd@gnu.org>
112 * buffer.c (word_wrap): Doc fix.
114 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
116 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
118 2012-06-03 Glenn Morris <rgm@gnu.org>
120 * xdisp.c (tool-bar-style): Doc fix.
122 2012-06-03 Ulrich Müller <ulm@gentoo.org>
124 * Makefile.in (PAXCTL): Define.
125 (temacs$(EXEEXT)): Disable memory randomization for the temacs
126 binary via PaX flags if the paxctl utility is available.
127 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
128 Restore PaX flags to their default. (Bug#11398)
130 2012-06-03 Chong Yidong <cyd@gnu.org>
132 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
135 2012-06-03 Chong Yidong <cyd@gnu.org>
137 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
138 (note_mode_line_or_margin_highlight): If there is no help echo,
139 use mode-line-default-help-echo. Handle the case where the mouse
140 position is past the end of the mode line string.
142 * buffer.c (buffer_local_value_1): New function, split from
143 Fbuffer_local_value; can return Qunbound.
144 (Fbuffer_local_value): Use it.
145 (Vmode_line_format): Docstring tweaks.
147 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
149 * sysdep.c (system_process_attributes): Improve comment.
151 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
153 * keyboard.c: Export real-this-command to Elisp.
154 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
155 and DEFVAR it. Update all users.
157 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
159 * minibuf.c (Fassoc_string): Remove duplicate declaration.
161 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
162 Convert pctcpu and pctmem to Lisp float properly.
163 Let the compiler fold better, as 100.0/0x8000 is exact.
165 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
167 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
170 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
172 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
174 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
176 For a 'struct window', replace some Lisp_Object fields to
177 bitfields where appropriate, remove unused fields.
178 * window.h (struct window): Remove unused 'last_mark_x' and
179 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
180 change it's type from Lisp_Object to bitfield.
181 Change type of 'force_start', 'optional_new_start',
182 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
183 fields from Lisp_Object to bitfield. Adjust users accordingly.
185 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
187 Pacify gcc -Wdouble-precision when using Xaw.
188 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
189 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
190 Use 'float' consistently, rather than 'float' in most places
191 and 'double' in a couple of places.
193 2012-05-31 Eli Zaretskii <eliz@gnu.org>
195 * xdisp.c (handle_stop): Detect whether we have overlay strings
196 loaded by testing it->current.overlay_string_index to be
197 non-negative, instead of checking whether n_overlay_strings is
198 positive. (Bug#11587)
200 2012-05-31 Chong Yidong <cyd@gnu.org>
202 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
204 * doc.c (Fsubstitute_command_keys): Doc fix.
206 2012-05-31 Eli Zaretskii <eliz@gnu.org>
208 * search.c (search_buffer): Remove calls to
209 r_alloc_inhibit_buffer_relocation, as it is now called by
210 maybe_unify_char, which was the cause of relocation of buffer text
213 2012-05-31 Eli Zaretskii <eliz@gnu.org>
215 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
216 for the duration of call to load_charset, to avoid problems with
217 callers of maybe_unify_char that access buffer text through C
220 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
221 decrement the inhibition flag, instead of just setting or
224 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
226 Remove obsolete '#define static' cruft.
227 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
228 This #undef was "temporary" in 2000; it is no longer needed
229 now that '#define static' has gone away.
230 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
231 (gray_bitmap_bits): Remove; no longer needed.
232 All uses replaced with definiens.
233 * xterm.c: Include "bitmaps/gray.xbm".
235 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
237 Clean up __executable_start, monstartup when --enable-profiling.
238 The following changes affect the code only when profiling.
239 * dispnew.c (__executable_start): Rename from safe_bcopy.
240 Define only on platforms that need it.
241 * emacs.c: Include <sys/gmon.h> when profiling.
242 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
243 (__executable_start): Remove decl, since lisp.h does it now.
244 (safe_bcopy): Remove decl; no longer has that name.
245 (main): Coalesce #if into single bit of code, for simplicity.
246 Cast pointers to uintptr_t, since standard libraries want integers
248 * lisp.h (__executable_start): New decl.
250 2012-05-31 Glenn Morris <rgm@gnu.org>
252 * image.c (Fimagemagick_types): Doc fix.
254 2012-05-30 Jim Meyering <meyering@redhat.com>
256 * callproc.c (Fcall_process_region): Include directory component
257 in mkstemp error message (Bug#11586).
259 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
261 * alloc.c, lisp.h (make_pure_vector): Now static.
263 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
265 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
267 (Fautoload): Do the hash-doc more carefully.
268 * data.c (Fdefalias): Purify definition, except for keymaps.
269 (Qdefun): Move from eval.c.
270 * lisp.h (Qdefun): Remove.
271 * lread.c (read1): Tiny simplification.
273 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
275 Do not create empty overlays with the evaporate property (Bug#9642).
276 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
277 Bug#9642, but explicitly check that the buffer the overlay would
278 be moved to is live and rearrange lines to make sure that errors
279 will not put the overlay in an inconsistent state.
280 (Fdelete_overlay): Cosmetics.
282 2012-05-28 Eli Zaretskii <eliz@gnu.org>
284 * w32term.c (my_bring_window_to_top): New function.
285 (x_raise_frame): Use handle returned by DeferWindowPos, which
286 could be different from the original one.
287 Call my_bring_window_to_top instead of my_set_foreground_window.
290 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
291 by calling BringWindowToTop.
293 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
294 (WM_EMACS_END): Increase by one.
296 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
298 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
299 This avoids undefined behavior that might cause the eassert
300 to not catch an out-of-range value.
302 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
304 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
307 2012-05-27 Eli Zaretskii <eliz@gnu.org>
309 * bidi.c (bidi_mirror_char): Fix last change.
311 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
313 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
314 when referring to sectname field in printf format.
316 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
318 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
319 Only r_alloc_inhibit_buffer_relocation needed to be added;
320 the others were already declared.
322 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
323 before checking whether it's out of range. Put the check inside
325 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
327 2012-05-27 Ken Brown <kbrown@cornell.edu>
329 * callproc.c (Fcall_process): Restore a line that was accidentally
330 commented out in the 2011-02-13 change (bug#11547).
332 2012-05-27 Eli Zaretskii <eliz@gnu.org>
334 * lisp.h [REL_ALLOC]: Add prototypes for external functions
337 * buffer.c [REL_ALLOC]: Remove prototypes of
338 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
339 they are now on lisp.h.
341 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
343 * search.c (search_buffer): Use it to inhibit relocation of buffer
344 text while re_search_2 is doing its job, because re_search_2 is
345 passed C pointers to buffer text. (Bug#11519)
347 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
350 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
351 state after an additional call to move_it_in_display_line_to, keep
352 the values of it->max_ascent and it->max_descent found for the
354 (pos_visible_p): Revert the comparison against bottom_y to what it
355 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
358 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
360 Fix coding-related core dumps with gcc -ftrapv.
361 The code was computing A - B, where A and B are pointers, and B is
362 random garbage. This can lead to core dumps on platforms that
363 have special pointer registers, and it also leads to core dumps on
364 x86-64 when compiled with gcc -ftrapv. The fix is to compute
365 A - B only when B is initialized properly.
366 * coding.c (coding_set_source, coding_set_destination): Return void.
367 (coding_change_source, coding_change_destinations): New functions,
368 with the old behaviors of coding_set_source and coding_set_destination.
369 All callers that need an offset changed to use these new functions.
371 2012-05-26 Glenn Morris <rgm@gnu.org>
373 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
375 2012-05-26 Eli Zaretskii <eliz@gnu.org>
377 Extend mouse support on W32 text-mode console.
378 * xdisp.c (draw_row_with_mouse_face):
379 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
381 * w32console.c: Include window.h.
382 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
384 (initialize_w32_display): Initialize mouse-highlight data.
386 * w32inevt.c: Include termchar.h and window.h.
387 (do_mouse_event): Support mouse-autoselect-window. When the mouse
388 moves, call note_mouse_highlight. If help_echo changed, call
389 gen_help_event to produce help-echo message in the echo area.
390 Call clear_mouse_face if mouse_face_hidden is set in the mouse
393 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
395 * lread.c (read1): Simplify slightly to avoid an overflow warning
396 with GCC 4.7.0 on x86-64.
398 2012-05-26 Eli Zaretskii <eliz@gnu.org>
400 * bidi.c (bidi_mirror_char): Revert last change: an int is
401 definitely wide enough here.
403 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
405 Fix integer width and related bugs (Bug#9874).
406 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
407 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
408 (string_bytes, check_sblock, allocate_string_data):
409 (compact_small_strings, Fmake_bool_vector, make_string)
410 (make_unibyte_string, make_multibyte_string)
411 (make_string_from_bytes, make_specified_string)
412 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
413 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
415 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
416 (allocate_pseudovector):
417 Use int, not EMACS_INT, where int is wide enough.
418 (inhibit_garbage_collection, Fgarbage_collect):
419 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
420 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
421 int might not be wide enough.
422 (bidi_cache_search, bidi_cache_find, bidi_init_it)
423 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
424 (bidi_at_paragraph_end, bidi_find_paragraph_start)
425 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
426 (bidi_level_of_next_char, bidi_move_to_visually_next):
427 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
428 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
429 (Fkill_buffer, Fset_buffer_major_mode)
430 (advance_to_char_boundary, Fbuffer_swap_text)
431 (Fset_buffer_multibyte, overlays_at, overlays_in)
432 (overlay_touches_p, struct sortvec, record_overlay_string)
433 (overlay_strings, recenter_overlay_lists)
434 (adjust_overlays_for_insert, adjust_overlays_for_delete)
435 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
436 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
437 (Foverlay_recenter, last_overlay_modification_hooks_used)
438 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
439 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
440 (validate_region): Omit unnecessary test for b <= e,
441 since that's guaranteed by the previous test.
442 (adjust_overlays_for_delete): Avoid pos + length overflow.
443 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
444 (report_overlay_modification):
445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
446 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
447 Omit pointer cast, which isn't needed anyway, and doesn't work
448 after the EMACS_INT -> ptrdiff_t change.
449 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
450 * buffer.h: Adjust decls to match defn changes elsewhere.
451 (struct buffer_text, struct buffer):
452 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
453 Use EMACS_INT, not int, where int might not be wide enough.
454 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
455 not int, to avoid needless 32-bit limit on 64-bit hosts.
456 (exec_byte_code): Use tighter memory-full test, one that checks
457 for alloca overflow. Don't compute the address of the object just
458 before an array, as that's not portable. Use EMACS_INT, not
459 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
460 * callint.c (Fcall_interactively):
461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
462 * callproc.c (call_process_kill, Fcall_process):
463 Don't assume pid_t fits into an Emacs fixnum.
464 (call_process_cleanup, Fcall_process, child_setup):
465 Don't assume pid_t fits into int.
466 (call_process_cleanup, Fcall_process, delete_temp_file)
467 (Fcall_process_region):
468 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
469 (Fcall_process): Simplify handling of volatile integers.
470 Use int, not EMACS_INT, where int will do.
471 * casefiddle.c (casify_object, casify_region, operate_on_word)
472 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
474 (casify_object): Avoid integer overflow when overallocating buffer.
475 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
476 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
477 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
478 * category.h (CATEGORYP): Don't assume arg is nonnegative.
479 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
480 integers are now checked earlier. All uses replaced with XINT.
482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
483 For CCL_MapSingle, check that content and value are in int range.
484 (ccl_driver, Fregister_code_conversion_map):
485 Check that Vcode_version_map_vector is a vector.
486 (resolve_symbol_ccl_program): Check that vector header is in range.
487 Always copy the vector, so that we can check its contents reliably
488 now rather than having to recheck each instruction as it's being
489 executed. Check that vector words fit in 'int'.
490 (ccl_get_compiled_code, Fregister_ccl_program)
491 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
492 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
493 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
494 contents are in range.
495 (Fccl_execute_on_string): Check that status is in range.
496 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
497 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
498 Accept and return EMACS_INT, not int, because callers can pass values
500 (c_string_width, strwidth, lisp_string_width, chars_in_text)
501 (multibyte_chars_in_text, parse_str_as_multibyte)
502 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
503 (str_as_unibyte, str_to_unibyte, string_count_byte8)
504 (string_escape_byte8, Fget_byte):
505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
506 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
507 avoid mishandling large integers.
508 * character.h: Adjust decls to match defn changes elsewhere.
509 * charset.c (load_charset_map_from_file, find_charsets_in_text)
510 (Ffind_charset_region):
511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
512 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
513 (load_charset_map_from_vector, Fdefine_charset_internal):
514 Don't assume fixnum fits in int.
515 (load_charset_map_from_vector, Fmap_charset_chars):
516 Remove now-unnecessary CHECK_NATNUMs.
517 (Fdefine_charset_internal): Check ranges here, more carefully.
518 Don't rely on undefined behavior with signed left shift overflow.
519 Don't assume unsigned int fits into fixnum, or that fixnum fits
520 into unsigned int. Don't require max_code to be a valid fixnum;
521 that's not true for gb10830 4-byte on a 32-bit host. Allow
522 invalid_code to be a cons, for the same reason. Require code_offset
523 to be a character. Avoid int overflow if max_char is close
525 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
526 this is intended anyway and avoids some undefined behavior.
527 (load_charset_map): Pass unsigned, not int, as 2nd arg of
528 INDEX_TO_CODE_POINT, as that's what it expects.
529 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
530 * charset.h (DECODE_CHAR): Return int, not unsigned;
531 this is what was intended anyway, and it avoids undefined behavior.
532 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
533 integer-overflow issues.
534 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
535 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
536 where the argument is EMACS_INT, and this behavior is not intended.
537 * chartab.c (Fmake_char_table, Fset_char_table_range)
538 (uniprop_get_decoder, uniprop_get_encoder):
539 Don't assume fixnum fits in int.
540 * cmds.c (move_point): New function, that does the gist of
541 Fforward_char and Fbackward_char, but does so while checking
542 for integer overflow more accurately.
543 (Fforward_char, Fbackward_char): Use it.
544 (Fforward_line, Fend_of_line, internal_self_insert)
545 (internal_self_insert):
546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
547 Fix a FIXME, by checking for integer overflow when calculating
548 target_clm and actual_clm.
549 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
550 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
551 (ASSURE_DESTINATION, coding_alloc_by_realloc)
552 (coding_alloc_by_making_gap, alloc_destination)
553 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
554 (encode_coding_utf_16, detect_coding_emacs_mule)
555 (decode_coding_emacs_mule, encode_coding_emacs_mule)
556 (detect_coding_iso_2022, decode_coding_iso_2022)
557 (encode_invocation_designation, encode_designation_at_bol)
558 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
559 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
560 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
561 (encode_coding_ccl, encode_coding_raw_text)
562 (detect_coding_charset, decode_coding_charset)
563 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
564 (produce_composition, produce_charset, produce_annotation)
565 (decode_coding, handle_composition_annotation)
566 (handle_charset_annotation, consume_chars, decode_coding_gap)
567 (decode_coding_object, encode_coding_object, detect_coding_system)
568 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
569 (code_convert_region, code_convert_string)
570 (Fdefine_coding_system_internal)
571 (coding_set_source, coding_set_destination):
572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
573 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
574 (Fdefine_coding_system_internal):
575 Don't assume fixnums fit in int.
576 (decode_coding_gap, decode_coding_object, encode_coding_object)
577 (Fread_coding_system, Fdetect_coding_region)
578 (Funencodable_char_position, Fcheck_coding_systems_region)
579 (get_translation, handle_composition_annotation, consume_chars):
580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
581 (consume_chars): Rewrite to not calculate an address outside buffer.
582 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
583 Don't access memory outside of the args array.
584 (Fdefine_coding_system_internal): Check for charset-id overflow.
585 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
586 result of ENCODE_CHAR.
587 * coding.h: Adjust decls to match defn changes elsewhere.
588 (struct coding_system):
589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
590 * composite.c (get_composition_id, find_composition)
591 (run_composition_function, update_compositions)
592 (compose_text, composition_gstring_put_cache)
593 (composition_gstring_p, composition_gstring_width)
594 (fill_gstring_header, fill_gstring_body, autocmp_chars)
595 (composition_compute_stop_pos, composition_reseat_it)
596 (composition_update_it, struct position_record)
597 (find_automatic_composition, composition_adjust_point)
598 (Fcomposition_get_gstring, Ffind_composition_internal):
599 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
600 (update_compositions):
601 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
602 * composite.h: Adjust decls to match defn changes elsewhere.
603 (struct composition):
604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
605 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
606 Do not attempt to compute the address of the object just before a
607 buffer; this is not portable.
609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
610 (Faset): Use int, not EMACS_INT, where int is wide enough.
611 (Fstring_to_number): Don't assume fixnums fit in int.
612 (Frem): Don't assume arg is nonnegative.
613 * dbusbind.c (xd_append_arg): Check for integers out of range.
614 (Fdbus_call_method): Don't overflow the timeout int.
615 (extract_signed, extract_unsigned): New functions.
616 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
617 (xd_get_connection_references): Return ptrdiff_t, not int.
619 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
621 Use int, not unsigned, where the dbus API uses int.
622 (Fdbus_message_internal): Don't overflow mtype.
623 (syms_of_dbusbind): Allocate right-sized buffer for integers.
624 * dired.c (directory_files_internal, file_name_completion, scmp)
625 (file_name_completion_stat):
626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
627 (file_name_completion): Don't overflow matchcount.
628 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
629 * dispextern.h: Adjust decls to match defn changes elsewhere.
630 (struct text_pos, struct glyph, struct bidi_saved_info)
631 (struct bidi_string_data, struct bidi_it, struct composition_it)
633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
634 (struct display_pos, struct composition_it, struct it):
635 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
636 * dispnew.c (increment_matrix_positions)
637 (increment_row_positions, mode_line_string)
638 (marginal_area_string):
639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
640 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
641 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
642 (duration_to_sec_usec): New function, to check for overflow better.
643 (Fsleep_for, sit_for): Use it.
644 * doc.c (get_doc_string, store_function_docstring):
645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
646 (get_doc_string, Fsnarf_documentation):
647 Use int, not EMACS_INT, where int is wide enough.
649 Use SAFE_ALLOCA, not alloca.
650 Check for overflow when converting EMACS_INT to off_t.
652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
653 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
654 Don't assume uid_t fits into fixnum.
655 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
656 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
657 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
658 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
659 (general_insert_function)
660 (Finsert_char, make_buffer_string, make_buffer_string_both)
661 (update_buffer_properties, Fbuffer_substring)
662 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
663 (Fsubst_char_in_region, check_translation)
664 (Ftranslate_region_internal, save_restriction_restore, Fformat)
665 (transpose_markers, Ftranspose_regions):
666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
667 (clip_to_bounds): Move to lisp.h as an inline function).
668 (Fconstrain_to_field): Don't assume integers are nonnegative.
669 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
670 (Fsubst_char_in_region, Fsave_restriction):
671 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
672 (Femacs_pid): Don't assume pid_t fits into fixnum.
673 (lo_time): Use int, not EMACS_INT, when int suffices.
674 (lisp_time_argument): Check for usec out of range.
675 (Fencode_time): Don't assume fixnum fits in int.
676 (Fuser_login_name, Fuser_full_name): Signal an error
677 if a uid argument is out of range, rather than relying on
679 (Fformat_time_string): Remove now-unnecessary check.
680 lisp_time_argument checks for out-of-range usec now.
681 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
682 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
683 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
684 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
685 (init_cmdargs, Fdump_emacs):
686 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
687 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
688 the bottom (typically) 32 bits of the fixnum.
689 * eval.c (specpdl_size, call_debugger):
690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
691 (when_entered_debugger, Fbacktrace_debug):
692 Don't assume fixnum can fit in int.
693 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
694 the object just before a buffer; this is not portable.
695 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
696 (grow_specpdl, unbind_to):
697 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
698 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
699 (grow_specpdl): Simplify allocation by using xpalloc.
700 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
701 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
702 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
703 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
704 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
707 (Fcopy_file, non_regular_nbytes, read_non_regular)
708 (Finsert_file_contents):
709 Use int, not EMACS_INT, where int is wide enough.
710 (READ_BUF_SIZE): Verify that it fits in int.
711 (Finsert_file_contents): Check that counts are in proper range,
712 rather than assuming fixnums fit into ptrdiff_t etc.
713 Don't assume fixnums fit into int.
714 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
715 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
716 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
717 (string_char_to_byte, string_byte_to_char)
718 (string_make_multibyte, string_to_multibyte)
719 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
720 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
721 (substring_both, Fdelete, internal_equal, Ffillarray)
722 (Fclear_string, mapcar1)
723 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
724 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
725 (larger_vector, make_hash_table, maybe_resize_hash_table)
726 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
727 (Fmaphash, secure_hash):
728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
729 (concat): Check for string index and length overflow.
730 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
732 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
733 (larger_vector): New API (vec, incr_min, size_max) replaces old
734 one (vec, new_size, init). This catches size overflow.
735 INIT was removed because it was always Qnil.
737 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
738 the upper bound on a hash table index size.
739 (make_hash_table, maybe_resize_hash_table): Use it.
740 (secure_hash): Computer start_byte and end_byte only after
741 they're known to be in ptrdiff_t range.
742 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
743 (Ffont_get_glyphs, Ffont_at):
744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
745 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
746 (Flist_fonts, Fopen_font):
747 Don't assume fixnum can fit in int.
748 (check_gstring): Don't assume index can fit in int.
749 (font_match_p): Check that fixnum is a character, not a nonnegative
750 fixnum, since the later code needs to stuff it into an int.
751 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
752 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
753 conversion overflow issues.
754 (Fopen_font): Check for integer out of range.
755 (Ffont_get_glyphs): Don't assume index can fit in int.
756 * font.h: Adjust decls to match defn changes elsewhere.
757 * fontset.c (reorder_font_vector): Redo score calculation to avoid
759 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
760 printmax_t, where ptrdiff_t is wide enough.
761 (Finternal_char_font):
762 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
763 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
764 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
765 (Fset_frame_position, x_set_frame_parameters)
766 (x_set_line_spacing, x_set_border_width)
767 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
768 Check that fixnums are in proper range for system types.
769 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
771 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
772 Use SAFE_ALLOCA_LISP, not alloca.
773 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
774 intptr_t is wide enough.
775 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
776 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
777 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
778 Check for fixnum out of range.
779 * ftfont.c (ftfont_list): Don't assume index fits in int.
780 Check that fixnums are in proper range for system types.
781 (ftfont_shape_by_flt):
782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
783 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
785 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
786 Check that fixnums are in proper range for system types.
787 * gnutls.h: Adjust decls to match defn changes elsewhere.
788 * gtkutil.c (xg_dialog_run):
789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
790 (update_frame_tool_bar):
791 Check that fixnums are in proper range for system types.
792 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
793 (lookup_image): Check that fixnums are in range for system types.
794 * indent.c (last_known_column, last_known_column_point):
795 (current_column_bol_cache):
796 (skip_invisible, current_column, check_display_width):
797 (check_display_width, scan_for_column, current_column_1)
798 (Findent_to, Fcurrent_indentation, position_indentation)
799 (indented_beyond_p, Fmove_to_column, compute_motion):
800 (Fcompute_motion, Fvertical_motion):
801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
802 (last_known_column_modified): Use EMACS_INT, not int.
803 (check_display_width):
805 Check that fixnums and floats are in proper range for system types.
806 (compute_motion): Don't assume index or fixnum fits in int.
807 (compute_motion, Fcompute_motion):
808 Use int, not EMACS_INT, when it is wide enough.
809 (vmotion): Omit local var start_hpos that is always 0; that way
810 we don't need to worry about overflow in expressions involving it.
811 * indent.h: Adjust decls to match defn changes elsewhere.
813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
814 Use int, not EMACS_INT, where int is wide enough.
815 Remove unused members ovstring_chars_done and tab_offset;
817 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
818 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
819 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
820 (make_gap, copy_text, insert, insert_and_inherit)
821 (insert_before_markers, insert_before_markers_and_inherit)
822 (insert_1, count_combining_before, count_combining_after)
823 (insert_1_both, insert_from_string)
824 (insert_from_string_before_markers, insert_from_string_1)
825 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
826 (adjust_after_replace, adjust_after_insert, replace_range)
827 (replace_range_2, del_range, del_range_1, del_range_byte)
828 (del_range_both, del_range_2, modify_region)
829 (prepare_to_modify_buffer, signal_before_change)
830 (signal_after_change, Fcombine_after_change_execute):
831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
832 * intervals.c (traverse_intervals, rotate_right, rotate_left)
833 (balance_an_interval, split_interval_right, split_interval_left)
834 (find_interval, next_interval, update_interval)
835 (adjust_intervals_for_insertion, delete_node, delete_interval)
836 (interval_deletion_adjustment, adjust_intervals_for_deletion)
837 (static_offset_intervals, offset_intervals)
838 (merge_interval_right, merge_interval_left, make_new_interval)
839 (graft_intervals_into_buffer, temp_set_point_both)
840 (temp_set_point, set_point, adjust_for_invis_intang)
841 (set_point_both, move_if_not_intangible, get_property_and_range)
842 (get_local_map, copy_intervals, copy_intervals_to_string)
843 (compare_string_intervals, set_intervals_multibyte_1):
844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
845 * intervals.h: Adjust decls to match defn changes elsewhere.
847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
848 * keyboard.c (this_command_key_count, this_single_command_key_start)
849 (before_command_key_count, before_command_echo_length, echo_now)
850 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
851 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
852 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
853 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
854 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
855 (last_non_minibuf_size, last_point_position, echo_truncate)
856 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
857 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
858 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
859 (stuff_buffered_input):
860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
861 (last_auto_save, command_loop_1, read_char):
862 Use EMACS_INT, not int, to avoid integer overflow.
863 (record_char): Avoid overflow in total_keys computation.
864 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
865 * keyboard.h: Adjust decls to match defn changes elsewhere.
866 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
867 (Fkey_description, Fdescribe_vector, Flookup_key):
868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
869 (click_position): New function, to check that positions are in range.
870 (Fcurrent_active_maps):
872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
873 (Faccessible_keymaps, Fkey_description):
874 (preferred_sequence_p):
875 Don't assume fixnum can fit into int.
876 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
877 Check for integer overflow in size calculations.
878 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
879 avoid mishandling large integers.
880 * lisp.h: Adjust decls to match defn changes elsewhere.
881 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
882 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
883 (struct Lisp_Marker):
884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
885 (clip_to_bounds): Now an inline function, moved here from editfns.c.
886 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
887 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
889 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
890 Assume the arg has valid form, since it always does.
891 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
892 unsigned integer system type.
893 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
894 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
896 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
897 (duration_to_sec_usec): New decl.
898 * lread.c (read_from_string_index, read_from_string_index_byte)
899 (read_from_string_limit, readchar, unreadchar, openp)
900 (read_internal_start, read1, oblookup):
901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
902 (Fload, readevalloop, Feval_buffer, Feval_region):
903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
904 (openp): Check for out-of-range argument to 'access'.
905 (read1): Use int, not EMACS_INT, where int is wide enough.
906 Don't assume fixnum fits into int.
907 Fix off-by-one error that can read outside a buffer.
908 (read_filtered_event): Use duration_to_sec_usec
909 to do proper overflow checking on durations.
910 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
912 (Fexecute_kbd_macro):
913 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
914 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
915 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
916 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
917 (set_marker_both, set_marker_restricted_both, marker_position)
918 (marker_byte_position, Fbuffer_has_markers_at):
919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
920 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
921 * menu.c (ensure_menu_items): Rename from grow_menu_items.
922 It now merely ensures that the menu is large enough, without
923 necessarily growing it, as this avoids some integer overflow issues.
925 (keymap_panes, parse_single_submenu, Fx_popup_menu):
926 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
927 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
928 Use SAFE_ALLOCA_LISP, not alloca.
929 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
930 to EMACS_INT. Check that fixnums are in proper range for system types.
931 * minibuf.c (minibuf_prompt_width, string_to_object)
932 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
933 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
935 (get_minibuffer, read_minibuf_unwind):
936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
937 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
938 this simplifies overflow checking. All callers changed.
939 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
942 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
943 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
944 Check that fixnums are in proper range for system types.
945 (Fx_create_frame, Fx_show_tip):
946 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
947 * nsfont.m (ns_findfonts, nsfont_list_family):
948 Don't assume fixnum fits in long.
949 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
951 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
953 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
954 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
955 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
956 (PRINTDECLARE, PRINTPREPARE):
957 (strout, print_string):
958 (print, print_preprocess, print_check_string_charset_prop)
960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
962 (temp_output_buffer_setup, Fprin1_to_string, print_object):
963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
964 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
965 (printchar, strout): Use xpalloc to catch size calculation overflow.
966 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
967 (print_error_message): Use SAFE_ALLOCA, not alloca.
968 (print_object): Use int, not EMACS_INT, where int is wide enough.
969 (print_depth, new_backquote_output, print_number_index):
970 Use ptrdiff_t, not int, where int might not be wide enough.
971 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
972 (Fset_process_window_size, Fformat_network_address)
973 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
975 Check that fixnums are in proper range for system types.
976 (Fsignal_process): Simplify by avoiding a goto.
977 Check for process-ids out of pid_t range rather than relying on
979 (process_tick, update_tick): Use EMACS_INT, not int.
980 (Fformat_network_address, read_process_output, send_process)
981 (Fprocess_send_region, status_notify):
982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
983 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
984 (wait_reading_process_output, read_process_output, exec_sentinel):
985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
986 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
987 (Faccept_process_output): Use duration_to_sec_usec to do proper
988 overflow checking on durations.
989 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
990 Don't assume pid_t fits in int.
991 * process.h (struct Lisp_Process): Members tick and update_tick
992 are now of type EMACS_INT, not int.
993 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
994 configured --with-wide-int.
995 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
996 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
997 * search.c (looking_at_1, string_match_1):
998 (fast_string_match, fast_c_string_match_ignore_case)
999 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1000 (scan_newline, find_before_next_newline, search_command)
1001 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1002 (set_search_regs, wordify):
1005 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1006 (string_match_1, search_buffer, set_search_regs):
1008 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1009 (wordify): Check for overflow in size calculation.
1010 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1011 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1012 Check that fixnums are in proper range for system types.
1013 * sound.c (struct sound_device)
1014 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1016 (Fplay_sound_internal):
1017 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1018 * syntax.c (struct lisp_parse_state, find_start_modiff)
1019 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1020 (Fparse_partial_sexp):
1021 Don't assume fixnums can fit in int.
1022 (struct lisp_parse_state, find_start_pos, find_start_value)
1023 (find_start_value_byte, find_start_begv)
1024 (update_syntax_table, char_quoted, dec_bytepos)
1025 (find_defun_start, prev_char_comend_first, back_comment):
1026 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1027 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1029 (Finternal_describe_syntax_value): Check that match_lisp is a
1030 character, not an integer, since the code stuffs it into int.
1031 (scan_words, scan_sexps_forward):
1032 Check that fixnums are in proper range for system types.
1034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1035 (scan_sexps_forward):
1036 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1037 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1038 * syntax.h: Adjust decls to match defn changes elsewhere.
1039 (struct gl_state_s):
1040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1041 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1042 MOST_POSITIVE_FIXNUM.
1043 * sysdep.c (wait_for_termination_1, wait_for_termination)
1044 (interruptible_wait_for_termination, mkdir):
1045 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1046 (emacs_read, emacs_write):
1047 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1048 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1049 and double all fit in int.
1050 * term.c (set_tty_color_mode):
1051 Check that fixnums are in proper range for system types.
1052 * termhooks.h (struct input_event):
1053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1054 * textprop.c (validate_interval_range, interval_of)
1055 (Fadd_text_properties, set_text_properties_1)
1056 (Fremove_text_properties, Fremove_list_of_text_properties)
1057 (Ftext_property_any, Ftext_property_not_all)
1058 (copy_text_properties, text_property_list, extend_property_ranges)
1059 (verify_interval_modification):
1060 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1061 (Fnext_single_char_property_change)
1062 (Fprevious_single_char_property_change):
1063 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1064 (copy_text_properties):
1065 Check for integer overflow in index calculation.
1066 * undo.c (last_boundary_position, record_point, record_insert)
1067 (record_delete, record_marker_adjustment, record_change)
1068 (record_property_change):
1069 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1070 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1072 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1073 (Fx_hide_tip, Fx_file_dialog):
1074 * w32menu.c (set_frame_menubar):
1075 Use ptrdiff_t, not int, for consistency with rest of code.
1076 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1077 (select_window, Fdelete_other_windows_internal)
1078 (window_scroll_pixel_based, window_scroll_line_based)
1079 (Frecenter, Fset_window_configuration):
1080 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1081 (Fset_window_hscroll, run_window_configuration_change_hook)
1082 (set_window_buffer, temp_output_buffer_show, scroll_command)
1083 (Fscroll_other_window, Frecenter):
1084 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1085 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1086 Don't assume fixnum fits in int.
1087 (Fset_window_scroll_bars):
1088 Check that fixnums are in proper range for system types.
1089 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1090 (string_pos, c_string_pos, number_of_chars, init_iterator)
1091 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1092 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1093 (compute_display_string_end, handle_face_prop)
1094 (face_before_or_after_it_pos, handle_invisible_prop)
1095 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1096 (display_prop_intangible_p, string_buffer_position_lim)
1097 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1098 (get_overlay_strings_1, get_overlay_strings)
1099 (iterate_out_of_display_property, forward_to_next_line_start)
1100 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1101 (get_next_display_element, set_iterator_to_next)
1102 (get_visually_first_element, compute_stop_pos_backwards)
1103 (handle_stop_backwards, next_element_from_buffer)
1104 (move_it_in_display_line_to, move_it_in_display_line)
1105 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1106 (add_to_log, message_dolog, message_log_check_duplicate)
1107 (message2, message2_nolog, message3, message3_nolog
1108 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1109 (current_message_1, truncate_echo_area, truncate_message_1)
1110 (set_message, set_message_1, store_mode_line_noprop)
1111 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1112 (text_outside_line_unchanged_p, check_point_in_composition)
1113 (reconsider_clip_changes)
1114 (redisplay_internal, set_cursor_from_row, try_scrolling)
1115 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1116 (redisplay_window, find_last_unchanged_at_beg_row)
1117 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1118 (trailing_whitespace_p, find_row_edges, display_line)
1119 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1120 (display_mode_element, store_mode_line_string)
1121 (pint2str, pint2hrstr, decode_mode_spec)
1122 (display_count_lines, display_string, draw_glyphs)
1123 (x_produce_glyphs, x_insert_glyphs)
1124 (rows_from_pos_range, mouse_face_from_buffer_pos)
1125 (fast_find_string_pos, mouse_face_from_string_pos)
1126 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1127 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1128 (safe_call, init_from_display_pos, handle_fontified_prop)
1129 (handle_single_display_spec, load_overlay_strings)
1130 (with_echo_area_buffer, setup_echo_area_for_printing)
1131 (display_echo_area, echo_area_display)
1132 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1133 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1134 (redisplay_window, dump_glyph_row, display_mode_line)
1135 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1136 (handle_display_spec, display_prop_string_p):
1137 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1138 (handle_single_display_spec, build_desired_tool_bar_string)
1139 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1140 (get_specified_cursor_type):
1141 Check that fixnums are in proper range for system types.
1142 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1143 (Flookup_image_map):
1144 Don't assume fixnums fit in int.
1145 (compare_overlay_entries):
1146 Avoid mishandling comparisons due to subtraction overflow.
1147 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1148 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1149 (handle_tool_bar_click):
1150 Use int, not unsigned, since we prefer signed and the signedness
1151 doesn't matter here.
1152 (get_next_display_element, next_element_from_display_vector):
1153 Use int, not EMACS_INT, when int is wide enough.
1154 (start_hourglass): Use duration_to_sec_usec to do proper
1155 overflow checking on durations.
1156 * xfaces.c (Fbitmap_spec_p):
1157 Check that fixnums are in proper range for system types.
1158 (compare_fonts_by_sort_order):
1159 Avoid mishandling comparisons due to subtraction overflow.
1160 (Fx_family_fonts, realize_basic_faces):
1161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1163 Don't assume fixnum fits in int.
1164 Use SAFE_ALLOCA_LISP, not alloca.
1165 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1166 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1167 (face_at_buffer_position, face_for_overlay_string)
1168 (face_at_string_position):
1169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1170 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1171 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1173 Check that fixnums are in proper range for system types.
1174 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1175 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1177 (Fx_change_window_property): Don't assume fixnums fit in int.
1178 * xfont.c (xfont_chars_supported):
1179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1180 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1181 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1182 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1183 * xml.c (parse_region):
1184 * xrdb.c (magic_file_p):
1185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1186 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1187 (x_get_local_selection, x_reply_selection_request)
1188 (x_handle_selection_request, wait_for_property_change):
1189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1190 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1191 short is wide enough.
1192 (x_send_client_event): Don't assume fixnum fits in int.
1193 * xterm.c (x_x_to_emacs_modifiers):
1194 Don't assume EMACS_INT overflows nicely into int.
1195 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1197 (handle_one_xevent): NATNUMP can eval its arg twice.
1198 (x_connection_closed):
1199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1200 * xterm.h: Adjust decls to match defn changes elsewhere.
1201 (struct scroll_bar): Use struct vectorlike_header
1202 rather than rolling our own approximation.
1203 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1205 2012-05-25 Glenn Morris <rgm@gnu.org>
1207 * lisp.mk (lisp): Update for more files being compiled now.
1209 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1211 * lread.c: Remove `read_pure' which makes no difference.
1212 (read_pure): Remove var.
1213 (unreadpure): Remove function.
1214 (readevalloop): Don't call read_list with -1 flag.
1215 (read1, read_vector): Don't test read_pure any more.
1216 (read_list): Simplify.
1218 * fileio.c, character.h: Minor style tweaks.
1220 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1222 * window.h (clip_changed): Remove useless declaration.
1224 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1226 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1227 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1229 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1232 This directory predates autoconf and is no longer needed nowadays.
1233 Move its few remaining bits of functionality to where they're needed.
1234 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1235 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1236 * m/template.h: Remove.
1237 * Makefile.in (M_FILE): Remove. All uses removed.
1238 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1239 * lisp.h (USE_LSB_TAG):
1240 * mem-limits.h (EXCEEDS_LISP_PTR):
1241 Use VAL_MAX, not VALBITS, in #if.
1242 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1243 (EMACS_UINT): Define unconditionally now.
1244 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1245 (BITS_PER_EMACS_INT): New constants, replacing
1246 what used to be in config.h, but not useful in #if.
1247 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1248 define them any more.
1249 (VAL_MAX): New macro.
1251 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1252 BITS_PER_EMACS_INT, in #if.
1253 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1254 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1255 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1256 * s/ms-w32.h (DATA_START):
1257 Move here from removed file m/intel386.h.
1258 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1259 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1261 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1263 Assume C89 or later.
1264 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1265 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1267 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1268 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1269 * textprop.c, tparam.c (NULL): Remove.
1270 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1271 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1272 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1273 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1274 * xterm.c (input_signal_count): Assume volatile works.
1276 2012-05-21 Ken Brown <kbrown@cornell.edu>
1278 * xgselect.c (xg_select): Fix first argument in call to 'select'
1281 2012-05-20 Ken Brown <kbrown@cornell.edu>
1283 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1284 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1286 2012-05-19 Ken Brown <kbrown@cornell.edu>
1288 * xfns.c (x_in_use): Remove `static' qualifier.
1289 * xterm.h (x_in_use): Declare.
1290 * xgselect.c: Include xterm.h.
1291 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1292 and `display_arg' (bug#9754).
1294 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1296 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1298 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1299 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1301 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1303 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1305 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1306 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1308 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1309 reference to image_cache->refcount.
1310 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1312 2012-05-17 Juri Linkov <juri@jurta.org>
1314 * search.c (Fword_search_regexp, Fword_search_backward)
1315 (Fword_search_forward, Fword_search_backward_lax)
1316 (Fword_search_forward_lax): Move functions to isearch.el
1317 (bug#10145, bug#11381).
1319 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1321 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1323 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1325 * lread.c (init_obarray): Declare Qt and Qnil as special.
1327 2012-05-14 Glenn Morris <rgm@gnu.org>
1329 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1330 Put "libexec" before "bin", for the sake of init_callproc_1.
1332 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1334 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1336 * unexaix.c: Port to more-recent AIX compilers.
1337 (report_error, report_error_1, make_hdr, copy_sym)
1338 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1339 Make arguments const char *, not char *, to avoid violations of C
1340 standard and to fix some AIX warnings reported by Gilles Pion.
1342 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1344 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1345 already have overlays loaded.
1346 (handle_single_display_spec): Before returning without displaying
1347 fringe bitmap, synchronize the bidi iterator with the main display
1348 iterator, by calling iterate_out_of_display_property.
1349 (iterate_out_of_display_property): Detect buffer iteration by
1350 testing that it->string is a Lisp string.
1351 (get_next_display_element): When the current object is exhausted,
1352 and there's something on it->stack, call set_iterator_to_next to
1353 proceed with what's on the stack, instead of returning zero.
1354 (set_iterator_to_next): If called at the end of a Lisp string,
1355 proceed to consider_string_end without incrementing string
1356 position. Don't increment display vector index past the end of
1357 the display vector. (Bug#11417)
1358 (pos_visible_p): Don't report a position visible when move_it_to
1359 stopped at the last line of window, which happens to be scanned
1360 backwards by the bidi iteration. (Bug#11464)
1362 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1364 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1365 and right-margin display specs even if the spec is invalid or we
1366 are on a TTY, and thus unable to display on the fringes.
1367 That's because the text with the property will not be displayed anyway,
1368 so we need to signal to the caller that this is a "replacing"
1369 display spec. This fixes display when the spec is invalid or we
1372 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1374 * unexaix.c (make_hdr): Fix typo in prototype.
1375 This bug broke the build on AIX. Problem reported by Gilles Pion.
1377 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1379 * keyboard.c (kbd_buffer_get_event): Read special events also in
1380 batch mode. (Bug#11415)
1382 2012-05-12 Glenn Morris <rgm@gnu.org>
1384 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1386 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1388 * lisp.mk (lisp): Add newcomment.elc.
1390 2012-05-12 Glenn Morris <rgm@gnu.org>
1392 * Makefile.in (MKDIR_P): New, set by configure.
1393 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1395 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1397 Remove unused function hourglass_started.
1398 * dispextern.h (hourglass_started):
1399 * w32fns.c (hourglass_started):
1400 * xdisp.c (hourglass_started): Remove.
1402 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1404 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1405 Update dependencies.
1407 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1409 * xgselect.c (xg_select): Put maxfds+1 into a var.
1410 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1412 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1414 2012-05-10 Dave Abrahams <dave@boostpro.com>
1416 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1417 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1419 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1421 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1422 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1423 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1424 Initialize xd_registered_buses.
1426 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1428 Untag more efficiently if USE_LSB_TAG.
1429 This is based on a proposal by YAMAMOTO Mitsuharu in
1430 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1431 For an admittedly artificial (nth 8000 longlist) benchmark on
1432 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1433 Emacs's overall text size by 1%.
1434 * lisp.h (XUNTAG): New macro.
1435 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1436 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1437 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1438 * eval.c (Fautoload):
1439 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1440 * frame.h (XFRAME): Use XUNTAG.
1442 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1443 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1444 Remove unportable assumptions about print widths of types like
1446 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1447 intptr_t when converting between pointer and integer, to avoid GCC
1448 warnings about wrong width.
1450 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1452 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1453 stack for each reader_thread, instead of defaulting to 8MB
1454 determined by the linker. This avoids failures in creating
1455 subprocesses on Windows 7, see the discussion in this thread:
1456 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1458 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1460 Fix up display of the *Minibuf-0* buffer in the mini window.
1461 * keyboard.c (read_char): Don't clear the echo area if there's no
1463 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1464 contents of *Minibuf-0*) if there's no message displayed in its stead.
1466 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1468 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1471 2012-05-06 Chong Yidong <cyd@gnu.org>
1473 * lisp.mk (lisp): Update.
1475 2012-05-05 Jim Meyering <meyering@redhat.com>
1477 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1479 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1481 * data.c (PUT_ERROR): New macro.
1482 (syms_of_data): Use it. Add new error type `user-error'.
1483 * undo.c (user_error): New function.
1484 (Fprimitive_undo): Use it.
1485 * print.c (print_error_message): Adjust print style for `user-error'.
1486 * keyboard.c (user_error): New function.
1487 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1489 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1491 Do not limit current-time-string to years 1000..9999.
1492 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1493 (Fcurrent_time_string): Support any year that is supported by the
1494 underlying localtime representation. Don't use asctime, as it
1495 has undefined behavior for years outside the range -999..9999.
1497 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1499 Fix race conditions involving setenv, gmtime, localtime, asctime.
1500 Without this fix, interrupts could mess up code that uses these
1501 nonreentrant functions, since setting TZ invalidates existing
1502 tm_zone or tzname values, and since most of these functions return
1503 pointers to static storage.
1504 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1505 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1506 Grow the critical sections to include not just invoking
1507 localtime/gmtime, but also accessing these functions' results
1508 including their tm_zone values if any, and any related TZ setting.
1509 (format_time_string): Last arg is now struct tm *, not struct tm **,
1510 so that the struct tm is saved in the critical section.
1511 All callers changed. Simplify allocation of initial buffer, partly
1512 motivated by the fact that memory allocation needs to be outside
1513 the critical section.
1515 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1517 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1518 with RESET_INTERVAL.
1520 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1521 Remove duplicated buffer name initialization.
1523 2012-05-02 Jim Meyering <jim@meyering.net>
1525 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1527 * xfns.c (x_window): Use xstrdup (Bug#11375).
1529 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1531 * xdisp.c (pos_visible_p): If already at a newline from the
1532 display string before the 'while' loop, don't walk back the glyphs
1533 from it3.glyph_row. Solves assertion violation when the display
1534 string begins with a newline (egg.el). (Bug#11367)
1536 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1538 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1541 2012-05-01 Glenn Morris <rgm@gnu.org>
1543 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1544 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1545 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1546 All were removed before 23.1.
1548 * dispnew.c: Remove HAVE_LIBNCURSES test;
1549 it is always true on relevant platforms.
1551 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1552 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1554 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1556 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1558 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1559 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1562 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1564 Do not avoid creating empty evaporating overlays (Bug#9642).
1565 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1566 That is, do not delete an evaporating overlay if it becomes
1567 empty after its bounds are adjusted to fit within its buffer.
1568 This fix caused other problems, and I'm reverting it until we get
1569 to the bottom of them.
1571 2012-04-27 Chong Yidong <cyd@gnu.org>
1573 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1575 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1577 * xdisp.c (pos_visible_p): If the window start position is beyond
1578 ZV, start the display from buffer beginning. Prevents assertion
1579 violation in init_iterator when the minibuffer window is scrolled
1582 * window.c (window_scroll_pixel_based): Likewise.
1584 2012-04-27 Chong Yidong <cyd@gnu.org>
1586 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1588 2012-04-27 Glenn Morris <rgm@gnu.org>
1590 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1591 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1593 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1595 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1596 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1598 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1600 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1601 display element, check also the underlying string or buffer
1602 character. (Bug#11341)
1604 * w32menu.c: Include w32heap.h.
1605 (add_menu_item): If the call to AppendMenuW (via
1606 unicode_append_menu) fails, disable Unicode menus only if we are
1607 running on Windows 9X/Me.
1609 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1611 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1612 (xgetint): Add missing shift for LSB tags.
1614 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1616 * keyboard.c (read_char): Don't wipe echo area for select window
1617 events: These might get delayed via `mouse-autoselect-window'
1620 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1622 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1623 manipulation of :loaded-from data.
1625 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1627 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1628 now a cons (bug#11311).
1630 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1632 Do not create empty overlays with the evaporate property (Bug#9642).
1633 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1634 if it becomes empty after its bounds are adjusted to fit within
1635 its buffer. Without this fix, in a nonempty buffer (let ((o
1636 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1637 yields an empty overlay that has the evaporate property, which is
1638 not supposed to happen.
1640 Fix minor GTK3 problems found by static checking.
1641 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1642 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1643 (struct _EmacsFixedClass, emacs_fixed_get_type):
1644 Move decls here from emacsgtkfixed.h, since they needn't be public.
1645 (emacs_fixed_get_type): Now static.
1646 (emacs_fixed_class_init): Omit unused local.
1647 (emacs_fixed_child_type): Remove; unused.
1648 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1649 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1650 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1651 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1652 (EMACS_FIXED_GET_CLASS): Remove; unused.
1653 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1655 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1656 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1658 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1660 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1661 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1662 (__malloc_size_t, __malloc_ptrdiff_t):
1663 Remove. All uses removed, replaced by the definiens if needed,
1664 since we can assume C89 or better now.
1665 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1666 (protect_malloc_state, align, get_contiguous_space)
1667 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1668 (malloc_atfork_handler_child, malloc_enable_thread)
1669 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1670 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1671 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1672 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1673 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1674 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1675 Define using prototypes, not old style.
1676 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1677 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1678 (align): Don't assume that signed integer overflow wraps around.
1679 Omit unused local var.
1680 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1681 (_free_internal_nolock, memalign, mallochook, reallochook):
1682 Omit no-longer-needed casts.
1683 (valloc): Use getpagesize, not __getpagesize.
1684 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1685 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1687 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1689 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1691 Move functions from C to Lisp. Make non-blocking method calls
1692 the default. Implement further D-Bus standard interfaces.
1694 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1695 (QCdbus_request_name_allow_replacement)
1696 (QCdbus_request_name_replace_existing)
1697 (QCdbus_request_name_do_not_queue)
1698 (QCdbus_request_name_reply_primary_owner)
1699 (QCdbus_request_name_reply_in_queue)
1700 (QCdbus_request_name_reply_exists)
1701 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1702 (QCdbus_registered_serial, QCdbus_registered_method)
1703 (QCdbus_registered_signal): New Lisp objects.
1704 (XD_DEBUG_MESSAGE): Use sizeof.
1705 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1706 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1707 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1708 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1709 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1710 (xd_signature, xd_append_arg): Allow float for integer types.
1711 (xd_get_connection_references): New function.
1712 (xd_get_connection_address): Rename from xd_initialize.
1713 Return cached address.
1714 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1715 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1717 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1718 Return number of refcounts.
1719 (Fdbus_get_unique_name): Make stronger parameter check.
1720 (Fdbus_message_internal): New defun.
1721 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1722 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1723 (Fdbus_send_signal, Fdbus_register_service)
1724 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1725 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1726 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1727 (Vdbus_compiled_version, Vdbus_runtime_version)
1728 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1729 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1730 (Vdbus_message_type_signal): New defvars.
1731 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1734 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1736 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1737 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1738 Do not assume ptrdiff_t is the same width as 'int'.
1740 * alloc.c: Handle unusual debugging option combinations.
1741 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1742 since the two debugging options are incompatible.
1743 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1745 (mem_init, mem_insert, mem_insert_fixup):
1746 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1747 (NEED_MEM_INSERT): Remove; no longer needed.
1749 2012-04-22 Leo Liu <sdl.web@gmail.com>
1751 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1753 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1755 * sysdep.c [__FreeBSD__]: Minor cleanups.
1756 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1757 Use Emacs indenting style more consistently. Avoid some casts.
1758 Use 'double' consistently rather than mixing 'float' and 'double'.
1760 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1762 * sysdep.c (list_system_processes, system_process_attributes):
1763 Add implementation for FreeBSD (Bug#5243).
1765 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1767 * lisp.mk (lisp): Update.
1769 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1771 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1772 It is never used otherwise.
1774 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1776 * print.c (print_preprocess): Only check print_depth if print-circle
1778 (print_object): Check for cycles even when print-circle is nil and
1779 print-gensym is t, but only check print_depth if print-circle is nil.
1781 2012-04-20 Chong Yidong <cyd@gnu.org>
1783 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1784 set the status to "failed" and ensure that sentinel is run.
1786 2012-04-20 Glenn Morris <rgm@gnu.org>
1788 * process.c (Fset_process_inherit_coding_system_flag)
1789 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1790 (Fmake_network_process, Fmake_serial_process): Doc fix.
1792 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1794 * xdisp.c (string_buffer_position_lim): Limit starting position to
1796 (set_cursor_from_row): If called for a mode-line or header-line
1797 row, return zero immediately.
1798 (try_cursor_movement): If inside continuation line, don't back up
1799 farther than the first row after the header line, if any.
1800 Don't consider the header-line row as "partially visible", even if
1801 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1803 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1805 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1808 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1809 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1811 configure: new option --enable-gcc-warnings (Bug#11207)
1812 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1813 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1814 (ALL_CFLAGS): Use new macros rather than old.
1815 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1816 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1817 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1818 -Wunused-result, -Wunused-variable. This should go away once
1819 the Emacs and Gnulib regex code is merged.
1820 (xmalloc, xrealloc): Now static.
1822 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1824 * dired.c (Fsystem_groups): Remove unused local.
1826 2012-04-17 Glenn Morris <rgm@gnu.org>
1828 * dired.c (Fsystem_users): Doc fix.
1830 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1832 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1833 (syms_of_dired): Add them.
1835 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1837 Fix minor alloc.c problems found by static checking.
1838 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1839 New extern decls, to avoid calling undeclared functions.
1840 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1841 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1842 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1843 (NEED_MEM_INSERT): New macro.
1844 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1845 Remove one incorrect comment and fix another.
1847 Fix minor ralloc.c problems found by static checking.
1848 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1849 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1850 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1851 (r_alloc_sbrk): Now static.
1853 Improve ralloc.c interface checking.
1854 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1855 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1856 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1857 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1858 [REL_ALLOC]: ... to here, to check interface.
1859 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1860 Remove decls. This fixes an "It stinks!".
1862 * alloc.c (which_symbols): Fix alignment issue / type clash.
1864 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1866 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1867 (struct Lisp_Misc_Any): Likewise.
1868 (struct Lisp_Free): Likewise.
1869 * alloc.c (union aligned_Lisp_Symbol): Define.
1870 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1871 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1872 (union aligned_Lisp_Misc): Define.
1873 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1874 aligned_Lisp_Misc instead of union Lisp_Misc.
1875 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1877 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1879 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1880 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1881 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1882 * s/netbsd.h, s/sol2-6.h:
1883 Remove definition of GC_MARK_STACK, since the default now works.
1884 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1885 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1886 no longer the default.
1887 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1889 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1891 * lread.c (lisp_file_lexically_bound_p):
1892 Fix hang at ";-*-\n" (bug#11238).
1894 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1896 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1897 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1899 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1901 * nsterm.m (constrainFrameRect): Always constrain when there is only
1902 one screen (Bug#10962).
1904 2012-04-13 Ken Brown <kbrown@cornell.edu>
1906 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1908 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1910 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1912 2012-04-11 Daniel Colascione <dancol@dancol.org>
1914 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1915 against is gone. It's better to use vfork now so that when Cygwin
1916 gains a new, working vfork, we use it automatically (bug#10398).
1918 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1920 * window.c (save_window_save): Obey window-point-insertion-type.
1922 2012-04-11 Glenn Morris <rgm@gnu.org>
1924 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1926 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1928 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1930 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1932 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1933 (force_quit_count): New var.
1934 (handle_interrupt): Use it.
1936 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1938 * w32.c (w32_delayed_load): Record the full path of the library
1939 being loaded (bug#10424).
1941 2012-04-09 Glenn Morris <rgm@gnu.org>
1943 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1944 not just in the obarray, before snarfing them. (Bug#11036)
1946 * Makefile.in ($(leimdir)/leim-list.el):
1947 Pass EMACS rather than BUILT_EMACS.
1949 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1951 * process.c (make_process):
1952 * process.h: Add integer `gnutls_handshakes_tried' member to
1955 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1956 Add convenience `GNUTLS_LOG2i' macro.
1958 * gnutls.c (gnutls_log_function2i): Convenience log function.
1959 (emacs_gnutls_read): Use new log functions,
1960 `gnutls_handshakes_tried' process member, and
1961 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1962 attempts per process (connection).
1964 2012-04-09 Chong Yidong <cyd@gnu.org>
1966 * eval.c (Fuser_variable_p, user_variable_p_eh)
1967 (lisp_indirect_variable): Functions deleted.
1968 (Fdefvar): Caller changed.
1970 * callint.c (Finteractive, Fcall_interactively):
1971 * minibuf.c (Fread_variable): Callers changed.
1973 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1975 * xdisp.c (set_cursor_from_row): If the display string appears in
1976 the buffer at position that is closer to point than the position
1977 after the display string, display the cursor on the first glyph of
1978 the display string. Fixes cursor display when a 'display' text
1979 property immediately follows invisible text. (Bug#11094)
1981 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1983 composite.c: use 'double' consistently
1984 * composite.c (get_composition_id): Use 'double' consistently
1985 instead of converting 'float' to 'double' and vice versa; this is
1986 easier to understand and avoids a GCC warning.
1988 2012-04-09 Glenn Morris <rgm@gnu.org>
1990 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1991 preparation for dumping it with emacs. (Bug#4789)
1992 (leimdir): New variable.
1993 ($(leimdir)/leim-list.el): New rule.
1994 (emacs$(EXEEXT)): Depend on leim-list.el.
1996 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1997 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1998 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2000 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2002 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2005 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2007 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2008 Remove unused local variable.
2010 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2012 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2013 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2014 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2015 objects, as mark_maybe_pointer will catch them otherwise.
2016 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2017 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2019 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2021 Fix typo that broke non-Windows builds.
2022 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2024 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2026 Support building on MS-Windows with libxml2.
2028 * makefile.w32-in (OBJ2): Add xml.$(O).
2029 (GLOBAL_SOURCES): Add xml.c.
2030 ($(BLD)/xml.$(O)): New dependency list.
2032 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2033 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2034 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2035 [!WINDOWSNT]: New macros.
2036 (init_libxml2_functions, libxml2_loaded_p): New functions.
2037 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2038 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2039 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2040 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2042 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2043 Call init_libxml2_functions before calling libxml2 functions.
2044 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2046 * emacs.c: Don't include libxml/parser.h.
2047 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2048 xmlCleanupParser directly.
2050 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2052 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2054 * indent.c (Fvertical_motion): If there is a display string at
2055 point, use it.vpos to compute how many lines to backtrack after
2056 move_it_to point. (Bug#11133)
2058 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2060 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2061 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2062 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2063 macros related to unification of CJK characters. For the details,
2064 see the discussion following the message here:
2065 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2067 2012-04-04 Chong Yidong <cyd@gnu.org>
2069 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2071 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2073 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2074 instead of alloca. (Bug#11138)
2076 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2078 * w32menu.c (is_simple_dialog): Properly check lisp types.
2081 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2083 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2084 position we get to after a call to move_it_to fails the
2085 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2086 only if we wind up in a string from display property. (Bug#11063)
2088 * window.c (Fdelete_other_windows_internal): Invalidate the row
2089 and column information about mouse highlight, so that redisplay
2090 restores it after reallocating the glyph matrices. (Bug#7464)
2092 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2093 string comes from a `display' text property, use the buffer
2094 position of that property as if we actually saw that position in
2096 (move_it_by_lines): Remove the assertion that
2097 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2098 violated when there's a before-string at the beginning of a line.
2101 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2103 * xdisp.c (append_space_for_newline): If the default face was
2104 remapped, use the remapped face for the appended newline.
2105 (extend_face_to_end_of_line): Use the remapped default face for
2106 extending the face to the end of the line.
2107 (display_line): Call extend_face_to_end_of_line when the default
2108 face was remapped. (Bug#11068)
2110 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2112 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2114 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2116 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2118 2012-03-27 Glenn Morris <rgm@gnu.org>
2120 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2123 2012-03-26 Kenichi Handa <handa@m17n.org>
2125 * dispextern.h (struct glyph): Fix previous change. Change the
2126 bit length of glyphless.ch to 25 (Bug#11082).
2128 2012-03-26 Chong Yidong <cyd@gnu.org>
2130 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2131 (command_loop_1): Use it; inhibit selection update for
2132 handle-select-window too (Bug#8996).
2134 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2136 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2138 2012-03-25 Kenichi Handa <handa@m17n.org>
2140 * dispextern.h (struct glyph): Change the bit length of
2141 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2143 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2145 * s/ms-w32.h (tzname): Include time.h before redirecting to
2146 _tzname. Fixes the MSVC build. (Bug#9960)
2148 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2150 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2153 * xterm.c (XTread_socket): Only modify handling_signal if
2154 !SYNC_INPUT. (Bug#11080)
2156 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2158 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2159 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2160 when fetching a multibyte character consumes more bytes than
2161 CHAR_BYTES returns, due to unification of CJK characters in
2162 string_char. (Bug#11073)
2164 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2166 * process.c (wait_reading_process_output): Handle pty disconnect
2167 by refraining from sending oneself a SIGCHLD (bug#10933).
2169 2012-03-22 Chong Yidong <cyd@gnu.org>
2171 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2173 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2174 Mark string as coming from a prefix property.
2175 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2176 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2178 2012-03-21 Chong Yidong <cyd@gnu.org>
2180 * xfaces.c (Vface_remapping_alist): Doc fix.
2182 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2184 * w32proc.c (Fw32_set_console_codepage)
2185 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2188 2012-03-20 Chong Yidong <cyd@gnu.org>
2190 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2191 to reflect default non-nil value of redisplay-dont-pause.
2193 2012-03-19 Kenichi Handa <handa@m17n.org>
2195 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2196 it fit in a valid range (Bug#11003).
2198 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2200 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2201 that is not from display property, accept the row as a "cursor
2202 row" if one of the string's character has a non-nil `cursor'
2203 property. Fixes cursor positioning when there are newlines in
2204 overlay strings, e.g. in icomplete.el. (Bug#11035)
2206 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2208 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2210 2012-03-12 Chong Yidong <cyd@gnu.org>
2212 * eval.c (inhibit_lisp_code): Rename from
2213 inhibit_window_configuration_change_hook; move from window.c.
2215 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2216 * window.c (run_window_configuration_change_hook)
2217 (syms_of_window): Callers changed.
2219 2012-03-11 Chong Yidong <cyd@gnu.org>
2221 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2223 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2225 2012-03-10 Chong Yidong <cyd@gnu.org>
2227 * frame.c (other_visible_frames): Don't assume the selected frame
2228 is visible (Bug#10955).
2230 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2232 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2234 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2236 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2237 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2240 2012-03-03 Glenn Morris <rgm@gnu.org>
2242 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2244 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2246 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2247 position past the first glyph_row that ends at ZV. (Bug#10902)
2248 (redisplay_window, next_element_from_string): Fix typos in
2250 (redisplay_window): Pass to move_it_vertically the margin in
2251 pixels, not in screen lines.
2253 2012-03-02 Glenn Morris <rgm@gnu.org>
2255 * buffer.c (buffer-list-update-hook): Doc fix.
2257 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2259 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2260 push_it before setting up the iterator for the first overlay
2261 string, even if we have an empty string loaded.
2262 (next_overlay_string): If there's an empty string on the iterator
2263 stack, pop the stack. (Bug#10903)
2265 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2267 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2268 Suggested by Stefan Monnier in
2269 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2270 * alloc.c (widen_to_Lisp_Object): New static function.
2271 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2272 and widening them to Lisp_Objects. This would work even if
2273 USE_LSB_TAG is defined and wide integers are used, which might
2274 happen in a future version of Emacs.
2276 2012-02-25 Chong Yidong <cyd@gnu.org>
2278 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2281 * xselect.c (Fx_selection_exists_p): Doc fix.
2282 (x_clipboard_manager_save_all): Print an informative message
2283 before saving to clipboard manager.
2285 2012-02-24 Chong Yidong <cyd@gnu.org>
2287 * keyboard.c (process_special_events): Handle all X selection
2288 requests in kbd_buffer, not just the next one (Bug#8869).
2290 2012-02-23 Chong Yidong <cyd@gnu.org>
2292 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2293 call when setting menu-bar-lines and tool-bar-lines parameters.
2294 (unwind_create_frame_1): New helper function.
2296 * window.c (inhibit_window_configuration_change_hook): New var.
2297 (run_window_configuration_change_hook): Obey it.
2298 (syms_of_window): Initialize it.
2300 2012-02-22 Chong Yidong <cyd@gnu.org>
2302 * xterm.c (x_draw_image_relief): Add missing type check for
2303 Vtool_bar_button_margin (Bug#10743).
2305 2012-02-21 Chong Yidong <cyd@gnu.org>
2307 * fileio.c (Vfile_name_handler_alist): Doc fix.
2309 * buffer.c (Fget_file_buffer): Protect against invalid file
2310 handler return value.
2312 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2314 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2315 when computing $valmask.
2317 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2318 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2319 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2320 It's useless in that case, and it can cause problems on hosts
2321 that allocate halves of EMACS_INT values separately.
2322 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2323 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2324 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2325 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2326 it avoids undefined behavior on hosts where shifting right by more
2327 than the word width has undefined behavior.
2329 2012-02-19 Chong Yidong <cyd@gnu.org>
2331 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2332 (Funhandled_file_name_directory, Ffile_name_as_directory)
2333 (Fdirectory_file_name, Fexpand_file_name)
2334 (Fsubstitute_in_file_name): Protect against invalid file handler
2335 return values (Bug#10845).
2337 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2339 * .gdbinit (pitx): Fix incorrect references to fields of the
2342 2012-02-17 Chong Yidong <cyd@gnu.org>
2344 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2346 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2348 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2349 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2351 2012-02-15 Chong Yidong <cyd@gnu.org>
2353 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2354 marked as special. Also, starting docstrings with * is obsolete.
2356 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2358 * gnutls.c (emacs_gnutls_write): Fix last change.
2360 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2362 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2365 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2367 * keymap.c (Fsingle_key_description): Handle char ranges.
2369 2012-02-12 Chong Yidong <cyd@gnu.org>
2371 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2372 as that creates a dangerous corner case.
2374 * window.c (Fdelete_window_internal): Invalidate the mouse
2375 highlight (Bug#9904).
2377 2012-02-12 Glenn Morris <rgm@gnu.org>
2379 * xselect.c (Fx_own_selection_internal)
2380 (Fx_get_selection_internal, Fx_disown_selection_internal)
2381 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2382 * nsselect.m (Fx_own_selection_internal)
2383 (Fx_disown_selection_internal, Fx_selection_exists_p)
2384 (Fx_selection_owner_p, Fx_get_selection_internal):
2385 Sync docs and argument specs with the xselect.c versions.
2387 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2389 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2391 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2393 * w32select.c (Fx_selection_exists_p): Sync doc string and
2394 argument list with xselect.c. (Bug#10783)
2396 * w16select.c (Fx_selection_exists_p): Sync doc string and
2397 argument list with xselect.c. (Bug#10783)
2399 2012-02-10 Glenn Morris <rgm@gnu.org>
2401 * fns.c (Fsecure_hash): Doc fix.
2403 2012-02-09 Kenichi Handa <handa@m17n.org>
2405 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2407 2012-02-07 Chong Yidong <cyd@gnu.org>
2409 * buffer.c (Fbuffer_local_variables)
2410 (buffer_lisp_local_variables): Handle unbound vars correctly;
2411 don't let Qunbound leak into Lisp.
2413 2012-02-07 Glenn Morris <rgm@gnu.org>
2415 * image.c (Fimagemagick_types): Doc fix.
2417 * image.c (imagemagick-render-type): Change it from a lisp object
2418 to an integer. Move the doc here from the lisp manual.
2419 Treat all values not equal to 0 the same.
2421 2012-02-06 Chong Yidong <cyd@gnu.org>
2423 * doc.c (store_function_docstring): Avoid applying docstring of
2424 alias to base function (Bug#2603).
2426 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2428 * .gdbinit (pp1, pv1): Remove redundant defines.
2431 2012-02-04 Chong Yidong <cyd@gnu.org>
2433 * nsterm.m: Declare a global (Bug#10694).
2435 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2437 * w32.c (get_emacs_configuration_options):
2438 Include --enable-checking, if specified, in the return value.
2440 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2442 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2443 after rounding frame sizes. (Bug#9723)
2445 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2447 * keyboard.c (adjust_point_for_property): Don't position point
2448 before BEGV. (Bug#10696)
2450 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2452 Handle overflow when computing char display width (Bug#9496).
2453 * character.c (char_width): Return EMACS_INT, not int.
2454 (char_width, c_string_width): Check for overflow when
2455 computing the width; this is possible now that individual
2456 characters can have unbounded width. Problem introduced
2457 by merge from Emacs 23 on 2012-01-19.
2459 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2461 * dbusbind.c (Fdbus_register_method): Mention the return value
2462 :ignore in the docstring.
2464 2012-02-02 Glenn Morris <rgm@gnu.org>
2466 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2468 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2469 Unconditionally set to t. (Bug#10673)
2470 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2471 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2472 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2474 2012-02-02 Kenichi Handa <handa@m17n.org>
2476 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2477 0, do not call append_composite_glyph.
2479 2012-02-02 Kenichi Handa <handa@m17n.org>
2481 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2483 (x_produce_glyphs): If the component of a composition is a null
2484 string, set it->pixel_width to 1 to avoid zero-width glyph.
2486 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2488 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2489 first 2 arguments are identical. This makes inserting large
2490 output from a subprocess an order of magnitude faster on
2491 MS-Windows, where all sbrk'ed memory is always contiguous.
2493 2012-01-31 Glenn Morris <rgm@gnu.org>
2495 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2496 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2497 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2499 2012-01-29 Glenn Morris <rgm@gnu.org>
2501 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2503 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2505 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2507 2012-01-28 Chong Yidong <cyd@gnu.org>
2509 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2511 2012-01-26 Chong Yidong <cyd@gnu.org>
2513 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2515 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2516 repeat counts (Bug#10507).
2518 2012-01-26 Glenn Morris <rgm@gnu.org>
2520 * lread.c (syms_of_lread): Doc fix.
2522 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2524 * coding.c (encode_designation_at_bol): Change return value to
2527 2012-01-25 Chong Yidong <cyd@gnu.org>
2529 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2531 2012-01-21 Chong Yidong <cyd@gnu.org>
2533 * floatfns.c (Fcopysign): Make the second argument non-optional,
2534 since nil is not allowed anyway.
2536 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2538 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2539 (send_process): Likewise.
2541 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2543 * window.c (save_window_save, Fcurrent_window_configuration)
2544 (Vwindow_persistent_parameters): Do not use Qstate.
2545 Rewrite doc-strings.
2547 2012-01-19 Kenichi Handa <handa@m17n.org>
2549 * character.c (char_width): New function.
2550 (Fchar_width, c_string_width, lisp_string_width):
2551 Use char_width (Bug#9496).
2553 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2555 * window.c (Vwindow_persistent_parameters): New variable.
2556 (Fset_window_configuration, save_window_save): Handle persistent
2559 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2561 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2562 thrashing the stack of the thread. (Bug#9087)
2564 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2566 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2568 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2570 * xdisp.c (rows_from_pos_range): Handle the case where the
2571 highlight ends on a newline. (Bug#10464)
2572 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2573 he end column for display of highlight that ends on a newline
2576 2012-01-11 Glenn Morris <rgm@gnu.org>
2578 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2579 from load-path also when installation-directory is nil. (Bug#10208)
2581 2012-01-10 Glenn Morris <rgm@gnu.org>
2583 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2585 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2586 Update template values to be closer to their typical values these days.
2588 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2590 * xdisp.c (rows_from_pos_range): Accept additional argument
2591 DISP_STRING, and accept any glyph in a row whose object is that
2592 string as eligible for mouse highlight. Fixes mouse highlight of
2593 display strings from overlays. (Bug#10464)
2595 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2597 emacs: fix an auto-save permissions race condition (Bug#10400)
2598 * fileio.c (auto_saving_dir_umask): New static var.
2599 (Fmake_directory_internal): Use it.
2600 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2601 creating the directory. The old code temporarily assigns
2602 too-generous permissions to the directory.
2603 (do_auto_save_eh): Clear it.
2604 (Fdo_auto_save): Catch all errors, not just file errors, so
2605 that the var is always cleared.
2607 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2609 * search.c (scan_buffer): Pass character positions to
2610 know_region_cache, not byte positions. (Bug#6540)
2612 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2614 * w32.c (sys_rename): Report EXDEV when rename of a directory
2615 fails because the target is on another logical disk. (Bug#10284)
2617 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2619 * xterm.c (x_embed_request_focus): New function.
2621 * xterm.h: Add prototype.
2623 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2625 2012-01-05 Glenn Morris <rgm@gnu.org>
2627 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2629 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2631 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2632 Load gnutls_transport_set_lowat only if GnuTLS version is below
2634 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2635 GnuTLS versions below 2.11.1.
2637 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2639 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2640 to the doc string advising against its use for altering the way
2641 windows are scrolled.
2643 2011-12-28 Kenichi Handa <handa@m17n.org>
2645 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2646 coding-system ASCII compatible only when it does not produce BOM
2647 on encoding (Bug#10383).
2649 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2651 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2653 (create_and_show_popup_menu): Always use menu_position_func for
2656 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2658 * callint.c (Fcall_interactively): Don't truncate prompt string.
2660 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2662 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2663 property that ends at ZV, so that the bidi iteration could be
2664 resumed from there (after widening). (Bug#10360)
2666 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2668 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2670 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2672 * nsterm.m (x_free_frame_resources):
2673 Release f->output_data.ns->miniimage.
2674 (ns_index_color): Fix indentation. Do not retain
2675 color_table->colors[i].
2677 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2680 * nsfns.m (x_set_background_color): Assign return value from
2681 ns_index_color to face-background instead of NSColor*.
2682 (ns_implicitly_set_icon_type): Fix indentation.
2683 Change assignment in for loop to comparison.
2685 * emacs.c (ns_pool): New variable.
2686 (main): Assign ns_pool.
2687 (Fkill_emacs): Call ns_release_autorelease_pool.
2689 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2690 autorelease fdesc, release fdAttrs and tdict.
2691 (ns_get_covering_families): Release charset.
2692 (ns_findfonts): Release NSFontDescriptor created with new.
2693 (ns_uni_to_glyphs): Fix indentation.
2694 (setString): Release attrStr before assigning new value.
2696 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2698 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2700 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2701 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2703 2011-12-18 David Reitter <reitter@cmu.edu>
2705 * nsterm.m (ns_term_init): Subscribe for notifications
2706 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2707 to method trackingNotification in EmacsMenu.
2709 * nsmenu.m (trackingMenu): New variable.
2710 (trackingNotification): New method (from Aquamacs).
2711 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2712 from Aquamacs (Bug#7030).
2714 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2716 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2717 (symbol_to_nsstring): Fix indentation.
2718 (ns_symbol_to_pb): New function.
2719 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2720 (Fns_rotate_cut_buffers_internal): Remove.
2721 (Fns_store_selection_internal): Rename from
2722 Fns_store_cut_buffer_internal.
2723 (ns_get_foreign_selection, Fx_own_selection_internal)
2724 (Fx_disown_selection_internal, Fx_selection_exists_p)
2725 (Fns_get_selection_internal, Fns_store_selection_internal):
2726 Use ns_symbol_to_pb and check if return value is nil.
2727 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2728 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2729 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2730 renamed to Sns_store_selection_internal.
2731 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2732 and remove this function.
2733 (ns_handle_selection_clear): Remove, never used.
2734 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2737 2011-12-17 Ken Brown <kbrown@cornell.edu>
2739 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2740 GID is unknown (Bug#10257).
2742 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2744 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2745 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2746 which caused a build failure on GNU/Linux IA-64. This problem was
2747 introduced by my 2011-10-07 patch.
2749 2011-12-15 Juri Linkov <juri@jurta.org>
2751 * image.c (imagemagick_error): New function. (Bug#10112)
2752 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2753 Use `imagemagick_error' where ImageMagick functions return
2755 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2758 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2760 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2761 fill background (Bug#8992).
2763 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2765 * window.c (Vwindow_combination_resize)
2766 (Vwindow_combination_limit): Use t instead of non-nil in
2768 (Vrecenter_redisplay): Add first sentence of doc-string on
2770 (Frecenter): Fix doc-string typo.
2772 2011-12-11 Kenichi Handa <handa@m17n.org>
2774 * coding.c (Funencodable_char_position): Pay attention to the
2775 buffer text relocation (Bug#9389).
2777 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2779 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2780 gtk_init (Bug#10100).
2782 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2784 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2785 IT->string is nil. (Bug#10263)
2787 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2789 * nsterm.h (x_free_frame_resources): Declare.
2791 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2792 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2794 * nsterm.h (ns_get_defaults_value): Declare.
2796 * nsterm.m (ns_default): Call ns_get_defaults_value.
2798 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2800 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2803 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2805 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2806 that where the value of an _OBJC_* symbol points to is in the .bss
2807 section (Bug#10240).
2809 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2811 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2812 after the loop to call ccl_driver at least once (Bug#8619).
2814 2011-12-08 Kenichi Handa <handa@m17n.org>
2816 * ftfont.c (get_adstyle_property): Fix previous change
2819 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2821 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2822 dirs from the default value of EMACSLOADPATH (bug#10208).
2824 2011-12-07 Glenn Morris <rgm@gnu.org>
2826 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2827 installation and source directories as well. (Bug#10208)
2829 2011-12-06 Chong Yidong <cyd@gnu.org>
2831 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2833 2011-12-06 Glenn Morris <rgm@gnu.org>
2835 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2836 as an error, not just -1. (Bug#10217)
2838 2011-12-05 Chong Yidong <cyd@gnu.org>
2840 * keyboard.c (process_special_events): New function.
2841 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2843 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2845 * coding.c (encode_designation_at_bol): Don't use uninitialized
2846 local variable (Bug#9318).
2848 2011-12-05 Kenichi Handa <handa@m17n.org>
2850 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2851 return Qnil (Bug#8046, Bug#10193).
2853 2011-12-05 Kenichi Handa <handa@m17n.org>
2855 * coding.c (encode_designation_at_bol): New args charbuf_end and
2856 dst. Return the number of produced bytes. Callers changed.
2857 (coding_set_source): Return how many bytes coding->source was
2859 (coding_set_destination): Return how many bytes
2860 coding->destination was relocated.
2861 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2862 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2864 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2866 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2867 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2870 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2872 The following changes are to fix Bug#9318.
2874 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2875 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2876 (encode_coding_iso_2022, encode_coding_sjis)
2877 (encode_coding_big5, encode_coding_charset): Use the above macros.
2879 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2881 * lisp.h (process_quit_flag): Fix external declaration.
2883 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2885 Don't macro-inline non-performance-critical code.
2886 * eval.c (process_quit_flag): New function.
2887 * lisp.h (QUIT): Use it.
2889 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2891 * nsfns.m (get_geometry_from_preferences): New function.
2892 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2894 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2896 * emacs.c (Qkill_emacs): Define.
2897 (syms_of_emacs): Initialize it.
2898 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2899 Qquit_flag to `kill-emacs' instead.
2900 (quit_throw_to_read_char): Add parameter `from_signal'.
2901 All callers changed. Call Fkill_emacs if requested and safe.
2902 * lisp.h (QUIT): Call Fkill_emacs if requested.
2904 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2906 * widget.c (update_wm_hints): Return if wmshell is null.
2907 (widget_update_wm_size_hints): New function.
2909 * widget.h (widget_update_wm_size_hints): Declare.
2911 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2912 widget_update_wm_size_hints (Bug#10104).
2914 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2916 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2917 before a newline, prepare the bidi iterator for consuming the
2918 newline, and keep the current paragraph direction. (Bug#10183)
2919 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2921 2011-12-02 Juri Linkov <juri@jurta.org>
2923 * search.c (Fword_search_regexp): New Lisp function created from
2924 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2925 (Fword_search_backward, Fword_search_forward)
2926 (Fword_search_backward_lax, Fword_search_forward_lax):
2927 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2928 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2930 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2932 * fileio.c (Finsert_file_contents): Move after-change-function call
2933 to before the "handled:" label, since all "goto handled" appear in
2934 cases where the *-change-functions have already been properly called
2937 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2939 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2940 waiting for input. (Bug#10169)
2942 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2944 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2945 verifies glyph row's hash code--we have just reallocated the
2946 glyphs, so their contents can be complete garbage. (Bug#10164)
2948 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2950 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2952 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2954 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2955 attributes are tested _before_ calling verify_row_hash, to protect
2956 against GCC re-ordering of the tests. (Bug#10164)
2958 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2960 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2962 * xterm.c (handle_one_xevent): Only set async_visible and friends
2963 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2964 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2965 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2967 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2969 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2970 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2971 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2972 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2973 All uses changed to use GCPRO1 etc.
2974 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2975 Revert to old implementation (i.e., before 2011-03-11).
2977 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2979 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2980 of scroll runs so as to avoid assigning disabled bogus rows and
2981 unnecessary graphics copy operations.
2983 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2985 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2986 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2987 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2988 (malloc, free, realloc, calloc): Redirect to e_* only when
2991 * lisp.h (GCTYPEBITS): Move before first use.
2992 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2993 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2994 this macro definition.
2996 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2999 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3001 * gtkutil.c (xg_create_frame_widgets):
3002 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3003 present with Gtk+ 2.0.
3005 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3007 * fileio.c (Finsert_file_contents): Undo previous change; see
3008 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3010 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3012 Rename locals to avoid shadowing.
3013 * fileio.c (Finsert_file_contents):
3014 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3015 * process.c (wait_reading_process_output):
3016 Rename inner 'proc' to 'p' to avoid shadowing.
3017 Indent for consistency with usual Emacs style.
3019 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3021 * xdisp.c (redisplay_window): If cursor row is not fully visible
3022 after recentering, and scroll-conservatively is set to a large
3023 number, scroll window by a few more lines to make the cursor fully
3024 visible and out of scroll-margin. (Bug#10105)
3025 (start_display): Don't move to the next line if the display should
3026 start at a newline that is part of a display vector or an overlay
3029 2011-11-24 Juri Linkov <juri@jurta.org>
3031 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3032 after the `MagickPingImage' call. (Bug#10112)
3034 2011-11-23 Chong Yidong <cyd@gnu.org>
3036 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3038 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3040 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3041 making another buffer current. (Bug#10114)
3043 2011-11-23 Glenn Morris <rgm@gnu.org>
3045 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3047 2011-11-23 Chong Yidong <cyd@gnu.org>
3049 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3050 using it (Bug#5984).
3052 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3054 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3055 and header-lines, as they don't have one computed for them.
3058 * .gdbinit (prow): Make displayed values more self-explaining.
3059 Add row's hash code.
3061 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3063 * process.c (wait_reading_process_output): Fix asynchrounous
3064 GnuTLS socket handling on some versions of the GnuTLS library.
3065 (wait_reading_process_output): Add comment and URL.
3067 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3069 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3071 2011-11-21 Chong Yidong <cyd@gnu.org>
3073 * window.c (Fnext_window, Fprevious_window): Doc fix.
3075 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3077 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3079 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3081 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3083 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3085 * window.c (Fset_window_combination_limit): Rename argument
3087 (Vwindow_combination_limit): Remove "status" from doc-string.
3089 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3091 * m/ibms390.h: Remove.
3092 * m/ibms390x.h: Don't include "ibms390.h".
3094 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3096 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3097 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3099 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3101 * casetab.c (Fset_case_table):
3102 * charset.c (Fcharset_after): Fix typos.
3104 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3106 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3107 Otherwise, valgrind does not work on some platforms.
3108 Problem reported by Andreas Schwab in
3109 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3110 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3111 is set, removing the need for VIRT_ADDRESS_VARIES.
3112 (PURE_P): Use a more-efficient implementation that needs just one
3113 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3114 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3115 to 4 (xorl, subq, cmpq, setbe).
3116 * alloc.c (pure): Always extern now, since that's the
3117 VIRT_ADDR_VARIES behavior.
3118 (PURE_POINTER_P): Use a single comparison, not two, for
3119 consistency with the new puresize.h.
3120 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3121 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3122 Remove VIRT_ADDR_VARIES no longer needed.
3124 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3126 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3127 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3128 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3129 behave as if the cursor position were at the window margin.
3131 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3132 and the cursor position is out of bounds, behave as if the cursor
3133 position were at the window margin. (Bug#10075)
3135 2011-11-18 Chong Yidong <cyd@gnu.org>
3137 * window.c (Fwindow_combination_limit): Make first argument
3138 non-optional, since it is meaningless for live windows like the
3141 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3143 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3145 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3147 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3148 (graft_intervals_into_buffer): Simplify.
3150 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3152 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3153 hash values of the two rows.
3154 (copy_row_except_pointers): Preserve the used[] arrays and the
3155 hash values of the two rows. (Bug#10035)
3156 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3158 * xdisp.c (row_hash): New function, body extracted from
3159 compute_line_metrics.
3160 (compute_line_metrics): Call row_hash, instead of computing the
3163 * dispnew.c (verify_row_hash): Call row_hash for computing the
3164 hash code of a row, instead of duplicating code from xdisp.c.
3166 * dispextern.h (row_hash): Add prototype.
3168 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3170 * frame.c (delete_frame): Don't delete the terminal when the last
3171 X frame is closed if emacs is built with GTK toolkit.
3173 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3175 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3177 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3179 * window.c (Vwindow_splits): Rename to
3180 Vwindow_combination_resize. Suggested by Juri Linkov.
3181 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3184 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3186 * nsfns.m (Fns_font_name):
3187 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3189 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3191 * window.h (window): Rename slot "nest" to "combination_limit".
3192 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3193 (Fset_window_nest): Rename to Fset_window_combination_limit.
3194 (Vwindow_nest): Rename to Vwindow_combination_limit.
3195 (recombine_windows, make_parent_window, make_window)
3196 (Fsplit_window_internal, saved_window)
3197 (Fset_window_configuration, save_window_save): Rename all
3198 occurrences of window_nest to window_combination_limit.
3200 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3202 * image.c (imagemagick_load_image): Fix typo.
3204 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3206 * xdisp.c (display_line): Move the call to
3207 highlight_trailing_whitespace before the call to
3208 compute_line_metrics, since the latter needs to see the final
3209 faces of all the glyphs to compute ROW's hash value.
3210 Fixes assertion violations in row_equal_p. (Bug#10035)
3212 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3214 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3215 just return (bug#10044).
3217 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3219 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3220 with user-defined heap size. Bump the default size of the temacs
3221 heap to 27MB, to avoid memory warning when running temacs.
3222 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3224 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3225 current_matrix and desired_matrix. (Bug#9990)
3226 (verify_row_hash) [XASSERTS]: New function.
3227 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3228 that the hash value of glyph rows is correct.
3230 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3232 * window.h (window): Remove splits slot.
3233 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3234 (Fdelete_other_windows_internal, make_parent_window)
3235 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3236 (Fset_window_configuration, save_window_save): Don't deal with
3237 split status of windows.
3238 (saved_window): Remove splits slot.
3239 (Vwindow_splits): Rewrite doc-string.
3241 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3243 * xfns.c (unwind_create_frame):
3244 * nsfns.m (unwind_create_frame):
3245 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3246 Vframe_list (Bug#9999).
3248 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3250 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3252 2011-11-11 Kenichi Handa <handa@m17n.org>
3254 * callproc.c (Fcall_process): Set the member dst_multibyte of
3257 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3259 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3260 avoid a crash (bug#9496).
3262 2011-11-09 Chong Yidong <cyd@gnu.org>
3264 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3265 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3267 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3269 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3271 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3273 Avoid some portability problems by eschewing 'extern inline' functions.
3274 The trivial performance wins aren't worth the portability hassles; see
3275 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3277 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3278 (window_box_width, window_box_left, window_box_left_offset)
3279 (window_box_right, window_box_right_offset): Undo previous change,
3280 by removing the "extern"s.
3281 * intervals.c (adjust_intervals_for_insertion)
3282 (adjust_intervals_for_deletion): Undo previous change,
3283 making these static again.
3284 (offset_intervals, temp_set_point_both, temp_set_point)
3285 (copy_intervals_to_string): No longer inline.
3286 * xdisp.c (window_text_bottom_y, window_box_width)
3287 (window_box_height, window_box_left_offset)
3288 (window_box_right_offset, window_box_left, window_box_right)
3289 (window_box): No longer inline.
3291 2011-11-08 Chong Yidong <cyd@gnu.org>
3293 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3294 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3295 Signal an error if not a live window.
3296 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3297 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3299 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3301 * lisp.h (syms_of_abbrev): Remove declaration.
3302 Reported by CHENG Gao <chenggao@royau.me>.
3304 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3306 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3307 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3308 of temacs in GUI mode.
3310 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3312 * window.h: Declare delete_all_child_windows instead of
3313 delete_all_subwindows.
3314 * window.c (Fwindow_nest, Fset_window_nest)
3315 (Fset_window_new_total, Fset_window_new_normal)
3316 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3317 (delete_all_subwindows): Rename to delete_all_child_windows.
3318 (Fdelete_other_windows_internal, Fset_window_configuration):
3319 Call delete_all_child_windows instead of delete_all_subwindows.
3320 * frame.c (delete_frame): Call delete_all_child_windows instead
3321 of delete_all_subwindows.
3323 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3325 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3326 This is also needed for porting to any host where GC_MARK_STACK is
3327 not GC_MAKE_GCPROS_NOOPS.
3328 (which_symbols): Use it.
3330 2011-11-07 Kenichi Handa <handa@m17n.org>
3332 * coding.c (coding_set_destination): Check coding->src_pos only
3333 when coding->src_object is a buffer (bug#9910).
3335 * process.c (send_process): Set the member src_multibyte of coding
3336 to 0 (bug#9911) when sending a unibyte text.
3338 * callproc.c (Fcall_process): Set the member src_multibyte of
3339 process_coding to 0 (bug#9912).
3341 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3343 * xmenu.c (cleanup_widget_value_tree): New function.
3344 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3345 calling free_menubar_widget_value_tree directly (Bug#9830).
3347 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3349 Fix some portability problems with 'inline'.
3350 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3351 (window_box_width, window_box_left, window_box_left_offset)
3352 (window_box_right, window_box_right_offset): Declare extern.
3353 Otherwise, these inline functions do not conform to C99 and
3354 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3355 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3356 * intervals.c (adjust_intervals_for_insertion)
3357 (adjust_intervals_for_deletion): Now extern, because otherwise the
3358 extern inline functions 'offset_intervals' couldn't refer to it.
3359 (static_offset_intervals): Remove.
3360 (offset_intervals): Rewrite using the old contents of
3361 static_offset_intervals. The old version didn't conform to C99
3362 because an extern inline function contained a reference to an
3363 identifier with static linkage.
3365 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3367 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3370 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3372 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3373 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3374 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3375 return Qleft_to_right.
3377 2011-11-06 Chong Yidong <cyd@gnu.org>
3379 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3380 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3381 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3382 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3383 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3384 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3385 (Fwindow_vscroll): Doc fix.
3386 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3387 argument, since it makes no sense to pass a live window and for
3388 consistency with window-child.
3390 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3392 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3395 2011-11-05 Jason Rumney <jasonr@gnu.org>
3397 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3398 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3400 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3401 bitwise arithmetic preventing use of unicode-sip and non-truetype
3404 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3406 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3409 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3410 initialization code to keep similarity to xfns.c after changes
3413 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3415 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3416 (unwind_create_frame): New function (Bug#9943).
3417 (Fx_create_frame): Restructure code to be more similar to the one in
3418 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3419 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3420 Move terminal->reference_count++ just before making the frame official
3423 * nsterm.m (x_free_frame_resources): New function.
3424 (x_destroy_window): Move code to x_free_frame_resources.
3426 * xfns.c (unwind_create_frame): Fix comment.
3427 (Fx_create_frame, x_create_tip_frame):
3428 Move terminal->reference_count++ just before making the frame
3429 official. Move initialization of image_cache_refcount and
3430 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3432 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3434 Support MSVC build with newer versions of Visual Studio.
3435 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3436 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3439 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3440 which are not supported by MSVC.
3441 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3442 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3444 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3446 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3448 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3450 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3452 Support MSVC build with newer versions of Visual Studio.
3453 * w32.c: Don't include w32api.h for MSVC.
3454 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3456 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3457 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3458 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3459 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3461 (alloca) [_MSC_VER]: Define to _alloca.
3463 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3465 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3467 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3469 * xdisp.c (note_mouse_highlight): If either of
3470 previous/next-single-property-change returns nil, treat that as
3471 the beginning or the end of the buffer. (Bug#9955)
3473 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3475 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3476 label is not null (Bug#9951).
3477 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3480 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3482 * window.c (Fwindow_body_size): Mention in the doc string that the
3483 return value is in frame's canonical units. (Bug#9949)
3485 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3487 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3489 * w32fns.c (unwind_create_frame): If needed, free the glyph
3490 matrices of the partially constructed frame. (Bug#9943)
3491 * xfns.c (unwind_create_frame): Likewise.
3493 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3495 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3496 Don't stop backward scan on the continuation glyph, even though
3497 its CHARPOS is positive.
3498 (mouse_face_from_buffer_pos, note_mouse_highlight):
3499 Rename cover_string to disp_string.
3501 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3503 * window.c (temp_output_buffer_show): Don't use
3504 Vtemp_buffer_show_specifiers.
3505 (Vtemp_buffer_show_specifiers): Remove unused variable.
3507 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3509 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3510 past the beginning of the current glyph matrix.
3512 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3514 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3515 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3516 HAVE_GTK3 (Bug#9869).
3518 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3519 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3521 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3523 * xterm.c: Declare x_handle_net_wm_state to return int.
3524 (handle_one_xevent): Check if we are iconified but don't have
3525 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3526 (get_current_wm_state): Return non-zero if not hidden,
3527 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3528 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3529 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3530 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3532 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3534 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3535 so that this new function doesn't get optimized away by a
3536 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3538 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3540 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3542 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3544 Fix the `xbytecode' command.
3545 * .gdbinit (xprintbytestr): New command.
3546 (xwhichsymbols): Rename from `which'; all callers changed.
3547 (xbytecode): Print the byte-code string as well.
3549 2011-10-29 Kim Storm <storm@cua.dk>
3551 * alloc.c (which_symbols): New function.
3553 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3555 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3558 2011-10-29 Glenn Morris <rgm@gnu.org>
3560 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3561 Not clear what it was for, and it causes various bugs. (Bug#9839)
3563 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3565 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3566 possible random value that matches one of those tested as
3567 condition to clear the mouse face.
3569 2011-10-28 Chong Yidong <cyd@gnu.org>
3571 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3573 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3575 * window.c (make_window): Initialize phys_cursor_on_p.
3577 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3579 * lisp.h (struct Lisp_Symbol): Update comments.
3581 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3583 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3585 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3587 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3588 <oslsachem@gmail.com> for helping to debug this.
3590 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3591 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3592 (g_b_init_get_glyph_outline_w): New static variables.
3593 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3594 (GetGlyphOutlineW_Proc): New typedefs.
3595 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3596 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3598 (w32font_open_internal, compute_metrics):
3599 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3600 instead of calling the "wide" APIs directly.
3602 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3604 * w32.h (syms_of_w32font): Add prototype.
3606 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3608 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3609 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3610 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3611 (Fmove_to_window_line): Doc fix.
3613 2011-10-27 Chong Yidong <cyd@gnu.org>
3615 * process.c (make_process): Set gnutls_state to NULL.
3617 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3618 non-NULL, regardless of GNUTLS_INITSTAGE.
3619 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3620 an error. Set process slots as soon as we allocate them.
3622 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3624 2011-10-27 Chong Yidong <cyd@gnu.org>
3626 * gnutls.c (emacs_gnutls_deinit): New function.
3627 Deallocate credentials structures as well as calling gnutls_deinit.
3628 (Fgnutls_deinit, Fgnutls_boot): Use it.
3630 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3631 (deactivate_process): Call emacs_gnutls_deinit.
3633 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3635 * image.c (x_create_x_image_and_pixmap):
3636 * w32.c (sys_rename, w32_delayed_load):
3637 * w32font.c (fill_in_logfont):
3638 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3640 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3642 * w32fns.c (w32_default_color_map): New function,
3643 extracted from Fw32_default_color_map.
3644 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3646 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3648 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3650 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3652 * keyboard.c (test_undefined): New function (bug#9751).
3653 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3655 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3657 * sysdep.c (init_sys_modes): Fix the check for the controlling
3658 terminal (Bug#6649).
3660 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3662 * dispextern.h (struct bidi_it): New member next_en_type.
3664 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3665 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3666 current character, check also for next_en_type being WEAK_EN.
3667 (bidi_resolve_weak): Don't enter the expensive loop if the current
3668 position is before next_en_pos. Record the bidi type of the first
3669 non-ET, non-BN character we find, in addition to its position.
3670 (bidi_level_of_next_char): Invalidate next_en_type when
3671 next_en_pos is over-stepped.
3673 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3675 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3676 * editfns.c: Rewrite current-time-zone so that it invokes
3677 the equivalent of (format-time-string "%Z") to get the time zone name.
3678 This fixes a bug when the time zone name contains characters that
3679 need converting from the system time locale to Emacs internal format.
3680 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3681 that patch fixed format-time-string to do the conversion, but
3682 I forgot to fix current-time-zone.
3683 (format_time_string): New function, containing most of
3684 what Fformat_time_string used to contain.
3685 (Fformat_time_string): Rewrite in terms of format_time_string.
3686 This doesn't change this function's behavior.
3687 (current-time-zone): Rewrite to use format_time_string.
3688 This fixes the bug reported by Michael Schierl in
3689 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3690 Jason Rumney's 2007-06-07 change worked around this bug, but
3692 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3694 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3696 * xdisp.c (start_display): If the character at POS is displayed
3697 via a display vector, reset IT->current.dpvec_index to zero.
3698 (try_window_reusing_current_matrix): If a line ends in a display
3699 vector or the next line starts in a display vector, continue
3700 redrawing the window even though the character position of
3701 start_row was reached.
3704 2011-10-18 Chong Yidong <cyd@gnu.org>
3706 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3707 with nobreak-char-display too.
3709 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3711 Fix part 3 of bug#9771.
3712 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3713 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3714 non-neutral characters if the current character is a paragraph
3715 separator (a.k.a. Newline). This avoids running the same
3716 expensive loop twice, once when we consume the preceding newline
3717 and the other time when the line actually needs to be displayed.
3718 Avoid the loop when we see neutrals on the base embedding level
3719 following a character whose directionality is the same as the
3720 paragraph's. This avoids running the expensive loop when a line
3721 ends in a long sequence of neutrals, like control characters.
3722 Add assertion against STRONG_AL type. Slightly rearrange code
3723 that determines the type of a neutral given the first non-neutral
3725 (bidi_level_of_next_char): Set next_en_pos to zero when
3726 invalidating its info.
3728 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3730 * xdisp.c (push_display_prop): Determine whether to record string
3731 or buffer position by IT->string, not by IT->method. Allow
3732 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3733 (move_it_vertically_backward): Don't look for character position
3734 immediately after the newline when in a continuation line.
3737 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3739 * window.c (coordinates_in_window): Rewrite and delabelize
3740 vertical border check. (Bug#5357) (Bug#9618)
3742 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3744 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3745 errors in XSetWindowBorder (bug#9310).
3747 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3749 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3750 avoid crash when xmalloc overrun checking is enabled.
3752 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3754 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3755 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3756 cursor motion with <left> and <right> arrow keys.
3758 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3759 some callers set that themselves.
3761 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3763 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3764 display string and the previous row comes from the same string and
3765 is empty. (Bug#9739) (Bug#9738)
3767 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3769 * doc.c (get_doc_string): Encode file name (bug#9735).
3771 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3773 * bidi.c (bidi_level_of_next_char):
3774 * xdisp.c (get_visually_first_element): Remove old incorrect
3775 comments regarding the Unicode Line Separator character.
3777 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3779 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3781 * alloc.c (Fgc_status): Do not access beyond zombies array
3782 boundary if nzombies > MAX_ZOMBIES.
3783 * alloc.c (dump_zombies): Add missing format specifier.
3785 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3787 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3788 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3790 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3791 Some packages use them to denote characters with modifiers.
3793 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3795 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3796 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3797 matching a pp-number. Rename parameter var to var1.
3799 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3801 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3803 2011-10-08 Glenn Morris <rgm@gnu.org>
3805 * callint.c (Fcall_interactively): Give a more explicit error for the
3806 'c' case with a non-character input. (Bug#8479)
3808 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3810 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3812 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3813 lines that are hscrolled on the left.
3815 * dispnew.c (buffer_posn_from_coords): Account for a possible
3816 presence of header-line. (Bug#4426)
3818 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3820 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3821 Don't advertise functionality which we discourage or doesn't work.
3823 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3825 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3826 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3827 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3828 this makes Emacs dump core during garbage collection on rare
3829 occasions. sizeof is obviously inferior to offsetof here, so
3830 stick with offsetof.
3831 (GC_POINTER_ALIGNMENT): New macro.
3832 (mark_memory): Omit 3rd (offset) arg; caller changed.
3833 Don't assume EMACS_INT alignment is the same as pointer alignment.
3835 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3837 * keyboard.c (read_key_sequence_remapped): New var.
3838 (read_key_sequence): Compute remapping in the right buffer.
3839 (command_loop_1): Use read_key_sequence's remapping directly.
3841 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3843 * dired.c (file_name_completion): Don't expand file name.
3844 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3845 before checking file name handler.
3847 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3848 they've been requested explicitly (bug#9591).
3850 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3852 * keymap.c (Fsingle_key_description): Use make_specified_string
3853 instead of build_string to build string from push_key_description.
3856 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3858 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3859 This fixes a Y2038 bug on 64-bit hosts.
3860 * buffer.c (reset_buffer):
3861 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3862 (Fclear_buffer_auto_save_failure):
3863 Use 0, not -1, to represent an unset failure time, since time_t
3864 might not be signed.
3866 Remove dependency on glibc malloc internals.
3867 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3868 Move back here from lisp.h, but with their new implementations.
3869 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3870 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3871 * charset.c (charset_table_init): New static var.
3872 (syms_of_charset): Use it instead of xmalloc. This removes a
3873 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3874 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3875 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3876 Move back to alloc.c.
3877 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3878 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3880 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3882 * nsterm.m (windowDidResize): Call x_set_window_size only when
3883 ns_in_resize is true. Otherwise set pixelwidth/height and
3884 call change_frame_size (Bug#9628).
3886 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3888 Port --enable-checking=all to Fedora 14 x86-64.
3889 * charset.c (syms_of_charset): Also account for glibc malloc's
3890 internal overhead when calculating the initial malloc maximum.
3892 Port --enable-checking=all to Fedora 14 x86.
3893 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3895 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3896 (overrun_check_realloc, overrun_check_free):
3897 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3898 That way, xmalloc returns a properly-aligned pointer even if
3899 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3900 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3901 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3902 into account when calculating the initial malloc maximum.
3903 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3904 Move here from alloc.c, so that charset.c can use it too.
3905 Properly align; the old code wasn't right for common 32-bit hosts
3906 when configured with --enable-checking=all.
3907 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3908 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3910 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3912 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3915 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3917 * xdisp.c (compute_display_string_end): If there's no display
3918 string at CHARPOS, return -1.
3920 * bidi.c (bidi_fetch_char): When compute_display_string_end
3921 returns a negative value, treat the character as a normal
3922 character not covered by a display string. (Bug#9624)
3924 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3926 * lread.c (Fread_from_string): Fix typo in docstring.
3928 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3930 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3931 newline, reseat the iterator instead of bidi-iterating there one
3932 character at a time. (Bug#9610)
3933 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3934 TO_CHARPOS if the bidi iterator is at base embedding level.
3936 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3938 * lread.c (readevalloop): Use correct code for NBSP.
3939 (read1): Likewise. (Bug#9608)
3941 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3943 * dbusbind.c (Fdbus_register_signal): When service is not
3944 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3946 2011-09-25 Glenn Morris <rgm@gnu.org>
3948 * buffer.c (truncate-lines): Doc fix.
3950 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3952 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3953 (Fset_window_next_buffers): Doc fix.
3955 2011-09-24 Glenn Morris <rgm@gnu.org>
3957 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3959 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3961 Fix minor problems found by static checking.
3962 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3963 * indent.c (Fvertical_motion): Fix == vs = typo.
3965 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3967 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3968 Default value is now t. Doc fix.
3970 * indent.c (Fvertical_motion): Compute and apply the overshoot
3971 logic when moving up, not only when moving down. Fix the
3972 confusing name and values of the it_overshoot_expected variable;
3973 logic changes accordingly. (Bug#9254) (Bug#9549)
3975 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3976 CHARPOS is covered by a display string which includes newlines.
3977 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3978 is covered by a display string with embedded newlines.
3980 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3982 * dbusbind.c (Fdbus_register_signal): Add match rule to
3983 Vdbus_registered_objects_table. (Bug#9581)
3984 (Fdbus_register_method, Vdbus_registered_objects_table):
3987 2011-09-24 Jim Meyering <meyering@redhat.com>
3989 do not ignore write error for any output size
3990 The previous change was incomplete.
3991 While it makes emacs --batch detect the vast majority of stdout
3992 write failures, errors were still ignored whenever the output size is
3993 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3994 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3995 && echo FAIL: ignored write error
3996 FAIL: ignored write error
3997 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3998 && echo FAIL: ignored write error
3999 FAIL: ignored write error
4000 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4002 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4004 * emacs.c (Fkill_emacs): In noninteractive mode exit
4005 non-successfully if a write error occurred on stdout. (Bug#9574)
4007 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4009 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4012 * dispextern.h (struct it): Update the comment documenting what
4015 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4017 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4018 a display string, extend search for cursor position to end of row.
4019 (find_row_edges): If the row ends in a newline from a display
4020 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4021 Handle the case of a display string with multiple newlines.
4022 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4023 non-empty line. Fixes confusing cursor motion with arrow keys at
4024 the beginning of a line that starts with whitespace.
4026 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4028 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4031 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4033 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4036 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4038 * xdisp.c (display_line): Record maximum and minimum buffer
4039 positions even if no glyphs were produced (e.g., by a zero-width
4040 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4041 buffer positions that will be removed from the glyph row because
4043 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4044 column is beyond frame width: don't subtract 1 "pixel" when
4045 computing width of the stretch.
4046 (reseat_at_next_visible_line_start): Undo the change made on
4047 2011-09-17 that saved paragraph information and restored it after
4048 the call to `reseat'. (Bug#9545)
4050 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4052 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4053 and turn window cursor on if cleared (Bug#9415).
4055 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4057 * search.c (boyer_moore): Take unibyte characters from pattern
4058 literally. (Bug#9458)
4060 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4062 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4064 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4066 Fix minor problem found by static checking.
4067 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4068 initialized, to pacify gcc -Wuninitialized.
4070 * fileio.c: Report proper errno when syscall falls.
4071 (Finsert_file_contents): Save and restore errno,
4072 so that report_file_error outputs the correct diagnostic.
4073 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4075 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4077 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4079 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4081 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4082 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4084 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4086 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4087 about the current paragraph and restore it after the call to reseat.
4089 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4090 (bidi_find_paragraph_start): Search back for paragraph beginning
4091 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4092 (bidi_move_to_visually_next): Only trigger paragraph-related
4093 computations when the last character is a newline or at EOB, not
4094 just any NEUTRAL_B. (Bug#9470)
4096 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4097 truncated lines if point is covered by a display string. (Bug#9524)
4099 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4101 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4102 (cons_to_x_long): New function.
4103 (lisp_data_to_selection_data): Use it. Correct the test for
4104 short-versus-long data; it was negated. Break out of vector
4105 loop, for efficiency, when a long datum is discovered.
4107 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4109 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4111 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4113 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4114 GCC PR/17406) by declaring this function with external scope.
4116 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4118 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4119 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4121 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4123 * editfns.c (Fformat): Correctly handle text properties on "%%".
4125 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4127 * xterm.c (x_draw_composite_glyph_string_foreground):
4128 * w32term.c (x_draw_composite_glyph_string_foreground):
4129 * term.c (encode_terminal_code):
4130 * composite.c (composition_update_it, get_composition_id):
4131 * xdisp.c (get_next_display_element)
4132 (fill_composite_glyph_string): Add comments about special meaning
4133 of TAB characters in a composition.
4135 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4137 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4138 This occurs when processing a multibyte format.
4139 Problem reported by Wolfgang Jenker.
4141 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4143 * xdisp.c (try_cursor_movement): Only check for exact match if
4144 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4146 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4148 Remove unused external symbols.
4149 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4150 * xdisp.c (calc_pixel_width_or_height): Now static.
4151 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4152 * indent.c (check_display_width):
4153 * w32term.c: Fix comment to match code.
4154 * xterm.c, xterm.h (x_catching_errors): Remove.
4156 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4158 * xselect.c: Use signed conversions more consistently (Bug#9498).
4159 (selection_data_to_lisp_data): Assume incoming selection data are
4160 signed integers, not unsigned. This is to be consistent with
4161 outgoing selection data, which was modified to use signed integers
4162 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4163 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4164 expects long, not unsigned long.
4166 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4168 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4169 computation of loop end. Reported by Johan Bockgård
4172 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4174 * frame.c (Fother_visible_frames_p): Function deleted.
4176 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4178 * indent.c (compute_motion): Process display vector front to back
4179 rather than the other way around. (Bug#2496)
4181 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4183 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4185 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4187 * minibuf.c (Fread_from_minibuffer): Doc fix.
4189 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4191 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4192 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4194 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4196 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4197 value for non-existent files.
4199 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4201 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4202 set its "size" to -1. This will set the modtime_size field of
4203 the corresponding buffer to -1, which is what
4204 verify-visited-file-modtime expects for files that do not exist.
4207 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4209 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4211 * lisp.h: ... from here. push_key_description is no longer
4212 defined in keyboard.c, so its declaration should not be in
4213 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4214 logically belongs with push_key_description.
4216 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4218 * buffer.h: Include <sys/types.h> instead of <time.h>.
4219 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4220 Problem reported by Herbert J. Skuhra.
4222 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4224 * xml.c (parse_region): Make the parsing work for
4225 non-comment-starting XML files again (bug#9144).
4227 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4229 * image.c (gif_load): Fix calculation of bottom and right corner.
4232 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4234 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4235 redisplay in small windows.
4237 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4239 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4241 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4243 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4244 Operate on live windows only.
4246 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4248 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4250 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4252 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4253 only under bidi iteration.
4255 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4257 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4259 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4261 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4262 Without this fix, the command to link temacs failed due to an
4263 undefined symbol __builtin_isnan. This is because
4264 /usr/include/iso/math_c99.h #defines isnan(x) to
4265 __builtin_isnan(x), but the bundled gcc, which identifies itself
4266 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4268 * floatfns.c (isnan): #undef, and then #define to a clone of
4270 (Fisnan): Always define, since it's always available now.
4271 (syms_of_floatfns): Always define isnan at the Lisp level.
4273 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4275 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4277 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4279 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4280 The previous code assumed that file offsets (off_t values) fit in
4281 EMACS_INT variables, which is not true on typical 32-bit hosts.
4282 The code messed up by falsely reporting buffer overflow in cases
4283 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4284 when "big" contains more than 2**29 bytes, even though this
4285 inserts just one byte and does not overflow the buffer.
4286 (Finsert_file_contents): Store file offsets as off_t
4287 values, not as EMACS_INT values. Check for overflow when
4288 converting between EMACS_INT and off_t. When checking for
4289 buffer overflow or for overlap, take the offsets into account.
4290 Don't use EMACS_INT for small values where int suffices.
4291 When checking for overlap, fix a typo: ZV was used where
4292 ZV_BYTE was intended.
4293 (Fwrite_region): Don't assume off_t fits into 'long'.
4294 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4296 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4298 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4300 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4302 sprintf-related integer and memory overflow issues (Bug#9412).
4304 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4305 (esprintf, exprintf, evxprintf): New functions.
4306 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4307 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4308 (modify_event_symbol): Do not assume that the length of
4309 name_alist_or_stem is safe to alloca and fits in int.
4310 (Fexecute_extended_command): Likewise for function name and binding.
4311 (Frecursion_depth): Wrap around reliably on integer overflow.
4312 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4313 since some callers pass EMACS_INT values.
4314 (Fsingle_key_description): Don't crash if symbol name contains more
4315 than MAX_ALLOCA bytes.
4316 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4317 (get_minibuffer): Arg is now EMACS_INT, not int.
4318 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4319 (esprintf, exprintf, evxprintf): New decls.
4320 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4322 * dbusbind.c (signature_cat): New function.
4323 (xd_signature, Fdbus_register_signal):
4324 Do not overrun buffer; instead, report string overflow.
4326 * dispnew.c (add_window_display_history): Don't overrun buffer.
4327 Truncate instead; this is OK since it's just a log.
4329 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4330 even if the time zone offset is outlandishly large.
4331 Don't mishandle offset == INT_MIN.
4333 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4334 when creating daemon; the previous buffer-overflow check was incorrect.
4336 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4337 which has the guts of the old verror function.
4339 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4340 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4342 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4343 (font_unparse_xlfd): Don't blindly alloca long strings.
4344 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4345 fits in int, when using sprintf. Use single snprintf to count
4346 length of string rather than counting it via multiple sprintfs;
4347 that's simpler and more reliable.
4348 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4349 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4350 sprintf, in case result does not fit in int.
4352 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4353 (fontset_from_font): Print it.
4355 * frame.c (tty_frame_count): Now printmax_t, not int.
4356 (make_terminal_frame, set_term_frame_name): Print it.
4357 (x_report_frame_params): In X, window IDs are unsigned long,
4358 not signed long, so print them as unsigned.
4359 (validate_x_resource_name): Check for implausibly long names,
4360 and don't assume name length fits in 'int'.
4361 (x_get_resource_string): Don't blindly alloca invocation name;
4362 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4365 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4366 (xg_check_special_colors, xg_set_geometry):
4367 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4369 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4370 Use esprintf, not sprintf, in case result does not fit in int.
4372 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4373 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4374 it as a large positive number.
4375 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4376 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4378 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4379 in case result does not fit in int.
4381 * print.c (float_to_string): Detect width overflow more reliably.
4382 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4383 buffer overrun. Don't assume list length fits in 'int'. Treat
4384 print length of 0 as 0, not as infinity; to be consistent with other
4385 uses of print length in this function. Don't overflow print length
4386 index. Don't assume hash table size fits in 'long', or that
4387 vectorlike size fits in 'unsigned long'.
4389 * process.c (make_process): Use printmax_t, not int, to format
4390 process-name gensyms.
4392 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4394 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4395 to avoid potential buffer overrun.
4397 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4398 if X resource line is longer than 512 bytes.
4400 * xfns.c (x_window): Make sprintf buffer a bit bigger
4401 to avoid potential buffer overrun.
4403 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4405 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4407 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4409 Integer overflow fixes for scrolling, etc.
4410 Without these, Emacs silently mishandles large integers sometimes.
4411 For example, "C-u 4294967297 M-x recenter" was treated as if
4412 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4414 * xdisp.c (try_window_id): Check Emacs fixnum range before
4415 converting to 'int'.
4417 * window.c (window_scroll_line_based, Frecenter):
4418 Check that an Emacs fixnum is in range before assigning it to 'int'.
4419 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4420 values converted from Emacs fixnums.
4421 (Frecenter): Don't wrap around a line count if it is out of 'int'
4422 range; instead, treat it as an extreme value.
4423 (Fset_window_configuration, compare_window_configurations):
4424 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4426 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4427 that can exceed INT_MAX. Check that EMACS_INT value is in range
4428 before assigning it to the (possibly-narrower) index.
4429 (match_limit): Don't assume that a fixnum can fit in 'int'.
4431 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4434 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4435 (Fvertical_motion): Don't wrap around LINES values that don't fit
4436 in 'int'. Instead, treat them as extreme values. This is good
4437 enough for windows, which can't have more than INT_MAX lines anyway.
4439 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4441 * Require libxml/parser.h to avoid compilation warning.
4443 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4445 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4446 since this reportedly can destroy thread storage.
4448 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4450 * syntax.c (find_defun_start): Update all cache variables if
4451 exiting early (Bug#9401).
4453 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4455 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4457 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4458 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4459 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4461 * term.c (tty_append_glyph): New function.
4462 (produce_stretch_glyph): Static function and its prototype deleted.
4464 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4467 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4469 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4470 when checking :margin (Bug#9390).
4471 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4472 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4473 so that the name doesn't mislead. All uses changed.
4475 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4477 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4480 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4482 * xdisp.c (move_it_to): Don't bail out early when reaching
4483 position beyond to_charpos, if we are scanning backwards.
4484 (move_it_vertically_backward): When DY == 0, make sure we get to
4485 the first character in the line after the newline.
4487 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4489 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4490 (ccl_driver): Do not generate an out-of-range pointer.
4491 (Fccl_execute_on_string): Remove unnecessary check for
4492 integer overflow, noted by Stefan Monnier in
4493 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4494 Remove a FIXME that didn't need fixing.
4495 Simplify the newly-introduced buffer reallocation code.
4497 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4499 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4501 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4503 Integer and memory overflow issues (Bug#9196).
4505 * doc.c (get_doc_string): Rework so that
4506 get_doc_string_buffer_size is the actual buffer size, rather than
4507 being 1 less than the actual buffer size; this makes xpalloc more
4510 * image.c (x_allocate_bitmap_record, cache_image):
4511 * xselect.c (Fx_register_dnd_atom):
4512 Simplify previous changes by using xpalloc.
4514 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4515 since either will do and ptrdiff_t is convenient with xpalloc.
4517 * charset.c (charset_table_size)
4518 (struct charset_sort_data.priority): Now ptrdiff_t.
4519 (charset_compare): Don't overflow if priorities differ greatly.
4520 (Fsort_charsets): Don't assume list length fits in int.
4521 Check for size-calculation overflow when allocating sort data.
4522 (syms_of_charset): Allocate an initial charset table that is
4523 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4525 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4527 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4528 The actual value is always <= INT_MAX, and leaving it unsigned made
4529 overflow checking harder.
4531 * dispextern.h (struct glyph_matrix.rows_allocated)
4532 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4533 with xpalloc. The values are still always <= INT_MAX.
4535 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4537 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4538 (SAFE_NALLOCA): New macro.
4540 * region-cache.c (struct boundary.pos, find_cache_boundary)
4541 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4542 (set_cache_region, invalidate_region_cache)
4543 (revalidate_region_cache, know_region_cache, region_cache_forward)
4544 (region_cache_backward, pp_cache):
4545 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4546 so that ptrdiff_t * can be passed to xpalloc.
4547 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4548 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4549 (pp_cache): Don't assume cache_len fits in int.
4550 * region-cache.h: Adjust extern decls to match.
4552 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4553 EMACS_INT, since either will do, for xpalloc.
4555 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4556 (xnmalloc, xnrealloc, xpalloc): New functions.
4558 * bidi.c (bidi_shelve_header_size): New constant.
4559 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4560 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4562 * bidi.c (bidi_cache_shrink):
4563 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4565 Don't update size of array until after memory allocation succeeds,
4566 because xmalloc/xrealloc may not return.
4567 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4568 now that we have proper integer overflow checking.
4569 (record_overlay_string, overlay_strings): Catch overflows when
4570 calculating size of overlay_str_buf.
4572 * callproc.c (Fcall_process): Check for size overflow when
4573 calculating size of args2.
4574 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4575 Normally we prefer signed values, but sticking with ptrdiff_t would
4576 require adding more-complicated checks.
4578 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4579 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4580 Redo buffer-overflow calculations to avoid integer overflow.
4581 Add a FIXME comment where memory seems to be over-allocated.
4583 * character.c (Fstring): Check for size-calculation overflow.
4585 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4586 unnecessary integer overflow. Check for size overflow.
4587 (encode_coding_object): Don't update size until xmalloc succeeds.
4589 * composite.c (get_composition_id): Check for overflow in glyph
4590 length calculations.
4592 Integer and memory overflow fixes for display code.
4593 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4594 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4595 (scrolling_window): Check for overflow in size calculations.
4596 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4597 Don't assume glyph table len fits in int.
4598 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4599 (row_table_size): Now ptrdiff_t, not int.
4600 (scrolling_window): Avoid overflow in size calculations.
4601 Don't update size until allocation succeeds.
4602 * fns.c (concat): Check for overflow in size calculations.
4603 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4604 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4605 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4607 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4608 (get_doc_string): Check for size calculation overflow.
4609 Don't update size until allocation succeeds.
4610 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4611 EMACS_INT, where ptrdiff_t will do.
4612 (Fsubstitute_command_keys): Check for string overflow.
4614 * editfns.c (set_time_zone_rule): Don't assume environment length
4616 (message_length): Now ptrdiff_t, not int.
4617 (Fmessage_box): Don't update size until allocation succeeds.
4618 Don't assume message length fits in int.
4619 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4621 * emacs.c (main): Do not reallocate argv, since there is a null at
4622 the end that can be overwritten, and this way there's no need to
4623 worry about size-calculation overflow.
4624 (sort_args): Check for size-calculation overflow.
4626 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4628 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4630 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4631 (x_set_scroll_bar_width, x_figure_window_size):
4632 Check for integer overflow.
4633 (x_set_alpha): Do not assume XINT fits in int.
4635 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4636 This is for the members text_lines, text_cols, total_lines, total_cols,
4637 where the system imposes an 'int' limit.
4639 * fringe.c (Fdefine_fringe_bitmap):
4640 Don't update size until alloc works.
4642 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4643 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4645 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4646 Check for size-calculation overflow.
4647 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4648 do, as we prefer signed integers.
4649 (id_to_widget.max_size, id_to_widget.used)
4650 (xg_store_widget_in_map, xg_remove_widget_from_map)
4651 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4652 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4653 Use and return ptrdiff_t, not int.
4654 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4655 * gtkutil.h: Change prototypes to match the above.
4657 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4658 are duplicate now that they've been promoted to lisp.h.
4659 (x_allocate_bitmap_record, x_alloc_image_color)
4660 (make_image_cache, cache_image, xpm_load):
4661 Don't update size until alloc is done.
4662 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4664 Check for size calculation overflow.
4665 (ct_colors_allocated_max): New constant.
4666 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4669 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4670 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4671 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4672 Use ptrdiff_t, not int, to count maps.
4673 (read_char_minibuf_menu_prompt): Check for overflow in size
4674 calculations. Don't update size until allocation succeeds.
4675 Redo calculations to avoid overflow.
4676 * keyboard.h: Change prototypes to match the above.
4678 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4680 (current_minor_maps): Check for size calculation overflow.
4681 * keymap.h: Change prototypes to match the above.
4683 * lread.c (read1, init_obarray): Don't update size until alloc done.
4685 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4686 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4688 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4689 Now ptrdiff_t, not int.
4690 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4691 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4693 * process.c (Fnetwork_interface_list): Check for overflow
4694 in size calculation.
4696 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4698 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4699 overflow. Don't bother calling xmalloc when xrealloc will do.
4701 * search.c (Freplace_match): Check for size calculation overflow.
4702 (Fset_match_data): Don't assume list lengths fit in 'int'.
4704 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4705 for command line length. Do not attempt to address one before the
4706 beginning of an array, as that's not portable.
4708 * term.c (max_frame_lines): Remove; unused.
4709 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4711 (encode_terminal_code, calculate_costs): Check for size
4712 calculation overflow.
4713 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4714 table lengths and related sizes. Don't update size until alloc
4715 done. Redo calculations to avoid overflow.
4716 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4718 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4719 subtracting pointers.
4720 (gobble_line): Check for overflow more carefully. Don't update size
4723 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4724 Don't update size until alloc done.
4725 Redo size calculations to avoid overflow.
4726 Check for size calculation overflow.
4727 (main) [DEBUG]: Fix typo in invoking tparam1.
4729 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4730 Use ptrdiff_t, not int, for sizes.
4731 (store_mode_line_noprop_char): Don't update size until alloc done.
4733 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4734 Use ptrdiff_t, not int, for sizes.
4735 (Finternal_make_lisp_face, cache_face):
4736 Check for size calculation overflow.
4737 (cache_face): Treat size calculation overflows as if they were
4738 memory exhaustion (the usual treatment), rather than aborting.
4740 * xfns.c (x_encode_text, x_set_name_internal)
4741 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4742 sizes, since they can exceed INT_MAX in size. Check for size
4743 calculation overflow.
4745 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4746 (xg_select): Check for size calculation overflow.
4747 Don't update size until alloc done.
4749 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4750 as sprintf is limited to int lengths.
4752 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4753 (X_LONG_MIN): New macros.
4754 Use them to make the following changes clearer.
4755 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4756 This change doesn't affect the value now, but it may help remind
4757 future maintainers not to raise the value too much later.
4758 (SELECTION_QUANTUM): Remove, replacing with ...
4759 (selection_quantum): ... new function, which avoids overflow.
4761 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4762 assumption that selection length fits in 'int'.
4763 (x_reply_selection_request, x_handle_selection_request)
4764 (x_get_window_property, receive_incremental_selection)
4765 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4766 (lisp_data_to_selection_data, clean_local_selection_data):
4767 Use ptrdiff_t, not int, to record length of selection.
4768 (x_reply_selection_request, x_get_window_property)
4769 (receive_incremental_selection, x_property_data_to_lisp):
4770 Redo calculations to avoid overflow.
4771 (x_reply_selection_request): When sending hint, ceiling it at
4772 X_LONG_MAX rather than relying on wraparound overflow to send
4774 (x_get_window_property, receive_incremental_selection)
4775 (lisp_data_to_selection_data, x_property_data_to_lisp):
4776 Check for size-calculation overflow.
4777 (x_get_window_property, receive_incremental_selection)
4778 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4779 Don't store size until memory allocation succeeds.
4780 (x_get_window_property): Plug memory leak on memory exhaustion.
4781 Don't double-block input; malloc is safe here. Don't assume 2**34
4782 - 4 fits in unsigned long. Add an xassert to check
4783 XGetWindowProperty overflow. Be more careful about overflow
4784 calculations, and distinguish size from memory overflow better.
4785 (receive_incremental_selection): When tracing, don't assume
4786 unsigned int is less than INT_MAX.
4787 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4788 harmful) conversions of unsigned short to int.
4789 (lisp_data_to_selection_data): Don't assume that integers
4790 in the range -65535 through -1 fit in an X unsigned short.
4791 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4792 result parameters unless successful. Rely on cons_to_unsigned
4793 to report problems with elements; the old code wasn't right anyway.
4794 (x_check_property_data): Check for int overflow; we cannot use
4795 a wider type due to X limits.
4796 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4798 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4800 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4801 (x_term_init): Check for size calculation overflow.
4802 (x_color_cells): Don't store size until memory allocation succeeds.
4803 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4804 Don't assume alloca size is less than MAX_ALLOCA.
4805 (x_term_init): Don't assume length fits in int (sprintf is limited
4808 Use ptrdiff_t for composition IDs.
4809 * character.c (lisp_string_width):
4810 * composite.c (composition_table_size, n_compositions)
4811 (get_composition_id, composition_gstring_from_id):
4812 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4813 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4814 * window.c (Frecenter):
4815 Use ptrdiff_t, not int, for composition IDs.
4816 * composite.c (get_composition_id): Check for integer overflow.
4817 * composite.h: Adjust prototypes to match the above changes.
4819 Use ptrdiff_t for hash table indexes.
4820 * category.c (hash_get_category_set):
4821 * ccl.c (ccl_driver):
4822 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4823 * coding.c (coding_system_charset_list, detect_coding_system):
4824 * coding.h (struct coding_system.id):
4825 * composite.c (get_composition_id, gstring_lookup_cache):
4826 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4827 * image.c (xpm_get_color_table_h):
4828 * lisp.h (hash_lookup, hash_put):
4829 * minibuf.c (Ftest_completion):
4830 Use ptrdiff_t for hash table indexes, not int (which is too
4831 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4832 32-bit --with-wide-int hosts).
4834 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4835 Add a FIXME comment about memory leaks.
4836 (syms_of_charset): Don't assume xmalloc returns.
4838 Don't assume that stated character widths fit in int.
4839 * character.c (Fchar_width, c_string_width, lisp_string_width):
4840 * character.h (CHAR_WIDTH):
4841 * indent.c (MULTIBYTE_BYTES_WIDTH):
4842 Use sanitize_char_width to avoid undefined and/or bad behavior
4843 with outlandish widths.
4844 * character.h (sanitize_tab_width): Rename from sanitize_width,
4845 now that we have two such functions. All uses changed.
4846 (sanitize_char_width): New inline function.
4848 Don't assume that tab-width fits in int.
4849 * character.h (sanitize_width): New inline function.
4850 (SANE_TAB_WIDTH): New macro.
4851 (ASCII_CHAR_WIDTH): Use it.
4852 * indent.c (sane_tab_width): Remove. All uses replaced by
4853 SANE_TAB_WIDTH (current_buffer).
4854 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4856 * fileio.c: Integer overflow issues with file modes.
4857 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4859 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4860 Remove unreachable code.
4861 (read_hex, load_charset_map_from_file): Check for integer overflow.
4863 * xterm.c: Don't go over XClientMessageEvent limit.
4864 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4865 (x_send_scroll_bar_event): Likewise. Check that the size does not
4866 exceed limits imposed by XClientMessageEvent, as well as the usual
4867 ptrdiff_t and size_t limits.
4869 * keyboard.c: Overflow, signedness and related fixes.
4870 (make_lispy_movement): Use same integer type in forward decl
4871 that is used in the definition.
4872 (read_key_sequence, keyremap_step):
4873 Change bufsize argument back to int, undoing my 2011-03-30 change.
4874 We prefer signed types, and int is wide enough here.
4875 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4876 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4877 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4878 length, not size_t. Use ptrdiff_t for index, not int.
4879 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4880 possibility of integer overflow.
4882 Overflow, signedness and related fixes for images.
4884 * dispextern.h (struct it.stack[0].u.image.image_id)
4885 (struct_it.image_id, struct image.id, struct image_cache.size)
4886 (struct image_cache.used, struct image_cache.ref_count):
4887 * gtkutil.c (update_frame_tool_bar):
4888 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4889 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4890 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4891 * nsmenu.m (update_frame_tool_bar):
4892 * xdisp.c (calc_pixel_width_or_height):
4893 * xfns.c (image_cache_refcount):
4894 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4895 on typical 64-bit hosts.
4897 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4898 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4899 Omit unnecessary casts to int.
4900 (parse_image_spec): Check that integers fall into 'int' range
4901 when the callers expect that.
4902 (image_ascent): Redo ascent calculation to avoid int overflow.
4903 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4904 (lookup_image): Remove unnecessary tests.
4905 (xbm_image_p): Locals are now of int, not EMACS_INT,
4906 since parse_image_check makes sure they fit into int.
4907 (png_load, gif_load, svg_load_image):
4908 Prefer int to unsigned where either will do.
4909 (tiff_handler): New function, combining the cores of the
4910 old tiff_error_handler and tiff_warning_handler.
4911 This function is rewritten to use vsnprintf and thereby avoid
4912 stack buffer overflows. It uses only the features of vsnprintf
4913 that are common to both POSIX and native Microsoft.
4914 (tiff_error_handler, tiff_warning_handler): Use it.
4915 (tiff_load, gif_load, imagemagick_load_image):
4916 Don't assume :index value fits in 'int'.
4917 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4918 (imagemagick_load_image): Check that crop parameters fit into
4919 the integer types that MagickCropImage accepts. Don't assume
4920 Vimagemagick_render_type has a nonnegative value. Don't assume
4921 size_t fits in 'long'.
4922 (gs_load): Use printmax_t to print the widest integers possible.
4923 Check for integer overflow when computing image height and width.
4925 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4927 * xdisp.c (redisplay_window): Don't force window start if point
4928 will be invisible in the resulting window. (Bug#9324)
4930 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4932 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4933 the display spec is of the form `(space ...)'.
4934 (handle_display_spec): Return the value returned by
4935 handle_single_display_spec, not just 1 or zero.
4936 (handle_single_display_spec): If the display spec is of the form
4937 `(space ...)', and specifies display in the text area, return 2
4939 (try_cursor_movement): Check for the need to scroll more
4940 accurately, and prefer exact match for point under bidi.
4941 Don't advance `row' beyond the last row of the window.
4943 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4944 into disp_prop; all users changed.
4946 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4947 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4948 for the text covered by the display property.
4950 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4952 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4953 Change return value to nil.
4954 (Frecord_buffer): Delete unused function.
4956 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4958 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4959 buffers, return left-to-right.
4960 (set_cursor_from_row): Consider candidate row a win if its glyph
4961 represents a newline and point is on that newline. Fixes cursor
4962 positioning on the newline at EOL of R2L text within L2R
4963 paragraph, and vice versa.
4964 (try_cursor_movement): Check continued rows, in addition to
4965 continuation rows. Fixes unwarranted scroll when point enters a
4966 continued line of R2L text within an L2R paragraph, or vice versa.
4967 (cursor_row_p): Consider the case of point being equal to
4968 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4969 from the end of a short line to the beginning of a continued line
4970 of R2L text within L2R paragraph.
4971 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4972 composed characters.
4974 * bidi.c (bidi_check_type): Use xassert.
4975 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4978 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4980 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4983 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4985 * nsfont.m (ns_otf_to_script): Fix typo.
4987 2011-08-22 Kenichi Handa <handa@m17n.org>
4989 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4990 extra slot even if the purpose is char-code-property-table.
4992 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4994 * xdisp.c (redisplay_window): When computing centering_position,
4995 account for the height of the header line. (Bug#8874)
4997 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4998 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4999 candidate is selected by the mouse, and that candidate has a
5000 composed character under the mouse.
5002 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5003 coordinates reported by pos-visible-in-window-p for a composed
5004 character in column zero.
5006 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5008 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5010 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5012 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5013 consider it a hit if to_charpos is anywhere in the range of the
5014 composed buffer positions.
5016 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5018 * image.c (gif_load): Don't assume that each subimage has the same
5019 dimensions as the base image. Handle disposal method that is
5020 "undefined" by the gif spec (Bug#9335).
5022 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5024 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5025 (Fcondition_case): Document `debug' symbol in error handler.
5027 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5029 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5030 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5031 from an Org mode buffer to a Speedbar frame.
5033 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5034 a composition, take its buffer position from IT->cmp_it.charpos.
5035 Fixes cursor positioning at the beginning of a line that begins
5036 with a composed character.
5038 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5040 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5041 character bidirectional type, use STRONG_L instead. Fixes crashes
5042 in a buffer produced by `describe-categories'.
5044 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5045 members before the level stack, so they would be saved and
5046 restored when copying iterator state. Fixes incorrect reordering
5047 around TABs covered by display properties.
5049 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5051 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5053 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5055 * eval.c (internal_condition_case, internal_condition_case_1)
5056 (internal_condition_case_2, internal_condition_case_n):
5057 Remove unnecessary aborts (Bug#9081).
5059 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5061 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5062 has no `load' handler, try opening the file locally. (Bug#9311)
5064 2011-08-16 Ken Brown <kbrown@cornell.edu>
5066 * gmalloc.c: Expand comment.
5068 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5070 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5071 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5073 2011-08-16 Ken Brown <kbrown@cornell.edu>
5075 Fix memory allocation problems in Cygwin build (Bug#9273).
5077 * unexcw.c ( __malloc_initialized): Declare external variable.
5078 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5080 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5082 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5084 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5086 [CYGWIN] (special_realloc): New function.
5087 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5088 requests to realloc storage in the static heap.
5090 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5092 * bidi.c (bidi_initialize): Remove unused local.
5094 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5097 * biditype.h: Remove file.
5098 * makefile.w32-in ($(BLD)/bidi.$(O)):
5099 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5101 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5103 * chartab.c: Improve commentary for the uniprop_table API.
5105 * bidi.c (bidi_paragraph_init): Support zero value of
5106 bidi_ignore_explicit_marks_for_paragraph_level.
5107 (bidi_initialize): Use uniprop_table instead of including
5108 biditype.h and bidimirror.h.
5110 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5111 coordinates of the iterator when restoring from ppos_it.
5114 2011-08-14 Kenichi Handa <handa@m17n.org>
5116 * process.c (create_process): Call setup_process_coding_systems
5117 after the pid of the process is set to -1 (Bug#8162).
5119 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5121 * xdisp.c (move_it_in_display_line_to): Don't invoke
5122 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5123 ppos_it. Fixes vertical cursor motion when line beginning is
5124 covered by an image. (Bug#9296)
5126 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5128 * nsterm.h (ns_run_ascript): Declare.
5129 (NSAPP_DATA2_RUNASSCRIPT): Define.
5131 * nsfns.m (as_script, as_result, as_status): New static variables.
5132 (ns_run_ascript): New function.
5133 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5134 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5135 the event loop. Get status from as_status (Bug#7276).
5137 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5138 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5139 the event loop (Bug#7276).
5141 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5143 * gnutls.c (QCgnutls_bootprop_priority)
5144 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5145 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5146 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5147 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5148 (QCgnutls_bootprop_verify_hostname_error)
5149 (QCgnutls_bootprop_callbacks_verify): Rename from
5150 Qgnutls_bootprop_..., all uses changed.
5152 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5155 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5157 * xfaces.c (Qframe_set_background_mode): Now static.
5158 * dispextern.h (Qframe_set_background_mode): Remove decl.
5160 * process.c (Fnetwork_interface_info): Declare local only if needed.
5162 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5164 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5165 (Fnetwork_interface_list): Allocate in increments of bytes instead
5166 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5167 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5169 (struct ifflag_def): notrailers is smart on OSX.
5170 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5171 Get hardware address with getifaddrs if available.
5173 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5175 * xdisp.c (iterate_out_of_display_property): xassert that
5176 IT->position is set to within IT->object's boundaries. Break from
5177 the loop as soon as EOB is reached; avoids infloops in redisplay
5178 when IT->position is set up wrongly due to some bug.
5179 Set IT->current to match the bidi iterator unconditionally.
5180 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5181 entry. Force push_it to save on the stack the current
5182 buffer/string position, to be restored by pop_it. Fix flags in
5183 the iterator structure wrt the object coming from a display
5184 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5185 properties. (Bug#9284)
5187 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5189 * fontset.c (fontset_get_font_group): Add proper type checks.
5192 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5194 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5195 and LC_VERSION_MIN_MACOSX.
5196 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5197 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5199 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5201 * xdisp.c (forward_to_next_line_start): Allow to use the
5202 no-display-properties-and-no-overlays under bidi display.
5203 Set disp_pos in the bidi iterator to avoid searches for display
5204 properties and overlays.
5206 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5208 * editfns.c (Fset_time_zone_rule): Document relationship with the
5211 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5212 the font entity extracted from the cache (Bug#8109).
5214 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5216 * composite.c (autocmp_chars): Don't reset point. That is done by
5217 restore_point_unwind (Bug#5984).
5219 2011-08-07 Juri Linkov <juri@jurta.org>
5221 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5222 to show the arg `TIME' instead of `TIMEVAL'.
5224 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5226 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5227 display property strides EOL and includes a newline, as in
5228 longlines-mode. (Bug#9254)
5229 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5230 word-wrap under bidirectional display. (Bug#9224)
5232 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5233 is non-zero, even if the data buffer is NULL. Fixes a crash in
5234 vertical-motion with longlines-mode. (Bug#9254)
5236 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5238 * bidi.c <bidi_cache_total_alloc>: Now static.
5239 (bidi_initialize): Initialize bidi_cache_total_alloc.
5241 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5244 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5245 amount allocated this far in `bidi_cache_total_alloc'.
5246 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5247 non-zero, only free the data buffer without restoring the cache
5248 contents. All callers changed.
5250 * dispextern.h (bidi_unshelve_cache): Update prototype.
5252 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5253 (move_it_in_display_line, move_it_to)
5254 (move_it_vertically_backward, move_it_by_lines): Replace the call
5255 to xfree to an equivalent call to bidi_unshelve_cache.
5256 (move_it_in_display_line_to): Fix logic of returning
5257 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5259 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5261 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5262 came from a string character with a `cursor' property. (Bug#9229)
5264 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5266 * Makefile.in (LIB_PTHREAD): New variable.
5267 (LIBES): Add LIB_PTHREAD (Bug#9216).
5269 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5270 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5272 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5274 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5276 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5278 * xterm.c (x_find_topmost_parent): New function.
5279 (x_set_frame_alpha): Find topmost parent window with
5280 x_find_topmost_parent and set the property there also (bug#9181).
5281 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5283 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5285 * callproc.c (Fcall_process): Avoid vfork clobbering
5286 the local vars buffer, coding_systems, current_dir.
5288 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5290 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5292 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5294 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5295 so that it is not optimized away.
5297 * xdisp.c (compute_display_string_pos): Remove unused local.
5299 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5301 Fix slow cursor motion and scrolling in large buffers with
5302 selective display, like Org Mode buffers. (Bug#9218)
5304 * dispextern.h (struct bidi_it): New member disp_prop_p.
5306 * xdisp.c: Remove one-slot cache of display string positions.
5307 (compute_display_string_pos): Accept an additional argument
5308 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5309 for a display string or property. If found, set DISP_PROP_P
5312 * bidi.c (bidi_fetch_char): Accept an additional argument
5313 DISP_PROP_P, and pass it to compute_display_string_pos.
5314 Only handle text covered by a display string if DISP_PROP_P is returned
5315 non-zero. All callers of bidi_fetch_char changed.
5317 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5319 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5321 2010-12-03 Don March <don@ohspite.net>
5323 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5324 last character M-[char] is translated to ESC [char] (bug#7541).
5326 2011-08-02 Kenichi Handa <handa@m17n.org>
5328 * lisp.h (uniprop_table): Extern it.
5330 * chartab.c (uniprop_table): Make it non-static.
5332 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5334 * xdisp.c (forward_to_next_line_start): Accept additional argument
5335 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5337 (reseat_at_next_visible_line_start): Use the bidi iterator state
5338 returned by forward_to_next_line_start to restore the state of
5339 it->bidi_it after backing up to previous newline. (Bug#9212)
5341 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5343 * regex.c (re_comp): Protoize.
5344 (re_exec): Fix return type.
5345 (regexec): Fix type of `ret'. (Bug#9203)
5347 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5349 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5350 This is needed if max-image-size is a floating-point number.
5352 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5354 * print.c (print_object): Print empty symbol as ##.
5356 * lread.c (read1): Read ## as empty symbol.
5358 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5360 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5361 setting frame foreground color (Bug#9175).
5362 (x_set_background_color): Likewise.
5364 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5365 contents (Bug#9176).
5366 (EmacsTooltip -init): Remove bezels and add shadows to
5369 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5370 or scroll bar (Bug#8470).
5372 * nsfont.m (nsfont_open): Remove assignment to voffset and
5373 unnecessary vars hshink, expand, hd, full_height, min_height.
5374 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5376 * nsterm.h (nsfont_info): Remove voffset field.
5378 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5380 Implement strike-through and overline on NextStep (Bug#8863).
5382 * nsfont.m (nsfont_open): Use underline position provided by font,
5383 instead of hard-coded value of 2.
5384 (nsfont_draw): Call ns_draw_text_decoration instead.
5386 * nsterm.h: Add declaration for ns_draw_text_decoration.
5388 * nsterm.m (ns_draw_text_decoration): New function for drawing
5389 underline, overline, and strike-through.
5390 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5391 ns_draw_text_decoration. Change treatment of cursor drawing to
5392 accommodate underlining, etc.
5394 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5396 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5399 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5401 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5402 Without this fix, if a signal arrives just after memory fills up,
5403 'malloc' might be invoked reentrantly.
5405 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5406 In other words, assume that every image size is allowed, on non-X
5407 hosts. This assumption is probably wrong, but it lets Emacs compile.
5409 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5411 * regex.c (re_iswctype): Convert return values to boolean.
5413 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5415 * xdisp.c (compute_display_string_pos): Don't use cached display
5416 string position if the buffer had its restriction changed.
5419 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5421 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5423 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5425 Integer signedness and overflow and related fixes. (Bug#9079)
5427 * bidi.c: Integer size and overflow fixes.
5428 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5429 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5430 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5431 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5432 (bidi_find_other_level_edge):
5433 Use ptrdiff_t instead of EMACS_INT where either will do.
5434 This works better on 32-bit hosts configured --with-wide-int.
5435 (bidi_cache_ensure_space): Check for size-calculation overflow.
5436 Use % rather than repeated addition, for better worst-case speed.
5437 Don't set bidi_cache_size until after xrealloc returns, because it
5439 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5440 (bidi_cache_ensure_space): Also check that the bidi cache size
5441 does not exceed that of the largest Lisp string or buffer. See Eli
5442 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5444 * alloc.c (__malloc_size_t): Remove.
5445 All uses replaced by size_t. See Andreas Schwab's note
5446 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5448 * image.c: Improve checking for integer overflow.
5449 (check_image_size): Assume that f is nonnull, since
5450 it is always nonnull in practice. This is one less thing to
5451 worry about when checking for integer overflow later.
5452 (x_check_image_size): New function, which checks for integer
5453 overflow issues inside X.
5454 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5455 This removes the need for a memory_full check.
5456 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5457 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5458 (xbm_read_bitmap_data): Change locals back to 'int', since
5459 their values must fit in 'int'.
5460 (xpm_load_image, png_load, tiff_load):
5461 Invoke x_create_x_image_and_pixmap earlier,
5462 to avoid much needless work if the image is too large.
5463 (tiff_load): Treat overly large images as if
5464 x_create_x_image_and_pixmap failed, not as malloc failures.
5465 (gs_load): Use x_check_image_size.
5467 * gtkutil.c: Omit integer casts.
5468 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5469 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5471 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5473 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5474 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5475 would wrongly return t on a 64-bit host.
5477 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5478 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5479 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5480 and therefore cause GCC to emit a bogus diagnostic in some cases.
5482 * image.c: Integer signedness and overflow and related fixes.
5483 This is not an exhaustive set of fixes, but it's time to
5484 record what I've got.
5485 (lookup_pixel_color, check_image_size): Remove redundant decls.
5486 (check_image_size): Don't assume that arbitrary EMACS_INT values
5487 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5488 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5489 (tiff_load, imagemagick_load_image):
5490 Check for overflow in size calculations.
5491 (x_create_x_image_and_pixmap): Remove unnecessary test for
5492 xmalloc returning NULL; that can't happen.
5493 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5494 (xpm_color_bucket): Use better integer hashing function.
5495 (xpm_cache_color): Don't possibly over-allocate memory.
5496 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5497 (gif_memory_source):
5498 Use ptrdiff_t, not int or size_t, to record sizes.
5499 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5500 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5501 either works, as we prefer signed integers.
5502 (tiff_read_from_memory, tiff_write_from_memory):
5503 Return tsize_t, not size_t, since that's what the TIFF API wants.
5504 (tiff_read_from_memory): Don't fail simply because the read would
5505 go past EOF; instead, return a short read.
5506 (tiff_load): Omit no-longer-needed casts.
5507 (Fimagemagick_types): Don't assume size fits into 'int'.
5509 Improve hashing quality when configured --with-wide-int.
5510 * fns.c (hash_string): New function, taken from sxhash_string.
5511 Do not discard information about ASCII character case; this
5512 discarding is no longer needed.
5513 (sxhash-string): Use it. Change sig to match it. Caller changed.
5514 * lisp.h: Declare it.
5515 * lread.c (hash_string): Remove, since we now use fns.c's version.
5516 The fns.c version returns a wider integer if --with-wide-int is
5517 specified, so this should help the quality of the hashing a bit.
5519 * emacs.c: Integer overflow minor fix.
5520 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5521 Define only if GNU_LINUX.
5522 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5524 * dispnew.c: Integer signedness and overflow fixes.
5525 Remove unnecessary forward decls, that were a maintenance hassle.
5526 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5528 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5529 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5530 (prepare_desired_row, line_draw_cost):
5531 Use int, not unsigned, where either works.
5532 (save_current_matrix, restore_current_matrix):
5533 Use ptrdiff_t, not size_t, where either works.
5534 (init_display): Check for overflow more accurately, and without
5535 relying on undefined behavior.
5537 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5538 Remove, replacing with the new symbols in lisp.h. All uses changed.
5539 * fileio.c (make_temp_name):
5540 * filelock.c (lock_file_1, lock_file):
5541 * xdisp.c (message_dolog):
5542 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5543 Use pMd etc. instead.
5544 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5545 replacing the pWIDE etc. symbols removed from editfns.c.
5547 * keyboard.h (num_input_events): Now uintmax_t.
5548 This is (very slightly) less likely to mess up due to wraparound.
5551 * buffer.c: Integer signedness fixes.
5552 (alloc_buffer_text, enlarge_buffer_text):
5553 Use ptrdiff_t rather than size_t when either will do, as we prefer
5556 * alloc.c: Integer signedness and overflow fixes.
5557 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5558 (__malloc_size_t): Default to size_t, not to int.
5559 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5560 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5561 Prefer ptrdiff_t to size_t when either would do, as we prefer
5563 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5564 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5565 Now const. Initialize with values that are in range even if char
5567 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5568 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5569 These functions do the right thing with sizes > 2**32.
5570 (check_depth): Now ptrdiff_t, not int.
5571 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5572 Adjust to new way of storing sizes. Check for size overflow bugs
5574 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5575 slightly wrong anyway, as it missed one instance of
5576 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5577 (refill_memory_reserve): Omit needless cast to size_t.
5578 (mark_object_loop_halt): Mark as externally visible.
5580 * xselect.c: Integer signedness and overflow fixes.
5581 (Fx_register_dnd_atom, x_handle_dnd_message):
5582 Use ptrdiff_t, not size_t, since we prefer signed.
5583 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5584 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5585 x_dnd_atoms_size and x_dnd_atoms_length.
5587 * doprnt.c: Prefer signed to unsigned when either works.
5589 * doprnt.c (doprnt):
5591 * xdisp.c (vmessage):
5592 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5593 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5594 prefer signed arithmetic to avoid comparison confusion.
5595 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5596 but is a bit tricky.
5598 Assume freestanding C89 headers, string.h, stdlib.h.
5599 * data.c, doprnt.c, floatfns.c, print.c:
5600 Include float.h unconditionally.
5601 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5602 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5603 * regex.c: Likewise for stddef.h, string.h.
5604 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5605 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5606 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5607 (STDC_HEADERS): Remove obsolete defines.
5608 * sysdep.c: Include limits.h unconditionally.
5610 Assume support for memcmp, memcpy, memmove, memset.
5611 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5612 * regex.c (memcmp, memcpy):
5613 Remove; we assume C89 now.
5615 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5616 (__malloc_safe_bcopy): Remove; no longer needed.
5618 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5619 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5620 well either way, and we prefer signed to unsigned.
5622 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5624 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5625 closes the connection while we're reading (bug#9182).
5627 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5629 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5630 are specified (Bug#9168).
5632 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5634 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5635 Found by GCC static checking and --with-wide-int on a 32-bit host.
5637 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5639 * xdisp.c (compute_display_string_pos): Fix logic of caching
5640 previous display string position. Initialize cached_prev_pos to
5641 -1. Fixes slow-down at the beginning of a buffer.
5643 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5645 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5646 for attrs[LFACE_FONTSET_INDEX].
5648 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5650 * xml.c (parse_region): Remove unused local
5651 that was recently introduced.
5653 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5655 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5656 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5658 * xdisp.c (move_it_in_display_line_to): Record the best matching
5659 position for TO_CHARPOS while scanning the line, and restore it on
5660 exit if none of the characters scanned was an exact match.
5661 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5662 when exact match is impossible due to invisible text, and the
5663 lines are truncated.
5665 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5667 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5670 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5672 Fix a significant slow-down of cursor motion with C-n, C-p,
5673 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5674 auto-repeat under bidi redisplay in fontified buffers.
5675 * xdisp.c (compute_stop_pos_backwards): New function.
5676 (next_element_from_buffer): Call compute_stop_pos_backwards to
5677 find a suitable prev_stop when we find ourselves before
5679 (reseat): Don't look for prev_stop, as that could mean a very long
5681 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5682 <cached_disp_overlay_modiff>: Cache for last found display string
5684 (compute_display_string_pos): Return the cached position if asked
5685 about the same buffer in the same area of character positions, and
5686 the buffer wasn't changed since the time the display string
5687 position was cached.
5689 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5691 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5692 is an integer, which is important for empty lines. (Bug#9149)
5694 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5696 * frame.c (Fmodify_frame_parameters): In tty case, update the
5697 default face if necessary (Bug#4238).
5699 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5701 * editfns.c (Fstring_to_char): No need to explain what a character
5702 is in the docstring (Bug#6576).
5704 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5706 * xml.c (parse_region): Make sure we always return a tree.
5708 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5710 * xml.c (parse_region): If a document contains only comments,
5713 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5715 * xml.c (make_dom): Return comments, too.
5717 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5720 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5721 and the surrounding thread.
5722 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5723 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5724 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5726 * s/openbsd.h (BROKEN_SIGIO): Define.
5727 * unexelf.c (unexec) [__OpenBSD__]:
5728 Don't update the .mdebug section of the Alpha COFF symbol table.
5730 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5732 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5735 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5737 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5738 This fixes some race conditions on the permissions of any newly
5741 * alloc.c (valid_pointer_p): Use pipe, not open.
5742 This fixes some permissions issues when debugging.
5744 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5745 If fchown fails to set both uid and gid, try to set just gid,
5746 as that is sometimes allowed. Adjust the file's mode to eliminate
5747 setuid or setgid bits that are inappropriate if fchown fails.
5749 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5751 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5752 to compare Lisp_Objects.
5753 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5754 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5755 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5757 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5759 * lread.c (read_integer): Unread even EOF character.
5760 (read1): Likewise. Properly record start position of symbol.
5762 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5763 symbol character follows.
5765 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5767 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5768 This works around a problem with the previous change to Fcopy_file.
5769 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5770 and without this change, GCC might complain about discarding
5771 fchown's return value.
5773 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5775 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5777 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5779 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5781 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5783 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5784 it's used from the C level.
5786 * process.c: Use the same condition for POLL_FOR_INPUT in both
5787 keyboard.c and process.c (bug#1858).
5789 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5791 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5792 (Fgnutls_boot): Use it.
5794 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5796 * doc.c (Fsubstitute_command_keys): Revert last change.
5798 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5800 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5801 quotes the next character, and doesn't affect other longer
5802 sequences (bug#8935).
5804 * lread.c (syms_of_lread): Clarify that is isn't only
5805 `eval-buffer' and `eval-defun' that's affected by
5806 `lexical-binding' (bug#8460).
5808 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5810 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5811 bidi redisplay when a line includes both an image and is truncated.
5813 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5815 Fix minor problems found by static checking.
5816 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5817 (elsz): Now a signed constant, not a size_t var. We prefer signed
5818 types to unsigned, to avoid integer comparison confusion. Without
5819 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5820 "cannot optimize loop, the loop counter may overflow", a symptom
5822 * indent.c (Fvertical_motion): Mark locals as initialized.
5823 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5825 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5827 * search.c (Fre_search_backward): Mention `case-fold-search' in
5828 all the re_search_* functions (bug#8138).
5830 * keyboard.c (Fopen_dribble_file): Document when the file is
5833 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5835 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5838 Support bidi reordering of display and overlay strings.
5839 * xdisp.c (compute_display_string_pos)
5840 (compute_display_string_end): Accept additional argument STRING.
5841 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5842 (reseat_to_string): Initialize bidi_it->string.s and
5843 bidi_it->string.schars.
5844 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5845 NULL (avoids a crash in bidi_paragraph_init).
5846 Initialize itb.string.lstring.
5847 (init_iterator): Call bidi_init_it only of a valid
5848 buffer position was specified. Initialize paragraph_embedding to
5850 (reseat_to_string): Initialize the bidi iterator.
5851 (display_string): If we need to ignore text properties of
5852 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5853 original value of -1 will not work with bidi.)
5854 (compute_display_string_pos): First arg is now struct
5855 `text_pos *'; all callers changed. Support display properties on
5857 (compute_display_string_end): Support display properties on Lisp
5859 (init_iterator, reseat_1, reseat_to_string): Initialize the
5860 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5861 when iterating on a string not from display properties).
5862 (compute_display_string_pos, compute_display_string_end):
5863 Fix calculation of the object to scan. Fixes an error when using
5865 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5866 base_level_stop; instead, set base_level_stop to BEGV.
5867 Fixes crashes in vertical-motion.
5868 (next_element_from_buffer): Improve commentary for when
5869 the iterator is before prev_stop.
5870 (init_iterator): Initialize bidi_p from the default value of
5871 bidi-display-reordering, not from buffer-local value. Use the
5872 buffer-local value only if initializing for buffer iteration.
5873 (handle_invisible_prop): Support invisible properties on strings
5874 that are being bidi-reordered.
5875 (set_iterator_to_next): Support bidi reordering of C strings and
5877 (next_element_from_string): Support bidi reordering of Lisp
5879 (handle_stop_backwards): Support Lisp strings as well.
5880 (display_string): Support display of R2L glyph rows.
5881 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5882 (init_iterator): Don't initialize it->bidi_p for strings
5884 (reseat_to_string): Initialize it->bidi_p for strings here.
5885 (next_element_from_string, next_element_from_c_string)
5886 (next_element_from_buffer): Add xassert's for correspondence
5887 between IT's object being iterated and it->bidi_it.string
5889 (face_before_or_after_it_pos): Support bidi iteration.
5890 (next_element_from_c_string): Handle the case of the first string
5891 character that is not the first one in the visual order.
5892 (get_visually_first_element): New function, refactored from common
5893 parts of next_element_from_buffer, next_element_from_string, and
5894 next_element_from_c_string.
5895 (tool_bar_lines_needed, redisplay_tool_bar)
5896 (display_menu_bar): Force left-to-right direction. Add a FIXME
5897 comment for making that be controlled by a user option.
5898 (push_it, pop_it): Save and restore the state of the
5899 bidi iterator. Save and restore the bidi_p flag.
5900 (pop_it): Iterate out of display property for string iteration as
5902 (iterate_out_of_display_property): Support iteration over strings.
5903 (handle_single_display_spec): Set up it->bidi_it for iteration
5904 over a display string, and call bidi_init_it.
5905 (handle_single_display_spec, next_overlay_string)
5906 (get_overlay_strings_1, push_display_prop): Set up the bidi
5907 iterator for displaying display or overlay strings.
5908 (forward_to_next_line_start): Don't use the shortcut if
5910 (back_to_previous_visible_line_start): If handle_display_prop
5911 pushed the iterator stack, restore the internal state of the bidi
5912 iterator by calling bidi_pop_it same number of times.
5913 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5914 and we are bidi-iterating, don't decrement the iterator position;
5915 instead, set the first_elt flag in the bidi iterator, to produce
5917 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5918 (push_display_prop): xassert that we are iterating a buffer.
5919 (push_it, pop_it): Save and restore paragraph_embedding member.
5920 (handle_single_display_spec, next_overlay_string)
5921 (get_overlay_strings_1, reseat_1, reseat_to_string)
5922 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5923 correctly. Don't assume unibyte strings are not bidi-reordered.
5924 (compute_display_string_pos)
5925 (compute_display_string_end): Fix handling the case of C string.
5926 (push_it, pop_it): Save and restore from_disp_prop_p.
5927 (handle_single_display_spec, push_display_prop): Set the
5928 from_disp_prop_p flag.
5929 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5930 (pop_it): Call iterate_out_of_display_property only if we are
5931 popping after iteration over a string that came from a display
5932 property. Fix a typo in popping stretch info. Add an assertion
5933 for verifying that the iterator position is in sync with the bidi
5935 (handle_single_display_spec, get_overlay_strings_1)
5936 (push_display_prop): Fix initialization of paragraph direction for
5937 string when that of the parent object is not yet determined.
5938 (reseat_1): Call bidi_init_it to resync the bidi
5939 iterator with IT's position. (Bug#7616)
5940 (find_row_edges): If ROW->start.pos gives position
5941 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5942 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5943 Reset the from_disp_prop_p flag.
5944 (SAVE_IT, RESTORE_IT): New macros.
5945 (pos_visible_p, face_before_or_after_it_pos)
5946 (back_to_previous_visible_line_start)
5947 (move_it_in_display_line_to, move_it_in_display_line)
5948 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5949 (try_scrolling, redisplay_window, display_line): Use them when
5950 saving a temporary copy of the iterator and restoring it back.
5951 (back_to_previous_visible_line_start, reseat_1)
5952 (init_iterator): Empty the bidi cache "stack".
5953 (move_it_in_display_line_to): If iterator ended up at
5954 EOL, but we never saw any buffer positions smaller than
5955 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5956 motion in bidi-reordered lines.
5957 (move_it_in_display_line_to): Record prev_method and prev_pos
5958 immediately before the call to set_iterator_to_next. Fixes cursor
5959 motion in bidi-reordered lines with stretch glyphs and strings
5960 displayed in margins. (Bug#8133) (Bug#8867)
5961 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5963 (pos_visible_p): Support positions in bidi-reordered lines.
5964 Save and restore bidi cache.
5966 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5967 (bidi_paragraph_info): Delete unused struct.
5968 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5969 (bidi_cache_start): New variable.
5970 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5972 (bidi_cache_fetch_state, bidi_cache_search)
5973 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5974 (bidi_cache_find, bidi_peek_at_next_level)
5975 (bidi_level_of_next_char, bidi_find_other_level_edge)
5976 (bidi_move_to_visually_next): Compare cache index with
5977 bidi_cache_start rather than with zero.
5978 (bidi_fetch_char): Accept new argument STRING; all callers
5979 changed. Support iteration over a string. Support strings with
5980 display properties. Support unibyte strings. Fix the type of
5981 `len' according to what STRING_CHAR_AND_LENGTH expects.
5982 (bidi_paragraph_init, bidi_resolve_explicit_1)
5983 (bidi_resolve_explicit, bidi_resolve_weak)
5984 (bidi_level_of_next_char, bidi_move_to_visually_next):
5985 Support iteration over a string.
5986 (bidi_set_sor_type, bidi_resolve_explicit_1)
5987 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5988 can now be zero (for strings); special values 0 and -1 were
5989 changed to -1 and -2, respectively.
5990 (bidi_char_at_pos): New function.
5991 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5992 Call it instead of FETCH_MULTIBYTE_CHAR.
5993 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5994 initialized to valid values.
5995 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5997 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5998 the test for valid cached positions. Fix the logic for looking up
5999 the sentinel state in the cache. GCPRO the Lisp string we are
6001 (bidi_push_it, bidi_pop_it): New functions.
6002 (bidi_initialize): Initialize the bidi cache start stack pointer.
6003 (bidi_cache_ensure_space): New function, refactored from part of
6004 bidi_cache_iterator_state. Don't assume the required size is just
6005 one BIDI_CACHE_CHUNK away.
6006 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6007 (bidi_count_bytes, bidi_char_at_pos): New functions.
6008 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6009 always valid if bidi_cache_idx is valid.
6010 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6011 is valid if it's going to be used.
6012 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6013 (bidi_cache_fetch_state, bidi_cache_search)
6014 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6015 (bidi_cache_iterator_state, bidi_cache_find)
6016 (bidi_find_other_level_edge, bidi_cache_start_stack):
6017 All variables related to cache indices are now EMACS_INT.
6019 * dispextern.h (struct bidi_string_data): New structure.
6020 (struct bidi_it): New member `string'. Make flag members be 1-bit
6021 fields, and put them last in the struct.
6022 (compute_display_string_pos, compute_display_string_end):
6024 (bidi_push_it, bidi_pop_it): Add prototypes.
6025 (struct iterator_stack_entry): New members bidi_p,
6026 paragraph_embedding, and from_disp_prop_p.
6027 (struct it): Member bidi_p is now a bit field 1 bit wide.
6028 (bidi_shelve_cache, bidi_unshelve_cache):
6031 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6032 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6033 and vector-like objects.
6035 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6036 cache around display iteration.
6038 * window.c (Fwindow_end, window_scroll_pixel_based)
6039 (displayed_window_lines, Frecenter): Save and restore the bidi
6040 cache around display iteration.
6042 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6044 * editfns.c (Fdelete_region): Clarify the use of the named
6045 parameters (bug#6788).
6047 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6049 * indent.c (Fvertical_motion): Set and restore w->pointm when
6050 saving and restoring the window's buffer (Bug#9006).
6052 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6054 * editfns.c (Fstring_to_char): Clarify just what is returned
6055 (bug#6576). Text by Eli Zaretskii.
6057 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6059 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6061 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6063 * buffer.c (mmap_find): Fix a typo.
6065 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6067 Fix execution of x selection hooks.
6068 * xselect.c (Qx_lost_selection_functions)
6069 (Qx_sent_selection_functions): New vars.
6070 (syms_of_xselect): DEFSYM them.
6071 (x_handle_selection_request): Pass Qx_sent_selection_functions
6072 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6073 (x_handle_selection_clear,x_clear_frame_selections):
6074 Pass Qx_lost_selection_functions rather than
6075 Vx_lost_selection_functions to Frun_hook_with_args.
6077 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6079 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6080 The old code sometimes used this field without initializing it.
6082 * alloc.c (gc_sweep): Don't read past end of array.
6083 In theory, the old code could also have corrupted Emacs internals,
6084 though it'd be very unlikely.
6086 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6088 * character.c (Fcharacterp): Don't advertise optional ignored
6089 argument. (Bug#4026)
6091 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6093 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6096 * window.c (Fset_window_start): Doc fix (bug#4199).
6097 (Fset_window_hscroll): Ditto.
6099 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6101 Fix minor new problems caught by GCC 4.6.1.
6102 * term.c (init_tty): Remove unused local.
6103 * xsettings.c (store_monospaced_changed): Define this function only
6104 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6107 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6109 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6111 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6113 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6114 are the mini-buffer and the echo area (bug#3320).
6116 * term.c (init_tty): Remove support for supdup, c10 and perq
6117 terminals, which are no longer supported (bug#1482).
6119 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6121 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6123 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6125 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6126 for non-popups (Bug#3642).
6128 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6130 * alloc.c (reset_malloc_hooks): Protoize.
6131 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6132 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6133 * cm.c (losecursor): Likewise.
6134 * data.c (fmod): Likewise.
6135 * dispnew.c (swap_glyphs_in_rows): Likewise.
6136 * emacs.c (memory_warning_signal): Likewise.
6137 * floatfns.c (float_error): Likewise.
6138 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6139 (otf_open, font_otf_capability, generate_otf_features)
6140 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6142 * image.c (pbm_read_file): Likewise.
6143 * indent.c (string_display_width): Likewise.
6144 * intervals.c (check_for_interval, search_for_interval)
6145 (inc_interval_count, count_intervals, root_interval)
6146 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6147 * lread.c (defalias): Likewise.
6148 * ralloc.c (r_alloc_check): Likewise.
6149 * regex.c (set_image_of_range_1, set_image_of_range)
6150 (regex_grow_registers): Likewise.
6151 * sysdep.c (strerror): Likewise.
6152 * termcap.c (valid_filename_p, tprint, main): Likewise.
6153 * tparam.c (main): Likewise.
6154 * unexhp9k800.c (run_time_remap, save_data_space)
6155 (update_file_ptrs, read_header, write_header, calculate_checksum)
6156 (copy_file, copy_rest, display_header): Likewise.
6157 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6159 * xdisp.c (check_it): Likewise.
6160 * xfaces.c (register_color, unregister_color, unregister_colors):
6162 * xfns.c (print_fontset_result): Likewise.
6163 * xrdb.c (member, fatal, main): Likewise.
6165 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6167 Fix minor problems found by static checking (Bug#9031).
6168 * chartab.c (char_table_set_range, map_sub_char_table):
6169 Remove unused locals.
6170 (uniprop_table): Now static.
6171 * composite.c (_work_char): Remove unused static var.
6173 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6175 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6177 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6179 * gtkutil.c (qttip_cb): Remove code without function.
6181 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6183 * w32.c (pthread_sigmask): New stub.
6185 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6187 Use pthread_sigmask, not sigprocmask (Bug#9010).
6188 sigprocmask is portable only for single-threaded applications, and
6189 Emacs can be multi-threaded when it uses GTK.
6190 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6192 * callproc.c (Fcall_process):
6193 * process.c (create_process):
6194 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6195 Use pthread_sigmask, not sigprocmask.
6197 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6199 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6200 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6203 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6205 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6206 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6207 (xg_hide_tooltip): Fix comment.
6209 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6210 in registerServicesMenuSendTypes.
6211 (validRequestorForSendType): Don't check ns_return_types.
6213 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6216 2011-07-08 Jason Rumney <jasonr@gnu.org>
6218 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6219 SH_SHOW for hidden windows (Bug#5482).
6221 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6222 frame struct members of non-existent frames (Bug#6284).
6224 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6226 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6227 variable firstTime not needed on OSX >= 10.6.
6228 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6229 >= 10.5. Use setKnobProportion, setDoubleValue.
6231 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6232 (MAC_OS_X_VERSION_10_5): Define if not defined.
6233 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6234 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6235 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6237 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6238 cString and lossyCString on OSX >= 10.4
6240 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6241 sizeToFit on OSX >= 10.2.
6243 * nsimage.m (allocInitFromFile): Don't use deprecated method
6244 bestRepresentationForDevice on OSX >= 10.6.
6246 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6249 * emacs.c: Declare unexec_init_emacs_zone.
6251 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6253 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6255 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6256 on svcsMenu (Bug#8842).
6258 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6260 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6262 * nsterm.m (QUTF8_STRING): Declare.
6263 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6264 (validRequestorForSendType): Return type is (id).
6265 Change indexOfObjectIdenticalTo to indexOfObject.
6266 Check if we have local selection before returning self (Bug#8842).
6267 (writeSelectionToPasteboard): Put local selection into paste board
6268 if we have a local selection (Bug#8842).
6269 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6271 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6272 (ns_get_local_selection): Declare.
6274 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6276 * keymap.c (describe_map_tree): Don't insert a double newline at
6277 the end of the buffer (bug#1169) and return whether we inserted
6280 * callint.c (Fcall_interactively): Change "reading args" to
6281 "providing args" to try to clarify what it does (bug#1010).
6283 2011-07-07 Kenichi Handa <handa@m17n.org>
6285 * composite.c (composition_compute_stop_pos): Ignore a static
6286 composition starting before CHARPOS (Bug#8915).
6288 * xdisp.c (handle_composition_prop): Likewise.
6290 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6292 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6295 2011-07-07 Kenichi Handa <handa@m17n.org>
6297 * character.h (unicode_category_t): New enum type.
6299 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6300 (Qchar_code_property_table): New variable.
6301 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6302 (UNIPROP_COMPRESSED_FORM_P): New macros.
6303 (char_table_ascii): Uncompress the compressed values.
6304 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6305 Uncompress the compressed values.
6306 (sub_char_table_ref_and_range): Likewise.
6307 (char_table_ref_and_range): Uncompress the compressed values.
6308 (sub_char_table_set): New arg is_uniprop. Callers changed.
6309 Uncompress the compressed values.
6310 (sub_char_table_set_range): Args changed. Callers changed.
6311 (char_table_set_range): Adjuted for the above change.
6312 (map_sub_char_table): Delete args default_val and parent. Add arg
6313 top. Give decoded values to a Lisp function.
6314 (map_char_table): Adjust for the above change. Give decoded
6315 values to a Lisp function. Gcpro more variables.
6316 (uniprop_table_uncompress)
6317 (uniprop_decode_value_run_length): New functions.
6318 (uniprop_decoder, uniprop_decoder_count): New variables.
6319 (uniprop_get_decoder, uniprop_encode_value_character)
6320 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6322 (uniprop_encoder, uniprop_encoder_count): New variables.
6323 (uniprop_get_encoder, uniprop_table)
6324 (Funicode_property_table_internal, Fget_unicode_property_internal)
6325 (Fput_unicode_property_internal): New functions.
6326 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6327 Sunicode_property_table_internal, Sget_unicode_property_internal,
6328 and Sput_unicode_property_internal. Defvar_lisp
6329 char-code-property-alist.
6331 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6332 Vunicode_category_table.
6334 * font.c (font_range): Adjust for the change of
6335 Vunicode_category_table.
6337 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6339 * m/iris4d.h: Remove file, move contents ...
6340 * s/irix6-5.h: ... here.
6342 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6344 Remove unportable assumption about struct layout (Bug#8884).
6345 * alloc.c (mark_buffer):
6346 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6347 (clone_per_buffer_values): Don't assume that
6348 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6349 This isn't true in general, and it's particularly not true
6350 if Emacs is configured with --with-wide-int.
6351 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6352 New macros, used in the buffer.c change.
6354 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6356 * xsettings.c: Use both GConf and GSettings if both are available.
6357 (store_config_changed_event): Add comment.
6358 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6359 (store_tool_bar_style_changed): New functions.
6360 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6361 (struct xsettings): Move font inside HAVE_XFT.
6362 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6363 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6364 Move inside HAVE_XFT.
6365 (something_changed_gsettingsCB): Rename from something_changedCB.
6366 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6368 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6369 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6370 (something_changed_gconfCB): Rename from something_changedCB.
6371 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6372 (parse_settings): Move check for font inside HAVE_XFT.
6373 (read_settings, apply_xft_settings): Add comment.
6374 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6375 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6376 call store_font_name_changed.
6377 (xft_settings_event): Add comment.
6378 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6379 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6380 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6381 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6382 (xsettings_initialize): Call init_gsettings last.
6383 (xsettings_get_system_font, xsettings_get_system_normal_font):
6386 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6388 Random fixes. E.g., (random) never returned negative values.
6389 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6390 subseconds part to the entropy, as that's a bit more random.
6391 Prefer signed to unsigned, since the signedness doesn't matter and
6392 in general we prefer signed. When given a limit, use a
6393 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6394 latter isn't right if USE_2_TAGS_FOR_INTS.
6395 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6396 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6398 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6400 * textprop.c (text_property_stickiness):
6401 Obey Vtext_property_default_nonsticky.
6402 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6403 * w32fns.c (syms_of_w32fns):
6404 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6406 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6408 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6409 This is more efficient than Ffile_directory_p and avoids a minor race.
6411 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6413 * buffer.c (Foverlay_put): Say what the return value is
6416 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6417 is a directory before asking whether to use the file name
6419 (barf_or_query_if_file_exists): Make the "File is a directory"
6420 error be more correct.
6422 * fns.c (Frequire): Remove the mention of the .gz files, since
6423 that's installation-specific, but keep the mention of
6424 `get-load-suffixes'.
6426 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6428 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6429 Report string overflow if the output is too long.
6431 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6433 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6434 (syms_of_gnutls): Remove duplicate DEFSYM for
6435 Qgnutls_bootprop_verify_hostname_error, an error for
6436 Qgnutls_bootprop_verify_error (which is no longer used).
6438 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6439 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6440 Also (re)move comments that are misplaced or no longer relevant.
6442 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6444 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6446 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6448 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6449 and background color parameters if they have been changed.
6451 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6453 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6455 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6457 * xsettings.c (SYSTEM_FONT): Define only when used.
6458 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6460 * keymap.c (access_keymap_1): Now static.
6462 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6464 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6465 leave any prefix arg for the up event (Bug#1586).
6467 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6469 * lread.c (syms_of_lread): Mention single symbols defined by
6470 `defvar' or `defconst' (bug#7154).
6472 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6473 (Frequire): Mention get-load-suffixes.
6475 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6477 * window.h (window): Remove clone_number slot.
6478 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6480 (make_parent_window, make_window, saved_window)
6481 (Fset_window_configuration, save_window_save): Don't deal with
6483 * buffer.c (Qclone_number): Remove declaration.
6484 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6486 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6488 Add multiple inheritance to keymaps.
6489 * keymap.c (Fmake_composed_keymap): New function.
6490 (Fset_keymap_parent): Simplify.
6491 (fix_submap_inheritance): Remove.
6492 (access_keymap_1): New function extracted from access_keymap to handle
6493 embedded parents and handle lists of maps.
6494 (access_keymap): Use it.
6495 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6496 (Fcopy_keymap): Handle embedded parents.
6497 (Fcommand_remapping, define_as_prefix): Simplify.
6498 (Fkey_binding): Simplify.
6499 (syms_of_keymap): Move minibuffer-local-completion-map,
6500 minibuffer-local-filename-completion-map,
6501 minibuffer-local-must-match-map, and
6502 minibuffer-local-filename-must-match-map to Elisp.
6503 (syms_of_keymap): Defsubr make-composed-keymap.
6504 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6505 (parse_menu_item): Trivial simplification.
6507 2011-07-01 Glenn Morris <rgm@gnu.org>
6509 * Makefile.in (SETTINGS_LIBS): Fix typo.
6511 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6513 * coding.c (Fencode_coding_string): Record the last coding system
6514 used, as the function doc string says (bug#8738).
6516 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6518 * xsettings.c (store_monospaced_changed): Take new font as arg and
6519 check for change against current_mono_font.
6520 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6521 (emacs_settings_constructor, emacs_settings_get_property)
6522 (emacs_settings_set_property, emacs_settings_class_init)
6523 (emacs_settings_init, gsettings_obj): Remove.
6524 (something_changedCB): New function for HAVE_GSETTINGS.
6525 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6526 with value as argument.
6527 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6528 g_settings_new (Bug#8967). Do not create gsettings_obj.
6529 Remove calls to g_settings_bind. Connect something_changedCB to
6532 * xgselect.c: Add defined (HAVE_GSETTINGS).
6533 (xgselect_initialize): Ditto.
6535 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6536 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6539 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6541 * eval.c (struct backtrace): Simplify and port the data structure.
6542 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6543 signed bit field, as this assumption is not portable and it makes
6544 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6545 "char debug_on_exit : 1" as this is not portable either; instead,
6546 use the portable "unsigned int debug_on_exit : 1". Remove unused
6547 member evalargs. Remove obsolete comments about cc bombing out.
6549 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6551 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6552 Let HAVE_GSETTINGS override HAVE_GCONF.
6553 (store_monospaced_changed): New function.
6554 (EMACS_SETTINGS): A new type derived from GObject to handle
6555 GSettings notifications.
6556 (emacs_settings_constructor, emacs_settings_get_property)
6557 (emacs_settings_set_property, emacs_settings_class_init):
6559 (gsettings_client, gsettings_obj): New variables.
6560 (GSETTINGS_SCHEMA): New define.
6561 (something_changedCB): Call store_monospaced_changed.
6562 (init_gsettings): New function.
6563 (xsettings_initialize): Call init_gsettings.
6564 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6567 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6570 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6572 * window.c (resize_root_window, grow_mini_window)
6573 (shrink_mini_window): Rename Qresize_root_window to
6574 Qwindow_resize_root_window and Qresize_root_window_vertically to
6575 Qwindow_resize_root_window_vertically.
6577 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6579 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6581 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6583 * makefile.w32-in: Redesign dependencies so they reflect more
6584 clearly which files are directly included by each source file,
6585 and not through other includes.
6587 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6589 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6590 (sort_overlays, overlay_strings): When an overlay's clone number
6591 matches the window's clone number process the overlay even if
6592 the overlay's window property doesn't match the current window.
6594 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6595 (Fwindow_hchild): Rename to Fwindow_left_child.
6596 (Fwindow_next): Rename to Fwindow_next_sibling.
6597 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6598 (resize_window_check): Rename to window_resize_check.
6599 (resize_window_apply): Rename to window_resize_apply.
6600 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6601 (Fdelete_other_windows_internal, resize_frame_windows)
6602 (Fsplit_window_internal, Fdelete_window_internal)
6603 (grow_mini_window, shrink_mini_window)
6604 (Fresize_mini_window_internal): Fix callers accordingly.
6606 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6608 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6609 (emacs_fixed_set_min_size): Remove.
6610 (emacs_fixed_new): Take frame as argument.
6612 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6613 (_EmacsFixedPrivate): Remove minwidth/height.
6614 Add struct frame *f.
6615 (emacs_fixed_init): Initialize priv->f.
6616 (get_parent_class, emacs_fixed_set_min_size): Remove.
6617 (emacs_fixed_new): Set priv->f to argument.
6618 (emacs_fixed_get_preferred_width)
6619 (emacs_fixed_get_preferred_height): Use min_width/height from
6620 frames size_hint to set minimum and natural (Bug#8919).
6621 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6622 and use min_width/height from frames size_hint to set
6623 min_width/height (Bug#8919).
6625 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6626 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6629 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6631 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6632 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6635 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6637 * process.c (wait_reading_process_output): Bypass select if
6638 waiting for a cell while ignoring keyboard input, and input is
6639 pending. Suggested by Jan Djärv (Bug#8869).
6641 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6643 Use gnulib's dup2 module instead of rolling our own.
6644 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6646 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6648 * dispnew.c (scrolling_window): Before scrolling, turn off a
6649 mouse-highlight in the window being scrolled.
6651 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6653 Move DEFSYM to lisp.h and use everywhere.
6655 * character.h (DEFSYM): Move declaration...
6656 * lisp.h (DEFSYM): ...here.
6662 * w32select.c: Don't include character.h.
6664 * alloc.c (syms_of_alloc):
6665 * buffer.c (syms_of_buffer):
6666 * bytecode.c (syms_of_bytecode):
6667 * callint.c (syms_of_callint):
6668 * casefiddle.c (syms_of_casefiddle):
6669 * casetab.c (init_casetab_once):
6670 * category.c (init_category_once, syms_of_category):
6671 * ccl.c (syms_of_ccl):
6672 * cmds.c (syms_of_cmds):
6673 * composite.c (syms_of_composite):
6674 * dbusbind.c (syms_of_dbusbind):
6675 * dired.c (syms_of_dired):
6676 * dispnew.c (syms_of_display):
6677 * doc.c (syms_of_doc):
6678 * editfns.c (syms_of_editfns):
6679 * emacs.c (syms_of_emacs):
6680 * eval.c (syms_of_eval):
6681 * fileio.c (syms_of_fileio):
6682 * fns.c (syms_of_fns):
6683 * frame.c (syms_of_frame):
6684 * fringe.c (syms_of_fringe):
6685 * insdel.c (syms_of_insdel):
6686 * keymap.c (syms_of_keymap):
6687 * lread.c (init_obarray, syms_of_lread):
6688 * macros.c (syms_of_macros):
6689 * msdos.c (syms_of_msdos):
6690 * print.c (syms_of_print):
6691 * process.c (syms_of_process):
6692 * search.c (syms_of_search):
6693 * sound.c (syms_of_sound):
6694 * syntax.c (init_syntax_once, syms_of_syntax):
6695 * terminal.c (syms_of_terminal):
6696 * textprop.c (syms_of_textprop):
6697 * undo.c (syms_of_undo):
6698 * w32.c (globals_of_w32):
6699 * window.c (syms_of_window):
6700 * xdisp.c (syms_of_xdisp):
6701 * xfaces.c (syms_of_xfaces):
6702 * xfns.c (syms_of_xfns):
6703 * xmenu.c (syms_of_xmenu):
6704 * xsettings.c (syms_of_xsettings):
6705 * xterm.c (syms_of_xterm): Use DEFSYM.
6707 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6709 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6711 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6713 Integer and buffer overflow fixes (Bug#8873).
6715 * print.c (printchar, strout): Check for string overflow.
6716 (PRINTPREPARE, printchar, strout):
6717 Don't set size unless allocation succeeds.
6719 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6720 for sizes. Check for string overflow more accurately.
6721 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6723 * macros.c: Integer and buffer overflow fixes.
6724 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6725 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6726 Use ptrdiff_t, not int, for sizes.
6727 Don't increment bufsize until after realloc succeeds.
6728 Check for size-calculation overflow.
6729 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6731 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6733 * lread.c: Integer overflow fixes.
6734 (read_integer): Radix is now EMACS_INT, not int,
6735 to improve quality of diagnostics for out-of-range radices.
6736 Calculate buffer size correctly for out-of-range radices.
6737 (read1): Check for integer overflow in radices, and in
6738 read-circle numbers.
6739 (read_escape): Avoid int overflow.
6740 (Fload, openp, read_buffer_size, read1)
6741 (substitute_object_recurse, read_vector, read_list, map_obarray):
6742 Use ptrdiff_t, not int, for sizes.
6743 (read1): Use EMACS_INT, not int, for sizes.
6744 Check for size overflow.
6746 * image.c (cache_image): Check for size arithmetic overflow.
6748 * lread.c: Integer overflow issues.
6749 (saved_doc_string_size, saved_doc_string_length)
6750 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6751 Now ptrdiff_t, not int.
6752 (read1): Don't assume doc string length fits in int. Check for
6753 out-of-range doc string lengths.
6754 (read_list): Don't assume file position fits in int.
6755 (read_escape): Check for hex character overflow.
6757 2011-06-22 Leo Liu <sdl.web@gmail.com>
6759 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6760 Move to minibuffer.el.
6762 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6764 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6765 The following patches are for when GLYPH_DEBUG && !XASSERT.
6766 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6767 * dispnew.c (flush_stdout):
6768 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6769 Mark as externally visible.
6770 * dispnew.c (check_window_matrix_pointers): Now static.
6771 * dispnew.c (window_to_frame_vpos):
6772 * xfns.c (unwind_create_frame):
6773 * xterm.c (x_check_font): Remove unused local.
6774 * scroll.c (CHECK_BOUNDS):
6775 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6776 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6777 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6778 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6779 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6781 (debug_method_add): Use va_list and vsprintf rather than relying
6782 on undefined behavior with wrong number of arguments.
6783 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6784 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6785 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6786 since we're not interested in debugging glyphs with old libraries.
6787 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6788 GCC 4.6.0's static checking.
6790 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6792 Integer overflow and signedness fixes (Bug#8873).
6793 A few related buffer overrun fixes, too.
6795 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6797 * dispextern.h (struct face.stipple):
6798 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6799 (x_bitmap_mask, x_allocate_bitmap_record)
6800 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6801 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6802 (x_create_bitmap_from_xpm_data):
6803 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6804 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6806 * xfaces.c (load_pixmap):
6807 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6808 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6809 (.bitmaps_last, struct x_output.icon_bitmap):
6810 Use ptrdiff_t, not int, for bitmap indexes.
6811 (x_allocate_bitmap_record): Check for size overflow.
6812 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6814 Use ptrdiff_t, not int, for overlay counts.
6815 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6816 * editfns.c (overlays_around, get_pos_property):
6817 * textprop.c (get_char_property_and_overlay):
6818 * xdisp.c (next_overlay_change, note_mouse_highlight):
6819 * xfaces.c (face_at_buffer_position):
6820 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6821 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6822 (Fnext_overlay_change, Fprevious_overlay_change)
6823 (mouse_face_overlay_overlaps, Foverlays_in):
6824 Use ptrdiff_t, not int, for sizes.
6825 (overlays_at, overlays_in): Check for size-calculation overflow.
6827 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6829 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6830 (x_session_initialize): Do not assume string length fits in int.
6832 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6833 This is unlikely, but can occur if DPI is outlandish.
6835 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6836 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6838 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6839 * xrdb.c (magic_file_p, search_magic_path):
6840 Omit last arg SUFFIX; it was always 0. All callers changed.
6841 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6843 * xfont.c (xfont_match): Avoid need for strlen.
6845 * xfns.c: Don't assume strlen fits in int.
6846 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6848 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6849 not unsigned long, as we prefer signed integers. All callers changed.
6850 Detect integer overflow in repeat count.
6851 (message_dolog): Don't assume print length fits in 39 bytes.
6852 (display_mode_element): Don't assume strlen fits in int.
6854 * termcap.c: Don't assume sizes fit in int and never overflow.
6855 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6856 (gobble_line): Check for size-calculation overflow.
6858 * minibuf.c (Fread_buffer):
6859 * lread.c (intern, intern_c_string):
6860 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6861 Don't assume string length fits in int.
6863 * keyboard.c (parse_tool_bar_item):
6864 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6866 * font.c: Don't assume string length fits in int.
6867 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6868 Use ptrdiff_t, not int.
6869 (font_intern_prop): Don't assume string length fits in int.
6870 Don't assume integer property fits in fixnum.
6871 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6873 * filelock.c: Fix some buffer overrun and integer overflow issues.
6874 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6875 Reformulate so as not to need the command string.
6876 Invoke gzip -cd rather than gunzip, as it's more portable.
6877 (lock_info_type, lock_file_1, lock_file):
6878 Don't assume pid_t and time_t fit in unsigned long.
6879 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6880 (current_lock_owner): Prefer signed type for sizes.
6881 Use memcpy, not strncpy, where memcpy is what is really wanted.
6882 Don't assume (via atoi) that time_t and pid_t fit in int.
6883 Check for time_t and/or pid_t out of range, e.g., via a network share.
6884 Don't alloca where an auto var works fine.
6886 * fileio.c: Fix some integer overflow issues.
6887 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6888 Don't assume string length fits in int.
6889 (directory_file_name): Don't assume string length fits in long.
6890 (make_temp_name): Don't assume pid fits in int, or that its print
6891 length is less than 20.
6893 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6895 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6897 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6899 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6900 We prefer signed integers, even for size calculations.
6902 * emacs.c: Don't assume string length fits in 'int'.
6903 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6904 (main): Don't invoke strlen when not needed.
6906 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6907 (XD_DEBUG_MESSAGE): Don't waste a byte.
6909 * callproc.c (getenv_internal_1, getenv_internal)
6911 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6913 * lread.c (invalid_syntax): Omit length argument.
6914 All uses changed. This doesn't fix a bug, but it simplifies the
6915 code away from its former Hollerith-constant appearance, and it's
6916 one less 'int' to worry about when looking at integer-overflow issues.
6917 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6919 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6920 This didn't break anything, but it didn't help either.
6921 It's confusing to put a bogus integer in a place where the actual
6922 value does not matter.
6923 (LIST_END_P): Remove unused macro and its bogus comment.
6924 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6926 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6927 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6929 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6930 We prefer signed types, and the value cannot exceed the EMACS_INT
6931 range anyway (because otherwise the length would not be representable).
6932 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6933 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6934 This avoids a GCC warning when WIDE_EMACS_INT.
6936 * indent.c (sane_tab_width): New function.
6937 (current_column, scan_for_column, Findent_to, position_indentation)
6938 (compute_motion): Use it. This is just for clarity.
6939 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6941 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6943 * lisp.h (lint_assume): New macro.
6944 * composite.c (composition_gstring_put_cache):
6945 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6947 * editfns.c, insdel.c:
6948 Omit unnecessary forward decls, to simplify future changes.
6950 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6952 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6954 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6955 Use much-faster test for byte-length change.
6956 Don't assume string byte-length fits in 'int'.
6957 Check that character arg fits in 'int'.
6958 (mapcar1): Declare byte as byte, for clarity.
6960 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6962 * fns.c (concat): Catch string overflow earlier.
6963 Do not rely on integer wraparound.
6965 * dispextern.h (struct it.overlay_strings_charpos)
6966 (struct it.selective): Now EMACS_INT, not int.
6967 * xdisp.c (forward_to_next_line_start)
6968 (back_to_previous_visible_line_start)
6969 (reseat_at_next_visible_line_start, next_element_from_buffer):
6970 Don't arbitrarily truncate the value of 'selective' to int.
6972 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6974 * composite.c: Don't truncate sizes to 'int'.
6975 (composition_gstring_p, composition_reseat_it)
6976 (composition_adjust_point): Use EMACS_INT, not int.
6977 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6978 not EMACS_UINT, for indexes.
6980 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6982 * buffer.c: Include <verify.h>.
6983 (struct sortvec.priority, struct sortstr.priority):
6984 Now EMACS_INT, not int.
6985 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6986 (struct sortstr.size, record_overlay_string)
6987 (struct sortstrlist.size, struct sortlist.used):
6988 Don't truncate size to int.
6989 (record_overlay_string): Check for size-calculation overflow.
6990 (init_buffer_once): Check at compile-time, not run-time.
6992 2011-06-22 Jim Meyering <meyering@redhat.com>
6994 Don't leak an XBM-image-sized buffer
6995 * image.c (xbm_load): Free the image buffer after using it.
6997 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7000 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7001 that Sun C diagnosed.
7002 * fns.c (secure_hash): Fix pointer signedness issue.
7003 * intervals.c (static_offset_intervals): New function.
7004 (offset_intervals): Use it.
7006 2011-06-21 Leo Liu <sdl.web@gmail.com>
7009 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7012 * fns.c (secure_hash): Rename from crypto_hash_function and change
7013 the first arg to accept symbols.
7014 (Fsecure_hash): New primitive.
7015 (syms_of_fns): New symbols.
7017 2011-06-20 Deniz Dogan <deniz@dogan.se>
7019 * process.c (Fset_process_buffer): Clarify return value in
7022 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7024 * dispnew.c (add_window_display_history): Use BVAR.
7026 * xdisp.c (debug_method_add): Use BVAR.
7027 (check_window_end, dump_glyph_matrix, dump_glyph)
7028 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7030 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7033 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7034 check till after the cache is created in init_frame_faces.
7036 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7038 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7040 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7042 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7043 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7044 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7046 Improve buffer-overflow checking (Bug#8873).
7047 * fileio.c (Finsert_file_contents):
7048 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7049 Remove the old (too-loose) buffer overflow checks.
7050 They weren't needed, since make_gap checks for buffer overflow.
7051 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7052 The old code merely checked for Emacs fixnum overflow, and relied
7053 on undefined (wraparound) behavior. The new code avoids undefined
7054 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7056 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7057 Tune. Don't use wider integers than needed. Don't use alloca.
7058 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7060 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7062 * insdel.c, lisp.h (buffer_overflow): New function.
7063 (insert_from_buffer_1, replace_range, replace_range_2):
7064 * insdel.c (make_gap_larger):
7065 * editfns.c (Finsert_char):
7066 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7068 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7070 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7072 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7074 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7075 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7077 * fileio.c: Don't assume EMACS_INT fits in off_t.
7078 (emacs_lseek): New static function.
7079 (Finsert_file_contents, Fwrite_region): Use it.
7080 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7082 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7084 * fns.c: Don't overflow int when computing a list length.
7085 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7086 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7087 truncation on 64-bit hosts. Check for QUIT every
7088 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7089 faster and is responsive enough.
7090 (Flength): Report an error instead of overflowing an integer.
7091 (Fsafe_length): Return a float if the value is not representable
7092 as a fixnum. This shouldn't happen except in contrived situations.
7093 (Fnthcdr, Fsort): Don't assume list length fits in int.
7094 (Fcopy_sequence): Don't assume vector length fits in int.
7096 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7097 (header_size, word_size): New constants.
7098 (allocate_vectorlike): Don't check size overflow here.
7099 (allocate_vector): Check it here instead, since this is the only
7100 caller of allocate_vectorlike that could cause overflow.
7101 Check that the new vector's length is representable as a fixnum.
7103 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7104 The previous code was bogus. For example, next_almost_prime (32)
7105 returned 39, which is undesirable as it is a multiple of 3; and
7106 next_almost_prime (24) returned 25, which is a multiple of 5 so
7107 why was the code bothering to check for multiples of 7?
7109 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7111 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7113 Variadic C functions now count arguments with ptrdiff_t.
7114 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7115 Back then I didn't know that the Emacs coding style prefers signed int.
7116 Also, in the meantime I found a few more instances where arguments
7117 were being counted with int, which may truncate counts on 64-bit
7118 machines, or EMACS_INT, which may be unnecessarily wide.
7119 * lisp.h (struct Lisp_Subr.function.aMANY)
7120 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7121 Arg counts are now ptrdiff_t, not size_t.
7122 All variadic functions and their callers changed accordingly.
7123 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7124 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7125 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7126 * callint.c (Fcall_interactively): Check arg count for overflow,
7127 to avoid potential buffer overrun. Use signed char, not 'int',
7128 for 'varies' array, so that we needn't bother to check its size
7129 calculation for overflow.
7130 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7131 * eval.c (apply_lambda):
7132 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7133 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7134 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7136 * callint.c (Fcall_interactively): Don't use index var as event count.
7138 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7139 * mem-limits.h (SIZE): Remove; no longer used.
7141 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7143 Remove unnecessary casts.
7144 * xterm.c (x_term_init):
7145 * xfns.c (x_set_border_pixel):
7146 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7147 These aren't needed now that we assume ANSI C.
7149 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7150 It's more likely to cause problems (due to unsigned overflow)
7153 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7155 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7157 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7159 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7161 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7163 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7165 GLYPH_CODE_FACE returns EMACS_INT, not int.
7166 * dispextern.h (merge_faces):
7167 * xfaces.c (merge_faces):
7168 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7169 Don't assume EMACS_INT fits in int.
7171 * character.h (CHAR_VALID_P): Remove unused parameter.
7172 * fontset.c, lisp.h, xdisp.c: All uses changed.
7174 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7176 * fns.c (concat): Minor tuning based on overflow analysis.
7177 This doesn't fix any bugs. Use int to hold character, instead
7178 of constantly refetching from Emacs object. Use XFASTINT, not
7179 XINT, for value known to be a character. Don't bother comparing
7180 a single byte to 0400, as it's always less.
7182 * floatfns.c (Fexpt):
7183 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7185 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7188 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7190 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7191 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7192 incorrectly succeed when S was a string, because 4294967386 was
7193 truncated before it was used.
7195 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7196 Otherwise, an out-of-range integer could cause undefined behavior
7199 * composite.c: Use int, not EMACS_INT, for characters.
7200 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7201 EMACS_INT, for values that are known to be in character range.
7202 This doesn't fix any bugs but is the usual style inside Emacs and
7203 may generate better code on 32-bit machines.
7205 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7206 This is for reasons similar to the recent CHAR_STRING fix.
7207 * charset.c (Fencode_char): Check that character arg is actually
7208 a character. Pass an int to ENCODE_CHAR.
7209 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7210 wider than 'int', as a compile-time check to prevent future regressions
7213 * character.c (char_string): Remove unnecessary casts.
7215 Make sure a 64-bit char is never passed to CHAR_STRING.
7216 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7217 by silently ignoring the top 32 bits, allowing some values
7218 that were far too large to be valid characters.
7219 * character.h: Include <verify.h>.
7220 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7221 arguments are no wider than unsigned, as a compile-time check
7222 to prevent future regressions in this area.
7224 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7225 (Fsubst_char_in_region):
7227 * xdisp.c (decode_mode_spec_coding):
7228 Adjust to CHAR_STRING's new requirement.
7229 * editfns.c (Finsert_char, Fsubst_char_in_region):
7230 * fns.c (concat): Check that character args are actually
7231 characters. Without this test, these functions did the wrong
7232 thing with wildly out-of-range values on 64-bit hosts.
7234 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7235 These casts should not be needed on 32-bit hosts, either.
7236 * keyboard.c (read_char):
7237 * lread.c (Fload): Remove casts to unsigned.
7239 * lisp.h (UNSIGNED_CMP): New macro.
7240 This fixes comparison bugs on 64-bit hosts.
7241 (ASCII_CHAR_P): Use it.
7242 * casefiddle.c (casify_object):
7243 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7244 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7245 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7246 * dispextern.h (FACE_FROM_ID):
7247 * keyboard.c (read_char): Use UNSIGNED_CMP.
7249 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7250 not to EMACS_INT, to avoid GCC warning.
7252 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7254 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7255 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7256 isn't needed on 32-bit machines.
7258 * buffer.c (Fgenerate_new_buffer_name):
7259 Use EMACS_INT for count, not int.
7260 (advance_to_char_boundary): Return EMACS_INT, not int.
7262 * data.c (Qcompiled_function): Now static.
7264 * window.c (window_body_lines): Now static.
7266 * image.c (gif_load): Rename local to avoid shadowing.
7268 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7269 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7270 * alloc.c (make_save_value): Integer argument is now of type
7272 (mark_object): Use ptrdiff_t, not int.
7273 * lisp.h (pD): New macro.
7274 * print.c (print_object): Use it.
7276 * alloc.c: Use EMACS_INT, not int, to count objects.
7277 (total_conses, total_markers, total_symbols, total_vector_size)
7278 (total_free_conses, total_free_markers, total_free_symbols)
7279 (total_free_floats, total_floats, total_free_intervals)
7280 (total_intervals, total_strings, total_free_strings):
7281 Now EMACS_INT, not int. All uses changed.
7282 (Fgarbage_collect): Compute overall total using a double, so that
7283 integer overflow is less likely to be a problem. Check for overflow
7284 when converting back to an integer.
7285 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7286 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7287 These were 'int' variables that could overflow on 64-bit hosts;
7288 they were never used, so remove them instead of repairing them.
7289 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7290 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7291 Previously, this ceilinged at INT_MAX, but that doesn't work on
7293 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7295 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7296 (allocate_vectorlike): Check for ptrdiff_t overflow.
7297 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7298 when a (possibly-narrower) signed value would do just as well.
7299 We prefer using signed arithmetic, to avoid comparison confusion.
7301 * alloc.c: Catch some string size overflows that we were missing.
7302 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7303 for convenience in STRING_BYTES_MAX.
7304 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7305 The definition here is exact; the one in lisp.h was approximate.
7306 (allocate_string_data): Check for string overflow. This catches
7307 some instances we weren't catching before. Also, it catches
7308 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7309 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7310 and ptrdiff_t and EMACS_INT are both 64 bits.
7312 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7313 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7314 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7316 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7318 * alloc.c (Fmake_string): Check for out-of-range init.
7320 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7322 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7324 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7326 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7327 xg_get_default_scrollbar_width.
7329 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7330 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7331 (style_changed_cb): Call update_theme_scrollbar_width and call
7332 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7333 all frames (Bug#8505).
7334 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7335 Call gtk_window_set_resizable if HAVE_GTK3.
7336 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7337 and height if HAVE_GTK3 (Bug#8505).
7338 (scroll_bar_width_for_theme): New variable.
7339 (update_theme_scrollbar_width): New function.
7340 (xg_get_default_scrollbar_width): Move code to
7341 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7342 (xg_initialize): Call update_theme_scrollbar_width.
7344 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7346 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7348 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7350 * frame.c (make_frame): Call other_buffer_safely instead of
7353 * window.c (temp_output_buffer_show): Call display_buffer with
7354 second argument Vtemp_buffer_show_specifiers and reset latter
7355 immediately after the call.
7356 (Vtemp_buffer_show_specifiers): New variable.
7357 (auto_window_vscroll_p, next_screen_context_lines)
7358 (Vscroll_preserve_screen_position): Remove leading asterisks from
7361 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7363 Fix minor problems found by GCC 4.6.0 static checking.
7364 * buffer.c (Qclone_number): Remove for now, as it's unused.
7365 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7366 (record_buffer): Remove unused local.
7367 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7368 (set_frame_buffer_list): Remove; unused.
7369 * frame.h (other_visible_frames): Remove decl.
7370 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7371 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7372 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7374 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7375 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7376 Define only if HAVE_GPM.
7377 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7378 (update_hints_inhibit): Remove; never set. All uses removed.
7379 * widgetprv.h (emacsFrameClassRec): Remove decl.
7380 * window.c (delete_deletable_window): Now returns void, since it
7381 wasn't returning anything.
7382 (compare_window_configurations): Remove unused locals.
7383 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7384 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7385 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7386 the same widths as pointers. This follows up on the 2011-05-06 patch.
7387 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7388 * xterm.h: Likewise.
7389 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7391 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7393 * makefile.w32-in: Update dependencies.
7394 (LISP_H): Add lib/intprops.h.
7396 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7398 * image.c (gif_load): Add animation frame delay to the metadata.
7399 (syms_of_image): Use DEFSYM. New symbol `delay'.
7401 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7403 * window.c (delete_deletable_window): Re-add.
7404 (Fset_window_configuration): Rewrite to handle dead buffers and
7405 consequently deletable windows.
7406 (window_tree, Fwindow_tree): Remove. Supply functionality in
7408 (compare_window_configurations): Simplify code.
7410 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7412 * image.c (imagemagick_load_image): Fix type mismatch.
7413 (Fimagemagick_types): Likewise.
7415 * window.h (replace_buffer_in_windows): Declare.
7417 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7419 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7420 Qclone_number. Remove external declaration of Qdelete_window.
7421 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7423 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7424 Run Qbuffer_list_update_hook if allowed.
7425 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7426 buffer list implementation.
7427 (other_buffer_safely): New function.
7428 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7429 calls to replace_buffer_in_windows and
7430 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7432 (record_buffer): Inhibit quitting and rewrite using quittable
7433 functions. Run Qbuffer_list_update_hook if allowed.
7434 (Frecord_buffer, Funrecord_buffer): New functions.
7435 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7436 Move switch-to-buffer to window.el.
7437 (bury-buffer): Move to window.el.
7438 (Vbuffer_list_update_hook): New variable.
7440 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7443 * window.h (resize_frame_windows): Move up in code.
7444 (Fwindow_frame): Remove EXFUN.
7445 (replace_buffer_in_all_windows): Remove prototype.
7446 (replace_buffer_in_windows_safely): Add prototype.
7448 * window.c: Declare Qdelete_window static again. Move down
7449 declaration of select_count.
7450 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7451 (Fother_window): Move to window.el.
7452 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7453 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7454 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7456 (replace_buffer_in_windows): Implement by calling
7457 Qreplace_buffer_in_windows.
7458 (replace_buffer_in_all_windows): Remove with some functionality
7459 moved into replace_buffer_in_windows_safely.
7460 (replace_buffer_in_windows_safely): New function.
7461 (select_window_norecord, select_frame_norecord): Move in front
7462 of run_window_configuration_change_hook. Remove now obsolete
7464 (Fset_window_buffer): Rewrite doc-string.
7465 Call Qrecord_window_buffer.
7466 (keys_of_window): Move binding for other-window to window.el.
7468 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7470 * dispextern.h (struct image): Replace data member, whose int_val
7471 and ptr_val fields were not used by anything, with a single
7474 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7475 (gif_clear_image, gif_load, imagemagick_load_image)
7476 (gs_clear_image, gs_load): Callers changed.
7478 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7480 * buffer.h: Include <time.h>, for time_t.
7481 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7483 Fix minor problems found by static checking.
7485 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7487 Make identifiers static if they are not used in other modules.
7488 * data.c (Qcompiled_function, Qframe, Qvector):
7489 * image.c (QimageMagick, Qsvg):
7490 * minibuf.c (Qmetadata):
7491 * window.c (resize_window_check, resize_root_window): Now static.
7492 * window.h (resize_window_check, resize_root_window): Remove decls.
7494 * window.c (window_deletion_count, delete_deletable_window):
7496 (window_body_lines): Now static.
7497 (Fdelete_other_windows_internal): Mark vars as initialized.
7498 Make sure 'resize_failed' is initialized.
7499 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7500 (resize_window_apply): Remove unused local.
7501 * window.h (delete_deletable_window): Remove decl.
7503 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7504 (imagemagick_load_image): Fix pointer signedness problem by changing
7505 last arg from unsigned char * to char *. All uses changed.
7506 Also, fix a local for similar reasons.
7507 Remove unused locals. Remove locals to avoid shadowing.
7508 (fn_rsvg_handle_free): Remove; unused.
7509 (svg_load, svg_load_image): Fix pointer signedness problem.
7510 (imagemagick_load_image): Don't use garbage pointer image_wand.
7512 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7514 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7516 * image.c (gif_load): Fix omitted cast error introduced by
7519 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7521 * window.h (resize_proportionally, orig_total_lines)
7522 (orig_top_line): Remove from window structure.
7523 (set_window_height, set_window_width, change_window_heights)
7524 (Fdelete_window): Remove prototypes.
7525 (resize_frame_windows): Remove duplicate declaration.
7527 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7529 * window.h (resize_frame_windows, resize_window_check)
7530 (delete_deletable_window, resize_root_window)
7531 (resize_frame_windows): Declare prototypes.
7533 * window.c (resize_window_apply): Make definition be "static" to
7534 match the prototype.
7536 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7538 * window.c: Remove declarations of Qwindow_size_fixed,
7539 window_min_size_1, window_min_size_2, window_min_size,
7540 size_window, window_fixed_size_p, enlarge_window, delete_window.
7541 Remove static from declaration of Qdelete_window, it's
7542 temporarily needed by Fbury_buffer.
7543 (replace_window): Don't assign orig_top_line and
7545 (Fdelete_window, delete_window): Remove. Window deletion is
7546 handled by window.el.
7547 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7548 Replace Fdelete_window calls with calls to Qdelete_window.
7549 (Fdelete_other_windows): Remove. Deleting other windows is
7550 handled by window.el.
7551 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7552 handled in window.el.
7553 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7554 Window minimum sizes are handled in window.el.
7555 (shrink_windows, size_window, set_window_height)
7556 (set_window_width, change_window_heights, window_height)
7557 (window_width, CURBEG, CURSIZE, enlarge_window)
7558 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7559 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7560 handled in window.el.
7561 (make_dummy_parent): Rename to make_parent_window and give it a
7562 second argument horflag.
7563 (make_window): Don't set resize_proportionally any more.
7564 (Fsplit_window): Remove. Windows are split in window.el.
7565 (save_restore_action, save_restore_orig_size)
7566 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7567 Resize mini windows in window.el.
7568 (grow_mini_window, shrink_mini_window): Implement by calling
7569 Qresize_root_window_vertically, resize_window_check and
7570 resize_window_apply.
7571 (saved_window, Fset_window_configuration, save_window_save):
7572 Do not handle orig_top_line, orig_total_lines, and
7573 resize_proportionally.
7574 (window_min_height, window_min_width): Move to window.el.
7575 (keys_of_window): Move bindings for delete-other-windows,
7576 split-window, delete-window and enlarge-window to window.el.
7578 * buffer.c: Temporarily extern Qdelete_window.
7579 (Fbury_buffer): Temporarily call Qdelete_window instead of
7580 Fdelete_window (Fbury_buffer will move to window.el soon).
7582 * frame.c (set_menu_bar_lines_1): Remove code handling
7583 orig_top_line and orig_total_lines.
7585 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7586 set_window_height but set heights directly.
7587 (change_frame_size_1): Use resize_frame_windows.
7589 * xdisp.c (init_xdisp): Don't use set_window_height but set
7592 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7593 Use resize_frame_windows instead of change_window_heights and run
7594 run_window_configuration_change_hook.
7596 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7597 instead of change_window_heights and run
7598 run_window_configuration_change_hook.
7600 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7602 * window.c (replace_window): Rename second argument REPLACEMENT to
7603 NEW. New third argument SETFLAG. Rewrite.
7604 (delete_window, make_dummy_parent): Call replace_window with
7606 (window_list_1): Move down in code.
7607 (run_window_configuration_change_hook): Move set_buffer part
7608 before select_frame_norecord part in order to unwind correctly.
7609 Rename count1 to count.
7610 (recombine_windows, delete_deletable_window, resize_root_window)
7611 (Fdelete_other_windows_internal)
7612 (Frun_window_configuration_change_hook, make_parent_window)
7613 (resize_window_check, resize_window_apply, Fresize_window_apply)
7614 (resize_frame_windows, Fsplit_window_internal)
7615 (Fdelete_window_internal, Fresize_mini_window_internal):
7617 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7619 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7621 * window.h (window): Add some new members to window structure -
7622 normal_lines, normal_cols, new_total, new_normal, clone_number,
7623 splits, nest, prev_buffers, next_buffers.
7624 (WINDOW_TOTAL_SIZE): Move here from window.c.
7625 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7627 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7629 (make_dummy_parent): Set new members of windows structure.
7630 (make_window): Move down in code. Handle new members of window
7632 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7633 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7634 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7635 (Fset_window_prev_buffers, Fwindow_next_buffers)
7636 (Fset_window_next_buffers, Fset_window_clone_number):
7638 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7639 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7641 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7642 Argument WINDOW can be now internal window too.
7643 (Fwindow_use_time): Move up in code.
7644 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7646 (Fset_window_configuration, saved_window)
7647 (Fcurrent_window_configuration, save_window_save): Handle new
7648 members of window structure.
7649 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7650 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7651 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7652 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7653 Qget_mru_window, Qresize_root_window,
7654 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7655 Qauto_buffer_name; staticpro them.
7657 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7659 * window.c (Fwindow_total_size, Fwindow_left_column)
7660 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7661 (Fwindow_list_1): New functions.
7662 (window_box_text_cols): Replace with window_body_cols.
7663 (Fwindow_width, Fscroll_left, Fscroll_right):
7664 Use window_body_cols instead of window_box_text_cols.
7665 (delete_window, Fset_window_configuration):
7666 Call delete_all_subwindows with window as argument.
7667 (delete_all_subwindows): Take a window as argument and not a
7669 (window_loop): Remove handling of GET_LRU_WINDOW and
7671 (Fget_lru_window, Fget_largest_window): Move to window.el.
7673 * window.h: Extern window_body_cols instead of
7674 window_box_text_cols. delete_all_subwindows now takes a
7675 Lisp_Object as argument.
7677 * indent.c (compute_motion, Fcompute_motion):
7678 Use window_body_cols instead of window_box_text_cols.
7680 * frame.c (delete_frame): Call delete_all_subwindows with root
7683 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7685 * fns.c (Fputhash): Document return value.
7687 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7689 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7691 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7693 Cons<->int and similar integer overflow fixes (Bug#8794).
7695 Check for overflow when converting integer to cons and back.
7696 * charset.c (Fdefine_charset_internal, Fdecode_char):
7697 Use cons_to_unsigned to catch overflow.
7698 (Fencode_char): Use INTEGER_TO_CONS.
7699 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7700 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7701 * data.c (long_to_cons, cons_to_long): Remove.
7702 (cons_to_unsigned, cons_to_signed): New functions.
7703 These signal an error for invalid or out-of-range values.
7704 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7705 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7706 * font.c (Ffont_variation_glyphs):
7707 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7708 * lisp.h: Include <intprops.h>.
7709 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7710 (cons_to_signed, cons_to_unsigned): New decls.
7711 (long_to_cons, cons_to_long): Remove decls.
7712 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7713 (Fprimitive_undo): Use CONS_TO_INTEGER.
7714 * xfns.c (Fx_window_property): Likewise.
7715 * xselect.c: Include <limits.h>.
7716 (x_own_selection, selection_data_to_lisp_data):
7717 Use INTEGER_TO_CONS.
7718 (x_handle_selection_request, x_handle_selection_clear)
7719 (x_get_foreign_selection, Fx_disown_selection_internal)
7720 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7721 (lisp_data_to_selection_data): Use cons_to_unsigned.
7722 (x_fill_property_data): Use cons_to_signed.
7723 Report values out of range.
7725 Check for buffer and string overflow more precisely.
7726 * buffer.h (BUF_BYTES_MAX): New macro.
7727 * lisp.h (STRING_BYTES_MAX): New macro.
7728 * alloc.c (Fmake_string):
7729 * character.c (string_escape_byte8):
7730 * coding.c (coding_alloc_by_realloc):
7731 * doprnt.c (doprnt):
7732 * editfns.c (Fformat):
7734 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7735 since they may not be the same number.
7736 * editfns.c (Finsert_char):
7737 * fileio.c (Finsert_file_contents):
7738 Likewise for BUF_BYTES_MAX.
7740 * image.c: Use ptrdiff_t, not int, for sizes.
7741 (slurp_file): Switch from int to ptrdiff_t.
7743 (slurp_file): Check that file size fits in both size_t (for
7744 malloc) and ptrdiff_t (for sanity and safety).
7746 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7747 if b->modtime has its maximal value.
7749 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7751 Don't assume time_t can fit into int.
7752 * buffer.h (struct buffer.modtime): Now time_t, not int.
7753 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7754 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7756 Minor fixes for signed vs unsigned integers.
7757 * character.h (MAYBE_UNIFY_CHAR):
7758 * charset.c (maybe_unify_char):
7759 * keyboard.c (read_char, reorder_modifiers):
7760 XINT -> XFASTINT, since the integer must be nonnegative.
7761 * ftfont.c (ftfont_spec_pattern):
7762 * keymap.c (access_keymap, silly_event_symbol_error):
7763 XUINT -> XFASTINT, since the integer must be nonnegative.
7764 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7765 since it makes no difference and we prefer signed.
7766 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7767 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7770 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7772 * window.h (Fwindow_frame): Declare.
7774 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7776 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7777 (SPARE_MEMORY): Always define.
7778 (LARGE_REQUEST): Remove.
7779 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7781 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7783 * lisp.h: Move EXFUNS for Fframe_root_window,
7784 Fframe_first_window and Fset_frame_selected_window to window.h.
7786 * window.h: Move EXFUNS for Fframe_root_window,
7787 Fframe_first_window and Fset_frame_selected_window here from
7790 * frame.c (Fwindow_frame, Fframe_first_window)
7791 (Fframe_root_window, Fframe_selected_window)
7792 (Fset_frame_selected_window): Move to window.c.
7793 (Factive_minibuffer_window): Move to minibuf.c.
7794 (Fother_visible_frames_p): New function.
7796 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7798 * window.c (decode_window, decode_any_window): Move up in code.
7799 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7800 (inhibit_frame_unsplittable): Remove unused variable.
7801 (Fwindow_buffer): Move up and rewrite doc-string.
7802 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7803 (Fwindow_prev): New functions.
7804 (Fwindow_frame): Move here from frame.c. Accept any window as
7806 (Fframe_root_window, Fframe_first_window)
7807 (Fframe_selected_window): Move here from frame.c. Accept frame
7808 or arbitrary window as argument. Update doc-strings.
7809 (Fminibuffer_window): Move up in code.
7810 (Fwindow_minibuffer_p): Move up in code and simplify.
7811 (Fset_frame_selected_window): Move here from frame.c.
7813 (Fselected_window, select_window, Fselect_window): Move up in
7814 code. Minor doc-string fixes.
7816 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7818 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7819 Do not assume that spare memory exists; that assumption is valid
7820 only if SYSTEM_MALLOC.
7821 (LARGE_REQUEST): New macro, so that the issue of large requests
7822 is separated from the issue of spare memory.
7824 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7826 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7829 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7831 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7834 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7836 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7838 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7840 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7841 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7843 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7845 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7847 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7849 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7850 (x_clipboard_manager_save): Add return value.
7851 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7853 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7854 Obey Vx_select_enable_clipboard_manager. Catch errors in
7855 x_clipboard_manager_save (Bug#8779).
7856 (Vx_select_enable_clipboard_manager): New variable.
7857 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7859 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7861 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7863 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7865 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7866 in the current matrix if keep_current_p is non-zero.
7868 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7870 * bidi.c (bidi_level_of_next_char): Fix last change.
7872 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7874 Support bidi reordering of text covered by display properties.
7876 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7877 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7878 (bidi_cache_search, bidi_cache_iterator_state)
7879 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7880 (bidi_level_of_next_char, bidi_move_to_visually_next):
7881 Support character positions inside a run of characters covered by a
7883 (bidi_paragraph_init, bidi_resolve_explicit_1)
7884 (bidi_level_of_next_char): Call bidi_fetch_char and
7885 bidi_fetch_char_advance instead of FETCH_CHAR and
7887 (bidi_init_it): Initialize new members.
7888 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7890 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7891 instead of using explicit *_CHAR codes.
7892 (bidi_resolve_explicit, bidi_resolve_weak):
7893 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7894 bidirectional text is supported only in multibyte buffers.
7895 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7896 it to initialize the frame_window_p member of struct bidi_it.
7897 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7898 (bidi_resolve_explicit, bidi_resolve_weak)
7899 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7900 bidi_it->nchars is non-positive.
7901 (bidi_level_of_next_char): Don't try to lookup the cache for the
7902 next/previous character if nothing is cached there yet, or if we
7903 were just reseat()'ed to a new position.
7905 * xdisp.c (set_cursor_from_row): Set start and stop points
7906 according to the row's direction when priming the loop that looks
7907 for the glyph on which to display cursor.
7908 (single_display_spec_intangible_p): Function deleted.
7909 (display_prop_intangible_p): Reimplement to call
7910 handle_display_spec instead of single_display_spec_intangible_p.
7911 Accept 3 additional arguments needed by handle_display_spec.
7912 This fixes incorrect cursor motion across display property with complex
7913 values: lists, `(when COND...)' forms, etc.
7914 (single_display_spec_string_p): Support property values that are
7915 lists with the argument STRING its top-level element.
7916 (display_prop_string_p): Fix the condition for processing a
7917 property that is a list to be consistent with handle_display_spec.
7918 (handle_display_spec): New function, refactored from the
7919 last portion of handle_display_prop.
7920 (compute_display_string_pos): Accept additional argument
7921 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7922 value of a `display' property is a "replacing spec".
7923 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7924 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7925 the display property, but just return a value indicating whether
7926 the display property will replace the characters it covers.
7927 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7928 frame_window_p members of struct bidi_it.
7929 (compute_display_string_pos, compute_display_string_end):
7931 (push_it): Accept second argument POSITION, where pop_it should
7932 jump to continue iteration.
7933 (reseat_1): Initialize bidi_it.disp_pos.
7935 * keyboard.c (adjust_point_for_property): Adjust the call to
7936 display_prop_intangible_p to its new signature.
7938 * dispextern.h (struct bidi_it): New member frame_window_p.
7939 (bidi_init_it): Update prototypes.
7940 (display_prop_intangible_p): Update prototype.
7941 (compute_display_string_pos, compute_display_string_end):
7943 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7946 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7948 Malloc failure behavior now depends on size of allocation.
7949 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7950 * lisp.h: Change signatures accordingly.
7951 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7952 All callers changed. (Bug#8762)
7954 * gnutls.c: Use Emacs's memory allocators.
7955 Without this change, the gnutls library would invoke malloc etc.
7956 directly, which causes problems on non-SYNC_INPUT hosts, and which
7957 runs afoul of improving memory_full behavior. (Bug#8761)
7958 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7959 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7960 xfree instead of the default malloc, realloc, free.
7961 (Fgnutls_boot): No need to check for memory allocation failure,
7962 since xmalloc does that for us.
7964 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7965 * category.c (hash_get_category_set):
7966 * ccl.c (ccl_driver):
7967 * charset.c (Fdefine_charset_internal):
7968 * charset.h (struct charset.hash_index):
7969 * composite.c (get_composition_id, gstring_lookup_cache)
7970 (composition_gstring_put_cache):
7971 * composite.h (struct composition.hash_index):
7972 * dispextern.h (struct image.hash):
7973 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7974 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7975 (hashfn_equal, hashfn_user_defined, make_hash_table)
7976 (maybe_resize_hash_table, hash_lookup, hash_put)
7977 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7978 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7979 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7980 * image.c (make_image, search_image_cache, lookup_image)
7981 (xpm_put_color_table_h):
7982 * lisp.h (struct Lisp_Hash_Table):
7983 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7984 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7985 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7986 * alloc.c (allocate_vectorlike):
7987 Check for overflow in vector size calculations.
7988 * ccl.c (ccl_driver):
7989 Check for overflow when converting EMACS_INT to int.
7990 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7991 need to be updated by these changes.
7992 * fns.c (make_hash_table, maybe_resize_hash_table):
7993 Check for integer overflow with large hash tables.
7994 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7995 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7996 (SXHASH_REDUCE): New macro.
7997 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7998 Use it instead of discarding useful hash info with large hash values.
7999 (sxhash_float): New function.
8000 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8001 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8002 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8003 Rewrite to use FIXNUM_BITS, as this simplifies things.
8004 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8005 Adjust signatures to match updated version of code.
8006 (consing_since_gc): Now EMACS_INT, since a single hash table can
8007 use more than INT_MAX bytes.
8009 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8011 Make it possible to build with GCC-4.6+ -O2 -flto.
8013 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8015 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8017 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8018 Call minibuffer-inactive-mode.
8020 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8022 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8023 Update dependencies.
8025 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8027 * data.c (init_data): Remove code for UTS, this system is not
8030 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8032 Don't force ./temacs to start in terminal mode.
8034 * frame.c (make_initial_frame): Initialize faces in all cases, not
8035 only when CANNOT_DUMP is defined.
8036 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8038 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8040 * dispnew.c (add_window_display_history): Use const for the string
8041 pointer. Remove declaration, not needed.
8043 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8045 Use 'inline', not 'INLINE'.
8046 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8047 * alloc.c, fontset.c (INLINE): Remove.
8048 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8049 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8050 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8051 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8052 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8054 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8056 Make it possible to run ./temacs.
8058 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8059 syms_of_callproc does the same thing. Remove test for
8060 "initialized", do it in the caller.
8061 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8063 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8065 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8066 (read_minibuf): Use get_minibuffer.
8067 (syms_of_minibuf): Use DEFSYM.
8068 (Qmetadata): New var.
8069 * data.c (Qbuffer): Don't make it static.
8070 (syms_of_data): Use DEFSYM.
8072 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8074 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8075 (CCL_CODE_MIN): New macro.
8077 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8079 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8081 * eval.c (Qdebug): Now static.
8082 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8083 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8084 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8086 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8088 * image.c: Various fixes to ImageMagick code comments.
8089 (Fimagemagick_types): Doc fix.
8091 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8093 Minor fixes prompted by GCC 4.6.0 warnings.
8095 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8097 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8098 (x_clipboard_manager_save_all): Move extern decl to ...
8099 * xterm.h: ... here, so that it can be checked for consistency.
8101 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8103 * xselect.c (x_clipboard_manager_save_frame)
8104 (x_clipboard_manager_save_all): New functions.
8105 (Fx_clipboard_manager_save): Lisp function deleted.
8107 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8108 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8110 * xterm.h: Update prototype.
8112 2011-05-28 William Xu <william.xwl@gmail.com>
8114 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8117 2011-05-28 Jim Meyering <meyering@redhat.com>
8119 Avoid a sign-extension bug in crypto_hash_function.
8120 * fns.c (to_uchar): Define.
8121 (crypto_hash_function): Use it to convert some newly-signed
8122 variables to unsigned, to avoid sign-extension bugs. For example,
8123 without this change, (md5 "truc") would evaluate to
8124 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8125 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8126 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8128 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8130 Integer overflow fixes.
8132 * dbusbind.c: Serial number integer overflow fixes.
8133 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8134 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8135 to hold a serial number that is too large for a fixnum.
8136 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8137 Check for serial numbers out of range. Decode any serial number
8138 that was so large that it became a float. (Bug#8722)
8140 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8141 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8142 Use XFASTINT rather than XUINT when numbers are nonnegative.
8143 (xd_append_arg, Fdbus_method_return_internal):
8144 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8145 arguments, check that Lisp number is nonnegative, rather than
8146 silently wrapping negative numbers around. (Bug#8722)
8147 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8150 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8152 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8154 ccl: Add integer overflow checks.
8155 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8156 (IN_INT_RANGE): New macros.
8157 (ccl_driver): Use them to check for integer overflow when
8158 decoding a CCL program. Many of the new checks are whether XINT (x)
8159 fits in int; it doesn't always, on 64-bit hosts. The new version
8160 doesn't catch all possible integer overflows, but it's an
8161 improvement. (Bug#8719)
8163 * alloc.c (make_event_array): Use XINT, not XUINT.
8164 There's no need for unsigned here.
8166 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8167 This follows up to the 2011-05-06 change that substituted uintptr_t
8168 for EMACS_INT. This case wasn't caught back then.
8170 Rework Fformat to avoid integer overflow issues.
8171 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8172 now (part of C89). Include <verify.h>.
8173 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8174 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8175 (Fformat): Avoid the prepass trying to compute sizes; it was only
8176 approximate and thus did not catch overflow reliably. Instead, walk
8177 through the format just once, formatting and computing sizes as we go,
8178 checking for integer overflow at every step, and allocating a larger
8179 buffer as needed. Keep track separately whether the format is
8180 multibyte. Keep only the most-recently calculated precision, rather
8181 than them all. Record whether each argument has been converted to
8182 string. Use EMACS_INT, not int, for byte and char and arg counts.
8183 Support field widths and precisions larger than INT_MAX. Avoid
8184 sprintf's undefined behavior with conversion specifications such as %#d
8185 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8186 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8187 formatting out-of-range floating point numbers with int
8190 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8192 * data.c: Avoid integer truncation in expressions involving floats.
8193 * data.c: Include <intprops.h>.
8194 (arith_driver): When there's an integer overflow in an expression
8195 involving floating point, convert the integers to floating point
8196 so that the resulting value does not suffer from catastrophic
8197 integer truncation. For example, on a 64-bit host (* 4
8198 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8199 Do not rely on undefined behavior after integer overflow.
8201 merge count_size_as_multibyte, parse_str_to_multibyte
8202 * character.c, character.h (count_size_as_multibyte):
8203 Rename from parse_str_to_multibyte; all uses changed.
8204 Check for integer overflow.
8205 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8206 since it's now a duplicate of the other. This is more of
8207 a character than a buffer op, so better that it's in character.c.
8208 * fns.c, print.c: Adjust to above changes.
8210 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8212 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8214 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8216 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8217 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8218 (x_clipboard_manager_save): Now static.
8219 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8221 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8222 (crypto_hash_function): Now static.
8223 Fix pointer signedness problems. Avoid unnecessary initializations.
8225 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8227 * termhooks.h (Vselection_alist): Make it terminal-local.
8229 * terminal.c (create_terminal): Initialize it.
8231 * xselect.c: Support for clipboard managers.
8232 (Vselection_alist): Move to termhooks.h as terminal-local var.
8233 (LOCAL_SELECTION): New macro.
8234 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8235 (symbol_to_x_atom): Remove gratuitous arg.
8236 (x_handle_selection_request, lisp_data_to_selection_data)
8237 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8238 (x_own_selection, x_get_local_selection, x_convert_selection):
8239 New arg, specifying work frame. Use terminal-local Vselection_alist.
8240 (some_frame_on_display): Delete unused function.
8241 (Fx_own_selection_internal, Fx_get_selection_internal)
8242 (Fx_disown_selection_internal, Fx_selection_owner_p)
8243 (Fx_selection_exists_p): New optional frame arg.
8244 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8245 (x_handle_selection_clear): Don't treat other terminals with the
8246 same keyboard specially. Use the terminal-local Vselection_alist.
8247 (x_clear_frame_selections): Use Frun_hook_with_args.
8249 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8251 * xterm.h: Add support for those atoms.
8253 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8255 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8256 (converted_selections, conversion_fail_tag): New global variables.
8257 (x_selection_request_lisp_error): Free the above.
8258 (x_get_local_selection): Remove unnecessary code.
8259 (x_reply_selection_request): Args changed; handle arbitrary array
8260 of converted selections stored in converted_selections.
8261 Separate the XChangeProperty and SelectionNotify steps.
8262 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8263 (x_convert_selection): New function.
8264 (x_handle_selection_event): Simplify.
8265 (x_get_foreign_selection): Don't ignore incoming requests while
8266 waiting for an answer; this will fail when we implement
8267 SAVE_TARGETS, and seems unnecessary anyway.
8268 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8269 (Vx_sent_selection_functions): Doc fix.
8271 2011-05-26 Leo Liu <sdl.web@gmail.com>
8273 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8275 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8277 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8279 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8280 for fringe update if it has periodic bitmap.
8281 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8282 and fringe_bitmap_periodic_p.
8284 * fringe.c (get_fringe_bitmap_data): New function.
8285 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8286 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8287 row. Mark glyph row for fringe update if periodicity changed.
8289 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8290 for fringe update unless it has periodic bitmap.
8292 2011-05-25 Kenichi Handa <handa@m17n.org>
8294 * xdisp.c (get_next_display_element): Set correct it->face_id for
8295 a static composition.
8297 2011-05-24 Leo Liu <sdl.web@gmail.com>
8300 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8302 * fns.c (crypto_hash_function, Fsha1): New function.
8303 (Fmd5): Use crypto_hash_function.
8304 (syms_of_fns): Add Ssha1.
8306 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8308 * gnutls.c: Remove unused macros.
8309 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8310 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8311 Remove macros that are defined and never used.
8312 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8314 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8316 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8317 (Fx_get_selection_internal): Minor cleanup.
8318 (Fx_own_selection_internal): Rename arguments for consistency with
8321 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8323 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8325 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8327 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8329 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8331 * dispnew.c (scrolling_window): Don't exclude the case that the
8332 last enabled row in the desired matrix touches the bottom boundary.
8334 2011-05-21 Glenn Morris <rgm@gnu.org>
8336 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8337 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8338 and add some more files.
8340 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8342 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8343 report_file_error introduced by the change from 2011-05-07.
8345 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8347 * systime.h (Time): Define only if emacs is defined.
8348 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8349 where the include path doesn't have X11/X.h by default. See
8350 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8352 2011-05-20 Kenichi Handa <handa@m17n.org>
8354 * composite.c (find_automatic_composition): Fix previous change.
8356 2011-05-20 Glenn Morris <rgm@gnu.org>
8358 * lisp.mk: New file, split from Makefile.in.
8359 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8360 (shortlisp): Remove.
8361 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8363 2011-05-19 Glenn Morris <rgm@gnu.org>
8365 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8366 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8367 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8368 (lisp): Set the order to that of loadup.el.
8369 (shortlisp): Make it a copy of $lisp.
8370 (SOME_MACHINE_LISP): Remove.
8371 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8372 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8374 2011-05-18 Kenichi Handa <handa@m17n.org>
8376 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8377 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8378 (find_automatic_composition): Mostly rewrite for efficiency.
8380 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8382 * makefile.w32-in: Update dependencies.
8384 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8386 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8387 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8389 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8391 Fix some integer overflow issues, such as string length overflow.
8393 * insdel.c (count_size_as_multibyte): Check for string overflow.
8395 * character.c (lisp_string_width): Check for string overflow.
8396 Use EMACS_INT, not int, for string indexes and lengths; in
8397 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8398 the resulting string length overflows an EMACS_INT; instead,
8399 report a string overflow if no precision given. When checking for
8400 precision exhaustion, use a check that cannot possibly have
8401 integer overflow. (Bug#8675)
8402 * character.h (lisp_string_width): Adjust to new signature.
8404 * alloc.c (string_overflow): New function.
8405 (Fmake_string): Use it. This doesn't change behavior, but saves
8406 a few bytes and will simplify future changes.
8407 * character.c (string_escape_byte8): Likewise.
8408 * lisp.h (string_overflow): New decl.
8410 Fixups, following up to the user-interface timestamp change.
8411 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8412 for UI timestamps, instead of unsigned long.
8413 * msdos.c (mouse_get_pos): Likewise.
8414 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8415 * w32gui.h (Time): Define by including "systime.h" rather than by
8416 declaring it ourselves. (Bug#8664)
8418 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8419 * image.c (clear_image_cache): Likewise.
8421 * term.c (term_mouse_position): Don't assume time_t wraparound.
8423 Be more systematic about user-interface timestamps.
8424 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8425 and sometimes 'EMACS_UINT', to represent these timestamps.
8426 This change causes it to use 'Time' uniformly, as that's what X uses.
8427 This makes the code easier to follow, and makes it easier to catch
8428 integer overflow bugs such as Bug#8664.
8429 * frame.c (Fmouse_position, Fmouse_pixel_position):
8430 Use Time, not unsigned long, for user-interface timestamps.
8431 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8432 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8433 * keyboard.h (last_event_timestamp): Likewise.
8434 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8435 * menu.h (xmenu_show): Likewise.
8436 * term.c (term_mouse_position): Likewise.
8437 * termhooks.h (struct input_event.timestamp): Likewise.
8438 (struct terminal.mouse_position_hook): Likewise.
8439 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8440 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8441 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8442 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8444 * menu.h, termhooks.h: Include "systime.h", for Time.
8446 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8447 Don't assume that the difference between two unsigned long values
8448 can fit into an integer. At this point, we know button_down_time
8449 <= event->timestamp, so the difference must be nonnegative, so
8450 there's no need to cast the result if double-click-time is
8451 nonnegative, as it should be; check that it's nonnegative, just in
8452 case. This bug is triggered when events are more than 2**31 ms
8453 apart (about 25 days). (Bug#8664)
8455 * xselect.c (last_event_timestamp): Remove duplicate decl.
8456 (x_own_selection): Remove needless cast to unsigned long.
8458 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8459 that always fit in int. Use a sentinel instead of a counter, to
8460 avoid a temp and to allay GCC's concerns about possible int overflow.
8461 * frame.h (struct frame): Use int for menu_bar_items_used
8462 instead of EMACS_INT, since it always fits in int.
8464 * menu.c (grow_menu_items): Check for int overflow.
8466 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8468 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8469 Before, the code was not consistent. These values cannot exceed
8470 2**31 - 1 so there's no need to make them unsigned.
8471 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8472 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8473 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8475 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8477 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8478 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8479 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8480 presumably because the widths might not match.
8482 * window.c (size_window): Avoid needless test at loop start.
8484 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8486 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8488 2011-05-12 Drew Adams <drew.adams@oracle.com>
8490 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8492 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8494 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8495 `width' to `bar_area_x' and `bar_area_width', respectively.
8496 (x_scroll_run): Take account of fringe background extension.
8498 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8499 Rename local vars `left' and `width' to `bar_area_x' and
8500 `bar_area_width', respectively.
8501 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8502 background extension.
8504 2011-05-10 Jim Meyering <meyering@redhat.com>
8506 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8508 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8510 * image.c (Finit_image_library): Return t for built-in image types,
8511 like pbm and xbm. (Bug#8640)
8513 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8515 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8517 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8519 * w32console.c (Fset_screen_color): Doc fix.
8520 (Fget_screen_color): New function.
8521 (syms_of_ntterm): Defsubr it.
8523 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8524 unlink the temporary file if Fcall_process didn't create it in the
8526 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8527 child process will be redirected to a file specified with `:file'.
8528 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8529 cue to call_process_cleanup not to close that handle.
8531 2011-05-07 Ben Key <bkey76@gmail.com>
8533 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8534 one of two shell specific rules, either bootstrap-temacs-CMD or
8535 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8536 to the previous implementation of the bootstrap-temacs rule.
8537 The bootstrap-temacs-CMD rule is similar to the previous
8538 implementation of the bootstrap-temacs rule except that it
8539 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8542 These changes, along with some changes to nt/configure.bat,
8543 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8544 earlier fix to add support for --cflags and --ldflags options
8545 that include quotes so that it works whether make uses cmd or
8548 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8550 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8551 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8553 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8554 a string. Handle both cases.
8555 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8556 (Fdbus_register_method): Use Qinvalid_function.
8558 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8560 * makefile.w32-in: Update dependencies.
8561 (LISP_H): Add inttypes.h and stdin.h.
8562 (PROCESS_H): Add unistd.h.
8564 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8566 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8567 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8569 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8571 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8573 * term.c (vfatal): Remove stray call to va_end.
8574 It's not needed and the C Standard doesn't allow it here anyway.
8576 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8577 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8579 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8582 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8584 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8586 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8588 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8590 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8592 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8593 * charset.c (Fdefine_charset_internal): Don't initialize
8594 charset.code_space[15]. The value was garbage, on hosts with
8595 32-bit int (Bug#8600).
8597 * lread.c (read_integer): Be more consistent with string-to-number.
8598 Use string_to_number to do the actual conversion; this avoids
8599 rounding errors and fixes some other screwups. Without this fix,
8600 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8601 (digit_to_number): Move earlier, for benefit of read_integer.
8602 Return -1 if the digit is out of range for the base, -2 if it is
8603 not a digit in any supported base. (Bug#8602)
8605 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8607 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8608 to match comment at start of function. This also removes a
8609 GCC warning about overflow in a 32+64-bit port.
8611 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8613 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8614 Reported by Stefan Monnier in
8615 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8616 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8617 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8619 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8620 (EMACS_UINTPTR): Likewise, with uintptr_t.
8622 * lisp.h: Prefer 64-bit EMACS_INT if available.
8623 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8624 on 32-bit hosts that have 64-bit int, so that they can access
8626 However, temporarily disable this change unless the temporary
8627 symbol WIDE_EMACS_INT is defined.
8629 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8631 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8632 This removes an assumption that EMACS_INT and long are the same
8633 width as pointers. The assumption is true for Emacs porting targets
8634 now, but we want to make other targets possible.
8635 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8636 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8637 In the rest of the code, change types of integers that hold casted
8638 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8639 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8640 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8641 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8642 No need to cast type when ORing.
8643 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8644 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8645 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8646 assume EMACS_INT is the same width as char *.
8647 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8648 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8649 Remove no-longer-needed casts.
8650 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8651 (xg_tool_bar_help_callback, xg_make_tool_item):
8652 Use EMACS_INTPTR to hold an integer
8653 that will be cast to void *; this can avoid a GCC warning
8654 if EMACS_INT is not the same width as void *.
8655 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8656 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8657 (current_message_1, set_message_1):
8658 Use a local to convert to proper width without a cast.
8659 * xmenu.c (dialog_selection_callback): Likewise.
8661 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8662 Also, don't assume VALBITS / RAND_BITS is less than 5,
8663 and don't rely on undefined behavior when shifting a 1 left into
8665 * lisp.h (get_random): Change signature to match.
8667 * lread.c (hash_string): Use size_t, not int, for hash computation.
8668 Normally we prefer signed values; but hashing is special, because
8669 it's better to use unsigned division on hash table sizes so that
8670 the remainder is nonnegative. Also, size_t is the natural width
8671 for hashing into memory. The previous code used 'int', which doesn't
8672 retain enough info to hash well into very large tables.
8673 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8675 * dbusbind.c: Don't possibly lose pointer info when converting.
8676 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8677 Use XPNTR rather than XHASH, so that the high-order bits of
8678 the pointer aren't lost when converting through void *.
8680 * eval.c (Fautoload): Don't double-shift a pointer.
8682 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8684 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8686 * gnutls.c (DEF_GNUTLS_FN):
8687 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8689 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8691 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8694 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8696 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8697 New version that can reserve upto 2GB of heap space.
8699 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8701 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8703 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8705 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8706 `gnutls_certificate_set_x509_key_file'.
8708 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8710 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8711 Update dependencies.
8713 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8715 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8716 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8717 Remove unused parameter `fildes'.
8718 * process.c (read_process_output, send_process): Don't pass it.
8720 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8722 Fix previous change: the library cache is defined in w32.c.
8723 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8724 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8726 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8728 Implement dynamic loading of GnuTLS on Windows.
8730 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8731 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8732 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8735 * gnutls.c (Qgnutls_dll): Define.
8736 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8737 (gnutls_*): Declare function pointers.
8738 (init_gnutls_functions): New function to initialize function pointers.
8739 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8740 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8741 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8742 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8743 (emacs_gnutls_write, emacs_gnutls_read)
8744 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8745 (Fgnutls_available_p): New function.
8746 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8747 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8748 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8750 * image.c: Include w32.h.
8751 (Vimage_type_cache): Delete.
8752 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8753 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8754 (w32_delayed_load): Move to w32.c.
8756 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8758 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8759 (w32_delayed_load): Move from image.c. When loading a library, record
8760 its filename in the :loaded-from property of the library id.
8761 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8762 Initialize and staticpro them.
8763 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8765 * process.c: Include lisp.h before w32.h, not after.
8766 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8767 instead of gnutls_record_check_pending.
8769 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8771 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8773 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8774 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8777 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8779 * xterm.c (x_set_frame_alpha): Do not set property on anything
8780 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8782 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8784 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8786 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8788 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8789 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8790 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8791 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8792 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8793 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8794 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8795 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8796 (Qgnutls_bootprop_callbacks_verify): Make static.
8798 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8800 * callproc.c: Indentation fixup.
8802 * sysdep.c (wait_for_termination_1): Make static.
8803 (wait_for_termination, interruptible_wait_for_termination):
8804 Move after wait_for_termination_1.
8806 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8808 * sysdep.c (interruptible_wait_for_termination): New function
8809 which is like wait_for_termination, but allows keyboard
8812 * callproc.c (Fcall_process): Add (:file "file") as an option for
8814 (Fcall_process_region): Ditto.
8816 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8818 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8819 rather than `XVECTOR (FOO)->size'.
8821 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8822 inttypes.h, as a gnulib replacement is used if it not available in
8825 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8827 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8828 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8829 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8831 * coding.c (coding_alloc_by_realloc): Error out if destination
8832 will grow beyond MOST_POSITIVE_FIXNUM.
8833 (decode_coding_emacs_mule): Abort if there isn't enough place in
8834 charbuf for the composition carryover bytes. Reserve an extra
8835 space for up to 2 characters produced in a loop.
8836 (decode_coding_iso_2022): Abort if there isn't enough place in
8837 charbuf for the composition carryover bytes.
8839 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8841 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8842 aborting when %lld or %lll format is passed.
8843 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8844 %llo or %llx format is passed. (Bug#8545)
8846 * window.c (window_scroll_line_based): Use a marker instead of
8847 simple variables to record original value of point. (Bug#7952)
8849 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8850 produced by %s or %c overflows available buffer space. (Bug#8545)
8852 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8854 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8855 (SIZE_MAX): Move defn after all includes, as they might #define it.
8857 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8859 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8861 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8863 * keyboard.c (Qdelayed_warnings_hook): Define.
8864 (command_loop_1): Run `delayed-warnings-hook'
8865 if Vdelayed_warnings_list is non-nil.
8866 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8867 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8869 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8871 * doprnt.c (doprnt): Don't return value smaller than the buffer
8872 size if the message was truncated. (Bug#8545).
8874 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8876 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8877 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8879 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8881 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8883 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8885 * makefile.w32-in: Update dependencies.
8887 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8889 Improve `doprnt' and its usage. (Bug#8545)
8890 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8891 `format_end'. Remove support for %l as a conversion specifier.
8892 Don't use xrealloc. Improve diagnostics when the %l size modifier
8893 is used. Update the commentary.
8895 * eval.c (verror): Simplify calculation of size_t.
8897 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8900 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8902 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8905 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8907 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8908 This makes this file independent of the recent pseudovector change.
8910 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8912 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8914 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8915 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8916 Remove unused local.
8917 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8919 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8920 GCC 4.6.0 optimizes based on type-based alias analysis.
8921 For example, if b is of type struct buffer * and v of type struct
8922 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8923 != &v->size, and therefore "v->size = 1; b->size = 2; return
8924 v->size;" must therefore return 1. This assumption is incorrect
8925 for Emacs, since it type-puns struct Lisp_Vector * with many other
8926 types. To fix this problem, this patch adds a new type struct
8927 vectorlike_header that documents the constraints on layout of vectors
8928 and pseudovectors, and helps optimizing compilers not get fooled
8929 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8930 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8931 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8933 (XSETPVECTYPE): Rewrite in terms of new macro.
8934 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8935 This is a bit clearer, and further avoids the possibility of
8936 undesirable aliasing.
8937 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8938 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8939 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8940 since Lisp_Subr is a special case (no "next" field).
8941 (ASIZE): Now uses header.size rather than size.
8942 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8943 to avoid the hassle of writing XVECTOR (foo)->header.size.
8944 (struct vectorlike_header): New type.
8945 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8946 object, to help avoid aliasing.
8947 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8948 (SUBRP): Likewise, since Lisp_Subr is a special case.
8949 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8950 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8951 (struct Lisp_Hash_Table): Combine first two members into a single
8952 struct vectorlike_header member. All uses of "size" and "next" members
8953 changed to be "header.size" and "header.next".
8954 * buffer.h (struct buffer): Likewise.
8955 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8956 * frame.h (struct frame): Likewise.
8957 * process.h (struct Lisp_Process): Likewise.
8958 * termhooks.h (struct terminal): Likewise.
8959 * window.c (struct save_window_data, struct saved_window): Likewise.
8960 * window.h (struct window): Likewise.
8961 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8962 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8963 * buffer.c (init_buffer_once): Likewise.
8964 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8966 * process.c (Fformat_network_address): Use local var for size,
8969 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8971 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8972 * data.c (atof): Remove decl; no longer used or needed.
8973 (digit_to_number): Move to lread.c.
8974 (Fstring_to_number): Use new string_to_number function, to be
8975 consistent with how the Lisp reader treats infinities and NaNs.
8976 Do not assume that floating-point numbers represent EMACS_INT
8977 without losing information; this is not true on most 64-bit hosts.
8978 Avoid double-rounding errors, by insisting on integers when
8979 parsing non-base-10 numbers, as the documentation specifies.
8980 * lisp.h (string_to_number): New decl, replacing ...
8981 (isfloat_string): Remove.
8982 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8983 (read1): Do not accept +. and -. as integers; this
8984 appears to have been a coding error. Similarly, do not accept
8985 strings like +-1e0 as floating point numbers. Do not report
8986 overflow for integer overflows unless the base is not 10 which
8987 means we have no simple and reliable way to continue.
8988 Break out the floating-point parsing into a new
8989 function string_to_number, so that Fstring_to_number parses
8990 floating point numbers consistently with the Lisp reader.
8991 (digit_to_number): Move here from data.c. Make it static inline.
8992 (E_CHAR, EXP_INT): Remove, replacing with ...
8993 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8994 (string_to_number): New function, replacing isfloat_string.
8995 This function checks for valid syntax and produces the resulting
8996 Lisp float number too. Rework it so that string-to-number
8997 no longer mishandles examples like "1.0e+". Use strtoumax,
8998 so that overflow for non-base-10 numbers is reported only when
8999 there's no portable and simple way to convert to floating point.
9001 * textprop.c (set_text_properties_1): Rewrite for clarity,
9002 and to avoid GCC warning about integer overflow.
9004 * intervals.h (struct interval): Use EMACS_INT for members
9005 where EMACS_UINT might cause problems. See
9006 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9007 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9008 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9010 (offset_intervals): Tell GCC not to worry about length overflow
9011 when negating a negative length.
9013 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9014 (overrun_check_free): Likewise.
9016 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9017 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9020 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9021 (gnutls_make_error): Rename local to avoid shadowing.
9022 (gnutls_emacs_global_deinit): ifdef out; not used.
9023 (Fgnutls_boot): Use const for pointer to readonly storage.
9024 Comment out unused local. Fix pointer signedness problems.
9026 * lread.c (openp): Don't stuff size_t into an 'int'.
9027 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9028 about possible signed overflow.
9030 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9031 (GDK_KEY_g): Don't define if already defined.
9032 (xg_prepare_tooltip): Avoid pointer signedness problem.
9033 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9035 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9036 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9038 * xfns.c (Fx_window_property): Simplify a bit,
9039 to make a bit faster and to avoid GCC 4.6.0 warning.
9040 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9042 * fns.c (internal_equal): Don't assume size_t fits in int.
9044 * alloc.c (compact_small_strings): Tighten assertion a little.
9046 Replace pEd with more-general pI, and fix some printf arg casts.
9047 * lisp.h (pI): New macro, generalizing old pEd macro to other
9048 conversion specifiers. For example, use "...%"pI"d..." rather
9049 than "...%"pEd"...".
9050 (pEd): Remove. All uses replaced with similar uses of pI.
9051 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9052 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9053 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9054 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9055 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9056 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9057 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9059 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9060 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9061 * print.c (safe_debug_print, print_object): Likewise.
9062 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9064 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9065 avoiding the 0 flag, which is not portable.
9066 * process.c (Fmake_network_process): Use pI to avoid cast.
9067 * region-cache.c (pp_cache): Likewise.
9068 * xdisp.c (decode_mode_spec): Likewise.
9069 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9070 behavior on 64-bit hosts with printf arg.
9071 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9072 (x_stop_queuing_selection_requests): Likewise.
9073 (x_get_window_property): Don't truncate byte count to an 'int'
9076 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9077 here, since it parses constructs like leading '-' and spaces,
9078 which are not wanted; and it overflows with large numbers.
9079 Instead, simply match F[0-9]+, which is what is wanted anyway.
9081 * alloc.c: Remove unportable assumptions about struct layout.
9082 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9083 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9084 (allocate_vectorlike, make_pure_vector): Use the new macros,
9085 plus offsetof, to remove unportable assumptions about struct layout.
9086 These assumptions hold on all porting targets that I know of, but
9087 they are not guaranteed, they're easy to remove, and removing them
9088 makes further changes easier.
9090 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9091 This doesn't fix a bug but makes the code clearer.
9092 (string_overrun_cookie): Now const. Use initializers that
9093 don't formally overflow signed char, to avoid warnings.
9094 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9095 can cause Emacs to crash when string overrun checking is enabled.
9096 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9097 multiple of sizeof (EMACS_INT); it need not be, if
9098 alignof(EMACS_INT) < sizeof (EMACS_INT).
9099 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9101 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9103 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9105 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9107 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9108 supposed to be handshaking. (Bug#8556)
9109 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9111 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9113 * lisp.h (Qdebug): List symbol.
9114 * eval.c (Qdebug): Restore global linkage.
9115 * keyboard.c (debug-on-event): New variable.
9116 (handle_user_signal): Break into debugger when debug-on-event
9117 matches the current signal symbol.
9119 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9121 * alloc.c (check_sblock, check_string_bytes)
9122 (check_string_free_list): Convert to standard C.
9124 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9126 * w32.c (emacs_gnutls_push): Fix typo.
9128 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9130 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9131 "cast to pointer from integer of different size".
9133 Improve doprnt and its use in verror. (Bug#8545)
9134 * doprnt.c (doprnt): Document the set of format control sequences
9135 supported by the function. Use SAFE_ALLOCA instead of always
9138 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9139 is one byte too soon. Don't use xrealloc; instead xfree and
9142 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9144 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9147 * gnutls.c: Renamed global_initialized to
9148 gnutls_global_initialized. Added internals for the
9149 :verify-hostname-error, :verify-error, and :verify-flags
9150 parameters of `gnutls-boot' and documented those parameters in the
9151 docstring. Start callback support.
9152 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9153 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9154 on error. Return error code.
9155 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9156 (emacs_gnutls_read): Likewise.
9157 (Fgnutls_boot): Return handshake error code.
9158 (emacs_gnutls_handle_error): New function.
9159 (wsaerror_to_errno): Likewise.
9161 * w32.h (emacs_gnutls_pull): Add prototype.
9162 (emacs_gnutls_push): Likewise.
9164 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9165 (emacs_gnutls_push): Likewise.
9167 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9169 * process.c (wait_reading_process_output): Check if GnuTLS
9170 buffered some data internally if no FDs are set for TLS
9173 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9174 (LIBS): Link to USER_LIBS.
9175 ($(BLD)/gnutls.$(0)): New target.
9177 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9179 * xdisp.c (handle_single_display_spec): Rename the
9180 display_replaced_before_p argument into display_replaced_p, to
9181 make it consistent with the commentary. Fix typos in the
9184 * textprop.c (syms_of_textprop): Remove dead code.
9185 (copy_text_properties): Delete obsolete commentary about an
9186 interface that was deleted long ago. Fix typos in the description
9189 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9190 to changes in oldXMenu/XMenu.h from 2011-04-16.
9191 <menu_help_message, prev_menu_help_message>: Constify.
9192 (IT_menu_make_room): menu->help_text is now `const char **';
9195 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9196 to changes in oldXMenu/XMenu.h from 2011-04-16.
9197 (struct XMenu): Declare `help_text' `const char **'.
9199 * xfaces.c <Qunspecified>: Make extern again.
9201 * syntax.c: Include sys/types.h before including regex.h, as
9204 * doc.c (get_doc_string): Improve the format passed to `error'.
9206 * doprnt.c (doprnt): Improve commentary.
9208 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9210 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9213 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9214 changes in globals.h immediately force recompilation.
9215 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9216 $(CURDIR)/s/ms-w32.h.
9217 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9219 * character.c (Fchar_direction): Function deleted.
9220 (syms_of_character): Don't defsubr it.
9221 <char-direction-table>: Deleted.
9223 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9225 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9226 * doprnt.c: Include limits.h.
9227 (SIZE_MAX): New macro.
9228 (doprnt): Return a size_t value. 2nd arg is now size_t.
9229 Many local variables are now size_t instead of int or unsigned.
9230 Improve overflow protection. Support `l' modifier for integer
9231 conversions. Support %l conversion. Don't assume an EMACS_INT
9232 argument for integer conversions and for %c.
9234 * lisp.h (doprnt): Restore prototype.
9236 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9239 * Makefile.in (base_obj): Add back doprnt.o.
9241 * deps.mk (doprnt.o): Add back prerequisites.
9242 (callint.o): Depend on character.h.
9244 * eval.c (internal_lisp_condition_case): Include the handler
9245 representation in the error message.
9246 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9247 when breaking from the loop.
9249 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9251 * callint.c (Fcall_interactively): When displaying error message
9252 about invalid control letter, pass the character's codepoint, not
9253 a pointer to its multibyte form. Improve display of the character
9254 in octal and display also its hex code.
9256 * character.c (char_string): Use %x to display the (unsigned)
9257 codepoint of an invalid character, to avoid displaying a bogus
9260 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9261 `error', not SYMBOL_NAME itself.
9263 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9264 character arguments to `error'.
9266 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9267 to `error' in error message about FINAL_CHAR argument. Make sure
9268 FINAL_CHAR is a character, and use %c when it is passed as
9269 argument to `error'.
9271 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9273 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9275 * w32.c: Include <time.h>.
9276 (sys_localtime): New function.
9278 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9280 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9282 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9284 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9286 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9289 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9291 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9292 gl_state.e_property when gl_state.object is Qt.
9294 * insdel.c (make_gap_larger): Remove limitation of buffer size
9297 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9299 * xdisp.c (lookup_glyphless_char_display)
9300 (produce_glyphless_glyph): Handle cons cell entry in
9301 glyphless-char-display.
9302 (Vglyphless_char_display): Document it.
9304 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9305 glyphless-char-display.
9307 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9309 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9311 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9313 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9314 definition for no-X builds.
9316 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9318 Static checks with GCC 4.6.0 and non-default toolkits.
9320 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9322 * process.c (keyboard_bit_set): Define only if SIGIO.
9323 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9324 (send_process): Repair possible setjmp clobbering.
9326 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9328 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9330 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9332 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9333 Define only if needed.
9335 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9336 by pacifying GCC about it. Maybe it's time to retire it?
9337 * xfaces.c (USG, __TIMEVAL__): Likewise.
9339 * dispextern.h (struct redisplay_interface): Rename param
9341 * termhooks.h (struct terminal): Likewise.
9342 * xterm.c (xembed_send_message): Likewise.
9344 * insdel.c (make_gap_smaller): Define only if
9345 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9347 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9350 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9351 so that we aren't warned about unused symbols.
9353 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9355 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9357 * xfns.c (x_real_positions): Mark locals as initialized.
9359 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9361 * xterm.c: Fix problems found by static analysis with other toolkits.
9362 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9363 (x_dispatch_event): Declare static if USE_GTK, and
9364 define if USE_GTK || USE_X_TOOLKIT.
9365 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9366 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9367 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9368 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9370 * xmenu.c (menu_help_callback): Pointer type fixes.
9371 Use const pointers when pointing at readonly data. Avoid pointer
9373 (FALSE): Remove unused macro.
9374 (update_frame_menubar): Remove unused decl.
9376 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9378 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9379 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9380 (single_menu_item): Rename local to avoid shadowing.
9382 * keyboard.c (make_lispy_event): Remove unused local var.
9384 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9385 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9387 * bitmaps: Change bitmaps from unsigned char back to the X11
9388 compatible char. Avoid the old compiler warnings about
9389 out-of-range initializers by using, for example, '\xab' rather
9392 * xgselect.c (xgselect_initialize): Check vs interface
9393 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9395 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9397 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9398 to read-only memory.
9400 * fns.c (vector): Remove; this old hack is no longer needed.
9402 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9404 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9406 * xrdb.c (x_load_resources): Omit unused local.
9408 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9409 (x_window): Rename locals to avoid shadowing.
9410 (USG): Use the kludged USG macro, to pacify gcc.
9412 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9413 (x_term_init): Remove local to avoid shadowing.
9415 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9417 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9418 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9420 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9422 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9424 Fix regex.c, syntax.c and friends for buffers > 2GB.
9425 * syntax.h (struct gl_state_s): Declare character position members
9428 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9430 * textprop.c (verify_interval_modification, interval_of):
9431 Declare arguments EMACS_INT.
9433 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9436 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9438 * indent.c (Fvertical_motion): Local variable it_start is now
9441 * regex.c (re_match, re_match_2, re_match_2_internal)
9442 (bcmp_translate, regcomp, regexec, print_double_string)
9443 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9444 (re_compile_pattern, re_exec): Declare arguments and local
9445 variables `size_t' and `ssize_t' and return values `regoff_t', as
9447 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9448 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9449 <compile_stack_type>: `size' and `avail' are now `size_t'.
9451 * regex.h <regoff_t>: Use ssize_t, not int.
9452 (re_search, re_search_2, re_match, re_match_2): Arguments that
9453 specify buffer/string position and length are now ssize_t and
9454 size_t. Return type is regoff_t.
9456 2011-04-16 Ben Key <bkey76@gmail.com>
9458 * nsfont.m: Fixed bugs in ns_get_family and
9459 ns_descriptor_to_entity that were caused by using free to
9460 deallocate memory blocks that were allocated by xmalloc (via
9461 xstrdup). This caused Emacs to crash when compiled with
9462 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9463 --enable-checking=xmallocoverrun). xfree is now used to
9464 deallocate these memory blocks.
9466 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9468 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9470 emacs_write: Accept and return EMACS_INT for sizes.
9471 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9473 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9474 Accept and return EMACS_INT.
9475 (emacs_gnutls_write): Return the number of bytes written on
9477 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9478 (emacs_read, emacs_write): Remove check for negative size, as the
9479 Emacs source code has been audited now.
9480 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9481 (emacs_read, emacs_write): Use it.
9482 * process.c (send_process): Adjust to the new signatures of
9483 emacs_write and emacs_gnutls_write. Do not attempt to store
9484 a byte offset into an 'int'; it might overflow.
9485 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9487 * sound.c: Don't assume sizes fit in 'int'.
9488 (struct sound_device.period_size, alsa_period_size):
9489 Return EMACS_INT, not int.
9490 (struct sound_device.write, vox_write, alsa_write):
9491 Accept EMACS_INT, not int.
9492 (wav_play, au_play): Use EMACS_INT to store sizes and to
9493 record read return values.
9495 2011-04-15 Ben Key <bkey76@gmail.com>
9497 * keyboard.c (Qundefined): Don't declare static since it is used
9499 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9500 static since they are used in nsfont.m.
9502 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9504 * process.c (Qprocessp): Don't declare static.
9505 * lisp.h (Qprocessp): Declare again.
9507 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9509 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9511 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9513 Improve C-level modularity by making more things 'static'.
9515 Don't publish debugger-only interfaces to other modules.
9516 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9517 (verify_bytepos, count_markers): Move decls to the only modules
9519 * region-cache.h (pp_cache): Likewise.
9520 * window.h (check_all_windows): Likewise.
9521 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9523 * sysdep.c (croak): Now static, if
9524 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9525 * syssignal.h (croak): Declare only if not static.
9527 * alloc.c (refill_memory_reserve): Now static if
9528 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9529 * lisp.h (refill_memory_reserve): Declare only if not static.
9531 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9532 Define only if USE_LUCID.
9534 * xrdb.c (x_customization_string, x_rm_string): Now static.
9536 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9537 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9539 * xdisp.c (draw_row_with_mouse_face): Now static.
9540 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9542 * window.h (check_all_windows): Mark externally visible.
9544 * window.c (window_deletion_count): Now static.
9546 * undo.c: Make symbols static if they're not exported.
9547 (last_undo_buffer, last_boundary_position, pending_boundary):
9550 * textprop.c (interval_insert_behind_hooks): Now static.
9551 (interval_insert_in_front_hooks): Likewise.
9553 * term.c: Make symbols static if they're not exported.
9554 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9555 (max_frame_lines, tty_set_terminal_modes):
9556 (tty_reset_terminal_modes, tty_turn_off_highlight):
9557 (get_tty_terminal): Now static.
9558 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9559 * termhooks.h (term_mouse_moveto): Do not declare if
9561 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9562 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9564 * sysdep.c: Make symbols static if they're not exported.
9565 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9567 (sigprocmask_set, full_mask): Remove; unused.
9568 (wait_debugging): Mark as visible.
9569 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9570 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9572 * syntax.c (syntax_temp): Define only if !__GNUC__.
9574 * sound.c (current_sound_device, current_sound): Now static.
9576 * search.c (searchbufs, searchbuf_head): Now static.
9578 * scroll.c (scroll_cost): Remove; unused.
9579 * dispextern.h (scroll_cost): Remove decl.
9581 * region-cache.h (pp_cache): Mark as externally visible.
9583 * process.c: Make symbols static if they're not exported.
9584 (process_tick, update_tick, create_process, chan_process):
9585 (Vprocess_alist, proc_buffered_char, datagram_access):
9586 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9587 (deactivate_process): Mark defn as static, as well as decl.
9588 * lisp.h (create_process): Remove decl.
9589 * process.h (chan_process, Vprocess_alist): Remove decls.
9591 * print.c: Make symbols static if they're not exported.
9592 (print_depth, new_backquote_output, being_printed, print_buffer):
9593 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9594 (print_interval, print_number_index, initial_stderr_stream):
9596 * lisp.h (Fprinc): Remove decl.
9597 (debug_output_compilation_hack): Mark as externally visible.
9599 * sysdep.c (croak): Move decl from here to syssignal.h.
9600 * syssignal.h (croak): Put it here, so the API can be checked when
9601 'croak' is called from dissociate_if_controlling_tty.
9603 * minibuf.c: Make symbols static if they're not exported.
9604 (minibuf_save_list, choose_minibuf_frame): Now static.
9605 * lisp.h (choose_minibuf_frame): Remove decl.
9607 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9609 * lread.c: Make symbols static if they're not exported.
9610 (read_objects, initial_obarray, oblookup_last_bucket_number):
9612 (make_symbol): Remove; unused.
9613 * lisp.h (initial_obarray, make_symbol): Remove decls.
9615 * keyboard.c: Make symbols static if they're not exported.
9616 (single_kboard, recent_keys_index, total_keys, recent_keys):
9617 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9618 (this_single_command_key_start, echoing, last_auto_save):
9619 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9620 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9621 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9622 (Vlispy_mouse_stem, double_click_count):
9624 (force_auto_save_soon): Define only if SIGDANGER.
9625 (ignore_mouse_drag_p): Now static if
9626 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9627 (print_help): Remove; unused.
9628 (stop_character, last_timer_event): Mark as externally visible.
9629 * keyboard.h (ignore_mouse_drag_p): Declare only if
9630 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9631 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9632 * lisp.h (echoing): Remove decl.
9633 (force_auto_save_soon): Declare only if SIGDANGER.
9634 * xdisp.c (redisplay_window): Simplify code, to make it more
9635 obvious that ignore_mouse_drag_p is not accessed if !defined
9636 USE_GTK && !defined HAVE_NS.
9638 * intervals.c: Make symbols static if they're not exported.
9639 (merge_properties_sticky, merge_interval_right, delete_interval):
9641 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9643 * insdel.c: Make symbols static if they're not exported.
9644 However, leave prepare_to_modify_buffer alone. It's never
9645 called from outside this function, but that appears to be a bug.
9646 (combine_after_change_list, combine_after_change_buffer):
9647 (adjust_after_replace, signal_before_change): Now static.
9648 (adjust_after_replace_noundo): Remove; unused.
9649 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9650 (signal_before_change): Remove decls.
9652 * indent.c (val_compute_motion, val_vmotion): Now static.
9654 * image.c: Make symbols static if they're not exported.
9655 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9657 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9658 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9660 * fringe.c (standard_bitmaps): Now static.
9661 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9663 * frame.c: Make symbols static if they're not exported.
9664 (x_report_frame_params, make_terminal_frame): Now static.
9665 (get_frame_param): Now static, unless HAVE_NS.
9666 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9667 (x_get_resource_string): Remove; not used.
9668 * frame.h (make_terminal_frame, x_report_frame_params):
9669 (x_get_resource_string); Remove decls.
9670 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9671 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9673 * font.c, fontset.c: Make symbols static if they're not exported.
9674 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9675 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9676 * font.c (font_close_object): Now static.
9677 * font.h (font_close_object): Remove.
9678 * fontset.c (FONTSET_OBJLIST): Remove.
9679 (free_realized_fontset) #if-0 the body, which does nothing.
9680 (face_suitable_for_char_p): #if-0, as it's never called.
9681 * fontset.h (face_suitable_for_char_p): Remove decl.
9682 * xfaces.c (face_at_string_position):
9683 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9684 since 0 is always ASCII.
9686 * fns.c (weak_hash_tables): Now static.
9688 * fileio.c: Make symbols static if they're not exported.
9689 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9690 (Vwrite_region_annotation_buffers): Now static.
9692 * eval.c: Make symbols static if they're not exported.
9693 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9694 * lisp.h (backtrace_list): Remove decl.
9696 * emacs.c: Make symbols static if they're not exported.
9697 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9698 (fatal_error_code, fatal_error_signal_hook, standard_args):
9700 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9701 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9702 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9703 * lisp.h (fatal_error_signal_hook): Remove decl.
9704 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9706 * editfns.c: Move a (normally-unused) function to its only use.
9707 * editfns.c, lisp.h (get_operating_system_release): Remove.
9708 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9709 worth the hassle of breaking this out.
9711 * xterm.c: Make symbols static if they're not exported.
9712 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9713 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9714 (x_destroy_window, x_delete_display):
9716 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9717 (x_mouse_leave): Remove; unused.
9718 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9719 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9720 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9722 (x_mouse_leave): Declare only if WINDOWSNT.
9723 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9724 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9727 * ftxfont.c: Make symbols static if they're not exported.
9728 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9730 * font.h (ftxfont_driver): Likewise.
9732 * xfns.c: Make symbols static if they're not exported.
9733 (x_last_font_name, x_display_info_for_name):
9734 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9735 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9736 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9737 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9738 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9739 (last_show_tip_args): Now static.
9740 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9741 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9742 (x_screen_planes): Remove; unused.
9743 * dispextern.h (x_screen_planes): Remove decl.
9745 * dispnew.c: Make symbols static if they're not exported.
9746 * dispextern.h (redraw_garbaged_frames, scrolling):
9747 (increment_row_positions): Remove.
9748 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9749 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9751 (redraw_garbaged_frames): Remove; unused.
9753 * xfaces.c: Make symbols static if they're not exported.
9754 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9756 * xterm.h (defined_color): Remove decls.
9757 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9758 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9759 (menu_face_changed_default, defined_color, free_realized_face):
9760 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9761 (ascii_face_of_lisp_face): Remove; unused.
9763 * xdisp.c: Make symbols static if they're not exported.
9764 * dispextern.h (scratch_glyph_row, window_box_edges):
9765 (glyph_to_pixel_coords, set_cursor_from_row):
9766 (get_next_display_element, set_iterator_to_next):
9767 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9768 (show_mouse_face): Remove decls
9769 * frame.h (message_buf_print): Likewise.
9770 * lisp.h (pop_message, set_message, check_point_in_composition):
9772 * xterm.h (set_vertical_scroll_bar): Likewise.
9773 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9774 (message_buf_print, scratch_glyph_row, displayed_buffer):
9775 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9776 (get_next_display_element, show_mouse_face, window_box_edges):
9777 (frame_to_window_pixel_xy, check_point_in_composition):
9778 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9779 (glyph_to_pixel_coords): Remove; unused.
9781 * dired.c (file_name_completion): Now static.
9783 * dbusbind.c (xd_in_read_queued_messages): Now static.
9785 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9786 * data.c (circular_list_error): Remove.
9788 * commands.h (last_point_position, last_point_position_buffer):
9789 (last_point_position_window): Remove decls.
9790 * keyboard.c: Make these variables static.
9792 * coding.h (coding, code_convert_region, encode_coding_gap):
9794 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9795 (iso_code_class, detect_coding, code_convert_region): Now static.
9796 (encode_coding_gap): Remove; unused.
9798 * chartab.c (chartab_chars, chartab_bits): Now static.
9800 * charset.h (charset_iso_8859_1): Remove decl.
9801 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9804 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9805 * ccl.c (Vccl_program_table): Now static.
9806 (check_ccl_update): Remove; unused.
9808 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9809 * category.h: ... from here.
9810 * category.c (check_category_table, set_category_set): Now static.
9812 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9813 * lisp.h: Remove these decls.
9815 * buffer.c (buffer_count): Remove unused var.
9817 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9818 so that it's not optimized away.
9819 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9820 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9821 exported only to the debugger.
9823 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9824 * atimer.h (run_all_atimers): Remove; not exported.
9826 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9827 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9828 was inaccessible from Lisp.
9829 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9830 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9832 alloc.c: Import and export fewer symbols, and remove unused items.
9833 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9835 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9836 it's not optimized away by whole-program optimization.
9837 (message_enable_multibyte, free_misc): Remove.
9838 (catchlist, handlerlist, mark_backtrace):
9839 Declare only if BYTE_MARK_STACK.
9840 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9841 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9842 (message_enable_multibyte): Remove decl.
9843 (free_misc, interval_free_list, float_block, float_block_index):
9844 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9845 (cons_free_list, last_marked_index):
9847 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9848 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9849 (mark_backtrace): Define only if BYTE_MARK_STACK.
9850 * xdisp.c (message_enable_multibyte): Now static.
9852 Declare Lisp_Object Q* variables to be 'static' if not exported.
9853 This makes it easier for human readers (and static analyzers)
9854 to see whether these variables are used from other modules.
9855 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9856 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9857 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9858 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9859 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9860 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9861 * xmenu.c, xselect.c:
9862 Declare Q* vars static if they are not used in other modules.
9863 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9864 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9865 Remove decls of unexported vars.
9866 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9868 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9870 Make Emacs functions such as Fatom 'static' by default.
9871 This makes it easier for human readers (and static analyzers)
9872 to see whether these functions can be called from other modules.
9873 DEFUN now defines a static function. To make the function external
9874 so that it can be used in other C modules, use the new macro DEFUE.
9875 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9876 (Finit_image_library):
9877 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9878 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9879 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9880 Remove decls, since these functions are now static.
9881 (Funintern, Fget_internal_run_time): New decls, since these functions
9882 were already external.
9884 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9885 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9886 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9887 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9888 * keyboard.c, keymap.c, lread.c:
9889 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9890 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9891 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9892 Mark functions with DEFUE instead of DEFUN,
9893 if they are used in other modules.
9894 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9895 decls for now-static functions.
9896 * buffer.h (Fdelete_overlay): Remove decl.
9897 * callproc.c (Fgetenv_internal): Mark as internal.
9898 * composite.c (Fremove_list_of_text_properties): Remove decl.
9899 (Fcomposition_get_gstring): New forward static decl.
9900 * composite.h (Fcomposite_get_gstring): Remove decl.
9901 * dired.c (Ffile_attributes): New forward static decl.
9902 * doc.c (Fdocumntation_property): New forward static decl.
9903 * eval.c (Ffetch_bytecode): New forward static decl.
9904 (Funintern): Remove extern decl; now in .h file where it belongs.
9905 * fileio.c (Fmake_symbolic_link): New forward static decl.
9906 * image.c (Finit_image_library): New forward static decl.
9907 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9908 * intervals.h (Fprevious_property_change):
9909 (Fremove_list_of_text_properties): Remove decls.
9910 * keyboard.c (Fthis_command_keys): Remove decl.
9911 (Fcommand_execute): New forward static decl.
9912 * keymap.c (Flookup_key): New forward static decl.
9913 (Fcopy_keymap): Now static.
9914 * keymap.h (Flookup_key): Remove decl.
9915 * process.c (Fget_process): New forward static decl.
9916 (Fprocess_datagram_address): Mark as internal.
9917 * syntax.c (Fsyntax_table_p): New forward static decl.
9918 (skip_chars): Remove duplicate decl.
9919 * textprop.c (Fprevious_property_change): New forward static decl.
9920 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9922 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9923 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9925 * editfns.c (Fformat): Remove unreachable code.
9927 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9929 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9932 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9934 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9935 when at ZV. (Bug#8487)
9937 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9939 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9941 * keyboard.c (parse_tool_bar_item): Likewise.
9942 * sound.c (sound_cleanup, alsa_close): Likewise.
9943 * termcap.c (tgetent): Likewise.
9944 * xfns.c (x_default_font_parameter): Likewise.
9945 * xsettings.c (read_and_apply_settings): Likewise.
9947 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9948 (overrun_check_free): Protoize.
9950 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9952 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9953 since callers should never pass a negative size.
9954 Change the signature to match that of plain 'read' and 'write'; see
9955 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9956 * lisp.h: Update prototypes of emacs_write and emacs_read.
9958 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9960 * xdisp.c (redisplay_window): Don't try to determine the character
9961 position of the scroll margin if the window start point w->startp
9962 is outside the buffer's accessible region. (Bug#8468)
9964 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9966 Fix write-region and its subroutines for buffers > 2GB.
9967 * fileio.c (a_write, e_write): Modify declaration of arguments and
9968 local variables to support buffers larger than 2GB.
9969 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9971 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9972 argument, local variables, and return value.
9974 * lisp.h: Update prototypes of emacs_write and emacs_read.
9976 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9978 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9980 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9982 Fix more problems found by GCC 4.6.0's static checks.
9984 * xdisp.c (vmessage): Use a better test for character truncation.
9986 * charset.c (load_charset_map): <, not <=, for optimization,
9987 and to avoid potential problems with integer overflow.
9988 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9989 * casetab.c (set_identity, shuffle): Likewise.
9990 * editfns.c (Fformat): Likewise.
9991 * syntax.c (skip_chars): Likewise.
9993 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9994 This also lets GCC 4.6.0 generate slightly better loop code.
9996 * callint.c (Fcall_interactively): <, not <=, for optimization.
9997 (Fcall_interactively): Count the number of arguments produced,
9998 not the number of arguments given. This is simpler and lets GCC
9999 4.6.0 generate slightly better code.
10001 * ftfont.c: Distingish more carefully between FcChar8 and char.
10002 The previous code passed unsigned char * to a functions like
10003 strlen and xstrcasecmp that expect char *, which does not
10004 conform to the C standard.
10005 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10006 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10007 char * when the C standard requires it.
10009 * keyboard.c (read_char): Remove unused var.
10011 * eval.c: Port to Windows vsnprintf (Bug#8435).
10012 Include <limits.h>.
10013 (SIZE_MAX): Define if the headers do not.
10014 (verror): Do not give up if vsnprintf returns a negative count.
10015 Instead, grow the buffer. This ports to Windows vsnprintf, which
10016 does not conform to C99. Problem reported by Eli Zaretskii.
10017 Also, simplify the allocation scheme, by avoiding the need for
10018 calling realloc, and removing the ALLOCATED variable.
10020 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10022 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10023 But keep the doprint source code for now, as we might revamp it
10024 and use it again (Bug#8435).
10025 * lisp.h (doprnt): Remove.
10026 * Makefile.in (base_obj): Remove doprnt.o.
10027 * deps.mk (doprnt.o): Remove.
10029 error: Print 32- and 64-bit integers portably (Bug#8435).
10030 Without this change, on typical 64-bit hosts error ("...%d...", N)
10031 was used to print both 32- and 64-bit integers N, which relied on
10032 undefined behavior.
10033 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10034 * lisp.h (error, verror): Mark as printf-like functions.
10035 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10036 Report overflow in size calculations when allocating printf buffer.
10037 Do not truncate output string at its first null byte.
10038 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10039 Truncate the output at a character boundary, since vsnprintf does not
10041 * charset.c (check_iso_charset_parameter): Convert internal
10042 character to string before calling 'error', since %c now has the
10044 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10045 overflow when computing char to be passed to 'error'. Do not
10046 pass Lisp_Object to 'error'; pass the integer instead.
10047 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10048 formatted with plain %d.
10050 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10052 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10054 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10056 * xterm.c (x_catch_errors): Remove duplicate declaration.
10058 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10060 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10062 2011-04-10 Jim Meyering <meyering@redhat.com>
10064 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10065 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10066 return ssize_t not "int", and use size_t as the buffer length.
10067 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10068 * gnutls.h: Update declarations.
10069 * process.c (read_process_output): Use ssize_t, to match.
10070 (send_process): Likewise.
10072 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10074 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10076 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10078 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10079 Use unsigned char, to match FcChar8 type definition.
10081 * xterm.c (handle_one_xevent):
10082 * xmenu.c (create_and_show_popup_menu):
10083 * xselect.c (x_decline_selection_request)
10084 (x_reply_selection_request): Avoid type-punned deref of X events.
10086 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10088 Fix some uses of `int' instead of EMACS_INT.
10089 * search.c (string_match_1, fast_string_match)
10090 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10091 (scan_buffer, find_next_newline_no_quit)
10092 (find_before_next_newline, search_command, Freplace_match)
10093 (Fmatch_data): Make some `int' variables be EMACS_INT.
10095 * xdisp.c (display_count_lines): 3rd argument and return value now
10096 EMACS_INT. All callers changed.
10097 (pint2hrstr): Last argument is now EMACS_INT.
10099 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10100 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10101 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10102 (decode_coding_utf_16, decode_coding_emacs_mule)
10103 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10104 (decode_coding_ccl, decode_coding_charset)
10105 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10106 (decode_coding_iso_2022, decode_coding_emacs_mule)
10107 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10108 <char_offset, last_offset>: Declare EMACS_INT.
10109 (encode_coding_utf_8, encode_coding_utf_16)
10110 (encode_coding_emacs_mule, encode_invocation_designation)
10111 (encode_designation_at_bol, encode_coding_iso_2022)
10112 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10113 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10115 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10116 (encode_invocation_designation): Last argument P_NCHARS is now
10118 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10119 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10121 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10124 * ccl.c (Fccl_execute_on_string): Declare some variables
10127 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10129 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10131 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10133 * process.c (Fformat_network_address): Doc fix.
10135 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10137 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10139 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10141 * keyboard.c (read_char): Call Lisp function help-form-show,
10142 instead of using internal_with_output_to_temp_buffer.
10143 (Qhelp_form_show): New var.
10144 (syms_of_keyboard): Use DEFSYM macro.
10146 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10148 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10150 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10152 * process.c (Flist_processes): Remove to Lisp.
10153 (list_processes_1): Delete.
10155 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10157 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10159 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10161 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10163 Fix more problems found by GCC 4.6.0's static checks.
10165 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10167 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10169 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10171 * xdisp.c (vmessage): Mark as a printf-like function.
10173 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10175 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10177 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10178 printf-like functions.
10179 (tiff_load): Add casts to remove these marks before passing them
10180 to system-supplied API.
10182 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10184 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10185 This avoids several warnings with gcc -Wstrict-overflow.
10186 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10187 directly, rather than having caller test rule sign. This avoids
10188 some unnecessary tests.
10189 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10190 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10191 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10193 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10194 (xfont_open): Avoid unnecessary tests.
10196 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10198 * composite.h, composite.c (composition_gstring_put_cache):
10199 Use EMACS_INT, not int, for length.
10201 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10202 breaking out part of COMPOSITION_DECODE_RULE.
10203 (COMPOSITION_DECODE_RULE): Use it.
10204 * composite.c (get_composition_id): Remove unused local vars,
10205 by using the new macro.
10207 * textprop.c (set_text_properties_1): Change while to do-while,
10208 since the condition is always true at first.
10210 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10211 (interval_deletion_adjustment): Return unsigned value.
10214 * process.c (list_processes_1, create_pty, read_process_output):
10215 (exec_sentinel): Remove vars that were set but not used.
10216 (create_pty): Remove unnecessary "volatile"s.
10217 (Fnetwork_interface_info): Avoid possibility of int overflow.
10218 (read_process_output): Do adaptive read buffering even if carryover.
10219 (read_process_output): Simplify nbytes computation if buffered.
10221 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10223 * syntax.c (scan_words): Remove var that was set but not used.
10224 (update_syntax_table): Use unsigned instead of int.
10226 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10227 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10228 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10230 * print.c (print_error_message): Avoid int overflow.
10232 * font.c (font_list_entities): Redo for clarity,
10233 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10235 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10236 (font_score): Avoid potential overflow in diff calculation.
10238 * fns.c (substring_both): Remove var that is set but not used.
10239 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10241 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10243 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10244 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10245 can always succeed if overflow has undefined behavior.
10247 * search.c (boyer_moore, wordify): Remove vars set but not used.
10248 (wordify): Omit three unnecessary tests.
10250 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10251 All callers changed. This avoids the need for an unused var.
10253 * casefiddle.c (casify_region): Remove var that is set but not used.
10255 * dired.c (file_name_completion): Remove var that is set but not used.
10257 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10259 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10260 (Finsert_file_contents): Remove unnecessary code checking fd.
10262 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10263 Check for integer overflow on size calculations.
10265 * buffer.c (Fprevious_overlay_change): Remove var that is set
10268 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10269 Remove vars that are set but not used.
10270 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10271 (timer_check_2): Mark vars as initialized.
10273 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10275 * image.c (lookup_image): Remove var that is set but not used.
10276 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10278 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10279 that are set but not used.
10281 * xfns.c (make_invisible_cursor): Don't return garbage
10282 if XCreateBitmapFromData fails (Bug#8410).
10284 * xselect.c (x_get_local_selection, x_handle_property_notify):
10285 Remove vars that are set but not used.
10287 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10288 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10290 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10291 Remove var that is set but not used.
10292 (scroll_bar_windows_size): Now size_t, not int.
10293 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10294 Check for overflow.
10296 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10297 (map_tty_color) [!defined MSDOS]: Likewise.
10299 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10301 * coding.c: Remove vars that are set but not used.
10302 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10303 All callers changed.
10304 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10305 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10306 (decode_coding_charset): Remove vars that are set but not used.
10308 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10309 that is set but not used.
10311 * print.c (print_object): Remove var that is set but not used.
10313 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10314 The gnulib version avoids calling malloc in the usual case,
10315 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10316 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10317 * filelock.c (current_lock_owner): Likewise.
10318 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10319 * sysdep.c: Include allocator.h, careadlinkat.h.
10320 (emacs_no_realloc_allocator): New static constant.
10321 (emacs_readlink): New function.
10322 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10323 ../lib/careadlinkat.h.
10325 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10327 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10328 first non-nil return value).
10330 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10332 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10333 if not defined (Bug#8403).
10335 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10337 * xdisp.c (display_count_lines): Remove parameter `start',
10338 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10339 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10340 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10341 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10342 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10343 and thereabouts. All callers changed.
10344 (get_per_char_metric): Remove parameter `f', unused since
10345 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10347 2011-04-02 Jim Meyering <meyering@redhat.com>
10349 do not dereference NULL upon failed strdup
10350 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10351 (ns_get_family): Likewise.
10353 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10355 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10357 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10359 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10362 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10364 Add lexical binding.
10366 * window.c (Ftemp_output_buffer_show): New fun.
10367 (Fsave_window_excursion):
10368 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10370 * lread.c (lisp_file_lexically_bound_p): New function.
10371 (Fload): Bind Qlexical_binding.
10372 (readevalloop): Remove `evalfun' arg.
10373 Bind Qinternal_interpreter_environment.
10374 (Feval_buffer): Bind Qlexical_binding.
10375 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10377 (syms_of_lread): Declare `lexical-binding'.
10379 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10381 * keyboard.c (eval_dyn): New fun.
10382 (menu_item_eval_property): Use it.
10384 * image.c (parse_image_spec): Use Ffunctionp.
10386 * fns.c (concat, mapcar1): Accept byte-code-functions.
10388 * eval.c (Fsetq): Handle lexical vars.
10389 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10390 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10391 (FletX, Flet): Obey lexical binding.
10392 (Fcommandp): Handle closures.
10393 (Feval): New `lexical' arg.
10394 (eval_sub): New function extracted from Feval. Use it almost
10395 everywhere where Feval was used. Look up vars in lexical env.
10397 (Ffunctionp): Move from subr.el.
10398 (Ffuncall): Handle closures.
10399 (apply_lambda): Remove `eval_flags'.
10400 (funcall_lambda): Handle closures and new byte-code-functions.
10401 (Fspecial_variable_p): New function.
10402 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10403 but without exporting it to Lisp.
10405 * doc.c (Fdocumentation, store_function_docstring):
10406 * data.c (Finteractive_form): Handle closures.
10408 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10411 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10413 (exec_byte_code): New function extracted from Fbyte_code to handle new
10414 calling convention for byte-code-functions. Add new byte-codes.
10416 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10418 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10420 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10422 * xdisp.c (redisplay_internal): Fix prototype.
10424 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10426 * xdisp.c (SCROLL_LIMIT): New macro.
10427 (try_scrolling): Use it when setting scroll_limit.
10428 Limit scrolling to 100 screen lines.
10429 (redisplay_window): Even when falling back on "recentering",
10430 position point in the window according to scroll-conservatively,
10431 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10433 (try_scrolling): When point is above the window, allow searching
10434 as far as scroll_max, or one screenful, to compute vertical
10435 distance from PT to the scroll margin position. This prevents
10436 try_scrolling from unnecessarily failing when
10437 scroll-conservatively is set to a value slightly larger than the
10438 window height. Clean up the case of PT below the margin at bottom
10439 of window: scroll_max can no longer be INT_MAX. When aggressive
10440 scrolling is in use, don't let point enter the opposite scroll
10441 margin as result of the scroll.
10442 (syms_of_xdisp) <scroll-conservatively>: Document the
10443 threshold of 100 lines for never-recentering scrolling.
10445 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10447 * dispextern.h (move_it_by_lines):
10448 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10449 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10450 (message_log_check_duplicate): Remove parameters `prev_bol' and
10451 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10452 (redisplay_internal): Remove parameter `preserve_echo_area',
10453 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10455 * indent.c (Fvertical_motion):
10456 * window.c (window_scroll_pixel_based, Frecenter):
10457 Don't pass `need_y_p' to `move_it_by_lines'.
10459 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10461 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10462 steal a few bits to be more compact.
10463 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10464 Remove unneeded casts.
10466 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10468 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10470 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10471 binding" message (bug#7967).
10473 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10475 Fix more problems found by GCC 4.6.0's static checks.
10477 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10478 Remove unused local var.
10480 * editfns.c (Fmessage_box): Remove unused local var.
10482 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10483 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10484 Omit unused local vars.
10485 * window.c (shrink_windows): Omit unused local var.
10486 * menu.c (digest_single_submenu): Omit unused local var.
10487 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10488 Omit unused local var.
10490 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10491 Don't assume string length fits in int.
10492 (keyremap_step, read_key_sequence): Use size_t for sizes.
10493 (read_key_sequence): Don't check last_real_key_start redundantly.
10495 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10496 instead of alloca (Bug#8344).
10498 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10499 (Fbacktrace_frame): Don't assume nframes fits in int.
10501 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10503 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10506 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10508 * cm.c (calccost): Turn while-do into do-while, for clarity.
10510 * keyboard.c (syms_of_keyboard): Use the same style as later
10511 in this function when indexing through an array. This also
10512 works around GCC bug 48267.
10514 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10516 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10518 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10519 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10521 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10522 This avoids undefined behavior on integer overflow, and is a bit
10523 more convenient anyway since it is compared to a size_t variable.
10525 Variadic C functions now count arguments with size_t, not int.
10526 This avoids an unnecessary limitation on 64-bit machines, which
10527 caused (substring ...) to crash on large vectors (Bug#8344).
10528 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10529 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10530 All variadic functions and their callers changed accordingly.
10531 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10532 * data.c (arith_driver, float_arith_driver): Likewise.
10533 * editfns.c (general_insert_function): Likewise.
10534 * eval.c (struct backtrace.nargs, interactive_p)
10535 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10536 (funcall_lambda, mark_backtrace): Likewise.
10537 * fns.c (concat): Likewise.
10538 * frame.c (x_set_frame_parameters): Likewise.
10539 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10540 0 if not found, not -1. All callers changed.
10542 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10543 (stack_copy_size): Now size_t, not int.
10544 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10546 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10548 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10549 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10550 All callers changed.
10552 * lisp.h (multibyte_char_to_unibyte):
10553 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10554 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10555 * character.h (CHAR_TO_BYTE8):
10556 * cmds.c (internal_self_insert):
10557 * editfns.c (general_insert_function):
10558 * keymap.c (push_key_description):
10559 * search.c (Freplace_match):
10560 * xdisp.c (message_dolog, set_message_1): All callers changed.
10562 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10564 * keyboard.c (safe_run_hook_funcall): New function.
10565 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10566 don't set the hook to nil, but remove the offending function instead.
10567 (Qcommand_hook_internal): Remove, unused.
10568 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10569 Vcommand_hook_internal.
10571 * eval.c (enum run_hooks_condition): Remove.
10572 (funcall_nil, funcall_not): New functions.
10573 (run_hook_with_args): Call each function through a `funcall' argument.
10574 Remove `cond' argument, now redundant.
10575 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10576 (Frun_hook_with_args_until_failure): Adjust accordingly.
10577 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10579 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10581 * dispextern.h (string_buffer_position): Remove declaration.
10583 * print.c (strout): Remove parameter `multibyte', unused since
10584 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10586 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10587 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10588 All callers changed.
10590 * w32.c (_wsa_errlist): Use braces for struct initializers.
10592 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10593 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10594 All callers changed.
10595 (string_buffer_position): Likewise. Also, make static (it's never
10596 used outside xdisp.c).
10597 (cursor_row_p): Remove parameter `w', unused since
10598 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10599 (decode_mode_spec): Remove parameter `precision', introduced during
10600 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10601 All callers changed.
10603 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10605 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10607 2011-03-27 Anders Lindgren <andlind@gmail.com>
10609 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10610 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10611 (ns_update_auto_hide_menu_bar): New functions.
10612 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10613 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10614 ns_constrain_all_frames.
10615 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10616 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10618 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10620 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10622 2011-03-27 Glenn Morris <rgm@gnu.org>
10624 * syssignal.h: Replace RETSIGTYPE with void.
10625 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10626 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10627 Replace SIGTYPE with void everywhere.
10628 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10629 * s/template.h (SIGTYPE): Remove commented out definition.
10631 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10633 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10634 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10636 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10638 * w32.c (read_unc_volume): Use parameter `henum', instead of
10639 global variable `wget_enum_handle'.
10641 * keymap.c (describe_vector): Remove parameters `indices' and
10642 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10643 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10645 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10647 * keyboard.c (timer_check): Remove parameter `do_it_now',
10648 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10649 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10650 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10652 * keyboard.c (read_char):
10653 * w32menu.c (w32_menu_display_help):
10654 * xmenu.c (show_help_event, menu_help_callback):
10655 Adjust calls to `show_help_echo'.
10657 * gtkutil.c (xg_maybe_add_timer):
10658 * keyboard.c (readable_events):
10659 * process.c (wait_reading_process_output):
10660 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10662 * insdel.c (adjust_markers_gap_motion):
10663 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10664 (gap_left, gap_right): Don't call it.
10666 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10668 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10669 incurred during fontification.
10671 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10673 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10674 (DEFVAR_PER_BUFFER): Don't pass it.
10676 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10677 (scrolling_window): Don't pass it.
10679 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10681 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10683 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10685 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10686 of variables specific to SELinux and computation of `encoded_absname'.
10688 * image.c (XPutPixel): Remove unused variable `height'.
10690 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10692 * unexw32.c (get_section_info): Remove unused variable `section'.
10694 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10695 (system_process_attributes): Remove unused variable `sess'.
10696 (sys_read): Remove unused variable `err'.
10698 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10699 (w32_wnd_proc): Remove unused variable `isdead'.
10700 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10701 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10702 (x_create_tip_frame): Remove unused variable `tem'.
10704 * w32inevt.c (w32_console_read_socket):
10705 Remove unused variable `no_events'.
10707 * w32term.c (x_draw_composite_glyph_string_foreground):
10708 Remove unused variable `width'.
10710 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10712 * w32term.c (x_set_glyph_string_clipping):
10713 Don't pass uninitialized region to CombineRgn.
10715 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10717 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10718 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10719 (Fx_close_connection): Remove unused variable `i'.
10721 * w32font.c (w32font_draw): Return number of glyphs.
10722 (w32font_open_internal): Remove unused variable `i'.
10723 (w32font_driver): Add missing initializer.
10725 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10726 (fill_in_menu): Remove unused variable `items_added'.
10728 * w32term.c (last_mouse_press_frame): Remove static global variable.
10729 (w32_clip_to_row): Remove unused variable `f'.
10730 (x_delete_terminal): Remove unused variable `i'.
10732 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10733 (NOTHING): Remove unused static global variable.
10734 (uniscribe_check_otf): Remove unused variable `table'.
10735 (uniscribe_font_driver): Add missing initializers.
10737 2011-03-23 Julien Danjou <julien@danjou.info>
10739 * term.c (Fsuspend_tty, Fresume_tty):
10740 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10741 * window.c (temp_output_buffer_show):
10742 * insdel.c (signal_before_change):
10743 * frame.c (Fhandle_switch_frame):
10744 * fileio.c (Fdo_auto_save):
10745 * emacs.c (Fkill_emacs):
10746 * editfns.c (save_excursion_restore):
10747 * cmds.c (internal_self_insert):
10748 * callint.c (Fcall_interactively):
10749 * buffer.c (Fkill_all_local_variables):
10750 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10752 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10753 unconditionally since it does the check itself.
10755 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10757 Fix more problems found by GCC 4.5.2's static checks.
10759 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10760 the first time through the loop, since we know p0 < p1 then.
10761 This also avoids a gcc -Wstrict-overflow warning.
10763 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10764 leading to a memory leak, possible in functions like
10765 load_charset_map_from_file that can allocate an unbounded number
10766 of objects (Bug#8318).
10768 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10769 that could (at least in theory) be that large.
10771 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10772 This is less likely to overflow, and avoids undefined behavior if
10773 overflow does occur. All callers changed. Use strtoul to scan
10774 for the unsigned long integer.
10775 (pint2hrstr): Simplify and tune code slightly.
10776 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10778 * scroll.c (do_scrolling): Work around GCC bug 48228.
10779 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10781 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10782 This also avoids a warning with gcc -Wstrict-overflow.
10783 (validate_x_resource_name): Simplify count usage.
10784 This also avoids a warning with gcc -Wstrict-overflow.
10786 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10789 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10791 * process.c (Fmake_network_process): Use socklen_t, not int,
10792 where POSIX says socklen_t is required in portable programs.
10793 This fixes a porting bug on hosts like 64-bit HP-UX, where
10794 socklen_t is wider than int (Bug#8277).
10795 (Fmake_network_process, server_accept_connection):
10796 (wait_reading_process_output, read_process_output):
10799 * process.c: Rename or move locals to avoid shadowing.
10800 (list_processes_1, Fmake_network_process):
10801 (read_process_output_error_handler, exec_sentinel_error_handler):
10802 Rename or move locals.
10803 (Fmake_network_process): Define label "retry_connect" only if needed.
10804 (Fnetwork_interface_info): Fix pointer signedness.
10805 (process_send_signal): Add cast to avoid pointer signedness problem.
10806 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10807 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10809 Make tparam.h and terminfo.c consistent.
10810 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10811 Include tparam.h instead, since it declares them.
10812 * cm.h (PC): Remove extern decl; tparam.h now does this.
10813 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10814 * terminfo.c: Include tparam.h, to check interfaces.
10815 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10816 (tparam): Adjust signature to match interface in tparam.h;
10817 this removes some undefined behavior. Check that outstring and len
10818 are zero, which they always are with Emacs.
10819 * tparam.h (PC, BC, UP): New extern decls.
10821 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10822 (xftfont_open): Rename locals to avoid shadowing.
10824 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10825 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10826 (OTF_TAG_SYM): Omit macro if not needed.
10827 (ftfont_list): Remove unused local.
10828 (get_adstyle_property, ftfont_pattern_entity):
10829 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10830 Rename locals to avoid shadowing.
10832 * xfont.c (xfont_list_family): Mark var as initialized.
10834 * xml.c (make_dom): Now static.
10836 * composite.c (composition_compute_stop_pos): Rename local to
10838 (composition_reseat_it): Remove unused locals.
10839 (find_automatic_composition, composition_adjust_point): Likewise.
10840 (composition_update_it): Mark var as initialized.
10841 (find_automatic_composition): Mark vars as initialized,
10842 with a FIXME (Bug#8290).
10844 character.h: Rename locals to avoid shadowing.
10845 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10846 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10847 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10848 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10849 to avoid shadowing.
10851 * textprop.c (property_change_between_p): Remove; unused.
10853 * intervals.c (interval_start_pos): Now static.
10855 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10857 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10858 Rename locals to avoid shadowing.
10860 * sound.c (wav_play, au_play, Fplay_sound_internal):
10861 Fix pointer signedness.
10862 (alsa_choose_format): Remove unused local var.
10863 (wav_play): Initialize a variable to 0, to prevent undefined
10864 behavior (Bug#8278).
10866 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10868 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10870 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10871 clobbering (Bug#8298).
10872 * sysdep.c (sys_subshell): Likewise.
10873 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10875 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10876 This should get cleaned up, so that child_setup has the
10877 same signature on all platforms.
10879 * callproc.c (call_process_cleanup): Now static.
10880 (relocate_fd): Rename locals to avoid shadowing.
10882 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10884 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10885 not to be necessary, and produces flickering.
10887 2011-03-20 Glenn Morris <rgm@gnu.org>
10889 * config.in: Remove file.
10891 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10893 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10894 are now in src/globals.h.
10895 (syms_of_minibuf): Remove spurious & from previous change.
10897 2011-03-20 Leo Liu <sdl.web@gmail.com>
10899 * minibuf.c (completing-read-function): New variable.
10900 (completing-read-default): Rename from completing-read.
10901 (completing-read): Call completing-read-function.
10903 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10905 * xfaces.c (Fx_load_color_file):
10906 Read color file from absolute filename (bug#8250).
10908 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10910 * makefile.w32-in: Update dependencies.
10912 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10914 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10916 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10918 Fix more problems found by GCC 4.5.2's static checks.
10920 * process.c (make_serial_process_unwind, send_process_trap):
10921 (sigchld_handler): Now static.
10923 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10924 That way, the code declares only the vars that it needs.
10925 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10926 * s/cygwin.h (PTY_ITERATION): Likewise.
10927 * s/darwin.h (PTY_ITERATION): Likewise.
10928 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10930 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10931 * process.c (allocate_pty): Don't declare stb unless it's needed.
10933 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10934 (CONSTANTLIM): Remove; unused.
10935 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10936 Define only if needed.
10938 * unexelf.c (unexec): Name an expression,
10939 to avoid gcc -Wbad-function-cast warning.
10940 Use a different way to cause a compilation error if anyone uses
10941 n rather than nn, a way that does not involve shadowing.
10942 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10944 * deps.mk (unexalpha.o): Remove; unused.
10946 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10947 * unexec.h: New file.
10948 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10949 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10950 Depend on unexec.h.
10951 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10952 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10953 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10954 Change as necessary to match prototype in unexec.h.
10956 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10958 (back_comment, skip_chars): Mark vars as initialized.
10960 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10961 Rename locals to avoid shadowing.
10963 * lread.c (read1): Rewrite so as not to use empty "else".
10964 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10966 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10968 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10969 warning when compiling print.c.
10971 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10972 instead of using an uninitialized var.
10973 (font_sort_entities): Mark var as initialized.
10975 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10977 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10978 pointers to constants.
10979 (font_parse_fcname): Remove unused vars.
10980 (font_delete_unmatched): Now static.
10981 (font_get_spec): Remove; unused.
10982 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10983 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10984 Rename or move locals to avoid shadowing.
10986 * fns.c (require_nesting_list, require_unwind): Now static.
10987 (Ffillarray): Rename locals to avoid shadowing.
10989 * floatfns.c (domain_error2): Define only if needed.
10990 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10992 * alloc.c (mark_backtrace): Move decl from here ...
10993 * lisp.h: ... to here, so that it can be checked.
10995 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10996 (Fdefvar): Rewrite so as not to use empty "else".
10997 (lisp_indirect_variable): Name an expression,
10998 to avoid gcc -Wbad-function-cast warning.
10999 (Fdefvar): Rename locals to avoid shadowing.
11001 * callint.c (quotify_arg, quotify_args): Now static.
11002 (Fcall_interactively): Rename locals to avoid shadowing.
11003 Use const pointer when appropriate.
11005 * lisp.h (get_system_name, get_operating_system_release):
11006 Move decls here, to check interfaces.
11007 * process.c (get_operating_system_release): Move decl to lisp.h.
11008 * xrdb.c (get_system_name): Likewise.
11009 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11010 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11011 some of which prompt warnings from gcc -Wbad-function-cast.
11012 (Fformat_time_string, Fencode_time, Finsert_char):
11013 (Ftranslate_region_internal, Fformat):
11014 Rename or remove local vars to avoid shadowing.
11015 (Ftranslate_region_internal): Mark var as initialized.
11017 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11020 * lisp.h (eassert): Check that the argument compiles, even if
11021 ENABLE_CHECKING is not defined.
11023 * data.c (Findirect_variable): Name an expression, to avoid
11024 gcc -Wbad-function-cast warning.
11025 (default_value, arithcompare, arith_driver, arith_error): Now static.
11026 (store_symval_forwarding): Rename local to avoid shadowing.
11027 (Fmake_variable_buffer_local, Fmake_local_variable):
11028 Mark variables as initialized.
11029 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11031 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11032 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11033 Rename locals to avoid shadowing.
11034 (mark_stack): Move local variables into the #ifdef region where
11036 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11037 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11039 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11040 (GC_STRING_CHARS): Remove; not used.
11041 (Fmemory_limit): Cast sbrk's returned value to char *.
11043 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11044 avoids undefined behavior in theory.
11046 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11048 Use functions, not macros, for up- and down-casing (Bug#8254).
11049 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11050 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11051 to use the following functions instead of these macros.
11052 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11053 EMACS_INT, since callers assume the returned value fits in int.
11054 (upcase1): Likewise, for UPCASE_TABLE.
11055 (uppercasep, lowercasep, upcase): New static inline functions.
11056 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11057 the race-condition problem in the old DOWNCASE.
11059 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11060 Rename locals to avoid shadowing.
11061 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11062 (regex_compile, re_search_2, re_match_2_internal):
11063 Remove unused local vars.
11064 (FREE_VAR): Rewrite so as not to use empty "else",
11065 which gcc can warn about.
11066 (regex_compile, re_match_2_internal): Mark locals as initialized.
11067 (RETALLOC_IF): Define only if needed.
11068 (WORDCHAR_P): Likewise. This one is never needed, but is used
11069 only in a comment talking about a compiler bug, so put inside
11070 the #if 0 of that comment.
11071 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11072 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11075 * search.c (boyer_moore): Rename locals to avoid shadowing.
11076 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11077 (PREV_CHAR_BOUNDARY): Likewise.
11079 * search.c (simple_search): Remove unused var.
11081 * dired.c (compile_pattern): Move decl from here ...
11082 * lisp.h: ... to here, so that it can be checked.
11083 (struct re_registers): New forward decl.
11085 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11087 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11089 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11090 Rename locals to avoid shadowing.
11091 (Fvertical_motion): Mark locals as initialized.
11093 * casefiddle.c (casify_object, casify_region): Now static.
11094 (casify_region): Mark local as initialized.
11096 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11098 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11099 New macros, so that the caller can use some names other than
11100 gcpro1, gcpro2, etc.
11101 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11103 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11104 argument, for consistency with GCPRO2_VAR, etc: it is now the
11105 prefix of the variable, not the variable itself. All uses
11107 * dired.c (directory_files_internal, file_name_completion):
11108 Rename locals to avoid shadowing.
11110 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11111 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11112 dired.c's scmp function, had undefined behavior.
11113 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11114 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11115 * buffer.h: ... to here, because these macros use current_buffer,
11116 and the new implementation with inline functions needs to have
11117 current_buffer in scope now, rather than later when the macros
11119 (downcase, upcase1): New static inline functions.
11120 (DOWNCASE, UPCASE1): Reimplement using these functions.
11121 This avoids undefined behavior in expressions like
11122 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11123 from race conditions in accessing the global variables
11124 case_temp1 and case_temp2.
11125 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11126 * lisp.h (case_temp1, case_temp2): Remove their decls.
11127 * character.h (ASCII_CHAR_P): Move from here ...
11128 * lisp.h: ... to here, so that the inline functions mentioned
11129 above can use them.
11131 * dired.c (directory_files_internal_unwind): Now static.
11133 * fileio.c (file_name_as_directory, directory_file_name):
11134 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11136 (file_name_as_directory): Use const pointers when appropriate.
11137 (Fexpand_file_name): Likewise. In particular, newdir might
11138 point at constant storage, so make it a const pointer.
11139 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11140 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11142 (Fset_file_times, Finsert_file_contents, auto_save_error):
11143 Rename locals to avoid shadowing.
11145 * minibuf.c (choose_minibuf_frame_1): Now static.
11146 (Ftry_completion, Fall_completions): Rename or remove locals
11147 to avoid shadowing.
11149 * marker.c (bytepos_to_charpos): Remove; unused.
11151 * lisp.h (verify_bytepos, count_markers): New decls,
11152 so that gcc does not warn that these functions aren't declared.
11154 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11155 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11156 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11157 (copy_text): Remove unused local var.
11159 * filelock.c (within_one_second): Now static.
11160 (lock_file_1): Rename local to avoid shadowing.
11162 * buffer.c (fix_overlays_before): Mark locals as initialized.
11163 (fix_start_end_in_overlays): Likewise. This function should be
11164 simplified by using pointers-to-pointers, but that's a different
11166 (switch_to_buffer_1): Now static.
11167 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11168 (report_overlay_modification): Rename locals to avoid shadowing.
11170 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11171 Fix pointer signedness issue.
11172 (sys_subshell): Mark local as volatile if checking for lint,
11173 to suppress a gcc -Wclobbered warning that does not seem to be right.
11174 (MAXPATHLEN): Define only if needed.
11176 * process.c (serial_open, serial_configure): Move decls from here ...
11177 * systty.h: ... to here, so that they can be checked.
11179 * fns.c (get_random, seed_random): Move extern decls from here ...
11180 * lisp.h: ... to here, so that they can be checked.
11182 * sysdep.c (reset_io): Now static.
11183 (wait_for_termination_signal): Remove; unused.
11185 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11186 (copy_keymap_item, append_key, push_text_char_description):
11188 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11189 (DENSE_TABLE_SIZE): Remove; unused.
11190 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11191 (describe_map_tree):
11192 Rename locals to avoid shadowing.
11194 * keyboard.c: Declare functions static if they are not used elsewhere.
11195 (echo_char, echo_dash, cmd_error, top_level_2):
11196 (poll_for_input, handle_async_input): Now static.
11197 (read_char, kbd_buffer_get_event, make_lispy_position):
11198 (make_lispy_event, make_lispy_movement, apply_modifiers):
11199 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11200 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11201 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11202 (read_key_sequence, read_char): Mark locals as initialized.
11203 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11205 * keyboard.h (make_ctrl_char): New decl.
11206 (mark_kboards): Move decl here ...
11207 * alloc.c (mark_kboards): ... from here.
11209 * lisp.h (force_auto_save_soon): New decl.
11211 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11212 (DEFINE_DUMMY_FUNCTION): New macro.
11213 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11215 (main): Add casts to avoid warnings
11216 if GCC considers string literals to be constants.
11218 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11220 * dbusbind.c: Pointer signedness fixes.
11221 (xd_signature, xd_append_arg, xd_initialize):
11222 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11223 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11224 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11225 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11227 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11228 if GCC considers string literals to be constants.
11229 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11231 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11233 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11234 (print_preprocess, print_object): New macro to fix last change.
11236 * print.c (print_preprocess): Don't forget font objects.
11238 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11240 * emacs.c (USAGE3): Doc fixes.
11242 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11244 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11247 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11249 * lisp.h (VWindow_system, Qfile_name_history):
11250 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11251 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11252 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11254 * w32select.c: Don't #include "keyboard.h".
11255 (run_protected): Add extern declaration for waiting_for_input.
11257 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11258 * w32console.c (detect_input_pending, read_input_pending)
11259 (encode_terminal_code):
11260 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11261 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11262 (w32_system_caret_y, Qfile_name_history):
11263 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11264 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11265 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11266 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11267 * w32proc.c (Qlocal, report_file_error):
11268 * w32term.c (Vwindow_system, updating_frame):
11269 * w32uniscribe.c (initialized, uniscribe_font_driver):
11270 Remove unneeded extern declarations.
11272 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11274 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11276 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11278 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11279 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11280 These macros can no longer be used for assignment.
11282 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11283 Assign struct members directly, instead of using BUF_BEGV etc.
11284 (record_buffer_markers, fetch_buffer_markers): New functions for
11285 recording and fetching special buffer markers.
11286 (set_buffer_internal_1, set_buffer_temp): Use them.
11288 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11290 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11292 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11293 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11295 * xdisp.c (hscroll_window_tree):
11296 (reconsider_clip_changes): Use PT instead of BUF_PT.
11298 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11300 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11301 $(EMACS_ROOT)/lib/intprops.h.
11303 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11305 Fix more problems found by GCC 4.5.2's static checks.
11307 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11308 to unsigned char * to avoid compiler diagnostic.
11309 (xg_free_frame_widgets): Make it clear that a local variable is
11310 needed only if USE_GTK_TOOLTIP.
11311 (gdk_window_get_screen): Make it clear that this macro is needed
11312 only if USE_GTK_TOOLTIP.
11313 (int_gtk_range_get_value): New function, which avoids a diagnostic
11314 from gcc -Wbad-function-cast.
11315 (xg_set_toolkit_scroll_bar_thumb): Use it.
11316 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11317 diagnostic from gcc -Wbad-function-cast.
11318 (get_utf8_string, xg_get_file_with_chooser):
11319 Rename locals to avoid shadowing.
11320 (create_dialog): Move locals to avoid shadowing.
11322 * xgselect.c (xg_select): Remove unused var.
11324 * image.c (four_corners_best): Mark locals as initialized.
11325 (gif_load): Initialize transparent_p to zero (Bug#8238).
11326 Mark another local as initialized.
11327 (my_png_error, my_error_exit): Mark with NO_RETURN.
11329 * image.c (clear_image_cache): Now static.
11330 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11331 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11332 (x_edge_detection): Remove unnecessary cast that
11333 gcc -Wbad-function-cast diagnoses.
11334 (gif_load): Fix pointer signedness.
11335 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11336 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11338 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11340 Improve quality of tests for time stamp overflow.
11341 For example, without this patch (encode-time 0 0 0 1 1
11342 1152921504606846976) returns the obviously-bogus value (-948597
11343 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11344 reports time overflow. See
11345 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11346 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11347 * editfns.c: Include limits.h and intprops.h.
11348 (TIME_T_MIN, TIME_T_MAX): New macros.
11349 (time_overflow): Move earlier, to before first use.
11350 (hi_time, lo_time): New functions, for an accurate test for
11351 out-of-range times.
11352 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11353 (Fget_internal_run_time): Don't assume time_t fits in int.
11354 (make_time): Use list2 instead of Fcons twice.
11355 (Fdecode_time): More accurate test for out-of-range times.
11356 (check_tm_member): New function.
11357 (Fencode_time): Use it, to test for out-of-range times.
11358 (lisp_time_argument): Don't rely on undefined left-shift and
11359 right-shift behavior when checking for time stamp overflow.
11361 * editfns.c (time_overflow): New function, refactoring common code.
11362 (Fformat_time_string, Fdecode_time, Fencode_time):
11363 (Fcurrent_time_string): Use it.
11365 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11366 * dired.c (make_time): Move to ...
11367 * editfns.c (make_time): ... here.
11368 * systime.h: Note the move.
11370 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11372 * fringe.c (update_window_fringes): Remove unused variables.
11374 * unexmacosx.c (copy_data_segment): Also copy __got section.
11377 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11379 * termcap.c [MSDOS]: Include "msdos.h".
11380 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11381 Constify `char *' arguments and their references according to
11382 prototypes in tparam.h.
11384 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11386 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11387 Adapt all references accordingly.
11389 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11391 2011-03-11 Tom Tromey <tromey@redhat.com>
11393 * buffer.c (syms_of_buffer): Remove obsolete comment.
11395 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11397 * termhooks.h (encode_terminal_code): Declare prototype.
11399 * msdos.c (encode_terminal_code): Don't declare prototype.
11401 * term.c (encode_terminal_code): Now external again, used by
11402 w32console.c and msdos.c.
11404 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11405 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11407 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11409 Fix some minor problems found by GCC 4.5.2's static checks.
11411 * fringe.c (update_window_fringes): Mark locals as initialized
11413 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11415 * alloc.c (mark_fringe_data): Move decl from here ...
11416 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11417 to check its interface.
11418 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11420 * fontset.c (free_realized_fontset): Now static.
11421 (Fset_fontset_font): Rename local to avoid shadowing.
11422 (fontset_font): Mark local as initialized.
11423 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11425 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11427 * xselect.c (x_disown_buffer_selections): Remove; not used.
11428 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11429 (x_own_selection, Fx_disown_selection_internal): Rename locals
11430 to avoid shadowing.
11431 (x_handle_dnd_message): Remove local to avoid shadowing.
11433 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11434 so that the caller can use some name other than gcpro1.
11435 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11436 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11437 (Fx_backspace_delete_keys_p):
11438 Use them to avoid shadowing, and rename vars to avoid shadowing.
11439 (x_decode_color, x_set_name, x_window): Now static.
11440 (Fx_create_frame): Add braces to silence GCC warning.
11441 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11442 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11443 Remove unused locals.
11444 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11445 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11446 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11449 * xterm.h (x_mouse_leave): New decl.
11451 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11452 Remove unused functions.
11453 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11454 (x_calc_absolute_position): Now static.
11455 (XTread_socket): Don't define label "out" unless it's used.
11456 Don't declare local "event" unless it's used.
11457 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11458 unless they are used.
11459 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11460 (x_fatal_error_signal): Remove; not used.
11461 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11462 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11463 (x_error_catcher, x_connection_closed, x_error_handler):
11464 (x_error_quitter, xembed_send_message, x_iconify_frame):
11465 (my_log_handler): Rename locals to avoid shadowing.
11466 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11467 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11469 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11470 Rename or move locals to avoid shadowing.
11471 (tty_defined_color, merge_face_heights): Now static.
11472 (free_realized_faces_for_fontset): Remove; not used.
11473 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11474 does not deduce is never used uninitialized.
11475 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11476 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11478 * terminal.c (store_terminal_param): Now static.
11480 * xmenu.c (menu_highlight_callback): Now static.
11481 (set_frame_menubar): Remove unused local.
11482 (xmenu_show): Rename parameter to avoid shadowing.
11483 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11484 since they might point to immutable storage.
11485 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11486 since it's unused otherwise.
11488 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11489 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11490 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11491 avoids a gcc -Wuninitialized diagnostic.
11492 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11493 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11494 does not deduce are never used uninitialized.
11496 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11498 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11499 * window.c (window_loop, size_window):
11500 (run_window_configuration_change_hook, enlarge_window): Likewise.
11502 * window.c (display_buffer): Now static.
11503 (size_window): Mark variables that gcc -Wuninitialized
11504 does not deduce are never used uninitialized.
11505 * window.h (check_all_windows): New decl, to forestall
11506 gcc -Wmissing-prototypes diagnostic.
11507 * dispextern.h (bidi_dump_cached_states): Likewise.
11509 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11511 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11512 Include <limits.h>.
11513 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11514 and to avoid gcc -Wuninitialized warning.
11515 (load_charset_map): Mark variables that gcc -Wuninitialized
11516 does not deduce are never used uninitialized.
11517 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11519 * coding.c (coding_set_source, coding_set_destination):
11520 Use "else { /* comment */ }" rather than "else /* comment */;"
11521 for clarity, and to avoid gcc -Wempty-body warning.
11522 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11523 a block, when the outer 'i' will do.
11524 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11525 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11526 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11527 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11528 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11529 Rename locals to avoid shadowing.
11530 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11531 * coding.c (emacs_mule_char, encode_invocation_designation):
11532 Now static, since they're not used elsewhere.
11533 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11534 (decode_coding_object, encode_coding_object, detect_coding_system):
11535 (decode_coding_emacs_mule): Mark variables that gcc
11536 -Wuninitialized does not deduce are never used uninitialized.
11537 (detect_coding_iso_2022): Initialize a local variable that might
11538 be used uninitialized. Leave a FIXME because it's not clear that
11539 this initialization is needed. (Bug#8211)
11540 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11541 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11542 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11543 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11544 Remove unused macros.
11546 * category.c (hash_get_category_set): Remove unused local var.
11547 (copy_category_table): Now static, since it's not used elsewhere.
11548 * character.c (string_count_byte8): Likewise.
11550 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11551 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11553 * chartab.c (copy_sub_char_table): Now static, since it's not used
11555 (sub_char_table_ref_and_range, char_table_ref_and_range):
11556 Rename locals to avoid shadowing.
11557 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11559 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11560 (BIDI_BOB): Remove unused macro.
11562 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11563 deduce are never used uninitialized.
11564 * term.c (encode_terminal_code): Likewise.
11566 * term.c (encode_terminal_code): Now static. Remove unused local.
11568 * tparam.h: New file.
11569 * term.c, tparam.h: Include it.
11570 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11571 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11572 Move these decls to tparam.h, and make them agree with what
11573 is actually in tparam.c. The previous trick of using incompatible
11574 decls in different modules does not conform to the C standard.
11575 All callers of tparam changed to use tparam's actual API.
11576 * tparam.c (tparam1, tparam, tgoto):
11577 Use const pointers where appropriate.
11579 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11580 * cm.h (struct cm): Likewise.
11581 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11582 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11583 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11584 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11585 (turn_on_face, init_tty): Likewise.
11586 * termchar.h (struct tty_display_info): Likewise.
11588 * term.c (term_mouse_position): Rename local to avoid shadowing.
11590 * alloc.c (mark_ttys): Move decl from here ...
11591 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11593 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11595 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11597 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11599 * search.c (compile_pattern_1): Remove argument regp, unused since
11600 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11601 (compile_pattern): Don't pass it.
11603 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11605 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11606 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11608 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11610 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11612 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11613 gdk_window_get_screen, gdk_window_get_geometry,
11614 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11615 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11616 (xg_get_pixbuf_from_pixmap): New function.
11617 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11618 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11619 Call xg_get_pixbuf_from_pixmap instead of
11620 gdk_pixbuf_get_from_drawable.
11621 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11622 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11623 (xg_check_special_colors): Use GtkStyleContext and its functions
11625 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11626 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11627 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11628 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11629 Call gtk_widget_get_preferred_size.
11630 (xg_frame_resized): gdk_window_get_geometry only takes 5
11632 (xg_win_to_widget, xg_event_is_for_menubar):
11633 Call gdk_x11_window_lookup_for_display.
11634 (xg_set_widget_bg): New function.
11635 (delete_cb): New function.
11636 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11637 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11638 (xg_set_background_color): Call xg_set_widget_bg.
11639 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11640 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11641 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11642 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11644 (update_frame_tool_bar): Call gtk_widget_hide.
11645 (xg_initialize): Use GDK_KEY_g.
11647 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11649 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11651 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11652 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11653 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11655 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11657 * w32xfns.c (select_palette): Check success of RealizePalette against
11658 GDI_ERROR, not zero.
11660 See ChangeLog.11 for earlier changes.
11662 ;; Local Variables:
11666 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11668 This file is part of GNU Emacs.
11670 GNU Emacs is free software: you can redistribute it and/or modify
11671 it under the terms of the GNU General Public License as published by
11672 the Free Software Foundation, either version 3 of the License, or
11673 (at your option) any later version.
11675 GNU Emacs is distributed in the hope that it will be useful,
11676 but WITHOUT ANY WARRANTY; without even the implied warranty of
11677 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11678 GNU General Public License for more details.
11680 You should have received a copy of the GNU General Public License
11681 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.