| commit | 8ad32809e1bf97ced654c3a7b85f267339aba3f2 | |
| author | Kalle Olavi Niemitalo <kon@iki.fi> | |
| Sun, 1 Mar 2009 07:21:29 +0000 (1 09:21 +0200) | ||
| committer | Kalle Olavi Niemitalo <Kalle@Astalo.kon.iki.fi> | |
| Sun, 1 Mar 2009 07:21:29 +0000 (1 09:21 +0200) | ||
| tree | 83f72c3d1738f0ec877bb4584a206b993f700d9c | treesnapshot (tar.gz zip) |
| parent | d65f41faab58aa171849749fa6a1da122b38160f | commitdiff |
bug 153, 1066: Fix search in bookmark manager.
test_search() was supposed to compare bookmark titles with
strcasestr(), but in commit 311d95358de258656a0c7145a2dcff943fcdcd4b
"bug 153, 1066: Convert bookmarks to/from UTF-8 when searching."
on 2009-02-08, I inadvertently changed that to strcasecmp(), even
while adding a comment about why strcasestr() is needed. strcasestr()
returns non-NULL if the strings match, and strcasecmp() returns
nonzero if they differ, so the search didn't work at all.
test_search() was supposed to compare bookmark titles with
strcasestr(), but in commit 311d95358de258656a0c7145a2dcff943fcdcd4b
"bug 153, 1066: Convert bookmarks to/from UTF-8 when searching."
on 2009-02-08, I inadvertently changed that to strcasecmp(), even
while adding a comment about why strcasestr() is needed. strcasestr()
returns non-NULL if the strings match, and strcasecmp() returns
nonzero if they differ, so the search didn't work at all.
| src/bookmarks/dialogs.c | diffblobblamehistory |