From bff48267248302a5de4425a17904c5979e462e23 Mon Sep 17 00:00:00 2001 From: Robin Rosenberg Date: Sun, 27 Apr 2008 10:48:15 +0200 Subject: [PATCH] Do not wrap getSelectedProjects Signed-off-by: Robin Rosenberg --- .../org/spearce/egit/ui/internal/actions/CommitAction.java | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java index bfc25ea0..9ffa6376 100644 --- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java +++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java @@ -21,12 +21,10 @@ import java.io.File; import java.io.IOException; import java.io.UnsupportedEncodingException; import java.util.ArrayList; -import java.util.Arrays; import java.util.Calendar; import java.util.Date; import java.util.HashMap; import java.util.HashSet; -import java.util.List; import java.util.TimeZone; import org.eclipse.core.resources.IFile; @@ -78,7 +76,7 @@ public class CommitAction extends RepositoryAction { } Repository repo = null; - for (IProject proj : listProjects()) { + for (IProject proj : getSelectedProjects()) { Repository repository = RepositoryMapping.getMapping(proj).getRepository(); if (repo == null) repo = repository; @@ -172,7 +170,7 @@ public class CommitAction extends RepositoryAction { } catch (IOException e) { throw new TeamException("Committing changes", e); } - for (IProject proj : listProjects()) { + for (IProject proj : getSelectedProjects()) { RepositoryMapping.getMapping(proj).fireRepositoryChanged(); } } @@ -241,7 +239,7 @@ public class CommitAction extends RepositoryAction { UnsupportedEncodingException { if (selectedItems.length == 0) { // amending commit - need to put something into the map - for (IProject proj : listProjects()) { + for (IProject proj : getSelectedProjects()) { Repository repo = RepositoryMapping.getMapping(proj).getRepository(); if (!treeMap.containsKey(repo)) treeMap.put(repo, repo.mapTree("HEAD")); @@ -347,7 +345,7 @@ public class CommitAction extends RepositoryAction { } private void buildIndexHeadDiffList() throws IOException { - for (IProject project : listProjects()) { + for (IProject project : getSelectedProjects()) { RepositoryMapping repositoryMapping = RepositoryMapping.getMapping(project); if (repositoryMapping != null) { Repository repository = repositoryMapping.getRepository(); @@ -391,10 +389,6 @@ public class CommitAction extends RepositoryAction { } } - private List listProjects() { - return Arrays.asList(getSelectedProjects()); - } - boolean tryAddResource(IFile resource, GitProjectData projectData, ArrayList category) { if (files.contains(resource)) return false; -- 2.11.4.GIT