From 52415348324f77b4645edc2d8dd0a15d148ec7ec Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Mon, 24 Mar 2008 19:10:06 -0400 Subject: [PATCH] Remove unnecessary selection of TOPO sort in visualizers Both visualizer applications (the history page and glog) require use of a RevPlot instance, which enforces use of TOPO sort and will not allow applications to remove it. Therefore there we do not need these explicit set calls here. Signed-off-by: Shawn O. Pearce --- .../src/org/spearce/egit/ui/internal/history/GitHistoryPage.java | 1 - org.spearce.jgit/src/org/spearce/jgit/pgm/Glog.java | 3 --- 2 files changed, 4 deletions(-) diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/history/GitHistoryPage.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/history/GitHistoryPage.java index 560bb48f..629bdabb 100644 --- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/history/GitHistoryPage.java +++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/history/GitHistoryPage.java @@ -241,7 +241,6 @@ public class GitHistoryPage extends HistoryPage { if (currentWalk == null || currentWalk.getRepository() != db || pathChange(pathFilters, paths)) { currentWalk = new SWTWalk(db); - currentWalk.sort(RevSort.TOPO, true); currentWalk.sort(RevSort.COMMIT_TIME_DESC, true); } else { currentWalk.reset(); diff --git a/org.spearce.jgit/src/org/spearce/jgit/pgm/Glog.java b/org.spearce.jgit/src/org/spearce/jgit/pgm/Glog.java index 2954d33e..8c57e42e 100644 --- a/org.spearce.jgit/src/org/spearce/jgit/pgm/Glog.java +++ b/org.spearce.jgit/src/org/spearce/jgit/pgm/Glog.java @@ -16,7 +16,6 @@ import javax.swing.JScrollPane; import org.spearce.jgit.awtui.CommitGraphPane; import org.spearce.jgit.revplot.PlotWalk; import org.spearce.jgit.revwalk.RevCommit; -import org.spearce.jgit.revwalk.RevSort; import org.spearce.jgit.revwalk.RevWalk; class Glog extends RevWalkTextBuiltin { @@ -56,8 +55,6 @@ class Glog extends RevWalkTextBuiltin { @Override protected int walkLoop() throws Exception { - walk.sort(RevSort.TOPO, true); - graphPane.getCommitList().source(walk); graphPane.getCommitList().fillTo(Integer.MAX_VALUE); -- 2.11.4.GIT