Refactor/rewrite CloneSourcePage to universal RepositorySelectionPage
CloneSourcePage is refactored to serve as generic wizard page for
repository selection. Selection can be performed now as custom URI or
(optionally - configurable) from preconfigured remote repositories. That
allows us to this wizard page for selection of both source and destination
repository in wizards.
As there was need for code rewrite in few places, some things get fixed or
improved by the way:
- Controls are disabled/enabled recursively, so user get better feedback
what he/she can type.
- URI panel behaved strange when bad URI was typed, now it's probably more
obvious what's going on.
- Distinction is introduced between internal URI/RemoteConfig selection
(possibly invalid) and exposed one - for other pages. Hence, clients of
this class don't have to handle internal validation issues.
- isPageComplete() logic is moved to checkPage(), as it seems to be
strange (and hard to follow?) pattern to mix setPageComplete() and
custom isPageComplete().
- possibly minor forgotten issues.
Signed-off-by: Marek Zawirski <marek.zawirski@gmail.com>
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>