Refactor/rewrite CloneSourcePage to universal RepositorySelectionPage
commit3463bb377b4cf7ba46b9cbcc4fd27009aac3d081
authorMarek Zawirski <marek.zawirski@gmail.com>
Sun, 17 Aug 2008 20:43:59 +0000 (17 22:43 +0200)
committerRobin Rosenberg <robin.rosenberg@dewire.com>
Thu, 21 Aug 2008 21:32:20 +0000 (21 23:32 +0200)
tree5dafed5af49d424c8ad0ec7d0cbb4746d6b15d58
parentbb1f20d9899c9a5422b8eee7cca8eacfb29226bf
Refactor/rewrite CloneSourcePage to universal RepositorySelectionPage

CloneSourcePage is refactored to serve as generic wizard page for
repository selection. Selection can be performed now as custom URI or
(optionally - configurable) from preconfigured remote repositories. That
allows us to this wizard page for selection of both source and destination
repository in wizards.

As there was need for code rewrite in few places, some things get fixed or
improved by the way:
- Controls are disabled/enabled recursively, so user get better feedback
  what he/she can type.
- URI panel behaved strange when bad URI was typed, now it's probably more
  obvious what's going on.
- Distinction is introduced between internal URI/RemoteConfig selection
  (possibly invalid) and exposed one - for other pages. Hence, clients of
  this class don't have to handle internal validation issues.
- isPageComplete() logic is moved to checkPage(), as it seems to be
  strange (and hard to follow?) pattern to mix setPageComplete() and
  custom isPageComplete().
- possibly minor forgotten issues.

Signed-off-by: Marek Zawirski <marek.zawirski@gmail.com>
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
org.spearce.egit.ui/src/org/spearce/egit/ui/UIText.java
org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/CloneDestinationPage.java
org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/CloneSourcePage.java [deleted file]
org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/GitCloneWizard.java
org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/SourceBranchPage.java
org.spearce.egit.ui/src/org/spearce/egit/ui/internal/clone/URIishChangeListener.java [deleted file]
org.spearce.egit.ui/src/org/spearce/egit/ui/internal/components/RepositorySelectionListener.java [new file with mode: 0644]
org.spearce.egit.ui/src/org/spearce/egit/ui/internal/components/RepositorySelectionPage.java [new file with mode: 0644]
org.spearce.egit.ui/src/org/spearce/egit/ui/uitext.properties