From 322122c5bfc6caeec9f473972f3e3f13e868cc8f Mon Sep 17 00:00:00 2001 From: Mathias Kinzler Date: Mon, 31 May 2010 17:52:42 +0200 Subject: [PATCH] Missing Push URI A "Remote" configuration should be usable for "Push" even if only a "Fetch" URI has been configured. Bug: 314573 Change-Id: I97e2d4c5991320fb8817cf27778b64e1496943ef Signed-off-by: Mathias Kinzler --- .../egit/ui/internal/components/RepositorySelectionPage.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java index 694e55e8..e080a5f1 100644 --- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java +++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java @@ -555,7 +555,8 @@ public class RepositorySelectionPage extends BaseWizardPage { for (RemoteConfig config : remotes) if ((sourceSelection && !config.getURIs().isEmpty() || !sourceSelection - && !config.getPushURIs().isEmpty())) + && (!config.getPushURIs().isEmpty() || !config.getURIs() + .isEmpty()))) result.add(config); if (!result.isEmpty()) @@ -581,8 +582,11 @@ public class RepositorySelectionPage extends BaseWizardPage { if (sourceSelection) { uris = rc.getURIs(); } else { - // TODO shouldn't this be getPushURIs? uris = rc.getPushURIs(); + // if no push URIs are defined, use fetch URIs instead + if (uris.isEmpty()) { + uris = rc.getURIs(); + } } for (final URIish u : uris) { -- 2.11.4.GIT