| commit | 83b0d70958090625dc5cb8e345a20f18da60f6f7 | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Fri, 12 Dec 2008 22:05:56 +0000 (12 14:05 -0800) | ||
| committer | Robin Rosenberg <robin.rosenberg@dewire.com> | |
| Sat, 13 Dec 2008 02:13:27 +0000 (13 03:13 +0100) | ||
| tree | 9277c23c51d4103eb2ad54a7768e8ede15511b83 | treesnapshot (tar.gz zip) |
| parent | e06b6064f21d3a3ac25d9756759c571892f5d290 | commitdiff |
Use FileMode.MISSING when a file is added or deleted rather than null
Null is better used to indicate "no mode information at all" in the
patch, while FileMode.MISSING is already commonly used within the
TreeWalk code to mean "this path doesn't exist in this tree". In
the context of a patch to create or delete a file, MISSING makes a
lot more sense for the application to work with.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
Null is better used to indicate "no mode information at all" in the
patch, while FileMode.MISSING is already commonly used within the
TreeWalk code to mean "this path doesn't exist in this tree". In
the context of a patch to create or delete a file, MISSING makes a
lot more sense for the application to work with.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>