Removed possibility to change stderr for ssh sessions
commit0114d4c082779d7e5f3f1a04564fc0d149d7b89a
authorConstantine Plotnikov <constantine.plotnikov@gmail.com>
Tue, 21 Apr 2009 18:49:56 +0000 (21 22:49 +0400)
committerShawn O. Pearce <spearce@spearce.org>
Wed, 22 Apr 2009 15:41:35 +0000 (22 08:41 -0700)
treebc1bd2a2de5898d61c1e1a783bdd7d3879837eef
parent1cad78c00514a9968cf51512c99b28bba380d7bf
Removed possibility to change stderr for ssh sessions

The current implementation allowed to change stderr for the
ssh sessions. However this functionality is broken. It is used
only by GitSshTransport and that class expects a very specific
behavior from this class. For example toString() method should
return the entire content of the stream. So only implementation
from SshConfigSessionFactory would have worked anyway. Returning
System.err (as was suggested by javadoc) comment would have broken
existing functionality. This patch makes this functionality
explicitly private.

If this functionality is to be reopened, this additional behavior
should be documented and there should be additional lifecycle
control, since the user streams will be interested to know when
stream will be no more used in order to release resoources.

Signed-off-by: Constantine Plotnikov <constantine.plotnikov@gmail.com>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
org.spearce.jgit/src/org/spearce/jgit/transport/SshConfigSessionFactory.java
org.spearce.jgit/src/org/spearce/jgit/transport/SshSessionFactory.java
org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitSsh.java