Shawn O. Pearce [Mon, 14 Jun 2010 15:29:21 +0000 (14 08:29 -0700)]
Qualify post-0.8.4 builds
Change-Id: Ie2d1ab2a4a481652e46050269806161b894fddb5
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Matthias Sohn [Mon, 14 Jun 2010 13:51:27 +0000 (14 15:51 +0200)]
EGit 0.8.4
Created wrong tags for 0.8.3 hence creating another version.
Change-Id: Ib850faa0f145bc01a50871921bba0a926b0a871e
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Matthias Sohn [Mon, 14 Jun 2010 00:06:16 +0000 (14 02:06 +0200)]
EGit 0.8.3
Change-Id: I3bfc5e4396f10a3db6d138f8265e7ba79c0d1073
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Shawn O. Pearce [Wed, 2 Jun 2010 23:10:46 +0000 (2 16:10 -0700)]
Qualify post 0.8.1 builds
Change-Id: Ia99ef4fc864396a3369e0e99a6d3d0c62c00bbaf
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Shawn O. Pearce [Wed, 2 Jun 2010 22:09:17 +0000 (2 15:09 -0700)]
EGit 0.8.1
Change-Id: I3901b45d428dbf09427cb6c4abb1ad848474905e
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Matthias Sohn [Wed, 2 Jun 2010 00:56:48 +0000 (2 02:56 +0200)]
Update egit help for 0.8.0 from wiki
Change-Id: I1bee00fc75f619e35dc64ccead61a507f58855a8
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Stefan Lay [Tue, 1 Jun 2010 15:13:02 +0000 (1 17:13 +0200)]
Show untracked files per default and remember last selection
The old behaviour was not intuitive. Additionally many users
want to see the untracked files.
Bug: 314997
Change-Id: I87813befb7288f24d4144e09522bda2de5b38e97
Signed-off-by: Stefan Lay <stefan.lay@sap.com>
Mathias Kinzler [Tue, 1 Jun 2010 14:11:25 +0000 (1 16:11 +0200)]
Import wizard does not remember last wizard
The page asking for the wizard to use does not
remember the "last used" wizard if it was the
"New Project" wizard. After fixing this, another
issue was found: when the "New Project" wizard
is selected initially, the tree should be disabled.
Change-Id: I366d177908d90a7f26c46805bc84b00b4cdad2dd
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Mathias Kinzler [Mon, 31 May 2010 15:52:42 +0000 (31 17:52 +0200)]
Missing Push URI
A "Remote" configuration should be usable for "Push" even
if only a "Fetch" URI has been configured.
Bug: 314573
Change-Id: I97e2d4c5991320fb8817cf27778b64e1496943ef
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Shawn O. Pearce [Fri, 28 May 2010 22:07:54 +0000 (28 15:07 -0700)]
Specify the Gerrit Code Review URL in our IP log
This way the IP log record can link back to the actual change in
Gerrit Code Review, improving the cross-linking.
Change-Id: I05df1d9ba6f9d0411cf9e0c568a57fd3a54032a1
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Shawn O. Pearce [Fri, 28 May 2010 21:54:35 +0000 (28 14:54 -0700)]
Denote EGit consumes JGit in the project IP log
Change-Id: I4eae7d73e01a4b94f6789af7c27d15595da733ba
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Shawn O. Pearce [Fri, 28 May 2010 21:32:13 +0000 (28 14:32 -0700)]
Update cache of IPzilla CQ 3905
Change-Id: Iad57647a71410aeb78bc864a56109d4d67138581
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Mathias Kinzler [Fri, 28 May 2010 11:14:44 +0000 (28 13:14 +0200)]
RepositorySearchDialog: String Externalization
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Mathias Kinzler [Fri, 28 May 2010 10:25:40 +0000 (28 06:25 -0400)]
Merge "Extract public class RepositoryCache from GitProjectData"
Mathias Kinzler [Fri, 28 May 2010 10:22:14 +0000 (28 06:22 -0400)]
Merge "Project org.eclipse.egit.doc does not need Java nature"
Matthias Sohn [Fri, 28 May 2010 08:34:37 +0000 (28 10:34 +0200)]
Update EGit eclipse help from wiki
- Update "EGit user guide" from
http://wiki.eclipse.org/EGit/User_Guide
Also include additional git documentation:
- "Git for Eclipse Users" from
http://wiki.eclipse.org/EGit/Git_For_Eclipse_Users
Remove the following wiki pages since they are specific to Eclipse foundation
and not interesting for other Eclipse users:
- "Git at Eclipse" from
http://wiki.eclipse.org/Git
- "Migrating to Git at Eclipse" from
http://wiki.eclipse.org/Git/Migrating_to_Git
Change-Id: I9a664f93910f1bd983786c57223296bceaee1c1a
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Matthias Sohn [Fri, 28 May 2010 08:16:20 +0000 (28 10:16 +0200)]
Project org.eclipse.egit.doc does not need Java nature
This bundle only contains help content and no Java sources so far.
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Stefan Lay [Fri, 28 May 2010 07:17:19 +0000 (28 09:17 +0200)]
Fix SWTBot test: Use ceiling directory
The SharingWizardTest did not work in the maven build.
The test assumes that no git repository is found above
the test project. When the junit-workspace was located
inside a git repository this condition was not fulfilled.
This is fixed using a MockSystemReader and a
ceiling directory.
Change-Id: I25913a2709512e25c211a31d431514561259bf80
Signed-off-by: Stefan Lay <stefan.lay@sap.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Jens Baumgart [Thu, 27 May 2010 16:30:19 +0000 (27 18:30 +0200)]
Extract public class RepositoryCache from GitProjectData
GitProjectData contains a cache for Repository instances.
This cache is used for Reposiotry instances related to
projects. Since there are also Repository instances with no
related project (e.g. in RepositoriesView) the cache was moved
to a public class RepositoryCache to enable sharing Repository
instances even if there is no related project.
Change-Id: I5526362279d87fd6f2651ee991bb08ea4cd65c2b
Signed-off-by: Jens Baumgart <jens.baumgart@sap.com>
Matthias Sohn [Thu, 27 May 2010 16:10:55 +0000 (27 18:10 +0200)]
Make dependency on wikitext bundles optional
We only need the wikitext jars during maven build when updating the help
content from the egit wiki. If these dependencies are not optional the
installation of egit fails on Eclipse installations that do not have
wikitext.
Bug: 314707
Change-Id: Ic340f8ee268fea70c50be34c0072444734911290
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Matthias Sohn [Thu, 27 May 2010 11:06:01 +0000 (27 13:06 +0200)]
Fix RepositorySearchDialog
This fixes the following problems:
1) the filtered tree was rendered twice on the dialog
2) the search result was empty, even if the directory
input field was prefilled with an existing directory
Change-Id: I1df69ee15209f6a565bcdc8d553fe20f9ea159da
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Matthias Sohn [Wed, 26 May 2010 23:51:20 +0000 (27 01:51 +0200)]
Label texts should use sentence case
Bug: 312100
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Stefan Lay [Wed, 26 May 2010 16:22:39 +0000 (26 18:22 +0200)]
Add mnemonics to menus
Eclipse menus should be easily accessible by keyboard.
Mnemonics help the user to directly access the desired
menu item.
Signed-off-by: Stefan Lay <stefan.lay@sap.com>
Chris Aniszczyk [Wed, 26 May 2010 14:20:11 +0000 (26 10:20 -0400)]
Merge "Fix missing support for monitor == null"
Jens Baumgart [Wed, 26 May 2010 13:53:18 +0000 (26 15:53 +0200)]
Fix missing support for monitor == null
Fix implementors of IEGitOperation.execute:
monitor == null is supported now.
Signed-off-by: Jens Baumgart <jens.baumgart@sap.com>
Chris Aniszczyk [Wed, 26 May 2010 13:52:42 +0000 (26 09:52 -0400)]
Merge "Use latest wikitext for help generation and add additional wikis"
Chris Aniszczyk [Wed, 26 May 2010 13:40:41 +0000 (26 09:40 -0400)]
Merge "Retrieve wikitext jars via OSGi dependencies and maven"
Jens Baumgart [Wed, 26 May 2010 12:54:15 +0000 (26 14:54 +0200)]
Fix JavaDoc in IEGitOperation
Fix JavaDoc of method execute.
Bug: 312768
Change-Id: I1f5f329881ce1951dedb566e9e0de01ff1f0973f
Signed-off-by: Jens Baumgart <jens.baumgart@sap.com>
Matthias Sohn [Wed, 26 May 2010 00:54:46 +0000 (26 02:54 +0200)]
Use latest wikitext for help generation and add additional wikis
With wikitext 1.3 the ant script can be simplified heavily. Also add
additional wikis to be included in the EGit documentation.
Change-Id: I3b9fb4bb65fe45d51fdd77e2356c0e722e10377c
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Matthias Sohn [Tue, 25 May 2010 12:00:17 +0000 (25 14:00 +0200)]
Retrieve wikitext jars via OSGi dependencies and maven
Previously the required wikitext binaries were committed into the repository.
Instead we are now downloading them from the wikitext p2-repository during
the build.
Change-Id: I92fb710ad2e7c4d1099686176bdfe6845abd632a
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Robin Rosenberg [Tue, 25 May 2010 22:08:34 +0000 (26 00:08 +0200)]
Silence a javadoc diagnostic with Eclipse 3.4
The FilteredCheckboxTree.getRefreshJobDelay method overrides
a method in Eclipse 3.5, which means it does not require
a javadoc. The project settings reflects and enforces this,
which does not work with Eclipse 3.4 since getRefreshJobDelay
is a new method there and the compiler flags this as an error.
Since this is the only place where this is a problem we create
a javadoc comment instead of relaxing the rules.
Change-Id: I9861336bb7b81d398119d4355e0fe3d303c38b55
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
Chris Aniszczyk [Tue, 25 May 2010 17:45:35 +0000 (25 12:45 -0500)]
Make FilteredCheckboxTree compatible with Eclipse 3.4
When we added FilteredCheckboxTree support to EGit, we broke
compatibility with Eclipse 3.4 by calling a 3.5+ constructor
on FilteredTree. The fix is to call the older constructor.
Change-Id: I1d4ee2fcbf9863b4957f7369843c5a292a8dee93
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
Chris Aniszczyk [Tue, 25 May 2010 16:48:50 +0000 (25 12:48 -0400)]
Merge "Improve JavaDoc of IEGitOperation"
Jens Baumgart [Tue, 25 May 2010 15:44:29 +0000 (25 17:44 +0200)]
Improve JavaDoc of IEGitOperation
JavaDoc of method getSchedulingRule was extended.
Bug: 312768
Signed-off-by: Jens Baumgart <jens.baumgart@sap.com>
Chris Aniszczyk [Tue, 25 May 2010 13:56:34 +0000 (25 09:56 -0400)]
Merge "Improve layout of tagging dialog"
Stefan Lay [Tue, 25 May 2010 10:41:30 +0000 (25 12:41 +0200)]
Fix compare error by checking if blob is contained in commit
Opening compare editor on a deleted file in the file list
of the History View caused a message to be logged. The
reason was that the blob was not found in the commit.
This patch makes use of code that was already available
for other compare actions. To allow for reuse, a new
class CompareUtils is introduced.
Bug: 312852
Signed-off-by: Stefan Lay <stefan.lay@sap.com>
Matthias Sohn [Mon, 24 May 2010 22:32:48 +0000 (25 00:32 +0200)]
Improve layout of tagging dialog
Width of commit selection combo and consequently also the tagging dialog
grew too large if there were commit messages with a long header line.
Also commit selection combo didn't get enough vertical space when opened
initially.
Bug: 314053
Change-Id: Icd65e211968ed87acc3c0e936ac29239a994743a
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Chris Aniszczyk [Mon, 24 May 2010 16:48:54 +0000 (24 11:48 -0500)]
Dialog improvements with TitleAreaDialog
A few of the dialogs were improved by extending TitleAreaDialog
instead of the vanilla JFace Dialog class.
Change-Id: Iec1cf7668e687c0e0e86072bc2eb933d06709667
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
Chris Aniszczyk [Mon, 24 May 2010 16:09:15 +0000 (24 11:09 -0500)]
Use a FilteredTree in BranchSelectionDialog
To improve the usability of the branch selection dialog, we will
add a filtered tree to help users navigate things.
Bug: 314132
Change-Id: If1b9e2ab3a69c1d47d212eb089b644b4af269715
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
Chris Aniszczyk [Mon, 24 May 2010 15:09:21 +0000 (24 10:09 -0500)]
Handle InvalidMergeHeadsException
Change-Id: Idfbaca9dd585dd837478c39ffd385c53980bf9f1
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
Chris Aniszczyk [Mon, 24 May 2010 13:57:02 +0000 (24 08:57 -0500)]
'Label Decorations' preference page has conflicting mnemonics
Bug: 309609
Change-Id: I003fa85ecf1934a02e4b14ff6f788dd69cb11d24
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
Stefan Lay [Thu, 20 May 2010 13:33:33 +0000 (20 15:33 +0200)]
Add action to trigger (fast-forward) merge
Add a new action to the team menu which opens
a merge dialog where a branch can be selected.
Currently jgit supports only fast-forward merges,
therefore the action label is "Fast-forward merge..."
In order to achieve better reuse the BranchSelectionDialog
is refactored.
Change-Id: I3a97d262fd4032d8cc045e94429608b49a937c0f
Signed-off-by: Stefan Lay <stefan.lay@sap.com>
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
Chris Aniszczyk [Mon, 24 May 2010 02:00:53 +0000 (23 21:00 -0500)]
RepositorySearchDialog improvements
The repository search dialog was improved to take advantage of
a new FilteredCheckboxTree. The layout of the dialog itself
was also improved.
Change-Id: Icd3b3e5d5c6ae136c44b9e70c53d73e10759a0a4
Dariusz Luksza [Sat, 22 May 2010 12:18:03 +0000 (22 14:18 +0200)]
Add tag icon for tags in tag list in CrateTagDialog
Adds tag icon for each tag that is in 'Existing tags' list in
CreateTagDialog.
Change-Id: Ib11cdcc7df976368fa64d6d26a5de339864cb57e
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
Mathias Kinzler [Fri, 21 May 2010 08:08:41 +0000 (21 10:08 +0200)]
Git Repostiories View: add context menu for fetch and push wizards
This makes the fetch and push wizards available from the Git Repositories View.
Change-Id: If8fb891ca4d4a79c00e4774ba0ef0382fee58654
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Stefan Lay [Fri, 21 May 2010 15:27:13 +0000 (21 17:27 +0200)]
Perform commit in a Job
Put the commit logic into a new CommitOperation.
Run the CommitOperation in a Job and report
progress. Allow for canceling before the index is
written to disk.
Bug: 313858
Signed-off-by: Stefan Lay <stefan.lay@sap.com>
Chris Aniszczyk [Fri, 21 May 2010 00:58:32 +0000 (20 19:58 -0500)]
Add new icons for track and untracking changes.
The old icons weren't representative enough of tracking. The
icons were updated to use glasses to represent tracking.
Change-Id: Ib6125cb9f3d730d08b5b2a2cb043a909675b1f8d
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
Chris Aniszczyk [Fri, 21 May 2010 00:55:56 +0000 (20 20:55 -0400)]
Merge "Better icon for assume unchanged action"
Matthias Sohn [Thu, 20 May 2010 15:38:58 +0000 (20 17:38 +0200)]
Better icon for assume unchanged action
A green plus doesn't imply that changes will not be considered.
Also already provide the icon for the no-assume-unchanged action
which isn't available yet.
Change-Id: I61a3bcd8e77b375dc6a1cc7a85847527895c0167
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Chris Aniszczyk [Thu, 20 May 2010 15:21:19 +0000 (20 11:21 -0400)]
Merge "Git Label Decorations of "detached" HEAD"
Matthias Sohn [Thu, 20 May 2010 12:02:17 +0000 (20 08:02 -0400)]
Merge "Git Repositories View: avoid parallel scheduling of auto-update job"
Mathias Kinzler [Thu, 20 May 2010 06:49:51 +0000 (20 08:49 +0200)]
Git Repositories View: use the new, cool icons
This does away with the ugly import/export icons for visualizing
push/fetch specifications by replacing them with the new ones. It also
adds a new icon for the "Remote specification" node.
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Mathias Kinzler [Wed, 19 May 2010 18:36:39 +0000 (19 20:36 +0200)]
Remove Unused Texts from UIText.java and corresponding properties
Bug: 309552
Change-Id: Ib8153b55c5479a37dd2dc617e7f0a287671e56c4
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
Mathias Kinzler [Wed, 19 May 2010 18:40:13 +0000 (19 20:40 +0200)]
Git Repositories View: avoid parallel scheduling of auto-update job
If the update takes longer than the auto-update refresh rate, the current
implementation will schedule the update job even if the last one is still running.
This checks if an auto-update job is already running and simply skips this
auto-update.
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Chris Aniszczyk [Wed, 19 May 2010 17:47:56 +0000 (19 12:47 -0500)]
Icon and menu cleanup
The current set of menu entries lack icons and aren't
organized in a coherent manner. This commit restructures
the order of the team menu entries and adds icons.
Bug: 313588
Change-Id: Iab813336f66328f5a3b7b2e3dbfffc1e79c1d094
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
Mathias Kinzler [Wed, 19 May 2010 09:41:19 +0000 (19 11:41 +0200)]
Git Repositories View: Simple fetch and push
This allows to execute fetch and push by a simple context menu on the
fetch/push specification in the Git Repositories View.
The actions provided here might also be helpful for
Bug: 312586
Change-Id: I275a0c01c0fcec3e7e9a9d4e5c1b3d3a03df940d
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Mathias Kinzler [Wed, 19 May 2010 05:40:23 +0000 (19 07:40 +0200)]
Change UIText.java so that "Find Broken Externalized Strings" works
The current implementation of UIText.java has the bundle name
inlined. Unfortunately, this results in the "Source->Find Broken Externalized
String" workbench action to not find any unused or otherwise inconsistent
keys (an info dialog is displayed saying "No NLS properties files found...".
This fix does not actually fix inconsistencies in the externalized Strings, just
enables the tool to find such inconsistencies (there are currently 42 unused keys
in the UIText.java).
Bug: 309552 (not completed, just as preparation)
Change-Id: I59d831cf1bce49cdc4043232277ec1c862fbce02
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Mathias Kinzler [Tue, 18 May 2010 16:52:48 +0000 (18 18:52 +0200)]
Git Repositories View: auto-refresh
This addresses the bug below, but in a more general manner:
a periodic (every 10 seconds) job will look for Repository changes
and refresh the tree if such changes are found.
Bug: 312993
Change-Id: Iee00e1ca7fbf865e4fd59acc904803ded933b3df
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Mathias Kinzler [Tue, 18 May 2010 17:27:39 +0000 (18 19:27 +0200)]
Git Label Decorations of "detached" HEAD
In the case of "detached" HEAD, currently, there is only
the commit ID (truncated) shown in the Project label decoration.
This fix implements the suggestions collected in a mail thread
on the egit-dev mailing list by adding the information which
tag or remote branch is pointing to the currently checked out
branch.
Change-Id: I70c791f9552c6201b1c66488ab45f8186ec4c28d
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Mathias Kinzler [Tue, 18 May 2010 06:31:00 +0000 (18 08:31 +0200)]
Git Repositories View: fix Branch Creation page
Only local branches can be created directly. This fix
adjusts the BranchCreation page accordingly which
wrongly suggest to the end user they can create
remote branches.
Change-Id: I7cfc69d9fbae9299c7c2f5f3e86f4ae587503340
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Matthias Sohn [Tue, 18 May 2010 14:44:18 +0000 (18 10:44 -0400)]
Merge "BranchSelectionDialog: allow check-out of tags"
Mathias Kinzler [Tue, 18 May 2010 09:16:22 +0000 (18 05:16 -0400)]
Merge "Add a SWTBot test case for the sharing wizard"
Stefan Lay [Tue, 18 May 2010 08:50:49 +0000 (18 04:50 -0400)]
Merge "Prevent NPE when comparing an untracked file with the index"
Stefan Lay [Tue, 18 May 2010 08:42:39 +0000 (18 10:42 +0200)]
Add a SWTBot test case for the sharing wizard
Add a UI test for the simplest scenario: create a
repository and share a project from the wizard.
Change-Id: I7827ed6f5987a8d4a97ff0ca414ee56b92e1c5b4
Signed-off-by: Stefan Lay <stefan.lay@sap.com>
Mathias Kinzler [Tue, 18 May 2010 06:53:56 +0000 (18 08:53 +0200)]
BranchSelectionDialog: allow check-out of tags
Since tags can now be checked out properly, this offers the checkout for tags on the Branch Selection dialog.
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Chris Aniszczyk [Mon, 17 May 2010 17:22:47 +0000 (17 13:22 -0400)]
Merge "Git Repositories View: allow tag check-out"
Remy Suen [Mon, 17 May 2010 10:13:02 +0000 (17 06:13 -0400)]
Prevent NPE when comparing an untracked file with the index
The compare request does not currently check whether a file is in
the index before displaying the compare editor. This causes
problems when the editor tries to ask the revision for its content
and JGit is unable to return something meaningful here because a
blob cannot actually be found. The fix is to check if an entry
actually exists in the index before trying to create a compare
editor input from it.
Change-Id: I9a1b8bd39aded3dcdeaf523b735f5fcf66f8d152
Stefan Lay [Mon, 17 May 2010 09:24:54 +0000 (17 05:24 -0400)]
Merge "Precheck selected files in the commit dialog"
Mathias Kinzler [Mon, 17 May 2010 06:29:42 +0000 (17 08:29 +0200)]
Git Repositories View: allow tag check-out
Tags can now be checked out properly. This fix
enables the check-out on tag nodes in the Git
Repositories View (also on double-click on a tag
node).
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Chris Aniszczyk [Mon, 17 May 2010 03:17:16 +0000 (16 23:17 -0400)]
Merge "Ignore secondary mouse clicks in the 'History' view's hyperlinks"
Chris Aniszczyk [Mon, 17 May 2010 03:15:46 +0000 (16 23:15 -0400)]
Merge "Improve error validation in the patch wizard"
Robin Rosenberg [Sun, 16 May 2010 08:12:24 +0000 (16 04:12 -0400)]
Merge "'Git' property page does not need 'Default' and 'Apply' buttons"
Remy Suen [Fri, 14 May 2010 22:34:54 +0000 (14 18:34 -0400)]
Improve error validation in the patch wizard
Currently, no error messages are presented to the user for invalid
input into the wizard. This is very unhelpful as the user may not
know what is wrong with their input. Switching to the clipboard
mode may also not clear the error message due to an error in the
validation logic. To also help prevent the user from entering data
that may not end up being processed, controls are now enabled and
disabled based on which radio button has been selected.
Change-Id: I50998266c213deabec4a01a44024d95015a56b55
Remy Suen [Fri, 14 May 2010 10:30:55 +0000 (14 06:30 -0400)]
'Git' property page does not need 'Default' and 'Apply' buttons
The 'Git' property page currently only shows read-only information
to the user. As there is no state information on this property
page, the 'Default' and 'Apply' buttons should be removed.
Change-Id: Id706859173a6bd9f11f4adebf78d1e03579621a1
Remy Suen [Fri, 14 May 2010 10:02:02 +0000 (14 06:02 -0400)]
Improve the patch wizard's text and image enhance its presentation
The wording of certain messages has been corrected and mnemonics
has been introduced to enhance accessibility. The wizard now also
uses the same title area image that the CVS plug-in uses.
Change-Id: Ia4777f18c5aec73983ceebb9ff12553cd24a2c20
Robin Rosenberg [Fri, 14 May 2010 05:38:09 +0000 (14 01:38 -0400)]
Merge "Relax constructor parameters of EGit operations"
Remy Suen [Fri, 14 May 2010 00:01:39 +0000 (13 20:01 -0400)]
Precheck selected files in the commit dialog
The commit dialog presents all local modifications of files but
does not respect the user's selection. The dialog should precheck
any files that the user has selected and any files that are in any
folders that the user has selected.
Bug: 304131
Change-Id: I1a0f73641b5bd5603b9fbde8fc25eb310976b3e0
Remy Suen [Thu, 13 May 2010 22:52:47 +0000 (13 18:52 -0400)]
Ignore secondary mouse clicks in the 'History' view's hyperlinks
Only the primary mouse click should be acknowledged as a request
to jump to another commit when browsing commits in the 'History'
view. At the moment, users that want to select the commit id and
copy the id to the clipboard through the context menu might
actually end up jumping to the selected commit as the secondary
mouse click is processed as a hyperlink request.
Change-Id: I8351cbda039419160e6731e307fa7243a3be90d4
Remy Suen [Thu, 13 May 2010 02:37:10 +0000 (12 22:37 -0400)]
Relax constructor parameters of EGit operations
Certain EGit operations takes a Collection<IResource> as a
parameter in its constructor. The problem with this type is that
one cannot pass in a Collection<IFile> or a Collection<IFolder>.
Instead, you are forced to alter your existing collection into one
for IResources. The fix is to alter these constructors so that they
take a Collection<? extends IResource> instead.
Change-Id: I93acf875107596b7eb08d76aaf69f13ed0cab524
Dariusz Luksza [Sun, 11 Apr 2010 20:25:44 +0000 (11 22:25 +0200)]
Add tagging UI support
Implements UI for unsigned and annotated tags. This implementation
allows the user to select which commit object should be associated with
created tag. List of all commits is available in the 'Advanced' section
of the dialog. There is a special combo widget that can suggest commits
based on match of typed-in text with commit SHA-1 or part of first line
of existing commit messages.
User can also edit/overwrite tag message or associated commit of an existing
tag by selecting it from the list of existing tags and marking the
'Force replace existing tag' check box.
By default tag is created for current HEAD, this can be changed in the
'Advanced' section.
The tag dialog is available in project's context menu ('Team->Tag...').
[ms]: rebased to master and resolved conflict
CQ: 4073
Bug: 311262
Change-Id: Icb30655845d1e1198e59992a10148421ab9f9bd5
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Mathias Kinzler [Tue, 11 May 2010 09:17:24 +0000 (11 11:17 +0200)]
Git Repositories View: Bare Repositoy Support
The following actions are disabled for a "bare" repository:
- checkout of branches
- browsing the working directory
- import of projects
The "bare"-ness of a Repository is visualized in the "Working Directoy" node
which displays "This is a bare Repository" instead of the working directory.
Bug: 311919
Change-Id: Ib698326233dee88b7a25bda7484b76b068c33a6c
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Chris Aniszczyk [Wed, 12 May 2010 17:27:00 +0000 (12 13:27 -0400)]
Merge "Git RepositoriesView: fix Label Provider"
Stefan Lay [Wed, 12 May 2010 15:23:15 +0000 (12 17:23 +0200)]
Fix NullPointer in "Compare with each other"
The Exception was thrown in the HistoryView,
"Compare with each other":
When the file did not exist in the newer one of the
two commits there was a NullPointer Exception.
Bug: 312644
Signed-off-by: Stefan Lay <stefan.lay@sap.com>
Jens Baumgart [Wed, 12 May 2010 12:25:05 +0000 (12 14:25 +0200)]
History View: sub menus for reset and quick diff
Add sub menus to the context menu of the history
view to improve the usability of the menu.
Reset
Hard
Mixed
Soft
Quick Diff
Reset Baseline to first Parent of HEAD
Reset Baseline to HEAD
Set as Baseline
Change-Id: I0cd088b3ea3d39be087607a33b627129e5b04cba
Signed-off-by: Jens Baumgart <jens.baumgart@sap.com>
Mathias Kinzler [Wed, 12 May 2010 12:58:17 +0000 (12 14:58 +0200)]
Git RepositoriesView: fix Label Provider
The label provider must be fixed with respect to the "checked out"-decoration.
Currently, this only works if a local branch is checked out. The fix makes the
decoration work also if a tag or remote branch is checked out.
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Ryan Schmitt [Wed, 12 May 2010 09:30:54 +0000 (12 11:30 +0200)]
Removed checkedItems field from GitProjectsImportPage
The checkedItems field has been removed from GitProjectsImportPage,
and a getCheckedProjects method has been added instead, which computes
the set of checked projects based on information available from the UI
widgets.
This fixes at least one bug that was affecting my work: unchecking projects
by using the spacebar didn't work, because there was no KeyListener in place
to update the checkedItems field. This lead to the project being unchecked
in the UI, but still considered checked by the wizard page, and upon
clicking Finish, the wizard would try to import all of those unchecked
projects.
[ms]:
- split off extraction of ProjectRecord into separate change
- ported change to current master
- added Ryan's copyright
Bug: 308284
Change-Id: I5c0889e9f6e95c2c62d96195623499802ce701a1
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Signed-off-by: Ryan Schmitt <ryan.schmitt@boeing.com>
Matthias Sohn [Wed, 12 May 2010 08:38:58 +0000 (12 10:38 +0200)]
Remove dead code from ProjectRecord and GitProjectsImportPage
The IImportStructureProvider passed to ProjectRecord was always null and
hence had no effect. The constructor ProjectRecord(Object, int) is
obsolete and no longer used. Therefore removing this dead code.
Change-Id: I9937c06217c855e3f8cf2391de4849636fa3e4af
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Ryan Schmitt [Wed, 12 May 2010 08:11:39 +0000 (12 10:11 +0200)]
Refactored GitProjectsImportPage
Extract inner class ProjectRecord to improve readability.
[ms] : rebased to current master
Change-Id: Iec631ae27610ccf147c4ac3445aead9d017b07ef
Signed-off-by: Ryan Schmitt <ryan.schmitt@boeing.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Mathias Kinzler [Wed, 12 May 2010 06:28:13 +0000 (12 08:28 +0200)]
Branch Selection Dialog UI improvements
The dialog shown for Team->Branch... and Team->Reset To... was
reworked to re-use the same tree as the Git Repositories view.
Change-Id: I68eb12f7c6d7b46488650e635639772a95a88e90
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Stefan Lay [Tue, 11 May 2010 15:40:16 +0000 (11 17:40 +0200)]
Show "Create Patch..." context menu entry in history view
The menu entry is shown in history view and not in the package
explorer as in CVS. The reason is that when you use a distributed
versioning system you normally commit your local changes
to a local branch before you create a patch.
When one commit is selected in the commit list, the diff to
its parent can be saved to a file or stored in the clipboard.
The file filter of the history view is used.
It is not possible to create patch files for the first commit and
for merge commits.
Per default the wizard creates a patch with a format which can
be applied with the eclipse apply patch wizard: The paths to the
files have no prefixes (as with git format-patch --no-prefix) and
they are relative to the eclipse project and not to the repository.
There is an option to create a patch which can be applied with
"git apply" on the command line (Not yet in eclipse.).
There may be more options in the future on the Options page.
Before more options are offered the diff rendering code should
be moved to jgit.
[ms]
- fixed some style nits
- reduced initial wizard height
Bug: 297636
Change-Id: I8d53a4c7685df75887ad6ec80aeda22dbb31e01f
Signed-off-by: Stefan Lay <stefan.lay@sap.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Chris Aniszczyk [Tue, 11 May 2010 18:29:35 +0000 (11 14:29 -0400)]
Merge "BranchOperation: fix checkout for tags and remote branches"
Matthias Sohn [Tue, 11 May 2010 15:10:33 +0000 (11 11:10 -0400)]
Merge "LabelDecoration should show ellipsis if HEAD is on a commit"
Chris Aniszczyk [Tue, 11 May 2010 14:55:45 +0000 (11 10:55 -0400)]
Merge "Use jgit p2 repository to resolve jgit dependencies"
Matthias Sohn [Tue, 11 May 2010 13:44:59 +0000 (11 15:44 +0200)]
BranchOperation: fix checkout for tags and remote branches
The current implementation wrongly changes the HEAD
ref to point to the remote branch instead of to the underlying
commit. Support for tags is not working at all.
This fixes both issues.
Bug: 312053
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Matthias Sohn [Tue, 11 May 2010 12:52:15 +0000 (11 14:52 +0200)]
Use jgit p2 repository to resolve jgit dependencies
EGit Tycho builds on build.eclipse.org frequently hit corrupted artifacts
which leads to broken builds. Cleaning up these corrupted files is tedious
since it requires file system access on the build server. Hence we want to
switch to use job-local m2 repositories. This requires that build artifacts
are shared between the jgit and egit build jobs via p2. Therefore we switch
from pom-first to p2 build dependencies between the egit and the jgit build.
For local builds the egit build assumes that jgit and egit are located
under a common parent folder. If this is not the case the URL of the jgit
update site has to be injected via system property "jgit-site".
- non-default local build:
$ mvn clean install -Djgit-site=file:/path/to/org.eclipse.jgit.updatesite/target/site
- hudson build on build.eclipse.org
$ mvn clean install -Djgit-site=https://build.eclipse.org/hudson/job/jgit/
lastSuccessfulBuild/artifact/org.eclipse.jgit.packaging/
org.eclipse.jgit.updatesite/target/site/
Change-Id: I43ee21f23d474a6579df187869c821fc3960583f
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Jens Baumgart [Tue, 11 May 2010 08:59:10 +0000 (11 10:59 +0200)]
Move UpdateJob to UpdateOperation
UpdateOperation currently schedules UpdateJob.
This is not needed since UpdateOperation itself
is scheduled as Job. Thus UpdateJob was integrated
in UpdateOperation.
Signed-off-by: Jens Baumgart <jens.baumgart@sap.com>
Mathias Kinzler [Fri, 7 May 2010 12:18:22 +0000 (7 14:18 +0200)]
LabelDecoration should show ellipsis if HEAD is on a commit
Bug: 311364
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
Matthias Sohn [Mon, 10 May 2010 19:45:12 +0000 (10 21:45 +0200)]
Replace org.apache.log4j package import by bundle dependency
Tycho picks some org.slf4j bundles to satisfy our package dependency
to org.apache.log4j needed to run swtbot tests. This caused a
NoClassDefFoundError due to some additional dependencies slf4j has.
Switching to a bundle dependency fixes this problem.
Change-Id: Ib9e70312bcdd591ec874cea0d10140300446cf93
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
Chris Aniszczyk [Mon, 10 May 2010 18:56:07 +0000 (10 14:56 -0400)]
Merge "Fix RepositoriesViewLabelProvider"
Mathias Kinzler [Mon, 10 May 2010 17:21:19 +0000 (10 19:21 +0200)]
Fix RepositoriesViewLabelProvider
If there are two branches with the same shortened name (e. g. a local
and a remote "master" branch), the current implementation wrongly
marks both of them as "checked out" if one of them is checked out.
The fix looks for the full branch name instead of the shortened name
in order to determine whether the icon should be decorated.
Change-Id: Ib6652732cfecfa762c0aa810cb4a5226b46fc27b
Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>