Don't rely on default locale when using toUpperCase() and toLowerCase()
commitdaca0edba32687fe8a777df0da487da017f601e0
authorMatthias Sohn <matthias.sohn@sap.com>
Sat, 28 Jan 2017 14:10:20 +0000 (28 15:10 +0100)
committerMatthias Sohn <matthias.sohn@sap.com>
Mon, 30 Jan 2017 21:53:28 +0000 (30 22:53 +0100)
tree56bd750dcdf1abfcdc5aab2129e261ab2a094783
parent76acd28a6f4d0f38a8a6f5a8c3c347155917ff26
Don't rely on default locale when using toUpperCase() and toLowerCase()

Otherwise these methods may produce unexpected results if used for
strings that are intended to be interpreted locale independently.
Examples are programming language identifiers, protocol keys, and HTML
tags. For instance, "TITLE".toLowerCase() in a Turkish locale returns
"t\u0131tle", where '\u0131' is the LATIN SMALL LETTER DOTLESS I
character.

See
https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#toLowerCase--
http://blog.thetaphi.de/2012/07/default-locales-default-charsets-and.html

Bug: 511238
Change-Id: I5619ce1bde33d6ce2469506a915af9203bae0314
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/ConnectProviderOperationTest.java
org.eclipse.egit.core/src/org/eclipse/egit/core/op/CreatePatchOperation.java
org.eclipse.egit.core/src/org/eclipse/egit/core/op/ResetOperation.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/search/CommitSearchQueryTest.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/ResourcePropertyTester.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java