| commit | c715f4fcedca66cde53553c78528fc828d8ab194 | |
| author | Thomas Wolf <thomas.wolf@paranor.ch> | |
| Sun, 6 Sep 2015 16:31:40 +0000 (6 18:31 +0200) | ||
| committer | Matthias Sohn <matthias.sohn@sap.com> | |
| Mon, 7 Sep 2015 06:07:56 +0000 (7 08:07 +0200) | ||
| tree | a12b2ede031a76b628aeeb42bb166a09418a856d | treesnapshot (tar.gz zip) |
| parent | dd7faf5b10769e8d5fb408137ff86a442d2b0e46 | commitdiff |
SpellcheckableMessageArea.setText() must not bypass document
The sourceViewer uses an IDocument. Directly manipulating the text in
the SWT widget used to display this document may bypass all kinds of
JFace infrastructure, for instance hyperlinking. Definitely not good.
Bug: 337288
Change-Id: Iebe30f7101540996c515d62fa9e978082cf1bd63
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
The sourceViewer uses an IDocument. Directly manipulating the text in
the SWT widget used to display this document may bypass all kinds of
JFace infrastructure, for instance hyperlinking. Definitely not good.
Bug: 337288
Change-Id: Iebe30f7101540996c515d62fa9e978082cf1bd63
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
| org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/SpellcheckableMessageArea.java | diffblobblamehistory |