Change singletons to enumeration literals
commita3c2f76211643062a0529a7afc8474345f39994e
authorThomas Wolf <thomas.wolf@paranor.ch>
Wed, 14 Jul 2021 11:42:32 +0000 (14 13:42 +0200)
committerThomas Wolf <thomas.wolf@paranor.ch>
Wed, 14 Jul 2021 12:55:10 +0000 (14 14:55 +0200)
tree8eced36a180deada20570159ec30846c36c0a203
parent5330bc5c6d874fe692161e1e8c25aab000b51d4e
Change singletons to enumeration literals

Use enumeration literals for the RepositoryCache, IndexDiffCache,
RepositoryUtil, and RepositoryGroups singletons to ensure their
initialization is thread-safe.

Bug: 574806
Change-Id: I54def946ec3b708366c1f4b73f5aead531f0142b
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
176 files changed:
org.eclipse.egit.core.junit/src/org/eclipse/egit/core/test/DualRepositoryTestCase.java
org.eclipse.egit.core.junit/src/org/eclipse/egit/core/test/GitTestCase.java
org.eclipse.egit.core.junit/src/org/eclipse/egit/core/test/TestRepository.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/GitMoveDeleteHookTest.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/ProjectReferenceImporterTest.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffCacheTest.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/storage/GitBlobStorageTest.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/GitProjectSetCapabilityTest.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/LinkedResourcesTest.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/RepositoryCacheTest.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/SubmoduleAndContainerTreeIteratorTest.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/DeletePathsOperationTest.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/ListRemoteOperationTest.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/PushOperationTest.java
org.eclipse.egit.core/src/org/eclipse/egit/core/GitMoveDeleteHook.java
org.eclipse.egit.core/src/org/eclipse/egit/core/RepositoryCache.java
org.eclipse.egit.core/src/org/eclipse/egit/core/RepositoryInitializer.java
org.eclipse.egit.core/src/org/eclipse/egit/core/RepositoryUtil.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/GitRepositoryProviderType.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/ProjectReferenceImporter.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/ResourceRefreshHandler.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/efs/EgitFileSystem.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/gerrit/GerritUtil.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/GitResourceDeltaVisitor.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffCache.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffCacheEntry.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/info/GitItemStateFactory.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/rebase/RebaseInteractivePlan.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/start/WorkspaceConnector.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/storage/CommitBlobStorage.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/storage/IndexBlobStorage.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/util/ResourceUtil.java
org.eclipse.egit.core/src/org/eclipse/egit/core/op/CommitOperation.java
org.eclipse.egit.core/src/org/eclipse/egit/core/op/ConnectProviderOperation.java
org.eclipse.egit.core/src/org/eclipse/egit/core/op/DeletePathsOperation.java
org.eclipse.egit.core/src/org/eclipse/egit/core/op/IgnoreOperation.java
org.eclipse.egit.core/src/org/eclipse/egit/core/op/SubmoduleUpdateOperation.java
org.eclipse.egit.core/src/org/eclipse/egit/core/project/GitProjectData.java
org.eclipse.egit.core/src/org/eclipse/egit/core/settings/GitSettings.java
org.eclipse.egit.core/src/org/eclipse/egit/core/synchronize/GitSubscriberMergeContext.java
org.eclipse.egit.gitflow.test/src/org/eclipse/egit/gitflow/op/AbstractDualRepositoryTestCase.java
org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/actions/FeatureCheckoutHandler.java
org.eclipse.egit.gitflow.ui/src/org/eclipse/egit/gitflow/ui/internal/properties/RepositoryPropertyTester.java
org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/CommitHyperlinkDetector.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/JavaProjectTester.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/LocalRepositoryTestCase.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/common/WorkingCopyPage.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/gitflow/CommandEnablementTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/httpauth/PushTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/CompareUtilsTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/branch/BranchProjectTrackerTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/decorators/DecoratableResourceAdapterTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/decorators/DecoratableResourceMappingTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/decorators/DecoratableWorkingSetTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/selection/SelectionForViewsTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/submodules/SubmoduleFolderTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelBlobTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelCacheFileTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelCacheTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelCacheTreeTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelCommitTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelRepositoryTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelTreeTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelWorkingFileTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelWorkingTreeTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/operations/GitScopeUtilTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/search/CommitSearchDialogTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/search/CommitSearchQueryTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/submodule/SubmoduleAddTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/submodule/SubmoduleSyncTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/submodule/SubmoduleUpdateTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/commit/CommitEditorInputFactoryTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/commit/CommitEditorInputTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/commit/CommitEditorTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/commit/DiffRegionFormatterTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/commit/RepositoryCommitTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/history/GitHistoryRefFilterConfigurationDialogTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/history/HistoryViewTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/history/RefFilterHelperTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/stagview/AbstractStagingViewTestCase.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/stagview/StagingViewTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/team/actions/BranchAndResetActionTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/team/actions/CommitNonWSChangesTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/team/actions/MergeToolTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/variables/DynamicVariablesTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewBranchHandlingTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewFetchAndPushTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewRemoteHandlingTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewRepoDeletionTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewRepoHandlingTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewTagHandlingTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewTestUtils.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/synchronize/AbstractSynchronizeViewTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/pull/PullWizardTest.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/ExternalRepositoryScanner.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/GitLabels.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/UIRepositoryUtils.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/CommitActionHandler.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/MergeToolActionHandler.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/RebaseAction.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/ReplaceConflictActionHandler.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/RepositoryGroupsMenu.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/StashCreateHandler.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/SwitchToMenu.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/BranchOperationUI.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/MultiBranchOperationResultDialog.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clean/CleanWizard.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/AbstractGitCloneWizard.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitImportWizard.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitSelectRepositoryPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/shared/AbstractRebaseCommandHandler.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitEditor.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitEditorInputFactory.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitSelectionDialog.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositoryMenuUtil.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/decorators/DecoratorRepositoryStateCache.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/decorators/GitDecorator.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/AbstractBranchSelectionDialog.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/BranchSelectionAndEditDialog.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CheckoutDialog.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommandConfirmation.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/ResetTargetSelectionDialog.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/factories/GitAdapterFactory.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/fetch/FetchDestinationPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/fetch/FetchGerritChangePage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/gerrit/GerritConfigurationPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/gerrit/GerritSelectRepositoryPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/groups/RepositoryGroups.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GenerateHistoryJob.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryWalk.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/RefFilterHelper.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/jobs/RepositoryJobResultAction.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/merge/AbstractGitMergeEditorInput.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/merge/GitCompareEditorInput.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/merge/GitMergeEditorInput.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/operations/GitScopeOperation.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/operations/IgnoreOperationUI.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/patch/PatchOperationUI.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/GlobalConfigurationPreferencePage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/pull/MultiPullResultDialog.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/pull/PullOperationUI.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/pull/PullResultDialog.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushToGerritPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveView.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/reflog/ReflogView.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/CreateBranchPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/DropAdapterAssistant.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/FilterCache.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/NewRepositoryWizard.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoriesView.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoriesViewContentProvider.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoryTreeNodeDecorator.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/RepositoryGroupNode.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/AddCommand.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/CreateRepositoryGroupCommand.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/DeleteRepositoryConfirmDialog.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/DeleteRepositoryGroupCommand.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/DeleteRepositoryGroupConfirmDialog.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/PasteCommand.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/RemoveCommand.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/RemoveOrDeleteRepositoryCommand.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/RepositoriesViewCommandHandler.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ResetCommand.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/SubmoduleUpdateCommand.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/search/CommitSearchPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/search/CommitSearchQuery.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/selection/SelectionPropertyTester.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/sharing/ExistingOrNewPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/sharing/RepoComboContentProvider.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/sharing/RepoComboLabelProvider.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/sharing/SharingWizard.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/compare/LocalNonWorkspaceTypedElement.java