| commit | 7fc2a098afdc40110c9606cc8d89c059e56f6f74 | |
| author | Thomas Wolf <thomas.wolf@paranor.ch> | |
| Sun, 13 May 2018 19:30:04 +0000 (13 21:30 +0200) | ||
| committer | Thomas Wolf <thomas.wolf@paranor.ch> | |
| Sun, 13 May 2018 19:30:04 +0000 (13 21:30 +0200) | ||
| tree | a761582ddf313ea7122f83614a86374cdd5f260c | treesnapshot (tar.gz zip) |
| parent | 71cc0b751951f2532ef89a28de9a9f167d0014dd | commitdiff |
Natural sort for tags in CreateTagDialog
Give the tag viewer a comparator, and change the label provider
from an ITableLabelProvider to a simple LabelProvider. The viewer
has one column only anyway, and with the previous label provider
implementation, the comparer wouldn't work. The viewer would use
getColumnText(), but the ViewerComparator would use the inherited
getText() from WorkbenchLabelProvider, which always returns the
empty string since the elements don't adapt to IWorkbenchAdapter.
Bug: 529449
Change-Id: Ib1371f13c80334a9f41246fc96134f3c99198fb4
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
Give the tag viewer a comparator, and change the label provider
from an ITableLabelProvider to a simple LabelProvider. The viewer
has one column only anyway, and with the previous label provider
implementation, the comparer wouldn't work. The viewer would use
getColumnText(), but the ViewerComparator would use the inherited
getText() from WorkbenchLabelProvider, which always returns the
empty string since the elements don't adapt to IWorkbenchAdapter.
Bug: 529449
Change-Id: Ib1371f13c80334a9f41246fc96134f3c99198fb4
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
| org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CreateTagDialog.java | diffblobblamehistory |