refactor: simplify collection.toArray()
commit7e54c44063ed9769a9d3c443799c52d4b2989cfd
authorMichael Keppler <Michael.Keppler@gmx.de>
Mon, 6 Aug 2018 12:10:12 +0000 (6 14:10 +0200)
committerThomas Wolf <thomas.wolf@paranor.ch>
Mon, 13 Aug 2018 16:35:35 +0000 (13 12:35 -0400)
treef860a4245b256b885b031173130fea59852fc127
parentdcc38081a23dedcc855b0abfa6f14253b93a5626
refactor: simplify collection.toArray()

On recent VMs, collection.toArray(new T[0]) is faster than
collection.toArray(new T[collection.size()]). Since it is also more
readable, it should now be the preferred way of collection to array
conversion.

https://shipilev.net/blog/2016/arrays-wisdom-ancients/

Change-Id: If0c3202aa3ebb2d4e4ea68da8fe431cd8f363826
Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
76 files changed:
org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/models/ModelTestCase.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/models/SampleResourceMapping.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/CommitOperationTest.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/PushOperationTest.java
org.eclipse.egit.core.test/src/org/eclipse/egit/core/test/op/TrackUntrackOperationTest.java
org.eclipse.egit.core/src/org/eclipse/egit/core/GitProjectSetCapability.java
org.eclipse.egit.core/src/org/eclipse/egit/core/RepositoryCache.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffCache.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffCacheEntry.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/job/RuleUtil.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/storage/CommitFileRevision.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/util/ProjectUtil.java
org.eclipse.egit.core/src/org/eclipse/egit/core/internal/util/ResourceUtil.java
org.eclipse.egit.core/src/org/eclipse/egit/core/op/AddToIndexOperation.java
org.eclipse.egit.core/src/org/eclipse/egit/core/op/AssumeUnchangedOperation.java
org.eclipse.egit.core/src/org/eclipse/egit/core/op/BranchOperation.java
org.eclipse.egit.core/src/org/eclipse/egit/core/op/ConnectProviderOperation.java
org.eclipse.egit.core/src/org/eclipse/egit/core/op/DisconnectProviderOperation.java
org.eclipse.egit.core/src/org/eclipse/egit/core/op/UntrackOperation.java
org.eclipse.egit.core/src/org/eclipse/egit/core/synchronize/GitLazyResourceVariantTreeSubscriber.java
org.eclipse.egit.core/src/org/eclipse/egit/core/synchronize/GitRemoteFolder.java
org.eclipse.egit.core/src/org/eclipse/egit/core/synchronize/GitResourceVariantTree.java
org.eclipse.egit.core/src/org/eclipse/egit/core/synchronize/GitResourceVariantTreeSubscriber.java
org.eclipse.egit.core/src/org/eclipse/egit/core/synchronize/dto/GitSynchronizeDataSet.java
org.eclipse.egit.mylyn.ui/src/org/eclipse/egit/internal/mylyn/ui/CommitHyperlinkDetector.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/TestUtil.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/synchronize/MockLogicalResourceMapping.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIUtils.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/PushMenu.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/RepositoryActionHandler.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/BranchProjectTracker.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitCreateProjectViaWizardWizard.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitImportWizard.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/clone/GitProjectsImportPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitProposalProcessor.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/CommitUI.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/DiffEditorPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/DiffViewer.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commit/StashEditorPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/CachedCheckboxTreeViewer.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositoryMenuUtil.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/decorators/GitDocument.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/decorators/ProblemLabelDecorator.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CompareTreeView.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/HyperlinkTokenScanner.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitFileDiffViewer.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitMessageViewer.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitSelectionDialog.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/HistoryPageInput.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/merge/GitCompareEditorInput.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/merge/MergeResultDialog.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/operations/GitScopeUtil.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/ConfigurationEditorComponent.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/GlobalConfigurationPreferencePage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/pull/PullOperationUI.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushTagsPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushToGerritPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/RefUpdateElement.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoriesView.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoryDragAssistant.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoryRemotePropertySource.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/SynchronizeCommand.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/selection/SelectionUtils.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronize.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronizeParticipant.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitSynchronizeWizardPage.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/ModelAwareGitSynchronizer.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/mapping/GitContainerMapping.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/mapping/GitTreeTraversal.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelRepository.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelRoot.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelTree.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/model/TreeBuilder.java