| commit | 54e713d2384c884aa98166a2ae76da36652eabe7 | |
| author | Thomas Wolf <thomas.wolf@paranor.ch> | |
| Tue, 1 Nov 2016 22:13:38 +0000 (1 23:13 +0100) | ||
| committer | Thomas Wolf <thomas.wolf@paranor.ch> | |
| Wed, 2 Nov 2016 09:02:32 +0000 (2 05:02 -0400) | ||
| tree | e792669d6867186bd79e2c1e440b9ec5e462a2de | treesnapshot (tar.gz zip) |
| parent | e79fb01386d432d635f482b7e0d3930426b1ed8a | commitdiff |
Handle MultiPageEditorParts in BlameOperation
In commit c72723a some calls to
RevisionAnnotationController.openEditor() were replaced because they
created the wrong kind of FileRevisionEditorInput.
Turns out that the replacement wasn't good; IDE.openEditor returns the
MultiPageEditorPart, not the nested AbstractDecoratedTextEditor.
Re-introduce RevisionAnnotationController for the IFile case, use our
own utils only for the IFileRevision case, and do handle multi-page
editors explicitly in that case.
Bug: 506841
Change-Id: I8d952e5b2d9355f1460394018853220bcff869f1
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
In commit c72723a some calls to
RevisionAnnotationController.openEditor() were replaced because they
created the wrong kind of FileRevisionEditorInput.
Turns out that the replacement wasn't good; IDE.openEditor returns the
MultiPageEditorPart, not the nested AbstractDecoratedTextEditor.
Re-introduce RevisionAnnotationController for the IFile case, use our
own utils only for the IFileRevision case, and do handle multi-page
editors explicitly in that case.
Bug: 506841
Change-Id: I8d952e5b2d9355f1460394018853220bcff869f1
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
| org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/EgitUiEditorUtils.java | diffblobblamehistory | |
| org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/blame/BlameOperation.java | diffblobblamehistory |