Avoid opening dialogs from push/fetch background jobs
commit09e0d369d3721bb844e0f60355efccc52381d5be
authorThomas Wolf <thomas.wolf@paranor.ch>
Wed, 8 Jun 2016 20:10:35 +0000 (8 22:10 +0200)
committerAndrey Loskutov <loskutov@gmx.de>
Sat, 2 Jul 2016 16:10:40 +0000 (2 12:10 -0400)
tree402762b335eb7204c833dfe46cc236069f8c1f54
parentd9b1e9dab26b671d6d16c1dd04b04ae27be9aef3
Avoid opening dialogs from push/fetch background jobs

Doing so quite frequently led to UI deadlocks when modal dialogs were
active when the job's result dialog popped up. Instead use the progress
framework's mechanisms to give the user a possibility to open a job's
result dialog at his leisure. Thus there is no danger of conflicting
with any modal shells.

Push and fetch UI tests adapted to the new behavior.

Bug: 495512
Change-Id: I10f8df000fdfc4c91f3d5a9b75354caf2a37d876
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
13 files changed:
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/JobJoiner.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/team/actions/FetchAndMergeActionTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/test/team/actions/PushActionTest.java
org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewFetchAndPushTest.java
org.eclipse.egit.ui/META-INF/MANIFEST.MF
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/UIText.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/fetch/FetchOperationUI.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/jobs/RepositoryJob.java [new file with mode: 0644]
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/jobs/RepositoryJobResultAction.java [new file with mode: 0644]
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushOperationUI.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushWizard.java
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/ShowPushResultAction.java [new file with mode: 0644]
org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties