From fe29b85a8f3e6ce384bc301af6c6536784f96136 Mon Sep 17 00:00:00 2001 From: Robin Rosenberg Date: Tue, 14 Apr 2009 01:26:01 +0200 Subject: [PATCH] Add some logging of GUI errors Though, hopefully rare, we might want to have errors logged. Signed-off-by: Robin Rosenberg Signed-off-by: Shawn O. Pearce --- .../spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java | 2 ++ .../src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java | 3 +++ 2 files changed, 5 insertions(+) diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java index 49d4a429..88c867d6 100644 --- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java +++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/GitCompareFileRevisionEditorInput.java @@ -35,6 +35,7 @@ import org.eclipse.team.internal.ui.history.FileRevisionTypedElement; import org.eclipse.team.internal.ui.synchronize.LocalResourceTypedElement; import org.eclipse.team.ui.synchronize.SaveableCompareEditorInput; import org.eclipse.ui.IWorkbenchPage; +import org.spearce.egit.core.Activator; /** * The input provider for the compare editor when working on resources @@ -327,6 +328,7 @@ public class GitCompareFileRevisionEditorInput extends SaveableCompareEditorInpu return TeamUIMessages.CompareFileRevisionEditorInput_1; } } catch (CoreException e) { + Activator.logError("Problem getting content identifier", e); } } else { return fileRevisionElement.getContentIdentifier(); diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java index e6bd02dd..ce7196fa 100644 --- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java +++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java @@ -59,6 +59,7 @@ import org.eclipse.team.core.history.IFileHistory; import org.eclipse.team.core.history.IFileRevision; import org.eclipse.team.internal.ui.history.FileRevisionTypedElement; import org.eclipse.ui.model.WorkbenchLabelProvider; +import org.spearce.egit.core.Activator; import org.spearce.egit.core.GitProvider; import org.spearce.egit.core.internal.storage.GitFileHistoryProvider; import org.spearce.egit.core.project.RepositoryMapping; @@ -434,6 +435,8 @@ public class CommitDialog extends Dialog { } } catch (Exception e) { + Activator.logError("Problem in finding file status", e); + prefix = e.getMessage(); } return prefix; -- 2.11.4.GIT