| commit | 71138b487a90ab1c156854426b38a1deeb42a709 | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Thu, 25 Dec 2008 02:11:05 +0000 (24 18:11 -0800) | ||
| committer | Robin Rosenberg <robin.rosenberg@dewire.com> | |
| Sun, 4 Jan 2009 00:01:53 +0000 (4 01:01 +0100) | ||
| tree | 9325862967f95112255c6ac2b3cba66ef13c7f8c | treesnapshot (tar.gz zip) |
| parent | 57c1cb250b54faef75135f2e33a3f6f1c6411895 | commitdiff |
Remove getId from ObjectLoader API as its unnecessary overhead
Apparently nobody actually requires the getId() method on an ObjectLoader.
In every single location where the getId() is being used the caller has
an AnyObjectId wich the proper value already in-scope, typically the value
they passed into Repository.openObject(). Avoiding having the id in the
loader API means PackFile doesn't have to copy a MutableObjectId into an
immutable ObjectId, saving an object allocation per object lookup.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
Apparently nobody actually requires the getId() method on an ObjectLoader.
In every single location where the getId() is being used the caller has
an AnyObjectId wich the proper value already in-scope, typically the value
they passed into Repository.openObject(). Avoiding having the id in the
loader API means PackFile doesn't have to copy a MutableObjectId into an
immutable ObjectId, saving an object allocation per object lookup.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>