| commit | 81e99965a7aab42532a9b5313c6c64b8272c436c | |
| author | Phy <git@phy25.com> | |
| Tue, 10 Mar 2020 00:10:54 +0000 (9 20:10 -0400) | ||
| committer | Phy <git@phy25.com> | |
| Tue, 10 Mar 2020 00:10:54 +0000 (9 20:10 -0400) | ||
| tree | dc471701e9e9d26e502f2bf139bdd5c5861ec9c2 | treesnapshot (tar.gz zip) |
| parent | 7a0b5f30c2d63a8e403568877b6f3f07db70bdd6 | commitdiff |
fallback to auth_login check when trustExternal returns null
This is a work based on #2701, Before this patch, it is either fully external, or fully internal (and DokuWiki's auth cookie mechanism is used in auth_login()). I believe we should provide plugin developers with a third state as out-put. Semantically $auth->trustExternal() === null to delegate auth flow back to DokuWiki makes sense to me - like no external auth result is returned, so we need to run internal auth flow.
Co-Authored-By: paweljasinski <paweljasinski@users.noreply.github.com>
This is a work based on #2701, Before this patch, it is either fully external, or fully internal (and DokuWiki's auth cookie mechanism is used in auth_login()). I believe we should provide plugin developers with a third state as out-put. Semantically $auth->trustExternal() === null to delegate auth flow back to DokuWiki makes sense to me - like no external auth result is returned, so we need to run internal auth flow.
Co-Authored-By: paweljasinski <paweljasinski@users.noreply.github.com>
| inc/Extension/AuthPlugin.php | diffblobblamehistory | |
| inc/Remote/ApiCore.php | diffblobblamehistory | |
| inc/auth.php | diffblobblamehistory |