From fb74dfd42d1ccbbf6184657c08e7971288d30aee Mon Sep 17 00:00:00 2001 From: mhagger Date: Tue, 1 Jul 2014 09:48:31 +0000 Subject: [PATCH] InitializeChangesetsPass: Fully initialize breaks array before continuing. This makes the logic clearer. git-svn-id: http://cvs2svn.tigris.org/svn/cvs2svn/trunk@5453 be7e6eca-30d4-0310-a8e5-ac0d63af7087 --- cvs2svn_lib/passes.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cvs2svn_lib/passes.py b/cvs2svn_lib/passes.py index 7f8ddbc8..424dab92 100644 --- a/cvs2svn_lib/passes.py +++ b/cvs2svn_lib/passes.py @@ -689,6 +689,7 @@ class InitializeChangesetsPass(Pass): indexes = {} for (i, changeset_item) in enumerate(changeset_items): indexes[changeset_item.id] = i + # How many internal dependencies would be broken by breaking the # Changeset after a particular index? breaks = [0] * len(changeset_items) @@ -697,11 +698,12 @@ class InitializeChangesetsPass(Pass): succ_index = indexes[succ] breaks[min(pred_index, succ_index)] += 1 breaks[max(pred_index, succ_index)] -= 1 + for i in range(1, len(breaks)): + breaks[i] += breaks[i - 1] + best_i = None best_count = -1 best_time = 0 - for i in range(1, len(breaks)): - breaks[i] += breaks[i - 1] for i in range(0, len(breaks) - 1): if breaks[i] > best_count: best_i = i -- 2.11.4.GIT