From 7223651ad194a5868b58c1be6c7452fd3ca2f75a Mon Sep 17 00:00:00 2001
From: =?utf8?q?P=C3=A1draig=20Brady?= <P@draigBrady.com>
Date: Tue, 2 May 2023 22:39:03 +0100
Subject: [PATCH] tests: provide more info on DEBUG=yes

* README: State that DEBUG=yes is particularly useful with perl tests.
* tests/split/l-chunk.sh: Use the more standard $DEBUG variable
rather than an internal $DEBUGGING variable.
---
 README                 | 4 ++--
 tests/split/l-chunk.sh | 9 ++++-----
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/README b/README
index e90940b94..363155a37 100644
--- a/README
+++ b/README
@@ -96,8 +96,8 @@ run this command:
 
   make check TESTS=tests/df/df-P.sh VERBOSE=yes SUBDIRS=. >> log 2>&1
 
-For some tests, you can get even more detail by adding DEBUG=yes.
-Then include the contents of the file 'log' in your bug report.
+For some tests, particularly perl tests, you can get even more detail by adding
+DEBUG=yes. Then include the contents of the file 'log' in your bug report.
 
 
 ***************************************
diff --git a/tests/split/l-chunk.sh b/tests/split/l-chunk.sh
index 2c287ee9f..bc9ad122c 100755
--- a/tests/split/l-chunk.sh
+++ b/tests/split/l-chunk.sh
@@ -72,12 +72,11 @@ printf '%s' "\
 
 sed 's/00 *//g' exp > exp.elide_empty || framework_failure_
 
-DEBUGGING=
-test "$DEBUGGING" && test "$VERBOSE" && set +x
+test "$DEBUG" && test "$VERBOSE" && set +x
 for ELIDE_EMPTY in '' '-e'; do
   for IO_BLKSIZE in 1 2 5 10 80 100; do
     > out
-    test "$DEBUGGING" && printf "\n---io-blk-size=$IO_BLKSIZE $ELIDE_EMPTY\n"
+    test "$DEBUG" && printf "\n---io-blk-size=$IO_BLKSIZE $ELIDE_EMPTY\n"
     for N in 6 8 12 15 22; do
       rm -f x*
 
@@ -93,7 +92,7 @@ for ELIDE_EMPTY in '' '-e'; do
         compare chunk.k xab || fail=1
       fi
 
-      if test "$DEBUGGING"; then
+      if test "$DEBUG"; then
         # Output partition pattern
         size=$(printf "%s" "$lines" | wc -c)
         chunk_size=$(($size/$N))
@@ -120,7 +119,7 @@ for ELIDE_EMPTY in '' '-e'; do
     compare out $EXP || fail=1
   done
 done
-test "$DEBUGGING" && test "$VERBOSE" && set -x
+test "$DEBUG" && test "$VERBOSE" && set -x
 
 
 # Check extraction of particular chunks
-- 
2.11.4.GIT