| commit | e7b4bf4b57efb699c87f03c1173d812ea34cb618 | |
| author | Jim Meyering <meyering@redhat.com> | |
| Wed, 1 Jun 2011 11:48:12 +0000 (1 13:48 +0200) | ||
| committer | Jim Meyering <meyering@redhat.com> | |
| Wed, 1 Jun 2011 11:49:04 +0000 (1 13:49 +0200) | ||
| tree | 6c8b4463f5e6354d79c61d8d7fbcd87cd1c65c5a | treesnapshot (tar.gz zip) |
| parent | c1716a1ebf55b1d43e64b880ff0ec6f73d2f05c5 | commitdiff |
tail: fix an inconsequential bug spotted by coverity
* src/tail.c (start_bytes): Increase *READ_POS (not READ_POS)
by the number of bytes read. This is a real bug that happens
to have no consequence in practice. First, this code is exercised
only when tailing-forever a non-regular file by bytes, and with a
start-relative offset, e.g., "mkfifo f; tail -f -c +3 f", but even
then, the invalid READ_POS value does not influence how tail works.
It is stored in the File_spec.size member, but that member is not
used at all in tail_forever_inotify, and in tail_forever, it is
used only when the File_spec refers to a regular file.
* src/tail.c (start_bytes): Increase *READ_POS (not READ_POS)
by the number of bytes read. This is a real bug that happens
to have no consequence in practice. First, this code is exercised
only when tailing-forever a non-regular file by bytes, and with a
start-relative offset, e.g., "mkfifo f; tail -f -c +3 f", but even
then, the invalid READ_POS value does not influence how tail works.
It is stored in the File_spec.size member, but that member is not
used at all in tail_forever_inotify, and in tail_forever, it is
used only when the File_spec refers to a regular file.
| src/tail.c | diffblobblamehistory |