| commit | bf7b0e0358bc79141abdd4d974270fbc6bfcba27 | |
| author | Stefano Lattarini <stefano.lattarini@gmail.com> | |
| Fri, 15 Feb 2013 13:39:39 +0000 (15 14:39 +0100) | ||
| committer | Pádraig Brady <P@draigBrady.com> | |
| Mon, 18 Feb 2013 01:27:47 +0000 (18 01:27 +0000) | ||
| tree | e81f717d9ff867937bb752fa76ee40df11ad8a98 | treesnapshot (tar.gz zip) |
| parent | c53c5e2395d206a1ab2c821eed8414270fbc07b4 | commitdiff |
maint: don't reset PATH in the commit-msg git hook
I have a custom 'editor' script in ~/bin, and a system-provided
'editor' program in /usr/bin (on Debian, this is a link set up the
"debian alternatives" subsystem). My '$EDITOR' and '$GIT_EDITOR'
variables are set simply to 'editor' (no absolute path), which I
expect should point to my 'editor' script, since ~/bin precedes
/usr/bin in my PATH definition. But the 'commit-msg' hook used in
coreutils unconditionally resets its PATH to '/bin:/usr/bin', which
causes it to call the "wrong" editor (the one in /usr/bin, not the
one in ~/bin) when it makes me update a botched commit message.
* scripts/git-hooks: Don't reset $ENV{PATH} to '/bin:/usr/bin',
which was only done to avoid failure when enabling Perl's taint
checking.
I have a custom 'editor' script in ~/bin, and a system-provided
'editor' program in /usr/bin (on Debian, this is a link set up the
"debian alternatives" subsystem). My '$EDITOR' and '$GIT_EDITOR'
variables are set simply to 'editor' (no absolute path), which I
expect should point to my 'editor' script, since ~/bin precedes
/usr/bin in my PATH definition. But the 'commit-msg' hook used in
coreutils unconditionally resets its PATH to '/bin:/usr/bin', which
causes it to call the "wrong" editor (the one in /usr/bin, not the
one in ~/bin) when it makes me update a botched commit message.
* scripts/git-hooks: Don't reset $ENV{PATH} to '/bin:/usr/bin',
which was only done to avoid failure when enabling Perl's taint
checking.
| scripts/git-hooks/commit-msg | diffblobblamehistory |