| commit | 58cff8a009ed9b8280c5f35074cef97231286023 | |
| author | Pádraig Brady <P@draigBrady.com> | |
| Tue, 13 Jan 2015 03:30:33 +0000 (13 03:30 +0000) | ||
| committer | Pádraig Brady <P@draigBrady.com> | |
| Wed, 14 Jan 2015 12:20:32 +0000 (14 12:20 +0000) | ||
| tree | 771e8b3fa70fab99b548790931803b75dd272603 | treesnapshot (tar.gz zip) |
| parent | 924b1cadff3f2782475516d7eca9aabe856dbf0f | commitdiff |
tests: add extra protection against unexpected exits
Many tests use `program ... && fail=1` to ensure expected
error situations are indicated. However that would mask
an unexpected exit (like a crash). Therefore explicitly
check the expected exit code.
Note where error messages are also verified, the extra
protection is not added.
* tests/init.sh (returns_): A new helper function to
check the return code of a command, and used
throughout the tests.
* cfg.mk (sc_prohibit_and_fail_1): Add a syntax check
to avoid new instances of this issue.
Many tests use `program ... && fail=1` to ensure expected
error situations are indicated. However that would mask
an unexpected exit (like a crash). Therefore explicitly
check the expected exit code.
Note where error messages are also verified, the extra
protection is not added.
* tests/init.sh (returns_): A new helper function to
check the return code of a command, and used
throughout the tests.
* cfg.mk (sc_prohibit_and_fail_1): Add a syntax check
to avoid new instances of this issue.
93 files changed: