From a5061f8f5772e59725c8e89e02b9dff10735e915 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Mon, 14 Jun 2021 17:12:58 +0200 Subject: [PATCH] tpm/tss: Remove local variable Depending on how the "middle-end" (yes, the gcc developers are serious about that) optimizer ends up mangling the code, there may or may not be a complaint about x being used uninitialized when it's clearly not used at all. So instead, why keep x in the first place? memcpy(foo, NULL, 0) is the same as memcpy(foo, some_uninitialized_variable, 0) in that it does nothing. Change-Id: Ib0a97c3e3fd1a2a6aff37da63376373c88ac595d Signed-off-by: Patrick Georgi Reviewed-on: https://review.coreboot.org/c/coreboot/+/55499 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/security/tpm/tss/tcg-1.2/tss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/security/tpm/tss/tcg-1.2/tss.c b/src/security/tpm/tss/tcg-1.2/tss.c index 413b68193f..52bc2722b2 100644 --- a/src/security/tpm/tss/tcg-1.2/tss.c +++ b/src/security/tpm/tss/tcg-1.2/tss.c @@ -327,9 +327,8 @@ uint32_t tlcl_get_flags(uint8_t *disable, uint8_t *deactivated, uint32_t tlcl_set_global_lock(void) { - uint32_t x; VBDEBUG("TPM: Set global lock\n"); - return tlcl_write(TPM_NV_INDEX0, (uint8_t *) &x, 0); + return tlcl_write(TPM_NV_INDEX0, NULL, 0); } uint32_t tlcl_extend(int pcr_num, const uint8_t *in_digest, -- 2.11.4.GIT