From 790534104af5a5b84ac5ecd721aa8774c2f40ca3 Mon Sep 17 00:00:00 2001 From: Raul E Rangel Date: Mon, 6 Aug 2018 10:40:02 -0600 Subject: [PATCH] soc/amd/stoneyridge: Prevent reboot in romstage By setting this register in bootblock AmdInitEnv will no longer trigger a reset in romstage. This fixes a few vboot test failures and also speeds up boot time. BUG=b:111610455 TEST=Built grunt and made sure bootblock only happens once on cold boot, and S3 resume. Change-Id: Ie19f7a14deaef45ac63156bec6946273c1b9447e Signed-off-by: Raul E Rangel Reviewed-on: https://review.coreboot.org/27876 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/soc/amd/stoneyridge/southbridge.c | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c index 348d5f15a3..a6219b4b5c 100644 --- a/src/soc/amd/stoneyridge/southbridge.c +++ b/src/soc/amd/stoneyridge/southbridge.c @@ -556,7 +556,7 @@ static void sb_lpc_early_setup(void) } } -static void setup_spread_spectrum(void) +static void setup_spread_spectrum(int *reboot) { uint16_t rstcfg = pm_read16(PWR_RESET_CFG); @@ -606,11 +606,25 @@ static void setup_spread_spectrum(void) cntl1 |= CG1PLL_FBDIV_TEST; misc_write32(MISC_CLK_CNTL1, cntl1); - soft_reset(); + *reboot = 1; +} + +static void setup_misc(int *reboot) +{ + /* Undocumented register */ + uint32_t reg = misc_read32(0x50); + if (!(reg & BIT(16))) { + reg |= BIT(16); + + misc_write32(0x50, reg); + *reboot = 1; + } } void bootblock_fch_early_init(void) { + int reboot = 0; + sb_enable_rom(); sb_lpc_port80(); sb_lpc_decode(); @@ -619,7 +633,12 @@ void bootblock_fch_early_init(void) sb_disable_4dw_burst(); /* Must be disabled on CZ(ST) */ sb_acpi_mmio_decode(); sb_enable_cf9_io(); - setup_spread_spectrum(); + setup_spread_spectrum(&reboot); + setup_misc(&reboot); + + if (reboot) + soft_reset(); + sb_enable_legacy_io(); enable_aoac_devices(); } -- 2.11.4.GIT