From 5fa756cc97de1ed30ac3fd4d5ddb85f079efe521 Mon Sep 17 00:00:00 2001 From: Jacob Garber Date: Wed, 31 Jul 2019 12:23:51 -0600 Subject: [PATCH] util/cbfstool: Remove unused assignment This variable is overwritten on one branch of the next if statement, and the other branch returns, so this assignment does nothing. Change-Id: I63737929d47c882bbcf637182bc8bf73c19daa9f Signed-off-by: Jacob Garber Found-by: scan-build 8.0.0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/34644 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- util/cbfstool/ifittool.c | 1 - 1 file changed, 1 deletion(-) diff --git a/util/cbfstool/ifittool.c b/util/cbfstool/ifittool.c index 3b16c3fcf0..dce37c8084 100644 --- a/util/cbfstool/ifittool.c +++ b/util/cbfstool/ifittool.c @@ -336,7 +336,6 @@ int main(int argc, char *argv[]) case ADD_REGI_OP: { struct buffer region; - addr = 0; if (partitioned_file_read_region(®ion, image_file, name)) { addr = -convert_to_from_top_aligned(®ion, 0); -- 2.11.4.GIT