From 5213b193c7afb4d1790b2d1ed8d36a4b672dfef5 Mon Sep 17 00:00:00 2001 From: Elyes Haouas Date: Fri, 25 Feb 2022 18:13:03 +0100 Subject: [PATCH] nb/amd/*/*/northbridge.c: Change the comment 'hole from 0xa0000..' to reflect the code Signed-off-by: Elyes Haouas Change-Id: I4acc895be00cfdef3ff0eef440f4b85fdb75edf8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62378 Tested-by: build bot (Jenkins) Reviewed-by: Martin L Roth --- src/northbridge/amd/agesa/family14/northbridge.c | 2 +- src/northbridge/amd/agesa/family15tn/northbridge.c | 2 +- src/northbridge/amd/agesa/family16kb/northbridge.c | 2 +- src/northbridge/amd/pi/00730F01/northbridge.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c index 3507ff709b..e102252983 100644 --- a/src/northbridge/amd/agesa/family14/northbridge.c +++ b/src/northbridge/amd/agesa/family14/northbridge.c @@ -551,7 +551,7 @@ static void domain_set_resources(struct device *dev) printk(BIOS_DEBUG, "adsr: basek = %llx, limitk = %llx, sizek = %llx.\n", basek, limitk, sizek); - /* see if we need a hole from 0xa0000 to 0xbffff */ + /* See if we need a hole from 0xa0000 (640K) to 0xbffff (768K) */ if ((basek < 640) && (sizek > 768)) { printk(BIOS_DEBUG,"adsr - 0xa0000 to 0xbffff resource.\n"); ram_resource(dev, (idx | 0), basek, 640 - basek); diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c index d36c9d459d..8c010ee388 100644 --- a/src/northbridge/amd/agesa/family15tn/northbridge.c +++ b/src/northbridge/amd/agesa/family15tn/northbridge.c @@ -709,7 +709,7 @@ static void domain_set_resources(struct device *dev) sizek = limitk - basek; - /* see if we need a hole from 0xa0000 to 0xbffff */ + /* See if we need a hole from 0xa0000 (640K) to 0xbffff (768K) */ if ((basek < ((8*64)+(8*16))) && (sizek > ((8*64)+(16*16)))) { ram_resource(dev, (idx | i), basek, ((8*64)+(8*16)) - basek); idx += 0x10; diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c index 170a0d2ee2..a343321808 100644 --- a/src/northbridge/amd/agesa/family16kb/northbridge.c +++ b/src/northbridge/amd/agesa/family16kb/northbridge.c @@ -721,7 +721,7 @@ static void domain_set_resources(struct device *dev) sizek = limitk - basek; - /* see if we need a hole from 0xa0000 to 0xbffff */ + /* See if we need a hole from 0xa0000 (640K) to 0xbffff (768K) */ if ((basek < ((8*64)+(8*16))) && (sizek > ((8*64)+(16*16)))) { ram_resource(dev, (idx | i), basek, ((8*64)+(8*16)) - basek); idx += 0x10; diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c index 8a136b6be6..9889275758 100644 --- a/src/northbridge/amd/pi/00730F01/northbridge.c +++ b/src/northbridge/amd/pi/00730F01/northbridge.c @@ -810,7 +810,7 @@ static void domain_read_resources(struct device *dev) printk(BIOS_DEBUG, "node %d: basek=%08llx, limitk=%08llx, sizek=%08llx,\n", i, basek, limitk, sizek); - /* see if we need a hole from 0xa0000 to 0xfffff */ + /* See if we need a hole from 0xa0000 (640K) to 0xfffff (1024K) */ if ((basek < (0xa0000 >> 10) && (sizek > (0x100000 >> 10)))) { ram_resource(dev, (idx | i), basek, (0xa0000 >> 10) - basek); idx += 0x10; -- 2.11.4.GIT