| commit | f42da176de685ebc6432da1008c408876060dced | |
| author | Felix Held <felix-coreboot@felixheld.de> | |
| Tue, 1 Dec 2020 20:29:59 +0000 (1 21:29 +0100) | ||
| committer | Felix Held <felix-coreboot@felixheld.de> | |
| Wed, 2 Dec 2020 21:28:19 +0000 (2 21:28 +0000) | ||
| tree | 6d18b89d302265152c2c8ff1bececa45adfd6d20 | treesnapshot (tar.gz zip) |
| parent | 43a5f88bb428080ab6e361ef6bc5e92169ee8452 | commitdiff |
soc/amd/common/smbus: remove misleading definition
SMBHST_STAT_NOERROR was a redefinition of SMBHST_STAT_INTERRUPT that was
used in smbus_wait_until_done. Remove the misleading bit definition that
also didn't correspond with the register definitions and replace it with
the definition of the actual bit that gets checked. Also add a comment
that the code actually checks the IRQ status flag to see if the last
command is already completed.
Change-Id: I1a58fe0d58d3887dd2e83320e977a57e271685b3
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48219
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
SMBHST_STAT_NOERROR was a redefinition of SMBHST_STAT_INTERRUPT that was
used in smbus_wait_until_done. Remove the misleading bit definition that
also didn't correspond with the register definitions and replace it with
the definition of the actual bit that gets checked. Also add a comment
that the code actually checks the IRQ status flag to see if the last
command is already completed.
Change-Id: I1a58fe0d58d3887dd2e83320e977a57e271685b3
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48219
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
| src/soc/amd/common/block/include/amdblocks/smbus.h | diffblobblamehistory | |
| src/soc/amd/common/block/smbus/smbus.c | diffblobblamehistory |