| commit | f209b18df3b66d78a9838787182d40fc72eee010 | |
| author | Eric Lai <ericr_lai@compal.corp-partner.google.com> | |
| Mon, 19 Oct 2020 18:44:53 +0000 (20 02:44 +0800) | ||
| committer | Patrick Georgi <pgeorgi@google.com> | |
| Mon, 26 Oct 2020 06:44:02 +0000 (26 06:44 +0000) | ||
| tree | 69f27fbfb9c36cb15efb827bf9959b53ea57cd8b | treesnapshot (tar.gz zip) |
| parent | 7d1a137b845ad0b4d1aa1553070b26411b899cf6 | commitdiff |
mb/google/zork: Update style of check on cbi return values
Since google_chromeec_cbi_get_board_version and google_chromeec_cbi_get_fw_config both call cbi_get_unit32 and return 0 as success, non-zero as failure. Let's add more readability for the false condition.
BUG=None
TEST=check with empty CBI value
Signed-off-by: Eric Lai <ericr_lai@compal.corp-partner.google.com>
Change-Id: Ia49ac1ee35302f8f6afe8c0eb8e13afdf36c5b2b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46566
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Since google_chromeec_cbi_get_board_version and google_chromeec_cbi_get_fw_config both call cbi_get_unit32 and return 0 as success, non-zero as failure. Let's add more readability for the false condition.
BUG=None
TEST=check with empty CBI value
Signed-off-by: Eric Lai <ericr_lai@compal.corp-partner.google.com>
Change-Id: Ia49ac1ee35302f8f6afe8c0eb8e13afdf36c5b2b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46566
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>