| commit | e7de6fb162bb9a7c0551027514596d6d7f45421b | |
| author | Furquan Shaikh <furquan@google.com> | |
| Mon, 15 Aug 2016 04:50:50 +0000 (14 21:50 -0700) | ||
| committer | Furquan Shaikh <furquan@google.com> | |
| Wed, 17 Aug 2016 23:07:36 +0000 (18 01:07 +0200) | ||
| tree | 099481e2b4a8a0c8a2db1c9859c576c72b539801 | treesnapshot (tar.gz zip) |
| parent | 91f6e679ccce9cf90c98608fc2c24aef44db5bf0 | commitdiff |
intel/apollolake: Fix check for return value of pmc_gpe_route_to_gpio
pmc_gpe_route_to_gpio returns -1 on error. However, the value was being
stored in unsigned int and compared against -1. Fix this by using local
variable ret.
Change-Id: I5ec824949d4ee0fbdbb2ffdc9fc9d4762455b27b
Reported-by: Coverity ID 1357443, 1357442, 1357441
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/16218
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
pmc_gpe_route_to_gpio returns -1 on error. However, the value was being
stored in unsigned int and compared against -1. Fix this by using local
variable ret.
Change-Id: I5ec824949d4ee0fbdbb2ffdc9fc9d4762455b27b
Reported-by: Coverity ID 1357443, 1357442, 1357441
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/16218
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
| src/soc/intel/apollolake/gpio.c | diffblobblamehistory |