soc/intel/tigerlake: Clear RTC_BATTERY_DEAD
commite186821952ad7e2248d63ba21041fe84f756816e
authorTim Wawrzynczak <twawrzynczak@chromium.org>
Wed, 28 Jul 2021 17:30:59 +0000 (28 11:30 -0600)
committerPaul Fagerburg <pfagerburg@chromium.org>
Mon, 20 Sep 2021 15:44:07 +0000 (20 15:44 +0000)
tree6b96d9e4d056cb2b571c7a0c00fbd03d9e031c32
parent1a7640dc628c39b3af24983eb90474962c096119
soc/intel/tigerlake: Clear RTC_BATTERY_DEAD

Normally for vboot-enabled x86 board, the VBNV region is stored in CMOS
and backed up to flash (RW_NVRAM). However, on the very first boot after
a flash of the full SPI image (so RW_NVRAM is empty), if
RTC_BATTERY_DEAD is set, coreboot persistently requests recovery before
FSP-M finishes (which appears to be the current location that
RTC_BATTERY_DEAD is cleared on this platform). This is because
vbnv_cmos_failed() will still return 1. Therefore, immediately after
reading RTC_BATTERY_DEAD, it is cleared. This prevents an infinite boot
loop when trying to set the recovery mode bit.

Note that this was the behavior for previous generations of Intel PMC
programming as well (see southbridge/intel, soc/skylake, soc/broadwell,
etc).

BUG=b:181678769

Change-Id: Ie86822f22aa5899a7e446398370424ca5a4ca43d
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56669
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
src/soc/intel/tigerlake/pmutil.c