soc/amd/picasso: Move PMOD global variable to globalnvs.asl
commitdbac2b59128193b5c44b3587c75f09a560a2c426
authorFurquan Shaikh <furquan@google.com>
Tue, 14 Jul 2020 05:36:51 +0000 (13 22:36 -0700)
committerFurquan Shaikh <furquan@google.com>
Fri, 17 Jul 2020 18:29:37 +0000 (17 18:29 +0000)
tree9d5488f9c9daff3cda01c5c86706eea6e545403f
parentd2b173657a5d9a48f8ec4f3f2cabb02dc161171b
soc/amd/picasso: Move PMOD global variable to globalnvs.asl

Global variable `PMOD` that stores the interrupt mode used by OS is
required by all mainboards. This change moves the variable definition to
globalnvs.asl under picasso.

Additionally, ACPI spec says that BIOS should assume interrupt mode as PIC
until _PIC() method is called by OS. Thus, this change also updates the
default value of PMOD as 0 i.e. PIC mode.

BUG=b:153879530

Signed-off-by: Furquan Shaikh <furquan@google.com>
Change-Id: I731c03d965882281a7a23f55894451210ba72274
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43514
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
src/mainboard/amd/mandolin/acpi/mainboard.asl
src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl
src/soc/amd/picasso/acpi/globalnvs.asl