| commit | cbedae116cccbb6399f854d4392c28b710705323 | |
| author | Sean Rhodes <sean@starlabs.systems> | |
| Wed, 16 Aug 2023 08:25:42 +0000 (16 09:25 +0100) | ||
| committer | Felix Held <felix-coreboot@felixheld.de> | |
| Wed, 30 Aug 2023 14:11:44 +0000 (30 14:11 +0000) | ||
| tree | f708e6f16f7fd5318ac83d664a29ac767827870a | treesnapshot (tar.gz zip) |
| parent | 29514472085b43612abdb6ae50a0b46e4a60dec9 | commitdiff |
ec/starlabs/merlin: Unconditionally enable the Keyboard Backlight
KBL_STATE was originally intended to provide more granular control
of the keyboard backlight. However, KBL_BRIGHTNESS has a valid value
of "off" which achieves the same thing.
Therefore, unconditionally set the KBL_STATE to enabled, and rely on
KBL_BRIGHTNESS.
Change-Id: Ic7ee6b96b1dcaa6633b111e92097bce87908885e
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77201
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
KBL_STATE was originally intended to provide more granular control
of the keyboard backlight. However, KBL_BRIGHTNESS has a valid value
of "off" which achieves the same thing.
Therefore, unconditionally set the KBL_STATE to enabled, and rely on
KBL_BRIGHTNESS.
Change-Id: Ic7ee6b96b1dcaa6633b111e92097bce87908885e
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77201
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| src/ec/starlabs/merlin/ite.c | diffblobblamehistory | |
| src/ec/starlabs/merlin/nuvoton.c | diffblobblamehistory |