src/: Remove g_ prefixes and _g suffixes from variables
commitc9b13594eb8d425e54a126b5c10e3f6fbc41528b
authorPatrick Georgi <pgeorgi@google.com>
Fri, 29 Nov 2019 10:47:47 +0000 (29 11:47 +0100)
committerPatrick Georgi <pgeorgi@google.com>
Mon, 2 Dec 2019 10:44:38 +0000 (2 10:44 +0000)
treef120705f6eb4ddf6dd008e73bdbbd34ae17fbdc9
parentae64f22e8d5707ef715ad4bd01b6181653a3f9ca
src/: Remove g_ prefixes and _g suffixes from variables

These were often used to distinguish CAR_GLOBAL variables that weren't
directly usable. Since we're getting rid of this special case, also get
rid of the marker.

This change was created using coccinelle and the following script:
@match@
type T;
identifier old =~ "^(g_.*|.*_g)$";
@@
old

@script:python global_marker@
old << match.old;
new;
@@
new = old
if old[0:2] == "g_":
  new = new[2:]

if new[-2:] == "_g":
  new = new[:-2]

coccinelle.new = new

@@
identifier match.old, global_marker.new;
@@
- old
+ new

@@
type T;
identifier match.old, global_marker.new;
@@
- T old;
+ T new;

@@
type T;
identifier match.old, global_marker.new;
@@
- T old
+ T new
 = ...;

There were some manual fixups: Some code still uses the global/local
variable naming scheme, so keep g_* there, and some variable names
weren't completely rewritten.

Change-Id: I4936ff9780a0d3ed9b8b539772bc48887f8d5eed
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37358
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
17 files changed:
src/cpu/intel/common/fsb.c
src/cpu/x86/lapic/apic_timer.c
src/cpu/x86/tsc/delay_tsc.c
src/drivers/elog/elog.c
src/drivers/i2c/tpm/cr50.c
src/drivers/i2c/tpm/tis.c
src/drivers/i2c/tpm/tpm.c
src/drivers/pc80/pc/i8254.c
src/drivers/spi/flashconsole.c
src/drivers/spi/tpm/tpm.c
src/drivers/vpd/vpd.c
src/soc/intel/common/block/cse/cse.c
src/soc/nvidia/tegra/i2c.c
src/soc/nvidia/tegra/i2c.h
src/soc/nvidia/tegra124/i2c.c
src/soc/nvidia/tegra210/i2c.c
src/southbridge/intel/common/spi.c