| commit | c89099641ee2a8a33d9a92e11751915472e249ff | |
| author | Martin Roth <martinroth@google.com> | |
| Mon, 21 Dec 2015 20:14:58 +0000 (21 13:14 -0700) | ||
| committer | Martin Roth <martinroth@google.com> | |
| Tue, 22 Dec 2015 22:07:20 +0000 (22 23:07 +0100) | ||
| tree | 2421689ee9c96a5015ac92692fdd15ed6159b821 | treesnapshot (tar.gz zip) |
| parent | a4c57407527d8fcd9a3e6e06824b21eb85104b78 | commitdiff |
soc/intel/fsp_baytrail: Make sure i2c bus is < 7
Baytrail has I2c Busses 0 to 6, so is supposed to error out
if the I2c driver is called with 7 or greater. Due to an off-by-one
error it could be called with bus 7.
Fixes coverity warning:
CID 1287074 (#1 of 1): Out-of-bounds read (OVERRUN)
3. overrun-local: Overrunning array base_adr of 7 4-byte elements at
element index 7 (byte offset 28) using index bus (which evaluates to 7).
Change-Id: I7caec60298cf27bd669796e0e05e4a896f92befd
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/12781
Tested-by: build bot (Jenkins)
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Baytrail has I2c Busses 0 to 6, so is supposed to error out
if the I2c driver is called with 7 or greater. Due to an off-by-one
error it could be called with bus 7.
Fixes coverity warning:
CID 1287074 (#1 of 1): Out-of-bounds read (OVERRUN)
3. overrun-local: Overrunning array base_adr of 7 4-byte elements at
element index 7 (byte offset 28) using index bus (which evaluates to 7).
Change-Id: I7caec60298cf27bd669796e0e05e4a896f92befd
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/12781
Tested-by: build bot (Jenkins)
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
| src/soc/intel/fsp_baytrail/i2c.c | diffblobblamehistory |