device/oprom/realmode: Add vbe return status support as per VBE spec 3.0
commitc76bfac088021df631364a092fe12449ba916e30
authorSubrata Banik <subrata.banik@intel.com>
Fri, 12 Jul 2019 11:13:17 +0000 (12 16:43 +0530)
committerPatrick Georgi <pgeorgi@google.com>
Thu, 18 Jul 2019 16:12:05 +0000 (18 16:12 +0000)
treefa18cf6e820943a8844b36e03934013bb6e34c40
parent8950cfb66f8f1fd4b047fbef2347134be0aeacec
device/oprom/realmode: Add vbe return status support as per VBE spec 3.0

Existing coreboot oprom implementation relies on user selected
vesa mode through CONFIG_FRAMEBUFFER_VESA_MODE Kconfig option
and expects that all oprom might support user selected vesa mode.

Take an example:
Enabling AMD external radeon PCIE graphics card on ICLRVP with
default vesa mode 0x118. Unable to get valid X and Y resolution
after executing vbe_get_mode_info() with 0x4118, return data
buffer shows 0x0 resolution. It causes further hang while trying
to draw bmpblk image at depthcharge.

This patch checks for output register AH in all vbe function
(0x3 and 0x4f00/1/2) and die() if returns error.

Change-Id: Iacd2ce468e038a14424f029df3a0adec3e5fa15c
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33737
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
src/device/oprom/realmode/x86.c
src/device/oprom/realmode/x86.h
src/device/oprom/realmode/x86_asm.S