| commit | b14e04bd7c492a551532dc3678a1cc922b3cedf8 | |
| author | Marshall Dawson <marshalldawson3rd@gmail.com> | |
| Wed, 28 Jun 2017 00:40:09 +0000 (27 18:40 -0600) | ||
| committer | Martin Roth <martinroth@google.com> | |
| Thu, 27 Jul 2017 21:31:26 +0000 (27 21:31 +0000) | ||
| tree | ee14c76b3c2b5c9b324179a24e6d74bd6d4e1b0f | treesnapshot (tar.gz zip) |
| parent | e7557ded6998b334e3070a00a54a1989981d37b5 | commitdiff |
soc/amd/stoneyridge: Remove unused SD controller
Remove the unused support code from the old multi-device hudson
SD controller. The binaryPI blob contains the correct steps
for setting up SD and the public BKDG doesn't completely document
the controller.
The sd.c file was using device IDs not associated with the Stoney
Ridge APU. The hudson_enable() code removed was also looking for
incorrect device IDs and the PM_MANUAL_RESET register doesn't
behave as the source indicates.
The SD default settings may be overridden. Future improvements
may include a few Kconfig options and a weak call to the mainboard
for overriding additional defaults.
BUG=chrome-os-partner:62580062
Change-Id: I7dbd70320740e8a05e6bf16af125d67012f20674
Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-on: https://review.coreboot.org/20401
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Remove the unused support code from the old multi-device hudson
SD controller. The binaryPI blob contains the correct steps
for setting up SD and the public BKDG doesn't completely document
the controller.
The sd.c file was using device IDs not associated with the Stoney
Ridge APU. The hudson_enable() code removed was also looking for
incorrect device IDs and the PM_MANUAL_RESET register doesn't
behave as the source indicates.
The SD default settings may be overridden. Future improvements
may include a few Kconfig options and a weak call to the mainboard
for overriding additional defaults.
BUG=chrome-os-partner:62580062
Change-Id: I7dbd70320740e8a05e6bf16af125d67012f20674
Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-on: https://review.coreboot.org/20401
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
| src/soc/amd/stoneyridge/Makefile.inc | diffblobblamehistory | |
| src/soc/amd/stoneyridge/hudson.c | diffblobblamehistory | |
| src/soc/amd/stoneyridge/sd.c | [deleted file] | blobblamehistory |