| commit | afb60e7112d44d7b38226554bef366503f59d5c5 | |
| author | Angel Pons <th3fanbus@gmail.com> | |
| Tue, 10 Nov 2020 16:10:01 +0000 (10 17:10 +0100) | ||
| committer | Patrick Georgi <pgeorgi@google.com> | |
| Mon, 30 Nov 2020 07:56:35 +0000 (30 07:56 +0000) | ||
| tree | af8708139e32cb38f356ba33d4e15466072bf0d2 | treesnapshot (tar.gz zip) |
| parent | c19a9a52783f7ed14fbe5beb7f1be15706222578 | commitdiff |
mb/siemens/mc_apl1: Simplify is_mac_adr_valid() logic
A MAC address that is neither 00:00:00:00:00:00 nor ff:ff:ff:ff:ff:ff is
considered valid. Instead of using a temporary buffer and memcmp(), use
a single loop that exits as soon as the MAC cannot possibly be invalid.
Change-Id: I2b15b510092860fbbefd150c9060da38aeb13311
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47405
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-by: Uwe Poeche <uwe.poeche@siemens.com>
A MAC address that is neither 00:00:00:00:00:00 nor ff:ff:ff:ff:ff:ff is
considered valid. Instead of using a temporary buffer and memcmp(), use
a single loop that exits as soon as the MAC cannot possibly be invalid.
Change-Id: I2b15b510092860fbbefd150c9060da38aeb13311
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47405
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-by: Uwe Poeche <uwe.poeche@siemens.com>
| src/mainboard/siemens/mc_apl1/mainboard.c | diffblobblamehistory |