soc/amd/common: Drop ACPIMMIO bank for SMBus device PCI config
commita0b92b019f3a8712b8ffdc56a771d03def1fc08d
authorKyösti Mälkki <kyosti.malkki@gmail.com>
Thu, 18 Jun 2020 20:04:33 +0000 (18 23:04 +0300)
committerFelix Held <felix-coreboot@felixheld.de>
Sat, 20 Aug 2022 04:31:08 +0000 (20 04:31 +0000)
tree5e34487195316721d726ee9d647405cb33baddfa
parenta21a738cce29f9810c1c05a7311648b1906c2bba
soc/amd/common: Drop ACPIMMIO bank for SMBus device PCI config

The PCI config space of the SMBus device has a secondary mapping as an
ACPIMMIO bank. Since the PCI device is on bus 0, it's already available
early in boot after the enable_pci_mmconf call, so there's no need to
use the ACPIMMIO mapping instead of the PCI config space mapping.
Verstage on PSP could theoretically access the PCI config space via the
0xcf8/0xcfc register pair, but since verstage on PSP doesn't have the
ACPIMMIO mapping anyway, we won't loose any functionality here.

Change-Id: I5c8ce8de0a6ab0ed41e7e8a5980d0f0510aaa993
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42685
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
src/soc/amd/common/block/acpimmio/mmio_util.c
src/soc/amd/common/block/include/amdblocks/acpimmio.h