Intel BD82x6x: LPC: Unify I/O APIC setup
commit9c50e6a4a071a03c4dedd8eb87022644e9ee74c3
authorPaul Menzel <paulepanter@users.sourceforge.net>
Fri, 3 May 2013 10:23:39 +0000 (3 12:23 +0200)
committerAlexandru Gagniuc <mr.nuke.me@gmail.com>
Mon, 3 Jun 2013 06:21:54 +0000 (3 08:21 +0200)
tree32dfc65e3a630e1dc2d80e0e361037050c5aadad
parent42409e87322e974e81db9e0ac8b454e205fe8d3b
Intel BD82x6x: LPC: Unify I/O APIC setup

Remove local copies of reading and writing I/O APIC registers by
using already available functions.

This change is similar to

    commit db4f875a412e6c41f48a86a79b72465f6cd81635
    Author: Kyösti Mälkki <kyosti.malkki@gmail.com>
    Date:   Tue Jan 31 17:24:12 2012 +0200

        IOAPIC: Divide setup_ioapic() in two parts.

        Reviewed-on: http://review.coreboot.org/300

and

    commit e614353194c712a40aa8444a530b2062876eabe3
    Author: Kyösti Mälkki <kyosti.malkki@gmail.com>
    Date:   Tue Feb 26 17:24:41 2013 +0200

        Unify setting 82801a/b/c/d IOAPIC ID

        Reviewed-on: http://review.coreboot.org/2532

and uses `io_apic_read()` and `io_apic_write()` too. Define
`ACPI_EN` in the header file `pch.h`.

As commented by Aaron Durbin, a separate `pch_enable_acpi()` is
not needed: “The existing code path *in this file* is about enabling
the io apic.” [1].

[1] http://review.coreboot.org/#/c/3182/4/src/southbridge/intel/lynxpoint/lpc.c

Change-Id: I4478b1902d09061ca1db8eab6b71fef388c7a74c
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/3183
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@google.com>
src/southbridge/intel/bd82x6x/lpc.c
src/southbridge/intel/bd82x6x/pch.h