| commit | 8aa210bbf0343b1da1ab4e164c22da13c985a796 | |
| author | Aaron Durbin <adurbin@chromium.org> | |
| Fri, 8 Feb 2013 22:14:07 +0000 (8 16:14 -0600) | ||
| committer | Ronald G. Minnich <rminnich@gmail.com> | |
| Sun, 17 Mar 2013 21:50:04 +0000 (17 22:50 +0100) | ||
| tree | fb5e21ccfe5f93a5003e32971c38c52521f471cc | treesnapshot (tar.gz zip) |
| parent | 058d70f163e1a46e16d8577de4e612af04b9aeca | commitdiff |
bd82x6x: don't use absolute symbols
objcopy -B provides symbols of the form _binary_<name>_(start|end|size).
However, the _size variant is an absoult symbol. If one wants to
relocate the smi loading the _size symbol will be relocated which is
wrong since it is suppose to be a fixed size. There is no way to
distinguish symbols that shouldn't be relocated vs ones that can.
Instead use the _start and _end variants to determine the size.
Change-Id: I55192992cf36f62a9d8dd896e5fb3043a3eacbd3
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/2760
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
objcopy -B provides symbols of the form _binary_<name>_(start|end|size).
However, the _size variant is an absoult symbol. If one wants to
relocate the smi loading the _size symbol will be relocated which is
wrong since it is suppose to be a fixed size. There is no way to
distinguish symbols that shouldn't be relocated vs ones that can.
Instead use the _start and _end variants to determine the size.
Change-Id: I55192992cf36f62a9d8dd896e5fb3043a3eacbd3
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/2760
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
| src/southbridge/intel/bd82x6x/smi.c | diffblobblamehistory |