sar: Fix semantics of `get_wifi_sar_cbfs_filename()`
commit7fe5d3d382e25fbdd5026c8e0231dc5a10b57931
authorFurquan Shaikh <furquan@google.com>
Sun, 14 Mar 2021 06:54:16 +0000 (13 22:54 -0800)
committerPatrick Georgi <pgeorgi@google.com>
Wed, 17 Mar 2021 07:56:13 +0000 (17 07:56 +0000)
treef97fe6e53afe9ff6f61eee4303cd8b5377c7e87d
parent31f6320afeedfe622b0af51360078be28d26e378
sar: Fix semantics of `get_wifi_sar_cbfs_filename()`

Currently, if `get_wifi_sar_cbfs_filename()` returns NULL, then
`get_wifi_sar_limits()` assumes that the default filename is used for
CBFS SAR file. This prevents a board from supporting different models
using the same firmware -- some which require SAR support and some
which don't.

This change updates the logic in `get_wifi_sar_limits()` to return
early if filename is not provided by the mainboard. In order to
maintain the same logic as before, current mainboards are updated to
return WIFI_SAR_CBFS_DEFAULT_FILENAME instead of NULL in default
case.

Change-Id: I68b5bdd213767a3cd81fe41ace66540acd68e26a
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51485
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
18 files changed:
src/include/sar.h
src/mainboard/google/dedede/variants/drawcia/variant.c
src/mainboard/google/dedede/variants/galtic/variant.c
src/mainboard/google/dedede/variants/madoo/variant.c
src/mainboard/google/dedede/variants/magolor/variant.c
src/mainboard/google/hatch/variants/dratini/variant.c
src/mainboard/google/hatch/variants/kindred/variant.c
src/mainboard/google/octopus/variants/bloog/variant.c
src/mainboard/google/octopus/variants/bobba/variant.c
src/mainboard/google/octopus/variants/casta/variant.c
src/mainboard/google/octopus/variants/fleex/variant.c
src/mainboard/google/octopus/variants/foob/variant.c
src/mainboard/google/octopus/variants/meep/variant.c
src/mainboard/google/octopus/variants/phaser/mainboard.c
src/mainboard/google/poppy/variants/rammus/mainboard.c
src/mainboard/google/volteer/variants/lindar/variant.c
src/mainboard/google/zork/variants/vilboz/variant.c
src/vendorcode/google/chromeos/sar.c