soc/intel/skylake: Factor out unnecessary if-else-block
commit736de9f2466a08d563cc9ed29c76d9d5f0cc2440
authorFelix Singer <felixsinger@posteo.net>
Tue, 11 Aug 2020 05:49:55 +0000 (11 07:49 +0200)
committerMichael Niewöhner <c0d3z3r0@review.coreboot.org>
Fri, 14 Aug 2020 21:00:33 +0000 (14 21:00 +0000)
tree5a6b0c4eac6b24cc5b4bc65f5df5130e392984ce
parent4e9687c4162257f52e1b19283e6f5bbe3244b9ed
soc/intel/skylake: Factor out unnecessary if-else-block

Move InternalGfx config option out of the if-else-block and replace the
left over config option IgdDvmt50PreAlloc by a ternary expression. Also,
adjust related code comments to fit the new logic of this code.

This changes the logic of the code, since InternalGfx is configured
first and IgdDvmt50PreAlloc depends on its value. The negation in the
ternary expression is removed to improve the readability.

Change-Id: I89ff17f4574a7ade228c1791f17ea072fb731775
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44369
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michael Niewöhner
src/soc/intel/skylake/romstage/romstage.c