libpayload: Split EHCI bulk transfers on packet boundaries over qTDs
commit69eea7c01af0ce095aa7618eadae72e86f6eebbe
authorJulius Werner <jwerner@chromium.org>
Sat, 12 Jan 2013 00:25:52 +0000 (11 16:25 -0800)
committerRonald G. Minnich <rminnich@gmail.com>
Wed, 13 Mar 2013 22:08:11 +0000 (13 23:08 +0100)
treeaa8da537c37121dc0817462e5a78417ede0d6728
parent716375dd3ee8ec695c38b2ab25e714a0cc116fb0
libpayload: Split EHCI bulk transfers on packet boundaries over qTDs

EHCI controllers see transfers as a queue of transfer descriptors
(qTDs), each of which can represent an aligned area of up to 20KB. Each
qTD is processed separately, which means that a single USB packet cannot
span multiple qTDs.

While this should not be a problem according to the specification, some
USB storage devices seem to get confused when a packet in the middle of
a transfer is smaller than the maximum packet size (512 bytes) due to
falling on a qTD boundary. This patch aligns the total transfer length
per qTD to 512 bytes to avoid that problem (any excess bytes will simply
roll over to the next qTD).

Change-Id: I0b5db07507699a3861b30c1a5ee774c45dda7fdd
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: http://review.coreboot.org/2651
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
payloads/libpayload/drivers/usb/ehci.c